[jira] [Comment Edited] (HBASE-14093) deduplicate copies of bootstrap files

["Tamas Penzes (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-14093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16209573#comment-16209573 ] 

Tamas Penzes edited comment on HBASE-14093 at 10/18/17 6:27 PM:
----------------------------------------------------------------

Hi [~mdrob],

Looks like I have misunderstand you. I've thought you want to move the download to hbase-assembly, which I would not do, but you only want to spare the move task from the download/extract/move.

I've checked it, and I would also not work. If we extract the webjars directly we get a different directory structure, which includes bootstrap/jquery version number.
Please check direct_extract.log and indirect_extract.log attached to the ticket.
This is why I have to extract it to a tmp dir and only copy the relevant part to the final place.

Thanks, Tamaas


was (Author: tamaas):
Hi [~mdrob],

Looks like I have misunderstand you. I've thought you want to move the download to hbase-assembly, which I would not do, but you only want to spare the move task from the download/extract/move.

I'll do a fix soon.

Regards, Tamaas

> deduplicate copies of bootstrap files
> -------------------------------------
>
>                 Key: HBASE-14093
>                 URL: https://issues.apache.org/jira/browse/HBASE-14093
>             Project: HBase
>          Issue Type: Improvement
>          Components: build
>            Reporter: Sean Busbey
>            Assignee: Tamas Penzes
>              Labels: beginner
>             Fix For: 2.0.0
>
>         Attachments: HBASE-14093.master.001.patch, HBASE-14093.master.002.patch, HBASE-14093.master.002.patch, HBASE-14093.master.003.patch, HBASE-14093.master.003.patch, HBASE-14093.master.004.patch, direct_extract.log, indirect_extract.log, patch-shadedjars.txt
>
>
> right now we have a couple of different copies of the bootstrap js and css files. It'll be easier to maintain them later if we can centralize.
> Move them to a common location and use maven to populate them as needed in various component build directories.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)