You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@hive.apache.org by hongtaq zhao <ho...@126.com> on 2017/07/31 09:42:29 UTC

Review Request 61250: HIVE-17211:SQLStdHiveAccessController.showPrivileges Method may encountered Null pointer

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61250/
-----------------------------------------------------------

Review request for hive.


Bugs: https://issues.apache.org/jira/browse/HIVE-17211
    https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/HIVE-17211


Repository: hive-git


Description
-------

List<HiveObjectPrivilege> msObjPrivs = mClient.list_privileges(
principalName, principalType,
this.getThriftHiveObjectRef(privObj));
>>> CID 166074: Null pointer dereferences (NULL_RETURNS)
>>> Calling a method on null object "msObjPrivs".
for (HiveObjectPrivilege msObjPriv : msObjPrivs) {
HivePrincipal resPrincipal = new HivePrincipal(
msObjPriv.getPrincipalName(),
AuthorizationUtils.getHivePrincipalType(msObjPriv
.getPrincipalType()));
Reason?
The method mClient.list_privileges(
principalName, principalType,
this.getThriftHiveObjectRef(privObj)); may return null ?


Diffs
-----

  ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/SQLStdHiveAccessController.java d5c3a1a 


Diff: https://reviews.apache.org/r/61250/diff/1/


Testing
-------

tested it


Thanks,

hongtaq zhao

Re: Review Request 61250: HIVE-17211:SQLStdHiveAccessController.showPrivileges Method may encountered Null pointer

Posted by hongtaq zhao <ho...@126.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61250/
-----------------------------------------------------------

(Updated 八月 2, 2017, 12:44 a.m.)


Review request for hive.


Bugs: HIVE-17211
    https://issues.apache.org/jira/browse/HIVE-17211


Repository: hive-git


Description (updated)
-------

List<HiveObjectPrivilege> msObjPrivs = mClient.list_privileges(
principalName, principalType,
this.getThriftHiveObjectRef(privObj));
>>> CID 166074: Null pointer dereferences (NULL_RETURNS)
>>> Calling a method on null object "msObjPrivs".
for (HiveObjectPrivilege msObjPriv : msObjPrivs) {
HivePrincipal resPrincipal = new HivePrincipal(
msObjPriv.getPrincipalName(),
AuthorizationUtils.getHivePrincipalType(msObjPriv
.getPrincipalType()));

Reason?
The method mClient.list_privileges(
principalName, principalType,
this.getThriftHiveObjectRef(privObj)); may return null.


Diffs
-----

  ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/SQLStdHiveAccessController.java d5c3a1a 


Diff: https://reviews.apache.org/r/61250/diff/1/


Testing
-------

tested it


Thanks,

hongtaq zhao

Re: Review Request 61250: HIVE-17211:SQLStdHiveAccessController.showPrivileges Method may encountered Null pointer

Posted by hongtaq zhao <ho...@126.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61250/
-----------------------------------------------------------

(Updated 七月 31, 2017, 11:29 a.m.)


Review request for hive.


Bugs: HIVE-17211
    https://issues.apache.org/jira/browse/HIVE-17211


Repository: hive-git


Description
-------

List<HiveObjectPrivilege> msObjPrivs = mClient.list_privileges(
principalName, principalType,
this.getThriftHiveObjectRef(privObj));
>>> CID 166074: Null pointer dereferences (NULL_RETURNS)
>>> Calling a method on null object "msObjPrivs".
for (HiveObjectPrivilege msObjPriv : msObjPrivs) {
HivePrincipal resPrincipal = new HivePrincipal(
msObjPriv.getPrincipalName(),
AuthorizationUtils.getHivePrincipalType(msObjPriv
.getPrincipalType()));
Reason?
The method mClient.list_privileges(
principalName, principalType,
this.getThriftHiveObjectRef(privObj)); may return null ?


Diffs
-----

  ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/SQLStdHiveAccessController.java d5c3a1a 


Diff: https://reviews.apache.org/r/61250/diff/1/


Testing
-------

tested it


Thanks,

hongtaq zhao