You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by shankarh <gi...@git.apache.org> on 2017/05/11 05:24:28 UTC
[GitHub] geode pull request #507: GEODE-231 : Remove deprecated AttributesMutator.set...
GitHub user shankarh opened a pull request:
https://github.com/apache/geode/pull/507
GEODE-231 : Remove deprecated AttributesMutator.setCacheListener
Removed AttributesMutator.setCacheListener from AttributesMutator interface and AbstractRegion.
Modified tests to use addCacheListener/initCacheListener.
Removed tests which are not valid for new APIs
Changed references in java docs.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/shankarh/geode feature/GEODE-231
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/geode/pull/507.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #507
----
commit f54579be9530d4a1eeb444ad40934129cbc9709a
Author: Shankar <sh...@ampool.io>
Date: 2017-05-09T18:20:39Z
GEODE-231: Remove deprecated AttributesMutator.setCacheListener
Removed setCacheListener method from AttributesMutator and AbstractRegion.
Changed tests to use either initCacheListeners or addCacheListener methods from AttributesMutator.
commit 31eae2a2b7933c7feea4d080721ee953768ce2f6
Author: Shankar <sh...@ampool.io>
Date: 2017-05-09T18:32:44Z
GEODE-231: Remove deprecated AttributesMutator.setCacheListener
Spotlessapply changes
commit 92cc47148b33a0e8bad9e85d62a397fae2e07f94
Author: Shankar <sh...@ampool.io>
Date: 2017-05-10T07:29:42Z
GEODE-231: Remove deprecated AttributesMutator.setCacheListener
Removed commented test
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode issue #507: GEODE-231 : Remove deprecated AttributesMutator.setCacheLi...
Posted by dschneider-pivotal <gi...@git.apache.org>.
Github user dschneider-pivotal commented on the issue:
https://github.com/apache/geode/pull/507
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode pull request #507: GEODE-231 : Remove deprecated AttributesMutator.set...
Posted by dschneider-pivotal <gi...@git.apache.org>.
Github user dschneider-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/507#discussion_r118060767
--- Diff: geode-junit/src/main/java/org/apache/geode/test/junit/rules/UseJacksonForJsonPathRule.java ---
@@ -14,19 +14,18 @@
*/
package org.apache.geode.test.junit.rules;
-import java.util.EnumSet;
-import java.util.Set;
--- End diff --
I see no reason why this import reorg should be part of this pull request.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode issue #507: GEODE-231 : Remove deprecated AttributesMutator.setCacheLi...
Posted by shankarh <gi...@git.apache.org>.
Github user shankarh commented on the issue:
https://github.com/apache/geode/pull/507
Thanks @ameybarve15 @dschneider-pivotal for review.
Do I need to resubmit this PR after resolving conflicts?
or we resolve conflicts while merging?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode pull request #507: GEODE-231 : Remove deprecated AttributesMutator.set...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/geode/pull/507
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode issue #507: GEODE-231 : Remove deprecated AttributesMutator.setCacheLi...
Posted by ameybarve15 <gi...@git.apache.org>.
Github user ameybarve15 commented on the issue:
https://github.com/apache/geode/pull/507
+1 Looks good , only fix conflicts.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---