[GitHub] [iceberg] zhangjun0x01 commented on a change in pull request #2508: Core : fix bugs in RewriteDataFilesAction when datafile size greater than targetFileSize

[GitBox <gi...@apache.org>]

zhangjun0x01 commented on a change in pull request #2508:
URL: https://github.com/apache/iceberg/pull/2508#discussion_r635824619



##########
File path: core/src/main/java/org/apache/iceberg/actions/BaseRewriteDataFilesAction.java
##########
@@ -238,12 +239,13 @@ public RewriteDataFilesActionResult execute() {
     }
 
     List<DataFile> addedDataFiles = rewriteDataForTasks(combinedScanTasks);
-    List<DataFile> currentDataFiles = combinedScanTasks.stream()
+    Set<DataFile> currentDataFiles = combinedScanTasks.stream()

Review comment:
       If we split a large file into multiple small files, the original large file will appear multiple times in `currentDataFiles`, so I use the `set` to remove duplicates




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org