You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Dong Robin <ro...@gmail.com> on 2015/06/01 09:10:30 UTC
Review Request 34881: let libprocess to compile on arm64 servers
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34881/
-----------------------------------------------------------
Review request for mesos.
Bugs: MESOS-2786
https://issues.apache.org/jira/browse/MESOS-2786
Repository: mesos
Description
-------
To compile libprocess on arm64(aarch64) servers, we need to
add patches for 3rd software to recognize aarch64 architecture
and replace x86 assemble language to standard gcc buildin function
Diffs
-----
3rdparty/libprocess/3rdparty/Makefile.am 519e38c2c22904e75f36b936142a915a8f615b21
3rdparty/libprocess/3rdparty/glog-0.3.3.patch 76b8c0fe3b4615371e265bab713d62c896b7c3d6
3rdparty/libprocess/3rdparty/libev-4.15.patch bbd83e6928e6caba3bc5a9739823d60923cfaa2a
3rdparty/libprocess/3rdparty/protobuf-2.5.0.patch PRE-CREATION
Diff: https://reviews.apache.org/r/34881/diff/
Testing
-------
Build and run mesos-mater/mesos-slave succesly on arm64 server.
Thanks,
Dong Robin
Re: Review Request 34881: let libprocess to compile on arm64 servers
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34881/#review85961
-----------------------------------------------------------
Patch looks great!
Reviews applied: [34881]
All tests passed.
- Mesos ReviewBot
On June 1, 2015, 7:10 a.m., Dong Robin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34881/
> -----------------------------------------------------------
>
> (Updated June 1, 2015, 7:10 a.m.)
>
>
> Review request for mesos.
>
>
> Bugs: MESOS-2786
> https://issues.apache.org/jira/browse/MESOS-2786
>
>
> Repository: mesos
>
>
> Description
> -------
>
> To compile libprocess on arm64(aarch64) servers, we need to
> add patches for 3rd software to recognize aarch64 architecture
> and replace x86 assemble language to standard gcc buildin function
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/Makefile.am 519e38c2c22904e75f36b936142a915a8f615b21
> 3rdparty/libprocess/3rdparty/glog-0.3.3.patch 76b8c0fe3b4615371e265bab713d62c896b7c3d6
> 3rdparty/libprocess/3rdparty/libev-4.15.patch bbd83e6928e6caba3bc5a9739823d60923cfaa2a
> 3rdparty/libprocess/3rdparty/protobuf-2.5.0.patch PRE-CREATION
>
> Diff: https://reviews.apache.org/r/34881/diff/
>
>
> Testing
> -------
>
> Build and run mesos-mater/mesos-slave succesly on arm64 server.
>
>
> Thanks,
>
> Dong Robin
>
>
Re: Review Request 34881: let libprocess to compile on arm64 servers
Posted by Dong Robin <ro...@gmail.com>.
> On 六月 22, 2015, 3:48 a.m., Cody Maloney wrote:
> > 3rdparty/libprocess/3rdparty/protobuf-2.5.0.patch, line 18
> > <https://reviews.apache.org/r/34881/diff/1/?file=975553#file975553line18>
> >
> > Where did this header come from? If we were to just update protobuf to a newer version would it just compile?
This header comes from https://github.com/google/protobuf/blob/master/src/google/protobuf/stubs/atomicops_internals_generic_gcc.h, the latest protobuf code.
If we update the protobuf to the newer version, it would just compile. And, if we update protobuf to the latest version (which already supported arm64 arch), we don't need this patch anymore.
- Dong
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34881/#review88722
-----------------------------------------------------------
On 六月 1, 2015, 7:10 a.m., Dong Robin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34881/
> -----------------------------------------------------------
>
> (Updated 六月 1, 2015, 7:10 a.m.)
>
>
> Review request for mesos.
>
>
> Bugs: MESOS-2786
> https://issues.apache.org/jira/browse/MESOS-2786
>
>
> Repository: mesos
>
>
> Description
> -------
>
> To compile libprocess on arm64(aarch64) servers, we need to
> add patches for 3rd software to recognize aarch64 architecture
> and replace x86 assemble language to standard gcc buildin function
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/Makefile.am 519e38c2c22904e75f36b936142a915a8f615b21
> 3rdparty/libprocess/3rdparty/glog-0.3.3.patch 76b8c0fe3b4615371e265bab713d62c896b7c3d6
> 3rdparty/libprocess/3rdparty/libev-4.15.patch bbd83e6928e6caba3bc5a9739823d60923cfaa2a
> 3rdparty/libprocess/3rdparty/protobuf-2.5.0.patch PRE-CREATION
>
> Diff: https://reviews.apache.org/r/34881/diff/
>
>
> Testing
> -------
>
> Build and run mesos-mater/mesos-slave succesly on arm64 server.
>
>
> Thanks,
>
> Dong Robin
>
>
Re: Review Request 34881: let libprocess to compile on arm64 servers
Posted by Vinod Kone <vi...@gmail.com>.
> On June 22, 2015, 3:48 a.m., Cody Maloney wrote:
> > 3rdparty/libprocess/3rdparty/protobuf-2.5.0.patch, line 18
> > <https://reviews.apache.org/r/34881/diff/1/?file=975553#file975553line18>
> >
> > Where did this header come from? If we were to just update protobuf to a newer version would it just compile?
>
> Dong Robin wrote:
> This header comes from https://github.com/google/protobuf/blob/master/src/google/protobuf/stubs/atomicops_internals_generic_gcc.h, the latest protobuf code.
> If we update the protobuf to the newer version, it would just compile. And, if we update protobuf to the latest version (which already supported arm64 arch), we don't need this patch anymore.
feel free to send a patch for https://issues.apache.org/jira/browse/MESOS-2504 to upgrade protobuf to the latest version.
- Vinod
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34881/#review88722
-----------------------------------------------------------
On June 1, 2015, 7:10 a.m., Dong Robin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34881/
> -----------------------------------------------------------
>
> (Updated June 1, 2015, 7:10 a.m.)
>
>
> Review request for mesos.
>
>
> Bugs: MESOS-2786
> https://issues.apache.org/jira/browse/MESOS-2786
>
>
> Repository: mesos
>
>
> Description
> -------
>
> To compile libprocess on arm64(aarch64) servers, we need to
> add patches for 3rd software to recognize aarch64 architecture
> and replace x86 assemble language to standard gcc buildin function
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/Makefile.am 519e38c2c22904e75f36b936142a915a8f615b21
> 3rdparty/libprocess/3rdparty/glog-0.3.3.patch 76b8c0fe3b4615371e265bab713d62c896b7c3d6
> 3rdparty/libprocess/3rdparty/libev-4.15.patch bbd83e6928e6caba3bc5a9739823d60923cfaa2a
> 3rdparty/libprocess/3rdparty/protobuf-2.5.0.patch PRE-CREATION
>
> Diff: https://reviews.apache.org/r/34881/diff/
>
>
> Testing
> -------
>
> Build and run mesos-mater/mesos-slave succesly on arm64 server.
>
>
> Thanks,
>
> Dong Robin
>
>
Re: Review Request 34881: let libprocess to compile on arm64 servers
Posted by Cody Maloney <co...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34881/#review88722
-----------------------------------------------------------
3rdparty/libprocess/3rdparty/protobuf-2.5.0.patch (line 18)
<https://reviews.apache.org/r/34881/#comment141289>
Where did this header come from? If we were to just update protobuf to a newer version would it just compile?
- Cody Maloney
On June 1, 2015, 7:10 a.m., Dong Robin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34881/
> -----------------------------------------------------------
>
> (Updated June 1, 2015, 7:10 a.m.)
>
>
> Review request for mesos.
>
>
> Bugs: MESOS-2786
> https://issues.apache.org/jira/browse/MESOS-2786
>
>
> Repository: mesos
>
>
> Description
> -------
>
> To compile libprocess on arm64(aarch64) servers, we need to
> add patches for 3rd software to recognize aarch64 architecture
> and replace x86 assemble language to standard gcc buildin function
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/Makefile.am 519e38c2c22904e75f36b936142a915a8f615b21
> 3rdparty/libprocess/3rdparty/glog-0.3.3.patch 76b8c0fe3b4615371e265bab713d62c896b7c3d6
> 3rdparty/libprocess/3rdparty/libev-4.15.patch bbd83e6928e6caba3bc5a9739823d60923cfaa2a
> 3rdparty/libprocess/3rdparty/protobuf-2.5.0.patch PRE-CREATION
>
> Diff: https://reviews.apache.org/r/34881/diff/
>
>
> Testing
> -------
>
> Build and run mesos-mater/mesos-slave succesly on arm64 server.
>
>
> Thanks,
>
> Dong Robin
>
>