[GitHub] [pinot] jtao15 commented on a change in pull request #8345: Change controller metrics to exclude the replaced segments

[GitBox <gi...@apache.org>]

jtao15 commented on a change in pull request #8345:
URL: https://github.com/apache/pinot/pull/8345#discussion_r827451881



##########
File path: pinot-controller/src/main/java/org/apache/pinot/controller/helix/SegmentStatusChecker.java
##########
@@ -161,6 +172,9 @@ private void updateSegmentMetrics(String tableNameWithType, Context context) {
     int nOffline = 0; // Keeps track of number segments with no online replicas
     int nSegments = 0; // Counts number of segments
     for (String partitionName : idealState.getPartitionSet()) {
+      if (!segmentsExcludeReplaced.contains(partitionName)) {

Review comment:
       Oh correct, that's better. Updated.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org