You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/04/14 08:15:06 UTC
[GitHub] [shardingsphere] linghengqian opened a new pull request, #16819: Handle SpringBootPropertiesConfiguration not lazily registered in ShardingSphereAutoConfiguration
linghengqian opened a new pull request, #16819:
URL: https://github.com/apache/shardingsphere/pull/16819
Fixes #11650 .
Changes proposed in this pull request:
- Handle `org.apache.shardingsphere.spring.boot.prop.SpringBootPropertiesConfiguration` not lazily registered in `org.apache.shardingsphere.spring.boot.ShardingSphereAutoConfiguration`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] linghengqian closed pull request #16819: Eliminate the log of Auto Proxying in Spring's log
Posted by GitBox <gi...@apache.org>.
linghengqian closed pull request #16819: Eliminate the log of Auto Proxying in Spring's log
URL: https://github.com/apache/shardingsphere/pull/16819
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] linghengqian commented on a diff in pull request #16819: Handle SpringBootPropertiesConfiguration not lazily registered in ShardingSphereAutoConfiguration
Posted by GitBox <gi...@apache.org>.
linghengqian commented on code in PR #16819:
URL: https://github.com/apache/shardingsphere/pull/16819#discussion_r850895778
##########
shardingsphere-jdbc/shardingsphere-jdbc-spring/shardingsphere-jdbc-core-spring/shardingsphere-jdbc-core-spring-boot-starter/src/main/java/org/apache/shardingsphere/spring/boot/ShardingSphereAutoConfiguration.java:
##########
@@ -63,6 +64,7 @@ public class ShardingSphereAutoConfiguration implements EnvironmentAware {
private String databaseName;
+ @Lazy
Review Comment:
Of course, in the long run, other classes should not continue to be injected into the classes registered in the Spring container in advance. But this is not easy to handle, and it is likely to require the existence of unit tests for Spring Boot 2.x in the project, and the project is currently Using Spring Boot 1.x for unit testing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] linghengqian closed pull request #16819: Handle SpringBootPropertiesConfiguration not lazily registered in ShardingSphereAutoConfiguration
Posted by GitBox <gi...@apache.org>.
linghengqian closed pull request #16819: Handle SpringBootPropertiesConfiguration not lazily registered in ShardingSphereAutoConfiguration
URL: https://github.com/apache/shardingsphere/pull/16819
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] linghengqian commented on a diff in pull request #16819: Handle SpringBootPropertiesConfiguration not lazily registered in ShardingSphereAutoConfiguration
Posted by GitBox <gi...@apache.org>.
linghengqian commented on code in PR #16819:
URL: https://github.com/apache/shardingsphere/pull/16819#discussion_r850895778
##########
shardingsphere-jdbc/shardingsphere-jdbc-spring/shardingsphere-jdbc-core-spring/shardingsphere-jdbc-core-spring-boot-starter/src/main/java/org/apache/shardingsphere/spring/boot/ShardingSphereAutoConfiguration.java:
##########
@@ -63,6 +64,7 @@ public class ShardingSphereAutoConfiguration implements EnvironmentAware {
private String databaseName;
+ @Lazy
Review Comment:
Of course, in the long run, other classes should not continue to be injected into the classes registered in the Spring container in advance. But this is not easy to handle, and it is likely to require the existence of unit tests for Spring Boot 2.x in the project, and the project is currently Using Spring Boot 1.x for unit testing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #16819: Handle SpringBootPropertiesConfiguration not lazily registered in ShardingSphereAutoConfiguration
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #16819:
URL: https://github.com/apache/shardingsphere/pull/16819#issuecomment-1099660231
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/16819?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#16819](https://codecov.io/gh/apache/shardingsphere/pull/16819?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (afd3e00) into [master](https://codecov.io/gh/apache/shardingsphere/commit/bbfa8c35aced32d6cd562616e4d1812d566da8dd?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (bbfa8c3) will **increase** coverage by `0.00%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #16819 +/- ##
=========================================
Coverage 60.63% 60.63%
Complexity 2128 2128
=========================================
Files 3416 3423 +7
Lines 51258 51272 +14
Branches 8776 8776
=========================================
+ Hits 31081 31090 +9
- Misses 17563 17568 +5
Partials 2614 2614
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/16819?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...e/spring/boot/ShardingSphereAutoConfiguration.java](https://codecov.io/gh/apache/shardingsphere/pull/16819/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtamRiYy9zaGFyZGluZ3NwaGVyZS1qZGJjLXNwcmluZy9zaGFyZGluZ3NwaGVyZS1qZGJjLWNvcmUtc3ByaW5nL3NoYXJkaW5nc3BoZXJlLWpkYmMtY29yZS1zcHJpbmctYm9vdC1zdGFydGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zcHJpbmcvYm9vdC9TaGFyZGluZ1NwaGVyZUF1dG9Db25maWd1cmF0aW9uLmphdmE=) | `66.66% <ø> (ø)` | |
| [...d/text/distsql/ral/common/hint/HintSourceType.java](https://codecov.io/gh/apache/shardingsphere/pull/16819/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC90ZXh0L2Rpc3RzcWwvcmFsL2NvbW1vbi9oaW50L0hpbnRTb3VyY2VUeXBlLmphdmE=) | `0.00% <0.00%> (-42.86%)` | :arrow_down: |
| [...l/parser/core/database/visitor/SQLVisitorRule.java](https://codecov.io/gh/apache/shardingsphere/pull/16819/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWVuZ2luZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9jb3JlL2RhdGFiYXNlL3Zpc2l0b3IvU1FMVmlzaXRvclJ1bGUuamF2YQ==) | `100.00% <0.00%> (ø)` | |
| [...resql/tcl/PostgreSQLRollbackPreparedStatement.java](https://codecov.io/gh/apache/shardingsphere/pull/16819/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLXN0YXRlbWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9zcWwvZGlhbGVjdC9zdGF0ZW1lbnQvcG9zdGdyZXNxbC90Y2wvUG9zdGdyZVNRTFJvbGxiYWNrUHJlcGFyZWRTdGF0ZW1lbnQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...ngauss/tcl/OpenGaussRollbackPreparedStatement.java](https://codecov.io/gh/apache/shardingsphere/pull/16819/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLXN0YXRlbWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9zcWwvZGlhbGVjdC9zdGF0ZW1lbnQvb3BlbmdhdXNzL3RjbC9PcGVuR2F1c3NSb2xsYmFja1ByZXBhcmVkU3RhdGVtZW50LmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...tgresql/tcl/PostgreSQLCommitPreparedStatement.java](https://codecov.io/gh/apache/shardingsphere/pull/16819/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLXN0YXRlbWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9zcWwvZGlhbGVjdC9zdGF0ZW1lbnQvcG9zdGdyZXNxbC90Y2wvUG9zdGdyZVNRTENvbW1pdFByZXBhcmVkU3RhdGVtZW50LmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...g/swapper/YamlRuleConfigurationSwapperFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/16819/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS95YW1sL2NvbmZpZy9zd2FwcGVyL1lhbWxSdWxlQ29uZmlndXJhdGlvblN3YXBwZXJGYWN0b3J5LmphdmE=) | `100.00% <0.00%> (ø)` | |
| [.../common/statement/tcl/CommitPreparedStatement.java](https://codecov.io/gh/apache/shardingsphere/pull/16819/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLXN0YXRlbWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9zcWwvY29tbW9uL3N0YXRlbWVudC90Y2wvQ29tbWl0UHJlcGFyZWRTdGF0ZW1lbnQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...pengauss/tcl/OpenGaussCommitPreparedStatement.java](https://codecov.io/gh/apache/shardingsphere/pull/16819/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLXN0YXRlbWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9zcWwvZGlhbGVjdC9zdGF0ZW1lbnQvb3BlbmdhdXNzL3RjbC9PcGVuR2F1c3NDb21taXRQcmVwYXJlZFN0YXRlbWVudC5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...ommon/statement/tcl/RollbackPreparedStatement.java](https://codecov.io/gh/apache/shardingsphere/pull/16819/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLXN0YXRlbWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9zcWwvY29tbW9uL3N0YXRlbWVudC90Y2wvUm9sbGJhY2tQcmVwYXJlZFN0YXRlbWVudC5qYXZh) | `0.00% <0.00%> (ø)` | |
| ... and [4 more](https://codecov.io/gh/apache/shardingsphere/pull/16819/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/16819?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/16819?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [bbfa8c3...afd3e00](https://codecov.io/gh/apache/shardingsphere/pull/16819?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] linghengqian commented on pull request #16819: Eliminate the log of Auto Proxying in Spring's log
Posted by GitBox <gi...@apache.org>.
linghengqian commented on PR #16819:
URL: https://github.com/apache/shardingsphere/pull/16819#issuecomment-1133651043
Close this issue because of the missing means of verification.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org