You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@brpc.apache.org by GitBox <gi...@apache.org> on 2020/08/20 18:21:56 UTC

[GitHub] [incubator-brpc] mapleFU commented on a change in pull request #1175: about support protobuf arena

mapleFU commented on a change in pull request #1175:
URL: https://github.com/apache/incubator-brpc/pull/1175#discussion_r474183991



##########
File path: src/butil/memory_arena.h
##########
@@ -0,0 +1,159 @@
+
+#ifndef BUTIL_MEMORY_ARENA_H
+#define BUTIL_MEMORY_ARENA_H
+
+#include <memory>
+#include "google/protobuf/message.h"
+#include "butil/logging.h"
+
+namespace butil {
+
+template<class T>
+struct ArenaObjDeleter {
+    constexpr ArenaObjDeleter() noexcept = default;

Review comment:
       为什么不把这个 mark 成 delete 呢？




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org