You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/04/15 03:03:56 UTC
[GitHub] [spark] Yikun opened a new pull request #32182: [SPARK-xxx][INFRA] Remove --ff-only and add --squash
Yikun opened a new pull request #32182:
URL: https://github.com/apache/spark/pull/32182
### What changes were proposed in this pull request?
Remove the fast-forward opt when git merge, and also add the --squash to squash all commits into one commit
### Why are the changes needed?
### Does this PR introduce _any_ user-facing change?
### How was this patch tested?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Yikun commented on pull request #32182: [SPARK-35082][INFRA] Use permissive and squshed merge when syncing to the latest branch in GitHub Actions testing
Posted by GitBox <gi...@apache.org>.
Yikun commented on pull request #32182:
URL: https://github.com/apache/spark/pull/32182#issuecomment-820028919
@HyukjinKwon Retest with email and user opt: https://github.com/Yikun/spark/pull/14
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yaooqinn commented on pull request #32182: [SPARK-35082][INFRA] Use permissive and squshed merge when syncing to the latest branch in GitHub Actions testing
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on pull request #32182:
URL: https://github.com/apache/spark/pull/32182#issuecomment-820047934
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Yikun commented on pull request #32182: [SPARK-35082][INFRA] Use permissive and squshed merge when syncing to the latest branch in GitHub Actions testing
Posted by GitBox <gi...@apache.org>.
Yikun commented on pull request #32182:
URL: https://github.com/apache/spark/pull/32182#issuecomment-820025510
@HyukjinKwon much thanks for your help.
Note that it works in normal case (using `git` push code), but looks like have some problem on page-edited case: https://github.com/Yikun/spark/pull/14 ,
But for this patch, I think we should merge it ASAP to stop breaking other patches merging, and deal with this page-edited case later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon removed a comment on pull request #32182: [SPARK-35082][INFRA] Use permissive and squshed merge when syncing to the latest branch in GitHub Actions testing
Posted by GitBox <gi...@apache.org>.
HyukjinKwon removed a comment on pull request #32182:
URL: https://github.com/apache/spark/pull/32182#issuecomment-820024122
Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Yikun commented on pull request #32182: [SPARK-35082][INFRA] Use permissive and squshed merge when syncing to the latest branch in GitHub Actions testing
Posted by GitBox <gi...@apache.org>.
Yikun commented on pull request #32182:
URL: https://github.com/apache/spark/pull/32182#issuecomment-820043537
Thanks! It makes me feel the active and powerful of our community. : )
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] github-actions[bot] commented on pull request #32182: [SPARK-35082][INFRA] Use permissive and squshed merge when syncing to the latest branch in GitHub Actions testing
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #32182:
URL: https://github.com/apache/spark/pull/32182#issuecomment-820032876
**[Test build #750613743](https://github.com/Yikun/spark/actions/runs/750613743)** for PR 32182 at commit [`33a7e43`](https://github.com/Yikun/spark/commit/33a7e43f3bf37bfc255bbd0cbd3d965c33cf27ed).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] github-actions[bot] commented on pull request #32182: [SPARK-35082][INFRA] Use permissive and squshed merge when syncing to the latest branch in GitHub Actions testing
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #32182:
URL: https://github.com/apache/spark/pull/32182#issuecomment-820032454
**[Test build #750610693](https://github.com/Yikun/spark/actions/runs/750610693)** for PR 32182 at commit [`dbd4aa3`](https://github.com/Yikun/spark/commit/dbd4aa3ea63539aa9dbe4ff52cff1ae6ee16bd30).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #32182: [SPARK-35082][INFRA] Use permissive and squshed merge when syncing to the latest branch in GitHub Actions testing
Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #32182:
URL: https://github.com/apache/spark/pull/32182
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] github-actions[bot] commented on pull request #32182: [SPARK-xxx][INFRA] Remove --ff-only and add --squash
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #32182:
URL: https://github.com/apache/spark/pull/32182#issuecomment-820022642
**[Test build #750543885](https://github.com/Yikun/spark/actions/runs/750543885)** for PR 32182 at commit [`3f17a28`](https://github.com/Yikun/spark/commit/3f17a28a37d6b8d6e9f021dc1b8af0215c5cdef8).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #32182: [SPARK-35082][INFRA] Use permissive and squshed merge when syncing to the latest branch in GitHub Actions testing
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #32182:
URL: https://github.com/apache/spark/pull/32182#issuecomment-820026201
We can add account and email for doubly sure. i made some suggestions on your branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #32182: [SPARK-35082][INFRA] Use permissive and squshed merge when syncing to the latest branch in GitHub Actions testing
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #32182:
URL: https://github.com/apache/spark/pull/32182#issuecomment-820024122
Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #32182: [SPARK-35082][INFRA] Use permissive and squshed merge when syncing to the latest branch in GitHub Actions testing
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #32182:
URL: https://github.com/apache/spark/pull/32182#issuecomment-820033398
Thanks all especially @Yikun and @yaooqinn. I was a bit in a hurry. thanks for bearing with me all.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] github-actions[bot] commented on pull request #32182: [SPARK-35082][INFRA] Use permissive and squshed merge when syncing to the latest branch in GitHub Actions testing
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #32182:
URL: https://github.com/apache/spark/pull/32182#issuecomment-820032738
**[Test build #750612793](https://github.com/Yikun/spark/actions/runs/750612793)** for PR 32182 at commit [`3f17a28`](https://github.com/Yikun/spark/commit/3f17a28a37d6b8d6e9f021dc1b8af0215c5cdef8).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #32182: [SPARK-35082][INFRA] Use permissive and squshed merge when syncing to the latest branch in GitHub Actions testing
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #32182:
URL: https://github.com/apache/spark/pull/32182#issuecomment-820032838
Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Yikun commented on pull request #32182: [SPARK-35082][INFRA] Use permissive and squshed merge when syncing to the latest branch in GitHub Actions testing
Posted by GitBox <gi...@apache.org>.
Yikun commented on pull request #32182:
URL: https://github.com/apache/spark/pull/32182#issuecomment-820032511
the latest code works in my local test: https://github.com/Yikun/spark/runs/2349203988?check_suite_focus=true#step:3:18
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #32182: [SPARK-35082][INFRA] Use permissive and squshed merge when syncing to the latest branch in GitHub Actions testing
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #32182:
URL: https://github.com/apache/spark/pull/32182#issuecomment-820023979
Im gonna merge this in and see how it gose.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org