You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mesos.apache.org by ne...@apache.org on 2017/05/09 21:34:02 UTC

mesos git commit: Fixed `Version::validateIdentifier()` for Unicode edge case.

Repository: mesos
Updated Branches:
  refs/heads/master 1e00fd5fa -> 5e2188e6a


Fixed `Version::validateIdentifier()` for Unicode edge case.

The test case `u8"1.0.0-b\u00e9ta"` in `VersionTest.ParseInvalid` caused
an abort in `isctype.cpp` with VS 2017. Changing the `char` to an
`unsigned char` prevents this.

Review: https://reviews.apache.org/r/59110/


Project: http://git-wip-us.apache.org/repos/asf/mesos/repo
Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/5e2188e6
Tree: http://git-wip-us.apache.org/repos/asf/mesos/tree/5e2188e6
Diff: http://git-wip-us.apache.org/repos/asf/mesos/diff/5e2188e6

Branch: refs/heads/master
Commit: 5e2188e6ad2acf190505b04db1aa03dade67bb75
Parents: 1e00fd5
Author: Andrew Schwartzmeyer <an...@schwartzmeyer.com>
Authored: Tue May 9 14:06:01 2017 -0700
Committer: Neil Conway <ne...@gmail.com>
Committed: Tue May 9 14:33:50 2017 -0700

----------------------------------------------------------------------
 3rdparty/stout/include/stout/version.hpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/mesos/blob/5e2188e6/3rdparty/stout/include/stout/version.hpp
----------------------------------------------------------------------
diff --git a/3rdparty/stout/include/stout/version.hpp b/3rdparty/stout/include/stout/version.hpp
index 9120e42..4be7222 100644
--- a/3rdparty/stout/include/stout/version.hpp
+++ b/3rdparty/stout/include/stout/version.hpp
@@ -299,7 +299,7 @@ private:
       return Error("Empty identifier");
     }
 
-    auto alphaNumericOrHyphen = [](char c) -> bool {
+    auto alphaNumericOrHyphen = [](unsigned char c) -> bool {
       return std::isalnum(c) || c == '-';
     };