[GitHub] [incubator-tamaya] acoburn commented on a change in pull request #51: TAMAYA-277: Don't fail builds because of Sonar

[GitBox <gi...@apache.org>]

acoburn commented on a change in pull request #51: TAMAYA-277: Don't fail builds because of Sonar
URL: https://github.com/apache/incubator-tamaya/pull/51#discussion_r280521228
 
 

 ##########
 File path: .travis.yml
 ##########
 @@ -10,7 +10,8 @@ jobs:
     include:
         - name: "Java 8"
           jdk: openjdk8
-          script: mvn clean install sonar:sonar -Dsonar.organization=apache -Dsonar.projectKey=apache_incubator-tamaya
+          script: mvn clean install
 
 Review comment:
   The jacoco task will have already completed in the `script` stage (jacoco runs during the `verify` task). So long as we don't `mvn clean` during `after_success`, those data files generated by jacoco will be present and will be used by the `sonar:sonar` task. The best way to verify this would be to close the PR from this branch and re-open it in the apache repo (though it was useful to verify that the CI task succeeded here)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services