You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/03/14 14:24:49 UTC
[GitHub] [airflow] potiuk opened a new pull request #22244: Protect against accidental misuse of XCom.get_value()
potiuk opened a new pull request #22244:
URL: https://github.com/apache/airflow/pull/22244
The XCom.get_value has been added in 2.3.0 and while there are
cases it should be used in the providers when task are mapped,
in order to keep compatibility with earlier versions of Airlfow,
the XCom.get_value() should only be used when ti_key is not None.
We check for the construct used in community providers automatically
and also add a documentation for users who would like to use
dynamic task mapping featuers in their own providers.
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #22244: Protect against accidental misuse of XCom.get_value()
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #22244:
URL: https://github.com/apache/airflow/pull/22244
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on a change in pull request #22244: Protect against accidental misuse of XCom.get_value()
Posted by GitBox <gi...@apache.org>.
ashb commented on a change in pull request #22244:
URL: https://github.com/apache/airflow/pull/22244#discussion_r826053680
##########
File path: airflow/providers/amazon/aws/operators/emr.py
##########
@@ -244,7 +244,7 @@ def get_link(
:param dttm: datetime
:return: url link
"""
- if ti_key:
+ if ti_key is not None:
Review comment:
This makes no difference does it? (since we don't define a custom book on TIKey)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a change in pull request #22244: Protect against accidental misuse of XCom.get_value()
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #22244:
URL: https://github.com/apache/airflow/pull/22244#discussion_r826108280
##########
File path: airflow/providers/amazon/aws/operators/emr.py
##########
@@ -244,7 +244,7 @@ def get_link(
:param dttm: datetime
:return: url link
"""
- if ti_key:
+ if ti_key is not None:
Review comment:
This way we have only one "standard" way to check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #22244: Protect against accidental misuse of XCom.get_value()
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #22244:
URL: https://github.com/apache/airflow/pull/22244#issuecomment-1066890016
Updated it so the error looks a bit nicer:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a change in pull request #22244: Protect against accidental misuse of XCom.get_value()
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #22244:
URL: https://github.com/apache/airflow/pull/22244#discussion_r826105653
##########
File path: airflow/providers/amazon/aws/operators/emr.py
##########
@@ -244,7 +244,7 @@ def get_link(
:param dttm: datetime
:return: url link
"""
- if ti_key:
+ if ti_key is not None:
Review comment:
Nope. But it's easier to standardize. Both ways were used in the code and I arbitrary choose `not None` as more explicit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk closed pull request #22244: Protect against accidental misuse of XCom.get_value()
Posted by GitBox <gi...@apache.org>.
potiuk closed pull request #22244:
URL: https://github.com/apache/airflow/pull/22244
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #22244: Protect against accidental misuse of XCom.get_value()
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #22244:
URL: https://github.com/apache/airflow/pull/22244#issuecomment-1067068888
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #22244: Protect against accidental misuse of XCom.get_value()
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #22244:
URL: https://github.com/apache/airflow/pull/22244#issuecomment-1066981716
Random doc inventory problem it seems. Reopened to rebuild.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk closed pull request #22244: Protect against accidental misuse of XCom.get_value()
Posted by GitBox <gi...@apache.org>.
potiuk closed pull request #22244:
URL: https://github.com/apache/airflow/pull/22244
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #22244: Protect against accidental misuse of XCom.get_value()
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #22244:
URL: https://github.com/apache/airflow/pull/22244#issuecomment-1067128509
Rebased to take advantage of the "docs" build fix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #22244: Protect against accidental misuse of XCom.get_value()
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #22244:
URL: https://github.com/apache/airflow/pull/22244#issuecomment-1066895853
I'd love to merge it quickly so that I could incorporate this in the changelogs (hidden entry but avoids future release pollution) to include that one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a change in pull request #22244: Protect against accidental misuse of XCom.get_value()
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #22244:
URL: https://github.com/apache/airflow/pull/22244#discussion_r826105653
##########
File path: airflow/providers/amazon/aws/operators/emr.py
##########
@@ -244,7 +244,7 @@ def get_link(
:param dttm: datetime
:return: url link
"""
- if ti_key:
+ if ti_key is not None:
Review comment:
Nope. But it's easier to standardize as convention. Both ways were used in the code and I arbitrary chose `not None` as more explicit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a change in pull request #22244: Protect against accidental misuse of XCom.get_value()
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #22244:
URL: https://github.com/apache/airflow/pull/22244#discussion_r826105653
##########
File path: airflow/providers/amazon/aws/operators/emr.py
##########
@@ -244,7 +244,7 @@ def get_link(
:param dttm: datetime
:return: url link
"""
- if ti_key:
+ if ti_key is not None:
Review comment:
Nope. But it's easier to standardize. Both ways were used in the code and I arbitrary chose `not None` as more explicit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org