You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "cstamas (via GitHub)" <gi...@apache.org> on 2024/03/10 15:18:05 UTC

[PR] Move to Java17 [maven-resolver]

cstamas opened a new pull request, #438:
URL: https://github.com/apache/maven-resolver/pull/438

   (no comment)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Move to Java17 [maven-resolver]

Posted by "cstamas (via GitHub)" <gi...@apache.org>.
cstamas commented on PR #438:
URL: https://github.com/apache/maven-resolver/pull/438#issuecomment-2877350659

   Will happen in resolver 2.1


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Move to Java17 [maven-resolver]

Posted by "slachiewicz (via GitHub)" <gi...@apache.org>.
slachiewicz commented on PR #438:
URL: https://github.com/apache/maven-resolver/pull/438#issuecomment-2877282750

   @cstamas ping?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Move to Java17 [maven-resolver]

Posted by "michael-o (via GitHub)" <gi...@apache.org>.
michael-o commented on PR #438:
URL: https://github.com/apache/maven-resolver/pull/438#issuecomment-1991394381

   A JIRA issue is also advised.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Move to Java17 [maven-resolver]

Posted by "cstamas (via GitHub)" <gi...@apache.org>.
cstamas commented on PR #438:
URL: https://github.com/apache/maven-resolver/pull/438#issuecomment-2877405102

   Or that, yes: point in point: no in 2.0.x


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Move to Java17 [maven-resolver]

Posted by "cstamas (via GitHub)" <gi...@apache.org>.
cstamas closed pull request #438: Move to Java17
URL: https://github.com/apache/maven-resolver/pull/438


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Move to Java17 [maven-resolver]

Posted by "elharo (via GitHub)" <gi...@apache.org>.
elharo commented on PR #438:
URL: https://github.com/apache/maven-resolver/pull/438#issuecomment-2661416055

   I think this is obdolete since project is now on java 21?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Move to Java17 [maven-resolver]

Posted by "michael-o (via GitHub)" <gi...@apache.org>.
michael-o commented on PR #438:
URL: https://github.com/apache/maven-resolver/pull/438#issuecomment-2661424436

   > I think this is obdolete since project is now on java 21?
   
   This is runtime requirement, not build time 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Move to Java17 [maven-resolver]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #438:
URL: https://github.com/apache/maven-resolver/pull/438#issuecomment-2831798134

   This pull request is stale because it has been waiting for feedback for 60 days. Remove the stale label or comment on this PR, or it will be automatically closed in 30 days.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Move to Java17 [maven-resolver]

Posted by "michael-o (via GitHub)" <gi...@apache.org>.
michael-o commented on PR #438:
URL: https://github.com/apache/maven-resolver/pull/438#issuecomment-2877402966

   > Will happen in resolver 2.1
   
   Shouldn't this happen with 3.0 and a namespace change for Maven 4/5?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Move to Java17 [maven-resolver]

Posted by "michael-o (via GitHub)" <gi...@apache.org>.
michael-o commented on code in PR #438:
URL: https://github.com/apache/maven-resolver/pull/438#discussion_r1521252180


##########
maven-resolver-transport-jdk-parent/maven-resolver-transport-jdk-17/pom.xml:
##########
@@ -26,17 +26,15 @@
     <version>2.0.0-SNAPSHOT</version>
   </parent>
 
-  <artifactId>maven-resolver-transport-jdk-11</artifactId>
+  <artifactId>maven-resolver-transport-jdk-17</artifactId>
   <packaging>jar</packaging>
 
-  <name>Maven Artifact Resolver Transport JDK 11</name>
-  <description>Maven Artifact Transport JDK Java 11+.</description>
+  <name>Maven Artifact Resolver Transport JDK 17</name>
+  <description>Maven Artifact Transport JDK Java 17+.</description>

Review Comment:
   Why? Can't it then just be "Maven Artifact Resolver Transport JDK" or so?



##########
src/site/markdown/configuration.md:
##########
@@ -116,8 +116,8 @@ under the License.
 | 89. | `"aether.transport.http.supportWebDav"` | `java.lang.Boolean` | Boolean flag should the HTTP transport support WebDAV remote. Not all transport support this option. |  `false`  | 2.0.0 (moved out from maven-resolver-transport-http). |  Yes  | Session Configuration |
 | 90. | `"aether.transport.http.userAgent"` | `java.lang.String` | The user agent that repository connectors should report to servers. |  `"Aether"`  |  |  No  | Session Configuration |
 | 91. | `"aether.transport.https.securityMode"` | `java.lang.String` | The mode that sets HTTPS transport "security mode": to ignore any SSL errors (certificate validity checks, hostname verification). The default value is . |  `"default"`  | 1.9.6 |  Yes  | Session Configuration |
-| 92. | `"aether.transport.jdk.httpVersion"` | `java.lang.String` | Use string representation of HttpClient version enum "HTTP_2" or "HTTP_1_1" to set default HTTP protocol to use. |  `"HTTP_2"`  | 2.0.0 |  Yes  | Session Configuration |
-| 93. | `"aether.transport.jdk.maxConcurrentRequests"` | `java.lang.Integer` | The hard limit of maximum concurrent requests JDK transport can do. This is a workaround for the fact, that in HTTP/2 mode, JDK HttpClient initializes this value to Integer.MAX_VALUE (!) and lowers it on first response from the remote server (but it may be too late). See JDK bug <a href="https://bugs.openjdk.org/browse/JDK-8225647">JDK-8225647</a> for details. |  `100`  | 2.0.0 |  Yes  | Session Configuration |
+| 92. | `"aether.transport.jdk.httpVersion"` | `String` | Use string representation of HttpClient version enum "HTTP_2" or "HTTP_1_1" to set default HTTP protocol to use. |  `"HTTP_2"`  | 2.0.0 |  Yes  | Session Configuration |
+| 93. | `"aether.transport.jdk.maxConcurrentRequests"` | `Integer` | The hard limit of maximum concurrent requests JDK transport can do. This is a workaround for the fact, that in HTTP/2 mode, JDK HttpClient initializes this value to Integer.MAX_VALUE (!) and lowers it on first response from the remote server (but it may be too late). See JDK bug <a href="https://bugs.openjdk.org/browse/JDK-8225647">JDK-8225647</a> for details. |  `100`  | 2.0.0 |  Yes  | Session Configuration |

Review Comment:
   This does not make sense if the other references are still fully qualified and I would leave it fully qualified for consistency.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Move to Java17 [maven-resolver]

Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski commented on code in PR #438:
URL: https://github.com/apache/maven-resolver/pull/438#discussion_r1518909135


##########
maven-resolver-transport-jdk-parent/maven-resolver-transport-jdk-17/src/main/java/org/eclipse/aether/transport/jdk/JdkTransporter.java:
##########
@@ -53,11 +53,7 @@
 import org.eclipse.aether.RepositorySystemSession;
 import org.eclipse.aether.repository.AuthenticationContext;
 import org.eclipse.aether.repository.RemoteRepository;
-import org.eclipse.aether.spi.connector.transport.AbstractTransporter;
-import org.eclipse.aether.spi.connector.transport.GetTask;
-import org.eclipse.aether.spi.connector.transport.PeekTask;
-import org.eclipse.aether.spi.connector.transport.PutTask;
-import org.eclipse.aether.spi.connector.transport.TransportTask;
+import org.eclipse.aether.spi.connector.transport.*;

Review Comment:
   😄 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org