You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@curator.apache.org by Randgalt <gi...@git.apache.org> on 2018/12/06 17:44:50 UTC
[GitHub] curator pull request #285: [CURATOR-468] LeaderSelector interruption causing...
GitHub user Randgalt opened a pull request:
https://github.com/apache/curator/pull/285
[CURATOR-468] LeaderSelector interruption causing spurious log messages, etc.
Adds a test to what #279 had along with a slightly more complete fix. The finally clause of doWork() releases the mutex. In an interrupted situation this would always fail causing the failed delete manager to handle the work resulting in slightly slower deletions and spurious log messaged. This fixes this by clearing the thread interrupted state prior to releasing the mutex and then resetting afterwards if needed.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/curator CURATOR-468
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/curator/pull/285.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #285
----
commit 97e76919ae0056985aacc786d6c440fb779a6877
Author: randgalt <ra...@...>
Date: 2018-12-06T17:40:43Z
CURATOR-468
Adds a test to what #279 had along with a slightly more complete fix. The finally clause of doWork() releases the mutex. In an interrupted situation this would always fail causing the failed delete manager to handle the work resulting in slightly slower deletions and spurious log messaged. This fixes this by clearing the thread interrupted state prior to releasing the mutex and then resetting afterwards if needed.
commit ddfcbc1e37fa9e8a9018f2c0d85b7f125efe173c
Author: randgalt <ra...@...>
Date: 2018-12-06T17:43:16Z
Add a comment explaining
----
---
[GitHub] curator issue #285: [CURATOR-468] LeaderSelector interruption causing spurio...
Posted by cammckenzie <gi...@git.apache.org>.
Github user cammckenzie commented on the issue:
https://github.com/apache/curator/pull/285
Looks ok to me.
---
[GitHub] curator pull request #285: [CURATOR-468] LeaderSelector interruption causing...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/curator/pull/285
---