You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Peter Ertl (JIRA)" <ji...@apache.org> on 2007/05/09 23:03:17 UTC

[jira] Created: (WICKET-549) should be accessible in wicket

<html> should be accessible in wicket
-------------------------------------

                 Key: WICKET-549
                 URL: https://issues.apache.org/jira/browse/WICKET-549
             Project: Wicket
          Issue Type: Improvement
          Components: wicket
            Reporter: Peter Ertl


--- issue copy-pasted from mailing list ---

On 5/9/07, Peter Ertl <pe...@gmx.net> wrote:


Hi folks,


I try to setup a multi-language website like that:


<? xml version= "1.0" encoding ="UTF-8" ?>
<! DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "
http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">
<html wicket:id="html"  xmlns:wicket xmlns=" http://www.w3.org/1999/xhtml"
xmlns:lang=[current language] lang=[current language]>
....


However, accessing <html> using a wicket:id will fail:


org.apache.wicket.WicketRuntimeException: Programming
error: 'parent' should be a Page or a Border.


changing the tag using a MarkupFilter will also fail as it requires to
value of the current locale of WebSession
but the markup filter seems to allow no access to it.


It would be straightforward to just access html using a wicket:id...
*imho* this would be a great enhancement!


Can somebody think of a better solution?


On 5/9/07, Johan Compagner <jc...@gmail.com> wrote:
hmm this is because of the HtmlHeaderContainer that container wants a page
to be its parent.

So you can't attach a wicket container to the html because then you
encapsulate the complete page.
i dont know immediantly how to solve this

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Resolved: (WICKET-549) HeaderContributions are missing if is a Component.

Posted by "Juergen Donnerstag (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-549?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Juergen Donnerstag resolved WICKET-549.
---------------------------------------

    Resolution: Fixed

It is working for me. See SimplePageTest_13 which I extend to add an AjaxLink. 

@Johan: Yes it is working a little bit strange because of the way the <body> Container is implemented. Especially the way it links with Page and the <body> markup tag.

> HeaderContributions are missing if <html> is a Component.
> ---------------------------------------------------------
>
>                 Key: WICKET-549
>                 URL: https://issues.apache.org/jira/browse/WICKET-549
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>    Affects Versions: 1.3.0-beta1
>            Reporter: Peter Ertl
>            Assignee: Juergen Donnerstag
>             Fix For: 1.3.0-rc1
>
>
> --- issue copy-pasted from mailing list ---
> On 5/9/07, Peter Ertl <pe...@gmx.net> wrote:
> Hi folks,
> I try to setup a multi-language website like that:
> <? xml version= "1.0" encoding ="UTF-8" ?>
> <! DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "
> http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">
> <html wicket:id="html"  xmlns:wicket xmlns=" http://www.w3.org/1999/xhtml"
> xmlns:lang=[current language] lang=[current language]>
> ....
> However, accessing <html> using a wicket:id will fail:
> org.apache.wicket.WicketRuntimeException: Programming
> error: 'parent' should be a Page or a Border.
> changing the tag using a MarkupFilter will also fail as it requires to
> value of the current locale of WebSession
> but the markup filter seems to allow no access to it.
> It would be straightforward to just access html using a wicket:id...
> *imho* this would be a great enhancement!
> Can somebody think of a better solution?
> On 5/9/07, Johan Compagner <jc...@gmail.com> wrote:
> hmm this is because of the HtmlHeaderContainer that container wants a page
> to be its parent.
> So you can't attach a wicket container to the html because then you
> encapsulate the complete page.
> i dont know immediantly how to solve this

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Commented: (WICKET-549) should be accessible in wicket

Posted by "Johan Compagner (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WICKET-549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12495405 ] 

Johan Compagner commented on WICKET-549:
----------------------------------------

But it works a bit strange: " The <html> tag seems to be the only case where you shouldn't add childs even if it is a child!" 

See SimplePage_14 for a test
it does work now but only because i add the label directly to the page instead (of what is normal) to the html tag container itself
Not that it matter to much, i think it is even handier that it works like that, but i guess we should document it?

> <html> should be accessible in wicket
> -------------------------------------
>
>                 Key: WICKET-549
>                 URL: https://issues.apache.org/jira/browse/WICKET-549
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>            Reporter: Peter Ertl
>         Assigned To: Juergen Donnerstag
>             Fix For: 1.3
>
>
> --- issue copy-pasted from mailing list ---
> On 5/9/07, Peter Ertl <pe...@gmx.net> wrote:
> Hi folks,
> I try to setup a multi-language website like that:
> <? xml version= "1.0" encoding ="UTF-8" ?>
> <! DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "
> http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">
> <html wicket:id="html"  xmlns:wicket xmlns=" http://www.w3.org/1999/xhtml"
> xmlns:lang=[current language] lang=[current language]>
> ....
> However, accessing <html> using a wicket:id will fail:
> org.apache.wicket.WicketRuntimeException: Programming
> error: 'parent' should be a Page or a Border.
> changing the tag using a MarkupFilter will also fail as it requires to
> value of the current locale of WebSession
> but the markup filter seems to allow no access to it.
> It would be straightforward to just access html using a wicket:id...
> *imho* this would be a great enhancement!
> Can somebody think of a better solution?
> On 5/9/07, Johan Compagner <jc...@gmail.com> wrote:
> hmm this is because of the HtmlHeaderContainer that container wants a page
> to be its parent.
> So you can't attach a wicket container to the html because then you
> encapsulate the complete page.
> i dont know immediantly how to solve this

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (WICKET-549) HeaderContributions are missing if is a Component.

Posted by "Alastair Maw (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-549?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alastair Maw updated WICKET-549:
--------------------------------

    Fix Version/s:     (was: 1.3.0-rc1)
                   1.3.0-beta2

> HeaderContributions are missing if <html> is a Component.
> ---------------------------------------------------------
>
>                 Key: WICKET-549
>                 URL: https://issues.apache.org/jira/browse/WICKET-549
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>    Affects Versions: 1.3.0-beta1
>            Reporter: Peter Ertl
>            Assignee: Juergen Donnerstag
>             Fix For: 1.3.0-beta2
>
>
> --- issue copy-pasted from mailing list ---
> On 5/9/07, Peter Ertl <pe...@gmx.net> wrote:
> Hi folks,
> I try to setup a multi-language website like that:
> <? xml version= "1.0" encoding ="UTF-8" ?>
> <! DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "
> http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">
> <html wicket:id="html"  xmlns:wicket xmlns=" http://www.w3.org/1999/xhtml"
> xmlns:lang=[current language] lang=[current language]>
> ....
> However, accessing <html> using a wicket:id will fail:
> org.apache.wicket.WicketRuntimeException: Programming
> error: 'parent' should be a Page or a Border.
> changing the tag using a MarkupFilter will also fail as it requires to
> value of the current locale of WebSession
> but the markup filter seems to allow no access to it.
> It would be straightforward to just access html using a wicket:id...
> *imho* this would be a great enhancement!
> Can somebody think of a better solution?
> On 5/9/07, Johan Compagner <jc...@gmail.com> wrote:
> hmm this is because of the HtmlHeaderContainer that container wants a page
> to be its parent.
> So you can't attach a wicket container to the html because then you
> encapsulate the complete page.
> i dont know immediantly how to solve this

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Resolved: (WICKET-549) should be accessible in wicket

Posted by "Juergen Donnerstag (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-549?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Juergen Donnerstag resolved WICKET-549.
---------------------------------------

       Resolution: Fixed
    Fix Version/s: 1.3
         Assignee: Juergen Donnerstag

It should now be possible. See SimplePageTest_13

> <html> should be accessible in wicket
> -------------------------------------
>
>                 Key: WICKET-549
>                 URL: https://issues.apache.org/jira/browse/WICKET-549
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>            Reporter: Peter Ertl
>         Assigned To: Juergen Donnerstag
>             Fix For: 1.3
>
>
> --- issue copy-pasted from mailing list ---
> On 5/9/07, Peter Ertl <pe...@gmx.net> wrote:
> Hi folks,
> I try to setup a multi-language website like that:
> <? xml version= "1.0" encoding ="UTF-8" ?>
> <! DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "
> http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">
> <html wicket:id="html"  xmlns:wicket xmlns=" http://www.w3.org/1999/xhtml"
> xmlns:lang=[current language] lang=[current language]>
> ....
> However, accessing <html> using a wicket:id will fail:
> org.apache.wicket.WicketRuntimeException: Programming
> error: 'parent' should be a Page or a Border.
> changing the tag using a MarkupFilter will also fail as it requires to
> value of the current locale of WebSession
> but the markup filter seems to allow no access to it.
> It would be straightforward to just access html using a wicket:id...
> *imho* this would be a great enhancement!
> Can somebody think of a better solution?
> On 5/9/07, Johan Compagner <jc...@gmail.com> wrote:
> hmm this is because of the HtmlHeaderContainer that container wants a page
> to be its parent.
> So you can't attach a wicket container to the html because then you
> encapsulate the complete page.
> i dont know immediantly how to solve this

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Reopened: (WICKET-549) should be accessible in wicket

Posted by "Peter Ertl (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-549?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Peter Ertl reopened WICKET-549:
-------------------------------


Using the <html> as a wicket component seems to swallow certain header contributions...

Simply add any ajax component (like AjaxLink) and see that the inclusion of ajax-event.js (or anything else) will be missing once you attach a WebMarkupContainer to <html>.

--markup--

  <html wicket:id="html">
...
</html>

--java--

  Page#add(new WebMarkupContainer("html"))

--effect--

header contributions are missing :-(



> <html> should be accessible in wicket
> -------------------------------------
>
>                 Key: WICKET-549
>                 URL: https://issues.apache.org/jira/browse/WICKET-549
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>            Reporter: Peter Ertl
>         Assigned To: Juergen Donnerstag
>             Fix For: 1.3
>
>
> --- issue copy-pasted from mailing list ---
> On 5/9/07, Peter Ertl <pe...@gmx.net> wrote:
> Hi folks,
> I try to setup a multi-language website like that:
> <? xml version= "1.0" encoding ="UTF-8" ?>
> <! DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "
> http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">
> <html wicket:id="html"  xmlns:wicket xmlns=" http://www.w3.org/1999/xhtml"
> xmlns:lang=[current language] lang=[current language]>
> ....
> However, accessing <html> using a wicket:id will fail:
> org.apache.wicket.WicketRuntimeException: Programming
> error: 'parent' should be a Page or a Border.
> changing the tag using a MarkupFilter will also fail as it requires to
> value of the current locale of WebSession
> but the markup filter seems to allow no access to it.
> It would be straightforward to just access html using a wicket:id...
> *imho* this would be a great enhancement!
> Can somebody think of a better solution?
> On 5/9/07, Johan Compagner <jc...@gmail.com> wrote:
> hmm this is because of the HtmlHeaderContainer that container wants a page
> to be its parent.
> So you can't attach a wicket container to the html because then you
> encapsulate the complete page.
> i dont know immediantly how to solve this

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (WICKET-549) HeaderContributions are missing if is a Component.

Posted by "Alastair Maw (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-549?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alastair Maw updated WICKET-549:
--------------------------------

        Fix Version/s:     (was: trunk)
                       1.3.0-rc1
    Affects Version/s: trunk
              Summary: HeaderContributions are missing if <html> is a Component.  (was: <html> should be accessible in wicket)

Retitling this appropriately.

> HeaderContributions are missing if <html> is a Component.
> ---------------------------------------------------------
>
>                 Key: WICKET-549
>                 URL: https://issues.apache.org/jira/browse/WICKET-549
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>    Affects Versions: trunk
>            Reporter: Peter Ertl
>         Assigned To: Juergen Donnerstag
>             Fix For: 1.3.0-rc1
>
>
> --- issue copy-pasted from mailing list ---
> On 5/9/07, Peter Ertl <pe...@gmx.net> wrote:
> Hi folks,
> I try to setup a multi-language website like that:
> <? xml version= "1.0" encoding ="UTF-8" ?>
> <! DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "
> http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">
> <html wicket:id="html"  xmlns:wicket xmlns=" http://www.w3.org/1999/xhtml"
> xmlns:lang=[current language] lang=[current language]>
> ....
> However, accessing <html> using a wicket:id will fail:
> org.apache.wicket.WicketRuntimeException: Programming
> error: 'parent' should be a Page or a Border.
> changing the tag using a MarkupFilter will also fail as it requires to
> value of the current locale of WebSession
> but the markup filter seems to allow no access to it.
> It would be straightforward to just access html using a wicket:id...
> *imho* this would be a great enhancement!
> Can somebody think of a better solution?
> On 5/9/07, Johan Compagner <jc...@gmail.com> wrote:
> hmm this is because of the HtmlHeaderContainer that container wants a page
> to be its parent.
> So you can't attach a wicket container to the html because then you
> encapsulate the complete page.
> i dont know immediantly how to solve this

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.