You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@hive.apache.org by "John Sichi (Resolved) (JIRA)" <ji...@apache.org> on 2011/12/14 02:02:30 UTC

[jira] [Resolved] (HIVE-1040) use sed rather than diff for masking out noise in diff-based tests

     [ https://issues.apache.org/jira/browse/HIVE-1040?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

John Sichi resolved HIVE-1040.
------------------------------

       Resolution: Fixed
    Fix Version/s: 0.9.0
     Hadoop Flags: Reviewed

Committed to trunk.  Thanks Marek!

                
> use sed rather than diff for masking out noise in diff-based tests
> ------------------------------------------------------------------
>
>                 Key: HIVE-1040
>                 URL: https://issues.apache.org/jira/browse/HIVE-1040
>             Project: Hive
>          Issue Type: Improvement
>          Components: Testing Infrastructure
>    Affects Versions: 0.4.1
>            Reporter: John Sichi
>            Assignee: Marek Sapota
>            Priority: Minor
>             Fix For: 0.9.0
>
>         Attachments: HIVE-1040-code-patch.patch, HIVE-1040.1.patch, HIVE-1040.2.patch, HIVE-1040.D597.1.patch, HIVE-1040.D597.2.patch, HIVE-1040.D597.3.patch, HIVE-1040.D597.4.patch, HIVE-1040.final.patch
>
>
> The current diff -I approach has two problems:  (1) it does not allow resolution finer than line-level, so it's impossible to mask out pattern occurrences within a line, and (2) it produces unmasked files, so if you run diff on the command line to compare the result .q.out with the checked-in file, you see the noise.
> My suggestion is to first run sed to replace noise patterns with an unlikely-to-occur string like ZYZZYZVA, and then diff the pre-masked files without using any -I.
> This would require a one-time hit to update all existing .q.out files so that they would contain the pre-masked results.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira