[jira] [Commented] (ZOOKEEPER-2284) LogFormatter and SnapshotFormatter does not handle FileNotFoundException gracefully

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-2284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16616718#comment-16616718 ] 

Hadoop QA commented on ZOOKEEPER-2284:
--------------------------------------

-1 overall.  GitHub Pull Request  Build
      

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 3 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 3.0.1) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    -1 core tests.  The patch failed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2190//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2190//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2190//console

This message is automatically generated.

> LogFormatter and SnapshotFormatter does not handle FileNotFoundException gracefully
> -----------------------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-2284
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2284
>             Project: ZooKeeper
>          Issue Type: Bug
>    Affects Versions: 3.5.0
>            Reporter: Mohammad Arshad
>            Assignee: maoling
>            Priority: Minor
>              Labels: pull-request-available
>             Fix For: 3.6.0, 3.5.5
>
>         Attachments: ZOOKEEPER-2284-01.patch, ZOOKEEPER-2284-02.patch, ZOOKEEPER-2284-03.patch, ZOOKEEPER-2284-04.patch
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> {{LogFormatter}} and {{SnapshotFormatter}} does not handle FileNotFoundException gracefully. If file no exist then these classes propagate the exception to console.
> {code}
> Exception in thread "main" java.io.FileNotFoundException: log.1 (The system cannot find the file specified)
>         at java.io.FileInputStream.open(Native Method)
>         at java.io.FileInputStream.<init>(FileInputStream.java:146)
>         at java.io.FileInputStream.<init>(FileInputStream.java:101)
>         at org.apache.zookeeper.server.LogFormatter.main(LogFormatter.java:49)
> {code}
>  File existence should be validated and appropriate message should be displayed on console if file does not exist



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)