[GitHub] [airflow] kaxil commented on pull request #9250: Fix tree view if config contains "

[GitBox <gi...@apache.org>]

kaxil commented on pull request #9250:
URL: https://github.com/apache/airflow/pull/9250#issuecomment-644121105


   The problem with the CI in this build was that it only tested the static tests. As no ".py" file was changed, CI skipped rest of the unit test. However on Master we run all the tests, hence Master failed with below error:
   
   ```
   tests/www/test_views.py .............................F
   
   _________ TestAirflowBaseViews.test_escape_in_tree_view_0_hello_world __________
   
   a = (<tests.www.test_views.TestAirflowBaseViews testMethod=test_escape_in_tree_view_0_hello_world>,)
   
       @wraps(func)
       def standalone_func(*a):
   >       return func(*(a + p.args), **p.kwargs)
   
   /usr/local/lib/python3.6/site-packages/parameterized/parameterized.py:530: 
   _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
   tests/www/test_views.py:646: in test_escape_in_tree_view
       self.check_content_in_response(f'"conf":{{"abc":"{seralized_test_str}"}}', resp)
   tests/www/test_views.py:177: in check_content_in_response
       self.assertIn(text, resp_html)
   ```
   
   ```
   tests/www/test_views.py F
   
   _________ TestAirflowBaseViews.test_escape_in_tree_view_1_hello_world __________
   
   a = (<tests.www.test_views.TestAirflowBaseViews testMethod=test_escape_in_tree_view_1_hello_world>,)
   
       @wraps(func)
       def standalone_func(*a):
   >       return func(*(a + p.args), **p.kwargs)
   
   /usr/local/lib/python3.6/site-packages/parameterized/parameterized.py:530: 
   _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
   tests/www/test_views.py:646: in test_escape_in_tree_view
       self.check_content_in_response(f'"conf":{{"abc":"{seralized_test_str}"}}', resp)
   tests/www/test_views.py:177: in check_content_in_response
       self.assertIn(text, resp_html)
   E   AssertionError: '"conf":{"abc":"hello\\\\u0027world"}' not found in '\n\n\n\n\n\n\n\n\n\n 
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org