Re: svn commit: r980427 - in /subversion/trunk/subversion: include/svn_wc.h libsvn_client/patch.c svn/notify.c tests/cmdline/patch_tests.py

[Stefan Sperling <st...@elego.de>]

On Thu, Jul 29, 2010 at 12:43:56PM -0000, dannas@apache.org wrote:
> Author: dannas
> Date: Thu Jul 29 12:43:56 2010
> New Revision: 980427
> 
> URL: http://svn.apache.org/viewvc?rev=980427&view=rev
> Log:
> Make 'svn patch' do notifications for property hunks.
> 
> We use the same notification actions as for text hunks but replace
> the headers to look like:
>   '## -1,6 +1,7 ##'
> instead of:
>   '@@ -1,6 +1,7 @@'
> 
> Note that we don't specify what property a hunk belongs to (that information
> is available in the reject file).

Why not provide the propery name to the notification callback,
and print it e.g. like this?

   ## -1,6 +1,7 ## (svn:externals)

Stefan

Re: svn commit: r980427 - in /subversion/trunk/subversion: include/svn_wc.h libsvn_client/patch.c svn/notify.c tests/cmdline/patch_tests.py

[Daniel Näslund <da...@longitudo.com>]

On Thu, Jul 29, 2010 at 02:54:29PM +0200, Stefan Sperling wrote:
> On Thu, Jul 29, 2010 at 12:43:56PM -0000, dannas@apache.org wrote:
> > Author: dannas
> > Date: Thu Jul 29 12:43:56 2010
> > New Revision: 980427
> > 
> > URL: http://svn.apache.org/viewvc?rev=980427&view=rev
> > Log:
> > Make 'svn patch' do notifications for property hunks.
> > 
> > We use the same notification actions as for text hunks but replace
> > the headers to look like:
> >   '## -1,6 +1,7 ##'
> > instead of:
> >   '@@ -1,6 +1,7 @@'
> > 
> > Note that we don't specify what property a hunk belongs to (that information
> > is available in the reject file).
> 
> Why not provide the propery name to the notification callback,
> and print it e.g. like this?
> 
>    ## -1,6 +1,7 ## (svn:externals)

Oh... So obvious. And the precense of n->prop_name tells us if we have a
property hunk or not. I'll do that.

Thanks,
Daniel