You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2021/01/11 16:18:17 UTC
[GitHub] [fineract] davidyaha opened a new pull request #1568: Avoid NullPointerException on calc schedule for floating rate (FINERACT-1286)
davidyaha opened a new pull request #1568:
URL: https://github.com/apache/fineract/pull/1568
## Description
Avoid NullPointerException when trying to calc schedule for floating-rate loans. @vorburger
## Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
- [x] Write the commit message as per https://github.com/apache/fineract/#pull-requests
- [x] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
- [ ] Create/update unit or integration tests for verifying the changes made.
- [x] Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
- [x] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/api-docs/apiLive.htm with details of any API changes
- [x] Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] ptuomola merged pull request #1568: Avoid NullPointerException on calc schedule for floating rate (FINERACT-1286)
Posted by GitBox <gi...@apache.org>.
ptuomola merged pull request #1568:
URL: https://github.com/apache/fineract/pull/1568
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] davidyaha commented on pull request #1568: Avoid NullPointerException on calc schedule for floating rate (FINERACT-1286)
Posted by GitBox <gi...@apache.org>.
davidyaha commented on pull request #1568:
URL: https://github.com/apache/fineract/pull/1568#issuecomment-758538435
Thanks for the quick review and merge @ptuomola!
Does the Jira ticket suppose to resolve automatically? What is the flow there?
Thanks ahead!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] ptuomola commented on pull request #1568: Avoid NullPointerException on calc schedule for floating rate (FINERACT-1286)
Posted by GitBox <gi...@apache.org>.
ptuomola commented on pull request #1568:
URL: https://github.com/apache/fineract/pull/1568#issuecomment-760234774
Unfortunately the JIRA does not resolve itself - so you should resolve the JIRA and set the fix version before resolving.
> On 12 Jan 2021, at 5:48 PM, David Yahalomi <no...@github.com> wrote:
>
>
> Thanks for the quick review and merge @ptuomola <https://github.com/ptuomola>!
>
> Does the Jira ticket suppose to resolve automatically? What is the flow there?
> Thanks ahead!
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub <https://github.com/apache/fineract/pull/1568#issuecomment-758538435>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AASJVCWLURXT3CHJGMRQSFTSZQLILANCNFSM4V5ZOMHA>.
>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org