You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "itholic (via GitHub)" <gi...@apache.org> on 2023/02/10 05:57:49 UTC
[GitHub] [spark] itholic opened a new pull request, #39963: [SPARK-42324][SQL] Assign name to _LEGACY_ERROR_TEMP_1001
itholic opened a new pull request, #39963:
URL: https://github.com/apache/spark/pull/39963
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'core/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
This PR proposes to assign name to _LEGACY_ERROR_TEMP_1001, "UNRESOLVED_USING_COLUMN_FOR_JOIN".
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
We should assign proper name to _LEGACY_ERROR_TEMP_*
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
No
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
`./build/sbt "sql/testOnly org.apache.spark.sql.SQLQueryTestSuite*`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] itholic commented on a diff in pull request #39963: [SPARK-42324][SQL] Assign name to _LEGACY_ERROR_TEMP_1001
Posted by "itholic (via GitHub)" <gi...@apache.org>.
itholic commented on code in PR #39963:
URL: https://github.com/apache/spark/pull/39963#discussion_r1103990643
##########
core/src/main/resources/error/error-classes.json:
##########
@@ -1537,6 +1537,12 @@
],
"sqlState" : "42883"
},
+ "UNRESOLVED_USING_COLUMN_FOR_JOIN" : {
+ "message" : [
+ "USING column <colName> cannot be resolved on the <side> side of the join. The <side>-side columns: [<plan>]."
Review Comment:
Sounds good.
Can I do this in separate ticket to apply changes for all related places, not only for this PR ?
Just created ticket here: SPARK-42414.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] itholic commented on pull request #39963: [SPARK-42324][SQL] Assign name to _LEGACY_ERROR_TEMP_1001
Posted by "itholic (via GitHub)" <gi...@apache.org>.
itholic commented on PR #39963:
URL: https://github.com/apache/spark/pull/39963#issuecomment-1425228479
cc @srielau @MaxGekk Could you review this error class when you find some time?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] itholic commented on a diff in pull request #39963: [SPARK-42324][SQL] Assign name to _LEGACY_ERROR_TEMP_1001
Posted by "itholic (via GitHub)" <gi...@apache.org>.
itholic commented on code in PR #39963:
URL: https://github.com/apache/spark/pull/39963#discussion_r1103466477
##########
core/src/main/resources/error/error-classes.json:
##########
@@ -1537,6 +1537,12 @@
],
"sqlState" : "42883"
},
+ "UNRESOLVED_USING_COLUMN_FOR_JOIN" : {
+ "message" : [
+ "USING column <colName> cannot be resolved on the <side> side of the join. The <side>-side columns: [<plan>]."
+ ],
+ "sqlState" : "42877"
Review Comment:
Oh... I understand what is the differences. Thanks!!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] itholic commented on a diff in pull request #39963: [SPARK-42324][SQL] Assign name to _LEGACY_ERROR_TEMP_1001
Posted by "itholic (via GitHub)" <gi...@apache.org>.
itholic commented on code in PR #39963:
URL: https://github.com/apache/spark/pull/39963#discussion_r1104623355
##########
core/src/main/resources/error/error-classes.json:
##########
@@ -1537,6 +1537,12 @@
],
"sqlState" : "42883"
},
+ "UNRESOLVED_USING_COLUMN_FOR_JOIN" : {
+ "message" : [
+ "USING column <colName> cannot be resolved on the <side> side of the join. The <side>-side columns: [<plan>]."
Review Comment:
Oh... we're using `StringUtils.orderStringsBySimilarity` that returns better candidates in `unresolvedColumnError` as below:
```scala
val orderedCandidates =
StringUtils.orderStringsBySimilarity(f.name, candidates)
throw QueryCompilationErrors.unresolvedColumnError(f.name, orderedCandidates)
```
But, we're just pumping out all columns in `unresolvedColumnWithSuggestionError` as below:
```scala
private def resolveException(colName: String, fields: Array[String]): AnalysisException = {
QueryCompilationErrors.unresolvedColumnWithSuggestionError(
colName, fields.map(toSQLId).mkString(", "))
}
```
Let me integrate `unresolvedColumnWithSuggestionError` into `unresolvedColumnError` so that we can display better suggestions in the error message.
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] itholic commented on a diff in pull request #39963: [SPARK-42324][SQL] Assign name to _LEGACY_ERROR_TEMP_1001
Posted by "itholic (via GitHub)" <gi...@apache.org>.
itholic commented on code in PR #39963:
URL: https://github.com/apache/spark/pull/39963#discussion_r1104627047
##########
core/src/main/resources/error/error-classes.json:
##########
@@ -1537,6 +1537,12 @@
],
"sqlState" : "42883"
},
+ "UNRESOLVED_USING_COLUMN_FOR_JOIN" : {
+ "message" : [
+ "USING column <colName> cannot be resolved on the <side> side of the join. The <side>-side columns: [<plan>]."
Review Comment:
Anyway, let me address within SPARK-42414 at once for all related code path, after this PR is completed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on pull request #39963: [SPARK-42324][SQL] Assign name to _LEGACY_ERROR_TEMP_1001
Posted by "MaxGekk (via GitHub)" <gi...@apache.org>.
MaxGekk commented on PR #39963:
URL: https://github.com/apache/spark/pull/39963#issuecomment-1429138975
+1, LGTM. Merging to master/3.4.
Thank you, @itholic and @srielau for review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] itholic commented on a diff in pull request #39963: [SPARK-42324][SQL] Assign name to _LEGACY_ERROR_TEMP_1001
Posted by "itholic (via GitHub)" <gi...@apache.org>.
itholic commented on code in PR #39963:
URL: https://github.com/apache/spark/pull/39963#discussion_r1103730768
##########
core/src/main/resources/error/error-classes.json:
##########
@@ -1537,6 +1537,12 @@
],
"sqlState" : "42883"
},
+ "UNRESOLVED_USING_COLUMN_FOR_JOIN" : {
+ "message" : [
+ "USING column <colName> cannot be resolved on the <side> side of the join. The <side>-side columns: [<plan>]."
Review Comment:
I updated the code to mimic the behavior of `UNRESOLVED_COLUMN.WITH_SUGGESTION`.
But just realized that `UNRESOLVED_COLUMN.WITH_SUGGESTION` also pump out all columns, so eventually the behavior is not changed.
In anyway the column names should be backquotes, so I did an update.
cc @MaxGekk
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on a diff in pull request #39963: [SPARK-42324][SQL] Assign name to _LEGACY_ERROR_TEMP_1001
Posted by "MaxGekk (via GitHub)" <gi...@apache.org>.
MaxGekk commented on code in PR #39963:
URL: https://github.com/apache/spark/pull/39963#discussion_r1104166582
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala:
##########
@@ -3447,12 +3447,14 @@ class Analyzer(override val catalogManager: CatalogManager) extends RuleExecutor
val leftKeys = joinNames.map { keyName =>
left.output.find(attr => resolver(attr.name, keyName)).getOrElse {
- throw QueryCompilationErrors.unresolvedUsingColForJoinError(keyName, left, "left")
+ throw QueryCompilationErrors.unresolvedUsingColForJoinError(
+ keyName, left.schema.fieldNames.map(toSQLId).mkString(", "), "left")
Review Comment:
The `suggestion` list is not stable, could you sort it, please.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk closed pull request #39963: [SPARK-42324][SQL] Assign name to _LEGACY_ERROR_TEMP_1001
Posted by "MaxGekk (via GitHub)" <gi...@apache.org>.
MaxGekk closed pull request #39963: [SPARK-42324][SQL] Assign name to _LEGACY_ERROR_TEMP_1001
URL: https://github.com/apache/spark/pull/39963
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] itholic commented on a diff in pull request #39963: [SPARK-42324][SQL] Assign name to _LEGACY_ERROR_TEMP_1001
Posted by "itholic (via GitHub)" <gi...@apache.org>.
itholic commented on code in PR #39963:
URL: https://github.com/apache/spark/pull/39963#discussion_r1104296886
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala:
##########
@@ -3447,12 +3447,14 @@ class Analyzer(override val catalogManager: CatalogManager) extends RuleExecutor
val leftKeys = joinNames.map { keyName =>
left.output.find(attr => resolver(attr.name, keyName)).getOrElse {
- throw QueryCompilationErrors.unresolvedUsingColForJoinError(keyName, left, "left")
+ throw QueryCompilationErrors.unresolvedUsingColForJoinError(
+ keyName, left.schema.fieldNames.map(toSQLId).mkString(", "), "left")
Review Comment:
Sorted!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] itholic commented on a diff in pull request #39963: [SPARK-42324][SQL] Assign name to _LEGACY_ERROR_TEMP_1001
Posted by "itholic (via GitHub)" <gi...@apache.org>.
itholic commented on code in PR #39963:
URL: https://github.com/apache/spark/pull/39963#discussion_r1104623355
##########
core/src/main/resources/error/error-classes.json:
##########
@@ -1537,6 +1537,12 @@
],
"sqlState" : "42883"
},
+ "UNRESOLVED_USING_COLUMN_FOR_JOIN" : {
+ "message" : [
+ "USING column <colName> cannot be resolved on the <side> side of the join. The <side>-side columns: [<plan>]."
Review Comment:
Oh... yes I found that we're using `StringUtils.orderStringsBySimilarity` that returns better candidates in `unresolvedColumnError` as below:
```scala
val orderedCandidates =
StringUtils.orderStringsBySimilarity(f.name, candidates)
throw QueryCompilationErrors.unresolvedColumnError(f.name, orderedCandidates)
```
But, we're just pumping out all columns in `unresolvedColumnWithSuggestionError` as below:
```scala
private def resolveException(colName: String, fields: Array[String]): AnalysisException = {
QueryCompilationErrors.unresolvedColumnWithSuggestionError(
colName, fields.map(toSQLId).mkString(", "))
}
```
Let me integrate `unresolvedColumnWithSuggestionError` into `unresolvedColumnError` so that we can display better suggestions in the error message.
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] itholic commented on a diff in pull request #39963: [SPARK-42324][SQL] Assign name to _LEGACY_ERROR_TEMP_1001
Posted by "itholic (via GitHub)" <gi...@apache.org>.
itholic commented on code in PR #39963:
URL: https://github.com/apache/spark/pull/39963#discussion_r1104627047
##########
core/src/main/resources/error/error-classes.json:
##########
@@ -1537,6 +1537,12 @@
],
"sqlState" : "42883"
},
+ "UNRESOLVED_USING_COLUMN_FOR_JOIN" : {
+ "message" : [
+ "USING column <colName> cannot be resolved on the <side> side of the join. The <side>-side columns: [<plan>]."
Review Comment:
Anyway, let me address within SPARK-42414 at once through all code path, after this PR is completed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on a diff in pull request #39963: [SPARK-42324][SQL] Assign name to _LEGACY_ERROR_TEMP_1001
Posted by "MaxGekk (via GitHub)" <gi...@apache.org>.
MaxGekk commented on code in PR #39963:
URL: https://github.com/apache/spark/pull/39963#discussion_r1103825715
##########
core/src/main/resources/error/error-classes.json:
##########
@@ -1537,6 +1537,12 @@
],
"sqlState" : "42883"
},
+ "UNRESOLVED_USING_COLUMN_FOR_JOIN" : {
+ "message" : [
+ "USING column <colName> cannot be resolved on the <side> side of the join. The <side>-side columns: [<plan>]."
Review Comment:
@itholic Could you restrict the number of columns by sorting the list (to have stable output) and return top 3 columns. Or be more smarter and output 3 columns that starts from the same char as the unresolved column, and if it is empty, just print the first 3 columns of the sorted list.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srielau commented on a diff in pull request #39963: [SPARK-42324][SQL] Assign name to _LEGACY_ERROR_TEMP_1001
Posted by "srielau (via GitHub)" <gi...@apache.org>.
srielau commented on code in PR #39963:
URL: https://github.com/apache/spark/pull/39963#discussion_r1104507371
##########
core/src/main/resources/error/error-classes.json:
##########
@@ -1537,6 +1537,12 @@
],
"sqlState" : "42883"
},
+ "UNRESOLVED_USING_COLUMN_FOR_JOIN" : {
+ "message" : [
+ "USING column <colName> cannot be resolved on the <side> side of the join. The <side>-side columns: [<plan>]."
Review Comment:
@itholic I think we can do better than pre-fix check. See slack.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] itholic commented on a diff in pull request #39963: [SPARK-42324][SQL] Assign name to _LEGACY_ERROR_TEMP_1001
Posted by "itholic (via GitHub)" <gi...@apache.org>.
itholic commented on code in PR #39963:
URL: https://github.com/apache/spark/pull/39963#discussion_r1103467447
##########
core/src/main/resources/error/error-classes.json:
##########
@@ -1537,6 +1537,12 @@
],
"sqlState" : "42883"
},
+ "UNRESOLVED_USING_COLUMN_FOR_JOIN" : {
+ "message" : [
+ "USING column <colName> cannot be resolved on the <side> side of the join. The <side>-side columns: [<plan>]."
Review Comment:
Sounds good! Will address to use the suggestion.
Thanks!!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srielau commented on a diff in pull request #39963: [SPARK-42324][SQL] Assign name to _LEGACY_ERROR_TEMP_1001
Posted by "srielau (via GitHub)" <gi...@apache.org>.
srielau commented on code in PR #39963:
URL: https://github.com/apache/spark/pull/39963#discussion_r1103814792
##########
core/src/main/resources/error/error-classes.json:
##########
@@ -1537,6 +1537,12 @@
],
"sqlState" : "42883"
},
+ "UNRESOLVED_USING_COLUMN_FOR_JOIN" : {
+ "message" : [
+ "USING column <colName> cannot be resolved on the <side> side of the join. The <side>-side columns: [<plan>]."
Review Comment:
"But just realized that UNRESOLVED_COLUMN.WITH_SUGGESTION also pump out all column"
Huh? @MaxGekk
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on pull request #39963: [SPARK-42324][SQL] Assign name to _LEGACY_ERROR_TEMP_1001
Posted by "MaxGekk (via GitHub)" <gi...@apache.org>.
MaxGekk commented on PR #39963:
URL: https://github.com/apache/spark/pull/39963#issuecomment-1427763691
Waiting for CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on a diff in pull request #39963: [SPARK-42324][SQL] Assign name to _LEGACY_ERROR_TEMP_1001
Posted by "MaxGekk (via GitHub)" <gi...@apache.org>.
MaxGekk commented on code in PR #39963:
URL: https://github.com/apache/spark/pull/39963#discussion_r1103996355
##########
core/src/main/resources/error/error-classes.json:
##########
@@ -1537,6 +1537,12 @@
],
"sqlState" : "42883"
},
+ "UNRESOLVED_USING_COLUMN_FOR_JOIN" : {
+ "message" : [
+ "USING column <colName> cannot be resolved on the <side> side of the join. The <side>-side columns: [<plan>]."
Review Comment:
> Can I do this in separate ticket to apply changes for all related places, not only for this PR ?
@itholic Sure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srielau commented on a diff in pull request #39963: [SPARK-42324][SQL] Assign name to _LEGACY_ERROR_TEMP_1001
Posted by "srielau (via GitHub)" <gi...@apache.org>.
srielau commented on code in PR #39963:
URL: https://github.com/apache/spark/pull/39963#discussion_r1103149937
##########
core/src/main/resources/error/error-classes.json:
##########
@@ -1537,6 +1537,12 @@
],
"sqlState" : "42883"
},
+ "UNRESOLVED_USING_COLUMN_FOR_JOIN" : {
+ "message" : [
+ "USING column <colName> cannot be resolved on the <side> side of the join. The <side>-side columns: [<plan>]."
Review Comment:
USING column `c0` cannot be resolved on the left side of the join. The left-side columns: [c1, c2, c3].
Do we use the suggestion code we have for UNRSOLVED_COLUMN>? We should NOT pump out all columns.
```suggestion
"USING column <colName> cannot be resolved on the <side> side of the join. The <side>-side columns: [<suggestion>]."
```
##########
core/src/main/resources/error/error-classes.json:
##########
@@ -1537,6 +1537,12 @@
],
"sqlState" : "42883"
},
+ "UNRESOLVED_USING_COLUMN_FOR_JOIN" : {
+ "message" : [
+ "USING column <colName> cannot be resolved on the <side> side of the join. The <side>-side columns: [<plan>]."
+ ],
+ "sqlState" : "42877"
Review Comment:
42877 is for illegally qualified columns e.g. USING (t.c1) (a syntax error for us)
```suggestion
"sqlState" : "42703"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng commented on pull request #39963: [SPARK-42324][SQL] Assign name to _LEGACY_ERROR_TEMP_1001
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng commented on PR #39963:
URL: https://github.com/apache/spark/pull/39963#issuecomment-1429228383
It seems that `SparkConnectProtoSuite` was broken after this PR, I send a followup https://github.com/apache/spark/pull/40007
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org