You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/12/15 19:55:08 UTC
[GitHub] [airflow] kaxil opened a new pull request #13090: Add guidelines for promoting Committers to PMC
kaxil opened a new pull request #13090:
URL: https://github.com/apache/airflow/pull/13090
This is based on the discussion on the mailing list and proposal from various PMC Members
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] turbaszek commented on a change in pull request #13090: Add guidelines for promoting Committers to PMC
Posted by GitBox <gi...@apache.org>.
turbaszek commented on a change in pull request #13090:
URL: https://github.com/apache/airflow/pull/13090#discussion_r544113025
##########
File path: CONTRIBUTING.rst
##########
@@ -135,6 +135,67 @@ The key aspects of a committer are:
* Visibility in community discussions (dev mailing list, Slack and GitHub)
* Testing Release Candidates
+Guidelines for promoting Committers to Airflow PMC
+---------------------------------------------------
+
+To become a PMC member the committers should meet all **general prerequisites**.
+Apart from that the person should demonstrate distinct **community involvement** or **code contributions**.
+
+Prerequisites
+==============
+
+* Has been a committer for at least 3 months
+* Is still active community member
Review comment:
What is the measure of activity?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil merged pull request #13090: Add guidelines for promoting Committers to PMC
Posted by GitBox <gi...@apache.org>.
kaxil merged pull request #13090:
URL: https://github.com/apache/airflow/pull/13090
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on a change in pull request #13090: Add guidelines for promoting Committers to PMC
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #13090:
URL: https://github.com/apache/airflow/pull/13090#discussion_r544691017
##########
File path: CONTRIBUTING.rst
##########
@@ -135,6 +135,67 @@ The key aspects of a committer are:
* Visibility in community discussions (dev mailing list, Slack and GitHub)
* Testing Release Candidates
+Guidelines for promoting Committers to Airflow PMC
Review comment:
Updated in https://github.com/apache/airflow/pull/13090/commits/4bc8e4ef24368afc778f2dbfd2bc4056c84add8e
##########
File path: CONTRIBUTING.rst
##########
@@ -135,6 +135,67 @@ The key aspects of a committer are:
* Visibility in community discussions (dev mailing list, Slack and GitHub)
* Testing Release Candidates
+Guidelines for promoting Committers to Airflow PMC
+---------------------------------------------------
+
+To become a PMC member the committers should meet all **general prerequisites**.
+Apart from that the person should demonstrate distinct **community involvement** or **code contributions**.
+
+Prerequisites
+==============
+
+* Has been a committer for at least 3 months
+* Is still active community member
+
+Community involvement
+======================
+
+* Visibility on discussions on the dev mailing list
+* Spreading the “Airflow” either:
+
+ * Talks at meetups, conferences, etc
+ * Creating content (videos, blogs etc)
Review comment:
Updated in https://github.com/apache/airflow/pull/13090/commits/4bc8e4ef24368afc778f2dbfd2bc4056c84add8e
##########
File path: CONTRIBUTING.rst
##########
@@ -135,6 +135,67 @@ The key aspects of a committer are:
* Visibility in community discussions (dev mailing list, Slack and GitHub)
* Testing Release Candidates
+Guidelines for promoting Committers to Airflow PMC
+---------------------------------------------------
+
+To become a PMC member the committers should meet all **general prerequisites**.
+Apart from that the person should demonstrate distinct **community involvement** or **code contributions**.
+
+Prerequisites
+==============
+
+* Has been a committer for at least 3 months
+* Is still active community member
Review comment:
Updated in https://github.com/apache/airflow/pull/13090/commits/4bc8e4ef24368afc778f2dbfd2bc4056c84add8e
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #13090: Add guidelines for promoting Committers to PMC
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13090:
URL: https://github.com/apache/airflow/pull/13090#issuecomment-747103842
The PR is likely ready to be merged. No tests are needed as no important environment files, nor python files were modified by it. However, committers might decide that full test matrix is needed and add the 'full tests needed' label. Then you should rebase it to the latest master or amend the last commit of the PR, and push it with --force-with-lease.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] turbaszek commented on a change in pull request #13090: Add guidelines for promoting Committers to PMC
Posted by GitBox <gi...@apache.org>.
turbaszek commented on a change in pull request #13090:
URL: https://github.com/apache/airflow/pull/13090#discussion_r544113600
##########
File path: CONTRIBUTING.rst
##########
@@ -135,6 +135,67 @@ The key aspects of a committer are:
* Visibility in community discussions (dev mailing list, Slack and GitHub)
* Testing Release Candidates
+Guidelines for promoting Committers to Airflow PMC
+---------------------------------------------------
+
+To become a PMC member the committers should meet all **general prerequisites**.
+Apart from that the person should demonstrate distinct **community involvement** or **code contributions**.
+
+Prerequisites
+==============
+
+* Has been a committer for at least 3 months
+* Is still active community member
+
+Community involvement
+======================
+
+* Visibility on discussions on the dev mailing list
+* Spreading the “Airflow” either:
+
+ * Talks at meetups, conferences, etc
+ * Creating content (videos, blogs etc)
Review comment:
```suggestion
* Creating content like videos, blogs, etc
```
Will be more consistent with previous bullet
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] turbaszek commented on a change in pull request #13090: Add guidelines for promoting Committers to PMC
Posted by GitBox <gi...@apache.org>.
turbaszek commented on a change in pull request #13090:
URL: https://github.com/apache/airflow/pull/13090#discussion_r544116393
##########
File path: CONTRIBUTING.rst
##########
@@ -135,6 +135,67 @@ The key aspects of a committer are:
* Visibility in community discussions (dev mailing list, Slack and GitHub)
* Testing Release Candidates
+Guidelines for promoting Committers to Airflow PMC
Review comment:
Should we link somewhere the official ASF guidelines?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org