You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by Steven Gill <st...@gmail.com> on 2012/04/12 23:17:50 UTC
1.6.1
So a bug has been discovered in Cordova Android that requires a new tag and
release. You can check out the bug on the issue tracker at
https://issues.apache.org/jira/browse/CB-490?focusedCommentId=13252809#comment-13252809
It doesn't make sense to just repackage 1.6.0 with this bug fixed as we
will have no way to know if people are experiencing this or not.
Anis mentioned Bada also had some major issues which he has fixed now and
would like in a 1.6.1 release.
Thoughts?
-Steve
Re: 1.6.1
Posted by Shazron <sh...@gmail.com>.
Sorry didn't expect a 1.6.1 release, this was a user contrib for
1.7.0. I can tag my 1.6.0 as 1.6.1, but don't know how that will work
with cordova-js - have to branch off 1.6.0 and cherry-pick CB-495
(then tag that branch 1.6.1) if you don't want this in.
On Thu, Apr 12, 2012 at 2:52 PM, Filip Maj <fi...@adobe.com> wrote:
> I was actually just looking at that myself.
>
> Looks like it's an iOS-only param.. sigh. We gotta stop doing that,
> especially if we don't update documentation.
>
> On 4/12/12 2:49 PM, "Joe Bowser" <bo...@gmail.com> wrote:
>
>>Has anyone tested the cropToSize param for Camera.getPicture yet? I
>>didn't
>>notice that change until now.
>>
>>On Thu, Apr 12, 2012 at 2:46 PM, Filip Maj <fi...@adobe.com> wrote:
>>
>>> JS tagged 1.6.1 - the build task in the JS should work properly now.
>>>
>>> FYI if anyone has to modify the jake tasks in the future and make them
>>> async, make sure you add the 4th "async" parameter to the task()
>>>function
>>> and set it to true, and call complete() when the task is done.
>>>
>>> See http://howtonode.org/intro-to-jake/async-jakefile.js for an example.
>>>
>>> On 4/12/12 2:35 PM, "Joe Bowser" <bo...@gmail.com> wrote:
>>>
>>> >Ready to tag once cordova-js is tagged 1.6.1.
>>> >
>>> >On Thu, Apr 12, 2012 at 2:33 PM, Anis KADRI <an...@gmail.com>
>>>wrote:
>>> >
>>> >> I will tag my repository to 1.6.1 before end of day today after some
>>> >> thorough testing.
>>> >>
>>> >> On Thu, Apr 12, 2012 at 2:30 PM, Shazron <sh...@gmail.com> wrote:
>>> >>
>>> >> > I also created a 1.6.1 version tag as well in jira...
>>> >> >
>>> >> > On Thu, Apr 12, 2012 at 2:29 PM, Shazron <sh...@gmail.com> wrote:
>>> >> > > Alright guys since 1.6.0 was released, I'm going to "Release" the
>>> >> > > 1.6.0 version in jira and move outstanding issues to 1.7.0
>>>version
>>> >> > > tag.
>>> >> > >
>>> >> > >
>>> >> > > On Thu, Apr 12, 2012 at 2:26 PM, Filip Maj <fi...@adobe.com> wrote:
>>> >> > >> The JS needs patching too. Since adding the commit ID into the
>>> >> packaging
>>> >> > >> in the jakefile, the default task isn't running properly.
>>> >> > >>
>>> >> > >> You can manually run "jake build" and "jake test" but not
>>>"jake" on
>>> >> its
>>> >> > >> own - gonna try to figure it out.
>>> >> > >>
>>> >> > >> On 4/12/12 2:21 PM, "Shazron" <sh...@gmail.com> wrote:
>>> >> > >>
>>> >> > >>>I'm good with tagging. iOS has a few commits (one commit in
>>> >> > >>>cordova-js) as well. Aim for first thing tomorrow for you to
>>> >> > >>>repackage?
>>> >> > >>>
>>> >> > >>>On Thu, Apr 12, 2012 at 2:17 PM, Steven Gill
>>> >><st...@gmail.com>
>>> >> > >>>wrote:
>>> >> > >>>> So a bug has been discovered in Cordova Android that requires
>>>a
>>> >>new
>>> >> > tag
>>> >> > >>>>and
>>> >> > >>>> release. You can check out the bug on the issue tracker at
>>> >> > >>>>
>>> >> > >>>>
>>> >> >
>>> >>
>>> >>
>>>
>>>https://issues.apache.org/jira/browse/CB-490?focusedCommentId=13252809#co
>>> >> > >>>>mment-13252809
>>> >> > >>>>
>>> >> > >>>> It doesn't make sense to just repackage 1.6.0 with this bug
>>> >>fixed as
>>> >> > we
>>> >> > >>>> will have no way to know if people are experiencing this or
>>>not.
>>> >> > >>>>
>>> >> > >>>> Anis mentioned Bada also had some major issues which he has
>>>fixed
>>> >> now
>>> >> > >>>>and
>>> >> > >>>> would like in a 1.6.1 release.
>>> >> > >>>>
>>> >> > >>>> Thoughts?
>>> >> > >>>>
>>> >> > >>>> -Steve
>>> >> > >>
>>> >> >
>>> >>
>>>
>>>
>
Re: 1.6.1
Posted by Brian LeRoux <b...@brian.io>.
The docs in 1.5 were an issue. No question. That rattled the community
and rightfully so. And they are fixed in 1.6.
Quality, from my perspective has never been higher. Go have a read of
CordovaJS and then look at the JS for 1.3 and tell me that isn't a
significant improvement! Across platforms we are more consistent than
ever.
As to adoption, downloads are up, roughly 10-25% week on week for
2012. I think a big part of that is the fact that we roll releases so
quickly addressing issues immediately rather than holding out.
On Fri, Apr 13, 2012 at 9:37 AM, Paul Beusterien
<pa...@gmail.com> wrote:
> My concern is more meta than any single release. It's about the PhoneGap
> reputation erosion caused by degradation of quality and usability in recent
> releases.
>
> Paul
>
> On Fri, Apr 13, 2012 at 9:21 AM, Brian LeRoux <b...@brian.io> wrote:
>
>> And, one more thing, if you have concerns about 1.7 lets start a thread
>> for 1.7
>>
>> On Fri, Apr 13, 2012 at 9:18 AM, Brian LeRoux <b...@brian.io> wrote:
>> > I wholeheartedly disagree Paul. These are fixes not changes.
>> >
>> >
>> > On Fri, Apr 13, 2012 at 9:08 AM, Paul Beusterien
>> > <pa...@gmail.com> wrote:
>> >> "Which is a good thing"
>> >>
>> >> For who ?!?!
>> >>
>> >> Definitely not for users and prospective adopters, for whom the rapid
>> pace
>> >> of releases with new bugs, usability changes, misleading documentation
>> and
>> >> new configurations is a barrier to adoption.
>> >>
>> >> Paul
>> >>
>> >>
>> >> On Fri, Apr 13, 2012 at 8:42 AM, Brian LeRoux <b...@brian.io> wrote:
>> >>
>> >>> Ok, everyone back away from the ledge! We discussed 1.7 as a bug fix
>> >>> only release. (Excepting possibly CordovaView which I think might be
>> >>> why Joe is concerned.) Again only bug fixes, and docs updates. The
>> >>> date is arbitrary but the benefit is a release that is all about
>> >>> hardening.
>> >>>
>> >>> Looks like we might even ship a point release between now and then.
>> >>> Which is a good thing: not a bad thing.
>> >>>
>> >>> The longer a delay between releases the more things that can creep in
>> >>> delaying further and making each point a monolith which increases our
>> >>> odds of a bad release. [1]
>> >>>
>> >>> [1]
>> >>>
>> http://phonegap.com/2012/04/12/rolling-releases-how-apache-cordova-becomes-phonegap-and-why/
>> >>>
>> >>>
>> >>> On Fri, Apr 13, 2012 at 8:27 AM, Patrick Mueller <pm...@gmail.com>
>> >>> wrote:
>> >>> > On Fri, Apr 13, 2012 at 11:24, Brian LeRoux <b...@brian.io> wrote:
>> >>> >
>> >>> >> For two bugs? Let's not get too excited.
>> >>> >>
>> >>> >
>> >>> > from: http://wiki.apache.org/cordova/CuttingReleases
>> >>> >
>> >>> > 2012 **Estimated** Release Schedule
>> >>> > ...
>> >>> > * 1.7.x, Apr 30
>> >>> >
>> >>> > So, we're on track to ship 1.7 in ~two weeks?
>> >>> >
>> >>> > --
>> >>> > Patrick Mueller
>> >>> > http://muellerware.org
>> >>>
>> >>
>> >>
>> >>
>> >> --
>> >> Paul Beusterien
>> >> http://www.mobiledevelopersolutions.com
>>
>
>
>
> --
> Paul Beusterien
> 1-650-918-7074
> skype:paul.beusterien
> http://www.mobiledevelopersolutions.com
Re: 1.6.1
Posted by Paul Beusterien <pa...@gmail.com>.
My concern is more meta than any single release. It's about the PhoneGap
reputation erosion caused by degradation of quality and usability in recent
releases.
Paul
On Fri, Apr 13, 2012 at 9:21 AM, Brian LeRoux <b...@brian.io> wrote:
> And, one more thing, if you have concerns about 1.7 lets start a thread
> for 1.7
>
> On Fri, Apr 13, 2012 at 9:18 AM, Brian LeRoux <b...@brian.io> wrote:
> > I wholeheartedly disagree Paul. These are fixes not changes.
> >
> >
> > On Fri, Apr 13, 2012 at 9:08 AM, Paul Beusterien
> > <pa...@gmail.com> wrote:
> >> "Which is a good thing"
> >>
> >> For who ?!?!
> >>
> >> Definitely not for users and prospective adopters, for whom the rapid
> pace
> >> of releases with new bugs, usability changes, misleading documentation
> and
> >> new configurations is a barrier to adoption.
> >>
> >> Paul
> >>
> >>
> >> On Fri, Apr 13, 2012 at 8:42 AM, Brian LeRoux <b...@brian.io> wrote:
> >>
> >>> Ok, everyone back away from the ledge! We discussed 1.7 as a bug fix
> >>> only release. (Excepting possibly CordovaView which I think might be
> >>> why Joe is concerned.) Again only bug fixes, and docs updates. The
> >>> date is arbitrary but the benefit is a release that is all about
> >>> hardening.
> >>>
> >>> Looks like we might even ship a point release between now and then.
> >>> Which is a good thing: not a bad thing.
> >>>
> >>> The longer a delay between releases the more things that can creep in
> >>> delaying further and making each point a monolith which increases our
> >>> odds of a bad release. [1]
> >>>
> >>> [1]
> >>>
> http://phonegap.com/2012/04/12/rolling-releases-how-apache-cordova-becomes-phonegap-and-why/
> >>>
> >>>
> >>> On Fri, Apr 13, 2012 at 8:27 AM, Patrick Mueller <pm...@gmail.com>
> >>> wrote:
> >>> > On Fri, Apr 13, 2012 at 11:24, Brian LeRoux <b...@brian.io> wrote:
> >>> >
> >>> >> For two bugs? Let's not get too excited.
> >>> >>
> >>> >
> >>> > from: http://wiki.apache.org/cordova/CuttingReleases
> >>> >
> >>> > 2012 **Estimated** Release Schedule
> >>> > ...
> >>> > * 1.7.x, Apr 30
> >>> >
> >>> > So, we're on track to ship 1.7 in ~two weeks?
> >>> >
> >>> > --
> >>> > Patrick Mueller
> >>> > http://muellerware.org
> >>>
> >>
> >>
> >>
> >> --
> >> Paul Beusterien
> >> http://www.mobiledevelopersolutions.com
>
--
Paul Beusterien
1-650-918-7074
skype:paul.beusterien
http://www.mobiledevelopersolutions.com
Re: 1.6.1
Posted by Brian LeRoux <b...@brian.io>.
And, one more thing, if you have concerns about 1.7 lets start a thread for 1.7
On Fri, Apr 13, 2012 at 9:18 AM, Brian LeRoux <b...@brian.io> wrote:
> I wholeheartedly disagree Paul. These are fixes not changes.
>
>
> On Fri, Apr 13, 2012 at 9:08 AM, Paul Beusterien
> <pa...@gmail.com> wrote:
>> "Which is a good thing"
>>
>> For who ?!?!
>>
>> Definitely not for users and prospective adopters, for whom the rapid pace
>> of releases with new bugs, usability changes, misleading documentation and
>> new configurations is a barrier to adoption.
>>
>> Paul
>>
>>
>> On Fri, Apr 13, 2012 at 8:42 AM, Brian LeRoux <b...@brian.io> wrote:
>>
>>> Ok, everyone back away from the ledge! We discussed 1.7 as a bug fix
>>> only release. (Excepting possibly CordovaView which I think might be
>>> why Joe is concerned.) Again only bug fixes, and docs updates. The
>>> date is arbitrary but the benefit is a release that is all about
>>> hardening.
>>>
>>> Looks like we might even ship a point release between now and then.
>>> Which is a good thing: not a bad thing.
>>>
>>> The longer a delay between releases the more things that can creep in
>>> delaying further and making each point a monolith which increases our
>>> odds of a bad release. [1]
>>>
>>> [1]
>>> http://phonegap.com/2012/04/12/rolling-releases-how-apache-cordova-becomes-phonegap-and-why/
>>>
>>>
>>> On Fri, Apr 13, 2012 at 8:27 AM, Patrick Mueller <pm...@gmail.com>
>>> wrote:
>>> > On Fri, Apr 13, 2012 at 11:24, Brian LeRoux <b...@brian.io> wrote:
>>> >
>>> >> For two bugs? Let's not get too excited.
>>> >>
>>> >
>>> > from: http://wiki.apache.org/cordova/CuttingReleases
>>> >
>>> > 2012 **Estimated** Release Schedule
>>> > ...
>>> > * 1.7.x, Apr 30
>>> >
>>> > So, we're on track to ship 1.7 in ~two weeks?
>>> >
>>> > --
>>> > Patrick Mueller
>>> > http://muellerware.org
>>>
>>
>>
>>
>> --
>> Paul Beusterien
>> http://www.mobiledevelopersolutions.com
Re: 1.6.1
Posted by Brian LeRoux <b...@brian.io>.
I wholeheartedly disagree Paul. These are fixes not changes.
On Fri, Apr 13, 2012 at 9:08 AM, Paul Beusterien
<pa...@gmail.com> wrote:
> "Which is a good thing"
>
> For who ?!?!
>
> Definitely not for users and prospective adopters, for whom the rapid pace
> of releases with new bugs, usability changes, misleading documentation and
> new configurations is a barrier to adoption.
>
> Paul
>
>
> On Fri, Apr 13, 2012 at 8:42 AM, Brian LeRoux <b...@brian.io> wrote:
>
>> Ok, everyone back away from the ledge! We discussed 1.7 as a bug fix
>> only release. (Excepting possibly CordovaView which I think might be
>> why Joe is concerned.) Again only bug fixes, and docs updates. The
>> date is arbitrary but the benefit is a release that is all about
>> hardening.
>>
>> Looks like we might even ship a point release between now and then.
>> Which is a good thing: not a bad thing.
>>
>> The longer a delay between releases the more things that can creep in
>> delaying further and making each point a monolith which increases our
>> odds of a bad release. [1]
>>
>> [1]
>> http://phonegap.com/2012/04/12/rolling-releases-how-apache-cordova-becomes-phonegap-and-why/
>>
>>
>> On Fri, Apr 13, 2012 at 8:27 AM, Patrick Mueller <pm...@gmail.com>
>> wrote:
>> > On Fri, Apr 13, 2012 at 11:24, Brian LeRoux <b...@brian.io> wrote:
>> >
>> >> For two bugs? Let's not get too excited.
>> >>
>> >
>> > from: http://wiki.apache.org/cordova/CuttingReleases
>> >
>> > 2012 **Estimated** Release Schedule
>> > ...
>> > * 1.7.x, Apr 30
>> >
>> > So, we're on track to ship 1.7 in ~two weeks?
>> >
>> > --
>> > Patrick Mueller
>> > http://muellerware.org
>>
>
>
>
> --
> Paul Beusterien
> http://www.mobiledevelopersolutions.com
Re: 1.6.1
Posted by Paul Beusterien <pa...@gmail.com>.
"Which is a good thing"
For who ?!?!
Definitely not for users and prospective adopters, for whom the rapid pace
of releases with new bugs, usability changes, misleading documentation and
new configurations is a barrier to adoption.
Paul
On Fri, Apr 13, 2012 at 8:42 AM, Brian LeRoux <b...@brian.io> wrote:
> Ok, everyone back away from the ledge! We discussed 1.7 as a bug fix
> only release. (Excepting possibly CordovaView which I think might be
> why Joe is concerned.) Again only bug fixes, and docs updates. The
> date is arbitrary but the benefit is a release that is all about
> hardening.
>
> Looks like we might even ship a point release between now and then.
> Which is a good thing: not a bad thing.
>
> The longer a delay between releases the more things that can creep in
> delaying further and making each point a monolith which increases our
> odds of a bad release. [1]
>
> [1]
> http://phonegap.com/2012/04/12/rolling-releases-how-apache-cordova-becomes-phonegap-and-why/
>
>
> On Fri, Apr 13, 2012 at 8:27 AM, Patrick Mueller <pm...@gmail.com>
> wrote:
> > On Fri, Apr 13, 2012 at 11:24, Brian LeRoux <b...@brian.io> wrote:
> >
> >> For two bugs? Let's not get too excited.
> >>
> >
> > from: http://wiki.apache.org/cordova/CuttingReleases
> >
> > 2012 **Estimated** Release Schedule
> > ...
> > * 1.7.x, Apr 30
> >
> > So, we're on track to ship 1.7 in ~two weeks?
> >
> > --
> > Patrick Mueller
> > http://muellerware.org
>
--
Paul Beusterien
http://www.mobiledevelopersolutions.com
Re: 1.6.1
Posted by Brian LeRoux <b...@brian.io>.
Ok, everyone back away from the ledge! We discussed 1.7 as a bug fix
only release. (Excepting possibly CordovaView which I think might be
why Joe is concerned.) Again only bug fixes, and docs updates. The
date is arbitrary but the benefit is a release that is all about
hardening.
Looks like we might even ship a point release between now and then.
Which is a good thing: not a bad thing.
The longer a delay between releases the more things that can creep in
delaying further and making each point a monolith which increases our
odds of a bad release. [1]
[1] http://phonegap.com/2012/04/12/rolling-releases-how-apache-cordova-becomes-phonegap-and-why/
On Fri, Apr 13, 2012 at 8:27 AM, Patrick Mueller <pm...@gmail.com> wrote:
> On Fri, Apr 13, 2012 at 11:24, Brian LeRoux <b...@brian.io> wrote:
>
>> For two bugs? Let's not get too excited.
>>
>
> from: http://wiki.apache.org/cordova/CuttingReleases
>
> 2012 **Estimated** Release Schedule
> ...
> * 1.7.x, Apr 30
>
> So, we're on track to ship 1.7 in ~two weeks?
>
> --
> Patrick Mueller
> http://muellerware.org
Re: 1.6.1
Posted by Patrick Mueller <pm...@gmail.com>.
On Fri, Apr 13, 2012 at 11:24, Brian LeRoux <b...@brian.io> wrote:
> For two bugs? Let's not get too excited.
>
from: http://wiki.apache.org/cordova/CuttingReleases
2012 **Estimated** Release Schedule
...
* 1.7.x, Apr 30
So, we're on track to ship 1.7 in ~two weeks?
--
Patrick Mueller
http://muellerware.org
Re: 1.6.1
Posted by Brian LeRoux <b...@brian.io>.
For two bugs? Let's not get too excited.
On Friday, April 13, 2012, Joe Bowser wrote:
> If we're doing this, can we move the release date of 1.7? I don't like the
> can of worms we're opening here.
> On Apr 13, 2012 8:01 AM, "Filip Maj" <fi...@adobe.com> wrote:
>
> > Yeh agreed. I've changed the release date of 1.6.1 in JIRA to Monday.
> >
> >
> >
> > On 4/13/12 7:05 AM, "Shazron" <sh...@gmail.com> wrote:
> >
> > >+1 seems like more bugs are getting shaken out of the tree. Just
> > >discovered another one:
> > >https://issues.apache.org/jira/browse/CB-501
> > >
> > >On Fri, Apr 13, 2012 at 6:59 AM, Simon MacDonald
> > ><si...@gmail.com> wrote:
> > >> Maybe we should wait until Monday before re-tagging? I mean if we are
> > >> going to re-release let's give it a few more days to shake out these
> > >> issues.
> > >>
> > >> Simon Mac Donald
> > >> http://hi.im/simonmacdonald
> > >>
> > >>
> > >>
> > >> On Fri, Apr 13, 2012 at 9:54 AM, Shazron <sh...@gmail.com> wrote:
> > >>> Users are discovering more bugs:
> > >>> https://issues.apache.org/jira/browse/CB-497
> > >>>
> > >>>
> > https://github.com/apache/incubator-cordova-ios/blob/master/CordovaLib/C
> > >>>lasses/CDVConnection.m#L103
> > >>>
> > >>> So I'm going to have to review, fix and re-tag, so wait up.
> > >>>
> > >>>
> > >>> On Thu, Apr 12, 2012 at 5:38 PM, Jesse <pu...@gmail.com>
> > wrote:
> > >>>> I am commited and tagged
> > >>>>
> > >>>> On Thu, Apr 12, 2012 at 5:27 PM, Shazron <sh...@gmail.com> wrote:
> > >>>>
> > >>>>> Logic error - no worries, I patched it (going to re-do 1.6.1 iOS)
> > >>>>>
> > >>>>> On Thu, Apr 12, 2012 at 5:27 PM, Filip Maj <fi...@adobe.com> wrote:
> > >>>>> > Did I f that up?
> > >>>>> >
> > >>>>> > On 4/12/12 5:07 PM, "Shazron" <sh...@gmail.com> wrote:
> > >>>>> >
> > >>>>> >>Sigh - user reported iOS bug
> > >>>>> >>
> > >>>>>
> > >>>>>
> > http://groups.google.com/group/phonegap/browse_thread/thread/faad0af97
> > >>>>>dec8
> > >>>>> >>907
> > >>>>> >>(you know who you are ;)
> > >>>>> >>
> > >>>>> >>On Thu, Apr 12, 2012 at 5:05 PM, Filip Maj <fi...@adobe.com>
> wrote:
> > >>>>> >>> Saweet! Nice work Anis. That kills off a bunch of old issues in
> > >>>>>JIRA
> > >>>>> >>>too.
> > >>>>> >>>
> > >>>>> >>> Way to hunker down all. As Jesse pointed out to me, we did 45
> > >>>>>emails in
> > >>>>> >>> two hours haha
> > >>>>> >>>
> > >>>>> >>> On 4/12/12 5:00 PM, "Anis KADRI" <an...@gmail.com> wrote:
> > >>>>> >>>
> > >>>>> >>>>Bada 1.2 is tagged 1.6.1. I added the new Cordova artwork,
> > >>>>> >>>>LICENSE/NOTICE
> > >>>>> >>>>files as well as the Apache source headers in every source
> file.
> > >>>>>I
> > >>>>> fixe
Re: 1.6.1
Posted by Joe Bowser <bo...@gmail.com>.
If we're doing this, can we move the release date of 1.7? I don't like the
can of worms we're opening here.
On Apr 13, 2012 8:01 AM, "Filip Maj" <fi...@adobe.com> wrote:
> Yeh agreed. I've changed the release date of 1.6.1 in JIRA to Monday.
>
>
>
> On 4/13/12 7:05 AM, "Shazron" <sh...@gmail.com> wrote:
>
> >+1 seems like more bugs are getting shaken out of the tree. Just
> >discovered another one:
> >https://issues.apache.org/jira/browse/CB-501
> >
> >On Fri, Apr 13, 2012 at 6:59 AM, Simon MacDonald
> ><si...@gmail.com> wrote:
> >> Maybe we should wait until Monday before re-tagging? I mean if we are
> >> going to re-release let's give it a few more days to shake out these
> >> issues.
> >>
> >> Simon Mac Donald
> >> http://hi.im/simonmacdonald
> >>
> >>
> >>
> >> On Fri, Apr 13, 2012 at 9:54 AM, Shazron <sh...@gmail.com> wrote:
> >>> Users are discovering more bugs:
> >>> https://issues.apache.org/jira/browse/CB-497
> >>>
> >>>
> https://github.com/apache/incubator-cordova-ios/blob/master/CordovaLib/C
> >>>lasses/CDVConnection.m#L103
> >>>
> >>> So I'm going to have to review, fix and re-tag, so wait up.
> >>>
> >>>
> >>> On Thu, Apr 12, 2012 at 5:38 PM, Jesse <pu...@gmail.com>
> wrote:
> >>>> I am commited and tagged
> >>>>
> >>>> On Thu, Apr 12, 2012 at 5:27 PM, Shazron <sh...@gmail.com> wrote:
> >>>>
> >>>>> Logic error - no worries, I patched it (going to re-do 1.6.1 iOS)
> >>>>>
> >>>>> On Thu, Apr 12, 2012 at 5:27 PM, Filip Maj <fi...@adobe.com> wrote:
> >>>>> > Did I f that up?
> >>>>> >
> >>>>> > On 4/12/12 5:07 PM, "Shazron" <sh...@gmail.com> wrote:
> >>>>> >
> >>>>> >>Sigh - user reported iOS bug
> >>>>> >>
> >>>>>
> >>>>>
> http://groups.google.com/group/phonegap/browse_thread/thread/faad0af97
> >>>>>dec8
> >>>>> >>907
> >>>>> >>(you know who you are ;)
> >>>>> >>
> >>>>> >>On Thu, Apr 12, 2012 at 5:05 PM, Filip Maj <fi...@adobe.com> wrote:
> >>>>> >>> Saweet! Nice work Anis. That kills off a bunch of old issues in
> >>>>>JIRA
> >>>>> >>>too.
> >>>>> >>>
> >>>>> >>> Way to hunker down all. As Jesse pointed out to me, we did 45
> >>>>>emails in
> >>>>> >>> two hours haha
> >>>>> >>>
> >>>>> >>> On 4/12/12 5:00 PM, "Anis KADRI" <an...@gmail.com> wrote:
> >>>>> >>>
> >>>>> >>>>Bada 1.2 is tagged 1.6.1. I added the new Cordova artwork,
> >>>>> >>>>LICENSE/NOTICE
> >>>>> >>>>files as well as the Apache source headers in every source file.
> >>>>>I
> >>>>> fixed
> >>>>> >>>>all the bugs I sawS
> >>>>> >>>>
> >>>>> >>>>On Thu, Apr 12, 2012 at 4:38 PM, Joe Bowser <bo...@gmail.com>
> >>>>>wrote:
> >>>>> >>>>
> >>>>> >>>>> Android is tagged.
> >>>>> >>>>>
> >>>>> >>>>> On Thu, Apr 12, 2012 at 4:36 PM, Jesse
> >>>>><pu...@gmail.com>
> >>>>> >>>>>wrote:
> >>>>> >>>>>
> >>>>> >>>>> > Done
> >>>>> >>>>> >
> >>>>> >>>>> > On Thu, Apr 12, 2012 at 4:31 PM, Joe Bowser
> >>>>><bo...@gmail.com>
> >>>>> >>>>>wrote:
> >>>>> >>>>> >
> >>>>> >>>>> > > I'd like to get the JS from the tag, but I need a tag for
> >>>>>that.
> >>>>> >>>>> > >
> >>>>> >>>>> > > On Thu, Apr 12, 2012 at 4:29 PM, Jesse
> >>>>><pu...@gmail.com>
> >>>>> >>>>> wrote:
> >>>>> >>>>> > >
> >>>>> >>>>> > > > Okay, I think it's good, tagging at 16:32 PDT if i don't
> >>>>>hear
> >>>>> >>>>>any
> >>>>> >>>>> > > > complaints.
> >>>>> >>>>> > > >
> >>>>> >>>>> > > > On Thu, Apr 12, 2012 at 4:26 PM, Filip Maj
> >>>>><fi...@adobe.com>
> >>>>> >>>>>wrote:
> >>>>> >>>>> > > >
> >>>>> >>>>> > > > > I just axed the existing 1.6.1 cordova-js tag
> >>>>> >>>>> > > > >
> >>>>> >>>>> > > > > Jesse when you feel you've got everything in there go
> >>>>>ahead
> >>>>> >>>>>and
> >>>>> >>>>>tag
> >>>>> >>>>> > JS
> >>>>> >>>>> > > > >
> >>>>> >>>>> > > > > On 4/12/12 4:20 PM, "Shazron" <sh...@gmail.com>
> >>>>>wrote:
> >>>>> >>>>> > > > >
> >>>>> >>>>> > > > > >Reverted. Just talked to Jesse - he has commits to
> >>>>> cordova-js
> >>>>> >>>>> > coming,
> >>>>> >>>>> > > > > >once those are in we can re-tag cordova-js to 1.6.1
> >>>>> >>>>> > > > > >
> >>>>> >>>>> > > > > >On Thu, Apr 12, 2012 at 4:12 PM, Shazron
> >>>>><shazron@gmail.com
> >>>>> >
> >>>>> >>>>> wrote:
> >>>>> >>>>> > > > > >> I'll remove it. *grabs the shovel*
> >>>>> >>>>> > > > > >>
> >>>>> >>>>> > > > > >> On Thu, Apr 12, 2012 at 4:10 PM, Joe Bowser
> >>>>> >>>>><bo...@gmail.com>
> >>>>> >>>>> > > > wrote:
> >>>>> >>>>> > > > > >>> You know, let's not rebase it, because it does
> >>>>>modify the
> >>>>> >>>>> > history.
> >>>>> >>>>> > > > We
> >>>>> >>>>> > > > > >>> should remove and document why we did it instead,
> >>>>>since
> >>>>> >>>>>that
> >>>>> >>>>> > would
> >>>>> >>>>> > > be
> >>>>> >>>>> > > > > >>>more
> >>>>> >>>>> > > > > >>> transparent. Or we could just leave it in and say
> >>>>>"don't
> >>>>> >>>>>do
> >>>>> >>>>> this
> >>>>> >>>>> > > next
> >>>>> >>>>> > > > > >>> time". I'm not that invested in it.
> >>>>> >>>>> > > > > >>>
> >>>>> >>>>> > > > > >>> On Thu, Apr 12, 2012 at 4:04 PM, Shazron
> >>>>> >>>>><sh...@gmail.com>
> >>>>> >>>>> > > wrote:
> >>>>> >>>>> > > > > >>>
> >>>>> >>>>> > > > > >>>> If we take out that iOS commit in cordova-js
> >>>>>(somehow),
> >>>>> >>>>>it
> >>>>> >>>>> > should
> >>>>> >>>>> > > be
> >>>>> >>>>> > > > > >>>> fine. cordova-ios 1.6.1 will then just be the
> >>>>>same as
> >>>>> >>>>>1.6.0.
> >>>>> >>>>> > > > > >>>>
> >>>>> >>>>> > > > > >>>> On Thu, Apr 12, 2012 at 4:02 PM, Filip Maj
> >>>>> >>>>><fi...@adobe.com>
> >>>>> >>>>> > wrote:
> >>>>> >>>>> > > > > >>>> >
> >>>>> >>>>> > > > > >>>> >>Is it too much to drop the new commit that
> >>>>>changed the
> >>>>> >>>>> common
> >>>>> >>>>> > js
> >>>>> >>>>> > > > > >>>>API, and
> >>>>> >>>>> > > > > >>>> >>reapply it after we tag 1.6.1, and figure this
> >>>>>one
> >>>>> >>>>>thing
> >>>>> >>>>>out
> >>>>> >>>>> > for
> >>>>> >>>>> > > > > >>>>1.7?
> >>>>> >>>>> > > > > >>>> >
> >>>>> >>>>> > > > > >>>> > That sounds very good to me but I am under the
> >>>>> >>>>>impression
> >>>>> >>>>> that
> >>>>> >>>>> > > iOS
> >>>>> >>>>> > > > > >>>> > requires this commit? Like I said I'm quite
> >>>>>confused.
> >>>>> >>>>> > > > > >>>> >
> >>>>> >>>>> > > > > >>>> >>
> >>>>> >>>>> > > > > >>>> >>I also have some cordova-js commits to add to
> >>>>>1.6.1?
> >>>>> >>>>> Although
> >>>>> >>>>> > > > > >>>>nothing
> >>>>> >>>>> > > > > >>>> that
> >>>>> >>>>> > > > > >>>> >>modifies any js outside of what is built for
> >>>>>wp7. (
> >>>>> ie,
> >>>>> >>>>>all
> >>>>> >>>>> in
> >>>>> >>>>> > > my
> >>>>> >>>>> > > > > >>>> platform
> >>>>> >>>>> > > > > >>>> >>specific plugins folder )
> >>>>> >>>>> > > > > >>>> >>
> >>>>> >>>>> > > > > >>>> >
> >>>>> >>>>> > > > > >>>> > O then it sounds like I tagged the JS 1.6.1 too
> >>>>>early
> >>>>> >>>>> > anyways..
> >>>>> >>>>> > > > > >>>> >
> >>>>> >>>>> > > > > >>>> >>
> >>>>> >>>>> > > > > >>>> >>
> >>>>> >>>>> > > > > >>>> >>
> >>>>> >>>>> > > > > >>>> >>On Thu, Apr 12, 2012 at 3:51 PM, Shazron
> >>>>> >>>>><shazron@gmail.com
> >>>>> >>>>> >
> >>>>> >>>>> > > > wrote:
> >>>>> >>>>> > > > > >>>> >>
> >>>>> >>>>> > > > > >>>> >>> No - it's about a user's contribution being
> >>>>>noted
> >>>>> (it
> >>>>> >>>>> > > exists), I
> >>>>> >>>>> > > > > >>>>will
> >>>>> >>>>> > > > > >>>> >>> move it out of the common code post-1.6.1 (I
> >>>>> >>>>>acknowledge
> >>>>> >>>>> my
> >>>>> >>>>> > > > > >>>>mistake in
> >>>>> >>>>> > > > > >>>> >>> allowing it in the first place). Can we
> >>>>>branch off
> >>>>> >>>>>1.6.0
> >>>>> >>>>> > then
> >>>>> >>>>> > > > > >>>> >>> cherry-pick Fil's latest fix for 1.6.1?
> >>>>> >>>>> > > > > >>>> >>>
> >>>>> >>>>> > > > > >>>> >>> On Thu, Apr 12, 2012 at 3:47 PM, Joe Bowser <
> >>>>> >>>>> > > bowserj@gmail.com>
> >>>>> >>>>> > > > > >>>>wrote:
> >>>>> >>>>> > > > > >>>> >>> > OK, so you're proposing that we leave the
> >>>>>thing in
> >>>>> >>>>>the
> >>>>> >>>>> > > common
> >>>>> >>>>> > > > > >>>>JS,
> >>>>> >>>>> > > > > >>>> even
> >>>>> >>>>> > > > > >>>> >>> > though it's not supposed to be there.
> >>>>> >>>>> > > > > >>>> >>> >
> >>>>> >>>>> > > > > >>>> >>> > On Thu, Apr 12, 2012 at 3:45 PM, Shazron <
> >>>>> >>>>> > shazron@gmail.com
> >>>>> >>>>> > > >
> >>>>> >>>>> > > > > >>>>wrote:
> >>>>> >>>>> > > > > >>>> >>> >
> >>>>> >>>>> > > > > >>>> >>> >> Will rebasing lose that commit? Then, no.
> >>>>> >>>>> > > > > >>>> >>> >>
> >>>>> >>>>> > > > > >>>> >>> >> On Thu, Apr 12, 2012 at 3:43 PM, Joe
> >>>>>Bowser <
> >>>>> >>>>> > > > bowserj@gmail.com
> >>>>> >>>>> > > > > >
> >>>>> >>>>> > > > > >>>> >>>wrote:
> >>>>> >>>>> > > > > >>>> >>> >> > So, can we just rebase the head, push
> >>>>>this out
> >>>>> >>>>>and
> >>>>> >>>>> get
> >>>>> >>>>> > > this
> >>>>> >>>>> > > > > >>>> >>>rolling?
> >>>>> >>>>> > > > > >>>> >>> >> >
> >>>>> >>>>> > > > > >>>> >>> >> > On Thu, Apr 12, 2012 at 3:43 PM, Filip
> >>>>>Maj <
> >>>>> >>>>> > > fil@adobe.com>
> >>>>> >>>>> > > > > >>>>wrote:
> >>>>> >>>>> > > > > >>>> >>> >> >
> >>>>> >>>>> > > > > >>>> >>> >> >> Correct, those iOS-specific parameters
> >>>>>(like
> >>>>> >>>>>allow
> >>>>> >>>>> > edit
> >>>>> >>>>> > > > and
> >>>>> >>>>> > > > > >>>>those
> >>>>> >>>>> > > > > >>>> >>> ones)
> >>>>> >>>>> > > > > >>>> >>> >> >> existed prior to cordova-js, so yeah,
> >>>>>we left
> >>>>> >>>>>them
> >>>>> >>>>> in
> >>>>> >>>>> > > > there
> >>>>> >>>>> > > > > >>>>as we
> >>>>> >>>>> > > > > >>>> >>> didn't
> >>>>> >>>>> > > > > >>>> >>> >> >> want to remove without deprecation.
> >>>>> >>>>> > > > > >>>> >>> >> >>
> >>>>> >>>>> > > > > >>>> >>> >> >> If you can deal with the iOS issue
> >>>>>without
> >>>>> >>>>>needing
> >>>>> >>>>> an
> >>>>> >>>>> > > API
> >>>>> >>>>> > > > > >>>> >>>extension:
> >>>>> >>>>> > > > > >>>> >>> >> then
> >>>>> >>>>> > > > > >>>> >>> >> >> do that. If not, leave it in there, but
> >>>>>docs
> >>>>> >>>>>need to
> >>>>> >>>>> > > > > >>>>updated too.
> >>>>> >>>>> > > > > >>>> >>> >> >>
> >>>>> >>>>> > > > > >>>> >>> >> >> Extending and changing the public API
> >>>>>is a
> >>>>> long
> >>>>> >>>>>and
> >>>>> >>>>> > > > > >>>>difficult
> >>>>> >>>>> > > > > >>>> >>>process
> >>>>> >>>>> > > > > >>>> >>> >> for
> >>>>> >>>>> > > > > >>>> >>> >> >> us and will only get tougher with every
> >>>>> >>>>>platform
> >>>>> >>>>>we
> >>>>> >>>>> > add
> >>>>> >>>>> > > > > >>>>support
> >>>>> >>>>> > > > > >>>> >>>to.
> >>>>> >>>>> > > > > >>>> >>> >> >>
> >>>>> >>>>> > > > > >>>> >>> >> >> On 4/12/12 3:37 PM, "Shazron"
> >>>>> >>>>><sh...@gmail.com>
> >>>>> >>>>> > > wrote:
> >>>>> >>>>> > > > > >>>> >>> >> >>
> >>>>> >>>>> > > > > >>>> >>> >> >> >Then we have to scrap the other
> >>>>>three(?) iOS
> >>>>> >>>>> > parameters
> >>>>> >>>>> > > > > >>>>ones
> >>>>> >>>>> > > > > >>>> that
> >>>>> >>>>> > > > > >>>> >>> >> >> >already exist in common if you
> >>>>>noticed. Don't
> >>>>> >>>>>know
> >>>>> >>>>> > how
> >>>>> >>>>> > > we
> >>>>> >>>>> > > > > >>>>merge
> >>>>> >>>>> > > > > >>>> >>> >> >> >(unmerge?) this one properly because
> >>>>>taking
> >>>>> >>>>>those
> >>>>> >>>>> out
> >>>>> >>>>> > > > will
> >>>>> >>>>> > > > > >>>>break
> >>>>> >>>>> > > > > >>>> >>> >> >> >everyone that is using it, but a
> >>>>>deprecation
> >>>>> >>>>>is
> >>>>> >>>>>the
> >>>>> >>>>> > way
> >>>>> >>>>> > > > to
> >>>>> >>>>> > > > > >>>>go as
> >>>>> >>>>> > > > > >>>> >>>per
> >>>>> >>>>> > > > > >>>> >>> >> >>
> >>>>> >>>>>>http://wiki.apache.org/cordova/DeprecationPolicy .
> >>>>> >>>>> > We
> >>>>> >>>>> > > > can
> >>>>> >>>>> > > > > >>>> remove
> >>>>> >>>>> > > > > >>>> >>> this
> >>>>> >>>>> > > > > >>>> >>> >> >> >new commit and I'll find a way to get
> >>>>>this in
> >>>>> >>>>> > somehow.
> >>>>> >>>>> > > > > >>>> >>> >> >> >
> >>>>> >>>>> > > > > >>>> >>> >> >> >
> >>>>> >>>>> > > > > >>>> >>> >> >> >
> >>>>> >>>>> > > > > >>>> >>> >> >> >On Thu, Apr 12, 2012 at 3:32 PM, Joe
> >>>>>Bowser
> >>>>> >>>>> > > > > >>>><bo...@gmail.com>
> >>>>> >>>>> > > > > >>>> >>> wrote:
> >>>>> >>>>> > > > > >>>> >>> >> >> >> The problem is that this parameter
> >>>>>doesn't
> >>>>> >>>>>belong
> >>>>> >>>>> > in
> >>>>> >>>>> > > > the
> >>>>> >>>>> > > > > >>>> common
> >>>>> >>>>> > > > > >>>> >>> API.
> >>>>> >>>>> > > > > >>>> >>> >> >> >>It'd
> >>>>> >>>>> > > > > >>>> >>> >> >> >> be just ignored in Android, but the
> >>>>>whole
> >>>>> >>>>>point
> >>>>> >>>>> of
> >>>>> >>>>> > > > > >>>>cordova-js
> >>>>> >>>>> > > > > >>>> >>>is
> >>>>> >>>>> > > > > >>>> >>> so
> >>>>> >>>>> > > > > >>>> >>> >> that
> >>>>> >>>>> > > > > >>>> >>> >> >> >> it's common. It'd look pretty
> >>>>>screwed up
> >>>>> to
> >>>>> >>>>>add
> >>>>> >>>>> > this
> >>>>> >>>>> > > > to
> >>>>> >>>>> > > > > >>>>the
> >>>>> >>>>> > > > > >>>> >>>docs,
> >>>>> >>>>> > > > > >>>> >>> >> IMO.
> >>>>> >>>>> > > > > >>>> >>> >> >> >>
> >>>>> >>>>> > > > > >>>> >>> >> >> >> On Thu, Apr 12, 2012 at 3:26 PM,
> >>>>>Shazron
> >>>>> >>>>> > > > > >>>><sh...@gmail.com>
> >>>>> >>>>> > > > > >>>> >>> wrote:
> >>>>> >>>>> > > > > >>>> >>> >> >> >>
> >>>>> >>>>> > > > > >>>> >>> >> >> >>> To fix two bugs for
> >>>>>Camera.takePicture on
> >>>>> >>>>>iOS
> >>>>> >>>>> > > > > >>>> >>> >> >> >>>
> >>>>> >>>>> > > > > >>>> >>> >> >> >>> On Thu, Apr 12, 2012 at 3:24 PM,
> >>>>>Filip Maj
> >>>>> >>>>> > > > > >>>><fi...@adobe.com>
> >>>>> >>>>> > > > > >>>> >>> wrote:
> >>>>> >>>>> > > > > >>>> >>> >> >> >>> > so what's the point of this new
> >>>>> >>>>>parameter?
> >>>>> >>>>> > > > > >>>> >>> >> >> >>> >
> >>>>> >>>>> > > > > >>>> >>> >> >> >>> > On 4/12/12 3:16 PM, "Shazron" <
> >>>>> >>>>> > shazron@gmail.com>
> >>>>> >>>>> > > > > >>>>wrote:
> >>>>> >>>>> > > > > >>>> >>> >> >> >>> >
> >>>>> >>>>> > > > > >>>> >>> >> >> >>> >>I did. Do we want to revert the
> >>>>> >>>>>cordova-js? I
> >>>>> >>>>> > can
> >>>>> >>>>> > > > > >>>>branch
> >>>>> >>>>> > > > > >>>> >>>1.6.0
> >>>>> >>>>> > > > > >>>> >>> and
> >>>>> >>>>> > > > > >>>> >>> >> >> >>> >>cherry-pick your latest commit
> >>>>>for 1.6.1
> >>>>> >>>>> > > > > >>>> >>> >> >> >>> >>
> >>>>> >>>>> > > > > >>>> >>> >> >> >>> >>On Thu, Apr 12, 2012 at 3:04 PM,
> >>>>>Filip
> >>>>> >>>>>Maj
> >>>>> >>>>> > > > > >>>><fi...@adobe.com>
> >>>>> >>>>> > > > > >>>> >>> wrote:
> >>>>> >>>>> > > > > >>>> >>> >> >> >>> >>> I saw something in the iOS
> >>>>>commit logs
> >>>>> >>>>>for
> >>>>> >>>>> > this.
> >>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>
> >>>>> >>>>> > > > > >>>> >>> >> >> >>> >>> Shaz can you comment?
> >>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>
> >>>>> >>>>> > > > > >>>> >>> >> >> >>> >>> On 4/12/12 2:59 PM, "Joe
> >>>>>Bowser" <
> >>>>> >>>>> > > > bowserj@gmail.com
> >>>>> >>>>> > > > > >
> >>>>> >>>>> > > > > >>>> >>>wrote:
> >>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>
> >>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>Can we revert this, since this
> >>>>>looks
> >>>>> >>>>>like
> >>>>> >>>>> it's
> >>>>> >>>>> > > > > >>>>intended
> >>>>> >>>>> > > > > >>>> >>>for
> >>>>> >>>>> > > > > >>>> >>> both
> >>>>> >>>>> > > > > >>>> >>> >> >> >>> Android
> >>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>and iOS, but I don't think it
> >>>>>should
> >>>>> be
> >>>>> >>>>>in
> >>>>> >>>>> > > 1.6.1.
> >>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>
> >>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>On Thu, Apr 12, 2012 at 2:52
> >>>>>PM, Filip
> >>>>> >>>>>Maj <
> >>>>> >>>>> > > > > >>>> fil@adobe.com>
> >>>>> >>>>> > > > > >>>> >>> >> wrote:
> >>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>
> >>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> I was actually just looking
> >>>>>at that
> >>>>> >>>>> myself.
> >>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>>
> >>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> Looks like it's an iOS-only
> >>>>>param..
> >>>>> >>>>>sigh.
> >>>>> >>>>> > We
> >>>>> >>>>> > > > > >>>>gotta
> >>>>> >>>>> > > > > >>>> stop
> >>>>> >>>>> > > > > >>>> >>> doing
> >>>>> >>>>> > > > > >>>> >>> >> >> >>>that,
> >>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> especially if we don't update
> >>>>> >>>>> documentation.
> >>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>>
> >>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> On 4/12/12 2:49 PM, "Joe
> >>>>>Bowser"
> >>>>> >>>>> > > > > >>>><bo...@gmail.com>
> >>>>> >>>>> > > > > >>>> >>> wrote:
> >>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>>
> >>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >Has anyone tested the
> >>>>>cropToSize
> >>>>> >>>>>param
> >>>>> >>>>> for
> >>>>> >>>>> > > > > >>>> >>> Camera.getPicture
> >>>>> >>>>> > > > > >>>> >>> >> >> >>>yet? I
> >>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >didn't
> >>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >notice that change until now.
> >>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >
> >>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >On Thu, Apr 12, 2012 at 2:46
> >>>>>PM,
> >>>>> >>>>>Filip
> >>>>> >>>>> Maj
> >>>>> >>>>> > > > > >>>> >>><fil@adobe.com
> >>>>> >>>>> > > > > >>>> >>> >
> >>>>> >>>>> > > > > >>>> >>> >> >> >>>wrote:
> >>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >
> >>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> JS tagged 1.6.1 - the
> >>>>>build task
> >>>>> >>>>>in
> >>>>> >>>>>the
> >>>>> >>>>> > JS
> >>>>> >>>>> > > > > >>>>should
> >>>>> >>>>> > > > > >>>> >>>work
> >>>>> >>>>> > > > > >>>> >>> >> >> >>>properly
> >>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>>now.
> >>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >>
> >>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> FYI if anyone has to
> >>>>>modify the
> >>>>> >>>>>jake
> >>>>> >>>>> > tasks
> >>>>> >>>>> > > in
> >>>>> >>>>> > > > > >>>>the
> >>>>> >>>>> > > > > >>>> >>>future
> >>>>> >>>>> > > > > >>>> >>> >> and
> >>>>> >>>>> > > > > >>>> >>> >> >> >>>make
> >>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>>them
> >>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> async, make sure you add
> >>>>>the 4th
> >>>>> >>>>> "async"
> >>>>> >>>>> > > > > >>>>parameter
> >>>>> >>>>> > > > > >>>> to
> >>>>> >>>>> > > > > >>>> >>> the
> >>>>> >>>>> > > > > >>>> >>> >> >> >>>task()
> >>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >>function
> >>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> and set it to true, and
> >>>>>call
> >>>>> >>>>>complete()
> >>>>> >>>>> > > when
> >>>>> >>>>> > > > > >>>>the
> >>>>> >>>>> > > > > >>>> >>>task is
> >>>>> >>>>> > > > > >>>> >>> >> done.
> >>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >>
> >>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> See
> >>>>> >>>>> > > > > >>>> >>>
> >>>>> >>>>>http://howtonode.org/intro-to-jake/async-jakefile.jsfor
> >>>>> >>>>> > > > > >>>> >>> >> >> >>>an
> >>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> example.
> >>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >>
> >>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> On 4/12/12 2:35 PM, "Joe
> >>>>>Bowser"
> >>>>> >>>>> > > > > >>>><bowserj@gmail.com
> >>>>> >>>>> > > > > >>>> >
> >>>>> >>>>> > > > > >>>> >>> >> wrote:
> >>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >>
> >>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >Ready to tag once
> >>>>>cordova-js is
> >>>>> >>>>>tagged
> >>>>> >>>>> > > > 1.6.1.
> >>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >
> >>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >On Thu, Apr 12, 2012 at
> >>>>>2:33 PM,
> >>>>> >>>>>Anis
> >>>>> >>>>> > > KADRI
> >>>>> >>>>> > > > <
> >>>>> >>>>> > > > > >>>> >>> >> >> >>> anis.kadri@gmail.com>
> >>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >>wrote:
> >>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >
> >>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> I will tag my
> >>>>>repository to
> >>>>> >>>>>1.6.1
> >>>>> >>>>> > before
> >>>>> >>>>> > > > > >>>>end of
> >>>>> >>>>> > > > > >>>> >>>day
> >>>>> >>>>> > > > > >>>> >>> >> today
> >>>>> >>>>> > > > > >>>> >>> >> >> >>>after
> >>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>>some
> >>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> thorough testing.
> >>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >>
> >>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> On Thu, Apr 12, 2012 at
> >>>>>2:30
> >>>>> >>>>>PM,
> >>>>> >>>>> > Shazron
> >>>>> >>>>> > > > > >>>> >>> >> >> >>><sh...@gmail.com>
> >>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>>wrote:
> >>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >>
> >>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > I also created a 1.6.1
> >>>>> >>>>>version
> >>>>> >>>>>tag
> >>>>> >>>>> > as
> >>>>> >>>>> > > > > >>>>well in
> >>>>> >>>>> > > > > >>>> >>> jira...
> >>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> >
> >>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > On Thu, Apr 12, 2012
> >>>>>at 2:29
> >>>>> >>>>>PM,
> >>>>> >>>>> > > Shazron
> >>>>> >>>>> > > > > >>>> >>> >> >> >>><sh...@gmail.com>
> >>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> wrote:
> >>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > > Alright guys since
> >>>>>1.6.0
> >>>>> >>>>>was
> >>>>> >>>>> > > released,
> >>>>> >>>>> > > > > >>>>I'm
> >>>>> >>>>> > > > > >>>> >>>going
> >>>>> >>>>> > > > > >>>> >>> to
> >>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>>"Release"
> >>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>>the
> >>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > > 1.6.0 version in
> >>>>>jira and
> >>>>> >>>>>move
> >>>>> >>>>> > > > > >>>>outstanding
> >>>>> >>>>> > > > > >>>> >>> issues to
> >>>>> >>>>> > > > > >>>> >>> >> >> >>>1.7.0
> >>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >>version
> >>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > > tag.
> >>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >
> >>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >
> >>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > > On Thu, Apr 12,
> >>>>>2012 at
> >>>>> >>>>>2:26
> >>>>> >>>>>PM,
> >>>>> >>>>> > > Filip
> >>>>> >>>>> > > > > >>>>Maj
> >>>>> >>>>> > > > > >>>> >>> >> >> >>><fi...@adobe.com>
> >>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> wrote:
> >>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >> The JS needs
> >>>>>patching
> >>>>> too.
> >>>>> >>>>> Since
> >>>>> >>>>> > > > > >>>>adding the
> >>>>> >>>>> > > > > >>>> >>> commit
> >>>>> >>>>> > > > > >>>> >>> >> ID
> >>>>> >>>>> > > > > >>>> >>> >> >> >>>into
> >>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>>the
> >>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> packaging
> >>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >> in the jakefile,
> >>>>>the
> >>>>> >>>>>default
> >>>>> >>>>> task
> >>>>> >>>>> > > > isn't
> >>>>> >>>>> > > > > >>>> >>>running
> >>>>> >>>>> > > > > >>>> >>> >> >> >>>properly.
> >>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>
> >>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >> You can manually
> >>>>>run
> >>>>> "jake
> >>>>> >>>>> build"
> >>>>> >>>>> > > and
> >>>>> >>>>> > > > > >>>>"jake
> >>>>> >>>>> > > > > >>>> >>> test"
> >>>>> >>>>> > > > > >>>> >>> >> but
> >>>>> >>>>> > > > > >>>> >>> >> >> >>>not
> >>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >>"jake" on
> >>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> its
> >>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >> own - gonna try to
> >>>>>figure
> >>>>> >>>>>it
> >>>>> >>>>> out.
> >>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>
> >>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >> On 4/12/12 2:21 PM,
> >>>>> >>>>>"Shazron" <
> >>>>> >>>>> > > > > >>>> >>> shazron@gmail.com>
> >>>>> >>>>> > > > > >>>> >>> >> >> >>>wrote:
> >>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>
> >>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>I'm good with
> >>>>>tagging.
> >>>>> >>>>>iOS
> >>>>> >>>>> has a
> >>>>> >>>>> > > few
> >>>>> >>>>> > > > > >>>> commits
> >>>>> >>>>> > > > > >>>> >>> (one
> >>>>> >>>>> > > > > >>>> >>> >> >> >>>commit
> >>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>>in
> >>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>cordova-js) as
> >>>>>well. Aim
> >>>>> >>>>>for
> >>>>> >>>>> > first
> >>>>> >>>>> > > > > >>>>thing
> >>>>> >>>>> > > > > >>>> >>> tomorrow
> >>>>> >>>>> > > > > >>>> >>> >> for
> >>>>> >>>>> > > > > >>>> >>> >> >> >>>you
> >>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>>to
> >>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>repackage?
> >>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>
> >>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>On Thu, Apr 12,
> >>>>>2012 at
> >>>>> >>>>>2:17
> >>>>> >>>>> PM,
> >>>>> >>>>> > > > > >>>>Steven Gill
> >>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >><st...@gmail.com>
> >>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>wrote:
> >>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>> So a bug has been
> >>>>> >>>>>discovered
> >>>>> >>>>> in
> >>>>> >>>>> > > > > >>>>Cordova
> >>>>> >>>>> > > > > >>>> >>> Android
> >>>>> >>>>> > > > > >>>> >>> >> that
> >>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>>requires
> >>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >>a
> >>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >>new
> >>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > tag
> >>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>>and
> >>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>> release. You can
> >>>>>check
> >>>>> >>>>>out
> >>>>> >>>>> the
> >>>>> >>>>> > > bug
> >>>>> >>>>> > > > > >>>>on the
> >>>>> >>>>> > > > > >>>> >>> issue
> >>>>> >>>>> > > > > >>>> >>> >> >> >>>tracker
> >>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>>at
> >>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>>
> >>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>>
> >>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> >
> >>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >>
> >>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >>
> >>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >>
> >>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >>
> >>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>>
> >>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>>
> >>>>> >>>>> > > > > >>>> >>> >> >> >>>
> >>>>> >>>>> > > > > >>>> >>> >> >>
> >>>>> >>>>> > > > > >>>> >>>
> >>>>> >>>>> > > > > >>>>
> >>>>> >>>>> > > > > >>>>
> >>>>> >>>>> > > > >
> >>>>> >>>>> > >
> >>>>> >>>>>
> >>>>> >>>>>
> >>>>>
> >>>>>
> https://issues.apache.org/jira/browse/CB-490?focusedCommentId=13252809
> >>>>>#
> >>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>>co
> >>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>>mment-13252809
> >>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>>
> >>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>> It doesn't make
> >>>>>sense
> >>>>> to
> >>>>> >>>>>just
> >>>>> >>>>> > > > > >>>>repackage
> >>>>> >>>>> > > > > >>>> >>>1.6.0
> >>>>> >>>>> > > > > >>>> >>> >> with
> >>>>> >>>>> > > > > >>>> >>> >> >> >>>this
> >>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>>bug
> >>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >>fixed as
> >>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > we
> >>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>> will have no way
> >>>>>to
> >>>>> know
> >>>>> >>>>>if
> >>>>> >>>>> > > people
> >>>>> >>>>> > > > > >>>>are
> >>>>> >>>>> > > > > >>>> >>> >> experiencing
> >>>>> >>>>> > > > > >>>> >>> >> >> >>>this
> >>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>>or
> >>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >>not.
> >>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>>
> >>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>> Anis mentioned
> >>>>>Bada
> >>>>> also
> >>>>> >>>>>had
> >>>>> >>>>> > some
> >>>>> >>>>> > > > > >>>>major
> >>>>> >>>>> > > > > >>>> >>>issues
> >>>>> >>>>> > > > > >>>> >>> >> >> >>>which he
> >>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>>has
> >>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >>fixed
> >>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> now
> >>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>>and
> >>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>> would like in a
> >>>>>1.6.1
> >>>>> >>>>> release.
> >>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>>
> >>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>> Thoughts?
> >>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>>
> >>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>> -Steve
> >>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>
> >>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> >
> >>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >>
> >>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >>
> >>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >>
> >>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>>
> >>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>>
> >>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>
> >>>>> >>>>> > > > > >>>> >>> >> >> >>> >
> >>>>> >>>>> > > > > >>>> >>> >> >> >>>
> >>>>> >>>>> > > > > >>>> >>> >> >>
> >>>>> >>>>> > > > > >>>> >>> >> >>
> >>>>> >>>>> > > > > >>>> >>> >>
> >>>>> >>>>> > > > > >>>> >>>
> >>>>> >>>>> > > > > >>>> >
> >>>>> >>>>> > > > > >>>>
> >>>>> >>>>> > > > >
> >>>>> >>>>> > > > >
> >>>>> >>>>> > > >
> >>>>> >>>>> > >
> >>>>> >>>>> >
> >>>>> >>>>>
> >>>>> >>>
> >>>>> >
> >>>>>
>
>
Re: 1.6.1
Posted by Filip Maj <fi...@adobe.com>.
Yeh agreed. I've changed the release date of 1.6.1 in JIRA to Monday.
On 4/13/12 7:05 AM, "Shazron" <sh...@gmail.com> wrote:
>+1 seems like more bugs are getting shaken out of the tree. Just
>discovered another one:
>https://issues.apache.org/jira/browse/CB-501
>
>On Fri, Apr 13, 2012 at 6:59 AM, Simon MacDonald
><si...@gmail.com> wrote:
>> Maybe we should wait until Monday before re-tagging? I mean if we are
>> going to re-release let's give it a few more days to shake out these
>> issues.
>>
>> Simon Mac Donald
>> http://hi.im/simonmacdonald
>>
>>
>>
>> On Fri, Apr 13, 2012 at 9:54 AM, Shazron <sh...@gmail.com> wrote:
>>> Users are discovering more bugs:
>>> https://issues.apache.org/jira/browse/CB-497
>>>
>>>https://github.com/apache/incubator-cordova-ios/blob/master/CordovaLib/C
>>>lasses/CDVConnection.m#L103
>>>
>>> So I'm going to have to review, fix and re-tag, so wait up.
>>>
>>>
>>> On Thu, Apr 12, 2012 at 5:38 PM, Jesse <pu...@gmail.com> wrote:
>>>> I am commited and tagged
>>>>
>>>> On Thu, Apr 12, 2012 at 5:27 PM, Shazron <sh...@gmail.com> wrote:
>>>>
>>>>> Logic error - no worries, I patched it (going to re-do 1.6.1 iOS)
>>>>>
>>>>> On Thu, Apr 12, 2012 at 5:27 PM, Filip Maj <fi...@adobe.com> wrote:
>>>>> > Did I f that up?
>>>>> >
>>>>> > On 4/12/12 5:07 PM, "Shazron" <sh...@gmail.com> wrote:
>>>>> >
>>>>> >>Sigh - user reported iOS bug
>>>>> >>
>>>>>
>>>>>http://groups.google.com/group/phonegap/browse_thread/thread/faad0af97
>>>>>dec8
>>>>> >>907
>>>>> >>(you know who you are ;)
>>>>> >>
>>>>> >>On Thu, Apr 12, 2012 at 5:05 PM, Filip Maj <fi...@adobe.com> wrote:
>>>>> >>> Saweet! Nice work Anis. That kills off a bunch of old issues in
>>>>>JIRA
>>>>> >>>too.
>>>>> >>>
>>>>> >>> Way to hunker down all. As Jesse pointed out to me, we did 45
>>>>>emails in
>>>>> >>> two hours haha
>>>>> >>>
>>>>> >>> On 4/12/12 5:00 PM, "Anis KADRI" <an...@gmail.com> wrote:
>>>>> >>>
>>>>> >>>>Bada 1.2 is tagged 1.6.1. I added the new Cordova artwork,
>>>>> >>>>LICENSE/NOTICE
>>>>> >>>>files as well as the Apache source headers in every source file.
>>>>>I
>>>>> fixed
>>>>> >>>>all the bugs I sawS
>>>>> >>>>
>>>>> >>>>On Thu, Apr 12, 2012 at 4:38 PM, Joe Bowser <bo...@gmail.com>
>>>>>wrote:
>>>>> >>>>
>>>>> >>>>> Android is tagged.
>>>>> >>>>>
>>>>> >>>>> On Thu, Apr 12, 2012 at 4:36 PM, Jesse
>>>>><pu...@gmail.com>
>>>>> >>>>>wrote:
>>>>> >>>>>
>>>>> >>>>> > Done
>>>>> >>>>> >
>>>>> >>>>> > On Thu, Apr 12, 2012 at 4:31 PM, Joe Bowser
>>>>><bo...@gmail.com>
>>>>> >>>>>wrote:
>>>>> >>>>> >
>>>>> >>>>> > > I'd like to get the JS from the tag, but I need a tag for
>>>>>that.
>>>>> >>>>> > >
>>>>> >>>>> > > On Thu, Apr 12, 2012 at 4:29 PM, Jesse
>>>>><pu...@gmail.com>
>>>>> >>>>> wrote:
>>>>> >>>>> > >
>>>>> >>>>> > > > Okay, I think it's good, tagging at 16:32 PDT if i don't
>>>>>hear
>>>>> >>>>>any
>>>>> >>>>> > > > complaints.
>>>>> >>>>> > > >
>>>>> >>>>> > > > On Thu, Apr 12, 2012 at 4:26 PM, Filip Maj
>>>>><fi...@adobe.com>
>>>>> >>>>>wrote:
>>>>> >>>>> > > >
>>>>> >>>>> > > > > I just axed the existing 1.6.1 cordova-js tag
>>>>> >>>>> > > > >
>>>>> >>>>> > > > > Jesse when you feel you've got everything in there go
>>>>>ahead
>>>>> >>>>>and
>>>>> >>>>>tag
>>>>> >>>>> > JS
>>>>> >>>>> > > > >
>>>>> >>>>> > > > > On 4/12/12 4:20 PM, "Shazron" <sh...@gmail.com>
>>>>>wrote:
>>>>> >>>>> > > > >
>>>>> >>>>> > > > > >Reverted. Just talked to Jesse - he has commits to
>>>>> cordova-js
>>>>> >>>>> > coming,
>>>>> >>>>> > > > > >once those are in we can re-tag cordova-js to 1.6.1
>>>>> >>>>> > > > > >
>>>>> >>>>> > > > > >On Thu, Apr 12, 2012 at 4:12 PM, Shazron
>>>>><shazron@gmail.com
>>>>> >
>>>>> >>>>> wrote:
>>>>> >>>>> > > > > >> I'll remove it. *grabs the shovel*
>>>>> >>>>> > > > > >>
>>>>> >>>>> > > > > >> On Thu, Apr 12, 2012 at 4:10 PM, Joe Bowser
>>>>> >>>>><bo...@gmail.com>
>>>>> >>>>> > > > wrote:
>>>>> >>>>> > > > > >>> You know, let's not rebase it, because it does
>>>>>modify the
>>>>> >>>>> > history.
>>>>> >>>>> > > > We
>>>>> >>>>> > > > > >>> should remove and document why we did it instead,
>>>>>since
>>>>> >>>>>that
>>>>> >>>>> > would
>>>>> >>>>> > > be
>>>>> >>>>> > > > > >>>more
>>>>> >>>>> > > > > >>> transparent. Or we could just leave it in and say
>>>>>"don't
>>>>> >>>>>do
>>>>> >>>>> this
>>>>> >>>>> > > next
>>>>> >>>>> > > > > >>> time". I'm not that invested in it.
>>>>> >>>>> > > > > >>>
>>>>> >>>>> > > > > >>> On Thu, Apr 12, 2012 at 4:04 PM, Shazron
>>>>> >>>>><sh...@gmail.com>
>>>>> >>>>> > > wrote:
>>>>> >>>>> > > > > >>>
>>>>> >>>>> > > > > >>>> If we take out that iOS commit in cordova-js
>>>>>(somehow),
>>>>> >>>>>it
>>>>> >>>>> > should
>>>>> >>>>> > > be
>>>>> >>>>> > > > > >>>> fine. cordova-ios 1.6.1 will then just be the
>>>>>same as
>>>>> >>>>>1.6.0.
>>>>> >>>>> > > > > >>>>
>>>>> >>>>> > > > > >>>> On Thu, Apr 12, 2012 at 4:02 PM, Filip Maj
>>>>> >>>>><fi...@adobe.com>
>>>>> >>>>> > wrote:
>>>>> >>>>> > > > > >>>> >
>>>>> >>>>> > > > > >>>> >>Is it too much to drop the new commit that
>>>>>changed the
>>>>> >>>>> common
>>>>> >>>>> > js
>>>>> >>>>> > > > > >>>>API, and
>>>>> >>>>> > > > > >>>> >>reapply it after we tag 1.6.1, and figure this
>>>>>one
>>>>> >>>>>thing
>>>>> >>>>>out
>>>>> >>>>> > for
>>>>> >>>>> > > > > >>>>1.7?
>>>>> >>>>> > > > > >>>> >
>>>>> >>>>> > > > > >>>> > That sounds very good to me but I am under the
>>>>> >>>>>impression
>>>>> >>>>> that
>>>>> >>>>> > > iOS
>>>>> >>>>> > > > > >>>> > requires this commit? Like I said I'm quite
>>>>>confused.
>>>>> >>>>> > > > > >>>> >
>>>>> >>>>> > > > > >>>> >>
>>>>> >>>>> > > > > >>>> >>I also have some cordova-js commits to add to
>>>>>1.6.1?
>>>>> >>>>> Although
>>>>> >>>>> > > > > >>>>nothing
>>>>> >>>>> > > > > >>>> that
>>>>> >>>>> > > > > >>>> >>modifies any js outside of what is built for
>>>>>wp7. (
>>>>> ie,
>>>>> >>>>>all
>>>>> >>>>> in
>>>>> >>>>> > > my
>>>>> >>>>> > > > > >>>> platform
>>>>> >>>>> > > > > >>>> >>specific plugins folder )
>>>>> >>>>> > > > > >>>> >>
>>>>> >>>>> > > > > >>>> >
>>>>> >>>>> > > > > >>>> > O then it sounds like I tagged the JS 1.6.1 too
>>>>>early
>>>>> >>>>> > anyways..
>>>>> >>>>> > > > > >>>> >
>>>>> >>>>> > > > > >>>> >>
>>>>> >>>>> > > > > >>>> >>
>>>>> >>>>> > > > > >>>> >>
>>>>> >>>>> > > > > >>>> >>On Thu, Apr 12, 2012 at 3:51 PM, Shazron
>>>>> >>>>><shazron@gmail.com
>>>>> >>>>> >
>>>>> >>>>> > > > wrote:
>>>>> >>>>> > > > > >>>> >>
>>>>> >>>>> > > > > >>>> >>> No - it's about a user's contribution being
>>>>>noted
>>>>> (it
>>>>> >>>>> > > exists), I
>>>>> >>>>> > > > > >>>>will
>>>>> >>>>> > > > > >>>> >>> move it out of the common code post-1.6.1 (I
>>>>> >>>>>acknowledge
>>>>> >>>>> my
>>>>> >>>>> > > > > >>>>mistake in
>>>>> >>>>> > > > > >>>> >>> allowing it in the first place). Can we
>>>>>branch off
>>>>> >>>>>1.6.0
>>>>> >>>>> > then
>>>>> >>>>> > > > > >>>> >>> cherry-pick Fil's latest fix for 1.6.1?
>>>>> >>>>> > > > > >>>> >>>
>>>>> >>>>> > > > > >>>> >>> On Thu, Apr 12, 2012 at 3:47 PM, Joe Bowser <
>>>>> >>>>> > > bowserj@gmail.com>
>>>>> >>>>> > > > > >>>>wrote:
>>>>> >>>>> > > > > >>>> >>> > OK, so you're proposing that we leave the
>>>>>thing in
>>>>> >>>>>the
>>>>> >>>>> > > common
>>>>> >>>>> > > > > >>>>JS,
>>>>> >>>>> > > > > >>>> even
>>>>> >>>>> > > > > >>>> >>> > though it's not supposed to be there.
>>>>> >>>>> > > > > >>>> >>> >
>>>>> >>>>> > > > > >>>> >>> > On Thu, Apr 12, 2012 at 3:45 PM, Shazron <
>>>>> >>>>> > shazron@gmail.com
>>>>> >>>>> > > >
>>>>> >>>>> > > > > >>>>wrote:
>>>>> >>>>> > > > > >>>> >>> >
>>>>> >>>>> > > > > >>>> >>> >> Will rebasing lose that commit? Then, no.
>>>>> >>>>> > > > > >>>> >>> >>
>>>>> >>>>> > > > > >>>> >>> >> On Thu, Apr 12, 2012 at 3:43 PM, Joe
>>>>>Bowser <
>>>>> >>>>> > > > bowserj@gmail.com
>>>>> >>>>> > > > > >
>>>>> >>>>> > > > > >>>> >>>wrote:
>>>>> >>>>> > > > > >>>> >>> >> > So, can we just rebase the head, push
>>>>>this out
>>>>> >>>>>and
>>>>> >>>>> get
>>>>> >>>>> > > this
>>>>> >>>>> > > > > >>>> >>>rolling?
>>>>> >>>>> > > > > >>>> >>> >> >
>>>>> >>>>> > > > > >>>> >>> >> > On Thu, Apr 12, 2012 at 3:43 PM, Filip
>>>>>Maj <
>>>>> >>>>> > > fil@adobe.com>
>>>>> >>>>> > > > > >>>>wrote:
>>>>> >>>>> > > > > >>>> >>> >> >
>>>>> >>>>> > > > > >>>> >>> >> >> Correct, those iOS-specific parameters
>>>>>(like
>>>>> >>>>>allow
>>>>> >>>>> > edit
>>>>> >>>>> > > > and
>>>>> >>>>> > > > > >>>>those
>>>>> >>>>> > > > > >>>> >>> ones)
>>>>> >>>>> > > > > >>>> >>> >> >> existed prior to cordova-js, so yeah,
>>>>>we left
>>>>> >>>>>them
>>>>> >>>>> in
>>>>> >>>>> > > > there
>>>>> >>>>> > > > > >>>>as we
>>>>> >>>>> > > > > >>>> >>> didn't
>>>>> >>>>> > > > > >>>> >>> >> >> want to remove without deprecation.
>>>>> >>>>> > > > > >>>> >>> >> >>
>>>>> >>>>> > > > > >>>> >>> >> >> If you can deal with the iOS issue
>>>>>without
>>>>> >>>>>needing
>>>>> >>>>> an
>>>>> >>>>> > > API
>>>>> >>>>> > > > > >>>> >>>extension:
>>>>> >>>>> > > > > >>>> >>> >> then
>>>>> >>>>> > > > > >>>> >>> >> >> do that. If not, leave it in there, but
>>>>>docs
>>>>> >>>>>need to
>>>>> >>>>> > > > > >>>>updated too.
>>>>> >>>>> > > > > >>>> >>> >> >>
>>>>> >>>>> > > > > >>>> >>> >> >> Extending and changing the public API
>>>>>is a
>>>>> long
>>>>> >>>>>and
>>>>> >>>>> > > > > >>>>difficult
>>>>> >>>>> > > > > >>>> >>>process
>>>>> >>>>> > > > > >>>> >>> >> for
>>>>> >>>>> > > > > >>>> >>> >> >> us and will only get tougher with every
>>>>> >>>>>platform
>>>>> >>>>>we
>>>>> >>>>> > add
>>>>> >>>>> > > > > >>>>support
>>>>> >>>>> > > > > >>>> >>>to.
>>>>> >>>>> > > > > >>>> >>> >> >>
>>>>> >>>>> > > > > >>>> >>> >> >> On 4/12/12 3:37 PM, "Shazron"
>>>>> >>>>><sh...@gmail.com>
>>>>> >>>>> > > wrote:
>>>>> >>>>> > > > > >>>> >>> >> >>
>>>>> >>>>> > > > > >>>> >>> >> >> >Then we have to scrap the other
>>>>>three(?) iOS
>>>>> >>>>> > parameters
>>>>> >>>>> > > > > >>>>ones
>>>>> >>>>> > > > > >>>> that
>>>>> >>>>> > > > > >>>> >>> >> >> >already exist in common if you
>>>>>noticed. Don't
>>>>> >>>>>know
>>>>> >>>>> > how
>>>>> >>>>> > > we
>>>>> >>>>> > > > > >>>>merge
>>>>> >>>>> > > > > >>>> >>> >> >> >(unmerge?) this one properly because
>>>>>taking
>>>>> >>>>>those
>>>>> >>>>> out
>>>>> >>>>> > > > will
>>>>> >>>>> > > > > >>>>break
>>>>> >>>>> > > > > >>>> >>> >> >> >everyone that is using it, but a
>>>>>deprecation
>>>>> >>>>>is
>>>>> >>>>>the
>>>>> >>>>> > way
>>>>> >>>>> > > > to
>>>>> >>>>> > > > > >>>>go as
>>>>> >>>>> > > > > >>>> >>>per
>>>>> >>>>> > > > > >>>> >>> >> >>
>>>>> >>>>>>http://wiki.apache.org/cordova/DeprecationPolicy .
>>>>> >>>>> > We
>>>>> >>>>> > > > can
>>>>> >>>>> > > > > >>>> remove
>>>>> >>>>> > > > > >>>> >>> this
>>>>> >>>>> > > > > >>>> >>> >> >> >new commit and I'll find a way to get
>>>>>this in
>>>>> >>>>> > somehow.
>>>>> >>>>> > > > > >>>> >>> >> >> >
>>>>> >>>>> > > > > >>>> >>> >> >> >
>>>>> >>>>> > > > > >>>> >>> >> >> >
>>>>> >>>>> > > > > >>>> >>> >> >> >On Thu, Apr 12, 2012 at 3:32 PM, Joe
>>>>>Bowser
>>>>> >>>>> > > > > >>>><bo...@gmail.com>
>>>>> >>>>> > > > > >>>> >>> wrote:
>>>>> >>>>> > > > > >>>> >>> >> >> >> The problem is that this parameter
>>>>>doesn't
>>>>> >>>>>belong
>>>>> >>>>> > in
>>>>> >>>>> > > > the
>>>>> >>>>> > > > > >>>> common
>>>>> >>>>> > > > > >>>> >>> API.
>>>>> >>>>> > > > > >>>> >>> >> >> >>It'd
>>>>> >>>>> > > > > >>>> >>> >> >> >> be just ignored in Android, but the
>>>>>whole
>>>>> >>>>>point
>>>>> >>>>> of
>>>>> >>>>> > > > > >>>>cordova-js
>>>>> >>>>> > > > > >>>> >>>is
>>>>> >>>>> > > > > >>>> >>> so
>>>>> >>>>> > > > > >>>> >>> >> that
>>>>> >>>>> > > > > >>>> >>> >> >> >> it's common. It'd look pretty
>>>>>screwed up
>>>>> to
>>>>> >>>>>add
>>>>> >>>>> > this
>>>>> >>>>> > > > to
>>>>> >>>>> > > > > >>>>the
>>>>> >>>>> > > > > >>>> >>>docs,
>>>>> >>>>> > > > > >>>> >>> >> IMO.
>>>>> >>>>> > > > > >>>> >>> >> >> >>
>>>>> >>>>> > > > > >>>> >>> >> >> >> On Thu, Apr 12, 2012 at 3:26 PM,
>>>>>Shazron
>>>>> >>>>> > > > > >>>><sh...@gmail.com>
>>>>> >>>>> > > > > >>>> >>> wrote:
>>>>> >>>>> > > > > >>>> >>> >> >> >>
>>>>> >>>>> > > > > >>>> >>> >> >> >>> To fix two bugs for
>>>>>Camera.takePicture on
>>>>> >>>>>iOS
>>>>> >>>>> > > > > >>>> >>> >> >> >>>
>>>>> >>>>> > > > > >>>> >>> >> >> >>> On Thu, Apr 12, 2012 at 3:24 PM,
>>>>>Filip Maj
>>>>> >>>>> > > > > >>>><fi...@adobe.com>
>>>>> >>>>> > > > > >>>> >>> wrote:
>>>>> >>>>> > > > > >>>> >>> >> >> >>> > so what's the point of this new
>>>>> >>>>>parameter?
>>>>> >>>>> > > > > >>>> >>> >> >> >>> >
>>>>> >>>>> > > > > >>>> >>> >> >> >>> > On 4/12/12 3:16 PM, "Shazron" <
>>>>> >>>>> > shazron@gmail.com>
>>>>> >>>>> > > > > >>>>wrote:
>>>>> >>>>> > > > > >>>> >>> >> >> >>> >
>>>>> >>>>> > > > > >>>> >>> >> >> >>> >>I did. Do we want to revert the
>>>>> >>>>>cordova-js? I
>>>>> >>>>> > can
>>>>> >>>>> > > > > >>>>branch
>>>>> >>>>> > > > > >>>> >>>1.6.0
>>>>> >>>>> > > > > >>>> >>> and
>>>>> >>>>> > > > > >>>> >>> >> >> >>> >>cherry-pick your latest commit
>>>>>for 1.6.1
>>>>> >>>>> > > > > >>>> >>> >> >> >>> >>
>>>>> >>>>> > > > > >>>> >>> >> >> >>> >>On Thu, Apr 12, 2012 at 3:04 PM,
>>>>>Filip
>>>>> >>>>>Maj
>>>>> >>>>> > > > > >>>><fi...@adobe.com>
>>>>> >>>>> > > > > >>>> >>> wrote:
>>>>> >>>>> > > > > >>>> >>> >> >> >>> >>> I saw something in the iOS
>>>>>commit logs
>>>>> >>>>>for
>>>>> >>>>> > this.
>>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>
>>>>> >>>>> > > > > >>>> >>> >> >> >>> >>> Shaz can you comment?
>>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>
>>>>> >>>>> > > > > >>>> >>> >> >> >>> >>> On 4/12/12 2:59 PM, "Joe
>>>>>Bowser" <
>>>>> >>>>> > > > bowserj@gmail.com
>>>>> >>>>> > > > > >
>>>>> >>>>> > > > > >>>> >>>wrote:
>>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>
>>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>Can we revert this, since this
>>>>>looks
>>>>> >>>>>like
>>>>> >>>>> it's
>>>>> >>>>> > > > > >>>>intended
>>>>> >>>>> > > > > >>>> >>>for
>>>>> >>>>> > > > > >>>> >>> both
>>>>> >>>>> > > > > >>>> >>> >> >> >>> Android
>>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>and iOS, but I don't think it
>>>>>should
>>>>> be
>>>>> >>>>>in
>>>>> >>>>> > > 1.6.1.
>>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>
>>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>On Thu, Apr 12, 2012 at 2:52
>>>>>PM, Filip
>>>>> >>>>>Maj <
>>>>> >>>>> > > > > >>>> fil@adobe.com>
>>>>> >>>>> > > > > >>>> >>> >> wrote:
>>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>
>>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> I was actually just looking
>>>>>at that
>>>>> >>>>> myself.
>>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>>
>>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> Looks like it's an iOS-only
>>>>>param..
>>>>> >>>>>sigh.
>>>>> >>>>> > We
>>>>> >>>>> > > > > >>>>gotta
>>>>> >>>>> > > > > >>>> stop
>>>>> >>>>> > > > > >>>> >>> doing
>>>>> >>>>> > > > > >>>> >>> >> >> >>>that,
>>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> especially if we don't update
>>>>> >>>>> documentation.
>>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>>
>>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> On 4/12/12 2:49 PM, "Joe
>>>>>Bowser"
>>>>> >>>>> > > > > >>>><bo...@gmail.com>
>>>>> >>>>> > > > > >>>> >>> wrote:
>>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>>
>>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >Has anyone tested the
>>>>>cropToSize
>>>>> >>>>>param
>>>>> >>>>> for
>>>>> >>>>> > > > > >>>> >>> Camera.getPicture
>>>>> >>>>> > > > > >>>> >>> >> >> >>>yet? I
>>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >didn't
>>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >notice that change until now.
>>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >
>>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >On Thu, Apr 12, 2012 at 2:46
>>>>>PM,
>>>>> >>>>>Filip
>>>>> >>>>> Maj
>>>>> >>>>> > > > > >>>> >>><fil@adobe.com
>>>>> >>>>> > > > > >>>> >>> >
>>>>> >>>>> > > > > >>>> >>> >> >> >>>wrote:
>>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >
>>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> JS tagged 1.6.1 - the
>>>>>build task
>>>>> >>>>>in
>>>>> >>>>>the
>>>>> >>>>> > JS
>>>>> >>>>> > > > > >>>>should
>>>>> >>>>> > > > > >>>> >>>work
>>>>> >>>>> > > > > >>>> >>> >> >> >>>properly
>>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>>now.
>>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >>
>>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> FYI if anyone has to
>>>>>modify the
>>>>> >>>>>jake
>>>>> >>>>> > tasks
>>>>> >>>>> > > in
>>>>> >>>>> > > > > >>>>the
>>>>> >>>>> > > > > >>>> >>>future
>>>>> >>>>> > > > > >>>> >>> >> and
>>>>> >>>>> > > > > >>>> >>> >> >> >>>make
>>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>>them
>>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> async, make sure you add
>>>>>the 4th
>>>>> >>>>> "async"
>>>>> >>>>> > > > > >>>>parameter
>>>>> >>>>> > > > > >>>> to
>>>>> >>>>> > > > > >>>> >>> the
>>>>> >>>>> > > > > >>>> >>> >> >> >>>task()
>>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >>function
>>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> and set it to true, and
>>>>>call
>>>>> >>>>>complete()
>>>>> >>>>> > > when
>>>>> >>>>> > > > > >>>>the
>>>>> >>>>> > > > > >>>> >>>task is
>>>>> >>>>> > > > > >>>> >>> >> done.
>>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >>
>>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> See
>>>>> >>>>> > > > > >>>> >>>
>>>>> >>>>>http://howtonode.org/intro-to-jake/async-jakefile.jsfor
>>>>> >>>>> > > > > >>>> >>> >> >> >>>an
>>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> example.
>>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >>
>>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> On 4/12/12 2:35 PM, "Joe
>>>>>Bowser"
>>>>> >>>>> > > > > >>>><bowserj@gmail.com
>>>>> >>>>> > > > > >>>> >
>>>>> >>>>> > > > > >>>> >>> >> wrote:
>>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >>
>>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >Ready to tag once
>>>>>cordova-js is
>>>>> >>>>>tagged
>>>>> >>>>> > > > 1.6.1.
>>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >
>>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >On Thu, Apr 12, 2012 at
>>>>>2:33 PM,
>>>>> >>>>>Anis
>>>>> >>>>> > > KADRI
>>>>> >>>>> > > > <
>>>>> >>>>> > > > > >>>> >>> >> >> >>> anis.kadri@gmail.com>
>>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >>wrote:
>>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >
>>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> I will tag my
>>>>>repository to
>>>>> >>>>>1.6.1
>>>>> >>>>> > before
>>>>> >>>>> > > > > >>>>end of
>>>>> >>>>> > > > > >>>> >>>day
>>>>> >>>>> > > > > >>>> >>> >> today
>>>>> >>>>> > > > > >>>> >>> >> >> >>>after
>>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>>some
>>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> thorough testing.
>>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >>
>>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> On Thu, Apr 12, 2012 at
>>>>>2:30
>>>>> >>>>>PM,
>>>>> >>>>> > Shazron
>>>>> >>>>> > > > > >>>> >>> >> >> >>><sh...@gmail.com>
>>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>>wrote:
>>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >>
>>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > I also created a 1.6.1
>>>>> >>>>>version
>>>>> >>>>>tag
>>>>> >>>>> > as
>>>>> >>>>> > > > > >>>>well in
>>>>> >>>>> > > > > >>>> >>> jira...
>>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> >
>>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > On Thu, Apr 12, 2012
>>>>>at 2:29
>>>>> >>>>>PM,
>>>>> >>>>> > > Shazron
>>>>> >>>>> > > > > >>>> >>> >> >> >>><sh...@gmail.com>
>>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> wrote:
>>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > > Alright guys since
>>>>>1.6.0
>>>>> >>>>>was
>>>>> >>>>> > > released,
>>>>> >>>>> > > > > >>>>I'm
>>>>> >>>>> > > > > >>>> >>>going
>>>>> >>>>> > > > > >>>> >>> to
>>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>>"Release"
>>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>>the
>>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > > 1.6.0 version in
>>>>>jira and
>>>>> >>>>>move
>>>>> >>>>> > > > > >>>>outstanding
>>>>> >>>>> > > > > >>>> >>> issues to
>>>>> >>>>> > > > > >>>> >>> >> >> >>>1.7.0
>>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >>version
>>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > > tag.
>>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >
>>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >
>>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > > On Thu, Apr 12,
>>>>>2012 at
>>>>> >>>>>2:26
>>>>> >>>>>PM,
>>>>> >>>>> > > Filip
>>>>> >>>>> > > > > >>>>Maj
>>>>> >>>>> > > > > >>>> >>> >> >> >>><fi...@adobe.com>
>>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> wrote:
>>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >> The JS needs
>>>>>patching
>>>>> too.
>>>>> >>>>> Since
>>>>> >>>>> > > > > >>>>adding the
>>>>> >>>>> > > > > >>>> >>> commit
>>>>> >>>>> > > > > >>>> >>> >> ID
>>>>> >>>>> > > > > >>>> >>> >> >> >>>into
>>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>>the
>>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> packaging
>>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >> in the jakefile,
>>>>>the
>>>>> >>>>>default
>>>>> >>>>> task
>>>>> >>>>> > > > isn't
>>>>> >>>>> > > > > >>>> >>>running
>>>>> >>>>> > > > > >>>> >>> >> >> >>>properly.
>>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>
>>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >> You can manually
>>>>>run
>>>>> "jake
>>>>> >>>>> build"
>>>>> >>>>> > > and
>>>>> >>>>> > > > > >>>>"jake
>>>>> >>>>> > > > > >>>> >>> test"
>>>>> >>>>> > > > > >>>> >>> >> but
>>>>> >>>>> > > > > >>>> >>> >> >> >>>not
>>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >>"jake" on
>>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> its
>>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >> own - gonna try to
>>>>>figure
>>>>> >>>>>it
>>>>> >>>>> out.
>>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>
>>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >> On 4/12/12 2:21 PM,
>>>>> >>>>>"Shazron" <
>>>>> >>>>> > > > > >>>> >>> shazron@gmail.com>
>>>>> >>>>> > > > > >>>> >>> >> >> >>>wrote:
>>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>
>>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>I'm good with
>>>>>tagging.
>>>>> >>>>>iOS
>>>>> >>>>> has a
>>>>> >>>>> > > few
>>>>> >>>>> > > > > >>>> commits
>>>>> >>>>> > > > > >>>> >>> (one
>>>>> >>>>> > > > > >>>> >>> >> >> >>>commit
>>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>>in
>>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>cordova-js) as
>>>>>well. Aim
>>>>> >>>>>for
>>>>> >>>>> > first
>>>>> >>>>> > > > > >>>>thing
>>>>> >>>>> > > > > >>>> >>> tomorrow
>>>>> >>>>> > > > > >>>> >>> >> for
>>>>> >>>>> > > > > >>>> >>> >> >> >>>you
>>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>>to
>>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>repackage?
>>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>
>>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>On Thu, Apr 12,
>>>>>2012 at
>>>>> >>>>>2:17
>>>>> >>>>> PM,
>>>>> >>>>> > > > > >>>>Steven Gill
>>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >><st...@gmail.com>
>>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>wrote:
>>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>> So a bug has been
>>>>> >>>>>discovered
>>>>> >>>>> in
>>>>> >>>>> > > > > >>>>Cordova
>>>>> >>>>> > > > > >>>> >>> Android
>>>>> >>>>> > > > > >>>> >>> >> that
>>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>>requires
>>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >>a
>>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >>new
>>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > tag
>>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>>and
>>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>> release. You can
>>>>>check
>>>>> >>>>>out
>>>>> >>>>> the
>>>>> >>>>> > > bug
>>>>> >>>>> > > > > >>>>on the
>>>>> >>>>> > > > > >>>> >>> issue
>>>>> >>>>> > > > > >>>> >>> >> >> >>>tracker
>>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>>at
>>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>>
>>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>>
>>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> >
>>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >>
>>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >>
>>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >>
>>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >>
>>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>>
>>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>>
>>>>> >>>>> > > > > >>>> >>> >> >> >>>
>>>>> >>>>> > > > > >>>> >>> >> >>
>>>>> >>>>> > > > > >>>> >>>
>>>>> >>>>> > > > > >>>>
>>>>> >>>>> > > > > >>>>
>>>>> >>>>> > > > >
>>>>> >>>>> > >
>>>>> >>>>>
>>>>> >>>>>
>>>>>
>>>>>https://issues.apache.org/jira/browse/CB-490?focusedCommentId=13252809
>>>>>#
>>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>>co
>>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>>mment-13252809
>>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>>
>>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>> It doesn't make
>>>>>sense
>>>>> to
>>>>> >>>>>just
>>>>> >>>>> > > > > >>>>repackage
>>>>> >>>>> > > > > >>>> >>>1.6.0
>>>>> >>>>> > > > > >>>> >>> >> with
>>>>> >>>>> > > > > >>>> >>> >> >> >>>this
>>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>>bug
>>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >>fixed as
>>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > we
>>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>> will have no way
>>>>>to
>>>>> know
>>>>> >>>>>if
>>>>> >>>>> > > people
>>>>> >>>>> > > > > >>>>are
>>>>> >>>>> > > > > >>>> >>> >> experiencing
>>>>> >>>>> > > > > >>>> >>> >> >> >>>this
>>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>>or
>>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >>not.
>>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>>
>>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>> Anis mentioned
>>>>>Bada
>>>>> also
>>>>> >>>>>had
>>>>> >>>>> > some
>>>>> >>>>> > > > > >>>>major
>>>>> >>>>> > > > > >>>> >>>issues
>>>>> >>>>> > > > > >>>> >>> >> >> >>>which he
>>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>>has
>>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >>fixed
>>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> now
>>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>>and
>>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>> would like in a
>>>>>1.6.1
>>>>> >>>>> release.
>>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>>
>>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>> Thoughts?
>>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>>
>>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>> -Steve
>>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>
>>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> >
>>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >>
>>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >>
>>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >>
>>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>>
>>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>>
>>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>
>>>>> >>>>> > > > > >>>> >>> >> >> >>> >
>>>>> >>>>> > > > > >>>> >>> >> >> >>>
>>>>> >>>>> > > > > >>>> >>> >> >>
>>>>> >>>>> > > > > >>>> >>> >> >>
>>>>> >>>>> > > > > >>>> >>> >>
>>>>> >>>>> > > > > >>>> >>>
>>>>> >>>>> > > > > >>>> >
>>>>> >>>>> > > > > >>>>
>>>>> >>>>> > > > >
>>>>> >>>>> > > > >
>>>>> >>>>> > > >
>>>>> >>>>> > >
>>>>> >>>>> >
>>>>> >>>>>
>>>>> >>>
>>>>> >
>>>>>
Re: 1.6.1
Posted by Shazron <sh...@gmail.com>.
+1 seems like more bugs are getting shaken out of the tree. Just
discovered another one:
https://issues.apache.org/jira/browse/CB-501
On Fri, Apr 13, 2012 at 6:59 AM, Simon MacDonald
<si...@gmail.com> wrote:
> Maybe we should wait until Monday before re-tagging? I mean if we are
> going to re-release let's give it a few more days to shake out these
> issues.
>
> Simon Mac Donald
> http://hi.im/simonmacdonald
>
>
>
> On Fri, Apr 13, 2012 at 9:54 AM, Shazron <sh...@gmail.com> wrote:
>> Users are discovering more bugs:
>> https://issues.apache.org/jira/browse/CB-497
>> https://github.com/apache/incubator-cordova-ios/blob/master/CordovaLib/Classes/CDVConnection.m#L103
>>
>> So I'm going to have to review, fix and re-tag, so wait up.
>>
>>
>> On Thu, Apr 12, 2012 at 5:38 PM, Jesse <pu...@gmail.com> wrote:
>>> I am commited and tagged
>>>
>>> On Thu, Apr 12, 2012 at 5:27 PM, Shazron <sh...@gmail.com> wrote:
>>>
>>>> Logic error - no worries, I patched it (going to re-do 1.6.1 iOS)
>>>>
>>>> On Thu, Apr 12, 2012 at 5:27 PM, Filip Maj <fi...@adobe.com> wrote:
>>>> > Did I f that up?
>>>> >
>>>> > On 4/12/12 5:07 PM, "Shazron" <sh...@gmail.com> wrote:
>>>> >
>>>> >>Sigh - user reported iOS bug
>>>> >>
>>>> http://groups.google.com/group/phonegap/browse_thread/thread/faad0af97dec8
>>>> >>907
>>>> >>(you know who you are ;)
>>>> >>
>>>> >>On Thu, Apr 12, 2012 at 5:05 PM, Filip Maj <fi...@adobe.com> wrote:
>>>> >>> Saweet! Nice work Anis. That kills off a bunch of old issues in JIRA
>>>> >>>too.
>>>> >>>
>>>> >>> Way to hunker down all. As Jesse pointed out to me, we did 45 emails in
>>>> >>> two hours haha
>>>> >>>
>>>> >>> On 4/12/12 5:00 PM, "Anis KADRI" <an...@gmail.com> wrote:
>>>> >>>
>>>> >>>>Bada 1.2 is tagged 1.6.1. I added the new Cordova artwork,
>>>> >>>>LICENSE/NOTICE
>>>> >>>>files as well as the Apache source headers in every source file. I
>>>> fixed
>>>> >>>>all the bugs I sawS
>>>> >>>>
>>>> >>>>On Thu, Apr 12, 2012 at 4:38 PM, Joe Bowser <bo...@gmail.com> wrote:
>>>> >>>>
>>>> >>>>> Android is tagged.
>>>> >>>>>
>>>> >>>>> On Thu, Apr 12, 2012 at 4:36 PM, Jesse <pu...@gmail.com>
>>>> >>>>>wrote:
>>>> >>>>>
>>>> >>>>> > Done
>>>> >>>>> >
>>>> >>>>> > On Thu, Apr 12, 2012 at 4:31 PM, Joe Bowser <bo...@gmail.com>
>>>> >>>>>wrote:
>>>> >>>>> >
>>>> >>>>> > > I'd like to get the JS from the tag, but I need a tag for that.
>>>> >>>>> > >
>>>> >>>>> > > On Thu, Apr 12, 2012 at 4:29 PM, Jesse <pu...@gmail.com>
>>>> >>>>> wrote:
>>>> >>>>> > >
>>>> >>>>> > > > Okay, I think it's good, tagging at 16:32 PDT if i don't hear
>>>> >>>>>any
>>>> >>>>> > > > complaints.
>>>> >>>>> > > >
>>>> >>>>> > > > On Thu, Apr 12, 2012 at 4:26 PM, Filip Maj <fi...@adobe.com>
>>>> >>>>>wrote:
>>>> >>>>> > > >
>>>> >>>>> > > > > I just axed the existing 1.6.1 cordova-js tag
>>>> >>>>> > > > >
>>>> >>>>> > > > > Jesse when you feel you've got everything in there go ahead
>>>> >>>>>and
>>>> >>>>>tag
>>>> >>>>> > JS
>>>> >>>>> > > > >
>>>> >>>>> > > > > On 4/12/12 4:20 PM, "Shazron" <sh...@gmail.com> wrote:
>>>> >>>>> > > > >
>>>> >>>>> > > > > >Reverted. Just talked to Jesse - he has commits to
>>>> cordova-js
>>>> >>>>> > coming,
>>>> >>>>> > > > > >once those are in we can re-tag cordova-js to 1.6.1
>>>> >>>>> > > > > >
>>>> >>>>> > > > > >On Thu, Apr 12, 2012 at 4:12 PM, Shazron <shazron@gmail.com
>>>> >
>>>> >>>>> wrote:
>>>> >>>>> > > > > >> I'll remove it. *grabs the shovel*
>>>> >>>>> > > > > >>
>>>> >>>>> > > > > >> On Thu, Apr 12, 2012 at 4:10 PM, Joe Bowser
>>>> >>>>><bo...@gmail.com>
>>>> >>>>> > > > wrote:
>>>> >>>>> > > > > >>> You know, let's not rebase it, because it does modify the
>>>> >>>>> > history.
>>>> >>>>> > > > We
>>>> >>>>> > > > > >>> should remove and document why we did it instead, since
>>>> >>>>>that
>>>> >>>>> > would
>>>> >>>>> > > be
>>>> >>>>> > > > > >>>more
>>>> >>>>> > > > > >>> transparent. Or we could just leave it in and say "don't
>>>> >>>>>do
>>>> >>>>> this
>>>> >>>>> > > next
>>>> >>>>> > > > > >>> time". I'm not that invested in it.
>>>> >>>>> > > > > >>>
>>>> >>>>> > > > > >>> On Thu, Apr 12, 2012 at 4:04 PM, Shazron
>>>> >>>>><sh...@gmail.com>
>>>> >>>>> > > wrote:
>>>> >>>>> > > > > >>>
>>>> >>>>> > > > > >>>> If we take out that iOS commit in cordova-js (somehow),
>>>> >>>>>it
>>>> >>>>> > should
>>>> >>>>> > > be
>>>> >>>>> > > > > >>>> fine. cordova-ios 1.6.1 will then just be the same as
>>>> >>>>>1.6.0.
>>>> >>>>> > > > > >>>>
>>>> >>>>> > > > > >>>> On Thu, Apr 12, 2012 at 4:02 PM, Filip Maj
>>>> >>>>><fi...@adobe.com>
>>>> >>>>> > wrote:
>>>> >>>>> > > > > >>>> >
>>>> >>>>> > > > > >>>> >>Is it too much to drop the new commit that changed the
>>>> >>>>> common
>>>> >>>>> > js
>>>> >>>>> > > > > >>>>API, and
>>>> >>>>> > > > > >>>> >>reapply it after we tag 1.6.1, and figure this one
>>>> >>>>>thing
>>>> >>>>>out
>>>> >>>>> > for
>>>> >>>>> > > > > >>>>1.7?
>>>> >>>>> > > > > >>>> >
>>>> >>>>> > > > > >>>> > That sounds very good to me but I am under the
>>>> >>>>>impression
>>>> >>>>> that
>>>> >>>>> > > iOS
>>>> >>>>> > > > > >>>> > requires this commit? Like I said I'm quite confused.
>>>> >>>>> > > > > >>>> >
>>>> >>>>> > > > > >>>> >>
>>>> >>>>> > > > > >>>> >>I also have some cordova-js commits to add to 1.6.1?
>>>> >>>>> Although
>>>> >>>>> > > > > >>>>nothing
>>>> >>>>> > > > > >>>> that
>>>> >>>>> > > > > >>>> >>modifies any js outside of what is built for wp7. (
>>>> ie,
>>>> >>>>>all
>>>> >>>>> in
>>>> >>>>> > > my
>>>> >>>>> > > > > >>>> platform
>>>> >>>>> > > > > >>>> >>specific plugins folder )
>>>> >>>>> > > > > >>>> >>
>>>> >>>>> > > > > >>>> >
>>>> >>>>> > > > > >>>> > O then it sounds like I tagged the JS 1.6.1 too early
>>>> >>>>> > anyways..
>>>> >>>>> > > > > >>>> >
>>>> >>>>> > > > > >>>> >>
>>>> >>>>> > > > > >>>> >>
>>>> >>>>> > > > > >>>> >>
>>>> >>>>> > > > > >>>> >>On Thu, Apr 12, 2012 at 3:51 PM, Shazron
>>>> >>>>><shazron@gmail.com
>>>> >>>>> >
>>>> >>>>> > > > wrote:
>>>> >>>>> > > > > >>>> >>
>>>> >>>>> > > > > >>>> >>> No - it's about a user's contribution being noted
>>>> (it
>>>> >>>>> > > exists), I
>>>> >>>>> > > > > >>>>will
>>>> >>>>> > > > > >>>> >>> move it out of the common code post-1.6.1 (I
>>>> >>>>>acknowledge
>>>> >>>>> my
>>>> >>>>> > > > > >>>>mistake in
>>>> >>>>> > > > > >>>> >>> allowing it in the first place). Can we branch off
>>>> >>>>>1.6.0
>>>> >>>>> > then
>>>> >>>>> > > > > >>>> >>> cherry-pick Fil's latest fix for 1.6.1?
>>>> >>>>> > > > > >>>> >>>
>>>> >>>>> > > > > >>>> >>> On Thu, Apr 12, 2012 at 3:47 PM, Joe Bowser <
>>>> >>>>> > > bowserj@gmail.com>
>>>> >>>>> > > > > >>>>wrote:
>>>> >>>>> > > > > >>>> >>> > OK, so you're proposing that we leave the thing in
>>>> >>>>>the
>>>> >>>>> > > common
>>>> >>>>> > > > > >>>>JS,
>>>> >>>>> > > > > >>>> even
>>>> >>>>> > > > > >>>> >>> > though it's not supposed to be there.
>>>> >>>>> > > > > >>>> >>> >
>>>> >>>>> > > > > >>>> >>> > On Thu, Apr 12, 2012 at 3:45 PM, Shazron <
>>>> >>>>> > shazron@gmail.com
>>>> >>>>> > > >
>>>> >>>>> > > > > >>>>wrote:
>>>> >>>>> > > > > >>>> >>> >
>>>> >>>>> > > > > >>>> >>> >> Will rebasing lose that commit? Then, no.
>>>> >>>>> > > > > >>>> >>> >>
>>>> >>>>> > > > > >>>> >>> >> On Thu, Apr 12, 2012 at 3:43 PM, Joe Bowser <
>>>> >>>>> > > > bowserj@gmail.com
>>>> >>>>> > > > > >
>>>> >>>>> > > > > >>>> >>>wrote:
>>>> >>>>> > > > > >>>> >>> >> > So, can we just rebase the head, push this out
>>>> >>>>>and
>>>> >>>>> get
>>>> >>>>> > > this
>>>> >>>>> > > > > >>>> >>>rolling?
>>>> >>>>> > > > > >>>> >>> >> >
>>>> >>>>> > > > > >>>> >>> >> > On Thu, Apr 12, 2012 at 3:43 PM, Filip Maj <
>>>> >>>>> > > fil@adobe.com>
>>>> >>>>> > > > > >>>>wrote:
>>>> >>>>> > > > > >>>> >>> >> >
>>>> >>>>> > > > > >>>> >>> >> >> Correct, those iOS-specific parameters (like
>>>> >>>>>allow
>>>> >>>>> > edit
>>>> >>>>> > > > and
>>>> >>>>> > > > > >>>>those
>>>> >>>>> > > > > >>>> >>> ones)
>>>> >>>>> > > > > >>>> >>> >> >> existed prior to cordova-js, so yeah, we left
>>>> >>>>>them
>>>> >>>>> in
>>>> >>>>> > > > there
>>>> >>>>> > > > > >>>>as we
>>>> >>>>> > > > > >>>> >>> didn't
>>>> >>>>> > > > > >>>> >>> >> >> want to remove without deprecation.
>>>> >>>>> > > > > >>>> >>> >> >>
>>>> >>>>> > > > > >>>> >>> >> >> If you can deal with the iOS issue without
>>>> >>>>>needing
>>>> >>>>> an
>>>> >>>>> > > API
>>>> >>>>> > > > > >>>> >>>extension:
>>>> >>>>> > > > > >>>> >>> >> then
>>>> >>>>> > > > > >>>> >>> >> >> do that. If not, leave it in there, but docs
>>>> >>>>>need to
>>>> >>>>> > > > > >>>>updated too.
>>>> >>>>> > > > > >>>> >>> >> >>
>>>> >>>>> > > > > >>>> >>> >> >> Extending and changing the public API is a
>>>> long
>>>> >>>>>and
>>>> >>>>> > > > > >>>>difficult
>>>> >>>>> > > > > >>>> >>>process
>>>> >>>>> > > > > >>>> >>> >> for
>>>> >>>>> > > > > >>>> >>> >> >> us and will only get tougher with every
>>>> >>>>>platform
>>>> >>>>>we
>>>> >>>>> > add
>>>> >>>>> > > > > >>>>support
>>>> >>>>> > > > > >>>> >>>to.
>>>> >>>>> > > > > >>>> >>> >> >>
>>>> >>>>> > > > > >>>> >>> >> >> On 4/12/12 3:37 PM, "Shazron"
>>>> >>>>><sh...@gmail.com>
>>>> >>>>> > > wrote:
>>>> >>>>> > > > > >>>> >>> >> >>
>>>> >>>>> > > > > >>>> >>> >> >> >Then we have to scrap the other three(?) iOS
>>>> >>>>> > parameters
>>>> >>>>> > > > > >>>>ones
>>>> >>>>> > > > > >>>> that
>>>> >>>>> > > > > >>>> >>> >> >> >already exist in common if you noticed. Don't
>>>> >>>>>know
>>>> >>>>> > how
>>>> >>>>> > > we
>>>> >>>>> > > > > >>>>merge
>>>> >>>>> > > > > >>>> >>> >> >> >(unmerge?) this one properly because taking
>>>> >>>>>those
>>>> >>>>> out
>>>> >>>>> > > > will
>>>> >>>>> > > > > >>>>break
>>>> >>>>> > > > > >>>> >>> >> >> >everyone that is using it, but a deprecation
>>>> >>>>>is
>>>> >>>>>the
>>>> >>>>> > way
>>>> >>>>> > > > to
>>>> >>>>> > > > > >>>>go as
>>>> >>>>> > > > > >>>> >>>per
>>>> >>>>> > > > > >>>> >>> >> >>
>>>> >>>>>>http://wiki.apache.org/cordova/DeprecationPolicy .
>>>> >>>>> > We
>>>> >>>>> > > > can
>>>> >>>>> > > > > >>>> remove
>>>> >>>>> > > > > >>>> >>> this
>>>> >>>>> > > > > >>>> >>> >> >> >new commit and I'll find a way to get this in
>>>> >>>>> > somehow.
>>>> >>>>> > > > > >>>> >>> >> >> >
>>>> >>>>> > > > > >>>> >>> >> >> >
>>>> >>>>> > > > > >>>> >>> >> >> >
>>>> >>>>> > > > > >>>> >>> >> >> >On Thu, Apr 12, 2012 at 3:32 PM, Joe Bowser
>>>> >>>>> > > > > >>>><bo...@gmail.com>
>>>> >>>>> > > > > >>>> >>> wrote:
>>>> >>>>> > > > > >>>> >>> >> >> >> The problem is that this parameter doesn't
>>>> >>>>>belong
>>>> >>>>> > in
>>>> >>>>> > > > the
>>>> >>>>> > > > > >>>> common
>>>> >>>>> > > > > >>>> >>> API.
>>>> >>>>> > > > > >>>> >>> >> >> >>It'd
>>>> >>>>> > > > > >>>> >>> >> >> >> be just ignored in Android, but the whole
>>>> >>>>>point
>>>> >>>>> of
>>>> >>>>> > > > > >>>>cordova-js
>>>> >>>>> > > > > >>>> >>>is
>>>> >>>>> > > > > >>>> >>> so
>>>> >>>>> > > > > >>>> >>> >> that
>>>> >>>>> > > > > >>>> >>> >> >> >> it's common. It'd look pretty screwed up
>>>> to
>>>> >>>>>add
>>>> >>>>> > this
>>>> >>>>> > > > to
>>>> >>>>> > > > > >>>>the
>>>> >>>>> > > > > >>>> >>>docs,
>>>> >>>>> > > > > >>>> >>> >> IMO.
>>>> >>>>> > > > > >>>> >>> >> >> >>
>>>> >>>>> > > > > >>>> >>> >> >> >> On Thu, Apr 12, 2012 at 3:26 PM, Shazron
>>>> >>>>> > > > > >>>><sh...@gmail.com>
>>>> >>>>> > > > > >>>> >>> wrote:
>>>> >>>>> > > > > >>>> >>> >> >> >>
>>>> >>>>> > > > > >>>> >>> >> >> >>> To fix two bugs for Camera.takePicture on
>>>> >>>>>iOS
>>>> >>>>> > > > > >>>> >>> >> >> >>>
>>>> >>>>> > > > > >>>> >>> >> >> >>> On Thu, Apr 12, 2012 at 3:24 PM, Filip Maj
>>>> >>>>> > > > > >>>><fi...@adobe.com>
>>>> >>>>> > > > > >>>> >>> wrote:
>>>> >>>>> > > > > >>>> >>> >> >> >>> > so what's the point of this new
>>>> >>>>>parameter?
>>>> >>>>> > > > > >>>> >>> >> >> >>> >
>>>> >>>>> > > > > >>>> >>> >> >> >>> > On 4/12/12 3:16 PM, "Shazron" <
>>>> >>>>> > shazron@gmail.com>
>>>> >>>>> > > > > >>>>wrote:
>>>> >>>>> > > > > >>>> >>> >> >> >>> >
>>>> >>>>> > > > > >>>> >>> >> >> >>> >>I did. Do we want to revert the
>>>> >>>>>cordova-js? I
>>>> >>>>> > can
>>>> >>>>> > > > > >>>>branch
>>>> >>>>> > > > > >>>> >>>1.6.0
>>>> >>>>> > > > > >>>> >>> and
>>>> >>>>> > > > > >>>> >>> >> >> >>> >>cherry-pick your latest commit for 1.6.1
>>>> >>>>> > > > > >>>> >>> >> >> >>> >>
>>>> >>>>> > > > > >>>> >>> >> >> >>> >>On Thu, Apr 12, 2012 at 3:04 PM, Filip
>>>> >>>>>Maj
>>>> >>>>> > > > > >>>><fi...@adobe.com>
>>>> >>>>> > > > > >>>> >>> wrote:
>>>> >>>>> > > > > >>>> >>> >> >> >>> >>> I saw something in the iOS commit logs
>>>> >>>>>for
>>>> >>>>> > this.
>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>
>>>> >>>>> > > > > >>>> >>> >> >> >>> >>> Shaz can you comment?
>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>
>>>> >>>>> > > > > >>>> >>> >> >> >>> >>> On 4/12/12 2:59 PM, "Joe Bowser" <
>>>> >>>>> > > > bowserj@gmail.com
>>>> >>>>> > > > > >
>>>> >>>>> > > > > >>>> >>>wrote:
>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>
>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>Can we revert this, since this looks
>>>> >>>>>like
>>>> >>>>> it's
>>>> >>>>> > > > > >>>>intended
>>>> >>>>> > > > > >>>> >>>for
>>>> >>>>> > > > > >>>> >>> both
>>>> >>>>> > > > > >>>> >>> >> >> >>> Android
>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>and iOS, but I don't think it should
>>>> be
>>>> >>>>>in
>>>> >>>>> > > 1.6.1.
>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>
>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>On Thu, Apr 12, 2012 at 2:52 PM, Filip
>>>> >>>>>Maj <
>>>> >>>>> > > > > >>>> fil@adobe.com>
>>>> >>>>> > > > > >>>> >>> >> wrote:
>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>
>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> I was actually just looking at that
>>>> >>>>> myself.
>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>>
>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> Looks like it's an iOS-only param..
>>>> >>>>>sigh.
>>>> >>>>> > We
>>>> >>>>> > > > > >>>>gotta
>>>> >>>>> > > > > >>>> stop
>>>> >>>>> > > > > >>>> >>> doing
>>>> >>>>> > > > > >>>> >>> >> >> >>>that,
>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> especially if we don't update
>>>> >>>>> documentation.
>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>>
>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> On 4/12/12 2:49 PM, "Joe Bowser"
>>>> >>>>> > > > > >>>><bo...@gmail.com>
>>>> >>>>> > > > > >>>> >>> wrote:
>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>>
>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >Has anyone tested the cropToSize
>>>> >>>>>param
>>>> >>>>> for
>>>> >>>>> > > > > >>>> >>> Camera.getPicture
>>>> >>>>> > > > > >>>> >>> >> >> >>>yet? I
>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >didn't
>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >notice that change until now.
>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >
>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >On Thu, Apr 12, 2012 at 2:46 PM,
>>>> >>>>>Filip
>>>> >>>>> Maj
>>>> >>>>> > > > > >>>> >>><fil@adobe.com
>>>> >>>>> > > > > >>>> >>> >
>>>> >>>>> > > > > >>>> >>> >> >> >>>wrote:
>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >
>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> JS tagged 1.6.1 - the build task
>>>> >>>>>in
>>>> >>>>>the
>>>> >>>>> > JS
>>>> >>>>> > > > > >>>>should
>>>> >>>>> > > > > >>>> >>>work
>>>> >>>>> > > > > >>>> >>> >> >> >>>properly
>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>>now.
>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >>
>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> FYI if anyone has to modify the
>>>> >>>>>jake
>>>> >>>>> > tasks
>>>> >>>>> > > in
>>>> >>>>> > > > > >>>>the
>>>> >>>>> > > > > >>>> >>>future
>>>> >>>>> > > > > >>>> >>> >> and
>>>> >>>>> > > > > >>>> >>> >> >> >>>make
>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>>them
>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> async, make sure you add the 4th
>>>> >>>>> "async"
>>>> >>>>> > > > > >>>>parameter
>>>> >>>>> > > > > >>>> to
>>>> >>>>> > > > > >>>> >>> the
>>>> >>>>> > > > > >>>> >>> >> >> >>>task()
>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >>function
>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> and set it to true, and call
>>>> >>>>>complete()
>>>> >>>>> > > when
>>>> >>>>> > > > > >>>>the
>>>> >>>>> > > > > >>>> >>>task is
>>>> >>>>> > > > > >>>> >>> >> done.
>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >>
>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> See
>>>> >>>>> > > > > >>>> >>>
>>>> >>>>>http://howtonode.org/intro-to-jake/async-jakefile.jsfor
>>>> >>>>> > > > > >>>> >>> >> >> >>>an
>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> example.
>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >>
>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> On 4/12/12 2:35 PM, "Joe Bowser"
>>>> >>>>> > > > > >>>><bowserj@gmail.com
>>>> >>>>> > > > > >>>> >
>>>> >>>>> > > > > >>>> >>> >> wrote:
>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >>
>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >Ready to tag once cordova-js is
>>>> >>>>>tagged
>>>> >>>>> > > > 1.6.1.
>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >
>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >On Thu, Apr 12, 2012 at 2:33 PM,
>>>> >>>>>Anis
>>>> >>>>> > > KADRI
>>>> >>>>> > > > <
>>>> >>>>> > > > > >>>> >>> >> >> >>> anis.kadri@gmail.com>
>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >>wrote:
>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >
>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> I will tag my repository to
>>>> >>>>>1.6.1
>>>> >>>>> > before
>>>> >>>>> > > > > >>>>end of
>>>> >>>>> > > > > >>>> >>>day
>>>> >>>>> > > > > >>>> >>> >> today
>>>> >>>>> > > > > >>>> >>> >> >> >>>after
>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>>some
>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> thorough testing.
>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >>
>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> On Thu, Apr 12, 2012 at 2:30
>>>> >>>>>PM,
>>>> >>>>> > Shazron
>>>> >>>>> > > > > >>>> >>> >> >> >>><sh...@gmail.com>
>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>>wrote:
>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >>
>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > I also created a 1.6.1
>>>> >>>>>version
>>>> >>>>>tag
>>>> >>>>> > as
>>>> >>>>> > > > > >>>>well in
>>>> >>>>> > > > > >>>> >>> jira...
>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> >
>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > On Thu, Apr 12, 2012 at 2:29
>>>> >>>>>PM,
>>>> >>>>> > > Shazron
>>>> >>>>> > > > > >>>> >>> >> >> >>><sh...@gmail.com>
>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> wrote:
>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > > Alright guys since 1.6.0
>>>> >>>>>was
>>>> >>>>> > > released,
>>>> >>>>> > > > > >>>>I'm
>>>> >>>>> > > > > >>>> >>>going
>>>> >>>>> > > > > >>>> >>> to
>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>>"Release"
>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>>the
>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > > 1.6.0 version in jira and
>>>> >>>>>move
>>>> >>>>> > > > > >>>>outstanding
>>>> >>>>> > > > > >>>> >>> issues to
>>>> >>>>> > > > > >>>> >>> >> >> >>>1.7.0
>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >>version
>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > > tag.
>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >
>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >
>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > > On Thu, Apr 12, 2012 at
>>>> >>>>>2:26
>>>> >>>>>PM,
>>>> >>>>> > > Filip
>>>> >>>>> > > > > >>>>Maj
>>>> >>>>> > > > > >>>> >>> >> >> >>><fi...@adobe.com>
>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> wrote:
>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >> The JS needs patching
>>>> too.
>>>> >>>>> Since
>>>> >>>>> > > > > >>>>adding the
>>>> >>>>> > > > > >>>> >>> commit
>>>> >>>>> > > > > >>>> >>> >> ID
>>>> >>>>> > > > > >>>> >>> >> >> >>>into
>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>>the
>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> packaging
>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >> in the jakefile, the
>>>> >>>>>default
>>>> >>>>> task
>>>> >>>>> > > > isn't
>>>> >>>>> > > > > >>>> >>>running
>>>> >>>>> > > > > >>>> >>> >> >> >>>properly.
>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>
>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >> You can manually run
>>>> "jake
>>>> >>>>> build"
>>>> >>>>> > > and
>>>> >>>>> > > > > >>>>"jake
>>>> >>>>> > > > > >>>> >>> test"
>>>> >>>>> > > > > >>>> >>> >> but
>>>> >>>>> > > > > >>>> >>> >> >> >>>not
>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >>"jake" on
>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> its
>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >> own - gonna try to figure
>>>> >>>>>it
>>>> >>>>> out.
>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>
>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >> On 4/12/12 2:21 PM,
>>>> >>>>>"Shazron" <
>>>> >>>>> > > > > >>>> >>> shazron@gmail.com>
>>>> >>>>> > > > > >>>> >>> >> >> >>>wrote:
>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>
>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>I'm good with tagging.
>>>> >>>>>iOS
>>>> >>>>> has a
>>>> >>>>> > > few
>>>> >>>>> > > > > >>>> commits
>>>> >>>>> > > > > >>>> >>> (one
>>>> >>>>> > > > > >>>> >>> >> >> >>>commit
>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>>in
>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>cordova-js) as well. Aim
>>>> >>>>>for
>>>> >>>>> > first
>>>> >>>>> > > > > >>>>thing
>>>> >>>>> > > > > >>>> >>> tomorrow
>>>> >>>>> > > > > >>>> >>> >> for
>>>> >>>>> > > > > >>>> >>> >> >> >>>you
>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>>to
>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>repackage?
>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>
>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>On Thu, Apr 12, 2012 at
>>>> >>>>>2:17
>>>> >>>>> PM,
>>>> >>>>> > > > > >>>>Steven Gill
>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >><st...@gmail.com>
>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>wrote:
>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>> So a bug has been
>>>> >>>>>discovered
>>>> >>>>> in
>>>> >>>>> > > > > >>>>Cordova
>>>> >>>>> > > > > >>>> >>> Android
>>>> >>>>> > > > > >>>> >>> >> that
>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>>requires
>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >>a
>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >>new
>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > tag
>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>>and
>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>> release. You can check
>>>> >>>>>out
>>>> >>>>> the
>>>> >>>>> > > bug
>>>> >>>>> > > > > >>>>on the
>>>> >>>>> > > > > >>>> >>> issue
>>>> >>>>> > > > > >>>> >>> >> >> >>>tracker
>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>>at
>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>>
>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>>
>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> >
>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >>
>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >>
>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >>
>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >>
>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>>
>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>>
>>>> >>>>> > > > > >>>> >>> >> >> >>>
>>>> >>>>> > > > > >>>> >>> >> >>
>>>> >>>>> > > > > >>>> >>>
>>>> >>>>> > > > > >>>>
>>>> >>>>> > > > > >>>>
>>>> >>>>> > > > >
>>>> >>>>> > >
>>>> >>>>>
>>>> >>>>>
>>>> https://issues.apache.org/jira/browse/CB-490?focusedCommentId=13252809#
>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>>co
>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>>mment-13252809
>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>>
>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>> It doesn't make sense
>>>> to
>>>> >>>>>just
>>>> >>>>> > > > > >>>>repackage
>>>> >>>>> > > > > >>>> >>>1.6.0
>>>> >>>>> > > > > >>>> >>> >> with
>>>> >>>>> > > > > >>>> >>> >> >> >>>this
>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>>bug
>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >>fixed as
>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > we
>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>> will have no way to
>>>> know
>>>> >>>>>if
>>>> >>>>> > > people
>>>> >>>>> > > > > >>>>are
>>>> >>>>> > > > > >>>> >>> >> experiencing
>>>> >>>>> > > > > >>>> >>> >> >> >>>this
>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>>or
>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >>not.
>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>>
>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>> Anis mentioned Bada
>>>> also
>>>> >>>>>had
>>>> >>>>> > some
>>>> >>>>> > > > > >>>>major
>>>> >>>>> > > > > >>>> >>>issues
>>>> >>>>> > > > > >>>> >>> >> >> >>>which he
>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>>has
>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >>fixed
>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> now
>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>>and
>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>> would like in a 1.6.1
>>>> >>>>> release.
>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>>
>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>> Thoughts?
>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>>
>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>> -Steve
>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>
>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> >
>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >>
>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >>
>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >>
>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>>
>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>>
>>>> >>>>> > > > > >>>> >>> >> >> >>> >>>
>>>> >>>>> > > > > >>>> >>> >> >> >>> >
>>>> >>>>> > > > > >>>> >>> >> >> >>>
>>>> >>>>> > > > > >>>> >>> >> >>
>>>> >>>>> > > > > >>>> >>> >> >>
>>>> >>>>> > > > > >>>> >>> >>
>>>> >>>>> > > > > >>>> >>>
>>>> >>>>> > > > > >>>> >
>>>> >>>>> > > > > >>>>
>>>> >>>>> > > > >
>>>> >>>>> > > > >
>>>> >>>>> > > >
>>>> >>>>> > >
>>>> >>>>> >
>>>> >>>>>
>>>> >>>
>>>> >
>>>>
Re: 1.6.1
Posted by Simon MacDonald <si...@gmail.com>.
Maybe we should wait until Monday before re-tagging? I mean if we are
going to re-release let's give it a few more days to shake out these
issues.
Simon Mac Donald
http://hi.im/simonmacdonald
On Fri, Apr 13, 2012 at 9:54 AM, Shazron <sh...@gmail.com> wrote:
> Users are discovering more bugs:
> https://issues.apache.org/jira/browse/CB-497
> https://github.com/apache/incubator-cordova-ios/blob/master/CordovaLib/Classes/CDVConnection.m#L103
>
> So I'm going to have to review, fix and re-tag, so wait up.
>
>
> On Thu, Apr 12, 2012 at 5:38 PM, Jesse <pu...@gmail.com> wrote:
>> I am commited and tagged
>>
>> On Thu, Apr 12, 2012 at 5:27 PM, Shazron <sh...@gmail.com> wrote:
>>
>>> Logic error - no worries, I patched it (going to re-do 1.6.1 iOS)
>>>
>>> On Thu, Apr 12, 2012 at 5:27 PM, Filip Maj <fi...@adobe.com> wrote:
>>> > Did I f that up?
>>> >
>>> > On 4/12/12 5:07 PM, "Shazron" <sh...@gmail.com> wrote:
>>> >
>>> >>Sigh - user reported iOS bug
>>> >>
>>> http://groups.google.com/group/phonegap/browse_thread/thread/faad0af97dec8
>>> >>907
>>> >>(you know who you are ;)
>>> >>
>>> >>On Thu, Apr 12, 2012 at 5:05 PM, Filip Maj <fi...@adobe.com> wrote:
>>> >>> Saweet! Nice work Anis. That kills off a bunch of old issues in JIRA
>>> >>>too.
>>> >>>
>>> >>> Way to hunker down all. As Jesse pointed out to me, we did 45 emails in
>>> >>> two hours haha
>>> >>>
>>> >>> On 4/12/12 5:00 PM, "Anis KADRI" <an...@gmail.com> wrote:
>>> >>>
>>> >>>>Bada 1.2 is tagged 1.6.1. I added the new Cordova artwork,
>>> >>>>LICENSE/NOTICE
>>> >>>>files as well as the Apache source headers in every source file. I
>>> fixed
>>> >>>>all the bugs I sawS
>>> >>>>
>>> >>>>On Thu, Apr 12, 2012 at 4:38 PM, Joe Bowser <bo...@gmail.com> wrote:
>>> >>>>
>>> >>>>> Android is tagged.
>>> >>>>>
>>> >>>>> On Thu, Apr 12, 2012 at 4:36 PM, Jesse <pu...@gmail.com>
>>> >>>>>wrote:
>>> >>>>>
>>> >>>>> > Done
>>> >>>>> >
>>> >>>>> > On Thu, Apr 12, 2012 at 4:31 PM, Joe Bowser <bo...@gmail.com>
>>> >>>>>wrote:
>>> >>>>> >
>>> >>>>> > > I'd like to get the JS from the tag, but I need a tag for that.
>>> >>>>> > >
>>> >>>>> > > On Thu, Apr 12, 2012 at 4:29 PM, Jesse <pu...@gmail.com>
>>> >>>>> wrote:
>>> >>>>> > >
>>> >>>>> > > > Okay, I think it's good, tagging at 16:32 PDT if i don't hear
>>> >>>>>any
>>> >>>>> > > > complaints.
>>> >>>>> > > >
>>> >>>>> > > > On Thu, Apr 12, 2012 at 4:26 PM, Filip Maj <fi...@adobe.com>
>>> >>>>>wrote:
>>> >>>>> > > >
>>> >>>>> > > > > I just axed the existing 1.6.1 cordova-js tag
>>> >>>>> > > > >
>>> >>>>> > > > > Jesse when you feel you've got everything in there go ahead
>>> >>>>>and
>>> >>>>>tag
>>> >>>>> > JS
>>> >>>>> > > > >
>>> >>>>> > > > > On 4/12/12 4:20 PM, "Shazron" <sh...@gmail.com> wrote:
>>> >>>>> > > > >
>>> >>>>> > > > > >Reverted. Just talked to Jesse - he has commits to
>>> cordova-js
>>> >>>>> > coming,
>>> >>>>> > > > > >once those are in we can re-tag cordova-js to 1.6.1
>>> >>>>> > > > > >
>>> >>>>> > > > > >On Thu, Apr 12, 2012 at 4:12 PM, Shazron <shazron@gmail.com
>>> >
>>> >>>>> wrote:
>>> >>>>> > > > > >> I'll remove it. *grabs the shovel*
>>> >>>>> > > > > >>
>>> >>>>> > > > > >> On Thu, Apr 12, 2012 at 4:10 PM, Joe Bowser
>>> >>>>><bo...@gmail.com>
>>> >>>>> > > > wrote:
>>> >>>>> > > > > >>> You know, let's not rebase it, because it does modify the
>>> >>>>> > history.
>>> >>>>> > > > We
>>> >>>>> > > > > >>> should remove and document why we did it instead, since
>>> >>>>>that
>>> >>>>> > would
>>> >>>>> > > be
>>> >>>>> > > > > >>>more
>>> >>>>> > > > > >>> transparent. Or we could just leave it in and say "don't
>>> >>>>>do
>>> >>>>> this
>>> >>>>> > > next
>>> >>>>> > > > > >>> time". I'm not that invested in it.
>>> >>>>> > > > > >>>
>>> >>>>> > > > > >>> On Thu, Apr 12, 2012 at 4:04 PM, Shazron
>>> >>>>><sh...@gmail.com>
>>> >>>>> > > wrote:
>>> >>>>> > > > > >>>
>>> >>>>> > > > > >>>> If we take out that iOS commit in cordova-js (somehow),
>>> >>>>>it
>>> >>>>> > should
>>> >>>>> > > be
>>> >>>>> > > > > >>>> fine. cordova-ios 1.6.1 will then just be the same as
>>> >>>>>1.6.0.
>>> >>>>> > > > > >>>>
>>> >>>>> > > > > >>>> On Thu, Apr 12, 2012 at 4:02 PM, Filip Maj
>>> >>>>><fi...@adobe.com>
>>> >>>>> > wrote:
>>> >>>>> > > > > >>>> >
>>> >>>>> > > > > >>>> >>Is it too much to drop the new commit that changed the
>>> >>>>> common
>>> >>>>> > js
>>> >>>>> > > > > >>>>API, and
>>> >>>>> > > > > >>>> >>reapply it after we tag 1.6.1, and figure this one
>>> >>>>>thing
>>> >>>>>out
>>> >>>>> > for
>>> >>>>> > > > > >>>>1.7?
>>> >>>>> > > > > >>>> >
>>> >>>>> > > > > >>>> > That sounds very good to me but I am under the
>>> >>>>>impression
>>> >>>>> that
>>> >>>>> > > iOS
>>> >>>>> > > > > >>>> > requires this commit? Like I said I'm quite confused.
>>> >>>>> > > > > >>>> >
>>> >>>>> > > > > >>>> >>
>>> >>>>> > > > > >>>> >>I also have some cordova-js commits to add to 1.6.1?
>>> >>>>> Although
>>> >>>>> > > > > >>>>nothing
>>> >>>>> > > > > >>>> that
>>> >>>>> > > > > >>>> >>modifies any js outside of what is built for wp7. (
>>> ie,
>>> >>>>>all
>>> >>>>> in
>>> >>>>> > > my
>>> >>>>> > > > > >>>> platform
>>> >>>>> > > > > >>>> >>specific plugins folder )
>>> >>>>> > > > > >>>> >>
>>> >>>>> > > > > >>>> >
>>> >>>>> > > > > >>>> > O then it sounds like I tagged the JS 1.6.1 too early
>>> >>>>> > anyways..
>>> >>>>> > > > > >>>> >
>>> >>>>> > > > > >>>> >>
>>> >>>>> > > > > >>>> >>
>>> >>>>> > > > > >>>> >>
>>> >>>>> > > > > >>>> >>On Thu, Apr 12, 2012 at 3:51 PM, Shazron
>>> >>>>><shazron@gmail.com
>>> >>>>> >
>>> >>>>> > > > wrote:
>>> >>>>> > > > > >>>> >>
>>> >>>>> > > > > >>>> >>> No - it's about a user's contribution being noted
>>> (it
>>> >>>>> > > exists), I
>>> >>>>> > > > > >>>>will
>>> >>>>> > > > > >>>> >>> move it out of the common code post-1.6.1 (I
>>> >>>>>acknowledge
>>> >>>>> my
>>> >>>>> > > > > >>>>mistake in
>>> >>>>> > > > > >>>> >>> allowing it in the first place). Can we branch off
>>> >>>>>1.6.0
>>> >>>>> > then
>>> >>>>> > > > > >>>> >>> cherry-pick Fil's latest fix for 1.6.1?
>>> >>>>> > > > > >>>> >>>
>>> >>>>> > > > > >>>> >>> On Thu, Apr 12, 2012 at 3:47 PM, Joe Bowser <
>>> >>>>> > > bowserj@gmail.com>
>>> >>>>> > > > > >>>>wrote:
>>> >>>>> > > > > >>>> >>> > OK, so you're proposing that we leave the thing in
>>> >>>>>the
>>> >>>>> > > common
>>> >>>>> > > > > >>>>JS,
>>> >>>>> > > > > >>>> even
>>> >>>>> > > > > >>>> >>> > though it's not supposed to be there.
>>> >>>>> > > > > >>>> >>> >
>>> >>>>> > > > > >>>> >>> > On Thu, Apr 12, 2012 at 3:45 PM, Shazron <
>>> >>>>> > shazron@gmail.com
>>> >>>>> > > >
>>> >>>>> > > > > >>>>wrote:
>>> >>>>> > > > > >>>> >>> >
>>> >>>>> > > > > >>>> >>> >> Will rebasing lose that commit? Then, no.
>>> >>>>> > > > > >>>> >>> >>
>>> >>>>> > > > > >>>> >>> >> On Thu, Apr 12, 2012 at 3:43 PM, Joe Bowser <
>>> >>>>> > > > bowserj@gmail.com
>>> >>>>> > > > > >
>>> >>>>> > > > > >>>> >>>wrote:
>>> >>>>> > > > > >>>> >>> >> > So, can we just rebase the head, push this out
>>> >>>>>and
>>> >>>>> get
>>> >>>>> > > this
>>> >>>>> > > > > >>>> >>>rolling?
>>> >>>>> > > > > >>>> >>> >> >
>>> >>>>> > > > > >>>> >>> >> > On Thu, Apr 12, 2012 at 3:43 PM, Filip Maj <
>>> >>>>> > > fil@adobe.com>
>>> >>>>> > > > > >>>>wrote:
>>> >>>>> > > > > >>>> >>> >> >
>>> >>>>> > > > > >>>> >>> >> >> Correct, those iOS-specific parameters (like
>>> >>>>>allow
>>> >>>>> > edit
>>> >>>>> > > > and
>>> >>>>> > > > > >>>>those
>>> >>>>> > > > > >>>> >>> ones)
>>> >>>>> > > > > >>>> >>> >> >> existed prior to cordova-js, so yeah, we left
>>> >>>>>them
>>> >>>>> in
>>> >>>>> > > > there
>>> >>>>> > > > > >>>>as we
>>> >>>>> > > > > >>>> >>> didn't
>>> >>>>> > > > > >>>> >>> >> >> want to remove without deprecation.
>>> >>>>> > > > > >>>> >>> >> >>
>>> >>>>> > > > > >>>> >>> >> >> If you can deal with the iOS issue without
>>> >>>>>needing
>>> >>>>> an
>>> >>>>> > > API
>>> >>>>> > > > > >>>> >>>extension:
>>> >>>>> > > > > >>>> >>> >> then
>>> >>>>> > > > > >>>> >>> >> >> do that. If not, leave it in there, but docs
>>> >>>>>need to
>>> >>>>> > > > > >>>>updated too.
>>> >>>>> > > > > >>>> >>> >> >>
>>> >>>>> > > > > >>>> >>> >> >> Extending and changing the public API is a
>>> long
>>> >>>>>and
>>> >>>>> > > > > >>>>difficult
>>> >>>>> > > > > >>>> >>>process
>>> >>>>> > > > > >>>> >>> >> for
>>> >>>>> > > > > >>>> >>> >> >> us and will only get tougher with every
>>> >>>>>platform
>>> >>>>>we
>>> >>>>> > add
>>> >>>>> > > > > >>>>support
>>> >>>>> > > > > >>>> >>>to.
>>> >>>>> > > > > >>>> >>> >> >>
>>> >>>>> > > > > >>>> >>> >> >> On 4/12/12 3:37 PM, "Shazron"
>>> >>>>><sh...@gmail.com>
>>> >>>>> > > wrote:
>>> >>>>> > > > > >>>> >>> >> >>
>>> >>>>> > > > > >>>> >>> >> >> >Then we have to scrap the other three(?) iOS
>>> >>>>> > parameters
>>> >>>>> > > > > >>>>ones
>>> >>>>> > > > > >>>> that
>>> >>>>> > > > > >>>> >>> >> >> >already exist in common if you noticed. Don't
>>> >>>>>know
>>> >>>>> > how
>>> >>>>> > > we
>>> >>>>> > > > > >>>>merge
>>> >>>>> > > > > >>>> >>> >> >> >(unmerge?) this one properly because taking
>>> >>>>>those
>>> >>>>> out
>>> >>>>> > > > will
>>> >>>>> > > > > >>>>break
>>> >>>>> > > > > >>>> >>> >> >> >everyone that is using it, but a deprecation
>>> >>>>>is
>>> >>>>>the
>>> >>>>> > way
>>> >>>>> > > > to
>>> >>>>> > > > > >>>>go as
>>> >>>>> > > > > >>>> >>>per
>>> >>>>> > > > > >>>> >>> >> >>
>>> >>>>>>http://wiki.apache.org/cordova/DeprecationPolicy .
>>> >>>>> > We
>>> >>>>> > > > can
>>> >>>>> > > > > >>>> remove
>>> >>>>> > > > > >>>> >>> this
>>> >>>>> > > > > >>>> >>> >> >> >new commit and I'll find a way to get this in
>>> >>>>> > somehow.
>>> >>>>> > > > > >>>> >>> >> >> >
>>> >>>>> > > > > >>>> >>> >> >> >
>>> >>>>> > > > > >>>> >>> >> >> >
>>> >>>>> > > > > >>>> >>> >> >> >On Thu, Apr 12, 2012 at 3:32 PM, Joe Bowser
>>> >>>>> > > > > >>>><bo...@gmail.com>
>>> >>>>> > > > > >>>> >>> wrote:
>>> >>>>> > > > > >>>> >>> >> >> >> The problem is that this parameter doesn't
>>> >>>>>belong
>>> >>>>> > in
>>> >>>>> > > > the
>>> >>>>> > > > > >>>> common
>>> >>>>> > > > > >>>> >>> API.
>>> >>>>> > > > > >>>> >>> >> >> >>It'd
>>> >>>>> > > > > >>>> >>> >> >> >> be just ignored in Android, but the whole
>>> >>>>>point
>>> >>>>> of
>>> >>>>> > > > > >>>>cordova-js
>>> >>>>> > > > > >>>> >>>is
>>> >>>>> > > > > >>>> >>> so
>>> >>>>> > > > > >>>> >>> >> that
>>> >>>>> > > > > >>>> >>> >> >> >> it's common. It'd look pretty screwed up
>>> to
>>> >>>>>add
>>> >>>>> > this
>>> >>>>> > > > to
>>> >>>>> > > > > >>>>the
>>> >>>>> > > > > >>>> >>>docs,
>>> >>>>> > > > > >>>> >>> >> IMO.
>>> >>>>> > > > > >>>> >>> >> >> >>
>>> >>>>> > > > > >>>> >>> >> >> >> On Thu, Apr 12, 2012 at 3:26 PM, Shazron
>>> >>>>> > > > > >>>><sh...@gmail.com>
>>> >>>>> > > > > >>>> >>> wrote:
>>> >>>>> > > > > >>>> >>> >> >> >>
>>> >>>>> > > > > >>>> >>> >> >> >>> To fix two bugs for Camera.takePicture on
>>> >>>>>iOS
>>> >>>>> > > > > >>>> >>> >> >> >>>
>>> >>>>> > > > > >>>> >>> >> >> >>> On Thu, Apr 12, 2012 at 3:24 PM, Filip Maj
>>> >>>>> > > > > >>>><fi...@adobe.com>
>>> >>>>> > > > > >>>> >>> wrote:
>>> >>>>> > > > > >>>> >>> >> >> >>> > so what's the point of this new
>>> >>>>>parameter?
>>> >>>>> > > > > >>>> >>> >> >> >>> >
>>> >>>>> > > > > >>>> >>> >> >> >>> > On 4/12/12 3:16 PM, "Shazron" <
>>> >>>>> > shazron@gmail.com>
>>> >>>>> > > > > >>>>wrote:
>>> >>>>> > > > > >>>> >>> >> >> >>> >
>>> >>>>> > > > > >>>> >>> >> >> >>> >>I did. Do we want to revert the
>>> >>>>>cordova-js? I
>>> >>>>> > can
>>> >>>>> > > > > >>>>branch
>>> >>>>> > > > > >>>> >>>1.6.0
>>> >>>>> > > > > >>>> >>> and
>>> >>>>> > > > > >>>> >>> >> >> >>> >>cherry-pick your latest commit for 1.6.1
>>> >>>>> > > > > >>>> >>> >> >> >>> >>
>>> >>>>> > > > > >>>> >>> >> >> >>> >>On Thu, Apr 12, 2012 at 3:04 PM, Filip
>>> >>>>>Maj
>>> >>>>> > > > > >>>><fi...@adobe.com>
>>> >>>>> > > > > >>>> >>> wrote:
>>> >>>>> > > > > >>>> >>> >> >> >>> >>> I saw something in the iOS commit logs
>>> >>>>>for
>>> >>>>> > this.
>>> >>>>> > > > > >>>> >>> >> >> >>> >>>
>>> >>>>> > > > > >>>> >>> >> >> >>> >>> Shaz can you comment?
>>> >>>>> > > > > >>>> >>> >> >> >>> >>>
>>> >>>>> > > > > >>>> >>> >> >> >>> >>> On 4/12/12 2:59 PM, "Joe Bowser" <
>>> >>>>> > > > bowserj@gmail.com
>>> >>>>> > > > > >
>>> >>>>> > > > > >>>> >>>wrote:
>>> >>>>> > > > > >>>> >>> >> >> >>> >>>
>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>Can we revert this, since this looks
>>> >>>>>like
>>> >>>>> it's
>>> >>>>> > > > > >>>>intended
>>> >>>>> > > > > >>>> >>>for
>>> >>>>> > > > > >>>> >>> both
>>> >>>>> > > > > >>>> >>> >> >> >>> Android
>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>and iOS, but I don't think it should
>>> be
>>> >>>>>in
>>> >>>>> > > 1.6.1.
>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>
>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>On Thu, Apr 12, 2012 at 2:52 PM, Filip
>>> >>>>>Maj <
>>> >>>>> > > > > >>>> fil@adobe.com>
>>> >>>>> > > > > >>>> >>> >> wrote:
>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>
>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> I was actually just looking at that
>>> >>>>> myself.
>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>>
>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> Looks like it's an iOS-only param..
>>> >>>>>sigh.
>>> >>>>> > We
>>> >>>>> > > > > >>>>gotta
>>> >>>>> > > > > >>>> stop
>>> >>>>> > > > > >>>> >>> doing
>>> >>>>> > > > > >>>> >>> >> >> >>>that,
>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> especially if we don't update
>>> >>>>> documentation.
>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>>
>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> On 4/12/12 2:49 PM, "Joe Bowser"
>>> >>>>> > > > > >>>><bo...@gmail.com>
>>> >>>>> > > > > >>>> >>> wrote:
>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>>
>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >Has anyone tested the cropToSize
>>> >>>>>param
>>> >>>>> for
>>> >>>>> > > > > >>>> >>> Camera.getPicture
>>> >>>>> > > > > >>>> >>> >> >> >>>yet? I
>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >didn't
>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >notice that change until now.
>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >
>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >On Thu, Apr 12, 2012 at 2:46 PM,
>>> >>>>>Filip
>>> >>>>> Maj
>>> >>>>> > > > > >>>> >>><fil@adobe.com
>>> >>>>> > > > > >>>> >>> >
>>> >>>>> > > > > >>>> >>> >> >> >>>wrote:
>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >
>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> JS tagged 1.6.1 - the build task
>>> >>>>>in
>>> >>>>>the
>>> >>>>> > JS
>>> >>>>> > > > > >>>>should
>>> >>>>> > > > > >>>> >>>work
>>> >>>>> > > > > >>>> >>> >> >> >>>properly
>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>>now.
>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >>
>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> FYI if anyone has to modify the
>>> >>>>>jake
>>> >>>>> > tasks
>>> >>>>> > > in
>>> >>>>> > > > > >>>>the
>>> >>>>> > > > > >>>> >>>future
>>> >>>>> > > > > >>>> >>> >> and
>>> >>>>> > > > > >>>> >>> >> >> >>>make
>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>>them
>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> async, make sure you add the 4th
>>> >>>>> "async"
>>> >>>>> > > > > >>>>parameter
>>> >>>>> > > > > >>>> to
>>> >>>>> > > > > >>>> >>> the
>>> >>>>> > > > > >>>> >>> >> >> >>>task()
>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >>function
>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> and set it to true, and call
>>> >>>>>complete()
>>> >>>>> > > when
>>> >>>>> > > > > >>>>the
>>> >>>>> > > > > >>>> >>>task is
>>> >>>>> > > > > >>>> >>> >> done.
>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >>
>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> See
>>> >>>>> > > > > >>>> >>>
>>> >>>>>http://howtonode.org/intro-to-jake/async-jakefile.jsfor
>>> >>>>> > > > > >>>> >>> >> >> >>>an
>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> example.
>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >>
>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> On 4/12/12 2:35 PM, "Joe Bowser"
>>> >>>>> > > > > >>>><bowserj@gmail.com
>>> >>>>> > > > > >>>> >
>>> >>>>> > > > > >>>> >>> >> wrote:
>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >>
>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >Ready to tag once cordova-js is
>>> >>>>>tagged
>>> >>>>> > > > 1.6.1.
>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >
>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >On Thu, Apr 12, 2012 at 2:33 PM,
>>> >>>>>Anis
>>> >>>>> > > KADRI
>>> >>>>> > > > <
>>> >>>>> > > > > >>>> >>> >> >> >>> anis.kadri@gmail.com>
>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >>wrote:
>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >
>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> I will tag my repository to
>>> >>>>>1.6.1
>>> >>>>> > before
>>> >>>>> > > > > >>>>end of
>>> >>>>> > > > > >>>> >>>day
>>> >>>>> > > > > >>>> >>> >> today
>>> >>>>> > > > > >>>> >>> >> >> >>>after
>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>>some
>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> thorough testing.
>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >>
>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> On Thu, Apr 12, 2012 at 2:30
>>> >>>>>PM,
>>> >>>>> > Shazron
>>> >>>>> > > > > >>>> >>> >> >> >>><sh...@gmail.com>
>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>>wrote:
>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >>
>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > I also created a 1.6.1
>>> >>>>>version
>>> >>>>>tag
>>> >>>>> > as
>>> >>>>> > > > > >>>>well in
>>> >>>>> > > > > >>>> >>> jira...
>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> >
>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > On Thu, Apr 12, 2012 at 2:29
>>> >>>>>PM,
>>> >>>>> > > Shazron
>>> >>>>> > > > > >>>> >>> >> >> >>><sh...@gmail.com>
>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> wrote:
>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > > Alright guys since 1.6.0
>>> >>>>>was
>>> >>>>> > > released,
>>> >>>>> > > > > >>>>I'm
>>> >>>>> > > > > >>>> >>>going
>>> >>>>> > > > > >>>> >>> to
>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>>"Release"
>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>>the
>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > > 1.6.0 version in jira and
>>> >>>>>move
>>> >>>>> > > > > >>>>outstanding
>>> >>>>> > > > > >>>> >>> issues to
>>> >>>>> > > > > >>>> >>> >> >> >>>1.7.0
>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >>version
>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > > tag.
>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >
>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >
>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > > On Thu, Apr 12, 2012 at
>>> >>>>>2:26
>>> >>>>>PM,
>>> >>>>> > > Filip
>>> >>>>> > > > > >>>>Maj
>>> >>>>> > > > > >>>> >>> >> >> >>><fi...@adobe.com>
>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> wrote:
>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >> The JS needs patching
>>> too.
>>> >>>>> Since
>>> >>>>> > > > > >>>>adding the
>>> >>>>> > > > > >>>> >>> commit
>>> >>>>> > > > > >>>> >>> >> ID
>>> >>>>> > > > > >>>> >>> >> >> >>>into
>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>>the
>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> packaging
>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >> in the jakefile, the
>>> >>>>>default
>>> >>>>> task
>>> >>>>> > > > isn't
>>> >>>>> > > > > >>>> >>>running
>>> >>>>> > > > > >>>> >>> >> >> >>>properly.
>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>
>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >> You can manually run
>>> "jake
>>> >>>>> build"
>>> >>>>> > > and
>>> >>>>> > > > > >>>>"jake
>>> >>>>> > > > > >>>> >>> test"
>>> >>>>> > > > > >>>> >>> >> but
>>> >>>>> > > > > >>>> >>> >> >> >>>not
>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >>"jake" on
>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> its
>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >> own - gonna try to figure
>>> >>>>>it
>>> >>>>> out.
>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>
>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >> On 4/12/12 2:21 PM,
>>> >>>>>"Shazron" <
>>> >>>>> > > > > >>>> >>> shazron@gmail.com>
>>> >>>>> > > > > >>>> >>> >> >> >>>wrote:
>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>
>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>I'm good with tagging.
>>> >>>>>iOS
>>> >>>>> has a
>>> >>>>> > > few
>>> >>>>> > > > > >>>> commits
>>> >>>>> > > > > >>>> >>> (one
>>> >>>>> > > > > >>>> >>> >> >> >>>commit
>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>>in
>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>cordova-js) as well. Aim
>>> >>>>>for
>>> >>>>> > first
>>> >>>>> > > > > >>>>thing
>>> >>>>> > > > > >>>> >>> tomorrow
>>> >>>>> > > > > >>>> >>> >> for
>>> >>>>> > > > > >>>> >>> >> >> >>>you
>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>>to
>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>repackage?
>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>
>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>On Thu, Apr 12, 2012 at
>>> >>>>>2:17
>>> >>>>> PM,
>>> >>>>> > > > > >>>>Steven Gill
>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >><st...@gmail.com>
>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>wrote:
>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>> So a bug has been
>>> >>>>>discovered
>>> >>>>> in
>>> >>>>> > > > > >>>>Cordova
>>> >>>>> > > > > >>>> >>> Android
>>> >>>>> > > > > >>>> >>> >> that
>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>>requires
>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >>a
>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >>new
>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > tag
>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>>and
>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>> release. You can check
>>> >>>>>out
>>> >>>>> the
>>> >>>>> > > bug
>>> >>>>> > > > > >>>>on the
>>> >>>>> > > > > >>>> >>> issue
>>> >>>>> > > > > >>>> >>> >> >> >>>tracker
>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>>at
>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>>
>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>>
>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> >
>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >>
>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >>
>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >>
>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >>
>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>>
>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>>
>>> >>>>> > > > > >>>> >>> >> >> >>>
>>> >>>>> > > > > >>>> >>> >> >>
>>> >>>>> > > > > >>>> >>>
>>> >>>>> > > > > >>>>
>>> >>>>> > > > > >>>>
>>> >>>>> > > > >
>>> >>>>> > >
>>> >>>>>
>>> >>>>>
>>> https://issues.apache.org/jira/browse/CB-490?focusedCommentId=13252809#
>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>>co
>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>>mment-13252809
>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>>
>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>> It doesn't make sense
>>> to
>>> >>>>>just
>>> >>>>> > > > > >>>>repackage
>>> >>>>> > > > > >>>> >>>1.6.0
>>> >>>>> > > > > >>>> >>> >> with
>>> >>>>> > > > > >>>> >>> >> >> >>>this
>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>>bug
>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >>fixed as
>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > we
>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>> will have no way to
>>> know
>>> >>>>>if
>>> >>>>> > > people
>>> >>>>> > > > > >>>>are
>>> >>>>> > > > > >>>> >>> >> experiencing
>>> >>>>> > > > > >>>> >>> >> >> >>>this
>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>>or
>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >>not.
>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>>
>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>> Anis mentioned Bada
>>> also
>>> >>>>>had
>>> >>>>> > some
>>> >>>>> > > > > >>>>major
>>> >>>>> > > > > >>>> >>>issues
>>> >>>>> > > > > >>>> >>> >> >> >>>which he
>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>>has
>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >>fixed
>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> now
>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>>and
>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>> would like in a 1.6.1
>>> >>>>> release.
>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>>
>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>> Thoughts?
>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>>
>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>> -Steve
>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>
>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> >
>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >>
>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >>
>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >>
>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>>
>>> >>>>> > > > > >>>> >>> >> >> >>> >>>>>
>>> >>>>> > > > > >>>> >>> >> >> >>> >>>
>>> >>>>> > > > > >>>> >>> >> >> >>> >
>>> >>>>> > > > > >>>> >>> >> >> >>>
>>> >>>>> > > > > >>>> >>> >> >>
>>> >>>>> > > > > >>>> >>> >> >>
>>> >>>>> > > > > >>>> >>> >>
>>> >>>>> > > > > >>>> >>>
>>> >>>>> > > > > >>>> >
>>> >>>>> > > > > >>>>
>>> >>>>> > > > >
>>> >>>>> > > > >
>>> >>>>> > > >
>>> >>>>> > >
>>> >>>>> >
>>> >>>>>
>>> >>>
>>> >
>>>
Re: 1.6.1
Posted by Shazron <sh...@gmail.com>.
Users are discovering more bugs:
https://issues.apache.org/jira/browse/CB-497
https://github.com/apache/incubator-cordova-ios/blob/master/CordovaLib/Classes/CDVConnection.m#L103
So I'm going to have to review, fix and re-tag, so wait up.
On Thu, Apr 12, 2012 at 5:38 PM, Jesse <pu...@gmail.com> wrote:
> I am commited and tagged
>
> On Thu, Apr 12, 2012 at 5:27 PM, Shazron <sh...@gmail.com> wrote:
>
>> Logic error - no worries, I patched it (going to re-do 1.6.1 iOS)
>>
>> On Thu, Apr 12, 2012 at 5:27 PM, Filip Maj <fi...@adobe.com> wrote:
>> > Did I f that up?
>> >
>> > On 4/12/12 5:07 PM, "Shazron" <sh...@gmail.com> wrote:
>> >
>> >>Sigh - user reported iOS bug
>> >>
>> http://groups.google.com/group/phonegap/browse_thread/thread/faad0af97dec8
>> >>907
>> >>(you know who you are ;)
>> >>
>> >>On Thu, Apr 12, 2012 at 5:05 PM, Filip Maj <fi...@adobe.com> wrote:
>> >>> Saweet! Nice work Anis. That kills off a bunch of old issues in JIRA
>> >>>too.
>> >>>
>> >>> Way to hunker down all. As Jesse pointed out to me, we did 45 emails in
>> >>> two hours haha
>> >>>
>> >>> On 4/12/12 5:00 PM, "Anis KADRI" <an...@gmail.com> wrote:
>> >>>
>> >>>>Bada 1.2 is tagged 1.6.1. I added the new Cordova artwork,
>> >>>>LICENSE/NOTICE
>> >>>>files as well as the Apache source headers in every source file. I
>> fixed
>> >>>>all the bugs I sawS
>> >>>>
>> >>>>On Thu, Apr 12, 2012 at 4:38 PM, Joe Bowser <bo...@gmail.com> wrote:
>> >>>>
>> >>>>> Android is tagged.
>> >>>>>
>> >>>>> On Thu, Apr 12, 2012 at 4:36 PM, Jesse <pu...@gmail.com>
>> >>>>>wrote:
>> >>>>>
>> >>>>> > Done
>> >>>>> >
>> >>>>> > On Thu, Apr 12, 2012 at 4:31 PM, Joe Bowser <bo...@gmail.com>
>> >>>>>wrote:
>> >>>>> >
>> >>>>> > > I'd like to get the JS from the tag, but I need a tag for that.
>> >>>>> > >
>> >>>>> > > On Thu, Apr 12, 2012 at 4:29 PM, Jesse <pu...@gmail.com>
>> >>>>> wrote:
>> >>>>> > >
>> >>>>> > > > Okay, I think it's good, tagging at 16:32 PDT if i don't hear
>> >>>>>any
>> >>>>> > > > complaints.
>> >>>>> > > >
>> >>>>> > > > On Thu, Apr 12, 2012 at 4:26 PM, Filip Maj <fi...@adobe.com>
>> >>>>>wrote:
>> >>>>> > > >
>> >>>>> > > > > I just axed the existing 1.6.1 cordova-js tag
>> >>>>> > > > >
>> >>>>> > > > > Jesse when you feel you've got everything in there go ahead
>> >>>>>and
>> >>>>>tag
>> >>>>> > JS
>> >>>>> > > > >
>> >>>>> > > > > On 4/12/12 4:20 PM, "Shazron" <sh...@gmail.com> wrote:
>> >>>>> > > > >
>> >>>>> > > > > >Reverted. Just talked to Jesse - he has commits to
>> cordova-js
>> >>>>> > coming,
>> >>>>> > > > > >once those are in we can re-tag cordova-js to 1.6.1
>> >>>>> > > > > >
>> >>>>> > > > > >On Thu, Apr 12, 2012 at 4:12 PM, Shazron <shazron@gmail.com
>> >
>> >>>>> wrote:
>> >>>>> > > > > >> I'll remove it. *grabs the shovel*
>> >>>>> > > > > >>
>> >>>>> > > > > >> On Thu, Apr 12, 2012 at 4:10 PM, Joe Bowser
>> >>>>><bo...@gmail.com>
>> >>>>> > > > wrote:
>> >>>>> > > > > >>> You know, let's not rebase it, because it does modify the
>> >>>>> > history.
>> >>>>> > > > We
>> >>>>> > > > > >>> should remove and document why we did it instead, since
>> >>>>>that
>> >>>>> > would
>> >>>>> > > be
>> >>>>> > > > > >>>more
>> >>>>> > > > > >>> transparent. Or we could just leave it in and say "don't
>> >>>>>do
>> >>>>> this
>> >>>>> > > next
>> >>>>> > > > > >>> time". I'm not that invested in it.
>> >>>>> > > > > >>>
>> >>>>> > > > > >>> On Thu, Apr 12, 2012 at 4:04 PM, Shazron
>> >>>>><sh...@gmail.com>
>> >>>>> > > wrote:
>> >>>>> > > > > >>>
>> >>>>> > > > > >>>> If we take out that iOS commit in cordova-js (somehow),
>> >>>>>it
>> >>>>> > should
>> >>>>> > > be
>> >>>>> > > > > >>>> fine. cordova-ios 1.6.1 will then just be the same as
>> >>>>>1.6.0.
>> >>>>> > > > > >>>>
>> >>>>> > > > > >>>> On Thu, Apr 12, 2012 at 4:02 PM, Filip Maj
>> >>>>><fi...@adobe.com>
>> >>>>> > wrote:
>> >>>>> > > > > >>>> >
>> >>>>> > > > > >>>> >>Is it too much to drop the new commit that changed the
>> >>>>> common
>> >>>>> > js
>> >>>>> > > > > >>>>API, and
>> >>>>> > > > > >>>> >>reapply it after we tag 1.6.1, and figure this one
>> >>>>>thing
>> >>>>>out
>> >>>>> > for
>> >>>>> > > > > >>>>1.7?
>> >>>>> > > > > >>>> >
>> >>>>> > > > > >>>> > That sounds very good to me but I am under the
>> >>>>>impression
>> >>>>> that
>> >>>>> > > iOS
>> >>>>> > > > > >>>> > requires this commit? Like I said I'm quite confused.
>> >>>>> > > > > >>>> >
>> >>>>> > > > > >>>> >>
>> >>>>> > > > > >>>> >>I also have some cordova-js commits to add to 1.6.1?
>> >>>>> Although
>> >>>>> > > > > >>>>nothing
>> >>>>> > > > > >>>> that
>> >>>>> > > > > >>>> >>modifies any js outside of what is built for wp7. (
>> ie,
>> >>>>>all
>> >>>>> in
>> >>>>> > > my
>> >>>>> > > > > >>>> platform
>> >>>>> > > > > >>>> >>specific plugins folder )
>> >>>>> > > > > >>>> >>
>> >>>>> > > > > >>>> >
>> >>>>> > > > > >>>> > O then it sounds like I tagged the JS 1.6.1 too early
>> >>>>> > anyways..
>> >>>>> > > > > >>>> >
>> >>>>> > > > > >>>> >>
>> >>>>> > > > > >>>> >>
>> >>>>> > > > > >>>> >>
>> >>>>> > > > > >>>> >>On Thu, Apr 12, 2012 at 3:51 PM, Shazron
>> >>>>><shazron@gmail.com
>> >>>>> >
>> >>>>> > > > wrote:
>> >>>>> > > > > >>>> >>
>> >>>>> > > > > >>>> >>> No - it's about a user's contribution being noted
>> (it
>> >>>>> > > exists), I
>> >>>>> > > > > >>>>will
>> >>>>> > > > > >>>> >>> move it out of the common code post-1.6.1 (I
>> >>>>>acknowledge
>> >>>>> my
>> >>>>> > > > > >>>>mistake in
>> >>>>> > > > > >>>> >>> allowing it in the first place). Can we branch off
>> >>>>>1.6.0
>> >>>>> > then
>> >>>>> > > > > >>>> >>> cherry-pick Fil's latest fix for 1.6.1?
>> >>>>> > > > > >>>> >>>
>> >>>>> > > > > >>>> >>> On Thu, Apr 12, 2012 at 3:47 PM, Joe Bowser <
>> >>>>> > > bowserj@gmail.com>
>> >>>>> > > > > >>>>wrote:
>> >>>>> > > > > >>>> >>> > OK, so you're proposing that we leave the thing in
>> >>>>>the
>> >>>>> > > common
>> >>>>> > > > > >>>>JS,
>> >>>>> > > > > >>>> even
>> >>>>> > > > > >>>> >>> > though it's not supposed to be there.
>> >>>>> > > > > >>>> >>> >
>> >>>>> > > > > >>>> >>> > On Thu, Apr 12, 2012 at 3:45 PM, Shazron <
>> >>>>> > shazron@gmail.com
>> >>>>> > > >
>> >>>>> > > > > >>>>wrote:
>> >>>>> > > > > >>>> >>> >
>> >>>>> > > > > >>>> >>> >> Will rebasing lose that commit? Then, no.
>> >>>>> > > > > >>>> >>> >>
>> >>>>> > > > > >>>> >>> >> On Thu, Apr 12, 2012 at 3:43 PM, Joe Bowser <
>> >>>>> > > > bowserj@gmail.com
>> >>>>> > > > > >
>> >>>>> > > > > >>>> >>>wrote:
>> >>>>> > > > > >>>> >>> >> > So, can we just rebase the head, push this out
>> >>>>>and
>> >>>>> get
>> >>>>> > > this
>> >>>>> > > > > >>>> >>>rolling?
>> >>>>> > > > > >>>> >>> >> >
>> >>>>> > > > > >>>> >>> >> > On Thu, Apr 12, 2012 at 3:43 PM, Filip Maj <
>> >>>>> > > fil@adobe.com>
>> >>>>> > > > > >>>>wrote:
>> >>>>> > > > > >>>> >>> >> >
>> >>>>> > > > > >>>> >>> >> >> Correct, those iOS-specific parameters (like
>> >>>>>allow
>> >>>>> > edit
>> >>>>> > > > and
>> >>>>> > > > > >>>>those
>> >>>>> > > > > >>>> >>> ones)
>> >>>>> > > > > >>>> >>> >> >> existed prior to cordova-js, so yeah, we left
>> >>>>>them
>> >>>>> in
>> >>>>> > > > there
>> >>>>> > > > > >>>>as we
>> >>>>> > > > > >>>> >>> didn't
>> >>>>> > > > > >>>> >>> >> >> want to remove without deprecation.
>> >>>>> > > > > >>>> >>> >> >>
>> >>>>> > > > > >>>> >>> >> >> If you can deal with the iOS issue without
>> >>>>>needing
>> >>>>> an
>> >>>>> > > API
>> >>>>> > > > > >>>> >>>extension:
>> >>>>> > > > > >>>> >>> >> then
>> >>>>> > > > > >>>> >>> >> >> do that. If not, leave it in there, but docs
>> >>>>>need to
>> >>>>> > > > > >>>>updated too.
>> >>>>> > > > > >>>> >>> >> >>
>> >>>>> > > > > >>>> >>> >> >> Extending and changing the public API is a
>> long
>> >>>>>and
>> >>>>> > > > > >>>>difficult
>> >>>>> > > > > >>>> >>>process
>> >>>>> > > > > >>>> >>> >> for
>> >>>>> > > > > >>>> >>> >> >> us and will only get tougher with every
>> >>>>>platform
>> >>>>>we
>> >>>>> > add
>> >>>>> > > > > >>>>support
>> >>>>> > > > > >>>> >>>to.
>> >>>>> > > > > >>>> >>> >> >>
>> >>>>> > > > > >>>> >>> >> >> On 4/12/12 3:37 PM, "Shazron"
>> >>>>><sh...@gmail.com>
>> >>>>> > > wrote:
>> >>>>> > > > > >>>> >>> >> >>
>> >>>>> > > > > >>>> >>> >> >> >Then we have to scrap the other three(?) iOS
>> >>>>> > parameters
>> >>>>> > > > > >>>>ones
>> >>>>> > > > > >>>> that
>> >>>>> > > > > >>>> >>> >> >> >already exist in common if you noticed. Don't
>> >>>>>know
>> >>>>> > how
>> >>>>> > > we
>> >>>>> > > > > >>>>merge
>> >>>>> > > > > >>>> >>> >> >> >(unmerge?) this one properly because taking
>> >>>>>those
>> >>>>> out
>> >>>>> > > > will
>> >>>>> > > > > >>>>break
>> >>>>> > > > > >>>> >>> >> >> >everyone that is using it, but a deprecation
>> >>>>>is
>> >>>>>the
>> >>>>> > way
>> >>>>> > > > to
>> >>>>> > > > > >>>>go as
>> >>>>> > > > > >>>> >>>per
>> >>>>> > > > > >>>> >>> >> >>
>> >>>>>>http://wiki.apache.org/cordova/DeprecationPolicy .
>> >>>>> > We
>> >>>>> > > > can
>> >>>>> > > > > >>>> remove
>> >>>>> > > > > >>>> >>> this
>> >>>>> > > > > >>>> >>> >> >> >new commit and I'll find a way to get this in
>> >>>>> > somehow.
>> >>>>> > > > > >>>> >>> >> >> >
>> >>>>> > > > > >>>> >>> >> >> >
>> >>>>> > > > > >>>> >>> >> >> >
>> >>>>> > > > > >>>> >>> >> >> >On Thu, Apr 12, 2012 at 3:32 PM, Joe Bowser
>> >>>>> > > > > >>>><bo...@gmail.com>
>> >>>>> > > > > >>>> >>> wrote:
>> >>>>> > > > > >>>> >>> >> >> >> The problem is that this parameter doesn't
>> >>>>>belong
>> >>>>> > in
>> >>>>> > > > the
>> >>>>> > > > > >>>> common
>> >>>>> > > > > >>>> >>> API.
>> >>>>> > > > > >>>> >>> >> >> >>It'd
>> >>>>> > > > > >>>> >>> >> >> >> be just ignored in Android, but the whole
>> >>>>>point
>> >>>>> of
>> >>>>> > > > > >>>>cordova-js
>> >>>>> > > > > >>>> >>>is
>> >>>>> > > > > >>>> >>> so
>> >>>>> > > > > >>>> >>> >> that
>> >>>>> > > > > >>>> >>> >> >> >> it's common. It'd look pretty screwed up
>> to
>> >>>>>add
>> >>>>> > this
>> >>>>> > > > to
>> >>>>> > > > > >>>>the
>> >>>>> > > > > >>>> >>>docs,
>> >>>>> > > > > >>>> >>> >> IMO.
>> >>>>> > > > > >>>> >>> >> >> >>
>> >>>>> > > > > >>>> >>> >> >> >> On Thu, Apr 12, 2012 at 3:26 PM, Shazron
>> >>>>> > > > > >>>><sh...@gmail.com>
>> >>>>> > > > > >>>> >>> wrote:
>> >>>>> > > > > >>>> >>> >> >> >>
>> >>>>> > > > > >>>> >>> >> >> >>> To fix two bugs for Camera.takePicture on
>> >>>>>iOS
>> >>>>> > > > > >>>> >>> >> >> >>>
>> >>>>> > > > > >>>> >>> >> >> >>> On Thu, Apr 12, 2012 at 3:24 PM, Filip Maj
>> >>>>> > > > > >>>><fi...@adobe.com>
>> >>>>> > > > > >>>> >>> wrote:
>> >>>>> > > > > >>>> >>> >> >> >>> > so what's the point of this new
>> >>>>>parameter?
>> >>>>> > > > > >>>> >>> >> >> >>> >
>> >>>>> > > > > >>>> >>> >> >> >>> > On 4/12/12 3:16 PM, "Shazron" <
>> >>>>> > shazron@gmail.com>
>> >>>>> > > > > >>>>wrote:
>> >>>>> > > > > >>>> >>> >> >> >>> >
>> >>>>> > > > > >>>> >>> >> >> >>> >>I did. Do we want to revert the
>> >>>>>cordova-js? I
>> >>>>> > can
>> >>>>> > > > > >>>>branch
>> >>>>> > > > > >>>> >>>1.6.0
>> >>>>> > > > > >>>> >>> and
>> >>>>> > > > > >>>> >>> >> >> >>> >>cherry-pick your latest commit for 1.6.1
>> >>>>> > > > > >>>> >>> >> >> >>> >>
>> >>>>> > > > > >>>> >>> >> >> >>> >>On Thu, Apr 12, 2012 at 3:04 PM, Filip
>> >>>>>Maj
>> >>>>> > > > > >>>><fi...@adobe.com>
>> >>>>> > > > > >>>> >>> wrote:
>> >>>>> > > > > >>>> >>> >> >> >>> >>> I saw something in the iOS commit logs
>> >>>>>for
>> >>>>> > this.
>> >>>>> > > > > >>>> >>> >> >> >>> >>>
>> >>>>> > > > > >>>> >>> >> >> >>> >>> Shaz can you comment?
>> >>>>> > > > > >>>> >>> >> >> >>> >>>
>> >>>>> > > > > >>>> >>> >> >> >>> >>> On 4/12/12 2:59 PM, "Joe Bowser" <
>> >>>>> > > > bowserj@gmail.com
>> >>>>> > > > > >
>> >>>>> > > > > >>>> >>>wrote:
>> >>>>> > > > > >>>> >>> >> >> >>> >>>
>> >>>>> > > > > >>>> >>> >> >> >>> >>>>Can we revert this, since this looks
>> >>>>>like
>> >>>>> it's
>> >>>>> > > > > >>>>intended
>> >>>>> > > > > >>>> >>>for
>> >>>>> > > > > >>>> >>> both
>> >>>>> > > > > >>>> >>> >> >> >>> Android
>> >>>>> > > > > >>>> >>> >> >> >>> >>>>and iOS, but I don't think it should
>> be
>> >>>>>in
>> >>>>> > > 1.6.1.
>> >>>>> > > > > >>>> >>> >> >> >>> >>>>
>> >>>>> > > > > >>>> >>> >> >> >>> >>>>On Thu, Apr 12, 2012 at 2:52 PM, Filip
>> >>>>>Maj <
>> >>>>> > > > > >>>> fil@adobe.com>
>> >>>>> > > > > >>>> >>> >> wrote:
>> >>>>> > > > > >>>> >>> >> >> >>> >>>>
>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> I was actually just looking at that
>> >>>>> myself.
>> >>>>> > > > > >>>> >>> >> >> >>> >>>>>
>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> Looks like it's an iOS-only param..
>> >>>>>sigh.
>> >>>>> > We
>> >>>>> > > > > >>>>gotta
>> >>>>> > > > > >>>> stop
>> >>>>> > > > > >>>> >>> doing
>> >>>>> > > > > >>>> >>> >> >> >>>that,
>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> especially if we don't update
>> >>>>> documentation.
>> >>>>> > > > > >>>> >>> >> >> >>> >>>>>
>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> On 4/12/12 2:49 PM, "Joe Bowser"
>> >>>>> > > > > >>>><bo...@gmail.com>
>> >>>>> > > > > >>>> >>> wrote:
>> >>>>> > > > > >>>> >>> >> >> >>> >>>>>
>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >Has anyone tested the cropToSize
>> >>>>>param
>> >>>>> for
>> >>>>> > > > > >>>> >>> Camera.getPicture
>> >>>>> > > > > >>>> >>> >> >> >>>yet? I
>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >didn't
>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >notice that change until now.
>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >
>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >On Thu, Apr 12, 2012 at 2:46 PM,
>> >>>>>Filip
>> >>>>> Maj
>> >>>>> > > > > >>>> >>><fil@adobe.com
>> >>>>> > > > > >>>> >>> >
>> >>>>> > > > > >>>> >>> >> >> >>>wrote:
>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >
>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> JS tagged 1.6.1 - the build task
>> >>>>>in
>> >>>>>the
>> >>>>> > JS
>> >>>>> > > > > >>>>should
>> >>>>> > > > > >>>> >>>work
>> >>>>> > > > > >>>> >>> >> >> >>>properly
>> >>>>> > > > > >>>> >>> >> >> >>> >>>>>now.
>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >>
>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> FYI if anyone has to modify the
>> >>>>>jake
>> >>>>> > tasks
>> >>>>> > > in
>> >>>>> > > > > >>>>the
>> >>>>> > > > > >>>> >>>future
>> >>>>> > > > > >>>> >>> >> and
>> >>>>> > > > > >>>> >>> >> >> >>>make
>> >>>>> > > > > >>>> >>> >> >> >>> >>>>>them
>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> async, make sure you add the 4th
>> >>>>> "async"
>> >>>>> > > > > >>>>parameter
>> >>>>> > > > > >>>> to
>> >>>>> > > > > >>>> >>> the
>> >>>>> > > > > >>>> >>> >> >> >>>task()
>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >>function
>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> and set it to true, and call
>> >>>>>complete()
>> >>>>> > > when
>> >>>>> > > > > >>>>the
>> >>>>> > > > > >>>> >>>task is
>> >>>>> > > > > >>>> >>> >> done.
>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >>
>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> See
>> >>>>> > > > > >>>> >>>
>> >>>>>http://howtonode.org/intro-to-jake/async-jakefile.jsfor
>> >>>>> > > > > >>>> >>> >> >> >>>an
>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> example.
>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >>
>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> On 4/12/12 2:35 PM, "Joe Bowser"
>> >>>>> > > > > >>>><bowserj@gmail.com
>> >>>>> > > > > >>>> >
>> >>>>> > > > > >>>> >>> >> wrote:
>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >>
>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >Ready to tag once cordova-js is
>> >>>>>tagged
>> >>>>> > > > 1.6.1.
>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >
>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >On Thu, Apr 12, 2012 at 2:33 PM,
>> >>>>>Anis
>> >>>>> > > KADRI
>> >>>>> > > > <
>> >>>>> > > > > >>>> >>> >> >> >>> anis.kadri@gmail.com>
>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >>wrote:
>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >
>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> I will tag my repository to
>> >>>>>1.6.1
>> >>>>> > before
>> >>>>> > > > > >>>>end of
>> >>>>> > > > > >>>> >>>day
>> >>>>> > > > > >>>> >>> >> today
>> >>>>> > > > > >>>> >>> >> >> >>>after
>> >>>>> > > > > >>>> >>> >> >> >>> >>>>>some
>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> thorough testing.
>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >>
>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> On Thu, Apr 12, 2012 at 2:30
>> >>>>>PM,
>> >>>>> > Shazron
>> >>>>> > > > > >>>> >>> >> >> >>><sh...@gmail.com>
>> >>>>> > > > > >>>> >>> >> >> >>> >>>>>wrote:
>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >>
>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > I also created a 1.6.1
>> >>>>>version
>> >>>>>tag
>> >>>>> > as
>> >>>>> > > > > >>>>well in
>> >>>>> > > > > >>>> >>> jira...
>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> >
>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > On Thu, Apr 12, 2012 at 2:29
>> >>>>>PM,
>> >>>>> > > Shazron
>> >>>>> > > > > >>>> >>> >> >> >>><sh...@gmail.com>
>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> wrote:
>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > > Alright guys since 1.6.0
>> >>>>>was
>> >>>>> > > released,
>> >>>>> > > > > >>>>I'm
>> >>>>> > > > > >>>> >>>going
>> >>>>> > > > > >>>> >>> to
>> >>>>> > > > > >>>> >>> >> >> >>> >>>>>"Release"
>> >>>>> > > > > >>>> >>> >> >> >>> >>>>>the
>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > > 1.6.0 version in jira and
>> >>>>>move
>> >>>>> > > > > >>>>outstanding
>> >>>>> > > > > >>>> >>> issues to
>> >>>>> > > > > >>>> >>> >> >> >>>1.7.0
>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >>version
>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > > tag.
>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >
>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >
>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > > On Thu, Apr 12, 2012 at
>> >>>>>2:26
>> >>>>>PM,
>> >>>>> > > Filip
>> >>>>> > > > > >>>>Maj
>> >>>>> > > > > >>>> >>> >> >> >>><fi...@adobe.com>
>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> wrote:
>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >> The JS needs patching
>> too.
>> >>>>> Since
>> >>>>> > > > > >>>>adding the
>> >>>>> > > > > >>>> >>> commit
>> >>>>> > > > > >>>> >>> >> ID
>> >>>>> > > > > >>>> >>> >> >> >>>into
>> >>>>> > > > > >>>> >>> >> >> >>> >>>>>the
>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> packaging
>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >> in the jakefile, the
>> >>>>>default
>> >>>>> task
>> >>>>> > > > isn't
>> >>>>> > > > > >>>> >>>running
>> >>>>> > > > > >>>> >>> >> >> >>>properly.
>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>
>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >> You can manually run
>> "jake
>> >>>>> build"
>> >>>>> > > and
>> >>>>> > > > > >>>>"jake
>> >>>>> > > > > >>>> >>> test"
>> >>>>> > > > > >>>> >>> >> but
>> >>>>> > > > > >>>> >>> >> >> >>>not
>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >>"jake" on
>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> its
>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >> own - gonna try to figure
>> >>>>>it
>> >>>>> out.
>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>
>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >> On 4/12/12 2:21 PM,
>> >>>>>"Shazron" <
>> >>>>> > > > > >>>> >>> shazron@gmail.com>
>> >>>>> > > > > >>>> >>> >> >> >>>wrote:
>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>
>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>I'm good with tagging.
>> >>>>>iOS
>> >>>>> has a
>> >>>>> > > few
>> >>>>> > > > > >>>> commits
>> >>>>> > > > > >>>> >>> (one
>> >>>>> > > > > >>>> >>> >> >> >>>commit
>> >>>>> > > > > >>>> >>> >> >> >>> >>>>>in
>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>cordova-js) as well. Aim
>> >>>>>for
>> >>>>> > first
>> >>>>> > > > > >>>>thing
>> >>>>> > > > > >>>> >>> tomorrow
>> >>>>> > > > > >>>> >>> >> for
>> >>>>> > > > > >>>> >>> >> >> >>>you
>> >>>>> > > > > >>>> >>> >> >> >>> >>>>>to
>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>repackage?
>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>
>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>On Thu, Apr 12, 2012 at
>> >>>>>2:17
>> >>>>> PM,
>> >>>>> > > > > >>>>Steven Gill
>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >><st...@gmail.com>
>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>wrote:
>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>> So a bug has been
>> >>>>>discovered
>> >>>>> in
>> >>>>> > > > > >>>>Cordova
>> >>>>> > > > > >>>> >>> Android
>> >>>>> > > > > >>>> >>> >> that
>> >>>>> > > > > >>>> >>> >> >> >>> >>>>>requires
>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >>a
>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >>new
>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > tag
>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>>and
>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>> release. You can check
>> >>>>>out
>> >>>>> the
>> >>>>> > > bug
>> >>>>> > > > > >>>>on the
>> >>>>> > > > > >>>> >>> issue
>> >>>>> > > > > >>>> >>> >> >> >>>tracker
>> >>>>> > > > > >>>> >>> >> >> >>> >>>>>at
>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>>
>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>>
>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> >
>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >>
>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >>
>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >>
>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >>
>> >>>>> > > > > >>>> >>> >> >> >>> >>>>>
>> >>>>> > > > > >>>> >>> >> >> >>> >>>>>
>> >>>>> > > > > >>>> >>> >> >> >>>
>> >>>>> > > > > >>>> >>> >> >>
>> >>>>> > > > > >>>> >>>
>> >>>>> > > > > >>>>
>> >>>>> > > > > >>>>
>> >>>>> > > > >
>> >>>>> > >
>> >>>>>
>> >>>>>
>> https://issues.apache.org/jira/browse/CB-490?focusedCommentId=13252809#
>> >>>>> > > > > >>>> >>> >> >> >>> >>>>>co
>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>>mment-13252809
>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>>
>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>> It doesn't make sense
>> to
>> >>>>>just
>> >>>>> > > > > >>>>repackage
>> >>>>> > > > > >>>> >>>1.6.0
>> >>>>> > > > > >>>> >>> >> with
>> >>>>> > > > > >>>> >>> >> >> >>>this
>> >>>>> > > > > >>>> >>> >> >> >>> >>>>>bug
>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >>fixed as
>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > we
>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>> will have no way to
>> know
>> >>>>>if
>> >>>>> > > people
>> >>>>> > > > > >>>>are
>> >>>>> > > > > >>>> >>> >> experiencing
>> >>>>> > > > > >>>> >>> >> >> >>>this
>> >>>>> > > > > >>>> >>> >> >> >>> >>>>>or
>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >>not.
>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>>
>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>> Anis mentioned Bada
>> also
>> >>>>>had
>> >>>>> > some
>> >>>>> > > > > >>>>major
>> >>>>> > > > > >>>> >>>issues
>> >>>>> > > > > >>>> >>> >> >> >>>which he
>> >>>>> > > > > >>>> >>> >> >> >>> >>>>>has
>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >>fixed
>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> now
>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>>and
>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>> would like in a 1.6.1
>> >>>>> release.
>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>>
>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>> Thoughts?
>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>>
>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>> -Steve
>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>
>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> >
>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >>
>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >>
>> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >>
>> >>>>> > > > > >>>> >>> >> >> >>> >>>>>
>> >>>>> > > > > >>>> >>> >> >> >>> >>>>>
>> >>>>> > > > > >>>> >>> >> >> >>> >>>
>> >>>>> > > > > >>>> >>> >> >> >>> >
>> >>>>> > > > > >>>> >>> >> >> >>>
>> >>>>> > > > > >>>> >>> >> >>
>> >>>>> > > > > >>>> >>> >> >>
>> >>>>> > > > > >>>> >>> >>
>> >>>>> > > > > >>>> >>>
>> >>>>> > > > > >>>> >
>> >>>>> > > > > >>>>
>> >>>>> > > > >
>> >>>>> > > > >
>> >>>>> > > >
>> >>>>> > >
>> >>>>> >
>> >>>>>
>> >>>
>> >
>>
Re: 1.6.1
Posted by Jesse <pu...@gmail.com>.
I am commited and tagged
On Thu, Apr 12, 2012 at 5:27 PM, Shazron <sh...@gmail.com> wrote:
> Logic error - no worries, I patched it (going to re-do 1.6.1 iOS)
>
> On Thu, Apr 12, 2012 at 5:27 PM, Filip Maj <fi...@adobe.com> wrote:
> > Did I f that up?
> >
> > On 4/12/12 5:07 PM, "Shazron" <sh...@gmail.com> wrote:
> >
> >>Sigh - user reported iOS bug
> >>
> http://groups.google.com/group/phonegap/browse_thread/thread/faad0af97dec8
> >>907
> >>(you know who you are ;)
> >>
> >>On Thu, Apr 12, 2012 at 5:05 PM, Filip Maj <fi...@adobe.com> wrote:
> >>> Saweet! Nice work Anis. That kills off a bunch of old issues in JIRA
> >>>too.
> >>>
> >>> Way to hunker down all. As Jesse pointed out to me, we did 45 emails in
> >>> two hours haha
> >>>
> >>> On 4/12/12 5:00 PM, "Anis KADRI" <an...@gmail.com> wrote:
> >>>
> >>>>Bada 1.2 is tagged 1.6.1. I added the new Cordova artwork,
> >>>>LICENSE/NOTICE
> >>>>files as well as the Apache source headers in every source file. I
> fixed
> >>>>all the bugs I sawS
> >>>>
> >>>>On Thu, Apr 12, 2012 at 4:38 PM, Joe Bowser <bo...@gmail.com> wrote:
> >>>>
> >>>>> Android is tagged.
> >>>>>
> >>>>> On Thu, Apr 12, 2012 at 4:36 PM, Jesse <pu...@gmail.com>
> >>>>>wrote:
> >>>>>
> >>>>> > Done
> >>>>> >
> >>>>> > On Thu, Apr 12, 2012 at 4:31 PM, Joe Bowser <bo...@gmail.com>
> >>>>>wrote:
> >>>>> >
> >>>>> > > I'd like to get the JS from the tag, but I need a tag for that.
> >>>>> > >
> >>>>> > > On Thu, Apr 12, 2012 at 4:29 PM, Jesse <pu...@gmail.com>
> >>>>> wrote:
> >>>>> > >
> >>>>> > > > Okay, I think it's good, tagging at 16:32 PDT if i don't hear
> >>>>>any
> >>>>> > > > complaints.
> >>>>> > > >
> >>>>> > > > On Thu, Apr 12, 2012 at 4:26 PM, Filip Maj <fi...@adobe.com>
> >>>>>wrote:
> >>>>> > > >
> >>>>> > > > > I just axed the existing 1.6.1 cordova-js tag
> >>>>> > > > >
> >>>>> > > > > Jesse when you feel you've got everything in there go ahead
> >>>>>and
> >>>>>tag
> >>>>> > JS
> >>>>> > > > >
> >>>>> > > > > On 4/12/12 4:20 PM, "Shazron" <sh...@gmail.com> wrote:
> >>>>> > > > >
> >>>>> > > > > >Reverted. Just talked to Jesse - he has commits to
> cordova-js
> >>>>> > coming,
> >>>>> > > > > >once those are in we can re-tag cordova-js to 1.6.1
> >>>>> > > > > >
> >>>>> > > > > >On Thu, Apr 12, 2012 at 4:12 PM, Shazron <shazron@gmail.com
> >
> >>>>> wrote:
> >>>>> > > > > >> I'll remove it. *grabs the shovel*
> >>>>> > > > > >>
> >>>>> > > > > >> On Thu, Apr 12, 2012 at 4:10 PM, Joe Bowser
> >>>>><bo...@gmail.com>
> >>>>> > > > wrote:
> >>>>> > > > > >>> You know, let's not rebase it, because it does modify the
> >>>>> > history.
> >>>>> > > > We
> >>>>> > > > > >>> should remove and document why we did it instead, since
> >>>>>that
> >>>>> > would
> >>>>> > > be
> >>>>> > > > > >>>more
> >>>>> > > > > >>> transparent. Or we could just leave it in and say "don't
> >>>>>do
> >>>>> this
> >>>>> > > next
> >>>>> > > > > >>> time". I'm not that invested in it.
> >>>>> > > > > >>>
> >>>>> > > > > >>> On Thu, Apr 12, 2012 at 4:04 PM, Shazron
> >>>>><sh...@gmail.com>
> >>>>> > > wrote:
> >>>>> > > > > >>>
> >>>>> > > > > >>>> If we take out that iOS commit in cordova-js (somehow),
> >>>>>it
> >>>>> > should
> >>>>> > > be
> >>>>> > > > > >>>> fine. cordova-ios 1.6.1 will then just be the same as
> >>>>>1.6.0.
> >>>>> > > > > >>>>
> >>>>> > > > > >>>> On Thu, Apr 12, 2012 at 4:02 PM, Filip Maj
> >>>>><fi...@adobe.com>
> >>>>> > wrote:
> >>>>> > > > > >>>> >
> >>>>> > > > > >>>> >>Is it too much to drop the new commit that changed the
> >>>>> common
> >>>>> > js
> >>>>> > > > > >>>>API, and
> >>>>> > > > > >>>> >>reapply it after we tag 1.6.1, and figure this one
> >>>>>thing
> >>>>>out
> >>>>> > for
> >>>>> > > > > >>>>1.7?
> >>>>> > > > > >>>> >
> >>>>> > > > > >>>> > That sounds very good to me but I am under the
> >>>>>impression
> >>>>> that
> >>>>> > > iOS
> >>>>> > > > > >>>> > requires this commit? Like I said I'm quite confused.
> >>>>> > > > > >>>> >
> >>>>> > > > > >>>> >>
> >>>>> > > > > >>>> >>I also have some cordova-js commits to add to 1.6.1?
> >>>>> Although
> >>>>> > > > > >>>>nothing
> >>>>> > > > > >>>> that
> >>>>> > > > > >>>> >>modifies any js outside of what is built for wp7. (
> ie,
> >>>>>all
> >>>>> in
> >>>>> > > my
> >>>>> > > > > >>>> platform
> >>>>> > > > > >>>> >>specific plugins folder )
> >>>>> > > > > >>>> >>
> >>>>> > > > > >>>> >
> >>>>> > > > > >>>> > O then it sounds like I tagged the JS 1.6.1 too early
> >>>>> > anyways..
> >>>>> > > > > >>>> >
> >>>>> > > > > >>>> >>
> >>>>> > > > > >>>> >>
> >>>>> > > > > >>>> >>
> >>>>> > > > > >>>> >>On Thu, Apr 12, 2012 at 3:51 PM, Shazron
> >>>>><shazron@gmail.com
> >>>>> >
> >>>>> > > > wrote:
> >>>>> > > > > >>>> >>
> >>>>> > > > > >>>> >>> No - it's about a user's contribution being noted
> (it
> >>>>> > > exists), I
> >>>>> > > > > >>>>will
> >>>>> > > > > >>>> >>> move it out of the common code post-1.6.1 (I
> >>>>>acknowledge
> >>>>> my
> >>>>> > > > > >>>>mistake in
> >>>>> > > > > >>>> >>> allowing it in the first place). Can we branch off
> >>>>>1.6.0
> >>>>> > then
> >>>>> > > > > >>>> >>> cherry-pick Fil's latest fix for 1.6.1?
> >>>>> > > > > >>>> >>>
> >>>>> > > > > >>>> >>> On Thu, Apr 12, 2012 at 3:47 PM, Joe Bowser <
> >>>>> > > bowserj@gmail.com>
> >>>>> > > > > >>>>wrote:
> >>>>> > > > > >>>> >>> > OK, so you're proposing that we leave the thing in
> >>>>>the
> >>>>> > > common
> >>>>> > > > > >>>>JS,
> >>>>> > > > > >>>> even
> >>>>> > > > > >>>> >>> > though it's not supposed to be there.
> >>>>> > > > > >>>> >>> >
> >>>>> > > > > >>>> >>> > On Thu, Apr 12, 2012 at 3:45 PM, Shazron <
> >>>>> > shazron@gmail.com
> >>>>> > > >
> >>>>> > > > > >>>>wrote:
> >>>>> > > > > >>>> >>> >
> >>>>> > > > > >>>> >>> >> Will rebasing lose that commit? Then, no.
> >>>>> > > > > >>>> >>> >>
> >>>>> > > > > >>>> >>> >> On Thu, Apr 12, 2012 at 3:43 PM, Joe Bowser <
> >>>>> > > > bowserj@gmail.com
> >>>>> > > > > >
> >>>>> > > > > >>>> >>>wrote:
> >>>>> > > > > >>>> >>> >> > So, can we just rebase the head, push this out
> >>>>>and
> >>>>> get
> >>>>> > > this
> >>>>> > > > > >>>> >>>rolling?
> >>>>> > > > > >>>> >>> >> >
> >>>>> > > > > >>>> >>> >> > On Thu, Apr 12, 2012 at 3:43 PM, Filip Maj <
> >>>>> > > fil@adobe.com>
> >>>>> > > > > >>>>wrote:
> >>>>> > > > > >>>> >>> >> >
> >>>>> > > > > >>>> >>> >> >> Correct, those iOS-specific parameters (like
> >>>>>allow
> >>>>> > edit
> >>>>> > > > and
> >>>>> > > > > >>>>those
> >>>>> > > > > >>>> >>> ones)
> >>>>> > > > > >>>> >>> >> >> existed prior to cordova-js, so yeah, we left
> >>>>>them
> >>>>> in
> >>>>> > > > there
> >>>>> > > > > >>>>as we
> >>>>> > > > > >>>> >>> didn't
> >>>>> > > > > >>>> >>> >> >> want to remove without deprecation.
> >>>>> > > > > >>>> >>> >> >>
> >>>>> > > > > >>>> >>> >> >> If you can deal with the iOS issue without
> >>>>>needing
> >>>>> an
> >>>>> > > API
> >>>>> > > > > >>>> >>>extension:
> >>>>> > > > > >>>> >>> >> then
> >>>>> > > > > >>>> >>> >> >> do that. If not, leave it in there, but docs
> >>>>>need to
> >>>>> > > > > >>>>updated too.
> >>>>> > > > > >>>> >>> >> >>
> >>>>> > > > > >>>> >>> >> >> Extending and changing the public API is a
> long
> >>>>>and
> >>>>> > > > > >>>>difficult
> >>>>> > > > > >>>> >>>process
> >>>>> > > > > >>>> >>> >> for
> >>>>> > > > > >>>> >>> >> >> us and will only get tougher with every
> >>>>>platform
> >>>>>we
> >>>>> > add
> >>>>> > > > > >>>>support
> >>>>> > > > > >>>> >>>to.
> >>>>> > > > > >>>> >>> >> >>
> >>>>> > > > > >>>> >>> >> >> On 4/12/12 3:37 PM, "Shazron"
> >>>>><sh...@gmail.com>
> >>>>> > > wrote:
> >>>>> > > > > >>>> >>> >> >>
> >>>>> > > > > >>>> >>> >> >> >Then we have to scrap the other three(?) iOS
> >>>>> > parameters
> >>>>> > > > > >>>>ones
> >>>>> > > > > >>>> that
> >>>>> > > > > >>>> >>> >> >> >already exist in common if you noticed. Don't
> >>>>>know
> >>>>> > how
> >>>>> > > we
> >>>>> > > > > >>>>merge
> >>>>> > > > > >>>> >>> >> >> >(unmerge?) this one properly because taking
> >>>>>those
> >>>>> out
> >>>>> > > > will
> >>>>> > > > > >>>>break
> >>>>> > > > > >>>> >>> >> >> >everyone that is using it, but a deprecation
> >>>>>is
> >>>>>the
> >>>>> > way
> >>>>> > > > to
> >>>>> > > > > >>>>go as
> >>>>> > > > > >>>> >>>per
> >>>>> > > > > >>>> >>> >> >>
> >>>>>>http://wiki.apache.org/cordova/DeprecationPolicy .
> >>>>> > We
> >>>>> > > > can
> >>>>> > > > > >>>> remove
> >>>>> > > > > >>>> >>> this
> >>>>> > > > > >>>> >>> >> >> >new commit and I'll find a way to get this in
> >>>>> > somehow.
> >>>>> > > > > >>>> >>> >> >> >
> >>>>> > > > > >>>> >>> >> >> >
> >>>>> > > > > >>>> >>> >> >> >
> >>>>> > > > > >>>> >>> >> >> >On Thu, Apr 12, 2012 at 3:32 PM, Joe Bowser
> >>>>> > > > > >>>><bo...@gmail.com>
> >>>>> > > > > >>>> >>> wrote:
> >>>>> > > > > >>>> >>> >> >> >> The problem is that this parameter doesn't
> >>>>>belong
> >>>>> > in
> >>>>> > > > the
> >>>>> > > > > >>>> common
> >>>>> > > > > >>>> >>> API.
> >>>>> > > > > >>>> >>> >> >> >>It'd
> >>>>> > > > > >>>> >>> >> >> >> be just ignored in Android, but the whole
> >>>>>point
> >>>>> of
> >>>>> > > > > >>>>cordova-js
> >>>>> > > > > >>>> >>>is
> >>>>> > > > > >>>> >>> so
> >>>>> > > > > >>>> >>> >> that
> >>>>> > > > > >>>> >>> >> >> >> it's common. It'd look pretty screwed up
> to
> >>>>>add
> >>>>> > this
> >>>>> > > > to
> >>>>> > > > > >>>>the
> >>>>> > > > > >>>> >>>docs,
> >>>>> > > > > >>>> >>> >> IMO.
> >>>>> > > > > >>>> >>> >> >> >>
> >>>>> > > > > >>>> >>> >> >> >> On Thu, Apr 12, 2012 at 3:26 PM, Shazron
> >>>>> > > > > >>>><sh...@gmail.com>
> >>>>> > > > > >>>> >>> wrote:
> >>>>> > > > > >>>> >>> >> >> >>
> >>>>> > > > > >>>> >>> >> >> >>> To fix two bugs for Camera.takePicture on
> >>>>>iOS
> >>>>> > > > > >>>> >>> >> >> >>>
> >>>>> > > > > >>>> >>> >> >> >>> On Thu, Apr 12, 2012 at 3:24 PM, Filip Maj
> >>>>> > > > > >>>><fi...@adobe.com>
> >>>>> > > > > >>>> >>> wrote:
> >>>>> > > > > >>>> >>> >> >> >>> > so what's the point of this new
> >>>>>parameter?
> >>>>> > > > > >>>> >>> >> >> >>> >
> >>>>> > > > > >>>> >>> >> >> >>> > On 4/12/12 3:16 PM, "Shazron" <
> >>>>> > shazron@gmail.com>
> >>>>> > > > > >>>>wrote:
> >>>>> > > > > >>>> >>> >> >> >>> >
> >>>>> > > > > >>>> >>> >> >> >>> >>I did. Do we want to revert the
> >>>>>cordova-js? I
> >>>>> > can
> >>>>> > > > > >>>>branch
> >>>>> > > > > >>>> >>>1.6.0
> >>>>> > > > > >>>> >>> and
> >>>>> > > > > >>>> >>> >> >> >>> >>cherry-pick your latest commit for 1.6.1
> >>>>> > > > > >>>> >>> >> >> >>> >>
> >>>>> > > > > >>>> >>> >> >> >>> >>On Thu, Apr 12, 2012 at 3:04 PM, Filip
> >>>>>Maj
> >>>>> > > > > >>>><fi...@adobe.com>
> >>>>> > > > > >>>> >>> wrote:
> >>>>> > > > > >>>> >>> >> >> >>> >>> I saw something in the iOS commit logs
> >>>>>for
> >>>>> > this.
> >>>>> > > > > >>>> >>> >> >> >>> >>>
> >>>>> > > > > >>>> >>> >> >> >>> >>> Shaz can you comment?
> >>>>> > > > > >>>> >>> >> >> >>> >>>
> >>>>> > > > > >>>> >>> >> >> >>> >>> On 4/12/12 2:59 PM, "Joe Bowser" <
> >>>>> > > > bowserj@gmail.com
> >>>>> > > > > >
> >>>>> > > > > >>>> >>>wrote:
> >>>>> > > > > >>>> >>> >> >> >>> >>>
> >>>>> > > > > >>>> >>> >> >> >>> >>>>Can we revert this, since this looks
> >>>>>like
> >>>>> it's
> >>>>> > > > > >>>>intended
> >>>>> > > > > >>>> >>>for
> >>>>> > > > > >>>> >>> both
> >>>>> > > > > >>>> >>> >> >> >>> Android
> >>>>> > > > > >>>> >>> >> >> >>> >>>>and iOS, but I don't think it should
> be
> >>>>>in
> >>>>> > > 1.6.1.
> >>>>> > > > > >>>> >>> >> >> >>> >>>>
> >>>>> > > > > >>>> >>> >> >> >>> >>>>On Thu, Apr 12, 2012 at 2:52 PM, Filip
> >>>>>Maj <
> >>>>> > > > > >>>> fil@adobe.com>
> >>>>> > > > > >>>> >>> >> wrote:
> >>>>> > > > > >>>> >>> >> >> >>> >>>>
> >>>>> > > > > >>>> >>> >> >> >>> >>>>> I was actually just looking at that
> >>>>> myself.
> >>>>> > > > > >>>> >>> >> >> >>> >>>>>
> >>>>> > > > > >>>> >>> >> >> >>> >>>>> Looks like it's an iOS-only param..
> >>>>>sigh.
> >>>>> > We
> >>>>> > > > > >>>>gotta
> >>>>> > > > > >>>> stop
> >>>>> > > > > >>>> >>> doing
> >>>>> > > > > >>>> >>> >> >> >>>that,
> >>>>> > > > > >>>> >>> >> >> >>> >>>>> especially if we don't update
> >>>>> documentation.
> >>>>> > > > > >>>> >>> >> >> >>> >>>>>
> >>>>> > > > > >>>> >>> >> >> >>> >>>>> On 4/12/12 2:49 PM, "Joe Bowser"
> >>>>> > > > > >>>><bo...@gmail.com>
> >>>>> > > > > >>>> >>> wrote:
> >>>>> > > > > >>>> >>> >> >> >>> >>>>>
> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >Has anyone tested the cropToSize
> >>>>>param
> >>>>> for
> >>>>> > > > > >>>> >>> Camera.getPicture
> >>>>> > > > > >>>> >>> >> >> >>>yet? I
> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >didn't
> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >notice that change until now.
> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >
> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >On Thu, Apr 12, 2012 at 2:46 PM,
> >>>>>Filip
> >>>>> Maj
> >>>>> > > > > >>>> >>><fil@adobe.com
> >>>>> > > > > >>>> >>> >
> >>>>> > > > > >>>> >>> >> >> >>>wrote:
> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >
> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> JS tagged 1.6.1 - the build task
> >>>>>in
> >>>>>the
> >>>>> > JS
> >>>>> > > > > >>>>should
> >>>>> > > > > >>>> >>>work
> >>>>> > > > > >>>> >>> >> >> >>>properly
> >>>>> > > > > >>>> >>> >> >> >>> >>>>>now.
> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >>
> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> FYI if anyone has to modify the
> >>>>>jake
> >>>>> > tasks
> >>>>> > > in
> >>>>> > > > > >>>>the
> >>>>> > > > > >>>> >>>future
> >>>>> > > > > >>>> >>> >> and
> >>>>> > > > > >>>> >>> >> >> >>>make
> >>>>> > > > > >>>> >>> >> >> >>> >>>>>them
> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> async, make sure you add the 4th
> >>>>> "async"
> >>>>> > > > > >>>>parameter
> >>>>> > > > > >>>> to
> >>>>> > > > > >>>> >>> the
> >>>>> > > > > >>>> >>> >> >> >>>task()
> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >>function
> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> and set it to true, and call
> >>>>>complete()
> >>>>> > > when
> >>>>> > > > > >>>>the
> >>>>> > > > > >>>> >>>task is
> >>>>> > > > > >>>> >>> >> done.
> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >>
> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> See
> >>>>> > > > > >>>> >>>
> >>>>>http://howtonode.org/intro-to-jake/async-jakefile.jsfor
> >>>>> > > > > >>>> >>> >> >> >>>an
> >>>>> > > > > >>>> >>> >> >> >>> >>>>> example.
> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >>
> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> On 4/12/12 2:35 PM, "Joe Bowser"
> >>>>> > > > > >>>><bowserj@gmail.com
> >>>>> > > > > >>>> >
> >>>>> > > > > >>>> >>> >> wrote:
> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >>
> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >Ready to tag once cordova-js is
> >>>>>tagged
> >>>>> > > > 1.6.1.
> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >
> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >On Thu, Apr 12, 2012 at 2:33 PM,
> >>>>>Anis
> >>>>> > > KADRI
> >>>>> > > > <
> >>>>> > > > > >>>> >>> >> >> >>> anis.kadri@gmail.com>
> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >>wrote:
> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >
> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> I will tag my repository to
> >>>>>1.6.1
> >>>>> > before
> >>>>> > > > > >>>>end of
> >>>>> > > > > >>>> >>>day
> >>>>> > > > > >>>> >>> >> today
> >>>>> > > > > >>>> >>> >> >> >>>after
> >>>>> > > > > >>>> >>> >> >> >>> >>>>>some
> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> thorough testing.
> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >>
> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> On Thu, Apr 12, 2012 at 2:30
> >>>>>PM,
> >>>>> > Shazron
> >>>>> > > > > >>>> >>> >> >> >>><sh...@gmail.com>
> >>>>> > > > > >>>> >>> >> >> >>> >>>>>wrote:
> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >>
> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > I also created a 1.6.1
> >>>>>version
> >>>>>tag
> >>>>> > as
> >>>>> > > > > >>>>well in
> >>>>> > > > > >>>> >>> jira...
> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> >
> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > On Thu, Apr 12, 2012 at 2:29
> >>>>>PM,
> >>>>> > > Shazron
> >>>>> > > > > >>>> >>> >> >> >>><sh...@gmail.com>
> >>>>> > > > > >>>> >>> >> >> >>> >>>>> wrote:
> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > > Alright guys since 1.6.0
> >>>>>was
> >>>>> > > released,
> >>>>> > > > > >>>>I'm
> >>>>> > > > > >>>> >>>going
> >>>>> > > > > >>>> >>> to
> >>>>> > > > > >>>> >>> >> >> >>> >>>>>"Release"
> >>>>> > > > > >>>> >>> >> >> >>> >>>>>the
> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > > 1.6.0 version in jira and
> >>>>>move
> >>>>> > > > > >>>>outstanding
> >>>>> > > > > >>>> >>> issues to
> >>>>> > > > > >>>> >>> >> >> >>>1.7.0
> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >>version
> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > > tag.
> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >
> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >
> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > > On Thu, Apr 12, 2012 at
> >>>>>2:26
> >>>>>PM,
> >>>>> > > Filip
> >>>>> > > > > >>>>Maj
> >>>>> > > > > >>>> >>> >> >> >>><fi...@adobe.com>
> >>>>> > > > > >>>> >>> >> >> >>> >>>>> wrote:
> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >> The JS needs patching
> too.
> >>>>> Since
> >>>>> > > > > >>>>adding the
> >>>>> > > > > >>>> >>> commit
> >>>>> > > > > >>>> >>> >> ID
> >>>>> > > > > >>>> >>> >> >> >>>into
> >>>>> > > > > >>>> >>> >> >> >>> >>>>>the
> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> packaging
> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >> in the jakefile, the
> >>>>>default
> >>>>> task
> >>>>> > > > isn't
> >>>>> > > > > >>>> >>>running
> >>>>> > > > > >>>> >>> >> >> >>>properly.
> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>
> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >> You can manually run
> "jake
> >>>>> build"
> >>>>> > > and
> >>>>> > > > > >>>>"jake
> >>>>> > > > > >>>> >>> test"
> >>>>> > > > > >>>> >>> >> but
> >>>>> > > > > >>>> >>> >> >> >>>not
> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >>"jake" on
> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> its
> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >> own - gonna try to figure
> >>>>>it
> >>>>> out.
> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>
> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >> On 4/12/12 2:21 PM,
> >>>>>"Shazron" <
> >>>>> > > > > >>>> >>> shazron@gmail.com>
> >>>>> > > > > >>>> >>> >> >> >>>wrote:
> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>
> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>I'm good with tagging.
> >>>>>iOS
> >>>>> has a
> >>>>> > > few
> >>>>> > > > > >>>> commits
> >>>>> > > > > >>>> >>> (one
> >>>>> > > > > >>>> >>> >> >> >>>commit
> >>>>> > > > > >>>> >>> >> >> >>> >>>>>in
> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>cordova-js) as well. Aim
> >>>>>for
> >>>>> > first
> >>>>> > > > > >>>>thing
> >>>>> > > > > >>>> >>> tomorrow
> >>>>> > > > > >>>> >>> >> for
> >>>>> > > > > >>>> >>> >> >> >>>you
> >>>>> > > > > >>>> >>> >> >> >>> >>>>>to
> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>repackage?
> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>
> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>On Thu, Apr 12, 2012 at
> >>>>>2:17
> >>>>> PM,
> >>>>> > > > > >>>>Steven Gill
> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >><st...@gmail.com>
> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>wrote:
> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>> So a bug has been
> >>>>>discovered
> >>>>> in
> >>>>> > > > > >>>>Cordova
> >>>>> > > > > >>>> >>> Android
> >>>>> > > > > >>>> >>> >> that
> >>>>> > > > > >>>> >>> >> >> >>> >>>>>requires
> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >>a
> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >>new
> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > tag
> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>>and
> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>> release. You can check
> >>>>>out
> >>>>> the
> >>>>> > > bug
> >>>>> > > > > >>>>on the
> >>>>> > > > > >>>> >>> issue
> >>>>> > > > > >>>> >>> >> >> >>>tracker
> >>>>> > > > > >>>> >>> >> >> >>> >>>>>at
> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>>
> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>>
> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> >
> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >>
> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >>
> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >>
> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >>
> >>>>> > > > > >>>> >>> >> >> >>> >>>>>
> >>>>> > > > > >>>> >>> >> >> >>> >>>>>
> >>>>> > > > > >>>> >>> >> >> >>>
> >>>>> > > > > >>>> >>> >> >>
> >>>>> > > > > >>>> >>>
> >>>>> > > > > >>>>
> >>>>> > > > > >>>>
> >>>>> > > > >
> >>>>> > >
> >>>>>
> >>>>>
> https://issues.apache.org/jira/browse/CB-490?focusedCommentId=13252809#
> >>>>> > > > > >>>> >>> >> >> >>> >>>>>co
> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>>mment-13252809
> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>>
> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>> It doesn't make sense
> to
> >>>>>just
> >>>>> > > > > >>>>repackage
> >>>>> > > > > >>>> >>>1.6.0
> >>>>> > > > > >>>> >>> >> with
> >>>>> > > > > >>>> >>> >> >> >>>this
> >>>>> > > > > >>>> >>> >> >> >>> >>>>>bug
> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >>fixed as
> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > we
> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>> will have no way to
> know
> >>>>>if
> >>>>> > > people
> >>>>> > > > > >>>>are
> >>>>> > > > > >>>> >>> >> experiencing
> >>>>> > > > > >>>> >>> >> >> >>>this
> >>>>> > > > > >>>> >>> >> >> >>> >>>>>or
> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >>not.
> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>>
> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>> Anis mentioned Bada
> also
> >>>>>had
> >>>>> > some
> >>>>> > > > > >>>>major
> >>>>> > > > > >>>> >>>issues
> >>>>> > > > > >>>> >>> >> >> >>>which he
> >>>>> > > > > >>>> >>> >> >> >>> >>>>>has
> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >>fixed
> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> now
> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>>and
> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>> would like in a 1.6.1
> >>>>> release.
> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>>
> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>> Thoughts?
> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>>
> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>> -Steve
> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>
> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> >
> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >>
> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >>
> >>>>> > > > > >>>> >>> >> >> >>> >>>>> >>
> >>>>> > > > > >>>> >>> >> >> >>> >>>>>
> >>>>> > > > > >>>> >>> >> >> >>> >>>>>
> >>>>> > > > > >>>> >>> >> >> >>> >>>
> >>>>> > > > > >>>> >>> >> >> >>> >
> >>>>> > > > > >>>> >>> >> >> >>>
> >>>>> > > > > >>>> >>> >> >>
> >>>>> > > > > >>>> >>> >> >>
> >>>>> > > > > >>>> >>> >>
> >>>>> > > > > >>>> >>>
> >>>>> > > > > >>>> >
> >>>>> > > > > >>>>
> >>>>> > > > >
> >>>>> > > > >
> >>>>> > > >
> >>>>> > >
> >>>>> >
> >>>>>
> >>>
> >
>
Re: 1.6.1
Posted by Shazron <sh...@gmail.com>.
iOS fix patched, tested, and re-tagged 1.6.1 (had to branch off 1.6.0
and apply this one patch)
On Thu, Apr 12, 2012 at 5:27 PM, Shazron <sh...@gmail.com> wrote:
> Logic error - no worries, I patched it (going to re-do 1.6.1 iOS)
>
> On Thu, Apr 12, 2012 at 5:27 PM, Filip Maj <fi...@adobe.com> wrote:
>> Did I f that up?
>>
>> On 4/12/12 5:07 PM, "Shazron" <sh...@gmail.com> wrote:
>>
>>>Sigh - user reported iOS bug
>>>http://groups.google.com/group/phonegap/browse_thread/thread/faad0af97dec8
>>>907
>>>(you know who you are ;)
>>>
>>>On Thu, Apr 12, 2012 at 5:05 PM, Filip Maj <fi...@adobe.com> wrote:
>>>> Saweet! Nice work Anis. That kills off a bunch of old issues in JIRA
>>>>too.
>>>>
>>>> Way to hunker down all. As Jesse pointed out to me, we did 45 emails in
>>>> two hours haha
>>>>
>>>> On 4/12/12 5:00 PM, "Anis KADRI" <an...@gmail.com> wrote:
>>>>
>>>>>Bada 1.2 is tagged 1.6.1. I added the new Cordova artwork,
>>>>>LICENSE/NOTICE
>>>>>files as well as the Apache source headers in every source file. I fixed
>>>>>all the bugs I sawS
>>>>>
>>>>>On Thu, Apr 12, 2012 at 4:38 PM, Joe Bowser <bo...@gmail.com> wrote:
>>>>>
>>>>>> Android is tagged.
>>>>>>
>>>>>> On Thu, Apr 12, 2012 at 4:36 PM, Jesse <pu...@gmail.com>
>>>>>>wrote:
>>>>>>
>>>>>> > Done
>>>>>> >
>>>>>> > On Thu, Apr 12, 2012 at 4:31 PM, Joe Bowser <bo...@gmail.com>
>>>>>>wrote:
>>>>>> >
>>>>>> > > I'd like to get the JS from the tag, but I need a tag for that.
>>>>>> > >
>>>>>> > > On Thu, Apr 12, 2012 at 4:29 PM, Jesse <pu...@gmail.com>
>>>>>> wrote:
>>>>>> > >
>>>>>> > > > Okay, I think it's good, tagging at 16:32 PDT if i don't hear
>>>>>>any
>>>>>> > > > complaints.
>>>>>> > > >
>>>>>> > > > On Thu, Apr 12, 2012 at 4:26 PM, Filip Maj <fi...@adobe.com>
>>>>>>wrote:
>>>>>> > > >
>>>>>> > > > > I just axed the existing 1.6.1 cordova-js tag
>>>>>> > > > >
>>>>>> > > > > Jesse when you feel you've got everything in there go ahead
>>>>>>and
>>>>>>tag
>>>>>> > JS
>>>>>> > > > >
>>>>>> > > > > On 4/12/12 4:20 PM, "Shazron" <sh...@gmail.com> wrote:
>>>>>> > > > >
>>>>>> > > > > >Reverted. Just talked to Jesse - he has commits to cordova-js
>>>>>> > coming,
>>>>>> > > > > >once those are in we can re-tag cordova-js to 1.6.1
>>>>>> > > > > >
>>>>>> > > > > >On Thu, Apr 12, 2012 at 4:12 PM, Shazron <sh...@gmail.com>
>>>>>> wrote:
>>>>>> > > > > >> I'll remove it. *grabs the shovel*
>>>>>> > > > > >>
>>>>>> > > > > >> On Thu, Apr 12, 2012 at 4:10 PM, Joe Bowser
>>>>>><bo...@gmail.com>
>>>>>> > > > wrote:
>>>>>> > > > > >>> You know, let's not rebase it, because it does modify the
>>>>>> > history.
>>>>>> > > > We
>>>>>> > > > > >>> should remove and document why we did it instead, since
>>>>>>that
>>>>>> > would
>>>>>> > > be
>>>>>> > > > > >>>more
>>>>>> > > > > >>> transparent. Or we could just leave it in and say "don't
>>>>>>do
>>>>>> this
>>>>>> > > next
>>>>>> > > > > >>> time". I'm not that invested in it.
>>>>>> > > > > >>>
>>>>>> > > > > >>> On Thu, Apr 12, 2012 at 4:04 PM, Shazron
>>>>>><sh...@gmail.com>
>>>>>> > > wrote:
>>>>>> > > > > >>>
>>>>>> > > > > >>>> If we take out that iOS commit in cordova-js (somehow),
>>>>>>it
>>>>>> > should
>>>>>> > > be
>>>>>> > > > > >>>> fine. cordova-ios 1.6.1 will then just be the same as
>>>>>>1.6.0.
>>>>>> > > > > >>>>
>>>>>> > > > > >>>> On Thu, Apr 12, 2012 at 4:02 PM, Filip Maj
>>>>>><fi...@adobe.com>
>>>>>> > wrote:
>>>>>> > > > > >>>> >
>>>>>> > > > > >>>> >>Is it too much to drop the new commit that changed the
>>>>>> common
>>>>>> > js
>>>>>> > > > > >>>>API, and
>>>>>> > > > > >>>> >>reapply it after we tag 1.6.1, and figure this one
>>>>>>thing
>>>>>>out
>>>>>> > for
>>>>>> > > > > >>>>1.7?
>>>>>> > > > > >>>> >
>>>>>> > > > > >>>> > That sounds very good to me but I am under the
>>>>>>impression
>>>>>> that
>>>>>> > > iOS
>>>>>> > > > > >>>> > requires this commit? Like I said I'm quite confused.
>>>>>> > > > > >>>> >
>>>>>> > > > > >>>> >>
>>>>>> > > > > >>>> >>I also have some cordova-js commits to add to 1.6.1?
>>>>>> Although
>>>>>> > > > > >>>>nothing
>>>>>> > > > > >>>> that
>>>>>> > > > > >>>> >>modifies any js outside of what is built for wp7. ( ie,
>>>>>>all
>>>>>> in
>>>>>> > > my
>>>>>> > > > > >>>> platform
>>>>>> > > > > >>>> >>specific plugins folder )
>>>>>> > > > > >>>> >>
>>>>>> > > > > >>>> >
>>>>>> > > > > >>>> > O then it sounds like I tagged the JS 1.6.1 too early
>>>>>> > anyways..
>>>>>> > > > > >>>> >
>>>>>> > > > > >>>> >>
>>>>>> > > > > >>>> >>
>>>>>> > > > > >>>> >>
>>>>>> > > > > >>>> >>On Thu, Apr 12, 2012 at 3:51 PM, Shazron
>>>>>><shazron@gmail.com
>>>>>> >
>>>>>> > > > wrote:
>>>>>> > > > > >>>> >>
>>>>>> > > > > >>>> >>> No - it's about a user's contribution being noted (it
>>>>>> > > exists), I
>>>>>> > > > > >>>>will
>>>>>> > > > > >>>> >>> move it out of the common code post-1.6.1 (I
>>>>>>acknowledge
>>>>>> my
>>>>>> > > > > >>>>mistake in
>>>>>> > > > > >>>> >>> allowing it in the first place). Can we branch off
>>>>>>1.6.0
>>>>>> > then
>>>>>> > > > > >>>> >>> cherry-pick Fil's latest fix for 1.6.1?
>>>>>> > > > > >>>> >>>
>>>>>> > > > > >>>> >>> On Thu, Apr 12, 2012 at 3:47 PM, Joe Bowser <
>>>>>> > > bowserj@gmail.com>
>>>>>> > > > > >>>>wrote:
>>>>>> > > > > >>>> >>> > OK, so you're proposing that we leave the thing in
>>>>>>the
>>>>>> > > common
>>>>>> > > > > >>>>JS,
>>>>>> > > > > >>>> even
>>>>>> > > > > >>>> >>> > though it's not supposed to be there.
>>>>>> > > > > >>>> >>> >
>>>>>> > > > > >>>> >>> > On Thu, Apr 12, 2012 at 3:45 PM, Shazron <
>>>>>> > shazron@gmail.com
>>>>>> > > >
>>>>>> > > > > >>>>wrote:
>>>>>> > > > > >>>> >>> >
>>>>>> > > > > >>>> >>> >> Will rebasing lose that commit? Then, no.
>>>>>> > > > > >>>> >>> >>
>>>>>> > > > > >>>> >>> >> On Thu, Apr 12, 2012 at 3:43 PM, Joe Bowser <
>>>>>> > > > bowserj@gmail.com
>>>>>> > > > > >
>>>>>> > > > > >>>> >>>wrote:
>>>>>> > > > > >>>> >>> >> > So, can we just rebase the head, push this out
>>>>>>and
>>>>>> get
>>>>>> > > this
>>>>>> > > > > >>>> >>>rolling?
>>>>>> > > > > >>>> >>> >> >
>>>>>> > > > > >>>> >>> >> > On Thu, Apr 12, 2012 at 3:43 PM, Filip Maj <
>>>>>> > > fil@adobe.com>
>>>>>> > > > > >>>>wrote:
>>>>>> > > > > >>>> >>> >> >
>>>>>> > > > > >>>> >>> >> >> Correct, those iOS-specific parameters (like
>>>>>>allow
>>>>>> > edit
>>>>>> > > > and
>>>>>> > > > > >>>>those
>>>>>> > > > > >>>> >>> ones)
>>>>>> > > > > >>>> >>> >> >> existed prior to cordova-js, so yeah, we left
>>>>>>them
>>>>>> in
>>>>>> > > > there
>>>>>> > > > > >>>>as we
>>>>>> > > > > >>>> >>> didn't
>>>>>> > > > > >>>> >>> >> >> want to remove without deprecation.
>>>>>> > > > > >>>> >>> >> >>
>>>>>> > > > > >>>> >>> >> >> If you can deal with the iOS issue without
>>>>>>needing
>>>>>> an
>>>>>> > > API
>>>>>> > > > > >>>> >>>extension:
>>>>>> > > > > >>>> >>> >> then
>>>>>> > > > > >>>> >>> >> >> do that. If not, leave it in there, but docs
>>>>>>need to
>>>>>> > > > > >>>>updated too.
>>>>>> > > > > >>>> >>> >> >>
>>>>>> > > > > >>>> >>> >> >> Extending and changing the public API is a long
>>>>>>and
>>>>>> > > > > >>>>difficult
>>>>>> > > > > >>>> >>>process
>>>>>> > > > > >>>> >>> >> for
>>>>>> > > > > >>>> >>> >> >> us and will only get tougher with every
>>>>>>platform
>>>>>>we
>>>>>> > add
>>>>>> > > > > >>>>support
>>>>>> > > > > >>>> >>>to.
>>>>>> > > > > >>>> >>> >> >>
>>>>>> > > > > >>>> >>> >> >> On 4/12/12 3:37 PM, "Shazron"
>>>>>><sh...@gmail.com>
>>>>>> > > wrote:
>>>>>> > > > > >>>> >>> >> >>
>>>>>> > > > > >>>> >>> >> >> >Then we have to scrap the other three(?) iOS
>>>>>> > parameters
>>>>>> > > > > >>>>ones
>>>>>> > > > > >>>> that
>>>>>> > > > > >>>> >>> >> >> >already exist in common if you noticed. Don't
>>>>>>know
>>>>>> > how
>>>>>> > > we
>>>>>> > > > > >>>>merge
>>>>>> > > > > >>>> >>> >> >> >(unmerge?) this one properly because taking
>>>>>>those
>>>>>> out
>>>>>> > > > will
>>>>>> > > > > >>>>break
>>>>>> > > > > >>>> >>> >> >> >everyone that is using it, but a deprecation
>>>>>>is
>>>>>>the
>>>>>> > way
>>>>>> > > > to
>>>>>> > > > > >>>>go as
>>>>>> > > > > >>>> >>>per
>>>>>> > > > > >>>> >>> >> >>
>>>>>>>http://wiki.apache.org/cordova/DeprecationPolicy .
>>>>>> > We
>>>>>> > > > can
>>>>>> > > > > >>>> remove
>>>>>> > > > > >>>> >>> this
>>>>>> > > > > >>>> >>> >> >> >new commit and I'll find a way to get this in
>>>>>> > somehow.
>>>>>> > > > > >>>> >>> >> >> >
>>>>>> > > > > >>>> >>> >> >> >
>>>>>> > > > > >>>> >>> >> >> >
>>>>>> > > > > >>>> >>> >> >> >On Thu, Apr 12, 2012 at 3:32 PM, Joe Bowser
>>>>>> > > > > >>>><bo...@gmail.com>
>>>>>> > > > > >>>> >>> wrote:
>>>>>> > > > > >>>> >>> >> >> >> The problem is that this parameter doesn't
>>>>>>belong
>>>>>> > in
>>>>>> > > > the
>>>>>> > > > > >>>> common
>>>>>> > > > > >>>> >>> API.
>>>>>> > > > > >>>> >>> >> >> >>It'd
>>>>>> > > > > >>>> >>> >> >> >> be just ignored in Android, but the whole
>>>>>>point
>>>>>> of
>>>>>> > > > > >>>>cordova-js
>>>>>> > > > > >>>> >>>is
>>>>>> > > > > >>>> >>> so
>>>>>> > > > > >>>> >>> >> that
>>>>>> > > > > >>>> >>> >> >> >> it's common. It'd look pretty screwed up to
>>>>>>add
>>>>>> > this
>>>>>> > > > to
>>>>>> > > > > >>>>the
>>>>>> > > > > >>>> >>>docs,
>>>>>> > > > > >>>> >>> >> IMO.
>>>>>> > > > > >>>> >>> >> >> >>
>>>>>> > > > > >>>> >>> >> >> >> On Thu, Apr 12, 2012 at 3:26 PM, Shazron
>>>>>> > > > > >>>><sh...@gmail.com>
>>>>>> > > > > >>>> >>> wrote:
>>>>>> > > > > >>>> >>> >> >> >>
>>>>>> > > > > >>>> >>> >> >> >>> To fix two bugs for Camera.takePicture on
>>>>>>iOS
>>>>>> > > > > >>>> >>> >> >> >>>
>>>>>> > > > > >>>> >>> >> >> >>> On Thu, Apr 12, 2012 at 3:24 PM, Filip Maj
>>>>>> > > > > >>>><fi...@adobe.com>
>>>>>> > > > > >>>> >>> wrote:
>>>>>> > > > > >>>> >>> >> >> >>> > so what's the point of this new
>>>>>>parameter?
>>>>>> > > > > >>>> >>> >> >> >>> >
>>>>>> > > > > >>>> >>> >> >> >>> > On 4/12/12 3:16 PM, "Shazron" <
>>>>>> > shazron@gmail.com>
>>>>>> > > > > >>>>wrote:
>>>>>> > > > > >>>> >>> >> >> >>> >
>>>>>> > > > > >>>> >>> >> >> >>> >>I did. Do we want to revert the
>>>>>>cordova-js? I
>>>>>> > can
>>>>>> > > > > >>>>branch
>>>>>> > > > > >>>> >>>1.6.0
>>>>>> > > > > >>>> >>> and
>>>>>> > > > > >>>> >>> >> >> >>> >>cherry-pick your latest commit for 1.6.1
>>>>>> > > > > >>>> >>> >> >> >>> >>
>>>>>> > > > > >>>> >>> >> >> >>> >>On Thu, Apr 12, 2012 at 3:04 PM, Filip
>>>>>>Maj
>>>>>> > > > > >>>><fi...@adobe.com>
>>>>>> > > > > >>>> >>> wrote:
>>>>>> > > > > >>>> >>> >> >> >>> >>> I saw something in the iOS commit logs
>>>>>>for
>>>>>> > this.
>>>>>> > > > > >>>> >>> >> >> >>> >>>
>>>>>> > > > > >>>> >>> >> >> >>> >>> Shaz can you comment?
>>>>>> > > > > >>>> >>> >> >> >>> >>>
>>>>>> > > > > >>>> >>> >> >> >>> >>> On 4/12/12 2:59 PM, "Joe Bowser" <
>>>>>> > > > bowserj@gmail.com
>>>>>> > > > > >
>>>>>> > > > > >>>> >>>wrote:
>>>>>> > > > > >>>> >>> >> >> >>> >>>
>>>>>> > > > > >>>> >>> >> >> >>> >>>>Can we revert this, since this looks
>>>>>>like
>>>>>> it's
>>>>>> > > > > >>>>intended
>>>>>> > > > > >>>> >>>for
>>>>>> > > > > >>>> >>> both
>>>>>> > > > > >>>> >>> >> >> >>> Android
>>>>>> > > > > >>>> >>> >> >> >>> >>>>and iOS, but I don't think it should be
>>>>>>in
>>>>>> > > 1.6.1.
>>>>>> > > > > >>>> >>> >> >> >>> >>>>
>>>>>> > > > > >>>> >>> >> >> >>> >>>>On Thu, Apr 12, 2012 at 2:52 PM, Filip
>>>>>>Maj <
>>>>>> > > > > >>>> fil@adobe.com>
>>>>>> > > > > >>>> >>> >> wrote:
>>>>>> > > > > >>>> >>> >> >> >>> >>>>
>>>>>> > > > > >>>> >>> >> >> >>> >>>>> I was actually just looking at that
>>>>>> myself.
>>>>>> > > > > >>>> >>> >> >> >>> >>>>>
>>>>>> > > > > >>>> >>> >> >> >>> >>>>> Looks like it's an iOS-only param..
>>>>>>sigh.
>>>>>> > We
>>>>>> > > > > >>>>gotta
>>>>>> > > > > >>>> stop
>>>>>> > > > > >>>> >>> doing
>>>>>> > > > > >>>> >>> >> >> >>>that,
>>>>>> > > > > >>>> >>> >> >> >>> >>>>> especially if we don't update
>>>>>> documentation.
>>>>>> > > > > >>>> >>> >> >> >>> >>>>>
>>>>>> > > > > >>>> >>> >> >> >>> >>>>> On 4/12/12 2:49 PM, "Joe Bowser"
>>>>>> > > > > >>>><bo...@gmail.com>
>>>>>> > > > > >>>> >>> wrote:
>>>>>> > > > > >>>> >>> >> >> >>> >>>>>
>>>>>> > > > > >>>> >>> >> >> >>> >>>>> >Has anyone tested the cropToSize
>>>>>>param
>>>>>> for
>>>>>> > > > > >>>> >>> Camera.getPicture
>>>>>> > > > > >>>> >>> >> >> >>>yet? I
>>>>>> > > > > >>>> >>> >> >> >>> >>>>> >didn't
>>>>>> > > > > >>>> >>> >> >> >>> >>>>> >notice that change until now.
>>>>>> > > > > >>>> >>> >> >> >>> >>>>> >
>>>>>> > > > > >>>> >>> >> >> >>> >>>>> >On Thu, Apr 12, 2012 at 2:46 PM,
>>>>>>Filip
>>>>>> Maj
>>>>>> > > > > >>>> >>><fil@adobe.com
>>>>>> > > > > >>>> >>> >
>>>>>> > > > > >>>> >>> >> >> >>>wrote:
>>>>>> > > > > >>>> >>> >> >> >>> >>>>> >
>>>>>> > > > > >>>> >>> >> >> >>> >>>>> >> JS tagged 1.6.1 - the build task
>>>>>>in
>>>>>>the
>>>>>> > JS
>>>>>> > > > > >>>>should
>>>>>> > > > > >>>> >>>work
>>>>>> > > > > >>>> >>> >> >> >>>properly
>>>>>> > > > > >>>> >>> >> >> >>> >>>>>now.
>>>>>> > > > > >>>> >>> >> >> >>> >>>>> >>
>>>>>> > > > > >>>> >>> >> >> >>> >>>>> >> FYI if anyone has to modify the
>>>>>>jake
>>>>>> > tasks
>>>>>> > > in
>>>>>> > > > > >>>>the
>>>>>> > > > > >>>> >>>future
>>>>>> > > > > >>>> >>> >> and
>>>>>> > > > > >>>> >>> >> >> >>>make
>>>>>> > > > > >>>> >>> >> >> >>> >>>>>them
>>>>>> > > > > >>>> >>> >> >> >>> >>>>> >> async, make sure you add the 4th
>>>>>> "async"
>>>>>> > > > > >>>>parameter
>>>>>> > > > > >>>> to
>>>>>> > > > > >>>> >>> the
>>>>>> > > > > >>>> >>> >> >> >>>task()
>>>>>> > > > > >>>> >>> >> >> >>> >>>>> >>function
>>>>>> > > > > >>>> >>> >> >> >>> >>>>> >> and set it to true, and call
>>>>>>complete()
>>>>>> > > when
>>>>>> > > > > >>>>the
>>>>>> > > > > >>>> >>>task is
>>>>>> > > > > >>>> >>> >> done.
>>>>>> > > > > >>>> >>> >> >> >>> >>>>> >>
>>>>>> > > > > >>>> >>> >> >> >>> >>>>> >> See
>>>>>> > > > > >>>> >>>
>>>>>>http://howtonode.org/intro-to-jake/async-jakefile.jsfor
>>>>>> > > > > >>>> >>> >> >> >>>an
>>>>>> > > > > >>>> >>> >> >> >>> >>>>> example.
>>>>>> > > > > >>>> >>> >> >> >>> >>>>> >>
>>>>>> > > > > >>>> >>> >> >> >>> >>>>> >> On 4/12/12 2:35 PM, "Joe Bowser"
>>>>>> > > > > >>>><bowserj@gmail.com
>>>>>> > > > > >>>> >
>>>>>> > > > > >>>> >>> >> wrote:
>>>>>> > > > > >>>> >>> >> >> >>> >>>>> >>
>>>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >Ready to tag once cordova-js is
>>>>>>tagged
>>>>>> > > > 1.6.1.
>>>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >
>>>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >On Thu, Apr 12, 2012 at 2:33 PM,
>>>>>>Anis
>>>>>> > > KADRI
>>>>>> > > > <
>>>>>> > > > > >>>> >>> >> >> >>> anis.kadri@gmail.com>
>>>>>> > > > > >>>> >>> >> >> >>> >>>>> >>wrote:
>>>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >
>>>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> I will tag my repository to
>>>>>>1.6.1
>>>>>> > before
>>>>>> > > > > >>>>end of
>>>>>> > > > > >>>> >>>day
>>>>>> > > > > >>>> >>> >> today
>>>>>> > > > > >>>> >>> >> >> >>>after
>>>>>> > > > > >>>> >>> >> >> >>> >>>>>some
>>>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> thorough testing.
>>>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >>
>>>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> On Thu, Apr 12, 2012 at 2:30
>>>>>>PM,
>>>>>> > Shazron
>>>>>> > > > > >>>> >>> >> >> >>><sh...@gmail.com>
>>>>>> > > > > >>>> >>> >> >> >>> >>>>>wrote:
>>>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >>
>>>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > I also created a 1.6.1
>>>>>>version
>>>>>>tag
>>>>>> > as
>>>>>> > > > > >>>>well in
>>>>>> > > > > >>>> >>> jira...
>>>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> >
>>>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > On Thu, Apr 12, 2012 at 2:29
>>>>>>PM,
>>>>>> > > Shazron
>>>>>> > > > > >>>> >>> >> >> >>><sh...@gmail.com>
>>>>>> > > > > >>>> >>> >> >> >>> >>>>> wrote:
>>>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > > Alright guys since 1.6.0
>>>>>>was
>>>>>> > > released,
>>>>>> > > > > >>>>I'm
>>>>>> > > > > >>>> >>>going
>>>>>> > > > > >>>> >>> to
>>>>>> > > > > >>>> >>> >> >> >>> >>>>>"Release"
>>>>>> > > > > >>>> >>> >> >> >>> >>>>>the
>>>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > > 1.6.0 version in jira and
>>>>>>move
>>>>>> > > > > >>>>outstanding
>>>>>> > > > > >>>> >>> issues to
>>>>>> > > > > >>>> >>> >> >> >>>1.7.0
>>>>>> > > > > >>>> >>> >> >> >>> >>>>> >>version
>>>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > > tag.
>>>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >
>>>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >
>>>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > > On Thu, Apr 12, 2012 at
>>>>>>2:26
>>>>>>PM,
>>>>>> > > Filip
>>>>>> > > > > >>>>Maj
>>>>>> > > > > >>>> >>> >> >> >>><fi...@adobe.com>
>>>>>> > > > > >>>> >>> >> >> >>> >>>>> wrote:
>>>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >> The JS needs patching too.
>>>>>> Since
>>>>>> > > > > >>>>adding the
>>>>>> > > > > >>>> >>> commit
>>>>>> > > > > >>>> >>> >> ID
>>>>>> > > > > >>>> >>> >> >> >>>into
>>>>>> > > > > >>>> >>> >> >> >>> >>>>>the
>>>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> packaging
>>>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >> in the jakefile, the
>>>>>>default
>>>>>> task
>>>>>> > > > isn't
>>>>>> > > > > >>>> >>>running
>>>>>> > > > > >>>> >>> >> >> >>>properly.
>>>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>
>>>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >> You can manually run "jake
>>>>>> build"
>>>>>> > > and
>>>>>> > > > > >>>>"jake
>>>>>> > > > > >>>> >>> test"
>>>>>> > > > > >>>> >>> >> but
>>>>>> > > > > >>>> >>> >> >> >>>not
>>>>>> > > > > >>>> >>> >> >> >>> >>>>> >>"jake" on
>>>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> its
>>>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >> own - gonna try to figure
>>>>>>it
>>>>>> out.
>>>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>
>>>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >> On 4/12/12 2:21 PM,
>>>>>>"Shazron" <
>>>>>> > > > > >>>> >>> shazron@gmail.com>
>>>>>> > > > > >>>> >>> >> >> >>>wrote:
>>>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>
>>>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>I'm good with tagging.
>>>>>>iOS
>>>>>> has a
>>>>>> > > few
>>>>>> > > > > >>>> commits
>>>>>> > > > > >>>> >>> (one
>>>>>> > > > > >>>> >>> >> >> >>>commit
>>>>>> > > > > >>>> >>> >> >> >>> >>>>>in
>>>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>cordova-js) as well. Aim
>>>>>>for
>>>>>> > first
>>>>>> > > > > >>>>thing
>>>>>> > > > > >>>> >>> tomorrow
>>>>>> > > > > >>>> >>> >> for
>>>>>> > > > > >>>> >>> >> >> >>>you
>>>>>> > > > > >>>> >>> >> >> >>> >>>>>to
>>>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>repackage?
>>>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>
>>>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>On Thu, Apr 12, 2012 at
>>>>>>2:17
>>>>>> PM,
>>>>>> > > > > >>>>Steven Gill
>>>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >><st...@gmail.com>
>>>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>wrote:
>>>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>> So a bug has been
>>>>>>discovered
>>>>>> in
>>>>>> > > > > >>>>Cordova
>>>>>> > > > > >>>> >>> Android
>>>>>> > > > > >>>> >>> >> that
>>>>>> > > > > >>>> >>> >> >> >>> >>>>>requires
>>>>>> > > > > >>>> >>> >> >> >>> >>>>> >>a
>>>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >>new
>>>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > tag
>>>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>>and
>>>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>> release. You can check
>>>>>>out
>>>>>> the
>>>>>> > > bug
>>>>>> > > > > >>>>on the
>>>>>> > > > > >>>> >>> issue
>>>>>> > > > > >>>> >>> >> >> >>>tracker
>>>>>> > > > > >>>> >>> >> >> >>> >>>>>at
>>>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>>
>>>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>>
>>>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> >
>>>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >>
>>>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >>
>>>>>> > > > > >>>> >>> >> >> >>> >>>>> >>
>>>>>> > > > > >>>> >>> >> >> >>> >>>>> >>
>>>>>> > > > > >>>> >>> >> >> >>> >>>>>
>>>>>> > > > > >>>> >>> >> >> >>> >>>>>
>>>>>> > > > > >>>> >>> >> >> >>>
>>>>>> > > > > >>>> >>> >> >>
>>>>>> > > > > >>>> >>>
>>>>>> > > > > >>>>
>>>>>> > > > > >>>>
>>>>>> > > > >
>>>>>> > >
>>>>>>
>>>>>>https://issues.apache.org/jira/browse/CB-490?focusedCommentId=13252809#
>>>>>> > > > > >>>> >>> >> >> >>> >>>>>co
>>>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>>mment-13252809
>>>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>>
>>>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>> It doesn't make sense to
>>>>>>just
>>>>>> > > > > >>>>repackage
>>>>>> > > > > >>>> >>>1.6.0
>>>>>> > > > > >>>> >>> >> with
>>>>>> > > > > >>>> >>> >> >> >>>this
>>>>>> > > > > >>>> >>> >> >> >>> >>>>>bug
>>>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >>fixed as
>>>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > we
>>>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>> will have no way to know
>>>>>>if
>>>>>> > > people
>>>>>> > > > > >>>>are
>>>>>> > > > > >>>> >>> >> experiencing
>>>>>> > > > > >>>> >>> >> >> >>>this
>>>>>> > > > > >>>> >>> >> >> >>> >>>>>or
>>>>>> > > > > >>>> >>> >> >> >>> >>>>> >>not.
>>>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>>
>>>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>> Anis mentioned Bada also
>>>>>>had
>>>>>> > some
>>>>>> > > > > >>>>major
>>>>>> > > > > >>>> >>>issues
>>>>>> > > > > >>>> >>> >> >> >>>which he
>>>>>> > > > > >>>> >>> >> >> >>> >>>>>has
>>>>>> > > > > >>>> >>> >> >> >>> >>>>> >>fixed
>>>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> now
>>>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>>and
>>>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>> would like in a 1.6.1
>>>>>> release.
>>>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>>
>>>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>> Thoughts?
>>>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>>
>>>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>> -Steve
>>>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>
>>>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> >
>>>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >>
>>>>>> > > > > >>>> >>> >> >> >>> >>>>> >>
>>>>>> > > > > >>>> >>> >> >> >>> >>>>> >>
>>>>>> > > > > >>>> >>> >> >> >>> >>>>>
>>>>>> > > > > >>>> >>> >> >> >>> >>>>>
>>>>>> > > > > >>>> >>> >> >> >>> >>>
>>>>>> > > > > >>>> >>> >> >> >>> >
>>>>>> > > > > >>>> >>> >> >> >>>
>>>>>> > > > > >>>> >>> >> >>
>>>>>> > > > > >>>> >>> >> >>
>>>>>> > > > > >>>> >>> >>
>>>>>> > > > > >>>> >>>
>>>>>> > > > > >>>> >
>>>>>> > > > > >>>>
>>>>>> > > > >
>>>>>> > > > >
>>>>>> > > >
>>>>>> > >
>>>>>> >
>>>>>>
>>>>
>>
Re: 1.6.1
Posted by Shazron <sh...@gmail.com>.
Logic error - no worries, I patched it (going to re-do 1.6.1 iOS)
On Thu, Apr 12, 2012 at 5:27 PM, Filip Maj <fi...@adobe.com> wrote:
> Did I f that up?
>
> On 4/12/12 5:07 PM, "Shazron" <sh...@gmail.com> wrote:
>
>>Sigh - user reported iOS bug
>>http://groups.google.com/group/phonegap/browse_thread/thread/faad0af97dec8
>>907
>>(you know who you are ;)
>>
>>On Thu, Apr 12, 2012 at 5:05 PM, Filip Maj <fi...@adobe.com> wrote:
>>> Saweet! Nice work Anis. That kills off a bunch of old issues in JIRA
>>>too.
>>>
>>> Way to hunker down all. As Jesse pointed out to me, we did 45 emails in
>>> two hours haha
>>>
>>> On 4/12/12 5:00 PM, "Anis KADRI" <an...@gmail.com> wrote:
>>>
>>>>Bada 1.2 is tagged 1.6.1. I added the new Cordova artwork,
>>>>LICENSE/NOTICE
>>>>files as well as the Apache source headers in every source file. I fixed
>>>>all the bugs I sawS
>>>>
>>>>On Thu, Apr 12, 2012 at 4:38 PM, Joe Bowser <bo...@gmail.com> wrote:
>>>>
>>>>> Android is tagged.
>>>>>
>>>>> On Thu, Apr 12, 2012 at 4:36 PM, Jesse <pu...@gmail.com>
>>>>>wrote:
>>>>>
>>>>> > Done
>>>>> >
>>>>> > On Thu, Apr 12, 2012 at 4:31 PM, Joe Bowser <bo...@gmail.com>
>>>>>wrote:
>>>>> >
>>>>> > > I'd like to get the JS from the tag, but I need a tag for that.
>>>>> > >
>>>>> > > On Thu, Apr 12, 2012 at 4:29 PM, Jesse <pu...@gmail.com>
>>>>> wrote:
>>>>> > >
>>>>> > > > Okay, I think it's good, tagging at 16:32 PDT if i don't hear
>>>>>any
>>>>> > > > complaints.
>>>>> > > >
>>>>> > > > On Thu, Apr 12, 2012 at 4:26 PM, Filip Maj <fi...@adobe.com>
>>>>>wrote:
>>>>> > > >
>>>>> > > > > I just axed the existing 1.6.1 cordova-js tag
>>>>> > > > >
>>>>> > > > > Jesse when you feel you've got everything in there go ahead
>>>>>and
>>>>>tag
>>>>> > JS
>>>>> > > > >
>>>>> > > > > On 4/12/12 4:20 PM, "Shazron" <sh...@gmail.com> wrote:
>>>>> > > > >
>>>>> > > > > >Reverted. Just talked to Jesse - he has commits to cordova-js
>>>>> > coming,
>>>>> > > > > >once those are in we can re-tag cordova-js to 1.6.1
>>>>> > > > > >
>>>>> > > > > >On Thu, Apr 12, 2012 at 4:12 PM, Shazron <sh...@gmail.com>
>>>>> wrote:
>>>>> > > > > >> I'll remove it. *grabs the shovel*
>>>>> > > > > >>
>>>>> > > > > >> On Thu, Apr 12, 2012 at 4:10 PM, Joe Bowser
>>>>><bo...@gmail.com>
>>>>> > > > wrote:
>>>>> > > > > >>> You know, let's not rebase it, because it does modify the
>>>>> > history.
>>>>> > > > We
>>>>> > > > > >>> should remove and document why we did it instead, since
>>>>>that
>>>>> > would
>>>>> > > be
>>>>> > > > > >>>more
>>>>> > > > > >>> transparent. Or we could just leave it in and say "don't
>>>>>do
>>>>> this
>>>>> > > next
>>>>> > > > > >>> time". I'm not that invested in it.
>>>>> > > > > >>>
>>>>> > > > > >>> On Thu, Apr 12, 2012 at 4:04 PM, Shazron
>>>>><sh...@gmail.com>
>>>>> > > wrote:
>>>>> > > > > >>>
>>>>> > > > > >>>> If we take out that iOS commit in cordova-js (somehow),
>>>>>it
>>>>> > should
>>>>> > > be
>>>>> > > > > >>>> fine. cordova-ios 1.6.1 will then just be the same as
>>>>>1.6.0.
>>>>> > > > > >>>>
>>>>> > > > > >>>> On Thu, Apr 12, 2012 at 4:02 PM, Filip Maj
>>>>><fi...@adobe.com>
>>>>> > wrote:
>>>>> > > > > >>>> >
>>>>> > > > > >>>> >>Is it too much to drop the new commit that changed the
>>>>> common
>>>>> > js
>>>>> > > > > >>>>API, and
>>>>> > > > > >>>> >>reapply it after we tag 1.6.1, and figure this one
>>>>>thing
>>>>>out
>>>>> > for
>>>>> > > > > >>>>1.7?
>>>>> > > > > >>>> >
>>>>> > > > > >>>> > That sounds very good to me but I am under the
>>>>>impression
>>>>> that
>>>>> > > iOS
>>>>> > > > > >>>> > requires this commit? Like I said I'm quite confused.
>>>>> > > > > >>>> >
>>>>> > > > > >>>> >>
>>>>> > > > > >>>> >>I also have some cordova-js commits to add to 1.6.1?
>>>>> Although
>>>>> > > > > >>>>nothing
>>>>> > > > > >>>> that
>>>>> > > > > >>>> >>modifies any js outside of what is built for wp7. ( ie,
>>>>>all
>>>>> in
>>>>> > > my
>>>>> > > > > >>>> platform
>>>>> > > > > >>>> >>specific plugins folder )
>>>>> > > > > >>>> >>
>>>>> > > > > >>>> >
>>>>> > > > > >>>> > O then it sounds like I tagged the JS 1.6.1 too early
>>>>> > anyways..
>>>>> > > > > >>>> >
>>>>> > > > > >>>> >>
>>>>> > > > > >>>> >>
>>>>> > > > > >>>> >>
>>>>> > > > > >>>> >>On Thu, Apr 12, 2012 at 3:51 PM, Shazron
>>>>><shazron@gmail.com
>>>>> >
>>>>> > > > wrote:
>>>>> > > > > >>>> >>
>>>>> > > > > >>>> >>> No - it's about a user's contribution being noted (it
>>>>> > > exists), I
>>>>> > > > > >>>>will
>>>>> > > > > >>>> >>> move it out of the common code post-1.6.1 (I
>>>>>acknowledge
>>>>> my
>>>>> > > > > >>>>mistake in
>>>>> > > > > >>>> >>> allowing it in the first place). Can we branch off
>>>>>1.6.0
>>>>> > then
>>>>> > > > > >>>> >>> cherry-pick Fil's latest fix for 1.6.1?
>>>>> > > > > >>>> >>>
>>>>> > > > > >>>> >>> On Thu, Apr 12, 2012 at 3:47 PM, Joe Bowser <
>>>>> > > bowserj@gmail.com>
>>>>> > > > > >>>>wrote:
>>>>> > > > > >>>> >>> > OK, so you're proposing that we leave the thing in
>>>>>the
>>>>> > > common
>>>>> > > > > >>>>JS,
>>>>> > > > > >>>> even
>>>>> > > > > >>>> >>> > though it's not supposed to be there.
>>>>> > > > > >>>> >>> >
>>>>> > > > > >>>> >>> > On Thu, Apr 12, 2012 at 3:45 PM, Shazron <
>>>>> > shazron@gmail.com
>>>>> > > >
>>>>> > > > > >>>>wrote:
>>>>> > > > > >>>> >>> >
>>>>> > > > > >>>> >>> >> Will rebasing lose that commit? Then, no.
>>>>> > > > > >>>> >>> >>
>>>>> > > > > >>>> >>> >> On Thu, Apr 12, 2012 at 3:43 PM, Joe Bowser <
>>>>> > > > bowserj@gmail.com
>>>>> > > > > >
>>>>> > > > > >>>> >>>wrote:
>>>>> > > > > >>>> >>> >> > So, can we just rebase the head, push this out
>>>>>and
>>>>> get
>>>>> > > this
>>>>> > > > > >>>> >>>rolling?
>>>>> > > > > >>>> >>> >> >
>>>>> > > > > >>>> >>> >> > On Thu, Apr 12, 2012 at 3:43 PM, Filip Maj <
>>>>> > > fil@adobe.com>
>>>>> > > > > >>>>wrote:
>>>>> > > > > >>>> >>> >> >
>>>>> > > > > >>>> >>> >> >> Correct, those iOS-specific parameters (like
>>>>>allow
>>>>> > edit
>>>>> > > > and
>>>>> > > > > >>>>those
>>>>> > > > > >>>> >>> ones)
>>>>> > > > > >>>> >>> >> >> existed prior to cordova-js, so yeah, we left
>>>>>them
>>>>> in
>>>>> > > > there
>>>>> > > > > >>>>as we
>>>>> > > > > >>>> >>> didn't
>>>>> > > > > >>>> >>> >> >> want to remove without deprecation.
>>>>> > > > > >>>> >>> >> >>
>>>>> > > > > >>>> >>> >> >> If you can deal with the iOS issue without
>>>>>needing
>>>>> an
>>>>> > > API
>>>>> > > > > >>>> >>>extension:
>>>>> > > > > >>>> >>> >> then
>>>>> > > > > >>>> >>> >> >> do that. If not, leave it in there, but docs
>>>>>need to
>>>>> > > > > >>>>updated too.
>>>>> > > > > >>>> >>> >> >>
>>>>> > > > > >>>> >>> >> >> Extending and changing the public API is a long
>>>>>and
>>>>> > > > > >>>>difficult
>>>>> > > > > >>>> >>>process
>>>>> > > > > >>>> >>> >> for
>>>>> > > > > >>>> >>> >> >> us and will only get tougher with every
>>>>>platform
>>>>>we
>>>>> > add
>>>>> > > > > >>>>support
>>>>> > > > > >>>> >>>to.
>>>>> > > > > >>>> >>> >> >>
>>>>> > > > > >>>> >>> >> >> On 4/12/12 3:37 PM, "Shazron"
>>>>><sh...@gmail.com>
>>>>> > > wrote:
>>>>> > > > > >>>> >>> >> >>
>>>>> > > > > >>>> >>> >> >> >Then we have to scrap the other three(?) iOS
>>>>> > parameters
>>>>> > > > > >>>>ones
>>>>> > > > > >>>> that
>>>>> > > > > >>>> >>> >> >> >already exist in common if you noticed. Don't
>>>>>know
>>>>> > how
>>>>> > > we
>>>>> > > > > >>>>merge
>>>>> > > > > >>>> >>> >> >> >(unmerge?) this one properly because taking
>>>>>those
>>>>> out
>>>>> > > > will
>>>>> > > > > >>>>break
>>>>> > > > > >>>> >>> >> >> >everyone that is using it, but a deprecation
>>>>>is
>>>>>the
>>>>> > way
>>>>> > > > to
>>>>> > > > > >>>>go as
>>>>> > > > > >>>> >>>per
>>>>> > > > > >>>> >>> >> >>
>>>>>>http://wiki.apache.org/cordova/DeprecationPolicy .
>>>>> > We
>>>>> > > > can
>>>>> > > > > >>>> remove
>>>>> > > > > >>>> >>> this
>>>>> > > > > >>>> >>> >> >> >new commit and I'll find a way to get this in
>>>>> > somehow.
>>>>> > > > > >>>> >>> >> >> >
>>>>> > > > > >>>> >>> >> >> >
>>>>> > > > > >>>> >>> >> >> >
>>>>> > > > > >>>> >>> >> >> >On Thu, Apr 12, 2012 at 3:32 PM, Joe Bowser
>>>>> > > > > >>>><bo...@gmail.com>
>>>>> > > > > >>>> >>> wrote:
>>>>> > > > > >>>> >>> >> >> >> The problem is that this parameter doesn't
>>>>>belong
>>>>> > in
>>>>> > > > the
>>>>> > > > > >>>> common
>>>>> > > > > >>>> >>> API.
>>>>> > > > > >>>> >>> >> >> >>It'd
>>>>> > > > > >>>> >>> >> >> >> be just ignored in Android, but the whole
>>>>>point
>>>>> of
>>>>> > > > > >>>>cordova-js
>>>>> > > > > >>>> >>>is
>>>>> > > > > >>>> >>> so
>>>>> > > > > >>>> >>> >> that
>>>>> > > > > >>>> >>> >> >> >> it's common. It'd look pretty screwed up to
>>>>>add
>>>>> > this
>>>>> > > > to
>>>>> > > > > >>>>the
>>>>> > > > > >>>> >>>docs,
>>>>> > > > > >>>> >>> >> IMO.
>>>>> > > > > >>>> >>> >> >> >>
>>>>> > > > > >>>> >>> >> >> >> On Thu, Apr 12, 2012 at 3:26 PM, Shazron
>>>>> > > > > >>>><sh...@gmail.com>
>>>>> > > > > >>>> >>> wrote:
>>>>> > > > > >>>> >>> >> >> >>
>>>>> > > > > >>>> >>> >> >> >>> To fix two bugs for Camera.takePicture on
>>>>>iOS
>>>>> > > > > >>>> >>> >> >> >>>
>>>>> > > > > >>>> >>> >> >> >>> On Thu, Apr 12, 2012 at 3:24 PM, Filip Maj
>>>>> > > > > >>>><fi...@adobe.com>
>>>>> > > > > >>>> >>> wrote:
>>>>> > > > > >>>> >>> >> >> >>> > so what's the point of this new
>>>>>parameter?
>>>>> > > > > >>>> >>> >> >> >>> >
>>>>> > > > > >>>> >>> >> >> >>> > On 4/12/12 3:16 PM, "Shazron" <
>>>>> > shazron@gmail.com>
>>>>> > > > > >>>>wrote:
>>>>> > > > > >>>> >>> >> >> >>> >
>>>>> > > > > >>>> >>> >> >> >>> >>I did. Do we want to revert the
>>>>>cordova-js? I
>>>>> > can
>>>>> > > > > >>>>branch
>>>>> > > > > >>>> >>>1.6.0
>>>>> > > > > >>>> >>> and
>>>>> > > > > >>>> >>> >> >> >>> >>cherry-pick your latest commit for 1.6.1
>>>>> > > > > >>>> >>> >> >> >>> >>
>>>>> > > > > >>>> >>> >> >> >>> >>On Thu, Apr 12, 2012 at 3:04 PM, Filip
>>>>>Maj
>>>>> > > > > >>>><fi...@adobe.com>
>>>>> > > > > >>>> >>> wrote:
>>>>> > > > > >>>> >>> >> >> >>> >>> I saw something in the iOS commit logs
>>>>>for
>>>>> > this.
>>>>> > > > > >>>> >>> >> >> >>> >>>
>>>>> > > > > >>>> >>> >> >> >>> >>> Shaz can you comment?
>>>>> > > > > >>>> >>> >> >> >>> >>>
>>>>> > > > > >>>> >>> >> >> >>> >>> On 4/12/12 2:59 PM, "Joe Bowser" <
>>>>> > > > bowserj@gmail.com
>>>>> > > > > >
>>>>> > > > > >>>> >>>wrote:
>>>>> > > > > >>>> >>> >> >> >>> >>>
>>>>> > > > > >>>> >>> >> >> >>> >>>>Can we revert this, since this looks
>>>>>like
>>>>> it's
>>>>> > > > > >>>>intended
>>>>> > > > > >>>> >>>for
>>>>> > > > > >>>> >>> both
>>>>> > > > > >>>> >>> >> >> >>> Android
>>>>> > > > > >>>> >>> >> >> >>> >>>>and iOS, but I don't think it should be
>>>>>in
>>>>> > > 1.6.1.
>>>>> > > > > >>>> >>> >> >> >>> >>>>
>>>>> > > > > >>>> >>> >> >> >>> >>>>On Thu, Apr 12, 2012 at 2:52 PM, Filip
>>>>>Maj <
>>>>> > > > > >>>> fil@adobe.com>
>>>>> > > > > >>>> >>> >> wrote:
>>>>> > > > > >>>> >>> >> >> >>> >>>>
>>>>> > > > > >>>> >>> >> >> >>> >>>>> I was actually just looking at that
>>>>> myself.
>>>>> > > > > >>>> >>> >> >> >>> >>>>>
>>>>> > > > > >>>> >>> >> >> >>> >>>>> Looks like it's an iOS-only param..
>>>>>sigh.
>>>>> > We
>>>>> > > > > >>>>gotta
>>>>> > > > > >>>> stop
>>>>> > > > > >>>> >>> doing
>>>>> > > > > >>>> >>> >> >> >>>that,
>>>>> > > > > >>>> >>> >> >> >>> >>>>> especially if we don't update
>>>>> documentation.
>>>>> > > > > >>>> >>> >> >> >>> >>>>>
>>>>> > > > > >>>> >>> >> >> >>> >>>>> On 4/12/12 2:49 PM, "Joe Bowser"
>>>>> > > > > >>>><bo...@gmail.com>
>>>>> > > > > >>>> >>> wrote:
>>>>> > > > > >>>> >>> >> >> >>> >>>>>
>>>>> > > > > >>>> >>> >> >> >>> >>>>> >Has anyone tested the cropToSize
>>>>>param
>>>>> for
>>>>> > > > > >>>> >>> Camera.getPicture
>>>>> > > > > >>>> >>> >> >> >>>yet? I
>>>>> > > > > >>>> >>> >> >> >>> >>>>> >didn't
>>>>> > > > > >>>> >>> >> >> >>> >>>>> >notice that change until now.
>>>>> > > > > >>>> >>> >> >> >>> >>>>> >
>>>>> > > > > >>>> >>> >> >> >>> >>>>> >On Thu, Apr 12, 2012 at 2:46 PM,
>>>>>Filip
>>>>> Maj
>>>>> > > > > >>>> >>><fil@adobe.com
>>>>> > > > > >>>> >>> >
>>>>> > > > > >>>> >>> >> >> >>>wrote:
>>>>> > > > > >>>> >>> >> >> >>> >>>>> >
>>>>> > > > > >>>> >>> >> >> >>> >>>>> >> JS tagged 1.6.1 - the build task
>>>>>in
>>>>>the
>>>>> > JS
>>>>> > > > > >>>>should
>>>>> > > > > >>>> >>>work
>>>>> > > > > >>>> >>> >> >> >>>properly
>>>>> > > > > >>>> >>> >> >> >>> >>>>>now.
>>>>> > > > > >>>> >>> >> >> >>> >>>>> >>
>>>>> > > > > >>>> >>> >> >> >>> >>>>> >> FYI if anyone has to modify the
>>>>>jake
>>>>> > tasks
>>>>> > > in
>>>>> > > > > >>>>the
>>>>> > > > > >>>> >>>future
>>>>> > > > > >>>> >>> >> and
>>>>> > > > > >>>> >>> >> >> >>>make
>>>>> > > > > >>>> >>> >> >> >>> >>>>>them
>>>>> > > > > >>>> >>> >> >> >>> >>>>> >> async, make sure you add the 4th
>>>>> "async"
>>>>> > > > > >>>>parameter
>>>>> > > > > >>>> to
>>>>> > > > > >>>> >>> the
>>>>> > > > > >>>> >>> >> >> >>>task()
>>>>> > > > > >>>> >>> >> >> >>> >>>>> >>function
>>>>> > > > > >>>> >>> >> >> >>> >>>>> >> and set it to true, and call
>>>>>complete()
>>>>> > > when
>>>>> > > > > >>>>the
>>>>> > > > > >>>> >>>task is
>>>>> > > > > >>>> >>> >> done.
>>>>> > > > > >>>> >>> >> >> >>> >>>>> >>
>>>>> > > > > >>>> >>> >> >> >>> >>>>> >> See
>>>>> > > > > >>>> >>>
>>>>>http://howtonode.org/intro-to-jake/async-jakefile.jsfor
>>>>> > > > > >>>> >>> >> >> >>>an
>>>>> > > > > >>>> >>> >> >> >>> >>>>> example.
>>>>> > > > > >>>> >>> >> >> >>> >>>>> >>
>>>>> > > > > >>>> >>> >> >> >>> >>>>> >> On 4/12/12 2:35 PM, "Joe Bowser"
>>>>> > > > > >>>><bowserj@gmail.com
>>>>> > > > > >>>> >
>>>>> > > > > >>>> >>> >> wrote:
>>>>> > > > > >>>> >>> >> >> >>> >>>>> >>
>>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >Ready to tag once cordova-js is
>>>>>tagged
>>>>> > > > 1.6.1.
>>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >
>>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >On Thu, Apr 12, 2012 at 2:33 PM,
>>>>>Anis
>>>>> > > KADRI
>>>>> > > > <
>>>>> > > > > >>>> >>> >> >> >>> anis.kadri@gmail.com>
>>>>> > > > > >>>> >>> >> >> >>> >>>>> >>wrote:
>>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >
>>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> I will tag my repository to
>>>>>1.6.1
>>>>> > before
>>>>> > > > > >>>>end of
>>>>> > > > > >>>> >>>day
>>>>> > > > > >>>> >>> >> today
>>>>> > > > > >>>> >>> >> >> >>>after
>>>>> > > > > >>>> >>> >> >> >>> >>>>>some
>>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> thorough testing.
>>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >>
>>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> On Thu, Apr 12, 2012 at 2:30
>>>>>PM,
>>>>> > Shazron
>>>>> > > > > >>>> >>> >> >> >>><sh...@gmail.com>
>>>>> > > > > >>>> >>> >> >> >>> >>>>>wrote:
>>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >>
>>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > I also created a 1.6.1
>>>>>version
>>>>>tag
>>>>> > as
>>>>> > > > > >>>>well in
>>>>> > > > > >>>> >>> jira...
>>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> >
>>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > On Thu, Apr 12, 2012 at 2:29
>>>>>PM,
>>>>> > > Shazron
>>>>> > > > > >>>> >>> >> >> >>><sh...@gmail.com>
>>>>> > > > > >>>> >>> >> >> >>> >>>>> wrote:
>>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > > Alright guys since 1.6.0
>>>>>was
>>>>> > > released,
>>>>> > > > > >>>>I'm
>>>>> > > > > >>>> >>>going
>>>>> > > > > >>>> >>> to
>>>>> > > > > >>>> >>> >> >> >>> >>>>>"Release"
>>>>> > > > > >>>> >>> >> >> >>> >>>>>the
>>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > > 1.6.0 version in jira and
>>>>>move
>>>>> > > > > >>>>outstanding
>>>>> > > > > >>>> >>> issues to
>>>>> > > > > >>>> >>> >> >> >>>1.7.0
>>>>> > > > > >>>> >>> >> >> >>> >>>>> >>version
>>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > > tag.
>>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >
>>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >
>>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > > On Thu, Apr 12, 2012 at
>>>>>2:26
>>>>>PM,
>>>>> > > Filip
>>>>> > > > > >>>>Maj
>>>>> > > > > >>>> >>> >> >> >>><fi...@adobe.com>
>>>>> > > > > >>>> >>> >> >> >>> >>>>> wrote:
>>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >> The JS needs patching too.
>>>>> Since
>>>>> > > > > >>>>adding the
>>>>> > > > > >>>> >>> commit
>>>>> > > > > >>>> >>> >> ID
>>>>> > > > > >>>> >>> >> >> >>>into
>>>>> > > > > >>>> >>> >> >> >>> >>>>>the
>>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> packaging
>>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >> in the jakefile, the
>>>>>default
>>>>> task
>>>>> > > > isn't
>>>>> > > > > >>>> >>>running
>>>>> > > > > >>>> >>> >> >> >>>properly.
>>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>
>>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >> You can manually run "jake
>>>>> build"
>>>>> > > and
>>>>> > > > > >>>>"jake
>>>>> > > > > >>>> >>> test"
>>>>> > > > > >>>> >>> >> but
>>>>> > > > > >>>> >>> >> >> >>>not
>>>>> > > > > >>>> >>> >> >> >>> >>>>> >>"jake" on
>>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> its
>>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >> own - gonna try to figure
>>>>>it
>>>>> out.
>>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>
>>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >> On 4/12/12 2:21 PM,
>>>>>"Shazron" <
>>>>> > > > > >>>> >>> shazron@gmail.com>
>>>>> > > > > >>>> >>> >> >> >>>wrote:
>>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>
>>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>I'm good with tagging.
>>>>>iOS
>>>>> has a
>>>>> > > few
>>>>> > > > > >>>> commits
>>>>> > > > > >>>> >>> (one
>>>>> > > > > >>>> >>> >> >> >>>commit
>>>>> > > > > >>>> >>> >> >> >>> >>>>>in
>>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>cordova-js) as well. Aim
>>>>>for
>>>>> > first
>>>>> > > > > >>>>thing
>>>>> > > > > >>>> >>> tomorrow
>>>>> > > > > >>>> >>> >> for
>>>>> > > > > >>>> >>> >> >> >>>you
>>>>> > > > > >>>> >>> >> >> >>> >>>>>to
>>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>repackage?
>>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>
>>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>On Thu, Apr 12, 2012 at
>>>>>2:17
>>>>> PM,
>>>>> > > > > >>>>Steven Gill
>>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >><st...@gmail.com>
>>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>wrote:
>>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>> So a bug has been
>>>>>discovered
>>>>> in
>>>>> > > > > >>>>Cordova
>>>>> > > > > >>>> >>> Android
>>>>> > > > > >>>> >>> >> that
>>>>> > > > > >>>> >>> >> >> >>> >>>>>requires
>>>>> > > > > >>>> >>> >> >> >>> >>>>> >>a
>>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >>new
>>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > tag
>>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>>and
>>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>> release. You can check
>>>>>out
>>>>> the
>>>>> > > bug
>>>>> > > > > >>>>on the
>>>>> > > > > >>>> >>> issue
>>>>> > > > > >>>> >>> >> >> >>>tracker
>>>>> > > > > >>>> >>> >> >> >>> >>>>>at
>>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>>
>>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>>
>>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> >
>>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >>
>>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >>
>>>>> > > > > >>>> >>> >> >> >>> >>>>> >>
>>>>> > > > > >>>> >>> >> >> >>> >>>>> >>
>>>>> > > > > >>>> >>> >> >> >>> >>>>>
>>>>> > > > > >>>> >>> >> >> >>> >>>>>
>>>>> > > > > >>>> >>> >> >> >>>
>>>>> > > > > >>>> >>> >> >>
>>>>> > > > > >>>> >>>
>>>>> > > > > >>>>
>>>>> > > > > >>>>
>>>>> > > > >
>>>>> > >
>>>>>
>>>>>https://issues.apache.org/jira/browse/CB-490?focusedCommentId=13252809#
>>>>> > > > > >>>> >>> >> >> >>> >>>>>co
>>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>>mment-13252809
>>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>>
>>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>> It doesn't make sense to
>>>>>just
>>>>> > > > > >>>>repackage
>>>>> > > > > >>>> >>>1.6.0
>>>>> > > > > >>>> >>> >> with
>>>>> > > > > >>>> >>> >> >> >>>this
>>>>> > > > > >>>> >>> >> >> >>> >>>>>bug
>>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >>fixed as
>>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > we
>>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>> will have no way to know
>>>>>if
>>>>> > > people
>>>>> > > > > >>>>are
>>>>> > > > > >>>> >>> >> experiencing
>>>>> > > > > >>>> >>> >> >> >>>this
>>>>> > > > > >>>> >>> >> >> >>> >>>>>or
>>>>> > > > > >>>> >>> >> >> >>> >>>>> >>not.
>>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>>
>>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>> Anis mentioned Bada also
>>>>>had
>>>>> > some
>>>>> > > > > >>>>major
>>>>> > > > > >>>> >>>issues
>>>>> > > > > >>>> >>> >> >> >>>which he
>>>>> > > > > >>>> >>> >> >> >>> >>>>>has
>>>>> > > > > >>>> >>> >> >> >>> >>>>> >>fixed
>>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> now
>>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>>and
>>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>> would like in a 1.6.1
>>>>> release.
>>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>>
>>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>> Thoughts?
>>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>>
>>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>> -Steve
>>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>
>>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> >
>>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >>
>>>>> > > > > >>>> >>> >> >> >>> >>>>> >>
>>>>> > > > > >>>> >>> >> >> >>> >>>>> >>
>>>>> > > > > >>>> >>> >> >> >>> >>>>>
>>>>> > > > > >>>> >>> >> >> >>> >>>>>
>>>>> > > > > >>>> >>> >> >> >>> >>>
>>>>> > > > > >>>> >>> >> >> >>> >
>>>>> > > > > >>>> >>> >> >> >>>
>>>>> > > > > >>>> >>> >> >>
>>>>> > > > > >>>> >>> >> >>
>>>>> > > > > >>>> >>> >>
>>>>> > > > > >>>> >>>
>>>>> > > > > >>>> >
>>>>> > > > > >>>>
>>>>> > > > >
>>>>> > > > >
>>>>> > > >
>>>>> > >
>>>>> >
>>>>>
>>>
>
RE: 1.6.1
Posted by Herm Wong <he...@hotmail.com>.
webos tagged 1.6.1
> From: shazron@gmail.com
> Date: Thu, 12 Apr 2012 17:11:08 -0700
> Subject: Re: 1.6.1
> To: callback-dev@incubator.apache.org
>
> https://issues.apache.org/jira/browse/CB-496
>
> On Thu, Apr 12, 2012 at 5:07 PM, Shazron <sh...@gmail.com> wrote:
> > Sigh - user reported iOS bug
> > http://groups.google.com/group/phonegap/browse_thread/thread/faad0af97dec8907
> > (you know who you are ;)
> >
> > On Thu, Apr 12, 2012 at 5:05 PM, Filip Maj <fi...@adobe.com> wrote:
> >> Saweet! Nice work Anis. That kills off a bunch of old issues in JIRA too.
> >>
> >> Way to hunker down all. As Jesse pointed out to me, we did 45 emails in
> >> two hours haha
> >>
> >> On 4/12/12 5:00 PM, "Anis KADRI" <an...@gmail.com> wrote:
> >>
> >>>Bada 1.2 is tagged 1.6.1. I added the new Cordova artwork, LICENSE/NOTICE
> >>>files as well as the Apache source headers in every source file. I fixed
> >>>all the bugs I sawS
> >>>
> >>>On Thu, Apr 12, 2012 at 4:38 PM, Joe Bowser <bo...@gmail.com> wrote:
> >>>
> >>>> Android is tagged.
> >>>>
> >>>> On Thu, Apr 12, 2012 at 4:36 PM, Jesse <pu...@gmail.com> wrote:
> >>>>
> >>>> > Done
> >>>> >
> >>>> > On Thu, Apr 12, 2012 at 4:31 PM, Joe Bowser <bo...@gmail.com> wrote:
> >>>> >
> >>>> > > I'd like to get the JS from the tag, but I need a tag for that.
> >>>> > >
> >>>> > > On Thu, Apr 12, 2012 at 4:29 PM, Jesse <pu...@gmail.com>
> >>>> wrote:
> >>>> > >
> >>>> > > > Okay, I think it's good, tagging at 16:32 PDT if i don't hear any
> >>>> > > > complaints.
> >>>> > > >
> >>>> > > > On Thu, Apr 12, 2012 at 4:26 PM, Filip Maj <fi...@adobe.com> wrote:
> >>>> > > >
> >>>> > > > > I just axed the existing 1.6.1 cordova-js tag
> >>>> > > > >
> >>>> > > > > Jesse when you feel you've got everything in there go ahead and
> >>>>tag
> >>>> > JS
> >>>> > > > >
> >>>> > > > > On 4/12/12 4:20 PM, "Shazron" <sh...@gmail.com> wrote:
> >>>> > > > >
> >>>> > > > > >Reverted. Just talked to Jesse - he has commits to cordova-js
> >>>> > coming,
> >>>> > > > > >once those are in we can re-tag cordova-js to 1.6.1
> >>>> > > > > >
> >>>> > > > > >On Thu, Apr 12, 2012 at 4:12 PM, Shazron <sh...@gmail.com>
> >>>> wrote:
> >>>> > > > > >> I'll remove it. *grabs the shovel*
> >>>> > > > > >>
> >>>> > > > > >> On Thu, Apr 12, 2012 at 4:10 PM, Joe Bowser
> >>>><bo...@gmail.com>
> >>>> > > > wrote:
> >>>> > > > > >>> You know, let's not rebase it, because it does modify the
> >>>> > history.
> >>>> > > > We
> >>>> > > > > >>> should remove and document why we did it instead, since that
> >>>> > would
> >>>> > > be
> >>>> > > > > >>>more
> >>>> > > > > >>> transparent. Or we could just leave it in and say "don't do
> >>>> this
> >>>> > > next
> >>>> > > > > >>> time". I'm not that invested in it.
> >>>> > > > > >>>
> >>>> > > > > >>> On Thu, Apr 12, 2012 at 4:04 PM, Shazron <sh...@gmail.com>
> >>>> > > wrote:
> >>>> > > > > >>>
> >>>> > > > > >>>> If we take out that iOS commit in cordova-js (somehow), it
> >>>> > should
> >>>> > > be
> >>>> > > > > >>>> fine. cordova-ios 1.6.1 will then just be the same as
> >>>>1.6.0.
> >>>> > > > > >>>>
> >>>> > > > > >>>> On Thu, Apr 12, 2012 at 4:02 PM, Filip Maj <fi...@adobe.com>
> >>>> > wrote:
> >>>> > > > > >>>> >
> >>>> > > > > >>>> >>Is it too much to drop the new commit that changed the
> >>>> common
> >>>> > js
> >>>> > > > > >>>>API, and
> >>>> > > > > >>>> >>reapply it after we tag 1.6.1, and figure this one thing
> >>>>out
> >>>> > for
> >>>> > > > > >>>>1.7?
> >>>> > > > > >>>> >
> >>>> > > > > >>>> > That sounds very good to me but I am under the impression
> >>>> that
> >>>> > > iOS
> >>>> > > > > >>>> > requires this commit? Like I said I'm quite confused.
> >>>> > > > > >>>> >
> >>>> > > > > >>>> >>
> >>>> > > > > >>>> >>I also have some cordova-js commits to add to 1.6.1?
> >>>> Although
> >>>> > > > > >>>>nothing
> >>>> > > > > >>>> that
> >>>> > > > > >>>> >>modifies any js outside of what is built for wp7. ( ie,
> >>>>all
> >>>> in
> >>>> > > my
> >>>> > > > > >>>> platform
> >>>> > > > > >>>> >>specific plugins folder )
> >>>> > > > > >>>> >>
> >>>> > > > > >>>> >
> >>>> > > > > >>>> > O then it sounds like I tagged the JS 1.6.1 too early
> >>>> > anyways..
> >>>> > > > > >>>> >
> >>>> > > > > >>>> >>
> >>>> > > > > >>>> >>
> >>>> > > > > >>>> >>
> >>>> > > > > >>>> >>On Thu, Apr 12, 2012 at 3:51 PM, Shazron
> >>>><shazron@gmail.com
> >>>> >
> >>>> > > > wrote:
> >>>> > > > > >>>> >>
> >>>> > > > > >>>> >>> No - it's about a user's contribution being noted (it
> >>>> > > exists), I
> >>>> > > > > >>>>will
> >>>> > > > > >>>> >>> move it out of the common code post-1.6.1 (I
> >>>>acknowledge
> >>>> my
> >>>> > > > > >>>>mistake in
> >>>> > > > > >>>> >>> allowing it in the first place). Can we branch off
> >>>>1.6.0
> >>>> > then
> >>>> > > > > >>>> >>> cherry-pick Fil's latest fix for 1.6.1?
> >>>> > > > > >>>> >>>
> >>>> > > > > >>>> >>> On Thu, Apr 12, 2012 at 3:47 PM, Joe Bowser <
> >>>> > > bowserj@gmail.com>
> >>>> > > > > >>>>wrote:
> >>>> > > > > >>>> >>> > OK, so you're proposing that we leave the thing in
> >>>>the
> >>>> > > common
> >>>> > > > > >>>>JS,
> >>>> > > > > >>>> even
> >>>> > > > > >>>> >>> > though it's not supposed to be there.
> >>>> > > > > >>>> >>> >
> >>>> > > > > >>>> >>> > On Thu, Apr 12, 2012 at 3:45 PM, Shazron <
> >>>> > shazron@gmail.com
> >>>> > > >
> >>>> > > > > >>>>wrote:
> >>>> > > > > >>>> >>> >
> >>>> > > > > >>>> >>> >> Will rebasing lose that commit? Then, no.
> >>>> > > > > >>>> >>> >>
> >>>> > > > > >>>> >>> >> On Thu, Apr 12, 2012 at 3:43 PM, Joe Bowser <
> >>>> > > > bowserj@gmail.com
> >>>> > > > > >
> >>>> > > > > >>>> >>>wrote:
> >>>> > > > > >>>> >>> >> > So, can we just rebase the head, push this out and
> >>>> get
> >>>> > > this
> >>>> > > > > >>>> >>>rolling?
> >>>> > > > > >>>> >>> >> >
> >>>> > > > > >>>> >>> >> > On Thu, Apr 12, 2012 at 3:43 PM, Filip Maj <
> >>>> > > fil@adobe.com>
> >>>> > > > > >>>>wrote:
> >>>> > > > > >>>> >>> >> >
> >>>> > > > > >>>> >>> >> >> Correct, those iOS-specific parameters (like
> >>>>allow
> >>>> > edit
> >>>> > > > and
> >>>> > > > > >>>>those
> >>>> > > > > >>>> >>> ones)
> >>>> > > > > >>>> >>> >> >> existed prior to cordova-js, so yeah, we left
> >>>>them
> >>>> in
> >>>> > > > there
> >>>> > > > > >>>>as we
> >>>> > > > > >>>> >>> didn't
> >>>> > > > > >>>> >>> >> >> want to remove without deprecation.
> >>>> > > > > >>>> >>> >> >>
> >>>> > > > > >>>> >>> >> >> If you can deal with the iOS issue without
> >>>>needing
> >>>> an
> >>>> > > API
> >>>> > > > > >>>> >>>extension:
> >>>> > > > > >>>> >>> >> then
> >>>> > > > > >>>> >>> >> >> do that. If not, leave it in there, but docs
> >>>>need to
> >>>> > > > > >>>>updated too.
> >>>> > > > > >>>> >>> >> >>
> >>>> > > > > >>>> >>> >> >> Extending and changing the public API is a long
> >>>>and
> >>>> > > > > >>>>difficult
> >>>> > > > > >>>> >>>process
> >>>> > > > > >>>> >>> >> for
> >>>> > > > > >>>> >>> >> >> us and will only get tougher with every platform
> >>>>we
> >>>> > add
> >>>> > > > > >>>>support
> >>>> > > > > >>>> >>>to.
> >>>> > > > > >>>> >>> >> >>
> >>>> > > > > >>>> >>> >> >> On 4/12/12 3:37 PM, "Shazron" <sh...@gmail.com>
> >>>> > > wrote:
> >>>> > > > > >>>> >>> >> >>
> >>>> > > > > >>>> >>> >> >> >Then we have to scrap the other three(?) iOS
> >>>> > parameters
> >>>> > > > > >>>>ones
> >>>> > > > > >>>> that
> >>>> > > > > >>>> >>> >> >> >already exist in common if you noticed. Don't
> >>>>know
> >>>> > how
> >>>> > > we
> >>>> > > > > >>>>merge
> >>>> > > > > >>>> >>> >> >> >(unmerge?) this one properly because taking
> >>>>those
> >>>> out
> >>>> > > > will
> >>>> > > > > >>>>break
> >>>> > > > > >>>> >>> >> >> >everyone that is using it, but a deprecation is
> >>>>the
> >>>> > way
> >>>> > > > to
> >>>> > > > > >>>>go as
> >>>> > > > > >>>> >>>per
> >>>> > > > > >>>> >>> >> >>
> >>>>>http://wiki.apache.org/cordova/DeprecationPolicy .
> >>>> > We
> >>>> > > > can
> >>>> > > > > >>>> remove
> >>>> > > > > >>>> >>> this
> >>>> > > > > >>>> >>> >> >> >new commit and I'll find a way to get this in
> >>>> > somehow.
> >>>> > > > > >>>> >>> >> >> >
> >>>> > > > > >>>> >>> >> >> >
> >>>> > > > > >>>> >>> >> >> >
> >>>> > > > > >>>> >>> >> >> >On Thu, Apr 12, 2012 at 3:32 PM, Joe Bowser
> >>>> > > > > >>>><bo...@gmail.com>
> >>>> > > > > >>>> >>> wrote:
> >>>> > > > > >>>> >>> >> >> >> The problem is that this parameter doesn't
> >>>>belong
> >>>> > in
> >>>> > > > the
> >>>> > > > > >>>> common
> >>>> > > > > >>>> >>> API.
> >>>> > > > > >>>> >>> >> >> >>It'd
> >>>> > > > > >>>> >>> >> >> >> be just ignored in Android, but the whole
> >>>>point
> >>>> of
> >>>> > > > > >>>>cordova-js
> >>>> > > > > >>>> >>>is
> >>>> > > > > >>>> >>> so
> >>>> > > > > >>>> >>> >> that
> >>>> > > > > >>>> >>> >> >> >> it's common. It'd look pretty screwed up to
> >>>>add
> >>>> > this
> >>>> > > > to
> >>>> > > > > >>>>the
> >>>> > > > > >>>> >>>docs,
> >>>> > > > > >>>> >>> >> IMO.
> >>>> > > > > >>>> >>> >> >> >>
> >>>> > > > > >>>> >>> >> >> >> On Thu, Apr 12, 2012 at 3:26 PM, Shazron
> >>>> > > > > >>>><sh...@gmail.com>
> >>>> > > > > >>>> >>> wrote:
> >>>> > > > > >>>> >>> >> >> >>
> >>>> > > > > >>>> >>> >> >> >>> To fix two bugs for Camera.takePicture on iOS
> >>>> > > > > >>>> >>> >> >> >>>
> >>>> > > > > >>>> >>> >> >> >>> On Thu, Apr 12, 2012 at 3:24 PM, Filip Maj
> >>>> > > > > >>>><fi...@adobe.com>
> >>>> > > > > >>>> >>> wrote:
> >>>> > > > > >>>> >>> >> >> >>> > so what's the point of this new parameter?
> >>>> > > > > >>>> >>> >> >> >>> >
> >>>> > > > > >>>> >>> >> >> >>> > On 4/12/12 3:16 PM, "Shazron" <
> >>>> > shazron@gmail.com>
> >>>> > > > > >>>>wrote:
> >>>> > > > > >>>> >>> >> >> >>> >
> >>>> > > > > >>>> >>> >> >> >>> >>I did. Do we want to revert the
> >>>>cordova-js? I
> >>>> > can
> >>>> > > > > >>>>branch
> >>>> > > > > >>>> >>>1.6.0
> >>>> > > > > >>>> >>> and
> >>>> > > > > >>>> >>> >> >> >>> >>cherry-pick your latest commit for 1.6.1
> >>>> > > > > >>>> >>> >> >> >>> >>
> >>>> > > > > >>>> >>> >> >> >>> >>On Thu, Apr 12, 2012 at 3:04 PM, Filip Maj
> >>>> > > > > >>>><fi...@adobe.com>
> >>>> > > > > >>>> >>> wrote:
> >>>> > > > > >>>> >>> >> >> >>> >>> I saw something in the iOS commit logs
> >>>>for
> >>>> > this.
> >>>> > > > > >>>> >>> >> >> >>> >>>
> >>>> > > > > >>>> >>> >> >> >>> >>> Shaz can you comment?
> >>>> > > > > >>>> >>> >> >> >>> >>>
> >>>> > > > > >>>> >>> >> >> >>> >>> On 4/12/12 2:59 PM, "Joe Bowser" <
> >>>> > > > bowserj@gmail.com
> >>>> > > > > >
> >>>> > > > > >>>> >>>wrote:
> >>>> > > > > >>>> >>> >> >> >>> >>>
> >>>> > > > > >>>> >>> >> >> >>> >>>>Can we revert this, since this looks like
> >>>> it's
> >>>> > > > > >>>>intended
> >>>> > > > > >>>> >>>for
> >>>> > > > > >>>> >>> both
> >>>> > > > > >>>> >>> >> >> >>> Android
> >>>> > > > > >>>> >>> >> >> >>> >>>>and iOS, but I don't think it should be
> >>>>in
> >>>> > > 1.6.1.
> >>>> > > > > >>>> >>> >> >> >>> >>>>
> >>>> > > > > >>>> >>> >> >> >>> >>>>On Thu, Apr 12, 2012 at 2:52 PM, Filip
> >>>>Maj <
> >>>> > > > > >>>> fil@adobe.com>
> >>>> > > > > >>>> >>> >> wrote:
> >>>> > > > > >>>> >>> >> >> >>> >>>>
> >>>> > > > > >>>> >>> >> >> >>> >>>>> I was actually just looking at that
> >>>> myself.
> >>>> > > > > >>>> >>> >> >> >>> >>>>>
> >>>> > > > > >>>> >>> >> >> >>> >>>>> Looks like it's an iOS-only param..
> >>>>sigh.
> >>>> > We
> >>>> > > > > >>>>gotta
> >>>> > > > > >>>> stop
> >>>> > > > > >>>> >>> doing
> >>>> > > > > >>>> >>> >> >> >>>that,
> >>>> > > > > >>>> >>> >> >> >>> >>>>> especially if we don't update
> >>>> documentation.
> >>>> > > > > >>>> >>> >> >> >>> >>>>>
> >>>> > > > > >>>> >>> >> >> >>> >>>>> On 4/12/12 2:49 PM, "Joe Bowser"
> >>>> > > > > >>>><bo...@gmail.com>
> >>>> > > > > >>>> >>> wrote:
> >>>> > > > > >>>> >>> >> >> >>> >>>>>
> >>>> > > > > >>>> >>> >> >> >>> >>>>> >Has anyone tested the cropToSize param
> >>>> for
> >>>> > > > > >>>> >>> Camera.getPicture
> >>>> > > > > >>>> >>> >> >> >>>yet? I
> >>>> > > > > >>>> >>> >> >> >>> >>>>> >didn't
> >>>> > > > > >>>> >>> >> >> >>> >>>>> >notice that change until now.
> >>>> > > > > >>>> >>> >> >> >>> >>>>> >
> >>>> > > > > >>>> >>> >> >> >>> >>>>> >On Thu, Apr 12, 2012 at 2:46 PM, Filip
> >>>> Maj
> >>>> > > > > >>>> >>><fil@adobe.com
> >>>> > > > > >>>> >>> >
> >>>> > > > > >>>> >>> >> >> >>>wrote:
> >>>> > > > > >>>> >>> >> >> >>> >>>>> >
> >>>> > > > > >>>> >>> >> >> >>> >>>>> >> JS tagged 1.6.1 - the build task in
> >>>>the
> >>>> > JS
> >>>> > > > > >>>>should
> >>>> > > > > >>>> >>>work
> >>>> > > > > >>>> >>> >> >> >>>properly
> >>>> > > > > >>>> >>> >> >> >>> >>>>>now.
> >>>> > > > > >>>> >>> >> >> >>> >>>>> >>
> >>>> > > > > >>>> >>> >> >> >>> >>>>> >> FYI if anyone has to modify the jake
> >>>> > tasks
> >>>> > > in
> >>>> > > > > >>>>the
> >>>> > > > > >>>> >>>future
> >>>> > > > > >>>> >>> >> and
> >>>> > > > > >>>> >>> >> >> >>>make
> >>>> > > > > >>>> >>> >> >> >>> >>>>>them
> >>>> > > > > >>>> >>> >> >> >>> >>>>> >> async, make sure you add the 4th
> >>>> "async"
> >>>> > > > > >>>>parameter
> >>>> > > > > >>>> to
> >>>> > > > > >>>> >>> the
> >>>> > > > > >>>> >>> >> >> >>>task()
> >>>> > > > > >>>> >>> >> >> >>> >>>>> >>function
> >>>> > > > > >>>> >>> >> >> >>> >>>>> >> and set it to true, and call
> >>>>complete()
> >>>> > > when
> >>>> > > > > >>>>the
> >>>> > > > > >>>> >>>task is
> >>>> > > > > >>>> >>> >> done.
> >>>> > > > > >>>> >>> >> >> >>> >>>>> >>
> >>>> > > > > >>>> >>> >> >> >>> >>>>> >> See
> >>>> > > > > >>>> >>> http://howtonode.org/intro-to-jake/async-jakefile.jsfor
> >>>> > > > > >>>> >>> >> >> >>>an
> >>>> > > > > >>>> >>> >> >> >>> >>>>> example.
> >>>> > > > > >>>> >>> >> >> >>> >>>>> >>
> >>>> > > > > >>>> >>> >> >> >>> >>>>> >> On 4/12/12 2:35 PM, "Joe Bowser"
> >>>> > > > > >>>><bowserj@gmail.com
> >>>> > > > > >>>> >
> >>>> > > > > >>>> >>> >> wrote:
> >>>> > > > > >>>> >>> >> >> >>> >>>>> >>
> >>>> > > > > >>>> >>> >> >> >>> >>>>> >> >Ready to tag once cordova-js is
> >>>>tagged
> >>>> > > > 1.6.1.
> >>>> > > > > >>>> >>> >> >> >>> >>>>> >> >
> >>>> > > > > >>>> >>> >> >> >>> >>>>> >> >On Thu, Apr 12, 2012 at 2:33 PM,
> >>>>Anis
> >>>> > > KADRI
> >>>> > > > <
> >>>> > > > > >>>> >>> >> >> >>> anis.kadri@gmail.com>
> >>>> > > > > >>>> >>> >> >> >>> >>>>> >>wrote:
> >>>> > > > > >>>> >>> >> >> >>> >>>>> >> >
> >>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> I will tag my repository to 1.6.1
> >>>> > before
> >>>> > > > > >>>>end of
> >>>> > > > > >>>> >>>day
> >>>> > > > > >>>> >>> >> today
> >>>> > > > > >>>> >>> >> >> >>>after
> >>>> > > > > >>>> >>> >> >> >>> >>>>>some
> >>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> thorough testing.
> >>>> > > > > >>>> >>> >> >> >>> >>>>> >> >>
> >>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> On Thu, Apr 12, 2012 at 2:30 PM,
> >>>> > Shazron
> >>>> > > > > >>>> >>> >> >> >>><sh...@gmail.com>
> >>>> > > > > >>>> >>> >> >> >>> >>>>>wrote:
> >>>> > > > > >>>> >>> >> >> >>> >>>>> >> >>
> >>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > I also created a 1.6.1 version
> >>>>tag
> >>>> > as
> >>>> > > > > >>>>well in
> >>>> > > > > >>>> >>> jira...
> >>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> >
> >>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > On Thu, Apr 12, 2012 at 2:29
> >>>>PM,
> >>>> > > Shazron
> >>>> > > > > >>>> >>> >> >> >>><sh...@gmail.com>
> >>>> > > > > >>>> >>> >> >> >>> >>>>> wrote:
> >>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > > Alright guys since 1.6.0 was
> >>>> > > released,
> >>>> > > > > >>>>I'm
> >>>> > > > > >>>> >>>going
> >>>> > > > > >>>> >>> to
> >>>> > > > > >>>> >>> >> >> >>> >>>>>"Release"
> >>>> > > > > >>>> >>> >> >> >>> >>>>>the
> >>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > > 1.6.0 version in jira and
> >>>>move
> >>>> > > > > >>>>outstanding
> >>>> > > > > >>>> >>> issues to
> >>>> > > > > >>>> >>> >> >> >>>1.7.0
> >>>> > > > > >>>> >>> >> >> >>> >>>>> >>version
> >>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > > tag.
> >>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >
> >>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >
> >>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > > On Thu, Apr 12, 2012 at 2:26
> >>>>PM,
> >>>> > > Filip
> >>>> > > > > >>>>Maj
> >>>> > > > > >>>> >>> >> >> >>><fi...@adobe.com>
> >>>> > > > > >>>> >>> >> >> >>> >>>>> wrote:
> >>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >> The JS needs patching too.
> >>>> Since
> >>>> > > > > >>>>adding the
> >>>> > > > > >>>> >>> commit
> >>>> > > > > >>>> >>> >> ID
> >>>> > > > > >>>> >>> >> >> >>>into
> >>>> > > > > >>>> >>> >> >> >>> >>>>>the
> >>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> packaging
> >>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >> in the jakefile, the default
> >>>> task
> >>>> > > > isn't
> >>>> > > > > >>>> >>>running
> >>>> > > > > >>>> >>> >> >> >>>properly.
> >>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>
> >>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >> You can manually run "jake
> >>>> build"
> >>>> > > and
> >>>> > > > > >>>>"jake
> >>>> > > > > >>>> >>> test"
> >>>> > > > > >>>> >>> >> but
> >>>> > > > > >>>> >>> >> >> >>>not
> >>>> > > > > >>>> >>> >> >> >>> >>>>> >>"jake" on
> >>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> its
> >>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >> own - gonna try to figure it
> >>>> out.
> >>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>
> >>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >> On 4/12/12 2:21 PM,
> >>>>"Shazron" <
> >>>> > > > > >>>> >>> shazron@gmail.com>
> >>>> > > > > >>>> >>> >> >> >>>wrote:
> >>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>
> >>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>I'm good with tagging. iOS
> >>>> has a
> >>>> > > few
> >>>> > > > > >>>> commits
> >>>> > > > > >>>> >>> (one
> >>>> > > > > >>>> >>> >> >> >>>commit
> >>>> > > > > >>>> >>> >> >> >>> >>>>>in
> >>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>cordova-js) as well. Aim for
> >>>> > first
> >>>> > > > > >>>>thing
> >>>> > > > > >>>> >>> tomorrow
> >>>> > > > > >>>> >>> >> for
> >>>> > > > > >>>> >>> >> >> >>>you
> >>>> > > > > >>>> >>> >> >> >>> >>>>>to
> >>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>repackage?
> >>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>
> >>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>On Thu, Apr 12, 2012 at 2:17
> >>>> PM,
> >>>> > > > > >>>>Steven Gill
> >>>> > > > > >>>> >>> >> >> >>> >>>>> >> >><st...@gmail.com>
> >>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>wrote:
> >>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>> So a bug has been
> >>>>discovered
> >>>> in
> >>>> > > > > >>>>Cordova
> >>>> > > > > >>>> >>> Android
> >>>> > > > > >>>> >>> >> that
> >>>> > > > > >>>> >>> >> >> >>> >>>>>requires
> >>>> > > > > >>>> >>> >> >> >>> >>>>> >>a
> >>>> > > > > >>>> >>> >> >> >>> >>>>> >> >>new
> >>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > tag
> >>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>>and
> >>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>> release. You can check out
> >>>> the
> >>>> > > bug
> >>>> > > > > >>>>on the
> >>>> > > > > >>>> >>> issue
> >>>> > > > > >>>> >>> >> >> >>>tracker
> >>>> > > > > >>>> >>> >> >> >>> >>>>>at
> >>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>>
> >>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>>
> >>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> >
> >>>> > > > > >>>> >>> >> >> >>> >>>>> >> >>
> >>>> > > > > >>>> >>> >> >> >>> >>>>> >> >>
> >>>> > > > > >>>> >>> >> >> >>> >>>>> >>
> >>>> > > > > >>>> >>> >> >> >>> >>>>> >>
> >>>> > > > > >>>> >>> >> >> >>> >>>>>
> >>>> > > > > >>>> >>> >> >> >>> >>>>>
> >>>> > > > > >>>> >>> >> >> >>>
> >>>> > > > > >>>> >>> >> >>
> >>>> > > > > >>>> >>>
> >>>> > > > > >>>>
> >>>> > > > > >>>>
> >>>> > > > >
> >>>> > >
> >>>> https://issues.apache.org/jira/browse/CB-490?focusedCommentId=13252809#
> >>>> > > > > >>>> >>> >> >> >>> >>>>>co
> >>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>>mment-13252809
> >>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>>
> >>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>> It doesn't make sense to
> >>>>just
> >>>> > > > > >>>>repackage
> >>>> > > > > >>>> >>>1.6.0
> >>>> > > > > >>>> >>> >> with
> >>>> > > > > >>>> >>> >> >> >>>this
> >>>> > > > > >>>> >>> >> >> >>> >>>>>bug
> >>>> > > > > >>>> >>> >> >> >>> >>>>> >> >>fixed as
> >>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > we
> >>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>> will have no way to know
> >>>>if
> >>>> > > people
> >>>> > > > > >>>>are
> >>>> > > > > >>>> >>> >> experiencing
> >>>> > > > > >>>> >>> >> >> >>>this
> >>>> > > > > >>>> >>> >> >> >>> >>>>>or
> >>>> > > > > >>>> >>> >> >> >>> >>>>> >>not.
> >>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>>
> >>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>> Anis mentioned Bada also
> >>>>had
> >>>> > some
> >>>> > > > > >>>>major
> >>>> > > > > >>>> >>>issues
> >>>> > > > > >>>> >>> >> >> >>>which he
> >>>> > > > > >>>> >>> >> >> >>> >>>>>has
> >>>> > > > > >>>> >>> >> >> >>> >>>>> >>fixed
> >>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> now
> >>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>>and
> >>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>> would like in a 1.6.1
> >>>> release.
> >>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>>
> >>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>> Thoughts?
> >>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>>
> >>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>> -Steve
> >>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>
> >>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> >
> >>>> > > > > >>>> >>> >> >> >>> >>>>> >> >>
> >>>> > > > > >>>> >>> >> >> >>> >>>>> >>
> >>>> > > > > >>>> >>> >> >> >>> >>>>> >>
> >>>> > > > > >>>> >>> >> >> >>> >>>>>
> >>>> > > > > >>>> >>> >> >> >>> >>>>>
> >>>> > > > > >>>> >>> >> >> >>> >>>
> >>>> > > > > >>>> >>> >> >> >>> >
> >>>> > > > > >>>> >>> >> >> >>>
> >>>> > > > > >>>> >>> >> >>
> >>>> > > > > >>>> >>> >> >>
> >>>> > > > > >>>> >>> >>
> >>>> > > > > >>>> >>>
> >>>> > > > > >>>> >
> >>>> > > > > >>>>
> >>>> > > > >
> >>>> > > > >
> >>>> > > >
> >>>> > >
> >>>> >
> >>>>
> >>
Re: 1.6.1
Posted by Shazron <sh...@gmail.com>.
https://issues.apache.org/jira/browse/CB-496
On Thu, Apr 12, 2012 at 5:07 PM, Shazron <sh...@gmail.com> wrote:
> Sigh - user reported iOS bug
> http://groups.google.com/group/phonegap/browse_thread/thread/faad0af97dec8907
> (you know who you are ;)
>
> On Thu, Apr 12, 2012 at 5:05 PM, Filip Maj <fi...@adobe.com> wrote:
>> Saweet! Nice work Anis. That kills off a bunch of old issues in JIRA too.
>>
>> Way to hunker down all. As Jesse pointed out to me, we did 45 emails in
>> two hours haha
>>
>> On 4/12/12 5:00 PM, "Anis KADRI" <an...@gmail.com> wrote:
>>
>>>Bada 1.2 is tagged 1.6.1. I added the new Cordova artwork, LICENSE/NOTICE
>>>files as well as the Apache source headers in every source file. I fixed
>>>all the bugs I sawS
>>>
>>>On Thu, Apr 12, 2012 at 4:38 PM, Joe Bowser <bo...@gmail.com> wrote:
>>>
>>>> Android is tagged.
>>>>
>>>> On Thu, Apr 12, 2012 at 4:36 PM, Jesse <pu...@gmail.com> wrote:
>>>>
>>>> > Done
>>>> >
>>>> > On Thu, Apr 12, 2012 at 4:31 PM, Joe Bowser <bo...@gmail.com> wrote:
>>>> >
>>>> > > I'd like to get the JS from the tag, but I need a tag for that.
>>>> > >
>>>> > > On Thu, Apr 12, 2012 at 4:29 PM, Jesse <pu...@gmail.com>
>>>> wrote:
>>>> > >
>>>> > > > Okay, I think it's good, tagging at 16:32 PDT if i don't hear any
>>>> > > > complaints.
>>>> > > >
>>>> > > > On Thu, Apr 12, 2012 at 4:26 PM, Filip Maj <fi...@adobe.com> wrote:
>>>> > > >
>>>> > > > > I just axed the existing 1.6.1 cordova-js tag
>>>> > > > >
>>>> > > > > Jesse when you feel you've got everything in there go ahead and
>>>>tag
>>>> > JS
>>>> > > > >
>>>> > > > > On 4/12/12 4:20 PM, "Shazron" <sh...@gmail.com> wrote:
>>>> > > > >
>>>> > > > > >Reverted. Just talked to Jesse - he has commits to cordova-js
>>>> > coming,
>>>> > > > > >once those are in we can re-tag cordova-js to 1.6.1
>>>> > > > > >
>>>> > > > > >On Thu, Apr 12, 2012 at 4:12 PM, Shazron <sh...@gmail.com>
>>>> wrote:
>>>> > > > > >> I'll remove it. *grabs the shovel*
>>>> > > > > >>
>>>> > > > > >> On Thu, Apr 12, 2012 at 4:10 PM, Joe Bowser
>>>><bo...@gmail.com>
>>>> > > > wrote:
>>>> > > > > >>> You know, let's not rebase it, because it does modify the
>>>> > history.
>>>> > > > We
>>>> > > > > >>> should remove and document why we did it instead, since that
>>>> > would
>>>> > > be
>>>> > > > > >>>more
>>>> > > > > >>> transparent. Or we could just leave it in and say "don't do
>>>> this
>>>> > > next
>>>> > > > > >>> time". I'm not that invested in it.
>>>> > > > > >>>
>>>> > > > > >>> On Thu, Apr 12, 2012 at 4:04 PM, Shazron <sh...@gmail.com>
>>>> > > wrote:
>>>> > > > > >>>
>>>> > > > > >>>> If we take out that iOS commit in cordova-js (somehow), it
>>>> > should
>>>> > > be
>>>> > > > > >>>> fine. cordova-ios 1.6.1 will then just be the same as
>>>>1.6.0.
>>>> > > > > >>>>
>>>> > > > > >>>> On Thu, Apr 12, 2012 at 4:02 PM, Filip Maj <fi...@adobe.com>
>>>> > wrote:
>>>> > > > > >>>> >
>>>> > > > > >>>> >>Is it too much to drop the new commit that changed the
>>>> common
>>>> > js
>>>> > > > > >>>>API, and
>>>> > > > > >>>> >>reapply it after we tag 1.6.1, and figure this one thing
>>>>out
>>>> > for
>>>> > > > > >>>>1.7?
>>>> > > > > >>>> >
>>>> > > > > >>>> > That sounds very good to me but I am under the impression
>>>> that
>>>> > > iOS
>>>> > > > > >>>> > requires this commit? Like I said I'm quite confused.
>>>> > > > > >>>> >
>>>> > > > > >>>> >>
>>>> > > > > >>>> >>I also have some cordova-js commits to add to 1.6.1?
>>>> Although
>>>> > > > > >>>>nothing
>>>> > > > > >>>> that
>>>> > > > > >>>> >>modifies any js outside of what is built for wp7. ( ie,
>>>>all
>>>> in
>>>> > > my
>>>> > > > > >>>> platform
>>>> > > > > >>>> >>specific plugins folder )
>>>> > > > > >>>> >>
>>>> > > > > >>>> >
>>>> > > > > >>>> > O then it sounds like I tagged the JS 1.6.1 too early
>>>> > anyways..
>>>> > > > > >>>> >
>>>> > > > > >>>> >>
>>>> > > > > >>>> >>
>>>> > > > > >>>> >>
>>>> > > > > >>>> >>On Thu, Apr 12, 2012 at 3:51 PM, Shazron
>>>><shazron@gmail.com
>>>> >
>>>> > > > wrote:
>>>> > > > > >>>> >>
>>>> > > > > >>>> >>> No - it's about a user's contribution being noted (it
>>>> > > exists), I
>>>> > > > > >>>>will
>>>> > > > > >>>> >>> move it out of the common code post-1.6.1 (I
>>>>acknowledge
>>>> my
>>>> > > > > >>>>mistake in
>>>> > > > > >>>> >>> allowing it in the first place). Can we branch off
>>>>1.6.0
>>>> > then
>>>> > > > > >>>> >>> cherry-pick Fil's latest fix for 1.6.1?
>>>> > > > > >>>> >>>
>>>> > > > > >>>> >>> On Thu, Apr 12, 2012 at 3:47 PM, Joe Bowser <
>>>> > > bowserj@gmail.com>
>>>> > > > > >>>>wrote:
>>>> > > > > >>>> >>> > OK, so you're proposing that we leave the thing in
>>>>the
>>>> > > common
>>>> > > > > >>>>JS,
>>>> > > > > >>>> even
>>>> > > > > >>>> >>> > though it's not supposed to be there.
>>>> > > > > >>>> >>> >
>>>> > > > > >>>> >>> > On Thu, Apr 12, 2012 at 3:45 PM, Shazron <
>>>> > shazron@gmail.com
>>>> > > >
>>>> > > > > >>>>wrote:
>>>> > > > > >>>> >>> >
>>>> > > > > >>>> >>> >> Will rebasing lose that commit? Then, no.
>>>> > > > > >>>> >>> >>
>>>> > > > > >>>> >>> >> On Thu, Apr 12, 2012 at 3:43 PM, Joe Bowser <
>>>> > > > bowserj@gmail.com
>>>> > > > > >
>>>> > > > > >>>> >>>wrote:
>>>> > > > > >>>> >>> >> > So, can we just rebase the head, push this out and
>>>> get
>>>> > > this
>>>> > > > > >>>> >>>rolling?
>>>> > > > > >>>> >>> >> >
>>>> > > > > >>>> >>> >> > On Thu, Apr 12, 2012 at 3:43 PM, Filip Maj <
>>>> > > fil@adobe.com>
>>>> > > > > >>>>wrote:
>>>> > > > > >>>> >>> >> >
>>>> > > > > >>>> >>> >> >> Correct, those iOS-specific parameters (like
>>>>allow
>>>> > edit
>>>> > > > and
>>>> > > > > >>>>those
>>>> > > > > >>>> >>> ones)
>>>> > > > > >>>> >>> >> >> existed prior to cordova-js, so yeah, we left
>>>>them
>>>> in
>>>> > > > there
>>>> > > > > >>>>as we
>>>> > > > > >>>> >>> didn't
>>>> > > > > >>>> >>> >> >> want to remove without deprecation.
>>>> > > > > >>>> >>> >> >>
>>>> > > > > >>>> >>> >> >> If you can deal with the iOS issue without
>>>>needing
>>>> an
>>>> > > API
>>>> > > > > >>>> >>>extension:
>>>> > > > > >>>> >>> >> then
>>>> > > > > >>>> >>> >> >> do that. If not, leave it in there, but docs
>>>>need to
>>>> > > > > >>>>updated too.
>>>> > > > > >>>> >>> >> >>
>>>> > > > > >>>> >>> >> >> Extending and changing the public API is a long
>>>>and
>>>> > > > > >>>>difficult
>>>> > > > > >>>> >>>process
>>>> > > > > >>>> >>> >> for
>>>> > > > > >>>> >>> >> >> us and will only get tougher with every platform
>>>>we
>>>> > add
>>>> > > > > >>>>support
>>>> > > > > >>>> >>>to.
>>>> > > > > >>>> >>> >> >>
>>>> > > > > >>>> >>> >> >> On 4/12/12 3:37 PM, "Shazron" <sh...@gmail.com>
>>>> > > wrote:
>>>> > > > > >>>> >>> >> >>
>>>> > > > > >>>> >>> >> >> >Then we have to scrap the other three(?) iOS
>>>> > parameters
>>>> > > > > >>>>ones
>>>> > > > > >>>> that
>>>> > > > > >>>> >>> >> >> >already exist in common if you noticed. Don't
>>>>know
>>>> > how
>>>> > > we
>>>> > > > > >>>>merge
>>>> > > > > >>>> >>> >> >> >(unmerge?) this one properly because taking
>>>>those
>>>> out
>>>> > > > will
>>>> > > > > >>>>break
>>>> > > > > >>>> >>> >> >> >everyone that is using it, but a deprecation is
>>>>the
>>>> > way
>>>> > > > to
>>>> > > > > >>>>go as
>>>> > > > > >>>> >>>per
>>>> > > > > >>>> >>> >> >>
>>>>>http://wiki.apache.org/cordova/DeprecationPolicy .
>>>> > We
>>>> > > > can
>>>> > > > > >>>> remove
>>>> > > > > >>>> >>> this
>>>> > > > > >>>> >>> >> >> >new commit and I'll find a way to get this in
>>>> > somehow.
>>>> > > > > >>>> >>> >> >> >
>>>> > > > > >>>> >>> >> >> >
>>>> > > > > >>>> >>> >> >> >
>>>> > > > > >>>> >>> >> >> >On Thu, Apr 12, 2012 at 3:32 PM, Joe Bowser
>>>> > > > > >>>><bo...@gmail.com>
>>>> > > > > >>>> >>> wrote:
>>>> > > > > >>>> >>> >> >> >> The problem is that this parameter doesn't
>>>>belong
>>>> > in
>>>> > > > the
>>>> > > > > >>>> common
>>>> > > > > >>>> >>> API.
>>>> > > > > >>>> >>> >> >> >>It'd
>>>> > > > > >>>> >>> >> >> >> be just ignored in Android, but the whole
>>>>point
>>>> of
>>>> > > > > >>>>cordova-js
>>>> > > > > >>>> >>>is
>>>> > > > > >>>> >>> so
>>>> > > > > >>>> >>> >> that
>>>> > > > > >>>> >>> >> >> >> it's common. It'd look pretty screwed up to
>>>>add
>>>> > this
>>>> > > > to
>>>> > > > > >>>>the
>>>> > > > > >>>> >>>docs,
>>>> > > > > >>>> >>> >> IMO.
>>>> > > > > >>>> >>> >> >> >>
>>>> > > > > >>>> >>> >> >> >> On Thu, Apr 12, 2012 at 3:26 PM, Shazron
>>>> > > > > >>>><sh...@gmail.com>
>>>> > > > > >>>> >>> wrote:
>>>> > > > > >>>> >>> >> >> >>
>>>> > > > > >>>> >>> >> >> >>> To fix two bugs for Camera.takePicture on iOS
>>>> > > > > >>>> >>> >> >> >>>
>>>> > > > > >>>> >>> >> >> >>> On Thu, Apr 12, 2012 at 3:24 PM, Filip Maj
>>>> > > > > >>>><fi...@adobe.com>
>>>> > > > > >>>> >>> wrote:
>>>> > > > > >>>> >>> >> >> >>> > so what's the point of this new parameter?
>>>> > > > > >>>> >>> >> >> >>> >
>>>> > > > > >>>> >>> >> >> >>> > On 4/12/12 3:16 PM, "Shazron" <
>>>> > shazron@gmail.com>
>>>> > > > > >>>>wrote:
>>>> > > > > >>>> >>> >> >> >>> >
>>>> > > > > >>>> >>> >> >> >>> >>I did. Do we want to revert the
>>>>cordova-js? I
>>>> > can
>>>> > > > > >>>>branch
>>>> > > > > >>>> >>>1.6.0
>>>> > > > > >>>> >>> and
>>>> > > > > >>>> >>> >> >> >>> >>cherry-pick your latest commit for 1.6.1
>>>> > > > > >>>> >>> >> >> >>> >>
>>>> > > > > >>>> >>> >> >> >>> >>On Thu, Apr 12, 2012 at 3:04 PM, Filip Maj
>>>> > > > > >>>><fi...@adobe.com>
>>>> > > > > >>>> >>> wrote:
>>>> > > > > >>>> >>> >> >> >>> >>> I saw something in the iOS commit logs
>>>>for
>>>> > this.
>>>> > > > > >>>> >>> >> >> >>> >>>
>>>> > > > > >>>> >>> >> >> >>> >>> Shaz can you comment?
>>>> > > > > >>>> >>> >> >> >>> >>>
>>>> > > > > >>>> >>> >> >> >>> >>> On 4/12/12 2:59 PM, "Joe Bowser" <
>>>> > > > bowserj@gmail.com
>>>> > > > > >
>>>> > > > > >>>> >>>wrote:
>>>> > > > > >>>> >>> >> >> >>> >>>
>>>> > > > > >>>> >>> >> >> >>> >>>>Can we revert this, since this looks like
>>>> it's
>>>> > > > > >>>>intended
>>>> > > > > >>>> >>>for
>>>> > > > > >>>> >>> both
>>>> > > > > >>>> >>> >> >> >>> Android
>>>> > > > > >>>> >>> >> >> >>> >>>>and iOS, but I don't think it should be
>>>>in
>>>> > > 1.6.1.
>>>> > > > > >>>> >>> >> >> >>> >>>>
>>>> > > > > >>>> >>> >> >> >>> >>>>On Thu, Apr 12, 2012 at 2:52 PM, Filip
>>>>Maj <
>>>> > > > > >>>> fil@adobe.com>
>>>> > > > > >>>> >>> >> wrote:
>>>> > > > > >>>> >>> >> >> >>> >>>>
>>>> > > > > >>>> >>> >> >> >>> >>>>> I was actually just looking at that
>>>> myself.
>>>> > > > > >>>> >>> >> >> >>> >>>>>
>>>> > > > > >>>> >>> >> >> >>> >>>>> Looks like it's an iOS-only param..
>>>>sigh.
>>>> > We
>>>> > > > > >>>>gotta
>>>> > > > > >>>> stop
>>>> > > > > >>>> >>> doing
>>>> > > > > >>>> >>> >> >> >>>that,
>>>> > > > > >>>> >>> >> >> >>> >>>>> especially if we don't update
>>>> documentation.
>>>> > > > > >>>> >>> >> >> >>> >>>>>
>>>> > > > > >>>> >>> >> >> >>> >>>>> On 4/12/12 2:49 PM, "Joe Bowser"
>>>> > > > > >>>><bo...@gmail.com>
>>>> > > > > >>>> >>> wrote:
>>>> > > > > >>>> >>> >> >> >>> >>>>>
>>>> > > > > >>>> >>> >> >> >>> >>>>> >Has anyone tested the cropToSize param
>>>> for
>>>> > > > > >>>> >>> Camera.getPicture
>>>> > > > > >>>> >>> >> >> >>>yet? I
>>>> > > > > >>>> >>> >> >> >>> >>>>> >didn't
>>>> > > > > >>>> >>> >> >> >>> >>>>> >notice that change until now.
>>>> > > > > >>>> >>> >> >> >>> >>>>> >
>>>> > > > > >>>> >>> >> >> >>> >>>>> >On Thu, Apr 12, 2012 at 2:46 PM, Filip
>>>> Maj
>>>> > > > > >>>> >>><fil@adobe.com
>>>> > > > > >>>> >>> >
>>>> > > > > >>>> >>> >> >> >>>wrote:
>>>> > > > > >>>> >>> >> >> >>> >>>>> >
>>>> > > > > >>>> >>> >> >> >>> >>>>> >> JS tagged 1.6.1 - the build task in
>>>>the
>>>> > JS
>>>> > > > > >>>>should
>>>> > > > > >>>> >>>work
>>>> > > > > >>>> >>> >> >> >>>properly
>>>> > > > > >>>> >>> >> >> >>> >>>>>now.
>>>> > > > > >>>> >>> >> >> >>> >>>>> >>
>>>> > > > > >>>> >>> >> >> >>> >>>>> >> FYI if anyone has to modify the jake
>>>> > tasks
>>>> > > in
>>>> > > > > >>>>the
>>>> > > > > >>>> >>>future
>>>> > > > > >>>> >>> >> and
>>>> > > > > >>>> >>> >> >> >>>make
>>>> > > > > >>>> >>> >> >> >>> >>>>>them
>>>> > > > > >>>> >>> >> >> >>> >>>>> >> async, make sure you add the 4th
>>>> "async"
>>>> > > > > >>>>parameter
>>>> > > > > >>>> to
>>>> > > > > >>>> >>> the
>>>> > > > > >>>> >>> >> >> >>>task()
>>>> > > > > >>>> >>> >> >> >>> >>>>> >>function
>>>> > > > > >>>> >>> >> >> >>> >>>>> >> and set it to true, and call
>>>>complete()
>>>> > > when
>>>> > > > > >>>>the
>>>> > > > > >>>> >>>task is
>>>> > > > > >>>> >>> >> done.
>>>> > > > > >>>> >>> >> >> >>> >>>>> >>
>>>> > > > > >>>> >>> >> >> >>> >>>>> >> See
>>>> > > > > >>>> >>> http://howtonode.org/intro-to-jake/async-jakefile.jsfor
>>>> > > > > >>>> >>> >> >> >>>an
>>>> > > > > >>>> >>> >> >> >>> >>>>> example.
>>>> > > > > >>>> >>> >> >> >>> >>>>> >>
>>>> > > > > >>>> >>> >> >> >>> >>>>> >> On 4/12/12 2:35 PM, "Joe Bowser"
>>>> > > > > >>>><bowserj@gmail.com
>>>> > > > > >>>> >
>>>> > > > > >>>> >>> >> wrote:
>>>> > > > > >>>> >>> >> >> >>> >>>>> >>
>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >Ready to tag once cordova-js is
>>>>tagged
>>>> > > > 1.6.1.
>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >
>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >On Thu, Apr 12, 2012 at 2:33 PM,
>>>>Anis
>>>> > > KADRI
>>>> > > > <
>>>> > > > > >>>> >>> >> >> >>> anis.kadri@gmail.com>
>>>> > > > > >>>> >>> >> >> >>> >>>>> >>wrote:
>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >
>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> I will tag my repository to 1.6.1
>>>> > before
>>>> > > > > >>>>end of
>>>> > > > > >>>> >>>day
>>>> > > > > >>>> >>> >> today
>>>> > > > > >>>> >>> >> >> >>>after
>>>> > > > > >>>> >>> >> >> >>> >>>>>some
>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> thorough testing.
>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >>
>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> On Thu, Apr 12, 2012 at 2:30 PM,
>>>> > Shazron
>>>> > > > > >>>> >>> >> >> >>><sh...@gmail.com>
>>>> > > > > >>>> >>> >> >> >>> >>>>>wrote:
>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >>
>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > I also created a 1.6.1 version
>>>>tag
>>>> > as
>>>> > > > > >>>>well in
>>>> > > > > >>>> >>> jira...
>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> >
>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > On Thu, Apr 12, 2012 at 2:29
>>>>PM,
>>>> > > Shazron
>>>> > > > > >>>> >>> >> >> >>><sh...@gmail.com>
>>>> > > > > >>>> >>> >> >> >>> >>>>> wrote:
>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > > Alright guys since 1.6.0 was
>>>> > > released,
>>>> > > > > >>>>I'm
>>>> > > > > >>>> >>>going
>>>> > > > > >>>> >>> to
>>>> > > > > >>>> >>> >> >> >>> >>>>>"Release"
>>>> > > > > >>>> >>> >> >> >>> >>>>>the
>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > > 1.6.0 version in jira and
>>>>move
>>>> > > > > >>>>outstanding
>>>> > > > > >>>> >>> issues to
>>>> > > > > >>>> >>> >> >> >>>1.7.0
>>>> > > > > >>>> >>> >> >> >>> >>>>> >>version
>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > > tag.
>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >
>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >
>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > > On Thu, Apr 12, 2012 at 2:26
>>>>PM,
>>>> > > Filip
>>>> > > > > >>>>Maj
>>>> > > > > >>>> >>> >> >> >>><fi...@adobe.com>
>>>> > > > > >>>> >>> >> >> >>> >>>>> wrote:
>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >> The JS needs patching too.
>>>> Since
>>>> > > > > >>>>adding the
>>>> > > > > >>>> >>> commit
>>>> > > > > >>>> >>> >> ID
>>>> > > > > >>>> >>> >> >> >>>into
>>>> > > > > >>>> >>> >> >> >>> >>>>>the
>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> packaging
>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >> in the jakefile, the default
>>>> task
>>>> > > > isn't
>>>> > > > > >>>> >>>running
>>>> > > > > >>>> >>> >> >> >>>properly.
>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>
>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >> You can manually run "jake
>>>> build"
>>>> > > and
>>>> > > > > >>>>"jake
>>>> > > > > >>>> >>> test"
>>>> > > > > >>>> >>> >> but
>>>> > > > > >>>> >>> >> >> >>>not
>>>> > > > > >>>> >>> >> >> >>> >>>>> >>"jake" on
>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> its
>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >> own - gonna try to figure it
>>>> out.
>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>
>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >> On 4/12/12 2:21 PM,
>>>>"Shazron" <
>>>> > > > > >>>> >>> shazron@gmail.com>
>>>> > > > > >>>> >>> >> >> >>>wrote:
>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>
>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>I'm good with tagging. iOS
>>>> has a
>>>> > > few
>>>> > > > > >>>> commits
>>>> > > > > >>>> >>> (one
>>>> > > > > >>>> >>> >> >> >>>commit
>>>> > > > > >>>> >>> >> >> >>> >>>>>in
>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>cordova-js) as well. Aim for
>>>> > first
>>>> > > > > >>>>thing
>>>> > > > > >>>> >>> tomorrow
>>>> > > > > >>>> >>> >> for
>>>> > > > > >>>> >>> >> >> >>>you
>>>> > > > > >>>> >>> >> >> >>> >>>>>to
>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>repackage?
>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>
>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>On Thu, Apr 12, 2012 at 2:17
>>>> PM,
>>>> > > > > >>>>Steven Gill
>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >><st...@gmail.com>
>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>wrote:
>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>> So a bug has been
>>>>discovered
>>>> in
>>>> > > > > >>>>Cordova
>>>> > > > > >>>> >>> Android
>>>> > > > > >>>> >>> >> that
>>>> > > > > >>>> >>> >> >> >>> >>>>>requires
>>>> > > > > >>>> >>> >> >> >>> >>>>> >>a
>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >>new
>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > tag
>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>>and
>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>> release. You can check out
>>>> the
>>>> > > bug
>>>> > > > > >>>>on the
>>>> > > > > >>>> >>> issue
>>>> > > > > >>>> >>> >> >> >>>tracker
>>>> > > > > >>>> >>> >> >> >>> >>>>>at
>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>>
>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>>
>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> >
>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >>
>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >>
>>>> > > > > >>>> >>> >> >> >>> >>>>> >>
>>>> > > > > >>>> >>> >> >> >>> >>>>> >>
>>>> > > > > >>>> >>> >> >> >>> >>>>>
>>>> > > > > >>>> >>> >> >> >>> >>>>>
>>>> > > > > >>>> >>> >> >> >>>
>>>> > > > > >>>> >>> >> >>
>>>> > > > > >>>> >>>
>>>> > > > > >>>>
>>>> > > > > >>>>
>>>> > > > >
>>>> > >
>>>> https://issues.apache.org/jira/browse/CB-490?focusedCommentId=13252809#
>>>> > > > > >>>> >>> >> >> >>> >>>>>co
>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>>mment-13252809
>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>>
>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>> It doesn't make sense to
>>>>just
>>>> > > > > >>>>repackage
>>>> > > > > >>>> >>>1.6.0
>>>> > > > > >>>> >>> >> with
>>>> > > > > >>>> >>> >> >> >>>this
>>>> > > > > >>>> >>> >> >> >>> >>>>>bug
>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >>fixed as
>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > we
>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>> will have no way to know
>>>>if
>>>> > > people
>>>> > > > > >>>>are
>>>> > > > > >>>> >>> >> experiencing
>>>> > > > > >>>> >>> >> >> >>>this
>>>> > > > > >>>> >>> >> >> >>> >>>>>or
>>>> > > > > >>>> >>> >> >> >>> >>>>> >>not.
>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>>
>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>> Anis mentioned Bada also
>>>>had
>>>> > some
>>>> > > > > >>>>major
>>>> > > > > >>>> >>>issues
>>>> > > > > >>>> >>> >> >> >>>which he
>>>> > > > > >>>> >>> >> >> >>> >>>>>has
>>>> > > > > >>>> >>> >> >> >>> >>>>> >>fixed
>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> now
>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>>and
>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>> would like in a 1.6.1
>>>> release.
>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>>
>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>> Thoughts?
>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>>
>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>> -Steve
>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>
>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> >
>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >>
>>>> > > > > >>>> >>> >> >> >>> >>>>> >>
>>>> > > > > >>>> >>> >> >> >>> >>>>> >>
>>>> > > > > >>>> >>> >> >> >>> >>>>>
>>>> > > > > >>>> >>> >> >> >>> >>>>>
>>>> > > > > >>>> >>> >> >> >>> >>>
>>>> > > > > >>>> >>> >> >> >>> >
>>>> > > > > >>>> >>> >> >> >>>
>>>> > > > > >>>> >>> >> >>
>>>> > > > > >>>> >>> >> >>
>>>> > > > > >>>> >>> >>
>>>> > > > > >>>> >>>
>>>> > > > > >>>> >
>>>> > > > > >>>>
>>>> > > > >
>>>> > > > >
>>>> > > >
>>>> > >
>>>> >
>>>>
>>
Re: 1.6.1
Posted by Filip Maj <fi...@adobe.com>.
Did I f that up?
On 4/12/12 5:07 PM, "Shazron" <sh...@gmail.com> wrote:
>Sigh - user reported iOS bug
>http://groups.google.com/group/phonegap/browse_thread/thread/faad0af97dec8
>907
>(you know who you are ;)
>
>On Thu, Apr 12, 2012 at 5:05 PM, Filip Maj <fi...@adobe.com> wrote:
>> Saweet! Nice work Anis. That kills off a bunch of old issues in JIRA
>>too.
>>
>> Way to hunker down all. As Jesse pointed out to me, we did 45 emails in
>> two hours haha
>>
>> On 4/12/12 5:00 PM, "Anis KADRI" <an...@gmail.com> wrote:
>>
>>>Bada 1.2 is tagged 1.6.1. I added the new Cordova artwork,
>>>LICENSE/NOTICE
>>>files as well as the Apache source headers in every source file. I fixed
>>>all the bugs I sawS
>>>
>>>On Thu, Apr 12, 2012 at 4:38 PM, Joe Bowser <bo...@gmail.com> wrote:
>>>
>>>> Android is tagged.
>>>>
>>>> On Thu, Apr 12, 2012 at 4:36 PM, Jesse <pu...@gmail.com>
>>>>wrote:
>>>>
>>>> > Done
>>>> >
>>>> > On Thu, Apr 12, 2012 at 4:31 PM, Joe Bowser <bo...@gmail.com>
>>>>wrote:
>>>> >
>>>> > > I'd like to get the JS from the tag, but I need a tag for that.
>>>> > >
>>>> > > On Thu, Apr 12, 2012 at 4:29 PM, Jesse <pu...@gmail.com>
>>>> wrote:
>>>> > >
>>>> > > > Okay, I think it's good, tagging at 16:32 PDT if i don't hear
>>>>any
>>>> > > > complaints.
>>>> > > >
>>>> > > > On Thu, Apr 12, 2012 at 4:26 PM, Filip Maj <fi...@adobe.com>
>>>>wrote:
>>>> > > >
>>>> > > > > I just axed the existing 1.6.1 cordova-js tag
>>>> > > > >
>>>> > > > > Jesse when you feel you've got everything in there go ahead
>>>>and
>>>>tag
>>>> > JS
>>>> > > > >
>>>> > > > > On 4/12/12 4:20 PM, "Shazron" <sh...@gmail.com> wrote:
>>>> > > > >
>>>> > > > > >Reverted. Just talked to Jesse - he has commits to cordova-js
>>>> > coming,
>>>> > > > > >once those are in we can re-tag cordova-js to 1.6.1
>>>> > > > > >
>>>> > > > > >On Thu, Apr 12, 2012 at 4:12 PM, Shazron <sh...@gmail.com>
>>>> wrote:
>>>> > > > > >> I'll remove it. *grabs the shovel*
>>>> > > > > >>
>>>> > > > > >> On Thu, Apr 12, 2012 at 4:10 PM, Joe Bowser
>>>><bo...@gmail.com>
>>>> > > > wrote:
>>>> > > > > >>> You know, let's not rebase it, because it does modify the
>>>> > history.
>>>> > > > We
>>>> > > > > >>> should remove and document why we did it instead, since
>>>>that
>>>> > would
>>>> > > be
>>>> > > > > >>>more
>>>> > > > > >>> transparent. Or we could just leave it in and say "don't
>>>>do
>>>> this
>>>> > > next
>>>> > > > > >>> time". I'm not that invested in it.
>>>> > > > > >>>
>>>> > > > > >>> On Thu, Apr 12, 2012 at 4:04 PM, Shazron
>>>><sh...@gmail.com>
>>>> > > wrote:
>>>> > > > > >>>
>>>> > > > > >>>> If we take out that iOS commit in cordova-js (somehow),
>>>>it
>>>> > should
>>>> > > be
>>>> > > > > >>>> fine. cordova-ios 1.6.1 will then just be the same as
>>>>1.6.0.
>>>> > > > > >>>>
>>>> > > > > >>>> On Thu, Apr 12, 2012 at 4:02 PM, Filip Maj
>>>><fi...@adobe.com>
>>>> > wrote:
>>>> > > > > >>>> >
>>>> > > > > >>>> >>Is it too much to drop the new commit that changed the
>>>> common
>>>> > js
>>>> > > > > >>>>API, and
>>>> > > > > >>>> >>reapply it after we tag 1.6.1, and figure this one
>>>>thing
>>>>out
>>>> > for
>>>> > > > > >>>>1.7?
>>>> > > > > >>>> >
>>>> > > > > >>>> > That sounds very good to me but I am under the
>>>>impression
>>>> that
>>>> > > iOS
>>>> > > > > >>>> > requires this commit? Like I said I'm quite confused.
>>>> > > > > >>>> >
>>>> > > > > >>>> >>
>>>> > > > > >>>> >>I also have some cordova-js commits to add to 1.6.1?
>>>> Although
>>>> > > > > >>>>nothing
>>>> > > > > >>>> that
>>>> > > > > >>>> >>modifies any js outside of what is built for wp7. ( ie,
>>>>all
>>>> in
>>>> > > my
>>>> > > > > >>>> platform
>>>> > > > > >>>> >>specific plugins folder )
>>>> > > > > >>>> >>
>>>> > > > > >>>> >
>>>> > > > > >>>> > O then it sounds like I tagged the JS 1.6.1 too early
>>>> > anyways..
>>>> > > > > >>>> >
>>>> > > > > >>>> >>
>>>> > > > > >>>> >>
>>>> > > > > >>>> >>
>>>> > > > > >>>> >>On Thu, Apr 12, 2012 at 3:51 PM, Shazron
>>>><shazron@gmail.com
>>>> >
>>>> > > > wrote:
>>>> > > > > >>>> >>
>>>> > > > > >>>> >>> No - it's about a user's contribution being noted (it
>>>> > > exists), I
>>>> > > > > >>>>will
>>>> > > > > >>>> >>> move it out of the common code post-1.6.1 (I
>>>>acknowledge
>>>> my
>>>> > > > > >>>>mistake in
>>>> > > > > >>>> >>> allowing it in the first place). Can we branch off
>>>>1.6.0
>>>> > then
>>>> > > > > >>>> >>> cherry-pick Fil's latest fix for 1.6.1?
>>>> > > > > >>>> >>>
>>>> > > > > >>>> >>> On Thu, Apr 12, 2012 at 3:47 PM, Joe Bowser <
>>>> > > bowserj@gmail.com>
>>>> > > > > >>>>wrote:
>>>> > > > > >>>> >>> > OK, so you're proposing that we leave the thing in
>>>>the
>>>> > > common
>>>> > > > > >>>>JS,
>>>> > > > > >>>> even
>>>> > > > > >>>> >>> > though it's not supposed to be there.
>>>> > > > > >>>> >>> >
>>>> > > > > >>>> >>> > On Thu, Apr 12, 2012 at 3:45 PM, Shazron <
>>>> > shazron@gmail.com
>>>> > > >
>>>> > > > > >>>>wrote:
>>>> > > > > >>>> >>> >
>>>> > > > > >>>> >>> >> Will rebasing lose that commit? Then, no.
>>>> > > > > >>>> >>> >>
>>>> > > > > >>>> >>> >> On Thu, Apr 12, 2012 at 3:43 PM, Joe Bowser <
>>>> > > > bowserj@gmail.com
>>>> > > > > >
>>>> > > > > >>>> >>>wrote:
>>>> > > > > >>>> >>> >> > So, can we just rebase the head, push this out
>>>>and
>>>> get
>>>> > > this
>>>> > > > > >>>> >>>rolling?
>>>> > > > > >>>> >>> >> >
>>>> > > > > >>>> >>> >> > On Thu, Apr 12, 2012 at 3:43 PM, Filip Maj <
>>>> > > fil@adobe.com>
>>>> > > > > >>>>wrote:
>>>> > > > > >>>> >>> >> >
>>>> > > > > >>>> >>> >> >> Correct, those iOS-specific parameters (like
>>>>allow
>>>> > edit
>>>> > > > and
>>>> > > > > >>>>those
>>>> > > > > >>>> >>> ones)
>>>> > > > > >>>> >>> >> >> existed prior to cordova-js, so yeah, we left
>>>>them
>>>> in
>>>> > > > there
>>>> > > > > >>>>as we
>>>> > > > > >>>> >>> didn't
>>>> > > > > >>>> >>> >> >> want to remove without deprecation.
>>>> > > > > >>>> >>> >> >>
>>>> > > > > >>>> >>> >> >> If you can deal with the iOS issue without
>>>>needing
>>>> an
>>>> > > API
>>>> > > > > >>>> >>>extension:
>>>> > > > > >>>> >>> >> then
>>>> > > > > >>>> >>> >> >> do that. If not, leave it in there, but docs
>>>>need to
>>>> > > > > >>>>updated too.
>>>> > > > > >>>> >>> >> >>
>>>> > > > > >>>> >>> >> >> Extending and changing the public API is a long
>>>>and
>>>> > > > > >>>>difficult
>>>> > > > > >>>> >>>process
>>>> > > > > >>>> >>> >> for
>>>> > > > > >>>> >>> >> >> us and will only get tougher with every
>>>>platform
>>>>we
>>>> > add
>>>> > > > > >>>>support
>>>> > > > > >>>> >>>to.
>>>> > > > > >>>> >>> >> >>
>>>> > > > > >>>> >>> >> >> On 4/12/12 3:37 PM, "Shazron"
>>>><sh...@gmail.com>
>>>> > > wrote:
>>>> > > > > >>>> >>> >> >>
>>>> > > > > >>>> >>> >> >> >Then we have to scrap the other three(?) iOS
>>>> > parameters
>>>> > > > > >>>>ones
>>>> > > > > >>>> that
>>>> > > > > >>>> >>> >> >> >already exist in common if you noticed. Don't
>>>>know
>>>> > how
>>>> > > we
>>>> > > > > >>>>merge
>>>> > > > > >>>> >>> >> >> >(unmerge?) this one properly because taking
>>>>those
>>>> out
>>>> > > > will
>>>> > > > > >>>>break
>>>> > > > > >>>> >>> >> >> >everyone that is using it, but a deprecation
>>>>is
>>>>the
>>>> > way
>>>> > > > to
>>>> > > > > >>>>go as
>>>> > > > > >>>> >>>per
>>>> > > > > >>>> >>> >> >>
>>>>>http://wiki.apache.org/cordova/DeprecationPolicy .
>>>> > We
>>>> > > > can
>>>> > > > > >>>> remove
>>>> > > > > >>>> >>> this
>>>> > > > > >>>> >>> >> >> >new commit and I'll find a way to get this in
>>>> > somehow.
>>>> > > > > >>>> >>> >> >> >
>>>> > > > > >>>> >>> >> >> >
>>>> > > > > >>>> >>> >> >> >
>>>> > > > > >>>> >>> >> >> >On Thu, Apr 12, 2012 at 3:32 PM, Joe Bowser
>>>> > > > > >>>><bo...@gmail.com>
>>>> > > > > >>>> >>> wrote:
>>>> > > > > >>>> >>> >> >> >> The problem is that this parameter doesn't
>>>>belong
>>>> > in
>>>> > > > the
>>>> > > > > >>>> common
>>>> > > > > >>>> >>> API.
>>>> > > > > >>>> >>> >> >> >>It'd
>>>> > > > > >>>> >>> >> >> >> be just ignored in Android, but the whole
>>>>point
>>>> of
>>>> > > > > >>>>cordova-js
>>>> > > > > >>>> >>>is
>>>> > > > > >>>> >>> so
>>>> > > > > >>>> >>> >> that
>>>> > > > > >>>> >>> >> >> >> it's common. It'd look pretty screwed up to
>>>>add
>>>> > this
>>>> > > > to
>>>> > > > > >>>>the
>>>> > > > > >>>> >>>docs,
>>>> > > > > >>>> >>> >> IMO.
>>>> > > > > >>>> >>> >> >> >>
>>>> > > > > >>>> >>> >> >> >> On Thu, Apr 12, 2012 at 3:26 PM, Shazron
>>>> > > > > >>>><sh...@gmail.com>
>>>> > > > > >>>> >>> wrote:
>>>> > > > > >>>> >>> >> >> >>
>>>> > > > > >>>> >>> >> >> >>> To fix two bugs for Camera.takePicture on
>>>>iOS
>>>> > > > > >>>> >>> >> >> >>>
>>>> > > > > >>>> >>> >> >> >>> On Thu, Apr 12, 2012 at 3:24 PM, Filip Maj
>>>> > > > > >>>><fi...@adobe.com>
>>>> > > > > >>>> >>> wrote:
>>>> > > > > >>>> >>> >> >> >>> > so what's the point of this new
>>>>parameter?
>>>> > > > > >>>> >>> >> >> >>> >
>>>> > > > > >>>> >>> >> >> >>> > On 4/12/12 3:16 PM, "Shazron" <
>>>> > shazron@gmail.com>
>>>> > > > > >>>>wrote:
>>>> > > > > >>>> >>> >> >> >>> >
>>>> > > > > >>>> >>> >> >> >>> >>I did. Do we want to revert the
>>>>cordova-js? I
>>>> > can
>>>> > > > > >>>>branch
>>>> > > > > >>>> >>>1.6.0
>>>> > > > > >>>> >>> and
>>>> > > > > >>>> >>> >> >> >>> >>cherry-pick your latest commit for 1.6.1
>>>> > > > > >>>> >>> >> >> >>> >>
>>>> > > > > >>>> >>> >> >> >>> >>On Thu, Apr 12, 2012 at 3:04 PM, Filip
>>>>Maj
>>>> > > > > >>>><fi...@adobe.com>
>>>> > > > > >>>> >>> wrote:
>>>> > > > > >>>> >>> >> >> >>> >>> I saw something in the iOS commit logs
>>>>for
>>>> > this.
>>>> > > > > >>>> >>> >> >> >>> >>>
>>>> > > > > >>>> >>> >> >> >>> >>> Shaz can you comment?
>>>> > > > > >>>> >>> >> >> >>> >>>
>>>> > > > > >>>> >>> >> >> >>> >>> On 4/12/12 2:59 PM, "Joe Bowser" <
>>>> > > > bowserj@gmail.com
>>>> > > > > >
>>>> > > > > >>>> >>>wrote:
>>>> > > > > >>>> >>> >> >> >>> >>>
>>>> > > > > >>>> >>> >> >> >>> >>>>Can we revert this, since this looks
>>>>like
>>>> it's
>>>> > > > > >>>>intended
>>>> > > > > >>>> >>>for
>>>> > > > > >>>> >>> both
>>>> > > > > >>>> >>> >> >> >>> Android
>>>> > > > > >>>> >>> >> >> >>> >>>>and iOS, but I don't think it should be
>>>>in
>>>> > > 1.6.1.
>>>> > > > > >>>> >>> >> >> >>> >>>>
>>>> > > > > >>>> >>> >> >> >>> >>>>On Thu, Apr 12, 2012 at 2:52 PM, Filip
>>>>Maj <
>>>> > > > > >>>> fil@adobe.com>
>>>> > > > > >>>> >>> >> wrote:
>>>> > > > > >>>> >>> >> >> >>> >>>>
>>>> > > > > >>>> >>> >> >> >>> >>>>> I was actually just looking at that
>>>> myself.
>>>> > > > > >>>> >>> >> >> >>> >>>>>
>>>> > > > > >>>> >>> >> >> >>> >>>>> Looks like it's an iOS-only param..
>>>>sigh.
>>>> > We
>>>> > > > > >>>>gotta
>>>> > > > > >>>> stop
>>>> > > > > >>>> >>> doing
>>>> > > > > >>>> >>> >> >> >>>that,
>>>> > > > > >>>> >>> >> >> >>> >>>>> especially if we don't update
>>>> documentation.
>>>> > > > > >>>> >>> >> >> >>> >>>>>
>>>> > > > > >>>> >>> >> >> >>> >>>>> On 4/12/12 2:49 PM, "Joe Bowser"
>>>> > > > > >>>><bo...@gmail.com>
>>>> > > > > >>>> >>> wrote:
>>>> > > > > >>>> >>> >> >> >>> >>>>>
>>>> > > > > >>>> >>> >> >> >>> >>>>> >Has anyone tested the cropToSize
>>>>param
>>>> for
>>>> > > > > >>>> >>> Camera.getPicture
>>>> > > > > >>>> >>> >> >> >>>yet? I
>>>> > > > > >>>> >>> >> >> >>> >>>>> >didn't
>>>> > > > > >>>> >>> >> >> >>> >>>>> >notice that change until now.
>>>> > > > > >>>> >>> >> >> >>> >>>>> >
>>>> > > > > >>>> >>> >> >> >>> >>>>> >On Thu, Apr 12, 2012 at 2:46 PM,
>>>>Filip
>>>> Maj
>>>> > > > > >>>> >>><fil@adobe.com
>>>> > > > > >>>> >>> >
>>>> > > > > >>>> >>> >> >> >>>wrote:
>>>> > > > > >>>> >>> >> >> >>> >>>>> >
>>>> > > > > >>>> >>> >> >> >>> >>>>> >> JS tagged 1.6.1 - the build task
>>>>in
>>>>the
>>>> > JS
>>>> > > > > >>>>should
>>>> > > > > >>>> >>>work
>>>> > > > > >>>> >>> >> >> >>>properly
>>>> > > > > >>>> >>> >> >> >>> >>>>>now.
>>>> > > > > >>>> >>> >> >> >>> >>>>> >>
>>>> > > > > >>>> >>> >> >> >>> >>>>> >> FYI if anyone has to modify the
>>>>jake
>>>> > tasks
>>>> > > in
>>>> > > > > >>>>the
>>>> > > > > >>>> >>>future
>>>> > > > > >>>> >>> >> and
>>>> > > > > >>>> >>> >> >> >>>make
>>>> > > > > >>>> >>> >> >> >>> >>>>>them
>>>> > > > > >>>> >>> >> >> >>> >>>>> >> async, make sure you add the 4th
>>>> "async"
>>>> > > > > >>>>parameter
>>>> > > > > >>>> to
>>>> > > > > >>>> >>> the
>>>> > > > > >>>> >>> >> >> >>>task()
>>>> > > > > >>>> >>> >> >> >>> >>>>> >>function
>>>> > > > > >>>> >>> >> >> >>> >>>>> >> and set it to true, and call
>>>>complete()
>>>> > > when
>>>> > > > > >>>>the
>>>> > > > > >>>> >>>task is
>>>> > > > > >>>> >>> >> done.
>>>> > > > > >>>> >>> >> >> >>> >>>>> >>
>>>> > > > > >>>> >>> >> >> >>> >>>>> >> See
>>>> > > > > >>>> >>>
>>>>http://howtonode.org/intro-to-jake/async-jakefile.jsfor
>>>> > > > > >>>> >>> >> >> >>>an
>>>> > > > > >>>> >>> >> >> >>> >>>>> example.
>>>> > > > > >>>> >>> >> >> >>> >>>>> >>
>>>> > > > > >>>> >>> >> >> >>> >>>>> >> On 4/12/12 2:35 PM, "Joe Bowser"
>>>> > > > > >>>><bowserj@gmail.com
>>>> > > > > >>>> >
>>>> > > > > >>>> >>> >> wrote:
>>>> > > > > >>>> >>> >> >> >>> >>>>> >>
>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >Ready to tag once cordova-js is
>>>>tagged
>>>> > > > 1.6.1.
>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >
>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >On Thu, Apr 12, 2012 at 2:33 PM,
>>>>Anis
>>>> > > KADRI
>>>> > > > <
>>>> > > > > >>>> >>> >> >> >>> anis.kadri@gmail.com>
>>>> > > > > >>>> >>> >> >> >>> >>>>> >>wrote:
>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >
>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> I will tag my repository to
>>>>1.6.1
>>>> > before
>>>> > > > > >>>>end of
>>>> > > > > >>>> >>>day
>>>> > > > > >>>> >>> >> today
>>>> > > > > >>>> >>> >> >> >>>after
>>>> > > > > >>>> >>> >> >> >>> >>>>>some
>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> thorough testing.
>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >>
>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> On Thu, Apr 12, 2012 at 2:30
>>>>PM,
>>>> > Shazron
>>>> > > > > >>>> >>> >> >> >>><sh...@gmail.com>
>>>> > > > > >>>> >>> >> >> >>> >>>>>wrote:
>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >>
>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > I also created a 1.6.1
>>>>version
>>>>tag
>>>> > as
>>>> > > > > >>>>well in
>>>> > > > > >>>> >>> jira...
>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> >
>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > On Thu, Apr 12, 2012 at 2:29
>>>>PM,
>>>> > > Shazron
>>>> > > > > >>>> >>> >> >> >>><sh...@gmail.com>
>>>> > > > > >>>> >>> >> >> >>> >>>>> wrote:
>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > > Alright guys since 1.6.0
>>>>was
>>>> > > released,
>>>> > > > > >>>>I'm
>>>> > > > > >>>> >>>going
>>>> > > > > >>>> >>> to
>>>> > > > > >>>> >>> >> >> >>> >>>>>"Release"
>>>> > > > > >>>> >>> >> >> >>> >>>>>the
>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > > 1.6.0 version in jira and
>>>>move
>>>> > > > > >>>>outstanding
>>>> > > > > >>>> >>> issues to
>>>> > > > > >>>> >>> >> >> >>>1.7.0
>>>> > > > > >>>> >>> >> >> >>> >>>>> >>version
>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > > tag.
>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >
>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >
>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > > On Thu, Apr 12, 2012 at
>>>>2:26
>>>>PM,
>>>> > > Filip
>>>> > > > > >>>>Maj
>>>> > > > > >>>> >>> >> >> >>><fi...@adobe.com>
>>>> > > > > >>>> >>> >> >> >>> >>>>> wrote:
>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >> The JS needs patching too.
>>>> Since
>>>> > > > > >>>>adding the
>>>> > > > > >>>> >>> commit
>>>> > > > > >>>> >>> >> ID
>>>> > > > > >>>> >>> >> >> >>>into
>>>> > > > > >>>> >>> >> >> >>> >>>>>the
>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> packaging
>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >> in the jakefile, the
>>>>default
>>>> task
>>>> > > > isn't
>>>> > > > > >>>> >>>running
>>>> > > > > >>>> >>> >> >> >>>properly.
>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>
>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >> You can manually run "jake
>>>> build"
>>>> > > and
>>>> > > > > >>>>"jake
>>>> > > > > >>>> >>> test"
>>>> > > > > >>>> >>> >> but
>>>> > > > > >>>> >>> >> >> >>>not
>>>> > > > > >>>> >>> >> >> >>> >>>>> >>"jake" on
>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> its
>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >> own - gonna try to figure
>>>>it
>>>> out.
>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>
>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >> On 4/12/12 2:21 PM,
>>>>"Shazron" <
>>>> > > > > >>>> >>> shazron@gmail.com>
>>>> > > > > >>>> >>> >> >> >>>wrote:
>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>
>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>I'm good with tagging.
>>>>iOS
>>>> has a
>>>> > > few
>>>> > > > > >>>> commits
>>>> > > > > >>>> >>> (one
>>>> > > > > >>>> >>> >> >> >>>commit
>>>> > > > > >>>> >>> >> >> >>> >>>>>in
>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>cordova-js) as well. Aim
>>>>for
>>>> > first
>>>> > > > > >>>>thing
>>>> > > > > >>>> >>> tomorrow
>>>> > > > > >>>> >>> >> for
>>>> > > > > >>>> >>> >> >> >>>you
>>>> > > > > >>>> >>> >> >> >>> >>>>>to
>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>repackage?
>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>
>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>On Thu, Apr 12, 2012 at
>>>>2:17
>>>> PM,
>>>> > > > > >>>>Steven Gill
>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >><st...@gmail.com>
>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>wrote:
>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>> So a bug has been
>>>>discovered
>>>> in
>>>> > > > > >>>>Cordova
>>>> > > > > >>>> >>> Android
>>>> > > > > >>>> >>> >> that
>>>> > > > > >>>> >>> >> >> >>> >>>>>requires
>>>> > > > > >>>> >>> >> >> >>> >>>>> >>a
>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >>new
>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > tag
>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>>and
>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>> release. You can check
>>>>out
>>>> the
>>>> > > bug
>>>> > > > > >>>>on the
>>>> > > > > >>>> >>> issue
>>>> > > > > >>>> >>> >> >> >>>tracker
>>>> > > > > >>>> >>> >> >> >>> >>>>>at
>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>>
>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>>
>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> >
>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >>
>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >>
>>>> > > > > >>>> >>> >> >> >>> >>>>> >>
>>>> > > > > >>>> >>> >> >> >>> >>>>> >>
>>>> > > > > >>>> >>> >> >> >>> >>>>>
>>>> > > > > >>>> >>> >> >> >>> >>>>>
>>>> > > > > >>>> >>> >> >> >>>
>>>> > > > > >>>> >>> >> >>
>>>> > > > > >>>> >>>
>>>> > > > > >>>>
>>>> > > > > >>>>
>>>> > > > >
>>>> > >
>>>>
>>>>https://issues.apache.org/jira/browse/CB-490?focusedCommentId=13252809#
>>>> > > > > >>>> >>> >> >> >>> >>>>>co
>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>>mment-13252809
>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>>
>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>> It doesn't make sense to
>>>>just
>>>> > > > > >>>>repackage
>>>> > > > > >>>> >>>1.6.0
>>>> > > > > >>>> >>> >> with
>>>> > > > > >>>> >>> >> >> >>>this
>>>> > > > > >>>> >>> >> >> >>> >>>>>bug
>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >>fixed as
>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > we
>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>> will have no way to know
>>>>if
>>>> > > people
>>>> > > > > >>>>are
>>>> > > > > >>>> >>> >> experiencing
>>>> > > > > >>>> >>> >> >> >>>this
>>>> > > > > >>>> >>> >> >> >>> >>>>>or
>>>> > > > > >>>> >>> >> >> >>> >>>>> >>not.
>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>>
>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>> Anis mentioned Bada also
>>>>had
>>>> > some
>>>> > > > > >>>>major
>>>> > > > > >>>> >>>issues
>>>> > > > > >>>> >>> >> >> >>>which he
>>>> > > > > >>>> >>> >> >> >>> >>>>>has
>>>> > > > > >>>> >>> >> >> >>> >>>>> >>fixed
>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> now
>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>>and
>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>> would like in a 1.6.1
>>>> release.
>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>>
>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>> Thoughts?
>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>>
>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>> -Steve
>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>
>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> >
>>>> > > > > >>>> >>> >> >> >>> >>>>> >> >>
>>>> > > > > >>>> >>> >> >> >>> >>>>> >>
>>>> > > > > >>>> >>> >> >> >>> >>>>> >>
>>>> > > > > >>>> >>> >> >> >>> >>>>>
>>>> > > > > >>>> >>> >> >> >>> >>>>>
>>>> > > > > >>>> >>> >> >> >>> >>>
>>>> > > > > >>>> >>> >> >> >>> >
>>>> > > > > >>>> >>> >> >> >>>
>>>> > > > > >>>> >>> >> >>
>>>> > > > > >>>> >>> >> >>
>>>> > > > > >>>> >>> >>
>>>> > > > > >>>> >>>
>>>> > > > > >>>> >
>>>> > > > > >>>>
>>>> > > > >
>>>> > > > >
>>>> > > >
>>>> > >
>>>> >
>>>>
>>
Re: 1.6.1
Posted by Shazron <sh...@gmail.com>.
Sigh - user reported iOS bug
http://groups.google.com/group/phonegap/browse_thread/thread/faad0af97dec8907
(you know who you are ;)
On Thu, Apr 12, 2012 at 5:05 PM, Filip Maj <fi...@adobe.com> wrote:
> Saweet! Nice work Anis. That kills off a bunch of old issues in JIRA too.
>
> Way to hunker down all. As Jesse pointed out to me, we did 45 emails in
> two hours haha
>
> On 4/12/12 5:00 PM, "Anis KADRI" <an...@gmail.com> wrote:
>
>>Bada 1.2 is tagged 1.6.1. I added the new Cordova artwork, LICENSE/NOTICE
>>files as well as the Apache source headers in every source file. I fixed
>>all the bugs I sawS
>>
>>On Thu, Apr 12, 2012 at 4:38 PM, Joe Bowser <bo...@gmail.com> wrote:
>>
>>> Android is tagged.
>>>
>>> On Thu, Apr 12, 2012 at 4:36 PM, Jesse <pu...@gmail.com> wrote:
>>>
>>> > Done
>>> >
>>> > On Thu, Apr 12, 2012 at 4:31 PM, Joe Bowser <bo...@gmail.com> wrote:
>>> >
>>> > > I'd like to get the JS from the tag, but I need a tag for that.
>>> > >
>>> > > On Thu, Apr 12, 2012 at 4:29 PM, Jesse <pu...@gmail.com>
>>> wrote:
>>> > >
>>> > > > Okay, I think it's good, tagging at 16:32 PDT if i don't hear any
>>> > > > complaints.
>>> > > >
>>> > > > On Thu, Apr 12, 2012 at 4:26 PM, Filip Maj <fi...@adobe.com> wrote:
>>> > > >
>>> > > > > I just axed the existing 1.6.1 cordova-js tag
>>> > > > >
>>> > > > > Jesse when you feel you've got everything in there go ahead and
>>>tag
>>> > JS
>>> > > > >
>>> > > > > On 4/12/12 4:20 PM, "Shazron" <sh...@gmail.com> wrote:
>>> > > > >
>>> > > > > >Reverted. Just talked to Jesse - he has commits to cordova-js
>>> > coming,
>>> > > > > >once those are in we can re-tag cordova-js to 1.6.1
>>> > > > > >
>>> > > > > >On Thu, Apr 12, 2012 at 4:12 PM, Shazron <sh...@gmail.com>
>>> wrote:
>>> > > > > >> I'll remove it. *grabs the shovel*
>>> > > > > >>
>>> > > > > >> On Thu, Apr 12, 2012 at 4:10 PM, Joe Bowser
>>><bo...@gmail.com>
>>> > > > wrote:
>>> > > > > >>> You know, let's not rebase it, because it does modify the
>>> > history.
>>> > > > We
>>> > > > > >>> should remove and document why we did it instead, since that
>>> > would
>>> > > be
>>> > > > > >>>more
>>> > > > > >>> transparent. Or we could just leave it in and say "don't do
>>> this
>>> > > next
>>> > > > > >>> time". I'm not that invested in it.
>>> > > > > >>>
>>> > > > > >>> On Thu, Apr 12, 2012 at 4:04 PM, Shazron <sh...@gmail.com>
>>> > > wrote:
>>> > > > > >>>
>>> > > > > >>>> If we take out that iOS commit in cordova-js (somehow), it
>>> > should
>>> > > be
>>> > > > > >>>> fine. cordova-ios 1.6.1 will then just be the same as
>>>1.6.0.
>>> > > > > >>>>
>>> > > > > >>>> On Thu, Apr 12, 2012 at 4:02 PM, Filip Maj <fi...@adobe.com>
>>> > wrote:
>>> > > > > >>>> >
>>> > > > > >>>> >>Is it too much to drop the new commit that changed the
>>> common
>>> > js
>>> > > > > >>>>API, and
>>> > > > > >>>> >>reapply it after we tag 1.6.1, and figure this one thing
>>>out
>>> > for
>>> > > > > >>>>1.7?
>>> > > > > >>>> >
>>> > > > > >>>> > That sounds very good to me but I am under the impression
>>> that
>>> > > iOS
>>> > > > > >>>> > requires this commit? Like I said I'm quite confused.
>>> > > > > >>>> >
>>> > > > > >>>> >>
>>> > > > > >>>> >>I also have some cordova-js commits to add to 1.6.1?
>>> Although
>>> > > > > >>>>nothing
>>> > > > > >>>> that
>>> > > > > >>>> >>modifies any js outside of what is built for wp7. ( ie,
>>>all
>>> in
>>> > > my
>>> > > > > >>>> platform
>>> > > > > >>>> >>specific plugins folder )
>>> > > > > >>>> >>
>>> > > > > >>>> >
>>> > > > > >>>> > O then it sounds like I tagged the JS 1.6.1 too early
>>> > anyways..
>>> > > > > >>>> >
>>> > > > > >>>> >>
>>> > > > > >>>> >>
>>> > > > > >>>> >>
>>> > > > > >>>> >>On Thu, Apr 12, 2012 at 3:51 PM, Shazron
>>><shazron@gmail.com
>>> >
>>> > > > wrote:
>>> > > > > >>>> >>
>>> > > > > >>>> >>> No - it's about a user's contribution being noted (it
>>> > > exists), I
>>> > > > > >>>>will
>>> > > > > >>>> >>> move it out of the common code post-1.6.1 (I
>>>acknowledge
>>> my
>>> > > > > >>>>mistake in
>>> > > > > >>>> >>> allowing it in the first place). Can we branch off
>>>1.6.0
>>> > then
>>> > > > > >>>> >>> cherry-pick Fil's latest fix for 1.6.1?
>>> > > > > >>>> >>>
>>> > > > > >>>> >>> On Thu, Apr 12, 2012 at 3:47 PM, Joe Bowser <
>>> > > bowserj@gmail.com>
>>> > > > > >>>>wrote:
>>> > > > > >>>> >>> > OK, so you're proposing that we leave the thing in
>>>the
>>> > > common
>>> > > > > >>>>JS,
>>> > > > > >>>> even
>>> > > > > >>>> >>> > though it's not supposed to be there.
>>> > > > > >>>> >>> >
>>> > > > > >>>> >>> > On Thu, Apr 12, 2012 at 3:45 PM, Shazron <
>>> > shazron@gmail.com
>>> > > >
>>> > > > > >>>>wrote:
>>> > > > > >>>> >>> >
>>> > > > > >>>> >>> >> Will rebasing lose that commit? Then, no.
>>> > > > > >>>> >>> >>
>>> > > > > >>>> >>> >> On Thu, Apr 12, 2012 at 3:43 PM, Joe Bowser <
>>> > > > bowserj@gmail.com
>>> > > > > >
>>> > > > > >>>> >>>wrote:
>>> > > > > >>>> >>> >> > So, can we just rebase the head, push this out and
>>> get
>>> > > this
>>> > > > > >>>> >>>rolling?
>>> > > > > >>>> >>> >> >
>>> > > > > >>>> >>> >> > On Thu, Apr 12, 2012 at 3:43 PM, Filip Maj <
>>> > > fil@adobe.com>
>>> > > > > >>>>wrote:
>>> > > > > >>>> >>> >> >
>>> > > > > >>>> >>> >> >> Correct, those iOS-specific parameters (like
>>>allow
>>> > edit
>>> > > > and
>>> > > > > >>>>those
>>> > > > > >>>> >>> ones)
>>> > > > > >>>> >>> >> >> existed prior to cordova-js, so yeah, we left
>>>them
>>> in
>>> > > > there
>>> > > > > >>>>as we
>>> > > > > >>>> >>> didn't
>>> > > > > >>>> >>> >> >> want to remove without deprecation.
>>> > > > > >>>> >>> >> >>
>>> > > > > >>>> >>> >> >> If you can deal with the iOS issue without
>>>needing
>>> an
>>> > > API
>>> > > > > >>>> >>>extension:
>>> > > > > >>>> >>> >> then
>>> > > > > >>>> >>> >> >> do that. If not, leave it in there, but docs
>>>need to
>>> > > > > >>>>updated too.
>>> > > > > >>>> >>> >> >>
>>> > > > > >>>> >>> >> >> Extending and changing the public API is a long
>>>and
>>> > > > > >>>>difficult
>>> > > > > >>>> >>>process
>>> > > > > >>>> >>> >> for
>>> > > > > >>>> >>> >> >> us and will only get tougher with every platform
>>>we
>>> > add
>>> > > > > >>>>support
>>> > > > > >>>> >>>to.
>>> > > > > >>>> >>> >> >>
>>> > > > > >>>> >>> >> >> On 4/12/12 3:37 PM, "Shazron" <sh...@gmail.com>
>>> > > wrote:
>>> > > > > >>>> >>> >> >>
>>> > > > > >>>> >>> >> >> >Then we have to scrap the other three(?) iOS
>>> > parameters
>>> > > > > >>>>ones
>>> > > > > >>>> that
>>> > > > > >>>> >>> >> >> >already exist in common if you noticed. Don't
>>>know
>>> > how
>>> > > we
>>> > > > > >>>>merge
>>> > > > > >>>> >>> >> >> >(unmerge?) this one properly because taking
>>>those
>>> out
>>> > > > will
>>> > > > > >>>>break
>>> > > > > >>>> >>> >> >> >everyone that is using it, but a deprecation is
>>>the
>>> > way
>>> > > > to
>>> > > > > >>>>go as
>>> > > > > >>>> >>>per
>>> > > > > >>>> >>> >> >>
>>>>http://wiki.apache.org/cordova/DeprecationPolicy .
>>> > We
>>> > > > can
>>> > > > > >>>> remove
>>> > > > > >>>> >>> this
>>> > > > > >>>> >>> >> >> >new commit and I'll find a way to get this in
>>> > somehow.
>>> > > > > >>>> >>> >> >> >
>>> > > > > >>>> >>> >> >> >
>>> > > > > >>>> >>> >> >> >
>>> > > > > >>>> >>> >> >> >On Thu, Apr 12, 2012 at 3:32 PM, Joe Bowser
>>> > > > > >>>><bo...@gmail.com>
>>> > > > > >>>> >>> wrote:
>>> > > > > >>>> >>> >> >> >> The problem is that this parameter doesn't
>>>belong
>>> > in
>>> > > > the
>>> > > > > >>>> common
>>> > > > > >>>> >>> API.
>>> > > > > >>>> >>> >> >> >>It'd
>>> > > > > >>>> >>> >> >> >> be just ignored in Android, but the whole
>>>point
>>> of
>>> > > > > >>>>cordova-js
>>> > > > > >>>> >>>is
>>> > > > > >>>> >>> so
>>> > > > > >>>> >>> >> that
>>> > > > > >>>> >>> >> >> >> it's common. It'd look pretty screwed up to
>>>add
>>> > this
>>> > > > to
>>> > > > > >>>>the
>>> > > > > >>>> >>>docs,
>>> > > > > >>>> >>> >> IMO.
>>> > > > > >>>> >>> >> >> >>
>>> > > > > >>>> >>> >> >> >> On Thu, Apr 12, 2012 at 3:26 PM, Shazron
>>> > > > > >>>><sh...@gmail.com>
>>> > > > > >>>> >>> wrote:
>>> > > > > >>>> >>> >> >> >>
>>> > > > > >>>> >>> >> >> >>> To fix two bugs for Camera.takePicture on iOS
>>> > > > > >>>> >>> >> >> >>>
>>> > > > > >>>> >>> >> >> >>> On Thu, Apr 12, 2012 at 3:24 PM, Filip Maj
>>> > > > > >>>><fi...@adobe.com>
>>> > > > > >>>> >>> wrote:
>>> > > > > >>>> >>> >> >> >>> > so what's the point of this new parameter?
>>> > > > > >>>> >>> >> >> >>> >
>>> > > > > >>>> >>> >> >> >>> > On 4/12/12 3:16 PM, "Shazron" <
>>> > shazron@gmail.com>
>>> > > > > >>>>wrote:
>>> > > > > >>>> >>> >> >> >>> >
>>> > > > > >>>> >>> >> >> >>> >>I did. Do we want to revert the
>>>cordova-js? I
>>> > can
>>> > > > > >>>>branch
>>> > > > > >>>> >>>1.6.0
>>> > > > > >>>> >>> and
>>> > > > > >>>> >>> >> >> >>> >>cherry-pick your latest commit for 1.6.1
>>> > > > > >>>> >>> >> >> >>> >>
>>> > > > > >>>> >>> >> >> >>> >>On Thu, Apr 12, 2012 at 3:04 PM, Filip Maj
>>> > > > > >>>><fi...@adobe.com>
>>> > > > > >>>> >>> wrote:
>>> > > > > >>>> >>> >> >> >>> >>> I saw something in the iOS commit logs
>>>for
>>> > this.
>>> > > > > >>>> >>> >> >> >>> >>>
>>> > > > > >>>> >>> >> >> >>> >>> Shaz can you comment?
>>> > > > > >>>> >>> >> >> >>> >>>
>>> > > > > >>>> >>> >> >> >>> >>> On 4/12/12 2:59 PM, "Joe Bowser" <
>>> > > > bowserj@gmail.com
>>> > > > > >
>>> > > > > >>>> >>>wrote:
>>> > > > > >>>> >>> >> >> >>> >>>
>>> > > > > >>>> >>> >> >> >>> >>>>Can we revert this, since this looks like
>>> it's
>>> > > > > >>>>intended
>>> > > > > >>>> >>>for
>>> > > > > >>>> >>> both
>>> > > > > >>>> >>> >> >> >>> Android
>>> > > > > >>>> >>> >> >> >>> >>>>and iOS, but I don't think it should be
>>>in
>>> > > 1.6.1.
>>> > > > > >>>> >>> >> >> >>> >>>>
>>> > > > > >>>> >>> >> >> >>> >>>>On Thu, Apr 12, 2012 at 2:52 PM, Filip
>>>Maj <
>>> > > > > >>>> fil@adobe.com>
>>> > > > > >>>> >>> >> wrote:
>>> > > > > >>>> >>> >> >> >>> >>>>
>>> > > > > >>>> >>> >> >> >>> >>>>> I was actually just looking at that
>>> myself.
>>> > > > > >>>> >>> >> >> >>> >>>>>
>>> > > > > >>>> >>> >> >> >>> >>>>> Looks like it's an iOS-only param..
>>>sigh.
>>> > We
>>> > > > > >>>>gotta
>>> > > > > >>>> stop
>>> > > > > >>>> >>> doing
>>> > > > > >>>> >>> >> >> >>>that,
>>> > > > > >>>> >>> >> >> >>> >>>>> especially if we don't update
>>> documentation.
>>> > > > > >>>> >>> >> >> >>> >>>>>
>>> > > > > >>>> >>> >> >> >>> >>>>> On 4/12/12 2:49 PM, "Joe Bowser"
>>> > > > > >>>><bo...@gmail.com>
>>> > > > > >>>> >>> wrote:
>>> > > > > >>>> >>> >> >> >>> >>>>>
>>> > > > > >>>> >>> >> >> >>> >>>>> >Has anyone tested the cropToSize param
>>> for
>>> > > > > >>>> >>> Camera.getPicture
>>> > > > > >>>> >>> >> >> >>>yet? I
>>> > > > > >>>> >>> >> >> >>> >>>>> >didn't
>>> > > > > >>>> >>> >> >> >>> >>>>> >notice that change until now.
>>> > > > > >>>> >>> >> >> >>> >>>>> >
>>> > > > > >>>> >>> >> >> >>> >>>>> >On Thu, Apr 12, 2012 at 2:46 PM, Filip
>>> Maj
>>> > > > > >>>> >>><fil@adobe.com
>>> > > > > >>>> >>> >
>>> > > > > >>>> >>> >> >> >>>wrote:
>>> > > > > >>>> >>> >> >> >>> >>>>> >
>>> > > > > >>>> >>> >> >> >>> >>>>> >> JS tagged 1.6.1 - the build task in
>>>the
>>> > JS
>>> > > > > >>>>should
>>> > > > > >>>> >>>work
>>> > > > > >>>> >>> >> >> >>>properly
>>> > > > > >>>> >>> >> >> >>> >>>>>now.
>>> > > > > >>>> >>> >> >> >>> >>>>> >>
>>> > > > > >>>> >>> >> >> >>> >>>>> >> FYI if anyone has to modify the jake
>>> > tasks
>>> > > in
>>> > > > > >>>>the
>>> > > > > >>>> >>>future
>>> > > > > >>>> >>> >> and
>>> > > > > >>>> >>> >> >> >>>make
>>> > > > > >>>> >>> >> >> >>> >>>>>them
>>> > > > > >>>> >>> >> >> >>> >>>>> >> async, make sure you add the 4th
>>> "async"
>>> > > > > >>>>parameter
>>> > > > > >>>> to
>>> > > > > >>>> >>> the
>>> > > > > >>>> >>> >> >> >>>task()
>>> > > > > >>>> >>> >> >> >>> >>>>> >>function
>>> > > > > >>>> >>> >> >> >>> >>>>> >> and set it to true, and call
>>>complete()
>>> > > when
>>> > > > > >>>>the
>>> > > > > >>>> >>>task is
>>> > > > > >>>> >>> >> done.
>>> > > > > >>>> >>> >> >> >>> >>>>> >>
>>> > > > > >>>> >>> >> >> >>> >>>>> >> See
>>> > > > > >>>> >>> http://howtonode.org/intro-to-jake/async-jakefile.jsfor
>>> > > > > >>>> >>> >> >> >>>an
>>> > > > > >>>> >>> >> >> >>> >>>>> example.
>>> > > > > >>>> >>> >> >> >>> >>>>> >>
>>> > > > > >>>> >>> >> >> >>> >>>>> >> On 4/12/12 2:35 PM, "Joe Bowser"
>>> > > > > >>>><bowserj@gmail.com
>>> > > > > >>>> >
>>> > > > > >>>> >>> >> wrote:
>>> > > > > >>>> >>> >> >> >>> >>>>> >>
>>> > > > > >>>> >>> >> >> >>> >>>>> >> >Ready to tag once cordova-js is
>>>tagged
>>> > > > 1.6.1.
>>> > > > > >>>> >>> >> >> >>> >>>>> >> >
>>> > > > > >>>> >>> >> >> >>> >>>>> >> >On Thu, Apr 12, 2012 at 2:33 PM,
>>>Anis
>>> > > KADRI
>>> > > > <
>>> > > > > >>>> >>> >> >> >>> anis.kadri@gmail.com>
>>> > > > > >>>> >>> >> >> >>> >>>>> >>wrote:
>>> > > > > >>>> >>> >> >> >>> >>>>> >> >
>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> I will tag my repository to 1.6.1
>>> > before
>>> > > > > >>>>end of
>>> > > > > >>>> >>>day
>>> > > > > >>>> >>> >> today
>>> > > > > >>>> >>> >> >> >>>after
>>> > > > > >>>> >>> >> >> >>> >>>>>some
>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> thorough testing.
>>> > > > > >>>> >>> >> >> >>> >>>>> >> >>
>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> On Thu, Apr 12, 2012 at 2:30 PM,
>>> > Shazron
>>> > > > > >>>> >>> >> >> >>><sh...@gmail.com>
>>> > > > > >>>> >>> >> >> >>> >>>>>wrote:
>>> > > > > >>>> >>> >> >> >>> >>>>> >> >>
>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > I also created a 1.6.1 version
>>>tag
>>> > as
>>> > > > > >>>>well in
>>> > > > > >>>> >>> jira...
>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> >
>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > On Thu, Apr 12, 2012 at 2:29
>>>PM,
>>> > > Shazron
>>> > > > > >>>> >>> >> >> >>><sh...@gmail.com>
>>> > > > > >>>> >>> >> >> >>> >>>>> wrote:
>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > > Alright guys since 1.6.0 was
>>> > > released,
>>> > > > > >>>>I'm
>>> > > > > >>>> >>>going
>>> > > > > >>>> >>> to
>>> > > > > >>>> >>> >> >> >>> >>>>>"Release"
>>> > > > > >>>> >>> >> >> >>> >>>>>the
>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > > 1.6.0 version in jira and
>>>move
>>> > > > > >>>>outstanding
>>> > > > > >>>> >>> issues to
>>> > > > > >>>> >>> >> >> >>>1.7.0
>>> > > > > >>>> >>> >> >> >>> >>>>> >>version
>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > > tag.
>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >
>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >
>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > > On Thu, Apr 12, 2012 at 2:26
>>>PM,
>>> > > Filip
>>> > > > > >>>>Maj
>>> > > > > >>>> >>> >> >> >>><fi...@adobe.com>
>>> > > > > >>>> >>> >> >> >>> >>>>> wrote:
>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >> The JS needs patching too.
>>> Since
>>> > > > > >>>>adding the
>>> > > > > >>>> >>> commit
>>> > > > > >>>> >>> >> ID
>>> > > > > >>>> >>> >> >> >>>into
>>> > > > > >>>> >>> >> >> >>> >>>>>the
>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> packaging
>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >> in the jakefile, the default
>>> task
>>> > > > isn't
>>> > > > > >>>> >>>running
>>> > > > > >>>> >>> >> >> >>>properly.
>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>
>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >> You can manually run "jake
>>> build"
>>> > > and
>>> > > > > >>>>"jake
>>> > > > > >>>> >>> test"
>>> > > > > >>>> >>> >> but
>>> > > > > >>>> >>> >> >> >>>not
>>> > > > > >>>> >>> >> >> >>> >>>>> >>"jake" on
>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> its
>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >> own - gonna try to figure it
>>> out.
>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>
>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >> On 4/12/12 2:21 PM,
>>>"Shazron" <
>>> > > > > >>>> >>> shazron@gmail.com>
>>> > > > > >>>> >>> >> >> >>>wrote:
>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>
>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>I'm good with tagging. iOS
>>> has a
>>> > > few
>>> > > > > >>>> commits
>>> > > > > >>>> >>> (one
>>> > > > > >>>> >>> >> >> >>>commit
>>> > > > > >>>> >>> >> >> >>> >>>>>in
>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>cordova-js) as well. Aim for
>>> > first
>>> > > > > >>>>thing
>>> > > > > >>>> >>> tomorrow
>>> > > > > >>>> >>> >> for
>>> > > > > >>>> >>> >> >> >>>you
>>> > > > > >>>> >>> >> >> >>> >>>>>to
>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>repackage?
>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>
>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>On Thu, Apr 12, 2012 at 2:17
>>> PM,
>>> > > > > >>>>Steven Gill
>>> > > > > >>>> >>> >> >> >>> >>>>> >> >><st...@gmail.com>
>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>wrote:
>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>> So a bug has been
>>>discovered
>>> in
>>> > > > > >>>>Cordova
>>> > > > > >>>> >>> Android
>>> > > > > >>>> >>> >> that
>>> > > > > >>>> >>> >> >> >>> >>>>>requires
>>> > > > > >>>> >>> >> >> >>> >>>>> >>a
>>> > > > > >>>> >>> >> >> >>> >>>>> >> >>new
>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > tag
>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>>and
>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>> release. You can check out
>>> the
>>> > > bug
>>> > > > > >>>>on the
>>> > > > > >>>> >>> issue
>>> > > > > >>>> >>> >> >> >>>tracker
>>> > > > > >>>> >>> >> >> >>> >>>>>at
>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>>
>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>>
>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> >
>>> > > > > >>>> >>> >> >> >>> >>>>> >> >>
>>> > > > > >>>> >>> >> >> >>> >>>>> >> >>
>>> > > > > >>>> >>> >> >> >>> >>>>> >>
>>> > > > > >>>> >>> >> >> >>> >>>>> >>
>>> > > > > >>>> >>> >> >> >>> >>>>>
>>> > > > > >>>> >>> >> >> >>> >>>>>
>>> > > > > >>>> >>> >> >> >>>
>>> > > > > >>>> >>> >> >>
>>> > > > > >>>> >>>
>>> > > > > >>>>
>>> > > > > >>>>
>>> > > > >
>>> > >
>>> https://issues.apache.org/jira/browse/CB-490?focusedCommentId=13252809#
>>> > > > > >>>> >>> >> >> >>> >>>>>co
>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>>mment-13252809
>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>>
>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>> It doesn't make sense to
>>>just
>>> > > > > >>>>repackage
>>> > > > > >>>> >>>1.6.0
>>> > > > > >>>> >>> >> with
>>> > > > > >>>> >>> >> >> >>>this
>>> > > > > >>>> >>> >> >> >>> >>>>>bug
>>> > > > > >>>> >>> >> >> >>> >>>>> >> >>fixed as
>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > we
>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>> will have no way to know
>>>if
>>> > > people
>>> > > > > >>>>are
>>> > > > > >>>> >>> >> experiencing
>>> > > > > >>>> >>> >> >> >>>this
>>> > > > > >>>> >>> >> >> >>> >>>>>or
>>> > > > > >>>> >>> >> >> >>> >>>>> >>not.
>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>>
>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>> Anis mentioned Bada also
>>>had
>>> > some
>>> > > > > >>>>major
>>> > > > > >>>> >>>issues
>>> > > > > >>>> >>> >> >> >>>which he
>>> > > > > >>>> >>> >> >> >>> >>>>>has
>>> > > > > >>>> >>> >> >> >>> >>>>> >>fixed
>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> now
>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>>and
>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>> would like in a 1.6.1
>>> release.
>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>>
>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>> Thoughts?
>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>>
>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>> -Steve
>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>
>>> > > > > >>>> >>> >> >> >>> >>>>> >> >> >
>>> > > > > >>>> >>> >> >> >>> >>>>> >> >>
>>> > > > > >>>> >>> >> >> >>> >>>>> >>
>>> > > > > >>>> >>> >> >> >>> >>>>> >>
>>> > > > > >>>> >>> >> >> >>> >>>>>
>>> > > > > >>>> >>> >> >> >>> >>>>>
>>> > > > > >>>> >>> >> >> >>> >>>
>>> > > > > >>>> >>> >> >> >>> >
>>> > > > > >>>> >>> >> >> >>>
>>> > > > > >>>> >>> >> >>
>>> > > > > >>>> >>> >> >>
>>> > > > > >>>> >>> >>
>>> > > > > >>>> >>>
>>> > > > > >>>> >
>>> > > > > >>>>
>>> > > > >
>>> > > > >
>>> > > >
>>> > >
>>> >
>>>
>
Re: 1.6.1
Posted by Filip Maj <fi...@adobe.com>.
Saweet! Nice work Anis. That kills off a bunch of old issues in JIRA too.
Way to hunker down all. As Jesse pointed out to me, we did 45 emails in
two hours haha
On 4/12/12 5:00 PM, "Anis KADRI" <an...@gmail.com> wrote:
>Bada 1.2 is tagged 1.6.1. I added the new Cordova artwork, LICENSE/NOTICE
>files as well as the Apache source headers in every source file. I fixed
>all the bugs I saw.
>
>On Thu, Apr 12, 2012 at 4:38 PM, Joe Bowser <bo...@gmail.com> wrote:
>
>> Android is tagged.
>>
>> On Thu, Apr 12, 2012 at 4:36 PM, Jesse <pu...@gmail.com> wrote:
>>
>> > Done
>> >
>> > On Thu, Apr 12, 2012 at 4:31 PM, Joe Bowser <bo...@gmail.com> wrote:
>> >
>> > > I'd like to get the JS from the tag, but I need a tag for that.
>> > >
>> > > On Thu, Apr 12, 2012 at 4:29 PM, Jesse <pu...@gmail.com>
>> wrote:
>> > >
>> > > > Okay, I think it's good, tagging at 16:32 PDT if i don't hear any
>> > > > complaints.
>> > > >
>> > > > On Thu, Apr 12, 2012 at 4:26 PM, Filip Maj <fi...@adobe.com> wrote:
>> > > >
>> > > > > I just axed the existing 1.6.1 cordova-js tag
>> > > > >
>> > > > > Jesse when you feel you've got everything in there go ahead and
>>tag
>> > JS
>> > > > >
>> > > > > On 4/12/12 4:20 PM, "Shazron" <sh...@gmail.com> wrote:
>> > > > >
>> > > > > >Reverted. Just talked to Jesse - he has commits to cordova-js
>> > coming,
>> > > > > >once those are in we can re-tag cordova-js to 1.6.1
>> > > > > >
>> > > > > >On Thu, Apr 12, 2012 at 4:12 PM, Shazron <sh...@gmail.com>
>> wrote:
>> > > > > >> I'll remove it. *grabs the shovel*
>> > > > > >>
>> > > > > >> On Thu, Apr 12, 2012 at 4:10 PM, Joe Bowser
>><bo...@gmail.com>
>> > > > wrote:
>> > > > > >>> You know, let's not rebase it, because it does modify the
>> > history.
>> > > > We
>> > > > > >>> should remove and document why we did it instead, since that
>> > would
>> > > be
>> > > > > >>>more
>> > > > > >>> transparent. Or we could just leave it in and say "don't do
>> this
>> > > next
>> > > > > >>> time". I'm not that invested in it.
>> > > > > >>>
>> > > > > >>> On Thu, Apr 12, 2012 at 4:04 PM, Shazron <sh...@gmail.com>
>> > > wrote:
>> > > > > >>>
>> > > > > >>>> If we take out that iOS commit in cordova-js (somehow), it
>> > should
>> > > be
>> > > > > >>>> fine. cordova-ios 1.6.1 will then just be the same as
>>1.6.0.
>> > > > > >>>>
>> > > > > >>>> On Thu, Apr 12, 2012 at 4:02 PM, Filip Maj <fi...@adobe.com>
>> > wrote:
>> > > > > >>>> >
>> > > > > >>>> >>Is it too much to drop the new commit that changed the
>> common
>> > js
>> > > > > >>>>API, and
>> > > > > >>>> >>reapply it after we tag 1.6.1, and figure this one thing
>>out
>> > for
>> > > > > >>>>1.7?
>> > > > > >>>> >
>> > > > > >>>> > That sounds very good to me but I am under the impression
>> that
>> > > iOS
>> > > > > >>>> > requires this commit? Like I said I'm quite confused.
>> > > > > >>>> >
>> > > > > >>>> >>
>> > > > > >>>> >>I also have some cordova-js commits to add to 1.6.1?
>> Although
>> > > > > >>>>nothing
>> > > > > >>>> that
>> > > > > >>>> >>modifies any js outside of what is built for wp7. ( ie,
>>all
>> in
>> > > my
>> > > > > >>>> platform
>> > > > > >>>> >>specific plugins folder )
>> > > > > >>>> >>
>> > > > > >>>> >
>> > > > > >>>> > O then it sounds like I tagged the JS 1.6.1 too early
>> > anyways..
>> > > > > >>>> >
>> > > > > >>>> >>
>> > > > > >>>> >>
>> > > > > >>>> >>
>> > > > > >>>> >>On Thu, Apr 12, 2012 at 3:51 PM, Shazron
>><shazron@gmail.com
>> >
>> > > > wrote:
>> > > > > >>>> >>
>> > > > > >>>> >>> No - it's about a user's contribution being noted (it
>> > > exists), I
>> > > > > >>>>will
>> > > > > >>>> >>> move it out of the common code post-1.6.1 (I
>>acknowledge
>> my
>> > > > > >>>>mistake in
>> > > > > >>>> >>> allowing it in the first place). Can we branch off
>>1.6.0
>> > then
>> > > > > >>>> >>> cherry-pick Fil's latest fix for 1.6.1?
>> > > > > >>>> >>>
>> > > > > >>>> >>> On Thu, Apr 12, 2012 at 3:47 PM, Joe Bowser <
>> > > bowserj@gmail.com>
>> > > > > >>>>wrote:
>> > > > > >>>> >>> > OK, so you're proposing that we leave the thing in
>>the
>> > > common
>> > > > > >>>>JS,
>> > > > > >>>> even
>> > > > > >>>> >>> > though it's not supposed to be there.
>> > > > > >>>> >>> >
>> > > > > >>>> >>> > On Thu, Apr 12, 2012 at 3:45 PM, Shazron <
>> > shazron@gmail.com
>> > > >
>> > > > > >>>>wrote:
>> > > > > >>>> >>> >
>> > > > > >>>> >>> >> Will rebasing lose that commit? Then, no.
>> > > > > >>>> >>> >>
>> > > > > >>>> >>> >> On Thu, Apr 12, 2012 at 3:43 PM, Joe Bowser <
>> > > > bowserj@gmail.com
>> > > > > >
>> > > > > >>>> >>>wrote:
>> > > > > >>>> >>> >> > So, can we just rebase the head, push this out and
>> get
>> > > this
>> > > > > >>>> >>>rolling?
>> > > > > >>>> >>> >> >
>> > > > > >>>> >>> >> > On Thu, Apr 12, 2012 at 3:43 PM, Filip Maj <
>> > > fil@adobe.com>
>> > > > > >>>>wrote:
>> > > > > >>>> >>> >> >
>> > > > > >>>> >>> >> >> Correct, those iOS-specific parameters (like
>>allow
>> > edit
>> > > > and
>> > > > > >>>>those
>> > > > > >>>> >>> ones)
>> > > > > >>>> >>> >> >> existed prior to cordova-js, so yeah, we left
>>them
>> in
>> > > > there
>> > > > > >>>>as we
>> > > > > >>>> >>> didn't
>> > > > > >>>> >>> >> >> want to remove without deprecation.
>> > > > > >>>> >>> >> >>
>> > > > > >>>> >>> >> >> If you can deal with the iOS issue without
>>needing
>> an
>> > > API
>> > > > > >>>> >>>extension:
>> > > > > >>>> >>> >> then
>> > > > > >>>> >>> >> >> do that. If not, leave it in there, but docs
>>need to
>> > > > > >>>>updated too.
>> > > > > >>>> >>> >> >>
>> > > > > >>>> >>> >> >> Extending and changing the public API is a long
>>and
>> > > > > >>>>difficult
>> > > > > >>>> >>>process
>> > > > > >>>> >>> >> for
>> > > > > >>>> >>> >> >> us and will only get tougher with every platform
>>we
>> > add
>> > > > > >>>>support
>> > > > > >>>> >>>to.
>> > > > > >>>> >>> >> >>
>> > > > > >>>> >>> >> >> On 4/12/12 3:37 PM, "Shazron" <sh...@gmail.com>
>> > > wrote:
>> > > > > >>>> >>> >> >>
>> > > > > >>>> >>> >> >> >Then we have to scrap the other three(?) iOS
>> > parameters
>> > > > > >>>>ones
>> > > > > >>>> that
>> > > > > >>>> >>> >> >> >already exist in common if you noticed. Don't
>>know
>> > how
>> > > we
>> > > > > >>>>merge
>> > > > > >>>> >>> >> >> >(unmerge?) this one properly because taking
>>those
>> out
>> > > > will
>> > > > > >>>>break
>> > > > > >>>> >>> >> >> >everyone that is using it, but a deprecation is
>>the
>> > way
>> > > > to
>> > > > > >>>>go as
>> > > > > >>>> >>>per
>> > > > > >>>> >>> >> >>
>>>http://wiki.apache.org/cordova/DeprecationPolicy .
>> > We
>> > > > can
>> > > > > >>>> remove
>> > > > > >>>> >>> this
>> > > > > >>>> >>> >> >> >new commit and I'll find a way to get this in
>> > somehow.
>> > > > > >>>> >>> >> >> >
>> > > > > >>>> >>> >> >> >
>> > > > > >>>> >>> >> >> >
>> > > > > >>>> >>> >> >> >On Thu, Apr 12, 2012 at 3:32 PM, Joe Bowser
>> > > > > >>>><bo...@gmail.com>
>> > > > > >>>> >>> wrote:
>> > > > > >>>> >>> >> >> >> The problem is that this parameter doesn't
>>belong
>> > in
>> > > > the
>> > > > > >>>> common
>> > > > > >>>> >>> API.
>> > > > > >>>> >>> >> >> >>It'd
>> > > > > >>>> >>> >> >> >> be just ignored in Android, but the whole
>>point
>> of
>> > > > > >>>>cordova-js
>> > > > > >>>> >>>is
>> > > > > >>>> >>> so
>> > > > > >>>> >>> >> that
>> > > > > >>>> >>> >> >> >> it's common. It'd look pretty screwed up to
>>add
>> > this
>> > > > to
>> > > > > >>>>the
>> > > > > >>>> >>>docs,
>> > > > > >>>> >>> >> IMO.
>> > > > > >>>> >>> >> >> >>
>> > > > > >>>> >>> >> >> >> On Thu, Apr 12, 2012 at 3:26 PM, Shazron
>> > > > > >>>><sh...@gmail.com>
>> > > > > >>>> >>> wrote:
>> > > > > >>>> >>> >> >> >>
>> > > > > >>>> >>> >> >> >>> To fix two bugs for Camera.takePicture on iOS
>> > > > > >>>> >>> >> >> >>>
>> > > > > >>>> >>> >> >> >>> On Thu, Apr 12, 2012 at 3:24 PM, Filip Maj
>> > > > > >>>><fi...@adobe.com>
>> > > > > >>>> >>> wrote:
>> > > > > >>>> >>> >> >> >>> > so what's the point of this new parameter?
>> > > > > >>>> >>> >> >> >>> >
>> > > > > >>>> >>> >> >> >>> > On 4/12/12 3:16 PM, "Shazron" <
>> > shazron@gmail.com>
>> > > > > >>>>wrote:
>> > > > > >>>> >>> >> >> >>> >
>> > > > > >>>> >>> >> >> >>> >>I did. Do we want to revert the
>>cordova-js? I
>> > can
>> > > > > >>>>branch
>> > > > > >>>> >>>1.6.0
>> > > > > >>>> >>> and
>> > > > > >>>> >>> >> >> >>> >>cherry-pick your latest commit for 1.6.1
>> > > > > >>>> >>> >> >> >>> >>
>> > > > > >>>> >>> >> >> >>> >>On Thu, Apr 12, 2012 at 3:04 PM, Filip Maj
>> > > > > >>>><fi...@adobe.com>
>> > > > > >>>> >>> wrote:
>> > > > > >>>> >>> >> >> >>> >>> I saw something in the iOS commit logs
>>for
>> > this.
>> > > > > >>>> >>> >> >> >>> >>>
>> > > > > >>>> >>> >> >> >>> >>> Shaz can you comment?
>> > > > > >>>> >>> >> >> >>> >>>
>> > > > > >>>> >>> >> >> >>> >>> On 4/12/12 2:59 PM, "Joe Bowser" <
>> > > > bowserj@gmail.com
>> > > > > >
>> > > > > >>>> >>>wrote:
>> > > > > >>>> >>> >> >> >>> >>>
>> > > > > >>>> >>> >> >> >>> >>>>Can we revert this, since this looks like
>> it's
>> > > > > >>>>intended
>> > > > > >>>> >>>for
>> > > > > >>>> >>> both
>> > > > > >>>> >>> >> >> >>> Android
>> > > > > >>>> >>> >> >> >>> >>>>and iOS, but I don't think it should be
>>in
>> > > 1.6.1.
>> > > > > >>>> >>> >> >> >>> >>>>
>> > > > > >>>> >>> >> >> >>> >>>>On Thu, Apr 12, 2012 at 2:52 PM, Filip
>>Maj <
>> > > > > >>>> fil@adobe.com>
>> > > > > >>>> >>> >> wrote:
>> > > > > >>>> >>> >> >> >>> >>>>
>> > > > > >>>> >>> >> >> >>> >>>>> I was actually just looking at that
>> myself.
>> > > > > >>>> >>> >> >> >>> >>>>>
>> > > > > >>>> >>> >> >> >>> >>>>> Looks like it's an iOS-only param..
>>sigh.
>> > We
>> > > > > >>>>gotta
>> > > > > >>>> stop
>> > > > > >>>> >>> doing
>> > > > > >>>> >>> >> >> >>>that,
>> > > > > >>>> >>> >> >> >>> >>>>> especially if we don't update
>> documentation.
>> > > > > >>>> >>> >> >> >>> >>>>>
>> > > > > >>>> >>> >> >> >>> >>>>> On 4/12/12 2:49 PM, "Joe Bowser"
>> > > > > >>>><bo...@gmail.com>
>> > > > > >>>> >>> wrote:
>> > > > > >>>> >>> >> >> >>> >>>>>
>> > > > > >>>> >>> >> >> >>> >>>>> >Has anyone tested the cropToSize param
>> for
>> > > > > >>>> >>> Camera.getPicture
>> > > > > >>>> >>> >> >> >>>yet? I
>> > > > > >>>> >>> >> >> >>> >>>>> >didn't
>> > > > > >>>> >>> >> >> >>> >>>>> >notice that change until now.
>> > > > > >>>> >>> >> >> >>> >>>>> >
>> > > > > >>>> >>> >> >> >>> >>>>> >On Thu, Apr 12, 2012 at 2:46 PM, Filip
>> Maj
>> > > > > >>>> >>><fil@adobe.com
>> > > > > >>>> >>> >
>> > > > > >>>> >>> >> >> >>>wrote:
>> > > > > >>>> >>> >> >> >>> >>>>> >
>> > > > > >>>> >>> >> >> >>> >>>>> >> JS tagged 1.6.1 - the build task in
>>the
>> > JS
>> > > > > >>>>should
>> > > > > >>>> >>>work
>> > > > > >>>> >>> >> >> >>>properly
>> > > > > >>>> >>> >> >> >>> >>>>>now.
>> > > > > >>>> >>> >> >> >>> >>>>> >>
>> > > > > >>>> >>> >> >> >>> >>>>> >> FYI if anyone has to modify the jake
>> > tasks
>> > > in
>> > > > > >>>>the
>> > > > > >>>> >>>future
>> > > > > >>>> >>> >> and
>> > > > > >>>> >>> >> >> >>>make
>> > > > > >>>> >>> >> >> >>> >>>>>them
>> > > > > >>>> >>> >> >> >>> >>>>> >> async, make sure you add the 4th
>> "async"
>> > > > > >>>>parameter
>> > > > > >>>> to
>> > > > > >>>> >>> the
>> > > > > >>>> >>> >> >> >>>task()
>> > > > > >>>> >>> >> >> >>> >>>>> >>function
>> > > > > >>>> >>> >> >> >>> >>>>> >> and set it to true, and call
>>complete()
>> > > when
>> > > > > >>>>the
>> > > > > >>>> >>>task is
>> > > > > >>>> >>> >> done.
>> > > > > >>>> >>> >> >> >>> >>>>> >>
>> > > > > >>>> >>> >> >> >>> >>>>> >> See
>> > > > > >>>> >>> http://howtonode.org/intro-to-jake/async-jakefile.jsfor
>> > > > > >>>> >>> >> >> >>>an
>> > > > > >>>> >>> >> >> >>> >>>>> example.
>> > > > > >>>> >>> >> >> >>> >>>>> >>
>> > > > > >>>> >>> >> >> >>> >>>>> >> On 4/12/12 2:35 PM, "Joe Bowser"
>> > > > > >>>><bowserj@gmail.com
>> > > > > >>>> >
>> > > > > >>>> >>> >> wrote:
>> > > > > >>>> >>> >> >> >>> >>>>> >>
>> > > > > >>>> >>> >> >> >>> >>>>> >> >Ready to tag once cordova-js is
>>tagged
>> > > > 1.6.1.
>> > > > > >>>> >>> >> >> >>> >>>>> >> >
>> > > > > >>>> >>> >> >> >>> >>>>> >> >On Thu, Apr 12, 2012 at 2:33 PM,
>>Anis
>> > > KADRI
>> > > > <
>> > > > > >>>> >>> >> >> >>> anis.kadri@gmail.com>
>> > > > > >>>> >>> >> >> >>> >>>>> >>wrote:
>> > > > > >>>> >>> >> >> >>> >>>>> >> >
>> > > > > >>>> >>> >> >> >>> >>>>> >> >> I will tag my repository to 1.6.1
>> > before
>> > > > > >>>>end of
>> > > > > >>>> >>>day
>> > > > > >>>> >>> >> today
>> > > > > >>>> >>> >> >> >>>after
>> > > > > >>>> >>> >> >> >>> >>>>>some
>> > > > > >>>> >>> >> >> >>> >>>>> >> >> thorough testing.
>> > > > > >>>> >>> >> >> >>> >>>>> >> >>
>> > > > > >>>> >>> >> >> >>> >>>>> >> >> On Thu, Apr 12, 2012 at 2:30 PM,
>> > Shazron
>> > > > > >>>> >>> >> >> >>><sh...@gmail.com>
>> > > > > >>>> >>> >> >> >>> >>>>>wrote:
>> > > > > >>>> >>> >> >> >>> >>>>> >> >>
>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > I also created a 1.6.1 version
>>tag
>> > as
>> > > > > >>>>well in
>> > > > > >>>> >>> jira...
>> > > > > >>>> >>> >> >> >>> >>>>> >> >> >
>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > On Thu, Apr 12, 2012 at 2:29
>>PM,
>> > > Shazron
>> > > > > >>>> >>> >> >> >>><sh...@gmail.com>
>> > > > > >>>> >>> >> >> >>> >>>>> wrote:
>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > > Alright guys since 1.6.0 was
>> > > released,
>> > > > > >>>>I'm
>> > > > > >>>> >>>going
>> > > > > >>>> >>> to
>> > > > > >>>> >>> >> >> >>> >>>>>"Release"
>> > > > > >>>> >>> >> >> >>> >>>>>the
>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > > 1.6.0 version in jira and
>>move
>> > > > > >>>>outstanding
>> > > > > >>>> >>> issues to
>> > > > > >>>> >>> >> >> >>>1.7.0
>> > > > > >>>> >>> >> >> >>> >>>>> >>version
>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > > tag.
>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >
>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >
>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > > On Thu, Apr 12, 2012 at 2:26
>>PM,
>> > > Filip
>> > > > > >>>>Maj
>> > > > > >>>> >>> >> >> >>><fi...@adobe.com>
>> > > > > >>>> >>> >> >> >>> >>>>> wrote:
>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >> The JS needs patching too.
>> Since
>> > > > > >>>>adding the
>> > > > > >>>> >>> commit
>> > > > > >>>> >>> >> ID
>> > > > > >>>> >>> >> >> >>>into
>> > > > > >>>> >>> >> >> >>> >>>>>the
>> > > > > >>>> >>> >> >> >>> >>>>> >> >> packaging
>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >> in the jakefile, the default
>> task
>> > > > isn't
>> > > > > >>>> >>>running
>> > > > > >>>> >>> >> >> >>>properly.
>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>
>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >> You can manually run "jake
>> build"
>> > > and
>> > > > > >>>>"jake
>> > > > > >>>> >>> test"
>> > > > > >>>> >>> >> but
>> > > > > >>>> >>> >> >> >>>not
>> > > > > >>>> >>> >> >> >>> >>>>> >>"jake" on
>> > > > > >>>> >>> >> >> >>> >>>>> >> >> its
>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >> own - gonna try to figure it
>> out.
>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>
>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >> On 4/12/12 2:21 PM,
>>"Shazron" <
>> > > > > >>>> >>> shazron@gmail.com>
>> > > > > >>>> >>> >> >> >>>wrote:
>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>
>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>I'm good with tagging. iOS
>> has a
>> > > few
>> > > > > >>>> commits
>> > > > > >>>> >>> (one
>> > > > > >>>> >>> >> >> >>>commit
>> > > > > >>>> >>> >> >> >>> >>>>>in
>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>cordova-js) as well. Aim for
>> > first
>> > > > > >>>>thing
>> > > > > >>>> >>> tomorrow
>> > > > > >>>> >>> >> for
>> > > > > >>>> >>> >> >> >>>you
>> > > > > >>>> >>> >> >> >>> >>>>>to
>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>repackage?
>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>
>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>On Thu, Apr 12, 2012 at 2:17
>> PM,
>> > > > > >>>>Steven Gill
>> > > > > >>>> >>> >> >> >>> >>>>> >> >><st...@gmail.com>
>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>wrote:
>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>> So a bug has been
>>discovered
>> in
>> > > > > >>>>Cordova
>> > > > > >>>> >>> Android
>> > > > > >>>> >>> >> that
>> > > > > >>>> >>> >> >> >>> >>>>>requires
>> > > > > >>>> >>> >> >> >>> >>>>> >>a
>> > > > > >>>> >>> >> >> >>> >>>>> >> >>new
>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > tag
>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>>and
>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>> release. You can check out
>> the
>> > > bug
>> > > > > >>>>on the
>> > > > > >>>> >>> issue
>> > > > > >>>> >>> >> >> >>>tracker
>> > > > > >>>> >>> >> >> >>> >>>>>at
>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>>
>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>>
>> > > > > >>>> >>> >> >> >>> >>>>> >> >> >
>> > > > > >>>> >>> >> >> >>> >>>>> >> >>
>> > > > > >>>> >>> >> >> >>> >>>>> >> >>
>> > > > > >>>> >>> >> >> >>> >>>>> >>
>> > > > > >>>> >>> >> >> >>> >>>>> >>
>> > > > > >>>> >>> >> >> >>> >>>>>
>> > > > > >>>> >>> >> >> >>> >>>>>
>> > > > > >>>> >>> >> >> >>>
>> > > > > >>>> >>> >> >>
>> > > > > >>>> >>>
>> > > > > >>>>
>> > > > > >>>>
>> > > > >
>> > >
>> https://issues.apache.org/jira/browse/CB-490?focusedCommentId=13252809#
>> > > > > >>>> >>> >> >> >>> >>>>>co
>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>>mment-13252809
>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>>
>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>> It doesn't make sense to
>>just
>> > > > > >>>>repackage
>> > > > > >>>> >>>1.6.0
>> > > > > >>>> >>> >> with
>> > > > > >>>> >>> >> >> >>>this
>> > > > > >>>> >>> >> >> >>> >>>>>bug
>> > > > > >>>> >>> >> >> >>> >>>>> >> >>fixed as
>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > we
>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>> will have no way to know
>>if
>> > > people
>> > > > > >>>>are
>> > > > > >>>> >>> >> experiencing
>> > > > > >>>> >>> >> >> >>>this
>> > > > > >>>> >>> >> >> >>> >>>>>or
>> > > > > >>>> >>> >> >> >>> >>>>> >>not.
>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>>
>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>> Anis mentioned Bada also
>>had
>> > some
>> > > > > >>>>major
>> > > > > >>>> >>>issues
>> > > > > >>>> >>> >> >> >>>which he
>> > > > > >>>> >>> >> >> >>> >>>>>has
>> > > > > >>>> >>> >> >> >>> >>>>> >>fixed
>> > > > > >>>> >>> >> >> >>> >>>>> >> >> now
>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>>and
>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>> would like in a 1.6.1
>> release.
>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>>
>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>> Thoughts?
>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>>
>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>> -Steve
>> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>
>> > > > > >>>> >>> >> >> >>> >>>>> >> >> >
>> > > > > >>>> >>> >> >> >>> >>>>> >> >>
>> > > > > >>>> >>> >> >> >>> >>>>> >>
>> > > > > >>>> >>> >> >> >>> >>>>> >>
>> > > > > >>>> >>> >> >> >>> >>>>>
>> > > > > >>>> >>> >> >> >>> >>>>>
>> > > > > >>>> >>> >> >> >>> >>>
>> > > > > >>>> >>> >> >> >>> >
>> > > > > >>>> >>> >> >> >>>
>> > > > > >>>> >>> >> >>
>> > > > > >>>> >>> >> >>
>> > > > > >>>> >>> >>
>> > > > > >>>> >>>
>> > > > > >>>> >
>> > > > > >>>>
>> > > > >
>> > > > >
>> > > >
>> > >
>> >
>>
Re: 1.6.1
Posted by Anis KADRI <an...@gmail.com>.
Bada 1.2 is tagged 1.6.1. I added the new Cordova artwork, LICENSE/NOTICE
files as well as the Apache source headers in every source file. I fixed
all the bugs I saw.
On Thu, Apr 12, 2012 at 4:38 PM, Joe Bowser <bo...@gmail.com> wrote:
> Android is tagged.
>
> On Thu, Apr 12, 2012 at 4:36 PM, Jesse <pu...@gmail.com> wrote:
>
> > Done
> >
> > On Thu, Apr 12, 2012 at 4:31 PM, Joe Bowser <bo...@gmail.com> wrote:
> >
> > > I'd like to get the JS from the tag, but I need a tag for that.
> > >
> > > On Thu, Apr 12, 2012 at 4:29 PM, Jesse <pu...@gmail.com>
> wrote:
> > >
> > > > Okay, I think it's good, tagging at 16:32 PDT if i don't hear any
> > > > complaints.
> > > >
> > > > On Thu, Apr 12, 2012 at 4:26 PM, Filip Maj <fi...@adobe.com> wrote:
> > > >
> > > > > I just axed the existing 1.6.1 cordova-js tag
> > > > >
> > > > > Jesse when you feel you've got everything in there go ahead and tag
> > JS
> > > > >
> > > > > On 4/12/12 4:20 PM, "Shazron" <sh...@gmail.com> wrote:
> > > > >
> > > > > >Reverted. Just talked to Jesse - he has commits to cordova-js
> > coming,
> > > > > >once those are in we can re-tag cordova-js to 1.6.1
> > > > > >
> > > > > >On Thu, Apr 12, 2012 at 4:12 PM, Shazron <sh...@gmail.com>
> wrote:
> > > > > >> I'll remove it. *grabs the shovel*
> > > > > >>
> > > > > >> On Thu, Apr 12, 2012 at 4:10 PM, Joe Bowser <bo...@gmail.com>
> > > > wrote:
> > > > > >>> You know, let's not rebase it, because it does modify the
> > history.
> > > > We
> > > > > >>> should remove and document why we did it instead, since that
> > would
> > > be
> > > > > >>>more
> > > > > >>> transparent. Or we could just leave it in and say "don't do
> this
> > > next
> > > > > >>> time". I'm not that invested in it.
> > > > > >>>
> > > > > >>> On Thu, Apr 12, 2012 at 4:04 PM, Shazron <sh...@gmail.com>
> > > wrote:
> > > > > >>>
> > > > > >>>> If we take out that iOS commit in cordova-js (somehow), it
> > should
> > > be
> > > > > >>>> fine. cordova-ios 1.6.1 will then just be the same as 1.6.0.
> > > > > >>>>
> > > > > >>>> On Thu, Apr 12, 2012 at 4:02 PM, Filip Maj <fi...@adobe.com>
> > wrote:
> > > > > >>>> >
> > > > > >>>> >>Is it too much to drop the new commit that changed the
> common
> > js
> > > > > >>>>API, and
> > > > > >>>> >>reapply it after we tag 1.6.1, and figure this one thing out
> > for
> > > > > >>>>1.7?
> > > > > >>>> >
> > > > > >>>> > That sounds very good to me but I am under the impression
> that
> > > iOS
> > > > > >>>> > requires this commit? Like I said I'm quite confused.
> > > > > >>>> >
> > > > > >>>> >>
> > > > > >>>> >>I also have some cordova-js commits to add to 1.6.1?
> Although
> > > > > >>>>nothing
> > > > > >>>> that
> > > > > >>>> >>modifies any js outside of what is built for wp7. ( ie, all
> in
> > > my
> > > > > >>>> platform
> > > > > >>>> >>specific plugins folder )
> > > > > >>>> >>
> > > > > >>>> >
> > > > > >>>> > O then it sounds like I tagged the JS 1.6.1 too early
> > anyways..
> > > > > >>>> >
> > > > > >>>> >>
> > > > > >>>> >>
> > > > > >>>> >>
> > > > > >>>> >>On Thu, Apr 12, 2012 at 3:51 PM, Shazron <shazron@gmail.com
> >
> > > > wrote:
> > > > > >>>> >>
> > > > > >>>> >>> No - it's about a user's contribution being noted (it
> > > exists), I
> > > > > >>>>will
> > > > > >>>> >>> move it out of the common code post-1.6.1 (I acknowledge
> my
> > > > > >>>>mistake in
> > > > > >>>> >>> allowing it in the first place). Can we branch off 1.6.0
> > then
> > > > > >>>> >>> cherry-pick Fil's latest fix for 1.6.1?
> > > > > >>>> >>>
> > > > > >>>> >>> On Thu, Apr 12, 2012 at 3:47 PM, Joe Bowser <
> > > bowserj@gmail.com>
> > > > > >>>>wrote:
> > > > > >>>> >>> > OK, so you're proposing that we leave the thing in the
> > > common
> > > > > >>>>JS,
> > > > > >>>> even
> > > > > >>>> >>> > though it's not supposed to be there.
> > > > > >>>> >>> >
> > > > > >>>> >>> > On Thu, Apr 12, 2012 at 3:45 PM, Shazron <
> > shazron@gmail.com
> > > >
> > > > > >>>>wrote:
> > > > > >>>> >>> >
> > > > > >>>> >>> >> Will rebasing lose that commit? Then, no.
> > > > > >>>> >>> >>
> > > > > >>>> >>> >> On Thu, Apr 12, 2012 at 3:43 PM, Joe Bowser <
> > > > bowserj@gmail.com
> > > > > >
> > > > > >>>> >>>wrote:
> > > > > >>>> >>> >> > So, can we just rebase the head, push this out and
> get
> > > this
> > > > > >>>> >>>rolling?
> > > > > >>>> >>> >> >
> > > > > >>>> >>> >> > On Thu, Apr 12, 2012 at 3:43 PM, Filip Maj <
> > > fil@adobe.com>
> > > > > >>>>wrote:
> > > > > >>>> >>> >> >
> > > > > >>>> >>> >> >> Correct, those iOS-specific parameters (like allow
> > edit
> > > > and
> > > > > >>>>those
> > > > > >>>> >>> ones)
> > > > > >>>> >>> >> >> existed prior to cordova-js, so yeah, we left them
> in
> > > > there
> > > > > >>>>as we
> > > > > >>>> >>> didn't
> > > > > >>>> >>> >> >> want to remove without deprecation.
> > > > > >>>> >>> >> >>
> > > > > >>>> >>> >> >> If you can deal with the iOS issue without needing
> an
> > > API
> > > > > >>>> >>>extension:
> > > > > >>>> >>> >> then
> > > > > >>>> >>> >> >> do that. If not, leave it in there, but docs need to
> > > > > >>>>updated too.
> > > > > >>>> >>> >> >>
> > > > > >>>> >>> >> >> Extending and changing the public API is a long and
> > > > > >>>>difficult
> > > > > >>>> >>>process
> > > > > >>>> >>> >> for
> > > > > >>>> >>> >> >> us and will only get tougher with every platform we
> > add
> > > > > >>>>support
> > > > > >>>> >>>to.
> > > > > >>>> >>> >> >>
> > > > > >>>> >>> >> >> On 4/12/12 3:37 PM, "Shazron" <sh...@gmail.com>
> > > wrote:
> > > > > >>>> >>> >> >>
> > > > > >>>> >>> >> >> >Then we have to scrap the other three(?) iOS
> > parameters
> > > > > >>>>ones
> > > > > >>>> that
> > > > > >>>> >>> >> >> >already exist in common if you noticed. Don't know
> > how
> > > we
> > > > > >>>>merge
> > > > > >>>> >>> >> >> >(unmerge?) this one properly because taking those
> out
> > > > will
> > > > > >>>>break
> > > > > >>>> >>> >> >> >everyone that is using it, but a deprecation is the
> > way
> > > > to
> > > > > >>>>go as
> > > > > >>>> >>>per
> > > > > >>>> >>> >> >> >http://wiki.apache.org/cordova/DeprecationPolicy .
> > We
> > > > can
> > > > > >>>> remove
> > > > > >>>> >>> this
> > > > > >>>> >>> >> >> >new commit and I'll find a way to get this in
> > somehow.
> > > > > >>>> >>> >> >> >
> > > > > >>>> >>> >> >> >
> > > > > >>>> >>> >> >> >
> > > > > >>>> >>> >> >> >On Thu, Apr 12, 2012 at 3:32 PM, Joe Bowser
> > > > > >>>><bo...@gmail.com>
> > > > > >>>> >>> wrote:
> > > > > >>>> >>> >> >> >> The problem is that this parameter doesn't belong
> > in
> > > > the
> > > > > >>>> common
> > > > > >>>> >>> API.
> > > > > >>>> >>> >> >> >>It'd
> > > > > >>>> >>> >> >> >> be just ignored in Android, but the whole point
> of
> > > > > >>>>cordova-js
> > > > > >>>> >>>is
> > > > > >>>> >>> so
> > > > > >>>> >>> >> that
> > > > > >>>> >>> >> >> >> it's common. It'd look pretty screwed up to add
> > this
> > > > to
> > > > > >>>>the
> > > > > >>>> >>>docs,
> > > > > >>>> >>> >> IMO.
> > > > > >>>> >>> >> >> >>
> > > > > >>>> >>> >> >> >> On Thu, Apr 12, 2012 at 3:26 PM, Shazron
> > > > > >>>><sh...@gmail.com>
> > > > > >>>> >>> wrote:
> > > > > >>>> >>> >> >> >>
> > > > > >>>> >>> >> >> >>> To fix two bugs for Camera.takePicture on iOS
> > > > > >>>> >>> >> >> >>>
> > > > > >>>> >>> >> >> >>> On Thu, Apr 12, 2012 at 3:24 PM, Filip Maj
> > > > > >>>><fi...@adobe.com>
> > > > > >>>> >>> wrote:
> > > > > >>>> >>> >> >> >>> > so what's the point of this new parameter?
> > > > > >>>> >>> >> >> >>> >
> > > > > >>>> >>> >> >> >>> > On 4/12/12 3:16 PM, "Shazron" <
> > shazron@gmail.com>
> > > > > >>>>wrote:
> > > > > >>>> >>> >> >> >>> >
> > > > > >>>> >>> >> >> >>> >>I did. Do we want to revert the cordova-js? I
> > can
> > > > > >>>>branch
> > > > > >>>> >>>1.6.0
> > > > > >>>> >>> and
> > > > > >>>> >>> >> >> >>> >>cherry-pick your latest commit for 1.6.1
> > > > > >>>> >>> >> >> >>> >>
> > > > > >>>> >>> >> >> >>> >>On Thu, Apr 12, 2012 at 3:04 PM, Filip Maj
> > > > > >>>><fi...@adobe.com>
> > > > > >>>> >>> wrote:
> > > > > >>>> >>> >> >> >>> >>> I saw something in the iOS commit logs for
> > this.
> > > > > >>>> >>> >> >> >>> >>>
> > > > > >>>> >>> >> >> >>> >>> Shaz can you comment?
> > > > > >>>> >>> >> >> >>> >>>
> > > > > >>>> >>> >> >> >>> >>> On 4/12/12 2:59 PM, "Joe Bowser" <
> > > > bowserj@gmail.com
> > > > > >
> > > > > >>>> >>>wrote:
> > > > > >>>> >>> >> >> >>> >>>
> > > > > >>>> >>> >> >> >>> >>>>Can we revert this, since this looks like
> it's
> > > > > >>>>intended
> > > > > >>>> >>>for
> > > > > >>>> >>> both
> > > > > >>>> >>> >> >> >>> Android
> > > > > >>>> >>> >> >> >>> >>>>and iOS, but I don't think it should be in
> > > 1.6.1.
> > > > > >>>> >>> >> >> >>> >>>>
> > > > > >>>> >>> >> >> >>> >>>>On Thu, Apr 12, 2012 at 2:52 PM, Filip Maj <
> > > > > >>>> fil@adobe.com>
> > > > > >>>> >>> >> wrote:
> > > > > >>>> >>> >> >> >>> >>>>
> > > > > >>>> >>> >> >> >>> >>>>> I was actually just looking at that
> myself.
> > > > > >>>> >>> >> >> >>> >>>>>
> > > > > >>>> >>> >> >> >>> >>>>> Looks like it's an iOS-only param.. sigh.
> > We
> > > > > >>>>gotta
> > > > > >>>> stop
> > > > > >>>> >>> doing
> > > > > >>>> >>> >> >> >>>that,
> > > > > >>>> >>> >> >> >>> >>>>> especially if we don't update
> documentation.
> > > > > >>>> >>> >> >> >>> >>>>>
> > > > > >>>> >>> >> >> >>> >>>>> On 4/12/12 2:49 PM, "Joe Bowser"
> > > > > >>>><bo...@gmail.com>
> > > > > >>>> >>> wrote:
> > > > > >>>> >>> >> >> >>> >>>>>
> > > > > >>>> >>> >> >> >>> >>>>> >Has anyone tested the cropToSize param
> for
> > > > > >>>> >>> Camera.getPicture
> > > > > >>>> >>> >> >> >>>yet? I
> > > > > >>>> >>> >> >> >>> >>>>> >didn't
> > > > > >>>> >>> >> >> >>> >>>>> >notice that change until now.
> > > > > >>>> >>> >> >> >>> >>>>> >
> > > > > >>>> >>> >> >> >>> >>>>> >On Thu, Apr 12, 2012 at 2:46 PM, Filip
> Maj
> > > > > >>>> >>><fil@adobe.com
> > > > > >>>> >>> >
> > > > > >>>> >>> >> >> >>>wrote:
> > > > > >>>> >>> >> >> >>> >>>>> >
> > > > > >>>> >>> >> >> >>> >>>>> >> JS tagged 1.6.1 - the build task in the
> > JS
> > > > > >>>>should
> > > > > >>>> >>>work
> > > > > >>>> >>> >> >> >>>properly
> > > > > >>>> >>> >> >> >>> >>>>>now.
> > > > > >>>> >>> >> >> >>> >>>>> >>
> > > > > >>>> >>> >> >> >>> >>>>> >> FYI if anyone has to modify the jake
> > tasks
> > > in
> > > > > >>>>the
> > > > > >>>> >>>future
> > > > > >>>> >>> >> and
> > > > > >>>> >>> >> >> >>>make
> > > > > >>>> >>> >> >> >>> >>>>>them
> > > > > >>>> >>> >> >> >>> >>>>> >> async, make sure you add the 4th
> "async"
> > > > > >>>>parameter
> > > > > >>>> to
> > > > > >>>> >>> the
> > > > > >>>> >>> >> >> >>>task()
> > > > > >>>> >>> >> >> >>> >>>>> >>function
> > > > > >>>> >>> >> >> >>> >>>>> >> and set it to true, and call complete()
> > > when
> > > > > >>>>the
> > > > > >>>> >>>task is
> > > > > >>>> >>> >> done.
> > > > > >>>> >>> >> >> >>> >>>>> >>
> > > > > >>>> >>> >> >> >>> >>>>> >> See
> > > > > >>>> >>> http://howtonode.org/intro-to-jake/async-jakefile.jsfor
> > > > > >>>> >>> >> >> >>>an
> > > > > >>>> >>> >> >> >>> >>>>> example.
> > > > > >>>> >>> >> >> >>> >>>>> >>
> > > > > >>>> >>> >> >> >>> >>>>> >> On 4/12/12 2:35 PM, "Joe Bowser"
> > > > > >>>><bowserj@gmail.com
> > > > > >>>> >
> > > > > >>>> >>> >> wrote:
> > > > > >>>> >>> >> >> >>> >>>>> >>
> > > > > >>>> >>> >> >> >>> >>>>> >> >Ready to tag once cordova-js is tagged
> > > > 1.6.1.
> > > > > >>>> >>> >> >> >>> >>>>> >> >
> > > > > >>>> >>> >> >> >>> >>>>> >> >On Thu, Apr 12, 2012 at 2:33 PM, Anis
> > > KADRI
> > > > <
> > > > > >>>> >>> >> >> >>> anis.kadri@gmail.com>
> > > > > >>>> >>> >> >> >>> >>>>> >>wrote:
> > > > > >>>> >>> >> >> >>> >>>>> >> >
> > > > > >>>> >>> >> >> >>> >>>>> >> >> I will tag my repository to 1.6.1
> > before
> > > > > >>>>end of
> > > > > >>>> >>>day
> > > > > >>>> >>> >> today
> > > > > >>>> >>> >> >> >>>after
> > > > > >>>> >>> >> >> >>> >>>>>some
> > > > > >>>> >>> >> >> >>> >>>>> >> >> thorough testing.
> > > > > >>>> >>> >> >> >>> >>>>> >> >>
> > > > > >>>> >>> >> >> >>> >>>>> >> >> On Thu, Apr 12, 2012 at 2:30 PM,
> > Shazron
> > > > > >>>> >>> >> >> >>><sh...@gmail.com>
> > > > > >>>> >>> >> >> >>> >>>>>wrote:
> > > > > >>>> >>> >> >> >>> >>>>> >> >>
> > > > > >>>> >>> >> >> >>> >>>>> >> >> > I also created a 1.6.1 version tag
> > as
> > > > > >>>>well in
> > > > > >>>> >>> jira...
> > > > > >>>> >>> >> >> >>> >>>>> >> >> >
> > > > > >>>> >>> >> >> >>> >>>>> >> >> > On Thu, Apr 12, 2012 at 2:29 PM,
> > > Shazron
> > > > > >>>> >>> >> >> >>><sh...@gmail.com>
> > > > > >>>> >>> >> >> >>> >>>>> wrote:
> > > > > >>>> >>> >> >> >>> >>>>> >> >> > > Alright guys since 1.6.0 was
> > > released,
> > > > > >>>>I'm
> > > > > >>>> >>>going
> > > > > >>>> >>> to
> > > > > >>>> >>> >> >> >>> >>>>>"Release"
> > > > > >>>> >>> >> >> >>> >>>>>the
> > > > > >>>> >>> >> >> >>> >>>>> >> >> > > 1.6.0 version in jira and move
> > > > > >>>>outstanding
> > > > > >>>> >>> issues to
> > > > > >>>> >>> >> >> >>>1.7.0
> > > > > >>>> >>> >> >> >>> >>>>> >>version
> > > > > >>>> >>> >> >> >>> >>>>> >> >> > > tag.
> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >
> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >
> > > > > >>>> >>> >> >> >>> >>>>> >> >> > > On Thu, Apr 12, 2012 at 2:26 PM,
> > > Filip
> > > > > >>>>Maj
> > > > > >>>> >>> >> >> >>><fi...@adobe.com>
> > > > > >>>> >>> >> >> >>> >>>>> wrote:
> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >> The JS needs patching too.
> Since
> > > > > >>>>adding the
> > > > > >>>> >>> commit
> > > > > >>>> >>> >> ID
> > > > > >>>> >>> >> >> >>>into
> > > > > >>>> >>> >> >> >>> >>>>>the
> > > > > >>>> >>> >> >> >>> >>>>> >> >> packaging
> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >> in the jakefile, the default
> task
> > > > isn't
> > > > > >>>> >>>running
> > > > > >>>> >>> >> >> >>>properly.
> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>
> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >> You can manually run "jake
> build"
> > > and
> > > > > >>>>"jake
> > > > > >>>> >>> test"
> > > > > >>>> >>> >> but
> > > > > >>>> >>> >> >> >>>not
> > > > > >>>> >>> >> >> >>> >>>>> >>"jake" on
> > > > > >>>> >>> >> >> >>> >>>>> >> >> its
> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >> own - gonna try to figure it
> out.
> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>
> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >> On 4/12/12 2:21 PM, "Shazron" <
> > > > > >>>> >>> shazron@gmail.com>
> > > > > >>>> >>> >> >> >>>wrote:
> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>
> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>I'm good with tagging. iOS
> has a
> > > few
> > > > > >>>> commits
> > > > > >>>> >>> (one
> > > > > >>>> >>> >> >> >>>commit
> > > > > >>>> >>> >> >> >>> >>>>>in
> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>cordova-js) as well. Aim for
> > first
> > > > > >>>>thing
> > > > > >>>> >>> tomorrow
> > > > > >>>> >>> >> for
> > > > > >>>> >>> >> >> >>>you
> > > > > >>>> >>> >> >> >>> >>>>>to
> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>repackage?
> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>
> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>On Thu, Apr 12, 2012 at 2:17
> PM,
> > > > > >>>>Steven Gill
> > > > > >>>> >>> >> >> >>> >>>>> >> >><st...@gmail.com>
> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>wrote:
> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>> So a bug has been discovered
> in
> > > > > >>>>Cordova
> > > > > >>>> >>> Android
> > > > > >>>> >>> >> that
> > > > > >>>> >>> >> >> >>> >>>>>requires
> > > > > >>>> >>> >> >> >>> >>>>> >>a
> > > > > >>>> >>> >> >> >>> >>>>> >> >>new
> > > > > >>>> >>> >> >> >>> >>>>> >> >> > tag
> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>>and
> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>> release. You can check out
> the
> > > bug
> > > > > >>>>on the
> > > > > >>>> >>> issue
> > > > > >>>> >>> >> >> >>>tracker
> > > > > >>>> >>> >> >> >>> >>>>>at
> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>>
> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>>
> > > > > >>>> >>> >> >> >>> >>>>> >> >> >
> > > > > >>>> >>> >> >> >>> >>>>> >> >>
> > > > > >>>> >>> >> >> >>> >>>>> >> >>
> > > > > >>>> >>> >> >> >>> >>>>> >>
> > > > > >>>> >>> >> >> >>> >>>>> >>
> > > > > >>>> >>> >> >> >>> >>>>>
> > > > > >>>> >>> >> >> >>> >>>>>
> > > > > >>>> >>> >> >> >>>
> > > > > >>>> >>> >> >>
> > > > > >>>> >>>
> > > > > >>>>
> > > > > >>>>
> > > > >
> > >
> https://issues.apache.org/jira/browse/CB-490?focusedCommentId=13252809#
> > > > > >>>> >>> >> >> >>> >>>>>co
> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>>mment-13252809
> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>>
> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>> It doesn't make sense to just
> > > > > >>>>repackage
> > > > > >>>> >>>1.6.0
> > > > > >>>> >>> >> with
> > > > > >>>> >>> >> >> >>>this
> > > > > >>>> >>> >> >> >>> >>>>>bug
> > > > > >>>> >>> >> >> >>> >>>>> >> >>fixed as
> > > > > >>>> >>> >> >> >>> >>>>> >> >> > we
> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>> will have no way to know if
> > > people
> > > > > >>>>are
> > > > > >>>> >>> >> experiencing
> > > > > >>>> >>> >> >> >>>this
> > > > > >>>> >>> >> >> >>> >>>>>or
> > > > > >>>> >>> >> >> >>> >>>>> >>not.
> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>>
> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>> Anis mentioned Bada also had
> > some
> > > > > >>>>major
> > > > > >>>> >>>issues
> > > > > >>>> >>> >> >> >>>which he
> > > > > >>>> >>> >> >> >>> >>>>>has
> > > > > >>>> >>> >> >> >>> >>>>> >>fixed
> > > > > >>>> >>> >> >> >>> >>>>> >> >> now
> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>>and
> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>> would like in a 1.6.1
> release.
> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>>
> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>> Thoughts?
> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>>
> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>> -Steve
> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>
> > > > > >>>> >>> >> >> >>> >>>>> >> >> >
> > > > > >>>> >>> >> >> >>> >>>>> >> >>
> > > > > >>>> >>> >> >> >>> >>>>> >>
> > > > > >>>> >>> >> >> >>> >>>>> >>
> > > > > >>>> >>> >> >> >>> >>>>>
> > > > > >>>> >>> >> >> >>> >>>>>
> > > > > >>>> >>> >> >> >>> >>>
> > > > > >>>> >>> >> >> >>> >
> > > > > >>>> >>> >> >> >>>
> > > > > >>>> >>> >> >>
> > > > > >>>> >>> >> >>
> > > > > >>>> >>> >>
> > > > > >>>> >>>
> > > > > >>>> >
> > > > > >>>>
> > > > >
> > > > >
> > > >
> > >
> >
>
Re: 1.6.1
Posted by Jesse <pu...@gmail.com>.
So the first line in ALL our cordova-1.6.1.js files should be:
// commit 9451ff3c5517ba9ba4a2c062633686bb3a993f52
Please verify before doing your platform release prep and tagging your own
repos.
Cheers,
Jesse
On Thu, Apr 12, 2012 at 4:38 PM, Joe Bowser <bo...@gmail.com> wrote:
> Android is tagged.
>
> On Thu, Apr 12, 2012 at 4:36 PM, Jesse <pu...@gmail.com> wrote:
>
> > Done
> >
> > On Thu, Apr 12, 2012 at 4:31 PM, Joe Bowser <bo...@gmail.com> wrote:
> >
> > > I'd like to get the JS from the tag, but I need a tag for that.
> > >
> > > On Thu, Apr 12, 2012 at 4:29 PM, Jesse <pu...@gmail.com>
> wrote:
> > >
> > > > Okay, I think it's good, tagging at 16:32 PDT if i don't hear any
> > > > complaints.
> > > >
> > > > On Thu, Apr 12, 2012 at 4:26 PM, Filip Maj <fi...@adobe.com> wrote:
> > > >
> > > > > I just axed the existing 1.6.1 cordova-js tag
> > > > >
> > > > > Jesse when you feel you've got everything in there go ahead and tag
> > JS
> > > > >
> > > > > On 4/12/12 4:20 PM, "Shazron" <sh...@gmail.com> wrote:
> > > > >
> > > > > >Reverted. Just talked to Jesse - he has commits to cordova-js
> > coming,
> > > > > >once those are in we can re-tag cordova-js to 1.6.1
> > > > > >
> > > > > >On Thu, Apr 12, 2012 at 4:12 PM, Shazron <sh...@gmail.com>
> wrote:
> > > > > >> I'll remove it. *grabs the shovel*
> > > > > >>
> > > > > >> On Thu, Apr 12, 2012 at 4:10 PM, Joe Bowser <bo...@gmail.com>
> > > > wrote:
> > > > > >>> You know, let's not rebase it, because it does modify the
> > history.
> > > > We
> > > > > >>> should remove and document why we did it instead, since that
> > would
> > > be
> > > > > >>>more
> > > > > >>> transparent. Or we could just leave it in and say "don't do
> this
> > > next
> > > > > >>> time". I'm not that invested in it.
> > > > > >>>
> > > > > >>> On Thu, Apr 12, 2012 at 4:04 PM, Shazron <sh...@gmail.com>
> > > wrote:
> > > > > >>>
> > > > > >>>> If we take out that iOS commit in cordova-js (somehow), it
> > should
> > > be
> > > > > >>>> fine. cordova-ios 1.6.1 will then just be the same as 1.6.0.
> > > > > >>>>
> > > > > >>>> On Thu, Apr 12, 2012 at 4:02 PM, Filip Maj <fi...@adobe.com>
> > wrote:
> > > > > >>>> >
> > > > > >>>> >>Is it too much to drop the new commit that changed the
> common
> > js
> > > > > >>>>API, and
> > > > > >>>> >>reapply it after we tag 1.6.1, and figure this one thing out
> > for
> > > > > >>>>1.7?
> > > > > >>>> >
> > > > > >>>> > That sounds very good to me but I am under the impression
> that
> > > iOS
> > > > > >>>> > requires this commit? Like I said I'm quite confused.
> > > > > >>>> >
> > > > > >>>> >>
> > > > > >>>> >>I also have some cordova-js commits to add to 1.6.1?
> Although
> > > > > >>>>nothing
> > > > > >>>> that
> > > > > >>>> >>modifies any js outside of what is built for wp7. ( ie, all
> in
> > > my
> > > > > >>>> platform
> > > > > >>>> >>specific plugins folder )
> > > > > >>>> >>
> > > > > >>>> >
> > > > > >>>> > O then it sounds like I tagged the JS 1.6.1 too early
> > anyways..
> > > > > >>>> >
> > > > > >>>> >>
> > > > > >>>> >>
> > > > > >>>> >>
> > > > > >>>> >>On Thu, Apr 12, 2012 at 3:51 PM, Shazron <shazron@gmail.com
> >
> > > > wrote:
> > > > > >>>> >>
> > > > > >>>> >>> No - it's about a user's contribution being noted (it
> > > exists), I
> > > > > >>>>will
> > > > > >>>> >>> move it out of the common code post-1.6.1 (I acknowledge
> my
> > > > > >>>>mistake in
> > > > > >>>> >>> allowing it in the first place). Can we branch off 1.6.0
> > then
> > > > > >>>> >>> cherry-pick Fil's latest fix for 1.6.1?
> > > > > >>>> >>>
> > > > > >>>> >>> On Thu, Apr 12, 2012 at 3:47 PM, Joe Bowser <
> > > bowserj@gmail.com>
> > > > > >>>>wrote:
> > > > > >>>> >>> > OK, so you're proposing that we leave the thing in the
> > > common
> > > > > >>>>JS,
> > > > > >>>> even
> > > > > >>>> >>> > though it's not supposed to be there.
> > > > > >>>> >>> >
> > > > > >>>> >>> > On Thu, Apr 12, 2012 at 3:45 PM, Shazron <
> > shazron@gmail.com
> > > >
> > > > > >>>>wrote:
> > > > > >>>> >>> >
> > > > > >>>> >>> >> Will rebasing lose that commit? Then, no.
> > > > > >>>> >>> >>
> > > > > >>>> >>> >> On Thu, Apr 12, 2012 at 3:43 PM, Joe Bowser <
> > > > bowserj@gmail.com
> > > > > >
> > > > > >>>> >>>wrote:
> > > > > >>>> >>> >> > So, can we just rebase the head, push this out and
> get
> > > this
> > > > > >>>> >>>rolling?
> > > > > >>>> >>> >> >
> > > > > >>>> >>> >> > On Thu, Apr 12, 2012 at 3:43 PM, Filip Maj <
> > > fil@adobe.com>
> > > > > >>>>wrote:
> > > > > >>>> >>> >> >
> > > > > >>>> >>> >> >> Correct, those iOS-specific parameters (like allow
> > edit
> > > > and
> > > > > >>>>those
> > > > > >>>> >>> ones)
> > > > > >>>> >>> >> >> existed prior to cordova-js, so yeah, we left them
> in
> > > > there
> > > > > >>>>as we
> > > > > >>>> >>> didn't
> > > > > >>>> >>> >> >> want to remove without deprecation.
> > > > > >>>> >>> >> >>
> > > > > >>>> >>> >> >> If you can deal with the iOS issue without needing
> an
> > > API
> > > > > >>>> >>>extension:
> > > > > >>>> >>> >> then
> > > > > >>>> >>> >> >> do that. If not, leave it in there, but docs need to
> > > > > >>>>updated too.
> > > > > >>>> >>> >> >>
> > > > > >>>> >>> >> >> Extending and changing the public API is a long and
> > > > > >>>>difficult
> > > > > >>>> >>>process
> > > > > >>>> >>> >> for
> > > > > >>>> >>> >> >> us and will only get tougher with every platform we
> > add
> > > > > >>>>support
> > > > > >>>> >>>to.
> > > > > >>>> >>> >> >>
> > > > > >>>> >>> >> >> On 4/12/12 3:37 PM, "Shazron" <sh...@gmail.com>
> > > wrote:
> > > > > >>>> >>> >> >>
> > > > > >>>> >>> >> >> >Then we have to scrap the other three(?) iOS
> > parameters
> > > > > >>>>ones
> > > > > >>>> that
> > > > > >>>> >>> >> >> >already exist in common if you noticed. Don't know
> > how
> > > we
> > > > > >>>>merge
> > > > > >>>> >>> >> >> >(unmerge?) this one properly because taking those
> out
> > > > will
> > > > > >>>>break
> > > > > >>>> >>> >> >> >everyone that is using it, but a deprecation is the
> > way
> > > > to
> > > > > >>>>go as
> > > > > >>>> >>>per
> > > > > >>>> >>> >> >> >http://wiki.apache.org/cordova/DeprecationPolicy .
> > We
> > > > can
> > > > > >>>> remove
> > > > > >>>> >>> this
> > > > > >>>> >>> >> >> >new commit and I'll find a way to get this in
> > somehow.
> > > > > >>>> >>> >> >> >
> > > > > >>>> >>> >> >> >
> > > > > >>>> >>> >> >> >
> > > > > >>>> >>> >> >> >On Thu, Apr 12, 2012 at 3:32 PM, Joe Bowser
> > > > > >>>><bo...@gmail.com>
> > > > > >>>> >>> wrote:
> > > > > >>>> >>> >> >> >> The problem is that this parameter doesn't belong
> > in
> > > > the
> > > > > >>>> common
> > > > > >>>> >>> API.
> > > > > >>>> >>> >> >> >>It'd
> > > > > >>>> >>> >> >> >> be just ignored in Android, but the whole point
> of
> > > > > >>>>cordova-js
> > > > > >>>> >>>is
> > > > > >>>> >>> so
> > > > > >>>> >>> >> that
> > > > > >>>> >>> >> >> >> it's common. It'd look pretty screwed up to add
> > this
> > > > to
> > > > > >>>>the
> > > > > >>>> >>>docs,
> > > > > >>>> >>> >> IMO.
> > > > > >>>> >>> >> >> >>
> > > > > >>>> >>> >> >> >> On Thu, Apr 12, 2012 at 3:26 PM, Shazron
> > > > > >>>><sh...@gmail.com>
> > > > > >>>> >>> wrote:
> > > > > >>>> >>> >> >> >>
> > > > > >>>> >>> >> >> >>> To fix two bugs for Camera.takePicture on iOS
> > > > > >>>> >>> >> >> >>>
> > > > > >>>> >>> >> >> >>> On Thu, Apr 12, 2012 at 3:24 PM, Filip Maj
> > > > > >>>><fi...@adobe.com>
> > > > > >>>> >>> wrote:
> > > > > >>>> >>> >> >> >>> > so what's the point of this new parameter?
> > > > > >>>> >>> >> >> >>> >
> > > > > >>>> >>> >> >> >>> > On 4/12/12 3:16 PM, "Shazron" <
> > shazron@gmail.com>
> > > > > >>>>wrote:
> > > > > >>>> >>> >> >> >>> >
> > > > > >>>> >>> >> >> >>> >>I did. Do we want to revert the cordova-js? I
> > can
> > > > > >>>>branch
> > > > > >>>> >>>1.6.0
> > > > > >>>> >>> and
> > > > > >>>> >>> >> >> >>> >>cherry-pick your latest commit for 1.6.1
> > > > > >>>> >>> >> >> >>> >>
> > > > > >>>> >>> >> >> >>> >>On Thu, Apr 12, 2012 at 3:04 PM, Filip Maj
> > > > > >>>><fi...@adobe.com>
> > > > > >>>> >>> wrote:
> > > > > >>>> >>> >> >> >>> >>> I saw something in the iOS commit logs for
> > this.
> > > > > >>>> >>> >> >> >>> >>>
> > > > > >>>> >>> >> >> >>> >>> Shaz can you comment?
> > > > > >>>> >>> >> >> >>> >>>
> > > > > >>>> >>> >> >> >>> >>> On 4/12/12 2:59 PM, "Joe Bowser" <
> > > > bowserj@gmail.com
> > > > > >
> > > > > >>>> >>>wrote:
> > > > > >>>> >>> >> >> >>> >>>
> > > > > >>>> >>> >> >> >>> >>>>Can we revert this, since this looks like
> it's
> > > > > >>>>intended
> > > > > >>>> >>>for
> > > > > >>>> >>> both
> > > > > >>>> >>> >> >> >>> Android
> > > > > >>>> >>> >> >> >>> >>>>and iOS, but I don't think it should be in
> > > 1.6.1.
> > > > > >>>> >>> >> >> >>> >>>>
> > > > > >>>> >>> >> >> >>> >>>>On Thu, Apr 12, 2012 at 2:52 PM, Filip Maj <
> > > > > >>>> fil@adobe.com>
> > > > > >>>> >>> >> wrote:
> > > > > >>>> >>> >> >> >>> >>>>
> > > > > >>>> >>> >> >> >>> >>>>> I was actually just looking at that
> myself.
> > > > > >>>> >>> >> >> >>> >>>>>
> > > > > >>>> >>> >> >> >>> >>>>> Looks like it's an iOS-only param.. sigh.
> > We
> > > > > >>>>gotta
> > > > > >>>> stop
> > > > > >>>> >>> doing
> > > > > >>>> >>> >> >> >>>that,
> > > > > >>>> >>> >> >> >>> >>>>> especially if we don't update
> documentation.
> > > > > >>>> >>> >> >> >>> >>>>>
> > > > > >>>> >>> >> >> >>> >>>>> On 4/12/12 2:49 PM, "Joe Bowser"
> > > > > >>>><bo...@gmail.com>
> > > > > >>>> >>> wrote:
> > > > > >>>> >>> >> >> >>> >>>>>
> > > > > >>>> >>> >> >> >>> >>>>> >Has anyone tested the cropToSize param
> for
> > > > > >>>> >>> Camera.getPicture
> > > > > >>>> >>> >> >> >>>yet? I
> > > > > >>>> >>> >> >> >>> >>>>> >didn't
> > > > > >>>> >>> >> >> >>> >>>>> >notice that change until now.
> > > > > >>>> >>> >> >> >>> >>>>> >
> > > > > >>>> >>> >> >> >>> >>>>> >On Thu, Apr 12, 2012 at 2:46 PM, Filip
> Maj
> > > > > >>>> >>><fil@adobe.com
> > > > > >>>> >>> >
> > > > > >>>> >>> >> >> >>>wrote:
> > > > > >>>> >>> >> >> >>> >>>>> >
> > > > > >>>> >>> >> >> >>> >>>>> >> JS tagged 1.6.1 - the build task in the
> > JS
> > > > > >>>>should
> > > > > >>>> >>>work
> > > > > >>>> >>> >> >> >>>properly
> > > > > >>>> >>> >> >> >>> >>>>>now.
> > > > > >>>> >>> >> >> >>> >>>>> >>
> > > > > >>>> >>> >> >> >>> >>>>> >> FYI if anyone has to modify the jake
> > tasks
> > > in
> > > > > >>>>the
> > > > > >>>> >>>future
> > > > > >>>> >>> >> and
> > > > > >>>> >>> >> >> >>>make
> > > > > >>>> >>> >> >> >>> >>>>>them
> > > > > >>>> >>> >> >> >>> >>>>> >> async, make sure you add the 4th
> "async"
> > > > > >>>>parameter
> > > > > >>>> to
> > > > > >>>> >>> the
> > > > > >>>> >>> >> >> >>>task()
> > > > > >>>> >>> >> >> >>> >>>>> >>function
> > > > > >>>> >>> >> >> >>> >>>>> >> and set it to true, and call complete()
> > > when
> > > > > >>>>the
> > > > > >>>> >>>task is
> > > > > >>>> >>> >> done.
> > > > > >>>> >>> >> >> >>> >>>>> >>
> > > > > >>>> >>> >> >> >>> >>>>> >> See
> > > > > >>>> >>> http://howtonode.org/intro-to-jake/async-jakefile.jsfor
> > > > > >>>> >>> >> >> >>>an
> > > > > >>>> >>> >> >> >>> >>>>> example.
> > > > > >>>> >>> >> >> >>> >>>>> >>
> > > > > >>>> >>> >> >> >>> >>>>> >> On 4/12/12 2:35 PM, "Joe Bowser"
> > > > > >>>><bowserj@gmail.com
> > > > > >>>> >
> > > > > >>>> >>> >> wrote:
> > > > > >>>> >>> >> >> >>> >>>>> >>
> > > > > >>>> >>> >> >> >>> >>>>> >> >Ready to tag once cordova-js is tagged
> > > > 1.6.1.
> > > > > >>>> >>> >> >> >>> >>>>> >> >
> > > > > >>>> >>> >> >> >>> >>>>> >> >On Thu, Apr 12, 2012 at 2:33 PM, Anis
> > > KADRI
> > > > <
> > > > > >>>> >>> >> >> >>> anis.kadri@gmail.com>
> > > > > >>>> >>> >> >> >>> >>>>> >>wrote:
> > > > > >>>> >>> >> >> >>> >>>>> >> >
> > > > > >>>> >>> >> >> >>> >>>>> >> >> I will tag my repository to 1.6.1
> > before
> > > > > >>>>end of
> > > > > >>>> >>>day
> > > > > >>>> >>> >> today
> > > > > >>>> >>> >> >> >>>after
> > > > > >>>> >>> >> >> >>> >>>>>some
> > > > > >>>> >>> >> >> >>> >>>>> >> >> thorough testing.
> > > > > >>>> >>> >> >> >>> >>>>> >> >>
> > > > > >>>> >>> >> >> >>> >>>>> >> >> On Thu, Apr 12, 2012 at 2:30 PM,
> > Shazron
> > > > > >>>> >>> >> >> >>><sh...@gmail.com>
> > > > > >>>> >>> >> >> >>> >>>>>wrote:
> > > > > >>>> >>> >> >> >>> >>>>> >> >>
> > > > > >>>> >>> >> >> >>> >>>>> >> >> > I also created a 1.6.1 version tag
> > as
> > > > > >>>>well in
> > > > > >>>> >>> jira...
> > > > > >>>> >>> >> >> >>> >>>>> >> >> >
> > > > > >>>> >>> >> >> >>> >>>>> >> >> > On Thu, Apr 12, 2012 at 2:29 PM,
> > > Shazron
> > > > > >>>> >>> >> >> >>><sh...@gmail.com>
> > > > > >>>> >>> >> >> >>> >>>>> wrote:
> > > > > >>>> >>> >> >> >>> >>>>> >> >> > > Alright guys since 1.6.0 was
> > > released,
> > > > > >>>>I'm
> > > > > >>>> >>>going
> > > > > >>>> >>> to
> > > > > >>>> >>> >> >> >>> >>>>>"Release"
> > > > > >>>> >>> >> >> >>> >>>>>the
> > > > > >>>> >>> >> >> >>> >>>>> >> >> > > 1.6.0 version in jira and move
> > > > > >>>>outstanding
> > > > > >>>> >>> issues to
> > > > > >>>> >>> >> >> >>>1.7.0
> > > > > >>>> >>> >> >> >>> >>>>> >>version
> > > > > >>>> >>> >> >> >>> >>>>> >> >> > > tag.
> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >
> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >
> > > > > >>>> >>> >> >> >>> >>>>> >> >> > > On Thu, Apr 12, 2012 at 2:26 PM,
> > > Filip
> > > > > >>>>Maj
> > > > > >>>> >>> >> >> >>><fi...@adobe.com>
> > > > > >>>> >>> >> >> >>> >>>>> wrote:
> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >> The JS needs patching too.
> Since
> > > > > >>>>adding the
> > > > > >>>> >>> commit
> > > > > >>>> >>> >> ID
> > > > > >>>> >>> >> >> >>>into
> > > > > >>>> >>> >> >> >>> >>>>>the
> > > > > >>>> >>> >> >> >>> >>>>> >> >> packaging
> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >> in the jakefile, the default
> task
> > > > isn't
> > > > > >>>> >>>running
> > > > > >>>> >>> >> >> >>>properly.
> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>
> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >> You can manually run "jake
> build"
> > > and
> > > > > >>>>"jake
> > > > > >>>> >>> test"
> > > > > >>>> >>> >> but
> > > > > >>>> >>> >> >> >>>not
> > > > > >>>> >>> >> >> >>> >>>>> >>"jake" on
> > > > > >>>> >>> >> >> >>> >>>>> >> >> its
> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >> own - gonna try to figure it
> out.
> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>
> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >> On 4/12/12 2:21 PM, "Shazron" <
> > > > > >>>> >>> shazron@gmail.com>
> > > > > >>>> >>> >> >> >>>wrote:
> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>
> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>I'm good with tagging. iOS
> has a
> > > few
> > > > > >>>> commits
> > > > > >>>> >>> (one
> > > > > >>>> >>> >> >> >>>commit
> > > > > >>>> >>> >> >> >>> >>>>>in
> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>cordova-js) as well. Aim for
> > first
> > > > > >>>>thing
> > > > > >>>> >>> tomorrow
> > > > > >>>> >>> >> for
> > > > > >>>> >>> >> >> >>>you
> > > > > >>>> >>> >> >> >>> >>>>>to
> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>repackage?
> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>
> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>On Thu, Apr 12, 2012 at 2:17
> PM,
> > > > > >>>>Steven Gill
> > > > > >>>> >>> >> >> >>> >>>>> >> >><st...@gmail.com>
> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>wrote:
> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>> So a bug has been discovered
> in
> > > > > >>>>Cordova
> > > > > >>>> >>> Android
> > > > > >>>> >>> >> that
> > > > > >>>> >>> >> >> >>> >>>>>requires
> > > > > >>>> >>> >> >> >>> >>>>> >>a
> > > > > >>>> >>> >> >> >>> >>>>> >> >>new
> > > > > >>>> >>> >> >> >>> >>>>> >> >> > tag
> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>>and
> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>> release. You can check out
> the
> > > bug
> > > > > >>>>on the
> > > > > >>>> >>> issue
> > > > > >>>> >>> >> >> >>>tracker
> > > > > >>>> >>> >> >> >>> >>>>>at
> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>>
> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>>
> > > > > >>>> >>> >> >> >>> >>>>> >> >> >
> > > > > >>>> >>> >> >> >>> >>>>> >> >>
> > > > > >>>> >>> >> >> >>> >>>>> >> >>
> > > > > >>>> >>> >> >> >>> >>>>> >>
> > > > > >>>> >>> >> >> >>> >>>>> >>
> > > > > >>>> >>> >> >> >>> >>>>>
> > > > > >>>> >>> >> >> >>> >>>>>
> > > > > >>>> >>> >> >> >>>
> > > > > >>>> >>> >> >>
> > > > > >>>> >>>
> > > > > >>>>
> > > > > >>>>
> > > > >
> > >
> https://issues.apache.org/jira/browse/CB-490?focusedCommentId=13252809#
> > > > > >>>> >>> >> >> >>> >>>>>co
> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>>mment-13252809
> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>>
> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>> It doesn't make sense to just
> > > > > >>>>repackage
> > > > > >>>> >>>1.6.0
> > > > > >>>> >>> >> with
> > > > > >>>> >>> >> >> >>>this
> > > > > >>>> >>> >> >> >>> >>>>>bug
> > > > > >>>> >>> >> >> >>> >>>>> >> >>fixed as
> > > > > >>>> >>> >> >> >>> >>>>> >> >> > we
> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>> will have no way to know if
> > > people
> > > > > >>>>are
> > > > > >>>> >>> >> experiencing
> > > > > >>>> >>> >> >> >>>this
> > > > > >>>> >>> >> >> >>> >>>>>or
> > > > > >>>> >>> >> >> >>> >>>>> >>not.
> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>>
> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>> Anis mentioned Bada also had
> > some
> > > > > >>>>major
> > > > > >>>> >>>issues
> > > > > >>>> >>> >> >> >>>which he
> > > > > >>>> >>> >> >> >>> >>>>>has
> > > > > >>>> >>> >> >> >>> >>>>> >>fixed
> > > > > >>>> >>> >> >> >>> >>>>> >> >> now
> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>>and
> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>> would like in a 1.6.1
> release.
> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>>
> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>> Thoughts?
> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>>
> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>> -Steve
> > > > > >>>> >>> >> >> >>> >>>>> >> >> > >>
> > > > > >>>> >>> >> >> >>> >>>>> >> >> >
> > > > > >>>> >>> >> >> >>> >>>>> >> >>
> > > > > >>>> >>> >> >> >>> >>>>> >>
> > > > > >>>> >>> >> >> >>> >>>>> >>
> > > > > >>>> >>> >> >> >>> >>>>>
> > > > > >>>> >>> >> >> >>> >>>>>
> > > > > >>>> >>> >> >> >>> >>>
> > > > > >>>> >>> >> >> >>> >
> > > > > >>>> >>> >> >> >>>
> > > > > >>>> >>> >> >>
> > > > > >>>> >>> >> >>
> > > > > >>>> >>> >>
> > > > > >>>> >>>
> > > > > >>>> >
> > > > > >>>>
> > > > >
> > > > >
> > > >
> > >
> >
>
Re: 1.6.1
Posted by Joe Bowser <bo...@gmail.com>.
Android is tagged.
On Thu, Apr 12, 2012 at 4:36 PM, Jesse <pu...@gmail.com> wrote:
> Done
>
> On Thu, Apr 12, 2012 at 4:31 PM, Joe Bowser <bo...@gmail.com> wrote:
>
> > I'd like to get the JS from the tag, but I need a tag for that.
> >
> > On Thu, Apr 12, 2012 at 4:29 PM, Jesse <pu...@gmail.com> wrote:
> >
> > > Okay, I think it's good, tagging at 16:32 PDT if i don't hear any
> > > complaints.
> > >
> > > On Thu, Apr 12, 2012 at 4:26 PM, Filip Maj <fi...@adobe.com> wrote:
> > >
> > > > I just axed the existing 1.6.1 cordova-js tag
> > > >
> > > > Jesse when you feel you've got everything in there go ahead and tag
> JS
> > > >
> > > > On 4/12/12 4:20 PM, "Shazron" <sh...@gmail.com> wrote:
> > > >
> > > > >Reverted. Just talked to Jesse - he has commits to cordova-js
> coming,
> > > > >once those are in we can re-tag cordova-js to 1.6.1
> > > > >
> > > > >On Thu, Apr 12, 2012 at 4:12 PM, Shazron <sh...@gmail.com> wrote:
> > > > >> I'll remove it. *grabs the shovel*
> > > > >>
> > > > >> On Thu, Apr 12, 2012 at 4:10 PM, Joe Bowser <bo...@gmail.com>
> > > wrote:
> > > > >>> You know, let's not rebase it, because it does modify the
> history.
> > > We
> > > > >>> should remove and document why we did it instead, since that
> would
> > be
> > > > >>>more
> > > > >>> transparent. Or we could just leave it in and say "don't do this
> > next
> > > > >>> time". I'm not that invested in it.
> > > > >>>
> > > > >>> On Thu, Apr 12, 2012 at 4:04 PM, Shazron <sh...@gmail.com>
> > wrote:
> > > > >>>
> > > > >>>> If we take out that iOS commit in cordova-js (somehow), it
> should
> > be
> > > > >>>> fine. cordova-ios 1.6.1 will then just be the same as 1.6.0.
> > > > >>>>
> > > > >>>> On Thu, Apr 12, 2012 at 4:02 PM, Filip Maj <fi...@adobe.com>
> wrote:
> > > > >>>> >
> > > > >>>> >>Is it too much to drop the new commit that changed the common
> js
> > > > >>>>API, and
> > > > >>>> >>reapply it after we tag 1.6.1, and figure this one thing out
> for
> > > > >>>>1.7?
> > > > >>>> >
> > > > >>>> > That sounds very good to me but I am under the impression that
> > iOS
> > > > >>>> > requires this commit? Like I said I'm quite confused.
> > > > >>>> >
> > > > >>>> >>
> > > > >>>> >>I also have some cordova-js commits to add to 1.6.1? Although
> > > > >>>>nothing
> > > > >>>> that
> > > > >>>> >>modifies any js outside of what is built for wp7. ( ie, all in
> > my
> > > > >>>> platform
> > > > >>>> >>specific plugins folder )
> > > > >>>> >>
> > > > >>>> >
> > > > >>>> > O then it sounds like I tagged the JS 1.6.1 too early
> anyways..
> > > > >>>> >
> > > > >>>> >>
> > > > >>>> >>
> > > > >>>> >>
> > > > >>>> >>On Thu, Apr 12, 2012 at 3:51 PM, Shazron <sh...@gmail.com>
> > > wrote:
> > > > >>>> >>
> > > > >>>> >>> No - it's about a user's contribution being noted (it
> > exists), I
> > > > >>>>will
> > > > >>>> >>> move it out of the common code post-1.6.1 (I acknowledge my
> > > > >>>>mistake in
> > > > >>>> >>> allowing it in the first place). Can we branch off 1.6.0
> then
> > > > >>>> >>> cherry-pick Fil's latest fix for 1.6.1?
> > > > >>>> >>>
> > > > >>>> >>> On Thu, Apr 12, 2012 at 3:47 PM, Joe Bowser <
> > bowserj@gmail.com>
> > > > >>>>wrote:
> > > > >>>> >>> > OK, so you're proposing that we leave the thing in the
> > common
> > > > >>>>JS,
> > > > >>>> even
> > > > >>>> >>> > though it's not supposed to be there.
> > > > >>>> >>> >
> > > > >>>> >>> > On Thu, Apr 12, 2012 at 3:45 PM, Shazron <
> shazron@gmail.com
> > >
> > > > >>>>wrote:
> > > > >>>> >>> >
> > > > >>>> >>> >> Will rebasing lose that commit? Then, no.
> > > > >>>> >>> >>
> > > > >>>> >>> >> On Thu, Apr 12, 2012 at 3:43 PM, Joe Bowser <
> > > bowserj@gmail.com
> > > > >
> > > > >>>> >>>wrote:
> > > > >>>> >>> >> > So, can we just rebase the head, push this out and get
> > this
> > > > >>>> >>>rolling?
> > > > >>>> >>> >> >
> > > > >>>> >>> >> > On Thu, Apr 12, 2012 at 3:43 PM, Filip Maj <
> > fil@adobe.com>
> > > > >>>>wrote:
> > > > >>>> >>> >> >
> > > > >>>> >>> >> >> Correct, those iOS-specific parameters (like allow
> edit
> > > and
> > > > >>>>those
> > > > >>>> >>> ones)
> > > > >>>> >>> >> >> existed prior to cordova-js, so yeah, we left them in
> > > there
> > > > >>>>as we
> > > > >>>> >>> didn't
> > > > >>>> >>> >> >> want to remove without deprecation.
> > > > >>>> >>> >> >>
> > > > >>>> >>> >> >> If you can deal with the iOS issue without needing an
> > API
> > > > >>>> >>>extension:
> > > > >>>> >>> >> then
> > > > >>>> >>> >> >> do that. If not, leave it in there, but docs need to
> > > > >>>>updated too.
> > > > >>>> >>> >> >>
> > > > >>>> >>> >> >> Extending and changing the public API is a long and
> > > > >>>>difficult
> > > > >>>> >>>process
> > > > >>>> >>> >> for
> > > > >>>> >>> >> >> us and will only get tougher with every platform we
> add
> > > > >>>>support
> > > > >>>> >>>to.
> > > > >>>> >>> >> >>
> > > > >>>> >>> >> >> On 4/12/12 3:37 PM, "Shazron" <sh...@gmail.com>
> > wrote:
> > > > >>>> >>> >> >>
> > > > >>>> >>> >> >> >Then we have to scrap the other three(?) iOS
> parameters
> > > > >>>>ones
> > > > >>>> that
> > > > >>>> >>> >> >> >already exist in common if you noticed. Don't know
> how
> > we
> > > > >>>>merge
> > > > >>>> >>> >> >> >(unmerge?) this one properly because taking those out
> > > will
> > > > >>>>break
> > > > >>>> >>> >> >> >everyone that is using it, but a deprecation is the
> way
> > > to
> > > > >>>>go as
> > > > >>>> >>>per
> > > > >>>> >>> >> >> >http://wiki.apache.org/cordova/DeprecationPolicy .
> We
> > > can
> > > > >>>> remove
> > > > >>>> >>> this
> > > > >>>> >>> >> >> >new commit and I'll find a way to get this in
> somehow.
> > > > >>>> >>> >> >> >
> > > > >>>> >>> >> >> >
> > > > >>>> >>> >> >> >
> > > > >>>> >>> >> >> >On Thu, Apr 12, 2012 at 3:32 PM, Joe Bowser
> > > > >>>><bo...@gmail.com>
> > > > >>>> >>> wrote:
> > > > >>>> >>> >> >> >> The problem is that this parameter doesn't belong
> in
> > > the
> > > > >>>> common
> > > > >>>> >>> API.
> > > > >>>> >>> >> >> >>It'd
> > > > >>>> >>> >> >> >> be just ignored in Android, but the whole point of
> > > > >>>>cordova-js
> > > > >>>> >>>is
> > > > >>>> >>> so
> > > > >>>> >>> >> that
> > > > >>>> >>> >> >> >> it's common. It'd look pretty screwed up to add
> this
> > > to
> > > > >>>>the
> > > > >>>> >>>docs,
> > > > >>>> >>> >> IMO.
> > > > >>>> >>> >> >> >>
> > > > >>>> >>> >> >> >> On Thu, Apr 12, 2012 at 3:26 PM, Shazron
> > > > >>>><sh...@gmail.com>
> > > > >>>> >>> wrote:
> > > > >>>> >>> >> >> >>
> > > > >>>> >>> >> >> >>> To fix two bugs for Camera.takePicture on iOS
> > > > >>>> >>> >> >> >>>
> > > > >>>> >>> >> >> >>> On Thu, Apr 12, 2012 at 3:24 PM, Filip Maj
> > > > >>>><fi...@adobe.com>
> > > > >>>> >>> wrote:
> > > > >>>> >>> >> >> >>> > so what's the point of this new parameter?
> > > > >>>> >>> >> >> >>> >
> > > > >>>> >>> >> >> >>> > On 4/12/12 3:16 PM, "Shazron" <
> shazron@gmail.com>
> > > > >>>>wrote:
> > > > >>>> >>> >> >> >>> >
> > > > >>>> >>> >> >> >>> >>I did. Do we want to revert the cordova-js? I
> can
> > > > >>>>branch
> > > > >>>> >>>1.6.0
> > > > >>>> >>> and
> > > > >>>> >>> >> >> >>> >>cherry-pick your latest commit for 1.6.1
> > > > >>>> >>> >> >> >>> >>
> > > > >>>> >>> >> >> >>> >>On Thu, Apr 12, 2012 at 3:04 PM, Filip Maj
> > > > >>>><fi...@adobe.com>
> > > > >>>> >>> wrote:
> > > > >>>> >>> >> >> >>> >>> I saw something in the iOS commit logs for
> this.
> > > > >>>> >>> >> >> >>> >>>
> > > > >>>> >>> >> >> >>> >>> Shaz can you comment?
> > > > >>>> >>> >> >> >>> >>>
> > > > >>>> >>> >> >> >>> >>> On 4/12/12 2:59 PM, "Joe Bowser" <
> > > bowserj@gmail.com
> > > > >
> > > > >>>> >>>wrote:
> > > > >>>> >>> >> >> >>> >>>
> > > > >>>> >>> >> >> >>> >>>>Can we revert this, since this looks like it's
> > > > >>>>intended
> > > > >>>> >>>for
> > > > >>>> >>> both
> > > > >>>> >>> >> >> >>> Android
> > > > >>>> >>> >> >> >>> >>>>and iOS, but I don't think it should be in
> > 1.6.1.
> > > > >>>> >>> >> >> >>> >>>>
> > > > >>>> >>> >> >> >>> >>>>On Thu, Apr 12, 2012 at 2:52 PM, Filip Maj <
> > > > >>>> fil@adobe.com>
> > > > >>>> >>> >> wrote:
> > > > >>>> >>> >> >> >>> >>>>
> > > > >>>> >>> >> >> >>> >>>>> I was actually just looking at that myself.
> > > > >>>> >>> >> >> >>> >>>>>
> > > > >>>> >>> >> >> >>> >>>>> Looks like it's an iOS-only param.. sigh.
> We
> > > > >>>>gotta
> > > > >>>> stop
> > > > >>>> >>> doing
> > > > >>>> >>> >> >> >>>that,
> > > > >>>> >>> >> >> >>> >>>>> especially if we don't update documentation.
> > > > >>>> >>> >> >> >>> >>>>>
> > > > >>>> >>> >> >> >>> >>>>> On 4/12/12 2:49 PM, "Joe Bowser"
> > > > >>>><bo...@gmail.com>
> > > > >>>> >>> wrote:
> > > > >>>> >>> >> >> >>> >>>>>
> > > > >>>> >>> >> >> >>> >>>>> >Has anyone tested the cropToSize param for
> > > > >>>> >>> Camera.getPicture
> > > > >>>> >>> >> >> >>>yet? I
> > > > >>>> >>> >> >> >>> >>>>> >didn't
> > > > >>>> >>> >> >> >>> >>>>> >notice that change until now.
> > > > >>>> >>> >> >> >>> >>>>> >
> > > > >>>> >>> >> >> >>> >>>>> >On Thu, Apr 12, 2012 at 2:46 PM, Filip Maj
> > > > >>>> >>><fil@adobe.com
> > > > >>>> >>> >
> > > > >>>> >>> >> >> >>>wrote:
> > > > >>>> >>> >> >> >>> >>>>> >
> > > > >>>> >>> >> >> >>> >>>>> >> JS tagged 1.6.1 - the build task in the
> JS
> > > > >>>>should
> > > > >>>> >>>work
> > > > >>>> >>> >> >> >>>properly
> > > > >>>> >>> >> >> >>> >>>>>now.
> > > > >>>> >>> >> >> >>> >>>>> >>
> > > > >>>> >>> >> >> >>> >>>>> >> FYI if anyone has to modify the jake
> tasks
> > in
> > > > >>>>the
> > > > >>>> >>>future
> > > > >>>> >>> >> and
> > > > >>>> >>> >> >> >>>make
> > > > >>>> >>> >> >> >>> >>>>>them
> > > > >>>> >>> >> >> >>> >>>>> >> async, make sure you add the 4th "async"
> > > > >>>>parameter
> > > > >>>> to
> > > > >>>> >>> the
> > > > >>>> >>> >> >> >>>task()
> > > > >>>> >>> >> >> >>> >>>>> >>function
> > > > >>>> >>> >> >> >>> >>>>> >> and set it to true, and call complete()
> > when
> > > > >>>>the
> > > > >>>> >>>task is
> > > > >>>> >>> >> done.
> > > > >>>> >>> >> >> >>> >>>>> >>
> > > > >>>> >>> >> >> >>> >>>>> >> See
> > > > >>>> >>> http://howtonode.org/intro-to-jake/async-jakefile.jsfor
> > > > >>>> >>> >> >> >>>an
> > > > >>>> >>> >> >> >>> >>>>> example.
> > > > >>>> >>> >> >> >>> >>>>> >>
> > > > >>>> >>> >> >> >>> >>>>> >> On 4/12/12 2:35 PM, "Joe Bowser"
> > > > >>>><bowserj@gmail.com
> > > > >>>> >
> > > > >>>> >>> >> wrote:
> > > > >>>> >>> >> >> >>> >>>>> >>
> > > > >>>> >>> >> >> >>> >>>>> >> >Ready to tag once cordova-js is tagged
> > > 1.6.1.
> > > > >>>> >>> >> >> >>> >>>>> >> >
> > > > >>>> >>> >> >> >>> >>>>> >> >On Thu, Apr 12, 2012 at 2:33 PM, Anis
> > KADRI
> > > <
> > > > >>>> >>> >> >> >>> anis.kadri@gmail.com>
> > > > >>>> >>> >> >> >>> >>>>> >>wrote:
> > > > >>>> >>> >> >> >>> >>>>> >> >
> > > > >>>> >>> >> >> >>> >>>>> >> >> I will tag my repository to 1.6.1
> before
> > > > >>>>end of
> > > > >>>> >>>day
> > > > >>>> >>> >> today
> > > > >>>> >>> >> >> >>>after
> > > > >>>> >>> >> >> >>> >>>>>some
> > > > >>>> >>> >> >> >>> >>>>> >> >> thorough testing.
> > > > >>>> >>> >> >> >>> >>>>> >> >>
> > > > >>>> >>> >> >> >>> >>>>> >> >> On Thu, Apr 12, 2012 at 2:30 PM,
> Shazron
> > > > >>>> >>> >> >> >>><sh...@gmail.com>
> > > > >>>> >>> >> >> >>> >>>>>wrote:
> > > > >>>> >>> >> >> >>> >>>>> >> >>
> > > > >>>> >>> >> >> >>> >>>>> >> >> > I also created a 1.6.1 version tag
> as
> > > > >>>>well in
> > > > >>>> >>> jira...
> > > > >>>> >>> >> >> >>> >>>>> >> >> >
> > > > >>>> >>> >> >> >>> >>>>> >> >> > On Thu, Apr 12, 2012 at 2:29 PM,
> > Shazron
> > > > >>>> >>> >> >> >>><sh...@gmail.com>
> > > > >>>> >>> >> >> >>> >>>>> wrote:
> > > > >>>> >>> >> >> >>> >>>>> >> >> > > Alright guys since 1.6.0 was
> > released,
> > > > >>>>I'm
> > > > >>>> >>>going
> > > > >>>> >>> to
> > > > >>>> >>> >> >> >>> >>>>>"Release"
> > > > >>>> >>> >> >> >>> >>>>>the
> > > > >>>> >>> >> >> >>> >>>>> >> >> > > 1.6.0 version in jira and move
> > > > >>>>outstanding
> > > > >>>> >>> issues to
> > > > >>>> >>> >> >> >>>1.7.0
> > > > >>>> >>> >> >> >>> >>>>> >>version
> > > > >>>> >>> >> >> >>> >>>>> >> >> > > tag.
> > > > >>>> >>> >> >> >>> >>>>> >> >> > >
> > > > >>>> >>> >> >> >>> >>>>> >> >> > >
> > > > >>>> >>> >> >> >>> >>>>> >> >> > > On Thu, Apr 12, 2012 at 2:26 PM,
> > Filip
> > > > >>>>Maj
> > > > >>>> >>> >> >> >>><fi...@adobe.com>
> > > > >>>> >>> >> >> >>> >>>>> wrote:
> > > > >>>> >>> >> >> >>> >>>>> >> >> > >> The JS needs patching too. Since
> > > > >>>>adding the
> > > > >>>> >>> commit
> > > > >>>> >>> >> ID
> > > > >>>> >>> >> >> >>>into
> > > > >>>> >>> >> >> >>> >>>>>the
> > > > >>>> >>> >> >> >>> >>>>> >> >> packaging
> > > > >>>> >>> >> >> >>> >>>>> >> >> > >> in the jakefile, the default task
> > > isn't
> > > > >>>> >>>running
> > > > >>>> >>> >> >> >>>properly.
> > > > >>>> >>> >> >> >>> >>>>> >> >> > >>
> > > > >>>> >>> >> >> >>> >>>>> >> >> > >> You can manually run "jake build"
> > and
> > > > >>>>"jake
> > > > >>>> >>> test"
> > > > >>>> >>> >> but
> > > > >>>> >>> >> >> >>>not
> > > > >>>> >>> >> >> >>> >>>>> >>"jake" on
> > > > >>>> >>> >> >> >>> >>>>> >> >> its
> > > > >>>> >>> >> >> >>> >>>>> >> >> > >> own - gonna try to figure it out.
> > > > >>>> >>> >> >> >>> >>>>> >> >> > >>
> > > > >>>> >>> >> >> >>> >>>>> >> >> > >> On 4/12/12 2:21 PM, "Shazron" <
> > > > >>>> >>> shazron@gmail.com>
> > > > >>>> >>> >> >> >>>wrote:
> > > > >>>> >>> >> >> >>> >>>>> >> >> > >>
> > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>I'm good with tagging. iOS has a
> > few
> > > > >>>> commits
> > > > >>>> >>> (one
> > > > >>>> >>> >> >> >>>commit
> > > > >>>> >>> >> >> >>> >>>>>in
> > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>cordova-js) as well. Aim for
> first
> > > > >>>>thing
> > > > >>>> >>> tomorrow
> > > > >>>> >>> >> for
> > > > >>>> >>> >> >> >>>you
> > > > >>>> >>> >> >> >>> >>>>>to
> > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>repackage?
> > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>
> > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>On Thu, Apr 12, 2012 at 2:17 PM,
> > > > >>>>Steven Gill
> > > > >>>> >>> >> >> >>> >>>>> >> >><st...@gmail.com>
> > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>wrote:
> > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>> So a bug has been discovered in
> > > > >>>>Cordova
> > > > >>>> >>> Android
> > > > >>>> >>> >> that
> > > > >>>> >>> >> >> >>> >>>>>requires
> > > > >>>> >>> >> >> >>> >>>>> >>a
> > > > >>>> >>> >> >> >>> >>>>> >> >>new
> > > > >>>> >>> >> >> >>> >>>>> >> >> > tag
> > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>>and
> > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>> release. You can check out the
> > bug
> > > > >>>>on the
> > > > >>>> >>> issue
> > > > >>>> >>> >> >> >>>tracker
> > > > >>>> >>> >> >> >>> >>>>>at
> > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>>
> > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>>
> > > > >>>> >>> >> >> >>> >>>>> >> >> >
> > > > >>>> >>> >> >> >>> >>>>> >> >>
> > > > >>>> >>> >> >> >>> >>>>> >> >>
> > > > >>>> >>> >> >> >>> >>>>> >>
> > > > >>>> >>> >> >> >>> >>>>> >>
> > > > >>>> >>> >> >> >>> >>>>>
> > > > >>>> >>> >> >> >>> >>>>>
> > > > >>>> >>> >> >> >>>
> > > > >>>> >>> >> >>
> > > > >>>> >>>
> > > > >>>>
> > > > >>>>
> > > >
> > https://issues.apache.org/jira/browse/CB-490?focusedCommentId=13252809#
> > > > >>>> >>> >> >> >>> >>>>>co
> > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>>mment-13252809
> > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>>
> > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>> It doesn't make sense to just
> > > > >>>>repackage
> > > > >>>> >>>1.6.0
> > > > >>>> >>> >> with
> > > > >>>> >>> >> >> >>>this
> > > > >>>> >>> >> >> >>> >>>>>bug
> > > > >>>> >>> >> >> >>> >>>>> >> >>fixed as
> > > > >>>> >>> >> >> >>> >>>>> >> >> > we
> > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>> will have no way to know if
> > people
> > > > >>>>are
> > > > >>>> >>> >> experiencing
> > > > >>>> >>> >> >> >>>this
> > > > >>>> >>> >> >> >>> >>>>>or
> > > > >>>> >>> >> >> >>> >>>>> >>not.
> > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>>
> > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>> Anis mentioned Bada also had
> some
> > > > >>>>major
> > > > >>>> >>>issues
> > > > >>>> >>> >> >> >>>which he
> > > > >>>> >>> >> >> >>> >>>>>has
> > > > >>>> >>> >> >> >>> >>>>> >>fixed
> > > > >>>> >>> >> >> >>> >>>>> >> >> now
> > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>>and
> > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>> would like in a 1.6.1 release.
> > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>>
> > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>> Thoughts?
> > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>>
> > > > >>>> >>> >> >> >>> >>>>> >> >> > >>>> -Steve
> > > > >>>> >>> >> >> >>> >>>>> >> >> > >>
> > > > >>>> >>> >> >> >>> >>>>> >> >> >
> > > > >>>> >>> >> >> >>> >>>>> >> >>
> > > > >>>> >>> >> >> >>> >>>>> >>
> > > > >>>> >>> >> >> >>> >>>>> >>
> > > > >>>> >>> >> >> >>> >>>>>
> > > > >>>> >>> >> >> >>> >>>>>
> > > > >>>> >>> >> >> >>> >>>
> > > > >>>> >>> >> >> >>> >
> > > > >>>> >>> >> >> >>>
> > > > >>>> >>> >> >>
> > > > >>>> >>> >> >>
> > > > >>>> >>> >>
> > > > >>>> >>>
> > > > >>>> >
> > > > >>>>
> > > >
> > > >
> > >
> >
>
Re: 1.6.1
Posted by Jesse <pu...@gmail.com>.
Done
On Thu, Apr 12, 2012 at 4:31 PM, Joe Bowser <bo...@gmail.com> wrote:
> I'd like to get the JS from the tag, but I need a tag for that.
>
> On Thu, Apr 12, 2012 at 4:29 PM, Jesse <pu...@gmail.com> wrote:
>
> > Okay, I think it's good, tagging at 16:32 PDT if i don't hear any
> > complaints.
> >
> > On Thu, Apr 12, 2012 at 4:26 PM, Filip Maj <fi...@adobe.com> wrote:
> >
> > > I just axed the existing 1.6.1 cordova-js tag
> > >
> > > Jesse when you feel you've got everything in there go ahead and tag JS
> > >
> > > On 4/12/12 4:20 PM, "Shazron" <sh...@gmail.com> wrote:
> > >
> > > >Reverted. Just talked to Jesse - he has commits to cordova-js coming,
> > > >once those are in we can re-tag cordova-js to 1.6.1
> > > >
> > > >On Thu, Apr 12, 2012 at 4:12 PM, Shazron <sh...@gmail.com> wrote:
> > > >> I'll remove it. *grabs the shovel*
> > > >>
> > > >> On Thu, Apr 12, 2012 at 4:10 PM, Joe Bowser <bo...@gmail.com>
> > wrote:
> > > >>> You know, let's not rebase it, because it does modify the history.
> > We
> > > >>> should remove and document why we did it instead, since that would
> be
> > > >>>more
> > > >>> transparent. Or we could just leave it in and say "don't do this
> next
> > > >>> time". I'm not that invested in it.
> > > >>>
> > > >>> On Thu, Apr 12, 2012 at 4:04 PM, Shazron <sh...@gmail.com>
> wrote:
> > > >>>
> > > >>>> If we take out that iOS commit in cordova-js (somehow), it should
> be
> > > >>>> fine. cordova-ios 1.6.1 will then just be the same as 1.6.0.
> > > >>>>
> > > >>>> On Thu, Apr 12, 2012 at 4:02 PM, Filip Maj <fi...@adobe.com> wrote:
> > > >>>> >
> > > >>>> >>Is it too much to drop the new commit that changed the common js
> > > >>>>API, and
> > > >>>> >>reapply it after we tag 1.6.1, and figure this one thing out for
> > > >>>>1.7?
> > > >>>> >
> > > >>>> > That sounds very good to me but I am under the impression that
> iOS
> > > >>>> > requires this commit? Like I said I'm quite confused.
> > > >>>> >
> > > >>>> >>
> > > >>>> >>I also have some cordova-js commits to add to 1.6.1? Although
> > > >>>>nothing
> > > >>>> that
> > > >>>> >>modifies any js outside of what is built for wp7. ( ie, all in
> my
> > > >>>> platform
> > > >>>> >>specific plugins folder )
> > > >>>> >>
> > > >>>> >
> > > >>>> > O then it sounds like I tagged the JS 1.6.1 too early anyways..
> > > >>>> >
> > > >>>> >>
> > > >>>> >>
> > > >>>> >>
> > > >>>> >>On Thu, Apr 12, 2012 at 3:51 PM, Shazron <sh...@gmail.com>
> > wrote:
> > > >>>> >>
> > > >>>> >>> No - it's about a user's contribution being noted (it
> exists), I
> > > >>>>will
> > > >>>> >>> move it out of the common code post-1.6.1 (I acknowledge my
> > > >>>>mistake in
> > > >>>> >>> allowing it in the first place). Can we branch off 1.6.0 then
> > > >>>> >>> cherry-pick Fil's latest fix for 1.6.1?
> > > >>>> >>>
> > > >>>> >>> On Thu, Apr 12, 2012 at 3:47 PM, Joe Bowser <
> bowserj@gmail.com>
> > > >>>>wrote:
> > > >>>> >>> > OK, so you're proposing that we leave the thing in the
> common
> > > >>>>JS,
> > > >>>> even
> > > >>>> >>> > though it's not supposed to be there.
> > > >>>> >>> >
> > > >>>> >>> > On Thu, Apr 12, 2012 at 3:45 PM, Shazron <shazron@gmail.com
> >
> > > >>>>wrote:
> > > >>>> >>> >
> > > >>>> >>> >> Will rebasing lose that commit? Then, no.
> > > >>>> >>> >>
> > > >>>> >>> >> On Thu, Apr 12, 2012 at 3:43 PM, Joe Bowser <
> > bowserj@gmail.com
> > > >
> > > >>>> >>>wrote:
> > > >>>> >>> >> > So, can we just rebase the head, push this out and get
> this
> > > >>>> >>>rolling?
> > > >>>> >>> >> >
> > > >>>> >>> >> > On Thu, Apr 12, 2012 at 3:43 PM, Filip Maj <
> fil@adobe.com>
> > > >>>>wrote:
> > > >>>> >>> >> >
> > > >>>> >>> >> >> Correct, those iOS-specific parameters (like allow edit
> > and
> > > >>>>those
> > > >>>> >>> ones)
> > > >>>> >>> >> >> existed prior to cordova-js, so yeah, we left them in
> > there
> > > >>>>as we
> > > >>>> >>> didn't
> > > >>>> >>> >> >> want to remove without deprecation.
> > > >>>> >>> >> >>
> > > >>>> >>> >> >> If you can deal with the iOS issue without needing an
> API
> > > >>>> >>>extension:
> > > >>>> >>> >> then
> > > >>>> >>> >> >> do that. If not, leave it in there, but docs need to
> > > >>>>updated too.
> > > >>>> >>> >> >>
> > > >>>> >>> >> >> Extending and changing the public API is a long and
> > > >>>>difficult
> > > >>>> >>>process
> > > >>>> >>> >> for
> > > >>>> >>> >> >> us and will only get tougher with every platform we add
> > > >>>>support
> > > >>>> >>>to.
> > > >>>> >>> >> >>
> > > >>>> >>> >> >> On 4/12/12 3:37 PM, "Shazron" <sh...@gmail.com>
> wrote:
> > > >>>> >>> >> >>
> > > >>>> >>> >> >> >Then we have to scrap the other three(?) iOS parameters
> > > >>>>ones
> > > >>>> that
> > > >>>> >>> >> >> >already exist in common if you noticed. Don't know how
> we
> > > >>>>merge
> > > >>>> >>> >> >> >(unmerge?) this one properly because taking those out
> > will
> > > >>>>break
> > > >>>> >>> >> >> >everyone that is using it, but a deprecation is the way
> > to
> > > >>>>go as
> > > >>>> >>>per
> > > >>>> >>> >> >> >http://wiki.apache.org/cordova/DeprecationPolicy . We
> > can
> > > >>>> remove
> > > >>>> >>> this
> > > >>>> >>> >> >> >new commit and I'll find a way to get this in somehow.
> > > >>>> >>> >> >> >
> > > >>>> >>> >> >> >
> > > >>>> >>> >> >> >
> > > >>>> >>> >> >> >On Thu, Apr 12, 2012 at 3:32 PM, Joe Bowser
> > > >>>><bo...@gmail.com>
> > > >>>> >>> wrote:
> > > >>>> >>> >> >> >> The problem is that this parameter doesn't belong in
> > the
> > > >>>> common
> > > >>>> >>> API.
> > > >>>> >>> >> >> >>It'd
> > > >>>> >>> >> >> >> be just ignored in Android, but the whole point of
> > > >>>>cordova-js
> > > >>>> >>>is
> > > >>>> >>> so
> > > >>>> >>> >> that
> > > >>>> >>> >> >> >> it's common. It'd look pretty screwed up to add this
> > to
> > > >>>>the
> > > >>>> >>>docs,
> > > >>>> >>> >> IMO.
> > > >>>> >>> >> >> >>
> > > >>>> >>> >> >> >> On Thu, Apr 12, 2012 at 3:26 PM, Shazron
> > > >>>><sh...@gmail.com>
> > > >>>> >>> wrote:
> > > >>>> >>> >> >> >>
> > > >>>> >>> >> >> >>> To fix two bugs for Camera.takePicture on iOS
> > > >>>> >>> >> >> >>>
> > > >>>> >>> >> >> >>> On Thu, Apr 12, 2012 at 3:24 PM, Filip Maj
> > > >>>><fi...@adobe.com>
> > > >>>> >>> wrote:
> > > >>>> >>> >> >> >>> > so what's the point of this new parameter?
> > > >>>> >>> >> >> >>> >
> > > >>>> >>> >> >> >>> > On 4/12/12 3:16 PM, "Shazron" <sh...@gmail.com>
> > > >>>>wrote:
> > > >>>> >>> >> >> >>> >
> > > >>>> >>> >> >> >>> >>I did. Do we want to revert the cordova-js? I can
> > > >>>>branch
> > > >>>> >>>1.6.0
> > > >>>> >>> and
> > > >>>> >>> >> >> >>> >>cherry-pick your latest commit for 1.6.1
> > > >>>> >>> >> >> >>> >>
> > > >>>> >>> >> >> >>> >>On Thu, Apr 12, 2012 at 3:04 PM, Filip Maj
> > > >>>><fi...@adobe.com>
> > > >>>> >>> wrote:
> > > >>>> >>> >> >> >>> >>> I saw something in the iOS commit logs for this.
> > > >>>> >>> >> >> >>> >>>
> > > >>>> >>> >> >> >>> >>> Shaz can you comment?
> > > >>>> >>> >> >> >>> >>>
> > > >>>> >>> >> >> >>> >>> On 4/12/12 2:59 PM, "Joe Bowser" <
> > bowserj@gmail.com
> > > >
> > > >>>> >>>wrote:
> > > >>>> >>> >> >> >>> >>>
> > > >>>> >>> >> >> >>> >>>>Can we revert this, since this looks like it's
> > > >>>>intended
> > > >>>> >>>for
> > > >>>> >>> both
> > > >>>> >>> >> >> >>> Android
> > > >>>> >>> >> >> >>> >>>>and iOS, but I don't think it should be in
> 1.6.1.
> > > >>>> >>> >> >> >>> >>>>
> > > >>>> >>> >> >> >>> >>>>On Thu, Apr 12, 2012 at 2:52 PM, Filip Maj <
> > > >>>> fil@adobe.com>
> > > >>>> >>> >> wrote:
> > > >>>> >>> >> >> >>> >>>>
> > > >>>> >>> >> >> >>> >>>>> I was actually just looking at that myself.
> > > >>>> >>> >> >> >>> >>>>>
> > > >>>> >>> >> >> >>> >>>>> Looks like it's an iOS-only param.. sigh. We
> > > >>>>gotta
> > > >>>> stop
> > > >>>> >>> doing
> > > >>>> >>> >> >> >>>that,
> > > >>>> >>> >> >> >>> >>>>> especially if we don't update documentation.
> > > >>>> >>> >> >> >>> >>>>>
> > > >>>> >>> >> >> >>> >>>>> On 4/12/12 2:49 PM, "Joe Bowser"
> > > >>>><bo...@gmail.com>
> > > >>>> >>> wrote:
> > > >>>> >>> >> >> >>> >>>>>
> > > >>>> >>> >> >> >>> >>>>> >Has anyone tested the cropToSize param for
> > > >>>> >>> Camera.getPicture
> > > >>>> >>> >> >> >>>yet? I
> > > >>>> >>> >> >> >>> >>>>> >didn't
> > > >>>> >>> >> >> >>> >>>>> >notice that change until now.
> > > >>>> >>> >> >> >>> >>>>> >
> > > >>>> >>> >> >> >>> >>>>> >On Thu, Apr 12, 2012 at 2:46 PM, Filip Maj
> > > >>>> >>><fil@adobe.com
> > > >>>> >>> >
> > > >>>> >>> >> >> >>>wrote:
> > > >>>> >>> >> >> >>> >>>>> >
> > > >>>> >>> >> >> >>> >>>>> >> JS tagged 1.6.1 - the build task in the JS
> > > >>>>should
> > > >>>> >>>work
> > > >>>> >>> >> >> >>>properly
> > > >>>> >>> >> >> >>> >>>>>now.
> > > >>>> >>> >> >> >>> >>>>> >>
> > > >>>> >>> >> >> >>> >>>>> >> FYI if anyone has to modify the jake tasks
> in
> > > >>>>the
> > > >>>> >>>future
> > > >>>> >>> >> and
> > > >>>> >>> >> >> >>>make
> > > >>>> >>> >> >> >>> >>>>>them
> > > >>>> >>> >> >> >>> >>>>> >> async, make sure you add the 4th "async"
> > > >>>>parameter
> > > >>>> to
> > > >>>> >>> the
> > > >>>> >>> >> >> >>>task()
> > > >>>> >>> >> >> >>> >>>>> >>function
> > > >>>> >>> >> >> >>> >>>>> >> and set it to true, and call complete()
> when
> > > >>>>the
> > > >>>> >>>task is
> > > >>>> >>> >> done.
> > > >>>> >>> >> >> >>> >>>>> >>
> > > >>>> >>> >> >> >>> >>>>> >> See
> > > >>>> >>> http://howtonode.org/intro-to-jake/async-jakefile.jsfor
> > > >>>> >>> >> >> >>>an
> > > >>>> >>> >> >> >>> >>>>> example.
> > > >>>> >>> >> >> >>> >>>>> >>
> > > >>>> >>> >> >> >>> >>>>> >> On 4/12/12 2:35 PM, "Joe Bowser"
> > > >>>><bowserj@gmail.com
> > > >>>> >
> > > >>>> >>> >> wrote:
> > > >>>> >>> >> >> >>> >>>>> >>
> > > >>>> >>> >> >> >>> >>>>> >> >Ready to tag once cordova-js is tagged
> > 1.6.1.
> > > >>>> >>> >> >> >>> >>>>> >> >
> > > >>>> >>> >> >> >>> >>>>> >> >On Thu, Apr 12, 2012 at 2:33 PM, Anis
> KADRI
> > <
> > > >>>> >>> >> >> >>> anis.kadri@gmail.com>
> > > >>>> >>> >> >> >>> >>>>> >>wrote:
> > > >>>> >>> >> >> >>> >>>>> >> >
> > > >>>> >>> >> >> >>> >>>>> >> >> I will tag my repository to 1.6.1 before
> > > >>>>end of
> > > >>>> >>>day
> > > >>>> >>> >> today
> > > >>>> >>> >> >> >>>after
> > > >>>> >>> >> >> >>> >>>>>some
> > > >>>> >>> >> >> >>> >>>>> >> >> thorough testing.
> > > >>>> >>> >> >> >>> >>>>> >> >>
> > > >>>> >>> >> >> >>> >>>>> >> >> On Thu, Apr 12, 2012 at 2:30 PM, Shazron
> > > >>>> >>> >> >> >>><sh...@gmail.com>
> > > >>>> >>> >> >> >>> >>>>>wrote:
> > > >>>> >>> >> >> >>> >>>>> >> >>
> > > >>>> >>> >> >> >>> >>>>> >> >> > I also created a 1.6.1 version tag as
> > > >>>>well in
> > > >>>> >>> jira...
> > > >>>> >>> >> >> >>> >>>>> >> >> >
> > > >>>> >>> >> >> >>> >>>>> >> >> > On Thu, Apr 12, 2012 at 2:29 PM,
> Shazron
> > > >>>> >>> >> >> >>><sh...@gmail.com>
> > > >>>> >>> >> >> >>> >>>>> wrote:
> > > >>>> >>> >> >> >>> >>>>> >> >> > > Alright guys since 1.6.0 was
> released,
> > > >>>>I'm
> > > >>>> >>>going
> > > >>>> >>> to
> > > >>>> >>> >> >> >>> >>>>>"Release"
> > > >>>> >>> >> >> >>> >>>>>the
> > > >>>> >>> >> >> >>> >>>>> >> >> > > 1.6.0 version in jira and move
> > > >>>>outstanding
> > > >>>> >>> issues to
> > > >>>> >>> >> >> >>>1.7.0
> > > >>>> >>> >> >> >>> >>>>> >>version
> > > >>>> >>> >> >> >>> >>>>> >> >> > > tag.
> > > >>>> >>> >> >> >>> >>>>> >> >> > >
> > > >>>> >>> >> >> >>> >>>>> >> >> > >
> > > >>>> >>> >> >> >>> >>>>> >> >> > > On Thu, Apr 12, 2012 at 2:26 PM,
> Filip
> > > >>>>Maj
> > > >>>> >>> >> >> >>><fi...@adobe.com>
> > > >>>> >>> >> >> >>> >>>>> wrote:
> > > >>>> >>> >> >> >>> >>>>> >> >> > >> The JS needs patching too. Since
> > > >>>>adding the
> > > >>>> >>> commit
> > > >>>> >>> >> ID
> > > >>>> >>> >> >> >>>into
> > > >>>> >>> >> >> >>> >>>>>the
> > > >>>> >>> >> >> >>> >>>>> >> >> packaging
> > > >>>> >>> >> >> >>> >>>>> >> >> > >> in the jakefile, the default task
> > isn't
> > > >>>> >>>running
> > > >>>> >>> >> >> >>>properly.
> > > >>>> >>> >> >> >>> >>>>> >> >> > >>
> > > >>>> >>> >> >> >>> >>>>> >> >> > >> You can manually run "jake build"
> and
> > > >>>>"jake
> > > >>>> >>> test"
> > > >>>> >>> >> but
> > > >>>> >>> >> >> >>>not
> > > >>>> >>> >> >> >>> >>>>> >>"jake" on
> > > >>>> >>> >> >> >>> >>>>> >> >> its
> > > >>>> >>> >> >> >>> >>>>> >> >> > >> own - gonna try to figure it out.
> > > >>>> >>> >> >> >>> >>>>> >> >> > >>
> > > >>>> >>> >> >> >>> >>>>> >> >> > >> On 4/12/12 2:21 PM, "Shazron" <
> > > >>>> >>> shazron@gmail.com>
> > > >>>> >>> >> >> >>>wrote:
> > > >>>> >>> >> >> >>> >>>>> >> >> > >>
> > > >>>> >>> >> >> >>> >>>>> >> >> > >>>I'm good with tagging. iOS has a
> few
> > > >>>> commits
> > > >>>> >>> (one
> > > >>>> >>> >> >> >>>commit
> > > >>>> >>> >> >> >>> >>>>>in
> > > >>>> >>> >> >> >>> >>>>> >> >> > >>>cordova-js) as well. Aim for first
> > > >>>>thing
> > > >>>> >>> tomorrow
> > > >>>> >>> >> for
> > > >>>> >>> >> >> >>>you
> > > >>>> >>> >> >> >>> >>>>>to
> > > >>>> >>> >> >> >>> >>>>> >> >> > >>>repackage?
> > > >>>> >>> >> >> >>> >>>>> >> >> > >>>
> > > >>>> >>> >> >> >>> >>>>> >> >> > >>>On Thu, Apr 12, 2012 at 2:17 PM,
> > > >>>>Steven Gill
> > > >>>> >>> >> >> >>> >>>>> >> >><st...@gmail.com>
> > > >>>> >>> >> >> >>> >>>>> >> >> > >>>wrote:
> > > >>>> >>> >> >> >>> >>>>> >> >> > >>>> So a bug has been discovered in
> > > >>>>Cordova
> > > >>>> >>> Android
> > > >>>> >>> >> that
> > > >>>> >>> >> >> >>> >>>>>requires
> > > >>>> >>> >> >> >>> >>>>> >>a
> > > >>>> >>> >> >> >>> >>>>> >> >>new
> > > >>>> >>> >> >> >>> >>>>> >> >> > tag
> > > >>>> >>> >> >> >>> >>>>> >> >> > >>>>and
> > > >>>> >>> >> >> >>> >>>>> >> >> > >>>> release. You can check out the
> bug
> > > >>>>on the
> > > >>>> >>> issue
> > > >>>> >>> >> >> >>>tracker
> > > >>>> >>> >> >> >>> >>>>>at
> > > >>>> >>> >> >> >>> >>>>> >> >> > >>>>
> > > >>>> >>> >> >> >>> >>>>> >> >> > >>>>
> > > >>>> >>> >> >> >>> >>>>> >> >> >
> > > >>>> >>> >> >> >>> >>>>> >> >>
> > > >>>> >>> >> >> >>> >>>>> >> >>
> > > >>>> >>> >> >> >>> >>>>> >>
> > > >>>> >>> >> >> >>> >>>>> >>
> > > >>>> >>> >> >> >>> >>>>>
> > > >>>> >>> >> >> >>> >>>>>
> > > >>>> >>> >> >> >>>
> > > >>>> >>> >> >>
> > > >>>> >>>
> > > >>>>
> > > >>>>
> > >
> https://issues.apache.org/jira/browse/CB-490?focusedCommentId=13252809#
> > > >>>> >>> >> >> >>> >>>>>co
> > > >>>> >>> >> >> >>> >>>>> >> >> > >>>>mment-13252809
> > > >>>> >>> >> >> >>> >>>>> >> >> > >>>>
> > > >>>> >>> >> >> >>> >>>>> >> >> > >>>> It doesn't make sense to just
> > > >>>>repackage
> > > >>>> >>>1.6.0
> > > >>>> >>> >> with
> > > >>>> >>> >> >> >>>this
> > > >>>> >>> >> >> >>> >>>>>bug
> > > >>>> >>> >> >> >>> >>>>> >> >>fixed as
> > > >>>> >>> >> >> >>> >>>>> >> >> > we
> > > >>>> >>> >> >> >>> >>>>> >> >> > >>>> will have no way to know if
> people
> > > >>>>are
> > > >>>> >>> >> experiencing
> > > >>>> >>> >> >> >>>this
> > > >>>> >>> >> >> >>> >>>>>or
> > > >>>> >>> >> >> >>> >>>>> >>not.
> > > >>>> >>> >> >> >>> >>>>> >> >> > >>>>
> > > >>>> >>> >> >> >>> >>>>> >> >> > >>>> Anis mentioned Bada also had some
> > > >>>>major
> > > >>>> >>>issues
> > > >>>> >>> >> >> >>>which he
> > > >>>> >>> >> >> >>> >>>>>has
> > > >>>> >>> >> >> >>> >>>>> >>fixed
> > > >>>> >>> >> >> >>> >>>>> >> >> now
> > > >>>> >>> >> >> >>> >>>>> >> >> > >>>>and
> > > >>>> >>> >> >> >>> >>>>> >> >> > >>>> would like in a 1.6.1 release.
> > > >>>> >>> >> >> >>> >>>>> >> >> > >>>>
> > > >>>> >>> >> >> >>> >>>>> >> >> > >>>> Thoughts?
> > > >>>> >>> >> >> >>> >>>>> >> >> > >>>>
> > > >>>> >>> >> >> >>> >>>>> >> >> > >>>> -Steve
> > > >>>> >>> >> >> >>> >>>>> >> >> > >>
> > > >>>> >>> >> >> >>> >>>>> >> >> >
> > > >>>> >>> >> >> >>> >>>>> >> >>
> > > >>>> >>> >> >> >>> >>>>> >>
> > > >>>> >>> >> >> >>> >>>>> >>
> > > >>>> >>> >> >> >>> >>>>>
> > > >>>> >>> >> >> >>> >>>>>
> > > >>>> >>> >> >> >>> >>>
> > > >>>> >>> >> >> >>> >
> > > >>>> >>> >> >> >>>
> > > >>>> >>> >> >>
> > > >>>> >>> >> >>
> > > >>>> >>> >>
> > > >>>> >>>
> > > >>>> >
> > > >>>>
> > >
> > >
> >
>
Re: 1.6.1
Posted by Joe Bowser <bo...@gmail.com>.
I'd like to get the JS from the tag, but I need a tag for that.
On Thu, Apr 12, 2012 at 4:29 PM, Jesse <pu...@gmail.com> wrote:
> Okay, I think it's good, tagging at 16:32 PDT if i don't hear any
> complaints.
>
> On Thu, Apr 12, 2012 at 4:26 PM, Filip Maj <fi...@adobe.com> wrote:
>
> > I just axed the existing 1.6.1 cordova-js tag
> >
> > Jesse when you feel you've got everything in there go ahead and tag JS
> >
> > On 4/12/12 4:20 PM, "Shazron" <sh...@gmail.com> wrote:
> >
> > >Reverted. Just talked to Jesse - he has commits to cordova-js coming,
> > >once those are in we can re-tag cordova-js to 1.6.1
> > >
> > >On Thu, Apr 12, 2012 at 4:12 PM, Shazron <sh...@gmail.com> wrote:
> > >> I'll remove it. *grabs the shovel*
> > >>
> > >> On Thu, Apr 12, 2012 at 4:10 PM, Joe Bowser <bo...@gmail.com>
> wrote:
> > >>> You know, let's not rebase it, because it does modify the history.
> We
> > >>> should remove and document why we did it instead, since that would be
> > >>>more
> > >>> transparent. Or we could just leave it in and say "don't do this next
> > >>> time". I'm not that invested in it.
> > >>>
> > >>> On Thu, Apr 12, 2012 at 4:04 PM, Shazron <sh...@gmail.com> wrote:
> > >>>
> > >>>> If we take out that iOS commit in cordova-js (somehow), it should be
> > >>>> fine. cordova-ios 1.6.1 will then just be the same as 1.6.0.
> > >>>>
> > >>>> On Thu, Apr 12, 2012 at 4:02 PM, Filip Maj <fi...@adobe.com> wrote:
> > >>>> >
> > >>>> >>Is it too much to drop the new commit that changed the common js
> > >>>>API, and
> > >>>> >>reapply it after we tag 1.6.1, and figure this one thing out for
> > >>>>1.7?
> > >>>> >
> > >>>> > That sounds very good to me but I am under the impression that iOS
> > >>>> > requires this commit? Like I said I'm quite confused.
> > >>>> >
> > >>>> >>
> > >>>> >>I also have some cordova-js commits to add to 1.6.1? Although
> > >>>>nothing
> > >>>> that
> > >>>> >>modifies any js outside of what is built for wp7. ( ie, all in my
> > >>>> platform
> > >>>> >>specific plugins folder )
> > >>>> >>
> > >>>> >
> > >>>> > O then it sounds like I tagged the JS 1.6.1 too early anyways..
> > >>>> >
> > >>>> >>
> > >>>> >>
> > >>>> >>
> > >>>> >>On Thu, Apr 12, 2012 at 3:51 PM, Shazron <sh...@gmail.com>
> wrote:
> > >>>> >>
> > >>>> >>> No - it's about a user's contribution being noted (it exists), I
> > >>>>will
> > >>>> >>> move it out of the common code post-1.6.1 (I acknowledge my
> > >>>>mistake in
> > >>>> >>> allowing it in the first place). Can we branch off 1.6.0 then
> > >>>> >>> cherry-pick Fil's latest fix for 1.6.1?
> > >>>> >>>
> > >>>> >>> On Thu, Apr 12, 2012 at 3:47 PM, Joe Bowser <bo...@gmail.com>
> > >>>>wrote:
> > >>>> >>> > OK, so you're proposing that we leave the thing in the common
> > >>>>JS,
> > >>>> even
> > >>>> >>> > though it's not supposed to be there.
> > >>>> >>> >
> > >>>> >>> > On Thu, Apr 12, 2012 at 3:45 PM, Shazron <sh...@gmail.com>
> > >>>>wrote:
> > >>>> >>> >
> > >>>> >>> >> Will rebasing lose that commit? Then, no.
> > >>>> >>> >>
> > >>>> >>> >> On Thu, Apr 12, 2012 at 3:43 PM, Joe Bowser <
> bowserj@gmail.com
> > >
> > >>>> >>>wrote:
> > >>>> >>> >> > So, can we just rebase the head, push this out and get this
> > >>>> >>>rolling?
> > >>>> >>> >> >
> > >>>> >>> >> > On Thu, Apr 12, 2012 at 3:43 PM, Filip Maj <fi...@adobe.com>
> > >>>>wrote:
> > >>>> >>> >> >
> > >>>> >>> >> >> Correct, those iOS-specific parameters (like allow edit
> and
> > >>>>those
> > >>>> >>> ones)
> > >>>> >>> >> >> existed prior to cordova-js, so yeah, we left them in
> there
> > >>>>as we
> > >>>> >>> didn't
> > >>>> >>> >> >> want to remove without deprecation.
> > >>>> >>> >> >>
> > >>>> >>> >> >> If you can deal with the iOS issue without needing an API
> > >>>> >>>extension:
> > >>>> >>> >> then
> > >>>> >>> >> >> do that. If not, leave it in there, but docs need to
> > >>>>updated too.
> > >>>> >>> >> >>
> > >>>> >>> >> >> Extending and changing the public API is a long and
> > >>>>difficult
> > >>>> >>>process
> > >>>> >>> >> for
> > >>>> >>> >> >> us and will only get tougher with every platform we add
> > >>>>support
> > >>>> >>>to.
> > >>>> >>> >> >>
> > >>>> >>> >> >> On 4/12/12 3:37 PM, "Shazron" <sh...@gmail.com> wrote:
> > >>>> >>> >> >>
> > >>>> >>> >> >> >Then we have to scrap the other three(?) iOS parameters
> > >>>>ones
> > >>>> that
> > >>>> >>> >> >> >already exist in common if you noticed. Don't know how we
> > >>>>merge
> > >>>> >>> >> >> >(unmerge?) this one properly because taking those out
> will
> > >>>>break
> > >>>> >>> >> >> >everyone that is using it, but a deprecation is the way
> to
> > >>>>go as
> > >>>> >>>per
> > >>>> >>> >> >> >http://wiki.apache.org/cordova/DeprecationPolicy . We
> can
> > >>>> remove
> > >>>> >>> this
> > >>>> >>> >> >> >new commit and I'll find a way to get this in somehow.
> > >>>> >>> >> >> >
> > >>>> >>> >> >> >
> > >>>> >>> >> >> >
> > >>>> >>> >> >> >On Thu, Apr 12, 2012 at 3:32 PM, Joe Bowser
> > >>>><bo...@gmail.com>
> > >>>> >>> wrote:
> > >>>> >>> >> >> >> The problem is that this parameter doesn't belong in
> the
> > >>>> common
> > >>>> >>> API.
> > >>>> >>> >> >> >>It'd
> > >>>> >>> >> >> >> be just ignored in Android, but the whole point of
> > >>>>cordova-js
> > >>>> >>>is
> > >>>> >>> so
> > >>>> >>> >> that
> > >>>> >>> >> >> >> it's common. It'd look pretty screwed up to add this
> to
> > >>>>the
> > >>>> >>>docs,
> > >>>> >>> >> IMO.
> > >>>> >>> >> >> >>
> > >>>> >>> >> >> >> On Thu, Apr 12, 2012 at 3:26 PM, Shazron
> > >>>><sh...@gmail.com>
> > >>>> >>> wrote:
> > >>>> >>> >> >> >>
> > >>>> >>> >> >> >>> To fix two bugs for Camera.takePicture on iOS
> > >>>> >>> >> >> >>>
> > >>>> >>> >> >> >>> On Thu, Apr 12, 2012 at 3:24 PM, Filip Maj
> > >>>><fi...@adobe.com>
> > >>>> >>> wrote:
> > >>>> >>> >> >> >>> > so what's the point of this new parameter?
> > >>>> >>> >> >> >>> >
> > >>>> >>> >> >> >>> > On 4/12/12 3:16 PM, "Shazron" <sh...@gmail.com>
> > >>>>wrote:
> > >>>> >>> >> >> >>> >
> > >>>> >>> >> >> >>> >>I did. Do we want to revert the cordova-js? I can
> > >>>>branch
> > >>>> >>>1.6.0
> > >>>> >>> and
> > >>>> >>> >> >> >>> >>cherry-pick your latest commit for 1.6.1
> > >>>> >>> >> >> >>> >>
> > >>>> >>> >> >> >>> >>On Thu, Apr 12, 2012 at 3:04 PM, Filip Maj
> > >>>><fi...@adobe.com>
> > >>>> >>> wrote:
> > >>>> >>> >> >> >>> >>> I saw something in the iOS commit logs for this.
> > >>>> >>> >> >> >>> >>>
> > >>>> >>> >> >> >>> >>> Shaz can you comment?
> > >>>> >>> >> >> >>> >>>
> > >>>> >>> >> >> >>> >>> On 4/12/12 2:59 PM, "Joe Bowser" <
> bowserj@gmail.com
> > >
> > >>>> >>>wrote:
> > >>>> >>> >> >> >>> >>>
> > >>>> >>> >> >> >>> >>>>Can we revert this, since this looks like it's
> > >>>>intended
> > >>>> >>>for
> > >>>> >>> both
> > >>>> >>> >> >> >>> Android
> > >>>> >>> >> >> >>> >>>>and iOS, but I don't think it should be in 1.6.1.
> > >>>> >>> >> >> >>> >>>>
> > >>>> >>> >> >> >>> >>>>On Thu, Apr 12, 2012 at 2:52 PM, Filip Maj <
> > >>>> fil@adobe.com>
> > >>>> >>> >> wrote:
> > >>>> >>> >> >> >>> >>>>
> > >>>> >>> >> >> >>> >>>>> I was actually just looking at that myself.
> > >>>> >>> >> >> >>> >>>>>
> > >>>> >>> >> >> >>> >>>>> Looks like it's an iOS-only param.. sigh. We
> > >>>>gotta
> > >>>> stop
> > >>>> >>> doing
> > >>>> >>> >> >> >>>that,
> > >>>> >>> >> >> >>> >>>>> especially if we don't update documentation.
> > >>>> >>> >> >> >>> >>>>>
> > >>>> >>> >> >> >>> >>>>> On 4/12/12 2:49 PM, "Joe Bowser"
> > >>>><bo...@gmail.com>
> > >>>> >>> wrote:
> > >>>> >>> >> >> >>> >>>>>
> > >>>> >>> >> >> >>> >>>>> >Has anyone tested the cropToSize param for
> > >>>> >>> Camera.getPicture
> > >>>> >>> >> >> >>>yet? I
> > >>>> >>> >> >> >>> >>>>> >didn't
> > >>>> >>> >> >> >>> >>>>> >notice that change until now.
> > >>>> >>> >> >> >>> >>>>> >
> > >>>> >>> >> >> >>> >>>>> >On Thu, Apr 12, 2012 at 2:46 PM, Filip Maj
> > >>>> >>><fil@adobe.com
> > >>>> >>> >
> > >>>> >>> >> >> >>>wrote:
> > >>>> >>> >> >> >>> >>>>> >
> > >>>> >>> >> >> >>> >>>>> >> JS tagged 1.6.1 - the build task in the JS
> > >>>>should
> > >>>> >>>work
> > >>>> >>> >> >> >>>properly
> > >>>> >>> >> >> >>> >>>>>now.
> > >>>> >>> >> >> >>> >>>>> >>
> > >>>> >>> >> >> >>> >>>>> >> FYI if anyone has to modify the jake tasks in
> > >>>>the
> > >>>> >>>future
> > >>>> >>> >> and
> > >>>> >>> >> >> >>>make
> > >>>> >>> >> >> >>> >>>>>them
> > >>>> >>> >> >> >>> >>>>> >> async, make sure you add the 4th "async"
> > >>>>parameter
> > >>>> to
> > >>>> >>> the
> > >>>> >>> >> >> >>>task()
> > >>>> >>> >> >> >>> >>>>> >>function
> > >>>> >>> >> >> >>> >>>>> >> and set it to true, and call complete() when
> > >>>>the
> > >>>> >>>task is
> > >>>> >>> >> done.
> > >>>> >>> >> >> >>> >>>>> >>
> > >>>> >>> >> >> >>> >>>>> >> See
> > >>>> >>> http://howtonode.org/intro-to-jake/async-jakefile.jsfor
> > >>>> >>> >> >> >>>an
> > >>>> >>> >> >> >>> >>>>> example.
> > >>>> >>> >> >> >>> >>>>> >>
> > >>>> >>> >> >> >>> >>>>> >> On 4/12/12 2:35 PM, "Joe Bowser"
> > >>>><bowserj@gmail.com
> > >>>> >
> > >>>> >>> >> wrote:
> > >>>> >>> >> >> >>> >>>>> >>
> > >>>> >>> >> >> >>> >>>>> >> >Ready to tag once cordova-js is tagged
> 1.6.1.
> > >>>> >>> >> >> >>> >>>>> >> >
> > >>>> >>> >> >> >>> >>>>> >> >On Thu, Apr 12, 2012 at 2:33 PM, Anis KADRI
> <
> > >>>> >>> >> >> >>> anis.kadri@gmail.com>
> > >>>> >>> >> >> >>> >>>>> >>wrote:
> > >>>> >>> >> >> >>> >>>>> >> >
> > >>>> >>> >> >> >>> >>>>> >> >> I will tag my repository to 1.6.1 before
> > >>>>end of
> > >>>> >>>day
> > >>>> >>> >> today
> > >>>> >>> >> >> >>>after
> > >>>> >>> >> >> >>> >>>>>some
> > >>>> >>> >> >> >>> >>>>> >> >> thorough testing.
> > >>>> >>> >> >> >>> >>>>> >> >>
> > >>>> >>> >> >> >>> >>>>> >> >> On Thu, Apr 12, 2012 at 2:30 PM, Shazron
> > >>>> >>> >> >> >>><sh...@gmail.com>
> > >>>> >>> >> >> >>> >>>>>wrote:
> > >>>> >>> >> >> >>> >>>>> >> >>
> > >>>> >>> >> >> >>> >>>>> >> >> > I also created a 1.6.1 version tag as
> > >>>>well in
> > >>>> >>> jira...
> > >>>> >>> >> >> >>> >>>>> >> >> >
> > >>>> >>> >> >> >>> >>>>> >> >> > On Thu, Apr 12, 2012 at 2:29 PM, Shazron
> > >>>> >>> >> >> >>><sh...@gmail.com>
> > >>>> >>> >> >> >>> >>>>> wrote:
> > >>>> >>> >> >> >>> >>>>> >> >> > > Alright guys since 1.6.0 was released,
> > >>>>I'm
> > >>>> >>>going
> > >>>> >>> to
> > >>>> >>> >> >> >>> >>>>>"Release"
> > >>>> >>> >> >> >>> >>>>>the
> > >>>> >>> >> >> >>> >>>>> >> >> > > 1.6.0 version in jira and move
> > >>>>outstanding
> > >>>> >>> issues to
> > >>>> >>> >> >> >>>1.7.0
> > >>>> >>> >> >> >>> >>>>> >>version
> > >>>> >>> >> >> >>> >>>>> >> >> > > tag.
> > >>>> >>> >> >> >>> >>>>> >> >> > >
> > >>>> >>> >> >> >>> >>>>> >> >> > >
> > >>>> >>> >> >> >>> >>>>> >> >> > > On Thu, Apr 12, 2012 at 2:26 PM, Filip
> > >>>>Maj
> > >>>> >>> >> >> >>><fi...@adobe.com>
> > >>>> >>> >> >> >>> >>>>> wrote:
> > >>>> >>> >> >> >>> >>>>> >> >> > >> The JS needs patching too. Since
> > >>>>adding the
> > >>>> >>> commit
> > >>>> >>> >> ID
> > >>>> >>> >> >> >>>into
> > >>>> >>> >> >> >>> >>>>>the
> > >>>> >>> >> >> >>> >>>>> >> >> packaging
> > >>>> >>> >> >> >>> >>>>> >> >> > >> in the jakefile, the default task
> isn't
> > >>>> >>>running
> > >>>> >>> >> >> >>>properly.
> > >>>> >>> >> >> >>> >>>>> >> >> > >>
> > >>>> >>> >> >> >>> >>>>> >> >> > >> You can manually run "jake build" and
> > >>>>"jake
> > >>>> >>> test"
> > >>>> >>> >> but
> > >>>> >>> >> >> >>>not
> > >>>> >>> >> >> >>> >>>>> >>"jake" on
> > >>>> >>> >> >> >>> >>>>> >> >> its
> > >>>> >>> >> >> >>> >>>>> >> >> > >> own - gonna try to figure it out.
> > >>>> >>> >> >> >>> >>>>> >> >> > >>
> > >>>> >>> >> >> >>> >>>>> >> >> > >> On 4/12/12 2:21 PM, "Shazron" <
> > >>>> >>> shazron@gmail.com>
> > >>>> >>> >> >> >>>wrote:
> > >>>> >>> >> >> >>> >>>>> >> >> > >>
> > >>>> >>> >> >> >>> >>>>> >> >> > >>>I'm good with tagging. iOS has a few
> > >>>> commits
> > >>>> >>> (one
> > >>>> >>> >> >> >>>commit
> > >>>> >>> >> >> >>> >>>>>in
> > >>>> >>> >> >> >>> >>>>> >> >> > >>>cordova-js) as well. Aim for first
> > >>>>thing
> > >>>> >>> tomorrow
> > >>>> >>> >> for
> > >>>> >>> >> >> >>>you
> > >>>> >>> >> >> >>> >>>>>to
> > >>>> >>> >> >> >>> >>>>> >> >> > >>>repackage?
> > >>>> >>> >> >> >>> >>>>> >> >> > >>>
> > >>>> >>> >> >> >>> >>>>> >> >> > >>>On Thu, Apr 12, 2012 at 2:17 PM,
> > >>>>Steven Gill
> > >>>> >>> >> >> >>> >>>>> >> >><st...@gmail.com>
> > >>>> >>> >> >> >>> >>>>> >> >> > >>>wrote:
> > >>>> >>> >> >> >>> >>>>> >> >> > >>>> So a bug has been discovered in
> > >>>>Cordova
> > >>>> >>> Android
> > >>>> >>> >> that
> > >>>> >>> >> >> >>> >>>>>requires
> > >>>> >>> >> >> >>> >>>>> >>a
> > >>>> >>> >> >> >>> >>>>> >> >>new
> > >>>> >>> >> >> >>> >>>>> >> >> > tag
> > >>>> >>> >> >> >>> >>>>> >> >> > >>>>and
> > >>>> >>> >> >> >>> >>>>> >> >> > >>>> release. You can check out the bug
> > >>>>on the
> > >>>> >>> issue
> > >>>> >>> >> >> >>>tracker
> > >>>> >>> >> >> >>> >>>>>at
> > >>>> >>> >> >> >>> >>>>> >> >> > >>>>
> > >>>> >>> >> >> >>> >>>>> >> >> > >>>>
> > >>>> >>> >> >> >>> >>>>> >> >> >
> > >>>> >>> >> >> >>> >>>>> >> >>
> > >>>> >>> >> >> >>> >>>>> >> >>
> > >>>> >>> >> >> >>> >>>>> >>
> > >>>> >>> >> >> >>> >>>>> >>
> > >>>> >>> >> >> >>> >>>>>
> > >>>> >>> >> >> >>> >>>>>
> > >>>> >>> >> >> >>>
> > >>>> >>> >> >>
> > >>>> >>>
> > >>>>
> > >>>>
> > https://issues.apache.org/jira/browse/CB-490?focusedCommentId=13252809#
> > >>>> >>> >> >> >>> >>>>>co
> > >>>> >>> >> >> >>> >>>>> >> >> > >>>>mment-13252809
> > >>>> >>> >> >> >>> >>>>> >> >> > >>>>
> > >>>> >>> >> >> >>> >>>>> >> >> > >>>> It doesn't make sense to just
> > >>>>repackage
> > >>>> >>>1.6.0
> > >>>> >>> >> with
> > >>>> >>> >> >> >>>this
> > >>>> >>> >> >> >>> >>>>>bug
> > >>>> >>> >> >> >>> >>>>> >> >>fixed as
> > >>>> >>> >> >> >>> >>>>> >> >> > we
> > >>>> >>> >> >> >>> >>>>> >> >> > >>>> will have no way to know if people
> > >>>>are
> > >>>> >>> >> experiencing
> > >>>> >>> >> >> >>>this
> > >>>> >>> >> >> >>> >>>>>or
> > >>>> >>> >> >> >>> >>>>> >>not.
> > >>>> >>> >> >> >>> >>>>> >> >> > >>>>
> > >>>> >>> >> >> >>> >>>>> >> >> > >>>> Anis mentioned Bada also had some
> > >>>>major
> > >>>> >>>issues
> > >>>> >>> >> >> >>>which he
> > >>>> >>> >> >> >>> >>>>>has
> > >>>> >>> >> >> >>> >>>>> >>fixed
> > >>>> >>> >> >> >>> >>>>> >> >> now
> > >>>> >>> >> >> >>> >>>>> >> >> > >>>>and
> > >>>> >>> >> >> >>> >>>>> >> >> > >>>> would like in a 1.6.1 release.
> > >>>> >>> >> >> >>> >>>>> >> >> > >>>>
> > >>>> >>> >> >> >>> >>>>> >> >> > >>>> Thoughts?
> > >>>> >>> >> >> >>> >>>>> >> >> > >>>>
> > >>>> >>> >> >> >>> >>>>> >> >> > >>>> -Steve
> > >>>> >>> >> >> >>> >>>>> >> >> > >>
> > >>>> >>> >> >> >>> >>>>> >> >> >
> > >>>> >>> >> >> >>> >>>>> >> >>
> > >>>> >>> >> >> >>> >>>>> >>
> > >>>> >>> >> >> >>> >>>>> >>
> > >>>> >>> >> >> >>> >>>>>
> > >>>> >>> >> >> >>> >>>>>
> > >>>> >>> >> >> >>> >>>
> > >>>> >>> >> >> >>> >
> > >>>> >>> >> >> >>>
> > >>>> >>> >> >>
> > >>>> >>> >> >>
> > >>>> >>> >>
> > >>>> >>>
> > >>>> >
> > >>>>
> >
> >
>
Re: 1.6.1
Posted by Jesse <pu...@gmail.com>.
Okay, I think it's good, tagging at 16:32 PDT if i don't hear any
complaints.
On Thu, Apr 12, 2012 at 4:26 PM, Filip Maj <fi...@adobe.com> wrote:
> I just axed the existing 1.6.1 cordova-js tag
>
> Jesse when you feel you've got everything in there go ahead and tag JS
>
> On 4/12/12 4:20 PM, "Shazron" <sh...@gmail.com> wrote:
>
> >Reverted. Just talked to Jesse - he has commits to cordova-js coming,
> >once those are in we can re-tag cordova-js to 1.6.1
> >
> >On Thu, Apr 12, 2012 at 4:12 PM, Shazron <sh...@gmail.com> wrote:
> >> I'll remove it. *grabs the shovel*
> >>
> >> On Thu, Apr 12, 2012 at 4:10 PM, Joe Bowser <bo...@gmail.com> wrote:
> >>> You know, let's not rebase it, because it does modify the history. We
> >>> should remove and document why we did it instead, since that would be
> >>>more
> >>> transparent. Or we could just leave it in and say "don't do this next
> >>> time". I'm not that invested in it.
> >>>
> >>> On Thu, Apr 12, 2012 at 4:04 PM, Shazron <sh...@gmail.com> wrote:
> >>>
> >>>> If we take out that iOS commit in cordova-js (somehow), it should be
> >>>> fine. cordova-ios 1.6.1 will then just be the same as 1.6.0.
> >>>>
> >>>> On Thu, Apr 12, 2012 at 4:02 PM, Filip Maj <fi...@adobe.com> wrote:
> >>>> >
> >>>> >>Is it too much to drop the new commit that changed the common js
> >>>>API, and
> >>>> >>reapply it after we tag 1.6.1, and figure this one thing out for
> >>>>1.7?
> >>>> >
> >>>> > That sounds very good to me but I am under the impression that iOS
> >>>> > requires this commit? Like I said I'm quite confused.
> >>>> >
> >>>> >>
> >>>> >>I also have some cordova-js commits to add to 1.6.1? Although
> >>>>nothing
> >>>> that
> >>>> >>modifies any js outside of what is built for wp7. ( ie, all in my
> >>>> platform
> >>>> >>specific plugins folder )
> >>>> >>
> >>>> >
> >>>> > O then it sounds like I tagged the JS 1.6.1 too early anyways..
> >>>> >
> >>>> >>
> >>>> >>
> >>>> >>
> >>>> >>On Thu, Apr 12, 2012 at 3:51 PM, Shazron <sh...@gmail.com> wrote:
> >>>> >>
> >>>> >>> No - it's about a user's contribution being noted (it exists), I
> >>>>will
> >>>> >>> move it out of the common code post-1.6.1 (I acknowledge my
> >>>>mistake in
> >>>> >>> allowing it in the first place). Can we branch off 1.6.0 then
> >>>> >>> cherry-pick Fil's latest fix for 1.6.1?
> >>>> >>>
> >>>> >>> On Thu, Apr 12, 2012 at 3:47 PM, Joe Bowser <bo...@gmail.com>
> >>>>wrote:
> >>>> >>> > OK, so you're proposing that we leave the thing in the common
> >>>>JS,
> >>>> even
> >>>> >>> > though it's not supposed to be there.
> >>>> >>> >
> >>>> >>> > On Thu, Apr 12, 2012 at 3:45 PM, Shazron <sh...@gmail.com>
> >>>>wrote:
> >>>> >>> >
> >>>> >>> >> Will rebasing lose that commit? Then, no.
> >>>> >>> >>
> >>>> >>> >> On Thu, Apr 12, 2012 at 3:43 PM, Joe Bowser <bowserj@gmail.com
> >
> >>>> >>>wrote:
> >>>> >>> >> > So, can we just rebase the head, push this out and get this
> >>>> >>>rolling?
> >>>> >>> >> >
> >>>> >>> >> > On Thu, Apr 12, 2012 at 3:43 PM, Filip Maj <fi...@adobe.com>
> >>>>wrote:
> >>>> >>> >> >
> >>>> >>> >> >> Correct, those iOS-specific parameters (like allow edit and
> >>>>those
> >>>> >>> ones)
> >>>> >>> >> >> existed prior to cordova-js, so yeah, we left them in there
> >>>>as we
> >>>> >>> didn't
> >>>> >>> >> >> want to remove without deprecation.
> >>>> >>> >> >>
> >>>> >>> >> >> If you can deal with the iOS issue without needing an API
> >>>> >>>extension:
> >>>> >>> >> then
> >>>> >>> >> >> do that. If not, leave it in there, but docs need to
> >>>>updated too.
> >>>> >>> >> >>
> >>>> >>> >> >> Extending and changing the public API is a long and
> >>>>difficult
> >>>> >>>process
> >>>> >>> >> for
> >>>> >>> >> >> us and will only get tougher with every platform we add
> >>>>support
> >>>> >>>to.
> >>>> >>> >> >>
> >>>> >>> >> >> On 4/12/12 3:37 PM, "Shazron" <sh...@gmail.com> wrote:
> >>>> >>> >> >>
> >>>> >>> >> >> >Then we have to scrap the other three(?) iOS parameters
> >>>>ones
> >>>> that
> >>>> >>> >> >> >already exist in common if you noticed. Don't know how we
> >>>>merge
> >>>> >>> >> >> >(unmerge?) this one properly because taking those out will
> >>>>break
> >>>> >>> >> >> >everyone that is using it, but a deprecation is the way to
> >>>>go as
> >>>> >>>per
> >>>> >>> >> >> >http://wiki.apache.org/cordova/DeprecationPolicy . We can
> >>>> remove
> >>>> >>> this
> >>>> >>> >> >> >new commit and I'll find a way to get this in somehow.
> >>>> >>> >> >> >
> >>>> >>> >> >> >
> >>>> >>> >> >> >
> >>>> >>> >> >> >On Thu, Apr 12, 2012 at 3:32 PM, Joe Bowser
> >>>><bo...@gmail.com>
> >>>> >>> wrote:
> >>>> >>> >> >> >> The problem is that this parameter doesn't belong in the
> >>>> common
> >>>> >>> API.
> >>>> >>> >> >> >>It'd
> >>>> >>> >> >> >> be just ignored in Android, but the whole point of
> >>>>cordova-js
> >>>> >>>is
> >>>> >>> so
> >>>> >>> >> that
> >>>> >>> >> >> >> it's common. It'd look pretty screwed up to add this to
> >>>>the
> >>>> >>>docs,
> >>>> >>> >> IMO.
> >>>> >>> >> >> >>
> >>>> >>> >> >> >> On Thu, Apr 12, 2012 at 3:26 PM, Shazron
> >>>><sh...@gmail.com>
> >>>> >>> wrote:
> >>>> >>> >> >> >>
> >>>> >>> >> >> >>> To fix two bugs for Camera.takePicture on iOS
> >>>> >>> >> >> >>>
> >>>> >>> >> >> >>> On Thu, Apr 12, 2012 at 3:24 PM, Filip Maj
> >>>><fi...@adobe.com>
> >>>> >>> wrote:
> >>>> >>> >> >> >>> > so what's the point of this new parameter?
> >>>> >>> >> >> >>> >
> >>>> >>> >> >> >>> > On 4/12/12 3:16 PM, "Shazron" <sh...@gmail.com>
> >>>>wrote:
> >>>> >>> >> >> >>> >
> >>>> >>> >> >> >>> >>I did. Do we want to revert the cordova-js? I can
> >>>>branch
> >>>> >>>1.6.0
> >>>> >>> and
> >>>> >>> >> >> >>> >>cherry-pick your latest commit for 1.6.1
> >>>> >>> >> >> >>> >>
> >>>> >>> >> >> >>> >>On Thu, Apr 12, 2012 at 3:04 PM, Filip Maj
> >>>><fi...@adobe.com>
> >>>> >>> wrote:
> >>>> >>> >> >> >>> >>> I saw something in the iOS commit logs for this.
> >>>> >>> >> >> >>> >>>
> >>>> >>> >> >> >>> >>> Shaz can you comment?
> >>>> >>> >> >> >>> >>>
> >>>> >>> >> >> >>> >>> On 4/12/12 2:59 PM, "Joe Bowser" <bowserj@gmail.com
> >
> >>>> >>>wrote:
> >>>> >>> >> >> >>> >>>
> >>>> >>> >> >> >>> >>>>Can we revert this, since this looks like it's
> >>>>intended
> >>>> >>>for
> >>>> >>> both
> >>>> >>> >> >> >>> Android
> >>>> >>> >> >> >>> >>>>and iOS, but I don't think it should be in 1.6.1.
> >>>> >>> >> >> >>> >>>>
> >>>> >>> >> >> >>> >>>>On Thu, Apr 12, 2012 at 2:52 PM, Filip Maj <
> >>>> fil@adobe.com>
> >>>> >>> >> wrote:
> >>>> >>> >> >> >>> >>>>
> >>>> >>> >> >> >>> >>>>> I was actually just looking at that myself.
> >>>> >>> >> >> >>> >>>>>
> >>>> >>> >> >> >>> >>>>> Looks like it's an iOS-only param.. sigh. We
> >>>>gotta
> >>>> stop
> >>>> >>> doing
> >>>> >>> >> >> >>>that,
> >>>> >>> >> >> >>> >>>>> especially if we don't update documentation.
> >>>> >>> >> >> >>> >>>>>
> >>>> >>> >> >> >>> >>>>> On 4/12/12 2:49 PM, "Joe Bowser"
> >>>><bo...@gmail.com>
> >>>> >>> wrote:
> >>>> >>> >> >> >>> >>>>>
> >>>> >>> >> >> >>> >>>>> >Has anyone tested the cropToSize param for
> >>>> >>> Camera.getPicture
> >>>> >>> >> >> >>>yet? I
> >>>> >>> >> >> >>> >>>>> >didn't
> >>>> >>> >> >> >>> >>>>> >notice that change until now.
> >>>> >>> >> >> >>> >>>>> >
> >>>> >>> >> >> >>> >>>>> >On Thu, Apr 12, 2012 at 2:46 PM, Filip Maj
> >>>> >>><fil@adobe.com
> >>>> >>> >
> >>>> >>> >> >> >>>wrote:
> >>>> >>> >> >> >>> >>>>> >
> >>>> >>> >> >> >>> >>>>> >> JS tagged 1.6.1 - the build task in the JS
> >>>>should
> >>>> >>>work
> >>>> >>> >> >> >>>properly
> >>>> >>> >> >> >>> >>>>>now.
> >>>> >>> >> >> >>> >>>>> >>
> >>>> >>> >> >> >>> >>>>> >> FYI if anyone has to modify the jake tasks in
> >>>>the
> >>>> >>>future
> >>>> >>> >> and
> >>>> >>> >> >> >>>make
> >>>> >>> >> >> >>> >>>>>them
> >>>> >>> >> >> >>> >>>>> >> async, make sure you add the 4th "async"
> >>>>parameter
> >>>> to
> >>>> >>> the
> >>>> >>> >> >> >>>task()
> >>>> >>> >> >> >>> >>>>> >>function
> >>>> >>> >> >> >>> >>>>> >> and set it to true, and call complete() when
> >>>>the
> >>>> >>>task is
> >>>> >>> >> done.
> >>>> >>> >> >> >>> >>>>> >>
> >>>> >>> >> >> >>> >>>>> >> See
> >>>> >>> http://howtonode.org/intro-to-jake/async-jakefile.jsfor
> >>>> >>> >> >> >>>an
> >>>> >>> >> >> >>> >>>>> example.
> >>>> >>> >> >> >>> >>>>> >>
> >>>> >>> >> >> >>> >>>>> >> On 4/12/12 2:35 PM, "Joe Bowser"
> >>>><bowserj@gmail.com
> >>>> >
> >>>> >>> >> wrote:
> >>>> >>> >> >> >>> >>>>> >>
> >>>> >>> >> >> >>> >>>>> >> >Ready to tag once cordova-js is tagged 1.6.1.
> >>>> >>> >> >> >>> >>>>> >> >
> >>>> >>> >> >> >>> >>>>> >> >On Thu, Apr 12, 2012 at 2:33 PM, Anis KADRI <
> >>>> >>> >> >> >>> anis.kadri@gmail.com>
> >>>> >>> >> >> >>> >>>>> >>wrote:
> >>>> >>> >> >> >>> >>>>> >> >
> >>>> >>> >> >> >>> >>>>> >> >> I will tag my repository to 1.6.1 before
> >>>>end of
> >>>> >>>day
> >>>> >>> >> today
> >>>> >>> >> >> >>>after
> >>>> >>> >> >> >>> >>>>>some
> >>>> >>> >> >> >>> >>>>> >> >> thorough testing.
> >>>> >>> >> >> >>> >>>>> >> >>
> >>>> >>> >> >> >>> >>>>> >> >> On Thu, Apr 12, 2012 at 2:30 PM, Shazron
> >>>> >>> >> >> >>><sh...@gmail.com>
> >>>> >>> >> >> >>> >>>>>wrote:
> >>>> >>> >> >> >>> >>>>> >> >>
> >>>> >>> >> >> >>> >>>>> >> >> > I also created a 1.6.1 version tag as
> >>>>well in
> >>>> >>> jira...
> >>>> >>> >> >> >>> >>>>> >> >> >
> >>>> >>> >> >> >>> >>>>> >> >> > On Thu, Apr 12, 2012 at 2:29 PM, Shazron
> >>>> >>> >> >> >>><sh...@gmail.com>
> >>>> >>> >> >> >>> >>>>> wrote:
> >>>> >>> >> >> >>> >>>>> >> >> > > Alright guys since 1.6.0 was released,
> >>>>I'm
> >>>> >>>going
> >>>> >>> to
> >>>> >>> >> >> >>> >>>>>"Release"
> >>>> >>> >> >> >>> >>>>>the
> >>>> >>> >> >> >>> >>>>> >> >> > > 1.6.0 version in jira and move
> >>>>outstanding
> >>>> >>> issues to
> >>>> >>> >> >> >>>1.7.0
> >>>> >>> >> >> >>> >>>>> >>version
> >>>> >>> >> >> >>> >>>>> >> >> > > tag.
> >>>> >>> >> >> >>> >>>>> >> >> > >
> >>>> >>> >> >> >>> >>>>> >> >> > >
> >>>> >>> >> >> >>> >>>>> >> >> > > On Thu, Apr 12, 2012 at 2:26 PM, Filip
> >>>>Maj
> >>>> >>> >> >> >>><fi...@adobe.com>
> >>>> >>> >> >> >>> >>>>> wrote:
> >>>> >>> >> >> >>> >>>>> >> >> > >> The JS needs patching too. Since
> >>>>adding the
> >>>> >>> commit
> >>>> >>> >> ID
> >>>> >>> >> >> >>>into
> >>>> >>> >> >> >>> >>>>>the
> >>>> >>> >> >> >>> >>>>> >> >> packaging
> >>>> >>> >> >> >>> >>>>> >> >> > >> in the jakefile, the default task isn't
> >>>> >>>running
> >>>> >>> >> >> >>>properly.
> >>>> >>> >> >> >>> >>>>> >> >> > >>
> >>>> >>> >> >> >>> >>>>> >> >> > >> You can manually run "jake build" and
> >>>>"jake
> >>>> >>> test"
> >>>> >>> >> but
> >>>> >>> >> >> >>>not
> >>>> >>> >> >> >>> >>>>> >>"jake" on
> >>>> >>> >> >> >>> >>>>> >> >> its
> >>>> >>> >> >> >>> >>>>> >> >> > >> own - gonna try to figure it out.
> >>>> >>> >> >> >>> >>>>> >> >> > >>
> >>>> >>> >> >> >>> >>>>> >> >> > >> On 4/12/12 2:21 PM, "Shazron" <
> >>>> >>> shazron@gmail.com>
> >>>> >>> >> >> >>>wrote:
> >>>> >>> >> >> >>> >>>>> >> >> > >>
> >>>> >>> >> >> >>> >>>>> >> >> > >>>I'm good with tagging. iOS has a few
> >>>> commits
> >>>> >>> (one
> >>>> >>> >> >> >>>commit
> >>>> >>> >> >> >>> >>>>>in
> >>>> >>> >> >> >>> >>>>> >> >> > >>>cordova-js) as well. Aim for first
> >>>>thing
> >>>> >>> tomorrow
> >>>> >>> >> for
> >>>> >>> >> >> >>>you
> >>>> >>> >> >> >>> >>>>>to
> >>>> >>> >> >> >>> >>>>> >> >> > >>>repackage?
> >>>> >>> >> >> >>> >>>>> >> >> > >>>
> >>>> >>> >> >> >>> >>>>> >> >> > >>>On Thu, Apr 12, 2012 at 2:17 PM,
> >>>>Steven Gill
> >>>> >>> >> >> >>> >>>>> >> >><st...@gmail.com>
> >>>> >>> >> >> >>> >>>>> >> >> > >>>wrote:
> >>>> >>> >> >> >>> >>>>> >> >> > >>>> So a bug has been discovered in
> >>>>Cordova
> >>>> >>> Android
> >>>> >>> >> that
> >>>> >>> >> >> >>> >>>>>requires
> >>>> >>> >> >> >>> >>>>> >>a
> >>>> >>> >> >> >>> >>>>> >> >>new
> >>>> >>> >> >> >>> >>>>> >> >> > tag
> >>>> >>> >> >> >>> >>>>> >> >> > >>>>and
> >>>> >>> >> >> >>> >>>>> >> >> > >>>> release. You can check out the bug
> >>>>on the
> >>>> >>> issue
> >>>> >>> >> >> >>>tracker
> >>>> >>> >> >> >>> >>>>>at
> >>>> >>> >> >> >>> >>>>> >> >> > >>>>
> >>>> >>> >> >> >>> >>>>> >> >> > >>>>
> >>>> >>> >> >> >>> >>>>> >> >> >
> >>>> >>> >> >> >>> >>>>> >> >>
> >>>> >>> >> >> >>> >>>>> >> >>
> >>>> >>> >> >> >>> >>>>> >>
> >>>> >>> >> >> >>> >>>>> >>
> >>>> >>> >> >> >>> >>>>>
> >>>> >>> >> >> >>> >>>>>
> >>>> >>> >> >> >>>
> >>>> >>> >> >>
> >>>> >>>
> >>>>
> >>>>
> https://issues.apache.org/jira/browse/CB-490?focusedCommentId=13252809#
> >>>> >>> >> >> >>> >>>>>co
> >>>> >>> >> >> >>> >>>>> >> >> > >>>>mment-13252809
> >>>> >>> >> >> >>> >>>>> >> >> > >>>>
> >>>> >>> >> >> >>> >>>>> >> >> > >>>> It doesn't make sense to just
> >>>>repackage
> >>>> >>>1.6.0
> >>>> >>> >> with
> >>>> >>> >> >> >>>this
> >>>> >>> >> >> >>> >>>>>bug
> >>>> >>> >> >> >>> >>>>> >> >>fixed as
> >>>> >>> >> >> >>> >>>>> >> >> > we
> >>>> >>> >> >> >>> >>>>> >> >> > >>>> will have no way to know if people
> >>>>are
> >>>> >>> >> experiencing
> >>>> >>> >> >> >>>this
> >>>> >>> >> >> >>> >>>>>or
> >>>> >>> >> >> >>> >>>>> >>not.
> >>>> >>> >> >> >>> >>>>> >> >> > >>>>
> >>>> >>> >> >> >>> >>>>> >> >> > >>>> Anis mentioned Bada also had some
> >>>>major
> >>>> >>>issues
> >>>> >>> >> >> >>>which he
> >>>> >>> >> >> >>> >>>>>has
> >>>> >>> >> >> >>> >>>>> >>fixed
> >>>> >>> >> >> >>> >>>>> >> >> now
> >>>> >>> >> >> >>> >>>>> >> >> > >>>>and
> >>>> >>> >> >> >>> >>>>> >> >> > >>>> would like in a 1.6.1 release.
> >>>> >>> >> >> >>> >>>>> >> >> > >>>>
> >>>> >>> >> >> >>> >>>>> >> >> > >>>> Thoughts?
> >>>> >>> >> >> >>> >>>>> >> >> > >>>>
> >>>> >>> >> >> >>> >>>>> >> >> > >>>> -Steve
> >>>> >>> >> >> >>> >>>>> >> >> > >>
> >>>> >>> >> >> >>> >>>>> >> >> >
> >>>> >>> >> >> >>> >>>>> >> >>
> >>>> >>> >> >> >>> >>>>> >>
> >>>> >>> >> >> >>> >>>>> >>
> >>>> >>> >> >> >>> >>>>>
> >>>> >>> >> >> >>> >>>>>
> >>>> >>> >> >> >>> >>>
> >>>> >>> >> >> >>> >
> >>>> >>> >> >> >>>
> >>>> >>> >> >>
> >>>> >>> >> >>
> >>>> >>> >>
> >>>> >>>
> >>>> >
> >>>>
>
>
Re: 1.6.1
Posted by Shazron <sh...@gmail.com>.
iOS is tagged 1.6.1 (exactly the same as iOS tag 1.6.0)
On Thu, Apr 12, 2012 at 4:20 PM, Shazron <sh...@gmail.com> wrote:
> Reverted. Just talked to Jesse - he has commits to cordova-js coming,
> once those are in we can re-tag cordova-js to 1.6.1
>
> On Thu, Apr 12, 2012 at 4:12 PM, Shazron <sh...@gmail.com> wrote:
>> I'll remove it. *grabs the shovel*
>>
>> On Thu, Apr 12, 2012 at 4:10 PM, Joe Bowser <bo...@gmail.com> wrote:
>>> You know, let's not rebase it, because it does modify the history. We
>>> should remove and document why we did it instead, since that would be more
>>> transparent. Or we could just leave it in and say "don't do this next
>>> time". I'm not that invested in it.
>>>
>>> On Thu, Apr 12, 2012 at 4:04 PM, Shazron <sh...@gmail.com> wrote:
>>>
>>>> If we take out that iOS commit in cordova-js (somehow), it should be
>>>> fine. cordova-ios 1.6.1 will then just be the same as 1.6.0.
>>>>
>>>> On Thu, Apr 12, 2012 at 4:02 PM, Filip Maj <fi...@adobe.com> wrote:
>>>> >
>>>> >>Is it too much to drop the new commit that changed the common js API, and
>>>> >>reapply it after we tag 1.6.1, and figure this one thing out for 1.7?
>>>> >
>>>> > That sounds very good to me but I am under the impression that iOS
>>>> > requires this commit? Like I said I'm quite confused.
>>>> >
>>>> >>
>>>> >>I also have some cordova-js commits to add to 1.6.1? Although nothing
>>>> that
>>>> >>modifies any js outside of what is built for wp7. ( ie, all in my
>>>> platform
>>>> >>specific plugins folder )
>>>> >>
>>>> >
>>>> > O then it sounds like I tagged the JS 1.6.1 too early anyways..
>>>> >
>>>> >>
>>>> >>
>>>> >>
>>>> >>On Thu, Apr 12, 2012 at 3:51 PM, Shazron <sh...@gmail.com> wrote:
>>>> >>
>>>> >>> No - it's about a user's contribution being noted (it exists), I will
>>>> >>> move it out of the common code post-1.6.1 (I acknowledge my mistake in
>>>> >>> allowing it in the first place). Can we branch off 1.6.0 then
>>>> >>> cherry-pick Fil's latest fix for 1.6.1?
>>>> >>>
>>>> >>> On Thu, Apr 12, 2012 at 3:47 PM, Joe Bowser <bo...@gmail.com> wrote:
>>>> >>> > OK, so you're proposing that we leave the thing in the common JS,
>>>> even
>>>> >>> > though it's not supposed to be there.
>>>> >>> >
>>>> >>> > On Thu, Apr 12, 2012 at 3:45 PM, Shazron <sh...@gmail.com> wrote:
>>>> >>> >
>>>> >>> >> Will rebasing lose that commit? Then, no.
>>>> >>> >>
>>>> >>> >> On Thu, Apr 12, 2012 at 3:43 PM, Joe Bowser <bo...@gmail.com>
>>>> >>>wrote:
>>>> >>> >> > So, can we just rebase the head, push this out and get this
>>>> >>>rolling?
>>>> >>> >> >
>>>> >>> >> > On Thu, Apr 12, 2012 at 3:43 PM, Filip Maj <fi...@adobe.com> wrote:
>>>> >>> >> >
>>>> >>> >> >> Correct, those iOS-specific parameters (like allow edit and those
>>>> >>> ones)
>>>> >>> >> >> existed prior to cordova-js, so yeah, we left them in there as we
>>>> >>> didn't
>>>> >>> >> >> want to remove without deprecation.
>>>> >>> >> >>
>>>> >>> >> >> If you can deal with the iOS issue without needing an API
>>>> >>>extension:
>>>> >>> >> then
>>>> >>> >> >> do that. If not, leave it in there, but docs need to updated too.
>>>> >>> >> >>
>>>> >>> >> >> Extending and changing the public API is a long and difficult
>>>> >>>process
>>>> >>> >> for
>>>> >>> >> >> us and will only get tougher with every platform we add support
>>>> >>>to.
>>>> >>> >> >>
>>>> >>> >> >> On 4/12/12 3:37 PM, "Shazron" <sh...@gmail.com> wrote:
>>>> >>> >> >>
>>>> >>> >> >> >Then we have to scrap the other three(?) iOS parameters ones
>>>> that
>>>> >>> >> >> >already exist in common if you noticed. Don't know how we merge
>>>> >>> >> >> >(unmerge?) this one properly because taking those out will break
>>>> >>> >> >> >everyone that is using it, but a deprecation is the way to go as
>>>> >>>per
>>>> >>> >> >> >http://wiki.apache.org/cordova/DeprecationPolicy . We can
>>>> remove
>>>> >>> this
>>>> >>> >> >> >new commit and I'll find a way to get this in somehow.
>>>> >>> >> >> >
>>>> >>> >> >> >
>>>> >>> >> >> >
>>>> >>> >> >> >On Thu, Apr 12, 2012 at 3:32 PM, Joe Bowser <bo...@gmail.com>
>>>> >>> wrote:
>>>> >>> >> >> >> The problem is that this parameter doesn't belong in the
>>>> common
>>>> >>> API.
>>>> >>> >> >> >>It'd
>>>> >>> >> >> >> be just ignored in Android, but the whole point of cordova-js
>>>> >>>is
>>>> >>> so
>>>> >>> >> that
>>>> >>> >> >> >> it's common. It'd look pretty screwed up to add this to the
>>>> >>>docs,
>>>> >>> >> IMO.
>>>> >>> >> >> >>
>>>> >>> >> >> >> On Thu, Apr 12, 2012 at 3:26 PM, Shazron <sh...@gmail.com>
>>>> >>> wrote:
>>>> >>> >> >> >>
>>>> >>> >> >> >>> To fix two bugs for Camera.takePicture on iOS
>>>> >>> >> >> >>>
>>>> >>> >> >> >>> On Thu, Apr 12, 2012 at 3:24 PM, Filip Maj <fi...@adobe.com>
>>>> >>> wrote:
>>>> >>> >> >> >>> > so what's the point of this new parameter?
>>>> >>> >> >> >>> >
>>>> >>> >> >> >>> > On 4/12/12 3:16 PM, "Shazron" <sh...@gmail.com> wrote:
>>>> >>> >> >> >>> >
>>>> >>> >> >> >>> >>I did. Do we want to revert the cordova-js? I can branch
>>>> >>>1.6.0
>>>> >>> and
>>>> >>> >> >> >>> >>cherry-pick your latest commit for 1.6.1
>>>> >>> >> >> >>> >>
>>>> >>> >> >> >>> >>On Thu, Apr 12, 2012 at 3:04 PM, Filip Maj <fi...@adobe.com>
>>>> >>> wrote:
>>>> >>> >> >> >>> >>> I saw something in the iOS commit logs for this.
>>>> >>> >> >> >>> >>>
>>>> >>> >> >> >>> >>> Shaz can you comment?
>>>> >>> >> >> >>> >>>
>>>> >>> >> >> >>> >>> On 4/12/12 2:59 PM, "Joe Bowser" <bo...@gmail.com>
>>>> >>>wrote:
>>>> >>> >> >> >>> >>>
>>>> >>> >> >> >>> >>>>Can we revert this, since this looks like it's intended
>>>> >>>for
>>>> >>> both
>>>> >>> >> >> >>> Android
>>>> >>> >> >> >>> >>>>and iOS, but I don't think it should be in 1.6.1.
>>>> >>> >> >> >>> >>>>
>>>> >>> >> >> >>> >>>>On Thu, Apr 12, 2012 at 2:52 PM, Filip Maj <
>>>> fil@adobe.com>
>>>> >>> >> wrote:
>>>> >>> >> >> >>> >>>>
>>>> >>> >> >> >>> >>>>> I was actually just looking at that myself.
>>>> >>> >> >> >>> >>>>>
>>>> >>> >> >> >>> >>>>> Looks like it's an iOS-only param.. sigh. We gotta
>>>> stop
>>>> >>> doing
>>>> >>> >> >> >>>that,
>>>> >>> >> >> >>> >>>>> especially if we don't update documentation.
>>>> >>> >> >> >>> >>>>>
>>>> >>> >> >> >>> >>>>> On 4/12/12 2:49 PM, "Joe Bowser" <bo...@gmail.com>
>>>> >>> wrote:
>>>> >>> >> >> >>> >>>>>
>>>> >>> >> >> >>> >>>>> >Has anyone tested the cropToSize param for
>>>> >>> Camera.getPicture
>>>> >>> >> >> >>>yet? I
>>>> >>> >> >> >>> >>>>> >didn't
>>>> >>> >> >> >>> >>>>> >notice that change until now.
>>>> >>> >> >> >>> >>>>> >
>>>> >>> >> >> >>> >>>>> >On Thu, Apr 12, 2012 at 2:46 PM, Filip Maj
>>>> >>><fil@adobe.com
>>>> >>> >
>>>> >>> >> >> >>>wrote:
>>>> >>> >> >> >>> >>>>> >
>>>> >>> >> >> >>> >>>>> >> JS tagged 1.6.1 - the build task in the JS should
>>>> >>>work
>>>> >>> >> >> >>>properly
>>>> >>> >> >> >>> >>>>>now.
>>>> >>> >> >> >>> >>>>> >>
>>>> >>> >> >> >>> >>>>> >> FYI if anyone has to modify the jake tasks in the
>>>> >>>future
>>>> >>> >> and
>>>> >>> >> >> >>>make
>>>> >>> >> >> >>> >>>>>them
>>>> >>> >> >> >>> >>>>> >> async, make sure you add the 4th "async" parameter
>>>> to
>>>> >>> the
>>>> >>> >> >> >>>task()
>>>> >>> >> >> >>> >>>>> >>function
>>>> >>> >> >> >>> >>>>> >> and set it to true, and call complete() when the
>>>> >>>task is
>>>> >>> >> done.
>>>> >>> >> >> >>> >>>>> >>
>>>> >>> >> >> >>> >>>>> >> See
>>>> >>> http://howtonode.org/intro-to-jake/async-jakefile.jsfor
>>>> >>> >> >> >>>an
>>>> >>> >> >> >>> >>>>> example.
>>>> >>> >> >> >>> >>>>> >>
>>>> >>> >> >> >>> >>>>> >> On 4/12/12 2:35 PM, "Joe Bowser" <bowserj@gmail.com
>>>> >
>>>> >>> >> wrote:
>>>> >>> >> >> >>> >>>>> >>
>>>> >>> >> >> >>> >>>>> >> >Ready to tag once cordova-js is tagged 1.6.1.
>>>> >>> >> >> >>> >>>>> >> >
>>>> >>> >> >> >>> >>>>> >> >On Thu, Apr 12, 2012 at 2:33 PM, Anis KADRI <
>>>> >>> >> >> >>> anis.kadri@gmail.com>
>>>> >>> >> >> >>> >>>>> >>wrote:
>>>> >>> >> >> >>> >>>>> >> >
>>>> >>> >> >> >>> >>>>> >> >> I will tag my repository to 1.6.1 before end of
>>>> >>>day
>>>> >>> >> today
>>>> >>> >> >> >>>after
>>>> >>> >> >> >>> >>>>>some
>>>> >>> >> >> >>> >>>>> >> >> thorough testing.
>>>> >>> >> >> >>> >>>>> >> >>
>>>> >>> >> >> >>> >>>>> >> >> On Thu, Apr 12, 2012 at 2:30 PM, Shazron
>>>> >>> >> >> >>><sh...@gmail.com>
>>>> >>> >> >> >>> >>>>>wrote:
>>>> >>> >> >> >>> >>>>> >> >>
>>>> >>> >> >> >>> >>>>> >> >> > I also created a 1.6.1 version tag as well in
>>>> >>> jira...
>>>> >>> >> >> >>> >>>>> >> >> >
>>>> >>> >> >> >>> >>>>> >> >> > On Thu, Apr 12, 2012 at 2:29 PM, Shazron
>>>> >>> >> >> >>><sh...@gmail.com>
>>>> >>> >> >> >>> >>>>> wrote:
>>>> >>> >> >> >>> >>>>> >> >> > > Alright guys since 1.6.0 was released, I'm
>>>> >>>going
>>>> >>> to
>>>> >>> >> >> >>> >>>>>"Release"
>>>> >>> >> >> >>> >>>>>the
>>>> >>> >> >> >>> >>>>> >> >> > > 1.6.0 version in jira and move outstanding
>>>> >>> issues to
>>>> >>> >> >> >>>1.7.0
>>>> >>> >> >> >>> >>>>> >>version
>>>> >>> >> >> >>> >>>>> >> >> > > tag.
>>>> >>> >> >> >>> >>>>> >> >> > >
>>>> >>> >> >> >>> >>>>> >> >> > >
>>>> >>> >> >> >>> >>>>> >> >> > > On Thu, Apr 12, 2012 at 2:26 PM, Filip Maj
>>>> >>> >> >> >>><fi...@adobe.com>
>>>> >>> >> >> >>> >>>>> wrote:
>>>> >>> >> >> >>> >>>>> >> >> > >> The JS needs patching too. Since adding the
>>>> >>> commit
>>>> >>> >> ID
>>>> >>> >> >> >>>into
>>>> >>> >> >> >>> >>>>>the
>>>> >>> >> >> >>> >>>>> >> >> packaging
>>>> >>> >> >> >>> >>>>> >> >> > >> in the jakefile, the default task isn't
>>>> >>>running
>>>> >>> >> >> >>>properly.
>>>> >>> >> >> >>> >>>>> >> >> > >>
>>>> >>> >> >> >>> >>>>> >> >> > >> You can manually run "jake build" and "jake
>>>> >>> test"
>>>> >>> >> but
>>>> >>> >> >> >>>not
>>>> >>> >> >> >>> >>>>> >>"jake" on
>>>> >>> >> >> >>> >>>>> >> >> its
>>>> >>> >> >> >>> >>>>> >> >> > >> own - gonna try to figure it out.
>>>> >>> >> >> >>> >>>>> >> >> > >>
>>>> >>> >> >> >>> >>>>> >> >> > >> On 4/12/12 2:21 PM, "Shazron" <
>>>> >>> shazron@gmail.com>
>>>> >>> >> >> >>>wrote:
>>>> >>> >> >> >>> >>>>> >> >> > >>
>>>> >>> >> >> >>> >>>>> >> >> > >>>I'm good with tagging. iOS has a few
>>>> commits
>>>> >>> (one
>>>> >>> >> >> >>>commit
>>>> >>> >> >> >>> >>>>>in
>>>> >>> >> >> >>> >>>>> >> >> > >>>cordova-js) as well. Aim for first thing
>>>> >>> tomorrow
>>>> >>> >> for
>>>> >>> >> >> >>>you
>>>> >>> >> >> >>> >>>>>to
>>>> >>> >> >> >>> >>>>> >> >> > >>>repackage?
>>>> >>> >> >> >>> >>>>> >> >> > >>>
>>>> >>> >> >> >>> >>>>> >> >> > >>>On Thu, Apr 12, 2012 at 2:17 PM, Steven Gill
>>>> >>> >> >> >>> >>>>> >> >><st...@gmail.com>
>>>> >>> >> >> >>> >>>>> >> >> > >>>wrote:
>>>> >>> >> >> >>> >>>>> >> >> > >>>> So a bug has been discovered in Cordova
>>>> >>> Android
>>>> >>> >> that
>>>> >>> >> >> >>> >>>>>requires
>>>> >>> >> >> >>> >>>>> >>a
>>>> >>> >> >> >>> >>>>> >> >>new
>>>> >>> >> >> >>> >>>>> >> >> > tag
>>>> >>> >> >> >>> >>>>> >> >> > >>>>and
>>>> >>> >> >> >>> >>>>> >> >> > >>>> release. You can check out the bug on the
>>>> >>> issue
>>>> >>> >> >> >>>tracker
>>>> >>> >> >> >>> >>>>>at
>>>> >>> >> >> >>> >>>>> >> >> > >>>>
>>>> >>> >> >> >>> >>>>> >> >> > >>>>
>>>> >>> >> >> >>> >>>>> >> >> >
>>>> >>> >> >> >>> >>>>> >> >>
>>>> >>> >> >> >>> >>>>> >> >>
>>>> >>> >> >> >>> >>>>> >>
>>>> >>> >> >> >>> >>>>> >>
>>>> >>> >> >> >>> >>>>>
>>>> >>> >> >> >>> >>>>>
>>>> >>> >> >> >>>
>>>> >>> >> >>
>>>> >>>
>>>> https://issues.apache.org/jira/browse/CB-490?focusedCommentId=13252809#
>>>> >>> >> >> >>> >>>>>co
>>>> >>> >> >> >>> >>>>> >> >> > >>>>mment-13252809
>>>> >>> >> >> >>> >>>>> >> >> > >>>>
>>>> >>> >> >> >>> >>>>> >> >> > >>>> It doesn't make sense to just repackage
>>>> >>>1.6.0
>>>> >>> >> with
>>>> >>> >> >> >>>this
>>>> >>> >> >> >>> >>>>>bug
>>>> >>> >> >> >>> >>>>> >> >>fixed as
>>>> >>> >> >> >>> >>>>> >> >> > we
>>>> >>> >> >> >>> >>>>> >> >> > >>>> will have no way to know if people are
>>>> >>> >> experiencing
>>>> >>> >> >> >>>this
>>>> >>> >> >> >>> >>>>>or
>>>> >>> >> >> >>> >>>>> >>not.
>>>> >>> >> >> >>> >>>>> >> >> > >>>>
>>>> >>> >> >> >>> >>>>> >> >> > >>>> Anis mentioned Bada also had some major
>>>> >>>issues
>>>> >>> >> >> >>>which he
>>>> >>> >> >> >>> >>>>>has
>>>> >>> >> >> >>> >>>>> >>fixed
>>>> >>> >> >> >>> >>>>> >> >> now
>>>> >>> >> >> >>> >>>>> >> >> > >>>>and
>>>> >>> >> >> >>> >>>>> >> >> > >>>> would like in a 1.6.1 release.
>>>> >>> >> >> >>> >>>>> >> >> > >>>>
>>>> >>> >> >> >>> >>>>> >> >> > >>>> Thoughts?
>>>> >>> >> >> >>> >>>>> >> >> > >>>>
>>>> >>> >> >> >>> >>>>> >> >> > >>>> -Steve
>>>> >>> >> >> >>> >>>>> >> >> > >>
>>>> >>> >> >> >>> >>>>> >> >> >
>>>> >>> >> >> >>> >>>>> >> >>
>>>> >>> >> >> >>> >>>>> >>
>>>> >>> >> >> >>> >>>>> >>
>>>> >>> >> >> >>> >>>>>
>>>> >>> >> >> >>> >>>>>
>>>> >>> >> >> >>> >>>
>>>> >>> >> >> >>> >
>>>> >>> >> >> >>>
>>>> >>> >> >>
>>>> >>> >> >>
>>>> >>> >>
>>>> >>>
>>>> >
>>>>
Re: 1.6.1
Posted by Filip Maj <fi...@adobe.com>.
I just axed the existing 1.6.1 cordova-js tag
Jesse when you feel you've got everything in there go ahead and tag JS
On 4/12/12 4:20 PM, "Shazron" <sh...@gmail.com> wrote:
>Reverted. Just talked to Jesse - he has commits to cordova-js coming,
>once those are in we can re-tag cordova-js to 1.6.1
>
>On Thu, Apr 12, 2012 at 4:12 PM, Shazron <sh...@gmail.com> wrote:
>> I'll remove it. *grabs the shovel*
>>
>> On Thu, Apr 12, 2012 at 4:10 PM, Joe Bowser <bo...@gmail.com> wrote:
>>> You know, let's not rebase it, because it does modify the history. We
>>> should remove and document why we did it instead, since that would be
>>>more
>>> transparent. Or we could just leave it in and say "don't do this next
>>> time". I'm not that invested in it.
>>>
>>> On Thu, Apr 12, 2012 at 4:04 PM, Shazron <sh...@gmail.com> wrote:
>>>
>>>> If we take out that iOS commit in cordova-js (somehow), it should be
>>>> fine. cordova-ios 1.6.1 will then just be the same as 1.6.0.
>>>>
>>>> On Thu, Apr 12, 2012 at 4:02 PM, Filip Maj <fi...@adobe.com> wrote:
>>>> >
>>>> >>Is it too much to drop the new commit that changed the common js
>>>>API, and
>>>> >>reapply it after we tag 1.6.1, and figure this one thing out for
>>>>1.7?
>>>> >
>>>> > That sounds very good to me but I am under the impression that iOS
>>>> > requires this commit? Like I said I'm quite confused.
>>>> >
>>>> >>
>>>> >>I also have some cordova-js commits to add to 1.6.1? Although
>>>>nothing
>>>> that
>>>> >>modifies any js outside of what is built for wp7. ( ie, all in my
>>>> platform
>>>> >>specific plugins folder )
>>>> >>
>>>> >
>>>> > O then it sounds like I tagged the JS 1.6.1 too early anyways..
>>>> >
>>>> >>
>>>> >>
>>>> >>
>>>> >>On Thu, Apr 12, 2012 at 3:51 PM, Shazron <sh...@gmail.com> wrote:
>>>> >>
>>>> >>> No - it's about a user's contribution being noted (it exists), I
>>>>will
>>>> >>> move it out of the common code post-1.6.1 (I acknowledge my
>>>>mistake in
>>>> >>> allowing it in the first place). Can we branch off 1.6.0 then
>>>> >>> cherry-pick Fil's latest fix for 1.6.1?
>>>> >>>
>>>> >>> On Thu, Apr 12, 2012 at 3:47 PM, Joe Bowser <bo...@gmail.com>
>>>>wrote:
>>>> >>> > OK, so you're proposing that we leave the thing in the common
>>>>JS,
>>>> even
>>>> >>> > though it's not supposed to be there.
>>>> >>> >
>>>> >>> > On Thu, Apr 12, 2012 at 3:45 PM, Shazron <sh...@gmail.com>
>>>>wrote:
>>>> >>> >
>>>> >>> >> Will rebasing lose that commit? Then, no.
>>>> >>> >>
>>>> >>> >> On Thu, Apr 12, 2012 at 3:43 PM, Joe Bowser <bo...@gmail.com>
>>>> >>>wrote:
>>>> >>> >> > So, can we just rebase the head, push this out and get this
>>>> >>>rolling?
>>>> >>> >> >
>>>> >>> >> > On Thu, Apr 12, 2012 at 3:43 PM, Filip Maj <fi...@adobe.com>
>>>>wrote:
>>>> >>> >> >
>>>> >>> >> >> Correct, those iOS-specific parameters (like allow edit and
>>>>those
>>>> >>> ones)
>>>> >>> >> >> existed prior to cordova-js, so yeah, we left them in there
>>>>as we
>>>> >>> didn't
>>>> >>> >> >> want to remove without deprecation.
>>>> >>> >> >>
>>>> >>> >> >> If you can deal with the iOS issue without needing an API
>>>> >>>extension:
>>>> >>> >> then
>>>> >>> >> >> do that. If not, leave it in there, but docs need to
>>>>updated too.
>>>> >>> >> >>
>>>> >>> >> >> Extending and changing the public API is a long and
>>>>difficult
>>>> >>>process
>>>> >>> >> for
>>>> >>> >> >> us and will only get tougher with every platform we add
>>>>support
>>>> >>>to.
>>>> >>> >> >>
>>>> >>> >> >> On 4/12/12 3:37 PM, "Shazron" <sh...@gmail.com> wrote:
>>>> >>> >> >>
>>>> >>> >> >> >Then we have to scrap the other three(?) iOS parameters
>>>>ones
>>>> that
>>>> >>> >> >> >already exist in common if you noticed. Don't know how we
>>>>merge
>>>> >>> >> >> >(unmerge?) this one properly because taking those out will
>>>>break
>>>> >>> >> >> >everyone that is using it, but a deprecation is the way to
>>>>go as
>>>> >>>per
>>>> >>> >> >> >http://wiki.apache.org/cordova/DeprecationPolicy . We can
>>>> remove
>>>> >>> this
>>>> >>> >> >> >new commit and I'll find a way to get this in somehow.
>>>> >>> >> >> >
>>>> >>> >> >> >
>>>> >>> >> >> >
>>>> >>> >> >> >On Thu, Apr 12, 2012 at 3:32 PM, Joe Bowser
>>>><bo...@gmail.com>
>>>> >>> wrote:
>>>> >>> >> >> >> The problem is that this parameter doesn't belong in the
>>>> common
>>>> >>> API.
>>>> >>> >> >> >>It'd
>>>> >>> >> >> >> be just ignored in Android, but the whole point of
>>>>cordova-js
>>>> >>>is
>>>> >>> so
>>>> >>> >> that
>>>> >>> >> >> >> it's common. It'd look pretty screwed up to add this to
>>>>the
>>>> >>>docs,
>>>> >>> >> IMO.
>>>> >>> >> >> >>
>>>> >>> >> >> >> On Thu, Apr 12, 2012 at 3:26 PM, Shazron
>>>><sh...@gmail.com>
>>>> >>> wrote:
>>>> >>> >> >> >>
>>>> >>> >> >> >>> To fix two bugs for Camera.takePicture on iOS
>>>> >>> >> >> >>>
>>>> >>> >> >> >>> On Thu, Apr 12, 2012 at 3:24 PM, Filip Maj
>>>><fi...@adobe.com>
>>>> >>> wrote:
>>>> >>> >> >> >>> > so what's the point of this new parameter?
>>>> >>> >> >> >>> >
>>>> >>> >> >> >>> > On 4/12/12 3:16 PM, "Shazron" <sh...@gmail.com>
>>>>wrote:
>>>> >>> >> >> >>> >
>>>> >>> >> >> >>> >>I did. Do we want to revert the cordova-js? I can
>>>>branch
>>>> >>>1.6.0
>>>> >>> and
>>>> >>> >> >> >>> >>cherry-pick your latest commit for 1.6.1
>>>> >>> >> >> >>> >>
>>>> >>> >> >> >>> >>On Thu, Apr 12, 2012 at 3:04 PM, Filip Maj
>>>><fi...@adobe.com>
>>>> >>> wrote:
>>>> >>> >> >> >>> >>> I saw something in the iOS commit logs for this.
>>>> >>> >> >> >>> >>>
>>>> >>> >> >> >>> >>> Shaz can you comment?
>>>> >>> >> >> >>> >>>
>>>> >>> >> >> >>> >>> On 4/12/12 2:59 PM, "Joe Bowser" <bo...@gmail.com>
>>>> >>>wrote:
>>>> >>> >> >> >>> >>>
>>>> >>> >> >> >>> >>>>Can we revert this, since this looks like it's
>>>>intended
>>>> >>>for
>>>> >>> both
>>>> >>> >> >> >>> Android
>>>> >>> >> >> >>> >>>>and iOS, but I don't think it should be in 1.6.1.
>>>> >>> >> >> >>> >>>>
>>>> >>> >> >> >>> >>>>On Thu, Apr 12, 2012 at 2:52 PM, Filip Maj <
>>>> fil@adobe.com>
>>>> >>> >> wrote:
>>>> >>> >> >> >>> >>>>
>>>> >>> >> >> >>> >>>>> I was actually just looking at that myself.
>>>> >>> >> >> >>> >>>>>
>>>> >>> >> >> >>> >>>>> Looks like it's an iOS-only param.. sigh. We
>>>>gotta
>>>> stop
>>>> >>> doing
>>>> >>> >> >> >>>that,
>>>> >>> >> >> >>> >>>>> especially if we don't update documentation.
>>>> >>> >> >> >>> >>>>>
>>>> >>> >> >> >>> >>>>> On 4/12/12 2:49 PM, "Joe Bowser"
>>>><bo...@gmail.com>
>>>> >>> wrote:
>>>> >>> >> >> >>> >>>>>
>>>> >>> >> >> >>> >>>>> >Has anyone tested the cropToSize param for
>>>> >>> Camera.getPicture
>>>> >>> >> >> >>>yet? I
>>>> >>> >> >> >>> >>>>> >didn't
>>>> >>> >> >> >>> >>>>> >notice that change until now.
>>>> >>> >> >> >>> >>>>> >
>>>> >>> >> >> >>> >>>>> >On Thu, Apr 12, 2012 at 2:46 PM, Filip Maj
>>>> >>><fil@adobe.com
>>>> >>> >
>>>> >>> >> >> >>>wrote:
>>>> >>> >> >> >>> >>>>> >
>>>> >>> >> >> >>> >>>>> >> JS tagged 1.6.1 - the build task in the JS
>>>>should
>>>> >>>work
>>>> >>> >> >> >>>properly
>>>> >>> >> >> >>> >>>>>now.
>>>> >>> >> >> >>> >>>>> >>
>>>> >>> >> >> >>> >>>>> >> FYI if anyone has to modify the jake tasks in
>>>>the
>>>> >>>future
>>>> >>> >> and
>>>> >>> >> >> >>>make
>>>> >>> >> >> >>> >>>>>them
>>>> >>> >> >> >>> >>>>> >> async, make sure you add the 4th "async"
>>>>parameter
>>>> to
>>>> >>> the
>>>> >>> >> >> >>>task()
>>>> >>> >> >> >>> >>>>> >>function
>>>> >>> >> >> >>> >>>>> >> and set it to true, and call complete() when
>>>>the
>>>> >>>task is
>>>> >>> >> done.
>>>> >>> >> >> >>> >>>>> >>
>>>> >>> >> >> >>> >>>>> >> See
>>>> >>> http://howtonode.org/intro-to-jake/async-jakefile.jsfor
>>>> >>> >> >> >>>an
>>>> >>> >> >> >>> >>>>> example.
>>>> >>> >> >> >>> >>>>> >>
>>>> >>> >> >> >>> >>>>> >> On 4/12/12 2:35 PM, "Joe Bowser"
>>>><bowserj@gmail.com
>>>> >
>>>> >>> >> wrote:
>>>> >>> >> >> >>> >>>>> >>
>>>> >>> >> >> >>> >>>>> >> >Ready to tag once cordova-js is tagged 1.6.1.
>>>> >>> >> >> >>> >>>>> >> >
>>>> >>> >> >> >>> >>>>> >> >On Thu, Apr 12, 2012 at 2:33 PM, Anis KADRI <
>>>> >>> >> >> >>> anis.kadri@gmail.com>
>>>> >>> >> >> >>> >>>>> >>wrote:
>>>> >>> >> >> >>> >>>>> >> >
>>>> >>> >> >> >>> >>>>> >> >> I will tag my repository to 1.6.1 before
>>>>end of
>>>> >>>day
>>>> >>> >> today
>>>> >>> >> >> >>>after
>>>> >>> >> >> >>> >>>>>some
>>>> >>> >> >> >>> >>>>> >> >> thorough testing.
>>>> >>> >> >> >>> >>>>> >> >>
>>>> >>> >> >> >>> >>>>> >> >> On Thu, Apr 12, 2012 at 2:30 PM, Shazron
>>>> >>> >> >> >>><sh...@gmail.com>
>>>> >>> >> >> >>> >>>>>wrote:
>>>> >>> >> >> >>> >>>>> >> >>
>>>> >>> >> >> >>> >>>>> >> >> > I also created a 1.6.1 version tag as
>>>>well in
>>>> >>> jira...
>>>> >>> >> >> >>> >>>>> >> >> >
>>>> >>> >> >> >>> >>>>> >> >> > On Thu, Apr 12, 2012 at 2:29 PM, Shazron
>>>> >>> >> >> >>><sh...@gmail.com>
>>>> >>> >> >> >>> >>>>> wrote:
>>>> >>> >> >> >>> >>>>> >> >> > > Alright guys since 1.6.0 was released,
>>>>I'm
>>>> >>>going
>>>> >>> to
>>>> >>> >> >> >>> >>>>>"Release"
>>>> >>> >> >> >>> >>>>>the
>>>> >>> >> >> >>> >>>>> >> >> > > 1.6.0 version in jira and move
>>>>outstanding
>>>> >>> issues to
>>>> >>> >> >> >>>1.7.0
>>>> >>> >> >> >>> >>>>> >>version
>>>> >>> >> >> >>> >>>>> >> >> > > tag.
>>>> >>> >> >> >>> >>>>> >> >> > >
>>>> >>> >> >> >>> >>>>> >> >> > >
>>>> >>> >> >> >>> >>>>> >> >> > > On Thu, Apr 12, 2012 at 2:26 PM, Filip
>>>>Maj
>>>> >>> >> >> >>><fi...@adobe.com>
>>>> >>> >> >> >>> >>>>> wrote:
>>>> >>> >> >> >>> >>>>> >> >> > >> The JS needs patching too. Since
>>>>adding the
>>>> >>> commit
>>>> >>> >> ID
>>>> >>> >> >> >>>into
>>>> >>> >> >> >>> >>>>>the
>>>> >>> >> >> >>> >>>>> >> >> packaging
>>>> >>> >> >> >>> >>>>> >> >> > >> in the jakefile, the default task isn't
>>>> >>>running
>>>> >>> >> >> >>>properly.
>>>> >>> >> >> >>> >>>>> >> >> > >>
>>>> >>> >> >> >>> >>>>> >> >> > >> You can manually run "jake build" and
>>>>"jake
>>>> >>> test"
>>>> >>> >> but
>>>> >>> >> >> >>>not
>>>> >>> >> >> >>> >>>>> >>"jake" on
>>>> >>> >> >> >>> >>>>> >> >> its
>>>> >>> >> >> >>> >>>>> >> >> > >> own - gonna try to figure it out.
>>>> >>> >> >> >>> >>>>> >> >> > >>
>>>> >>> >> >> >>> >>>>> >> >> > >> On 4/12/12 2:21 PM, "Shazron" <
>>>> >>> shazron@gmail.com>
>>>> >>> >> >> >>>wrote:
>>>> >>> >> >> >>> >>>>> >> >> > >>
>>>> >>> >> >> >>> >>>>> >> >> > >>>I'm good with tagging. iOS has a few
>>>> commits
>>>> >>> (one
>>>> >>> >> >> >>>commit
>>>> >>> >> >> >>> >>>>>in
>>>> >>> >> >> >>> >>>>> >> >> > >>>cordova-js) as well. Aim for first
>>>>thing
>>>> >>> tomorrow
>>>> >>> >> for
>>>> >>> >> >> >>>you
>>>> >>> >> >> >>> >>>>>to
>>>> >>> >> >> >>> >>>>> >> >> > >>>repackage?
>>>> >>> >> >> >>> >>>>> >> >> > >>>
>>>> >>> >> >> >>> >>>>> >> >> > >>>On Thu, Apr 12, 2012 at 2:17 PM,
>>>>Steven Gill
>>>> >>> >> >> >>> >>>>> >> >><st...@gmail.com>
>>>> >>> >> >> >>> >>>>> >> >> > >>>wrote:
>>>> >>> >> >> >>> >>>>> >> >> > >>>> So a bug has been discovered in
>>>>Cordova
>>>> >>> Android
>>>> >>> >> that
>>>> >>> >> >> >>> >>>>>requires
>>>> >>> >> >> >>> >>>>> >>a
>>>> >>> >> >> >>> >>>>> >> >>new
>>>> >>> >> >> >>> >>>>> >> >> > tag
>>>> >>> >> >> >>> >>>>> >> >> > >>>>and
>>>> >>> >> >> >>> >>>>> >> >> > >>>> release. You can check out the bug
>>>>on the
>>>> >>> issue
>>>> >>> >> >> >>>tracker
>>>> >>> >> >> >>> >>>>>at
>>>> >>> >> >> >>> >>>>> >> >> > >>>>
>>>> >>> >> >> >>> >>>>> >> >> > >>>>
>>>> >>> >> >> >>> >>>>> >> >> >
>>>> >>> >> >> >>> >>>>> >> >>
>>>> >>> >> >> >>> >>>>> >> >>
>>>> >>> >> >> >>> >>>>> >>
>>>> >>> >> >> >>> >>>>> >>
>>>> >>> >> >> >>> >>>>>
>>>> >>> >> >> >>> >>>>>
>>>> >>> >> >> >>>
>>>> >>> >> >>
>>>> >>>
>>>>
>>>>https://issues.apache.org/jira/browse/CB-490?focusedCommentId=13252809#
>>>> >>> >> >> >>> >>>>>co
>>>> >>> >> >> >>> >>>>> >> >> > >>>>mment-13252809
>>>> >>> >> >> >>> >>>>> >> >> > >>>>
>>>> >>> >> >> >>> >>>>> >> >> > >>>> It doesn't make sense to just
>>>>repackage
>>>> >>>1.6.0
>>>> >>> >> with
>>>> >>> >> >> >>>this
>>>> >>> >> >> >>> >>>>>bug
>>>> >>> >> >> >>> >>>>> >> >>fixed as
>>>> >>> >> >> >>> >>>>> >> >> > we
>>>> >>> >> >> >>> >>>>> >> >> > >>>> will have no way to know if people
>>>>are
>>>> >>> >> experiencing
>>>> >>> >> >> >>>this
>>>> >>> >> >> >>> >>>>>or
>>>> >>> >> >> >>> >>>>> >>not.
>>>> >>> >> >> >>> >>>>> >> >> > >>>>
>>>> >>> >> >> >>> >>>>> >> >> > >>>> Anis mentioned Bada also had some
>>>>major
>>>> >>>issues
>>>> >>> >> >> >>>which he
>>>> >>> >> >> >>> >>>>>has
>>>> >>> >> >> >>> >>>>> >>fixed
>>>> >>> >> >> >>> >>>>> >> >> now
>>>> >>> >> >> >>> >>>>> >> >> > >>>>and
>>>> >>> >> >> >>> >>>>> >> >> > >>>> would like in a 1.6.1 release.
>>>> >>> >> >> >>> >>>>> >> >> > >>>>
>>>> >>> >> >> >>> >>>>> >> >> > >>>> Thoughts?
>>>> >>> >> >> >>> >>>>> >> >> > >>>>
>>>> >>> >> >> >>> >>>>> >> >> > >>>> -Steve
>>>> >>> >> >> >>> >>>>> >> >> > >>
>>>> >>> >> >> >>> >>>>> >> >> >
>>>> >>> >> >> >>> >>>>> >> >>
>>>> >>> >> >> >>> >>>>> >>
>>>> >>> >> >> >>> >>>>> >>
>>>> >>> >> >> >>> >>>>>
>>>> >>> >> >> >>> >>>>>
>>>> >>> >> >> >>> >>>
>>>> >>> >> >> >>> >
>>>> >>> >> >> >>>
>>>> >>> >> >>
>>>> >>> >> >>
>>>> >>> >>
>>>> >>>
>>>> >
>>>>
Re: 1.6.1
Posted by Shazron <sh...@gmail.com>.
Reverted. Just talked to Jesse - he has commits to cordova-js coming,
once those are in we can re-tag cordova-js to 1.6.1
On Thu, Apr 12, 2012 at 4:12 PM, Shazron <sh...@gmail.com> wrote:
> I'll remove it. *grabs the shovel*
>
> On Thu, Apr 12, 2012 at 4:10 PM, Joe Bowser <bo...@gmail.com> wrote:
>> You know, let's not rebase it, because it does modify the history. We
>> should remove and document why we did it instead, since that would be more
>> transparent. Or we could just leave it in and say "don't do this next
>> time". I'm not that invested in it.
>>
>> On Thu, Apr 12, 2012 at 4:04 PM, Shazron <sh...@gmail.com> wrote:
>>
>>> If we take out that iOS commit in cordova-js (somehow), it should be
>>> fine. cordova-ios 1.6.1 will then just be the same as 1.6.0.
>>>
>>> On Thu, Apr 12, 2012 at 4:02 PM, Filip Maj <fi...@adobe.com> wrote:
>>> >
>>> >>Is it too much to drop the new commit that changed the common js API, and
>>> >>reapply it after we tag 1.6.1, and figure this one thing out for 1.7?
>>> >
>>> > That sounds very good to me but I am under the impression that iOS
>>> > requires this commit? Like I said I'm quite confused.
>>> >
>>> >>
>>> >>I also have some cordova-js commits to add to 1.6.1? Although nothing
>>> that
>>> >>modifies any js outside of what is built for wp7. ( ie, all in my
>>> platform
>>> >>specific plugins folder )
>>> >>
>>> >
>>> > O then it sounds like I tagged the JS 1.6.1 too early anyways..
>>> >
>>> >>
>>> >>
>>> >>
>>> >>On Thu, Apr 12, 2012 at 3:51 PM, Shazron <sh...@gmail.com> wrote:
>>> >>
>>> >>> No - it's about a user's contribution being noted (it exists), I will
>>> >>> move it out of the common code post-1.6.1 (I acknowledge my mistake in
>>> >>> allowing it in the first place). Can we branch off 1.6.0 then
>>> >>> cherry-pick Fil's latest fix for 1.6.1?
>>> >>>
>>> >>> On Thu, Apr 12, 2012 at 3:47 PM, Joe Bowser <bo...@gmail.com> wrote:
>>> >>> > OK, so you're proposing that we leave the thing in the common JS,
>>> even
>>> >>> > though it's not supposed to be there.
>>> >>> >
>>> >>> > On Thu, Apr 12, 2012 at 3:45 PM, Shazron <sh...@gmail.com> wrote:
>>> >>> >
>>> >>> >> Will rebasing lose that commit? Then, no.
>>> >>> >>
>>> >>> >> On Thu, Apr 12, 2012 at 3:43 PM, Joe Bowser <bo...@gmail.com>
>>> >>>wrote:
>>> >>> >> > So, can we just rebase the head, push this out and get this
>>> >>>rolling?
>>> >>> >> >
>>> >>> >> > On Thu, Apr 12, 2012 at 3:43 PM, Filip Maj <fi...@adobe.com> wrote:
>>> >>> >> >
>>> >>> >> >> Correct, those iOS-specific parameters (like allow edit and those
>>> >>> ones)
>>> >>> >> >> existed prior to cordova-js, so yeah, we left them in there as we
>>> >>> didn't
>>> >>> >> >> want to remove without deprecation.
>>> >>> >> >>
>>> >>> >> >> If you can deal with the iOS issue without needing an API
>>> >>>extension:
>>> >>> >> then
>>> >>> >> >> do that. If not, leave it in there, but docs need to updated too.
>>> >>> >> >>
>>> >>> >> >> Extending and changing the public API is a long and difficult
>>> >>>process
>>> >>> >> for
>>> >>> >> >> us and will only get tougher with every platform we add support
>>> >>>to.
>>> >>> >> >>
>>> >>> >> >> On 4/12/12 3:37 PM, "Shazron" <sh...@gmail.com> wrote:
>>> >>> >> >>
>>> >>> >> >> >Then we have to scrap the other three(?) iOS parameters ones
>>> that
>>> >>> >> >> >already exist in common if you noticed. Don't know how we merge
>>> >>> >> >> >(unmerge?) this one properly because taking those out will break
>>> >>> >> >> >everyone that is using it, but a deprecation is the way to go as
>>> >>>per
>>> >>> >> >> >http://wiki.apache.org/cordova/DeprecationPolicy . We can
>>> remove
>>> >>> this
>>> >>> >> >> >new commit and I'll find a way to get this in somehow.
>>> >>> >> >> >
>>> >>> >> >> >
>>> >>> >> >> >
>>> >>> >> >> >On Thu, Apr 12, 2012 at 3:32 PM, Joe Bowser <bo...@gmail.com>
>>> >>> wrote:
>>> >>> >> >> >> The problem is that this parameter doesn't belong in the
>>> common
>>> >>> API.
>>> >>> >> >> >>It'd
>>> >>> >> >> >> be just ignored in Android, but the whole point of cordova-js
>>> >>>is
>>> >>> so
>>> >>> >> that
>>> >>> >> >> >> it's common. It'd look pretty screwed up to add this to the
>>> >>>docs,
>>> >>> >> IMO.
>>> >>> >> >> >>
>>> >>> >> >> >> On Thu, Apr 12, 2012 at 3:26 PM, Shazron <sh...@gmail.com>
>>> >>> wrote:
>>> >>> >> >> >>
>>> >>> >> >> >>> To fix two bugs for Camera.takePicture on iOS
>>> >>> >> >> >>>
>>> >>> >> >> >>> On Thu, Apr 12, 2012 at 3:24 PM, Filip Maj <fi...@adobe.com>
>>> >>> wrote:
>>> >>> >> >> >>> > so what's the point of this new parameter?
>>> >>> >> >> >>> >
>>> >>> >> >> >>> > On 4/12/12 3:16 PM, "Shazron" <sh...@gmail.com> wrote:
>>> >>> >> >> >>> >
>>> >>> >> >> >>> >>I did. Do we want to revert the cordova-js? I can branch
>>> >>>1.6.0
>>> >>> and
>>> >>> >> >> >>> >>cherry-pick your latest commit for 1.6.1
>>> >>> >> >> >>> >>
>>> >>> >> >> >>> >>On Thu, Apr 12, 2012 at 3:04 PM, Filip Maj <fi...@adobe.com>
>>> >>> wrote:
>>> >>> >> >> >>> >>> I saw something in the iOS commit logs for this.
>>> >>> >> >> >>> >>>
>>> >>> >> >> >>> >>> Shaz can you comment?
>>> >>> >> >> >>> >>>
>>> >>> >> >> >>> >>> On 4/12/12 2:59 PM, "Joe Bowser" <bo...@gmail.com>
>>> >>>wrote:
>>> >>> >> >> >>> >>>
>>> >>> >> >> >>> >>>>Can we revert this, since this looks like it's intended
>>> >>>for
>>> >>> both
>>> >>> >> >> >>> Android
>>> >>> >> >> >>> >>>>and iOS, but I don't think it should be in 1.6.1.
>>> >>> >> >> >>> >>>>
>>> >>> >> >> >>> >>>>On Thu, Apr 12, 2012 at 2:52 PM, Filip Maj <
>>> fil@adobe.com>
>>> >>> >> wrote:
>>> >>> >> >> >>> >>>>
>>> >>> >> >> >>> >>>>> I was actually just looking at that myself.
>>> >>> >> >> >>> >>>>>
>>> >>> >> >> >>> >>>>> Looks like it's an iOS-only param.. sigh. We gotta
>>> stop
>>> >>> doing
>>> >>> >> >> >>>that,
>>> >>> >> >> >>> >>>>> especially if we don't update documentation.
>>> >>> >> >> >>> >>>>>
>>> >>> >> >> >>> >>>>> On 4/12/12 2:49 PM, "Joe Bowser" <bo...@gmail.com>
>>> >>> wrote:
>>> >>> >> >> >>> >>>>>
>>> >>> >> >> >>> >>>>> >Has anyone tested the cropToSize param for
>>> >>> Camera.getPicture
>>> >>> >> >> >>>yet? I
>>> >>> >> >> >>> >>>>> >didn't
>>> >>> >> >> >>> >>>>> >notice that change until now.
>>> >>> >> >> >>> >>>>> >
>>> >>> >> >> >>> >>>>> >On Thu, Apr 12, 2012 at 2:46 PM, Filip Maj
>>> >>><fil@adobe.com
>>> >>> >
>>> >>> >> >> >>>wrote:
>>> >>> >> >> >>> >>>>> >
>>> >>> >> >> >>> >>>>> >> JS tagged 1.6.1 - the build task in the JS should
>>> >>>work
>>> >>> >> >> >>>properly
>>> >>> >> >> >>> >>>>>now.
>>> >>> >> >> >>> >>>>> >>
>>> >>> >> >> >>> >>>>> >> FYI if anyone has to modify the jake tasks in the
>>> >>>future
>>> >>> >> and
>>> >>> >> >> >>>make
>>> >>> >> >> >>> >>>>>them
>>> >>> >> >> >>> >>>>> >> async, make sure you add the 4th "async" parameter
>>> to
>>> >>> the
>>> >>> >> >> >>>task()
>>> >>> >> >> >>> >>>>> >>function
>>> >>> >> >> >>> >>>>> >> and set it to true, and call complete() when the
>>> >>>task is
>>> >>> >> done.
>>> >>> >> >> >>> >>>>> >>
>>> >>> >> >> >>> >>>>> >> See
>>> >>> http://howtonode.org/intro-to-jake/async-jakefile.jsfor
>>> >>> >> >> >>>an
>>> >>> >> >> >>> >>>>> example.
>>> >>> >> >> >>> >>>>> >>
>>> >>> >> >> >>> >>>>> >> On 4/12/12 2:35 PM, "Joe Bowser" <bowserj@gmail.com
>>> >
>>> >>> >> wrote:
>>> >>> >> >> >>> >>>>> >>
>>> >>> >> >> >>> >>>>> >> >Ready to tag once cordova-js is tagged 1.6.1.
>>> >>> >> >> >>> >>>>> >> >
>>> >>> >> >> >>> >>>>> >> >On Thu, Apr 12, 2012 at 2:33 PM, Anis KADRI <
>>> >>> >> >> >>> anis.kadri@gmail.com>
>>> >>> >> >> >>> >>>>> >>wrote:
>>> >>> >> >> >>> >>>>> >> >
>>> >>> >> >> >>> >>>>> >> >> I will tag my repository to 1.6.1 before end of
>>> >>>day
>>> >>> >> today
>>> >>> >> >> >>>after
>>> >>> >> >> >>> >>>>>some
>>> >>> >> >> >>> >>>>> >> >> thorough testing.
>>> >>> >> >> >>> >>>>> >> >>
>>> >>> >> >> >>> >>>>> >> >> On Thu, Apr 12, 2012 at 2:30 PM, Shazron
>>> >>> >> >> >>><sh...@gmail.com>
>>> >>> >> >> >>> >>>>>wrote:
>>> >>> >> >> >>> >>>>> >> >>
>>> >>> >> >> >>> >>>>> >> >> > I also created a 1.6.1 version tag as well in
>>> >>> jira...
>>> >>> >> >> >>> >>>>> >> >> >
>>> >>> >> >> >>> >>>>> >> >> > On Thu, Apr 12, 2012 at 2:29 PM, Shazron
>>> >>> >> >> >>><sh...@gmail.com>
>>> >>> >> >> >>> >>>>> wrote:
>>> >>> >> >> >>> >>>>> >> >> > > Alright guys since 1.6.0 was released, I'm
>>> >>>going
>>> >>> to
>>> >>> >> >> >>> >>>>>"Release"
>>> >>> >> >> >>> >>>>>the
>>> >>> >> >> >>> >>>>> >> >> > > 1.6.0 version in jira and move outstanding
>>> >>> issues to
>>> >>> >> >> >>>1.7.0
>>> >>> >> >> >>> >>>>> >>version
>>> >>> >> >> >>> >>>>> >> >> > > tag.
>>> >>> >> >> >>> >>>>> >> >> > >
>>> >>> >> >> >>> >>>>> >> >> > >
>>> >>> >> >> >>> >>>>> >> >> > > On Thu, Apr 12, 2012 at 2:26 PM, Filip Maj
>>> >>> >> >> >>><fi...@adobe.com>
>>> >>> >> >> >>> >>>>> wrote:
>>> >>> >> >> >>> >>>>> >> >> > >> The JS needs patching too. Since adding the
>>> >>> commit
>>> >>> >> ID
>>> >>> >> >> >>>into
>>> >>> >> >> >>> >>>>>the
>>> >>> >> >> >>> >>>>> >> >> packaging
>>> >>> >> >> >>> >>>>> >> >> > >> in the jakefile, the default task isn't
>>> >>>running
>>> >>> >> >> >>>properly.
>>> >>> >> >> >>> >>>>> >> >> > >>
>>> >>> >> >> >>> >>>>> >> >> > >> You can manually run "jake build" and "jake
>>> >>> test"
>>> >>> >> but
>>> >>> >> >> >>>not
>>> >>> >> >> >>> >>>>> >>"jake" on
>>> >>> >> >> >>> >>>>> >> >> its
>>> >>> >> >> >>> >>>>> >> >> > >> own - gonna try to figure it out.
>>> >>> >> >> >>> >>>>> >> >> > >>
>>> >>> >> >> >>> >>>>> >> >> > >> On 4/12/12 2:21 PM, "Shazron" <
>>> >>> shazron@gmail.com>
>>> >>> >> >> >>>wrote:
>>> >>> >> >> >>> >>>>> >> >> > >>
>>> >>> >> >> >>> >>>>> >> >> > >>>I'm good with tagging. iOS has a few
>>> commits
>>> >>> (one
>>> >>> >> >> >>>commit
>>> >>> >> >> >>> >>>>>in
>>> >>> >> >> >>> >>>>> >> >> > >>>cordova-js) as well. Aim for first thing
>>> >>> tomorrow
>>> >>> >> for
>>> >>> >> >> >>>you
>>> >>> >> >> >>> >>>>>to
>>> >>> >> >> >>> >>>>> >> >> > >>>repackage?
>>> >>> >> >> >>> >>>>> >> >> > >>>
>>> >>> >> >> >>> >>>>> >> >> > >>>On Thu, Apr 12, 2012 at 2:17 PM, Steven Gill
>>> >>> >> >> >>> >>>>> >> >><st...@gmail.com>
>>> >>> >> >> >>> >>>>> >> >> > >>>wrote:
>>> >>> >> >> >>> >>>>> >> >> > >>>> So a bug has been discovered in Cordova
>>> >>> Android
>>> >>> >> that
>>> >>> >> >> >>> >>>>>requires
>>> >>> >> >> >>> >>>>> >>a
>>> >>> >> >> >>> >>>>> >> >>new
>>> >>> >> >> >>> >>>>> >> >> > tag
>>> >>> >> >> >>> >>>>> >> >> > >>>>and
>>> >>> >> >> >>> >>>>> >> >> > >>>> release. You can check out the bug on the
>>> >>> issue
>>> >>> >> >> >>>tracker
>>> >>> >> >> >>> >>>>>at
>>> >>> >> >> >>> >>>>> >> >> > >>>>
>>> >>> >> >> >>> >>>>> >> >> > >>>>
>>> >>> >> >> >>> >>>>> >> >> >
>>> >>> >> >> >>> >>>>> >> >>
>>> >>> >> >> >>> >>>>> >> >>
>>> >>> >> >> >>> >>>>> >>
>>> >>> >> >> >>> >>>>> >>
>>> >>> >> >> >>> >>>>>
>>> >>> >> >> >>> >>>>>
>>> >>> >> >> >>>
>>> >>> >> >>
>>> >>>
>>> https://issues.apache.org/jira/browse/CB-490?focusedCommentId=13252809#
>>> >>> >> >> >>> >>>>>co
>>> >>> >> >> >>> >>>>> >> >> > >>>>mment-13252809
>>> >>> >> >> >>> >>>>> >> >> > >>>>
>>> >>> >> >> >>> >>>>> >> >> > >>>> It doesn't make sense to just repackage
>>> >>>1.6.0
>>> >>> >> with
>>> >>> >> >> >>>this
>>> >>> >> >> >>> >>>>>bug
>>> >>> >> >> >>> >>>>> >> >>fixed as
>>> >>> >> >> >>> >>>>> >> >> > we
>>> >>> >> >> >>> >>>>> >> >> > >>>> will have no way to know if people are
>>> >>> >> experiencing
>>> >>> >> >> >>>this
>>> >>> >> >> >>> >>>>>or
>>> >>> >> >> >>> >>>>> >>not.
>>> >>> >> >> >>> >>>>> >> >> > >>>>
>>> >>> >> >> >>> >>>>> >> >> > >>>> Anis mentioned Bada also had some major
>>> >>>issues
>>> >>> >> >> >>>which he
>>> >>> >> >> >>> >>>>>has
>>> >>> >> >> >>> >>>>> >>fixed
>>> >>> >> >> >>> >>>>> >> >> now
>>> >>> >> >> >>> >>>>> >> >> > >>>>and
>>> >>> >> >> >>> >>>>> >> >> > >>>> would like in a 1.6.1 release.
>>> >>> >> >> >>> >>>>> >> >> > >>>>
>>> >>> >> >> >>> >>>>> >> >> > >>>> Thoughts?
>>> >>> >> >> >>> >>>>> >> >> > >>>>
>>> >>> >> >> >>> >>>>> >> >> > >>>> -Steve
>>> >>> >> >> >>> >>>>> >> >> > >>
>>> >>> >> >> >>> >>>>> >> >> >
>>> >>> >> >> >>> >>>>> >> >>
>>> >>> >> >> >>> >>>>> >>
>>> >>> >> >> >>> >>>>> >>
>>> >>> >> >> >>> >>>>>
>>> >>> >> >> >>> >>>>>
>>> >>> >> >> >>> >>>
>>> >>> >> >> >>> >
>>> >>> >> >> >>>
>>> >>> >> >>
>>> >>> >> >>
>>> >>> >>
>>> >>>
>>> >
>>>
Re: 1.6.1
Posted by Shazron <sh...@gmail.com>.
I'll remove it. *grabs the shovel*
On Thu, Apr 12, 2012 at 4:10 PM, Joe Bowser <bo...@gmail.com> wrote:
> You know, let's not rebase it, because it does modify the history. We
> should remove and document why we did it instead, since that would be more
> transparent. Or we could just leave it in and say "don't do this next
> time". I'm not that invested in it.
>
> On Thu, Apr 12, 2012 at 4:04 PM, Shazron <sh...@gmail.com> wrote:
>
>> If we take out that iOS commit in cordova-js (somehow), it should be
>> fine. cordova-ios 1.6.1 will then just be the same as 1.6.0.
>>
>> On Thu, Apr 12, 2012 at 4:02 PM, Filip Maj <fi...@adobe.com> wrote:
>> >
>> >>Is it too much to drop the new commit that changed the common js API, and
>> >>reapply it after we tag 1.6.1, and figure this one thing out for 1.7?
>> >
>> > That sounds very good to me but I am under the impression that iOS
>> > requires this commit? Like I said I'm quite confused.
>> >
>> >>
>> >>I also have some cordova-js commits to add to 1.6.1? Although nothing
>> that
>> >>modifies any js outside of what is built for wp7. ( ie, all in my
>> platform
>> >>specific plugins folder )
>> >>
>> >
>> > O then it sounds like I tagged the JS 1.6.1 too early anyways..
>> >
>> >>
>> >>
>> >>
>> >>On Thu, Apr 12, 2012 at 3:51 PM, Shazron <sh...@gmail.com> wrote:
>> >>
>> >>> No - it's about a user's contribution being noted (it exists), I will
>> >>> move it out of the common code post-1.6.1 (I acknowledge my mistake in
>> >>> allowing it in the first place). Can we branch off 1.6.0 then
>> >>> cherry-pick Fil's latest fix for 1.6.1?
>> >>>
>> >>> On Thu, Apr 12, 2012 at 3:47 PM, Joe Bowser <bo...@gmail.com> wrote:
>> >>> > OK, so you're proposing that we leave the thing in the common JS,
>> even
>> >>> > though it's not supposed to be there.
>> >>> >
>> >>> > On Thu, Apr 12, 2012 at 3:45 PM, Shazron <sh...@gmail.com> wrote:
>> >>> >
>> >>> >> Will rebasing lose that commit? Then, no.
>> >>> >>
>> >>> >> On Thu, Apr 12, 2012 at 3:43 PM, Joe Bowser <bo...@gmail.com>
>> >>>wrote:
>> >>> >> > So, can we just rebase the head, push this out and get this
>> >>>rolling?
>> >>> >> >
>> >>> >> > On Thu, Apr 12, 2012 at 3:43 PM, Filip Maj <fi...@adobe.com> wrote:
>> >>> >> >
>> >>> >> >> Correct, those iOS-specific parameters (like allow edit and those
>> >>> ones)
>> >>> >> >> existed prior to cordova-js, so yeah, we left them in there as we
>> >>> didn't
>> >>> >> >> want to remove without deprecation.
>> >>> >> >>
>> >>> >> >> If you can deal with the iOS issue without needing an API
>> >>>extension:
>> >>> >> then
>> >>> >> >> do that. If not, leave it in there, but docs need to updated too.
>> >>> >> >>
>> >>> >> >> Extending and changing the public API is a long and difficult
>> >>>process
>> >>> >> for
>> >>> >> >> us and will only get tougher with every platform we add support
>> >>>to.
>> >>> >> >>
>> >>> >> >> On 4/12/12 3:37 PM, "Shazron" <sh...@gmail.com> wrote:
>> >>> >> >>
>> >>> >> >> >Then we have to scrap the other three(?) iOS parameters ones
>> that
>> >>> >> >> >already exist in common if you noticed. Don't know how we merge
>> >>> >> >> >(unmerge?) this one properly because taking those out will break
>> >>> >> >> >everyone that is using it, but a deprecation is the way to go as
>> >>>per
>> >>> >> >> >http://wiki.apache.org/cordova/DeprecationPolicy . We can
>> remove
>> >>> this
>> >>> >> >> >new commit and I'll find a way to get this in somehow.
>> >>> >> >> >
>> >>> >> >> >
>> >>> >> >> >
>> >>> >> >> >On Thu, Apr 12, 2012 at 3:32 PM, Joe Bowser <bo...@gmail.com>
>> >>> wrote:
>> >>> >> >> >> The problem is that this parameter doesn't belong in the
>> common
>> >>> API.
>> >>> >> >> >>It'd
>> >>> >> >> >> be just ignored in Android, but the whole point of cordova-js
>> >>>is
>> >>> so
>> >>> >> that
>> >>> >> >> >> it's common. It'd look pretty screwed up to add this to the
>> >>>docs,
>> >>> >> IMO.
>> >>> >> >> >>
>> >>> >> >> >> On Thu, Apr 12, 2012 at 3:26 PM, Shazron <sh...@gmail.com>
>> >>> wrote:
>> >>> >> >> >>
>> >>> >> >> >>> To fix two bugs for Camera.takePicture on iOS
>> >>> >> >> >>>
>> >>> >> >> >>> On Thu, Apr 12, 2012 at 3:24 PM, Filip Maj <fi...@adobe.com>
>> >>> wrote:
>> >>> >> >> >>> > so what's the point of this new parameter?
>> >>> >> >> >>> >
>> >>> >> >> >>> > On 4/12/12 3:16 PM, "Shazron" <sh...@gmail.com> wrote:
>> >>> >> >> >>> >
>> >>> >> >> >>> >>I did. Do we want to revert the cordova-js? I can branch
>> >>>1.6.0
>> >>> and
>> >>> >> >> >>> >>cherry-pick your latest commit for 1.6.1
>> >>> >> >> >>> >>
>> >>> >> >> >>> >>On Thu, Apr 12, 2012 at 3:04 PM, Filip Maj <fi...@adobe.com>
>> >>> wrote:
>> >>> >> >> >>> >>> I saw something in the iOS commit logs for this.
>> >>> >> >> >>> >>>
>> >>> >> >> >>> >>> Shaz can you comment?
>> >>> >> >> >>> >>>
>> >>> >> >> >>> >>> On 4/12/12 2:59 PM, "Joe Bowser" <bo...@gmail.com>
>> >>>wrote:
>> >>> >> >> >>> >>>
>> >>> >> >> >>> >>>>Can we revert this, since this looks like it's intended
>> >>>for
>> >>> both
>> >>> >> >> >>> Android
>> >>> >> >> >>> >>>>and iOS, but I don't think it should be in 1.6.1.
>> >>> >> >> >>> >>>>
>> >>> >> >> >>> >>>>On Thu, Apr 12, 2012 at 2:52 PM, Filip Maj <
>> fil@adobe.com>
>> >>> >> wrote:
>> >>> >> >> >>> >>>>
>> >>> >> >> >>> >>>>> I was actually just looking at that myself.
>> >>> >> >> >>> >>>>>
>> >>> >> >> >>> >>>>> Looks like it's an iOS-only param.. sigh. We gotta
>> stop
>> >>> doing
>> >>> >> >> >>>that,
>> >>> >> >> >>> >>>>> especially if we don't update documentation.
>> >>> >> >> >>> >>>>>
>> >>> >> >> >>> >>>>> On 4/12/12 2:49 PM, "Joe Bowser" <bo...@gmail.com>
>> >>> wrote:
>> >>> >> >> >>> >>>>>
>> >>> >> >> >>> >>>>> >Has anyone tested the cropToSize param for
>> >>> Camera.getPicture
>> >>> >> >> >>>yet? I
>> >>> >> >> >>> >>>>> >didn't
>> >>> >> >> >>> >>>>> >notice that change until now.
>> >>> >> >> >>> >>>>> >
>> >>> >> >> >>> >>>>> >On Thu, Apr 12, 2012 at 2:46 PM, Filip Maj
>> >>><fil@adobe.com
>> >>> >
>> >>> >> >> >>>wrote:
>> >>> >> >> >>> >>>>> >
>> >>> >> >> >>> >>>>> >> JS tagged 1.6.1 - the build task in the JS should
>> >>>work
>> >>> >> >> >>>properly
>> >>> >> >> >>> >>>>>now.
>> >>> >> >> >>> >>>>> >>
>> >>> >> >> >>> >>>>> >> FYI if anyone has to modify the jake tasks in the
>> >>>future
>> >>> >> and
>> >>> >> >> >>>make
>> >>> >> >> >>> >>>>>them
>> >>> >> >> >>> >>>>> >> async, make sure you add the 4th "async" parameter
>> to
>> >>> the
>> >>> >> >> >>>task()
>> >>> >> >> >>> >>>>> >>function
>> >>> >> >> >>> >>>>> >> and set it to true, and call complete() when the
>> >>>task is
>> >>> >> done.
>> >>> >> >> >>> >>>>> >>
>> >>> >> >> >>> >>>>> >> See
>> >>> http://howtonode.org/intro-to-jake/async-jakefile.jsfor
>> >>> >> >> >>>an
>> >>> >> >> >>> >>>>> example.
>> >>> >> >> >>> >>>>> >>
>> >>> >> >> >>> >>>>> >> On 4/12/12 2:35 PM, "Joe Bowser" <bowserj@gmail.com
>> >
>> >>> >> wrote:
>> >>> >> >> >>> >>>>> >>
>> >>> >> >> >>> >>>>> >> >Ready to tag once cordova-js is tagged 1.6.1.
>> >>> >> >> >>> >>>>> >> >
>> >>> >> >> >>> >>>>> >> >On Thu, Apr 12, 2012 at 2:33 PM, Anis KADRI <
>> >>> >> >> >>> anis.kadri@gmail.com>
>> >>> >> >> >>> >>>>> >>wrote:
>> >>> >> >> >>> >>>>> >> >
>> >>> >> >> >>> >>>>> >> >> I will tag my repository to 1.6.1 before end of
>> >>>day
>> >>> >> today
>> >>> >> >> >>>after
>> >>> >> >> >>> >>>>>some
>> >>> >> >> >>> >>>>> >> >> thorough testing.
>> >>> >> >> >>> >>>>> >> >>
>> >>> >> >> >>> >>>>> >> >> On Thu, Apr 12, 2012 at 2:30 PM, Shazron
>> >>> >> >> >>><sh...@gmail.com>
>> >>> >> >> >>> >>>>>wrote:
>> >>> >> >> >>> >>>>> >> >>
>> >>> >> >> >>> >>>>> >> >> > I also created a 1.6.1 version tag as well in
>> >>> jira...
>> >>> >> >> >>> >>>>> >> >> >
>> >>> >> >> >>> >>>>> >> >> > On Thu, Apr 12, 2012 at 2:29 PM, Shazron
>> >>> >> >> >>><sh...@gmail.com>
>> >>> >> >> >>> >>>>> wrote:
>> >>> >> >> >>> >>>>> >> >> > > Alright guys since 1.6.0 was released, I'm
>> >>>going
>> >>> to
>> >>> >> >> >>> >>>>>"Release"
>> >>> >> >> >>> >>>>>the
>> >>> >> >> >>> >>>>> >> >> > > 1.6.0 version in jira and move outstanding
>> >>> issues to
>> >>> >> >> >>>1.7.0
>> >>> >> >> >>> >>>>> >>version
>> >>> >> >> >>> >>>>> >> >> > > tag.
>> >>> >> >> >>> >>>>> >> >> > >
>> >>> >> >> >>> >>>>> >> >> > >
>> >>> >> >> >>> >>>>> >> >> > > On Thu, Apr 12, 2012 at 2:26 PM, Filip Maj
>> >>> >> >> >>><fi...@adobe.com>
>> >>> >> >> >>> >>>>> wrote:
>> >>> >> >> >>> >>>>> >> >> > >> The JS needs patching too. Since adding the
>> >>> commit
>> >>> >> ID
>> >>> >> >> >>>into
>> >>> >> >> >>> >>>>>the
>> >>> >> >> >>> >>>>> >> >> packaging
>> >>> >> >> >>> >>>>> >> >> > >> in the jakefile, the default task isn't
>> >>>running
>> >>> >> >> >>>properly.
>> >>> >> >> >>> >>>>> >> >> > >>
>> >>> >> >> >>> >>>>> >> >> > >> You can manually run "jake build" and "jake
>> >>> test"
>> >>> >> but
>> >>> >> >> >>>not
>> >>> >> >> >>> >>>>> >>"jake" on
>> >>> >> >> >>> >>>>> >> >> its
>> >>> >> >> >>> >>>>> >> >> > >> own - gonna try to figure it out.
>> >>> >> >> >>> >>>>> >> >> > >>
>> >>> >> >> >>> >>>>> >> >> > >> On 4/12/12 2:21 PM, "Shazron" <
>> >>> shazron@gmail.com>
>> >>> >> >> >>>wrote:
>> >>> >> >> >>> >>>>> >> >> > >>
>> >>> >> >> >>> >>>>> >> >> > >>>I'm good with tagging. iOS has a few
>> commits
>> >>> (one
>> >>> >> >> >>>commit
>> >>> >> >> >>> >>>>>in
>> >>> >> >> >>> >>>>> >> >> > >>>cordova-js) as well. Aim for first thing
>> >>> tomorrow
>> >>> >> for
>> >>> >> >> >>>you
>> >>> >> >> >>> >>>>>to
>> >>> >> >> >>> >>>>> >> >> > >>>repackage?
>> >>> >> >> >>> >>>>> >> >> > >>>
>> >>> >> >> >>> >>>>> >> >> > >>>On Thu, Apr 12, 2012 at 2:17 PM, Steven Gill
>> >>> >> >> >>> >>>>> >> >><st...@gmail.com>
>> >>> >> >> >>> >>>>> >> >> > >>>wrote:
>> >>> >> >> >>> >>>>> >> >> > >>>> So a bug has been discovered in Cordova
>> >>> Android
>> >>> >> that
>> >>> >> >> >>> >>>>>requires
>> >>> >> >> >>> >>>>> >>a
>> >>> >> >> >>> >>>>> >> >>new
>> >>> >> >> >>> >>>>> >> >> > tag
>> >>> >> >> >>> >>>>> >> >> > >>>>and
>> >>> >> >> >>> >>>>> >> >> > >>>> release. You can check out the bug on the
>> >>> issue
>> >>> >> >> >>>tracker
>> >>> >> >> >>> >>>>>at
>> >>> >> >> >>> >>>>> >> >> > >>>>
>> >>> >> >> >>> >>>>> >> >> > >>>>
>> >>> >> >> >>> >>>>> >> >> >
>> >>> >> >> >>> >>>>> >> >>
>> >>> >> >> >>> >>>>> >> >>
>> >>> >> >> >>> >>>>> >>
>> >>> >> >> >>> >>>>> >>
>> >>> >> >> >>> >>>>>
>> >>> >> >> >>> >>>>>
>> >>> >> >> >>>
>> >>> >> >>
>> >>>
>> https://issues.apache.org/jira/browse/CB-490?focusedCommentId=13252809#
>> >>> >> >> >>> >>>>>co
>> >>> >> >> >>> >>>>> >> >> > >>>>mment-13252809
>> >>> >> >> >>> >>>>> >> >> > >>>>
>> >>> >> >> >>> >>>>> >> >> > >>>> It doesn't make sense to just repackage
>> >>>1.6.0
>> >>> >> with
>> >>> >> >> >>>this
>> >>> >> >> >>> >>>>>bug
>> >>> >> >> >>> >>>>> >> >>fixed as
>> >>> >> >> >>> >>>>> >> >> > we
>> >>> >> >> >>> >>>>> >> >> > >>>> will have no way to know if people are
>> >>> >> experiencing
>> >>> >> >> >>>this
>> >>> >> >> >>> >>>>>or
>> >>> >> >> >>> >>>>> >>not.
>> >>> >> >> >>> >>>>> >> >> > >>>>
>> >>> >> >> >>> >>>>> >> >> > >>>> Anis mentioned Bada also had some major
>> >>>issues
>> >>> >> >> >>>which he
>> >>> >> >> >>> >>>>>has
>> >>> >> >> >>> >>>>> >>fixed
>> >>> >> >> >>> >>>>> >> >> now
>> >>> >> >> >>> >>>>> >> >> > >>>>and
>> >>> >> >> >>> >>>>> >> >> > >>>> would like in a 1.6.1 release.
>> >>> >> >> >>> >>>>> >> >> > >>>>
>> >>> >> >> >>> >>>>> >> >> > >>>> Thoughts?
>> >>> >> >> >>> >>>>> >> >> > >>>>
>> >>> >> >> >>> >>>>> >> >> > >>>> -Steve
>> >>> >> >> >>> >>>>> >> >> > >>
>> >>> >> >> >>> >>>>> >> >> >
>> >>> >> >> >>> >>>>> >> >>
>> >>> >> >> >>> >>>>> >>
>> >>> >> >> >>> >>>>> >>
>> >>> >> >> >>> >>>>>
>> >>> >> >> >>> >>>>>
>> >>> >> >> >>> >>>
>> >>> >> >> >>> >
>> >>> >> >> >>>
>> >>> >> >>
>> >>> >> >>
>> >>> >>
>> >>>
>> >
>>
Re: 1.6.1
Posted by Joe Bowser <bo...@gmail.com>.
You know, let's not rebase it, because it does modify the history. We
should remove and document why we did it instead, since that would be more
transparent. Or we could just leave it in and say "don't do this next
time". I'm not that invested in it.
On Thu, Apr 12, 2012 at 4:04 PM, Shazron <sh...@gmail.com> wrote:
> If we take out that iOS commit in cordova-js (somehow), it should be
> fine. cordova-ios 1.6.1 will then just be the same as 1.6.0.
>
> On Thu, Apr 12, 2012 at 4:02 PM, Filip Maj <fi...@adobe.com> wrote:
> >
> >>Is it too much to drop the new commit that changed the common js API, and
> >>reapply it after we tag 1.6.1, and figure this one thing out for 1.7?
> >
> > That sounds very good to me but I am under the impression that iOS
> > requires this commit? Like I said I'm quite confused.
> >
> >>
> >>I also have some cordova-js commits to add to 1.6.1? Although nothing
> that
> >>modifies any js outside of what is built for wp7. ( ie, all in my
> platform
> >>specific plugins folder )
> >>
> >
> > O then it sounds like I tagged the JS 1.6.1 too early anyways..
> >
> >>
> >>
> >>
> >>On Thu, Apr 12, 2012 at 3:51 PM, Shazron <sh...@gmail.com> wrote:
> >>
> >>> No - it's about a user's contribution being noted (it exists), I will
> >>> move it out of the common code post-1.6.1 (I acknowledge my mistake in
> >>> allowing it in the first place). Can we branch off 1.6.0 then
> >>> cherry-pick Fil's latest fix for 1.6.1?
> >>>
> >>> On Thu, Apr 12, 2012 at 3:47 PM, Joe Bowser <bo...@gmail.com> wrote:
> >>> > OK, so you're proposing that we leave the thing in the common JS,
> even
> >>> > though it's not supposed to be there.
> >>> >
> >>> > On Thu, Apr 12, 2012 at 3:45 PM, Shazron <sh...@gmail.com> wrote:
> >>> >
> >>> >> Will rebasing lose that commit? Then, no.
> >>> >>
> >>> >> On Thu, Apr 12, 2012 at 3:43 PM, Joe Bowser <bo...@gmail.com>
> >>>wrote:
> >>> >> > So, can we just rebase the head, push this out and get this
> >>>rolling?
> >>> >> >
> >>> >> > On Thu, Apr 12, 2012 at 3:43 PM, Filip Maj <fi...@adobe.com> wrote:
> >>> >> >
> >>> >> >> Correct, those iOS-specific parameters (like allow edit and those
> >>> ones)
> >>> >> >> existed prior to cordova-js, so yeah, we left them in there as we
> >>> didn't
> >>> >> >> want to remove without deprecation.
> >>> >> >>
> >>> >> >> If you can deal with the iOS issue without needing an API
> >>>extension:
> >>> >> then
> >>> >> >> do that. If not, leave it in there, but docs need to updated too.
> >>> >> >>
> >>> >> >> Extending and changing the public API is a long and difficult
> >>>process
> >>> >> for
> >>> >> >> us and will only get tougher with every platform we add support
> >>>to.
> >>> >> >>
> >>> >> >> On 4/12/12 3:37 PM, "Shazron" <sh...@gmail.com> wrote:
> >>> >> >>
> >>> >> >> >Then we have to scrap the other three(?) iOS parameters ones
> that
> >>> >> >> >already exist in common if you noticed. Don't know how we merge
> >>> >> >> >(unmerge?) this one properly because taking those out will break
> >>> >> >> >everyone that is using it, but a deprecation is the way to go as
> >>>per
> >>> >> >> >http://wiki.apache.org/cordova/DeprecationPolicy . We can
> remove
> >>> this
> >>> >> >> >new commit and I'll find a way to get this in somehow.
> >>> >> >> >
> >>> >> >> >
> >>> >> >> >
> >>> >> >> >On Thu, Apr 12, 2012 at 3:32 PM, Joe Bowser <bo...@gmail.com>
> >>> wrote:
> >>> >> >> >> The problem is that this parameter doesn't belong in the
> common
> >>> API.
> >>> >> >> >>It'd
> >>> >> >> >> be just ignored in Android, but the whole point of cordova-js
> >>>is
> >>> so
> >>> >> that
> >>> >> >> >> it's common. It'd look pretty screwed up to add this to the
> >>>docs,
> >>> >> IMO.
> >>> >> >> >>
> >>> >> >> >> On Thu, Apr 12, 2012 at 3:26 PM, Shazron <sh...@gmail.com>
> >>> wrote:
> >>> >> >> >>
> >>> >> >> >>> To fix two bugs for Camera.takePicture on iOS
> >>> >> >> >>>
> >>> >> >> >>> On Thu, Apr 12, 2012 at 3:24 PM, Filip Maj <fi...@adobe.com>
> >>> wrote:
> >>> >> >> >>> > so what's the point of this new parameter?
> >>> >> >> >>> >
> >>> >> >> >>> > On 4/12/12 3:16 PM, "Shazron" <sh...@gmail.com> wrote:
> >>> >> >> >>> >
> >>> >> >> >>> >>I did. Do we want to revert the cordova-js? I can branch
> >>>1.6.0
> >>> and
> >>> >> >> >>> >>cherry-pick your latest commit for 1.6.1
> >>> >> >> >>> >>
> >>> >> >> >>> >>On Thu, Apr 12, 2012 at 3:04 PM, Filip Maj <fi...@adobe.com>
> >>> wrote:
> >>> >> >> >>> >>> I saw something in the iOS commit logs for this.
> >>> >> >> >>> >>>
> >>> >> >> >>> >>> Shaz can you comment?
> >>> >> >> >>> >>>
> >>> >> >> >>> >>> On 4/12/12 2:59 PM, "Joe Bowser" <bo...@gmail.com>
> >>>wrote:
> >>> >> >> >>> >>>
> >>> >> >> >>> >>>>Can we revert this, since this looks like it's intended
> >>>for
> >>> both
> >>> >> >> >>> Android
> >>> >> >> >>> >>>>and iOS, but I don't think it should be in 1.6.1.
> >>> >> >> >>> >>>>
> >>> >> >> >>> >>>>On Thu, Apr 12, 2012 at 2:52 PM, Filip Maj <
> fil@adobe.com>
> >>> >> wrote:
> >>> >> >> >>> >>>>
> >>> >> >> >>> >>>>> I was actually just looking at that myself.
> >>> >> >> >>> >>>>>
> >>> >> >> >>> >>>>> Looks like it's an iOS-only param.. sigh. We gotta
> stop
> >>> doing
> >>> >> >> >>>that,
> >>> >> >> >>> >>>>> especially if we don't update documentation.
> >>> >> >> >>> >>>>>
> >>> >> >> >>> >>>>> On 4/12/12 2:49 PM, "Joe Bowser" <bo...@gmail.com>
> >>> wrote:
> >>> >> >> >>> >>>>>
> >>> >> >> >>> >>>>> >Has anyone tested the cropToSize param for
> >>> Camera.getPicture
> >>> >> >> >>>yet? I
> >>> >> >> >>> >>>>> >didn't
> >>> >> >> >>> >>>>> >notice that change until now.
> >>> >> >> >>> >>>>> >
> >>> >> >> >>> >>>>> >On Thu, Apr 12, 2012 at 2:46 PM, Filip Maj
> >>><fil@adobe.com
> >>> >
> >>> >> >> >>>wrote:
> >>> >> >> >>> >>>>> >
> >>> >> >> >>> >>>>> >> JS tagged 1.6.1 - the build task in the JS should
> >>>work
> >>> >> >> >>>properly
> >>> >> >> >>> >>>>>now.
> >>> >> >> >>> >>>>> >>
> >>> >> >> >>> >>>>> >> FYI if anyone has to modify the jake tasks in the
> >>>future
> >>> >> and
> >>> >> >> >>>make
> >>> >> >> >>> >>>>>them
> >>> >> >> >>> >>>>> >> async, make sure you add the 4th "async" parameter
> to
> >>> the
> >>> >> >> >>>task()
> >>> >> >> >>> >>>>> >>function
> >>> >> >> >>> >>>>> >> and set it to true, and call complete() when the
> >>>task is
> >>> >> done.
> >>> >> >> >>> >>>>> >>
> >>> >> >> >>> >>>>> >> See
> >>> http://howtonode.org/intro-to-jake/async-jakefile.jsfor
> >>> >> >> >>>an
> >>> >> >> >>> >>>>> example.
> >>> >> >> >>> >>>>> >>
> >>> >> >> >>> >>>>> >> On 4/12/12 2:35 PM, "Joe Bowser" <bowserj@gmail.com
> >
> >>> >> wrote:
> >>> >> >> >>> >>>>> >>
> >>> >> >> >>> >>>>> >> >Ready to tag once cordova-js is tagged 1.6.1.
> >>> >> >> >>> >>>>> >> >
> >>> >> >> >>> >>>>> >> >On Thu, Apr 12, 2012 at 2:33 PM, Anis KADRI <
> >>> >> >> >>> anis.kadri@gmail.com>
> >>> >> >> >>> >>>>> >>wrote:
> >>> >> >> >>> >>>>> >> >
> >>> >> >> >>> >>>>> >> >> I will tag my repository to 1.6.1 before end of
> >>>day
> >>> >> today
> >>> >> >> >>>after
> >>> >> >> >>> >>>>>some
> >>> >> >> >>> >>>>> >> >> thorough testing.
> >>> >> >> >>> >>>>> >> >>
> >>> >> >> >>> >>>>> >> >> On Thu, Apr 12, 2012 at 2:30 PM, Shazron
> >>> >> >> >>><sh...@gmail.com>
> >>> >> >> >>> >>>>>wrote:
> >>> >> >> >>> >>>>> >> >>
> >>> >> >> >>> >>>>> >> >> > I also created a 1.6.1 version tag as well in
> >>> jira...
> >>> >> >> >>> >>>>> >> >> >
> >>> >> >> >>> >>>>> >> >> > On Thu, Apr 12, 2012 at 2:29 PM, Shazron
> >>> >> >> >>><sh...@gmail.com>
> >>> >> >> >>> >>>>> wrote:
> >>> >> >> >>> >>>>> >> >> > > Alright guys since 1.6.0 was released, I'm
> >>>going
> >>> to
> >>> >> >> >>> >>>>>"Release"
> >>> >> >> >>> >>>>>the
> >>> >> >> >>> >>>>> >> >> > > 1.6.0 version in jira and move outstanding
> >>> issues to
> >>> >> >> >>>1.7.0
> >>> >> >> >>> >>>>> >>version
> >>> >> >> >>> >>>>> >> >> > > tag.
> >>> >> >> >>> >>>>> >> >> > >
> >>> >> >> >>> >>>>> >> >> > >
> >>> >> >> >>> >>>>> >> >> > > On Thu, Apr 12, 2012 at 2:26 PM, Filip Maj
> >>> >> >> >>><fi...@adobe.com>
> >>> >> >> >>> >>>>> wrote:
> >>> >> >> >>> >>>>> >> >> > >> The JS needs patching too. Since adding the
> >>> commit
> >>> >> ID
> >>> >> >> >>>into
> >>> >> >> >>> >>>>>the
> >>> >> >> >>> >>>>> >> >> packaging
> >>> >> >> >>> >>>>> >> >> > >> in the jakefile, the default task isn't
> >>>running
> >>> >> >> >>>properly.
> >>> >> >> >>> >>>>> >> >> > >>
> >>> >> >> >>> >>>>> >> >> > >> You can manually run "jake build" and "jake
> >>> test"
> >>> >> but
> >>> >> >> >>>not
> >>> >> >> >>> >>>>> >>"jake" on
> >>> >> >> >>> >>>>> >> >> its
> >>> >> >> >>> >>>>> >> >> > >> own - gonna try to figure it out.
> >>> >> >> >>> >>>>> >> >> > >>
> >>> >> >> >>> >>>>> >> >> > >> On 4/12/12 2:21 PM, "Shazron" <
> >>> shazron@gmail.com>
> >>> >> >> >>>wrote:
> >>> >> >> >>> >>>>> >> >> > >>
> >>> >> >> >>> >>>>> >> >> > >>>I'm good with tagging. iOS has a few
> commits
> >>> (one
> >>> >> >> >>>commit
> >>> >> >> >>> >>>>>in
> >>> >> >> >>> >>>>> >> >> > >>>cordova-js) as well. Aim for first thing
> >>> tomorrow
> >>> >> for
> >>> >> >> >>>you
> >>> >> >> >>> >>>>>to
> >>> >> >> >>> >>>>> >> >> > >>>repackage?
> >>> >> >> >>> >>>>> >> >> > >>>
> >>> >> >> >>> >>>>> >> >> > >>>On Thu, Apr 12, 2012 at 2:17 PM, Steven Gill
> >>> >> >> >>> >>>>> >> >><st...@gmail.com>
> >>> >> >> >>> >>>>> >> >> > >>>wrote:
> >>> >> >> >>> >>>>> >> >> > >>>> So a bug has been discovered in Cordova
> >>> Android
> >>> >> that
> >>> >> >> >>> >>>>>requires
> >>> >> >> >>> >>>>> >>a
> >>> >> >> >>> >>>>> >> >>new
> >>> >> >> >>> >>>>> >> >> > tag
> >>> >> >> >>> >>>>> >> >> > >>>>and
> >>> >> >> >>> >>>>> >> >> > >>>> release. You can check out the bug on the
> >>> issue
> >>> >> >> >>>tracker
> >>> >> >> >>> >>>>>at
> >>> >> >> >>> >>>>> >> >> > >>>>
> >>> >> >> >>> >>>>> >> >> > >>>>
> >>> >> >> >>> >>>>> >> >> >
> >>> >> >> >>> >>>>> >> >>
> >>> >> >> >>> >>>>> >> >>
> >>> >> >> >>> >>>>> >>
> >>> >> >> >>> >>>>> >>
> >>> >> >> >>> >>>>>
> >>> >> >> >>> >>>>>
> >>> >> >> >>>
> >>> >> >>
> >>>
> https://issues.apache.org/jira/browse/CB-490?focusedCommentId=13252809#
> >>> >> >> >>> >>>>>co
> >>> >> >> >>> >>>>> >> >> > >>>>mment-13252809
> >>> >> >> >>> >>>>> >> >> > >>>>
> >>> >> >> >>> >>>>> >> >> > >>>> It doesn't make sense to just repackage
> >>>1.6.0
> >>> >> with
> >>> >> >> >>>this
> >>> >> >> >>> >>>>>bug
> >>> >> >> >>> >>>>> >> >>fixed as
> >>> >> >> >>> >>>>> >> >> > we
> >>> >> >> >>> >>>>> >> >> > >>>> will have no way to know if people are
> >>> >> experiencing
> >>> >> >> >>>this
> >>> >> >> >>> >>>>>or
> >>> >> >> >>> >>>>> >>not.
> >>> >> >> >>> >>>>> >> >> > >>>>
> >>> >> >> >>> >>>>> >> >> > >>>> Anis mentioned Bada also had some major
> >>>issues
> >>> >> >> >>>which he
> >>> >> >> >>> >>>>>has
> >>> >> >> >>> >>>>> >>fixed
> >>> >> >> >>> >>>>> >> >> now
> >>> >> >> >>> >>>>> >> >> > >>>>and
> >>> >> >> >>> >>>>> >> >> > >>>> would like in a 1.6.1 release.
> >>> >> >> >>> >>>>> >> >> > >>>>
> >>> >> >> >>> >>>>> >> >> > >>>> Thoughts?
> >>> >> >> >>> >>>>> >> >> > >>>>
> >>> >> >> >>> >>>>> >> >> > >>>> -Steve
> >>> >> >> >>> >>>>> >> >> > >>
> >>> >> >> >>> >>>>> >> >> >
> >>> >> >> >>> >>>>> >> >>
> >>> >> >> >>> >>>>> >>
> >>> >> >> >>> >>>>> >>
> >>> >> >> >>> >>>>>
> >>> >> >> >>> >>>>>
> >>> >> >> >>> >>>
> >>> >> >> >>> >
> >>> >> >> >>>
> >>> >> >>
> >>> >> >>
> >>> >>
> >>>
> >
>
Re: 1.6.1
Posted by Shazron <sh...@gmail.com>.
That's if I don't update the cordova-js in cordova-ios that is - but
doing a diff, just the header with the date and commit changed, no
logic.
On Thu, Apr 12, 2012 at 4:04 PM, Shazron <sh...@gmail.com> wrote:
> If we take out that iOS commit in cordova-js (somehow), it should be
> fine. cordova-ios 1.6.1 will then just be the same as 1.6.0.
>
> On Thu, Apr 12, 2012 at 4:02 PM, Filip Maj <fi...@adobe.com> wrote:
>>
>>>Is it too much to drop the new commit that changed the common js API, and
>>>reapply it after we tag 1.6.1, and figure this one thing out for 1.7?
>>
>> That sounds very good to me but I am under the impression that iOS
>> requires this commit? Like I said I'm quite confused.
>>
>>>
>>>I also have some cordova-js commits to add to 1.6.1? Although nothing that
>>>modifies any js outside of what is built for wp7. ( ie, all in my platform
>>>specific plugins folder )
>>>
>>
>> O then it sounds like I tagged the JS 1.6.1 too early anyways..
>>
>>>
>>>
>>>
>>>On Thu, Apr 12, 2012 at 3:51 PM, Shazron <sh...@gmail.com> wrote:
>>>
>>>> No - it's about a user's contribution being noted (it exists), I will
>>>> move it out of the common code post-1.6.1 (I acknowledge my mistake in
>>>> allowing it in the first place). Can we branch off 1.6.0 then
>>>> cherry-pick Fil's latest fix for 1.6.1?
>>>>
>>>> On Thu, Apr 12, 2012 at 3:47 PM, Joe Bowser <bo...@gmail.com> wrote:
>>>> > OK, so you're proposing that we leave the thing in the common JS, even
>>>> > though it's not supposed to be there.
>>>> >
>>>> > On Thu, Apr 12, 2012 at 3:45 PM, Shazron <sh...@gmail.com> wrote:
>>>> >
>>>> >> Will rebasing lose that commit? Then, no.
>>>> >>
>>>> >> On Thu, Apr 12, 2012 at 3:43 PM, Joe Bowser <bo...@gmail.com>
>>>>wrote:
>>>> >> > So, can we just rebase the head, push this out and get this
>>>>rolling?
>>>> >> >
>>>> >> > On Thu, Apr 12, 2012 at 3:43 PM, Filip Maj <fi...@adobe.com> wrote:
>>>> >> >
>>>> >> >> Correct, those iOS-specific parameters (like allow edit and those
>>>> ones)
>>>> >> >> existed prior to cordova-js, so yeah, we left them in there as we
>>>> didn't
>>>> >> >> want to remove without deprecation.
>>>> >> >>
>>>> >> >> If you can deal with the iOS issue without needing an API
>>>>extension:
>>>> >> then
>>>> >> >> do that. If not, leave it in there, but docs need to updated too.
>>>> >> >>
>>>> >> >> Extending and changing the public API is a long and difficult
>>>>process
>>>> >> for
>>>> >> >> us and will only get tougher with every platform we add support
>>>>to.
>>>> >> >>
>>>> >> >> On 4/12/12 3:37 PM, "Shazron" <sh...@gmail.com> wrote:
>>>> >> >>
>>>> >> >> >Then we have to scrap the other three(?) iOS parameters ones that
>>>> >> >> >already exist in common if you noticed. Don't know how we merge
>>>> >> >> >(unmerge?) this one properly because taking those out will break
>>>> >> >> >everyone that is using it, but a deprecation is the way to go as
>>>>per
>>>> >> >> >http://wiki.apache.org/cordova/DeprecationPolicy . We can remove
>>>> this
>>>> >> >> >new commit and I'll find a way to get this in somehow.
>>>> >> >> >
>>>> >> >> >
>>>> >> >> >
>>>> >> >> >On Thu, Apr 12, 2012 at 3:32 PM, Joe Bowser <bo...@gmail.com>
>>>> wrote:
>>>> >> >> >> The problem is that this parameter doesn't belong in the common
>>>> API.
>>>> >> >> >>It'd
>>>> >> >> >> be just ignored in Android, but the whole point of cordova-js
>>>>is
>>>> so
>>>> >> that
>>>> >> >> >> it's common. It'd look pretty screwed up to add this to the
>>>>docs,
>>>> >> IMO.
>>>> >> >> >>
>>>> >> >> >> On Thu, Apr 12, 2012 at 3:26 PM, Shazron <sh...@gmail.com>
>>>> wrote:
>>>> >> >> >>
>>>> >> >> >>> To fix two bugs for Camera.takePicture on iOS
>>>> >> >> >>>
>>>> >> >> >>> On Thu, Apr 12, 2012 at 3:24 PM, Filip Maj <fi...@adobe.com>
>>>> wrote:
>>>> >> >> >>> > so what's the point of this new parameter?
>>>> >> >> >>> >
>>>> >> >> >>> > On 4/12/12 3:16 PM, "Shazron" <sh...@gmail.com> wrote:
>>>> >> >> >>> >
>>>> >> >> >>> >>I did. Do we want to revert the cordova-js? I can branch
>>>>1.6.0
>>>> and
>>>> >> >> >>> >>cherry-pick your latest commit for 1.6.1
>>>> >> >> >>> >>
>>>> >> >> >>> >>On Thu, Apr 12, 2012 at 3:04 PM, Filip Maj <fi...@adobe.com>
>>>> wrote:
>>>> >> >> >>> >>> I saw something in the iOS commit logs for this.
>>>> >> >> >>> >>>
>>>> >> >> >>> >>> Shaz can you comment?
>>>> >> >> >>> >>>
>>>> >> >> >>> >>> On 4/12/12 2:59 PM, "Joe Bowser" <bo...@gmail.com>
>>>>wrote:
>>>> >> >> >>> >>>
>>>> >> >> >>> >>>>Can we revert this, since this looks like it's intended
>>>>for
>>>> both
>>>> >> >> >>> Android
>>>> >> >> >>> >>>>and iOS, but I don't think it should be in 1.6.1.
>>>> >> >> >>> >>>>
>>>> >> >> >>> >>>>On Thu, Apr 12, 2012 at 2:52 PM, Filip Maj <fi...@adobe.com>
>>>> >> wrote:
>>>> >> >> >>> >>>>
>>>> >> >> >>> >>>>> I was actually just looking at that myself.
>>>> >> >> >>> >>>>>
>>>> >> >> >>> >>>>> Looks like it's an iOS-only param.. sigh. We gotta stop
>>>> doing
>>>> >> >> >>>that,
>>>> >> >> >>> >>>>> especially if we don't update documentation.
>>>> >> >> >>> >>>>>
>>>> >> >> >>> >>>>> On 4/12/12 2:49 PM, "Joe Bowser" <bo...@gmail.com>
>>>> wrote:
>>>> >> >> >>> >>>>>
>>>> >> >> >>> >>>>> >Has anyone tested the cropToSize param for
>>>> Camera.getPicture
>>>> >> >> >>>yet? I
>>>> >> >> >>> >>>>> >didn't
>>>> >> >> >>> >>>>> >notice that change until now.
>>>> >> >> >>> >>>>> >
>>>> >> >> >>> >>>>> >On Thu, Apr 12, 2012 at 2:46 PM, Filip Maj
>>>><fil@adobe.com
>>>> >
>>>> >> >> >>>wrote:
>>>> >> >> >>> >>>>> >
>>>> >> >> >>> >>>>> >> JS tagged 1.6.1 - the build task in the JS should
>>>>work
>>>> >> >> >>>properly
>>>> >> >> >>> >>>>>now.
>>>> >> >> >>> >>>>> >>
>>>> >> >> >>> >>>>> >> FYI if anyone has to modify the jake tasks in the
>>>>future
>>>> >> and
>>>> >> >> >>>make
>>>> >> >> >>> >>>>>them
>>>> >> >> >>> >>>>> >> async, make sure you add the 4th "async" parameter to
>>>> the
>>>> >> >> >>>task()
>>>> >> >> >>> >>>>> >>function
>>>> >> >> >>> >>>>> >> and set it to true, and call complete() when the
>>>>task is
>>>> >> done.
>>>> >> >> >>> >>>>> >>
>>>> >> >> >>> >>>>> >> See
>>>> http://howtonode.org/intro-to-jake/async-jakefile.jsfor
>>>> >> >> >>>an
>>>> >> >> >>> >>>>> example.
>>>> >> >> >>> >>>>> >>
>>>> >> >> >>> >>>>> >> On 4/12/12 2:35 PM, "Joe Bowser" <bo...@gmail.com>
>>>> >> wrote:
>>>> >> >> >>> >>>>> >>
>>>> >> >> >>> >>>>> >> >Ready to tag once cordova-js is tagged 1.6.1.
>>>> >> >> >>> >>>>> >> >
>>>> >> >> >>> >>>>> >> >On Thu, Apr 12, 2012 at 2:33 PM, Anis KADRI <
>>>> >> >> >>> anis.kadri@gmail.com>
>>>> >> >> >>> >>>>> >>wrote:
>>>> >> >> >>> >>>>> >> >
>>>> >> >> >>> >>>>> >> >> I will tag my repository to 1.6.1 before end of
>>>>day
>>>> >> today
>>>> >> >> >>>after
>>>> >> >> >>> >>>>>some
>>>> >> >> >>> >>>>> >> >> thorough testing.
>>>> >> >> >>> >>>>> >> >>
>>>> >> >> >>> >>>>> >> >> On Thu, Apr 12, 2012 at 2:30 PM, Shazron
>>>> >> >> >>><sh...@gmail.com>
>>>> >> >> >>> >>>>>wrote:
>>>> >> >> >>> >>>>> >> >>
>>>> >> >> >>> >>>>> >> >> > I also created a 1.6.1 version tag as well in
>>>> jira...
>>>> >> >> >>> >>>>> >> >> >
>>>> >> >> >>> >>>>> >> >> > On Thu, Apr 12, 2012 at 2:29 PM, Shazron
>>>> >> >> >>><sh...@gmail.com>
>>>> >> >> >>> >>>>> wrote:
>>>> >> >> >>> >>>>> >> >> > > Alright guys since 1.6.0 was released, I'm
>>>>going
>>>> to
>>>> >> >> >>> >>>>>"Release"
>>>> >> >> >>> >>>>>the
>>>> >> >> >>> >>>>> >> >> > > 1.6.0 version in jira and move outstanding
>>>> issues to
>>>> >> >> >>>1.7.0
>>>> >> >> >>> >>>>> >>version
>>>> >> >> >>> >>>>> >> >> > > tag.
>>>> >> >> >>> >>>>> >> >> > >
>>>> >> >> >>> >>>>> >> >> > >
>>>> >> >> >>> >>>>> >> >> > > On Thu, Apr 12, 2012 at 2:26 PM, Filip Maj
>>>> >> >> >>><fi...@adobe.com>
>>>> >> >> >>> >>>>> wrote:
>>>> >> >> >>> >>>>> >> >> > >> The JS needs patching too. Since adding the
>>>> commit
>>>> >> ID
>>>> >> >> >>>into
>>>> >> >> >>> >>>>>the
>>>> >> >> >>> >>>>> >> >> packaging
>>>> >> >> >>> >>>>> >> >> > >> in the jakefile, the default task isn't
>>>>running
>>>> >> >> >>>properly.
>>>> >> >> >>> >>>>> >> >> > >>
>>>> >> >> >>> >>>>> >> >> > >> You can manually run "jake build" and "jake
>>>> test"
>>>> >> but
>>>> >> >> >>>not
>>>> >> >> >>> >>>>> >>"jake" on
>>>> >> >> >>> >>>>> >> >> its
>>>> >> >> >>> >>>>> >> >> > >> own - gonna try to figure it out.
>>>> >> >> >>> >>>>> >> >> > >>
>>>> >> >> >>> >>>>> >> >> > >> On 4/12/12 2:21 PM, "Shazron" <
>>>> shazron@gmail.com>
>>>> >> >> >>>wrote:
>>>> >> >> >>> >>>>> >> >> > >>
>>>> >> >> >>> >>>>> >> >> > >>>I'm good with tagging. iOS has a few commits
>>>> (one
>>>> >> >> >>>commit
>>>> >> >> >>> >>>>>in
>>>> >> >> >>> >>>>> >> >> > >>>cordova-js) as well. Aim for first thing
>>>> tomorrow
>>>> >> for
>>>> >> >> >>>you
>>>> >> >> >>> >>>>>to
>>>> >> >> >>> >>>>> >> >> > >>>repackage?
>>>> >> >> >>> >>>>> >> >> > >>>
>>>> >> >> >>> >>>>> >> >> > >>>On Thu, Apr 12, 2012 at 2:17 PM, Steven Gill
>>>> >> >> >>> >>>>> >> >><st...@gmail.com>
>>>> >> >> >>> >>>>> >> >> > >>>wrote:
>>>> >> >> >>> >>>>> >> >> > >>>> So a bug has been discovered in Cordova
>>>> Android
>>>> >> that
>>>> >> >> >>> >>>>>requires
>>>> >> >> >>> >>>>> >>a
>>>> >> >> >>> >>>>> >> >>new
>>>> >> >> >>> >>>>> >> >> > tag
>>>> >> >> >>> >>>>> >> >> > >>>>and
>>>> >> >> >>> >>>>> >> >> > >>>> release. You can check out the bug on the
>>>> issue
>>>> >> >> >>>tracker
>>>> >> >> >>> >>>>>at
>>>> >> >> >>> >>>>> >> >> > >>>>
>>>> >> >> >>> >>>>> >> >> > >>>>
>>>> >> >> >>> >>>>> >> >> >
>>>> >> >> >>> >>>>> >> >>
>>>> >> >> >>> >>>>> >> >>
>>>> >> >> >>> >>>>> >>
>>>> >> >> >>> >>>>> >>
>>>> >> >> >>> >>>>>
>>>> >> >> >>> >>>>>
>>>> >> >> >>>
>>>> >> >>
>>>> https://issues.apache.org/jira/browse/CB-490?focusedCommentId=13252809#
>>>> >> >> >>> >>>>>co
>>>> >> >> >>> >>>>> >> >> > >>>>mment-13252809
>>>> >> >> >>> >>>>> >> >> > >>>>
>>>> >> >> >>> >>>>> >> >> > >>>> It doesn't make sense to just repackage
>>>>1.6.0
>>>> >> with
>>>> >> >> >>>this
>>>> >> >> >>> >>>>>bug
>>>> >> >> >>> >>>>> >> >>fixed as
>>>> >> >> >>> >>>>> >> >> > we
>>>> >> >> >>> >>>>> >> >> > >>>> will have no way to know if people are
>>>> >> experiencing
>>>> >> >> >>>this
>>>> >> >> >>> >>>>>or
>>>> >> >> >>> >>>>> >>not.
>>>> >> >> >>> >>>>> >> >> > >>>>
>>>> >> >> >>> >>>>> >> >> > >>>> Anis mentioned Bada also had some major
>>>>issues
>>>> >> >> >>>which he
>>>> >> >> >>> >>>>>has
>>>> >> >> >>> >>>>> >>fixed
>>>> >> >> >>> >>>>> >> >> now
>>>> >> >> >>> >>>>> >> >> > >>>>and
>>>> >> >> >>> >>>>> >> >> > >>>> would like in a 1.6.1 release.
>>>> >> >> >>> >>>>> >> >> > >>>>
>>>> >> >> >>> >>>>> >> >> > >>>> Thoughts?
>>>> >> >> >>> >>>>> >> >> > >>>>
>>>> >> >> >>> >>>>> >> >> > >>>> -Steve
>>>> >> >> >>> >>>>> >> >> > >>
>>>> >> >> >>> >>>>> >> >> >
>>>> >> >> >>> >>>>> >> >>
>>>> >> >> >>> >>>>> >>
>>>> >> >> >>> >>>>> >>
>>>> >> >> >>> >>>>>
>>>> >> >> >>> >>>>>
>>>> >> >> >>> >>>
>>>> >> >> >>> >
>>>> >> >> >>>
>>>> >> >>
>>>> >> >>
>>>> >>
>>>>
>>
Re: 1.6.1
Posted by Shazron <sh...@gmail.com>.
If we take out that iOS commit in cordova-js (somehow), it should be
fine. cordova-ios 1.6.1 will then just be the same as 1.6.0.
On Thu, Apr 12, 2012 at 4:02 PM, Filip Maj <fi...@adobe.com> wrote:
>
>>Is it too much to drop the new commit that changed the common js API, and
>>reapply it after we tag 1.6.1, and figure this one thing out for 1.7?
>
> That sounds very good to me but I am under the impression that iOS
> requires this commit? Like I said I'm quite confused.
>
>>
>>I also have some cordova-js commits to add to 1.6.1? Although nothing that
>>modifies any js outside of what is built for wp7. ( ie, all in my platform
>>specific plugins folder )
>>
>
> O then it sounds like I tagged the JS 1.6.1 too early anyways..
>
>>
>>
>>
>>On Thu, Apr 12, 2012 at 3:51 PM, Shazron <sh...@gmail.com> wrote:
>>
>>> No - it's about a user's contribution being noted (it exists), I will
>>> move it out of the common code post-1.6.1 (I acknowledge my mistake in
>>> allowing it in the first place). Can we branch off 1.6.0 then
>>> cherry-pick Fil's latest fix for 1.6.1?
>>>
>>> On Thu, Apr 12, 2012 at 3:47 PM, Joe Bowser <bo...@gmail.com> wrote:
>>> > OK, so you're proposing that we leave the thing in the common JS, even
>>> > though it's not supposed to be there.
>>> >
>>> > On Thu, Apr 12, 2012 at 3:45 PM, Shazron <sh...@gmail.com> wrote:
>>> >
>>> >> Will rebasing lose that commit? Then, no.
>>> >>
>>> >> On Thu, Apr 12, 2012 at 3:43 PM, Joe Bowser <bo...@gmail.com>
>>>wrote:
>>> >> > So, can we just rebase the head, push this out and get this
>>>rolling?
>>> >> >
>>> >> > On Thu, Apr 12, 2012 at 3:43 PM, Filip Maj <fi...@adobe.com> wrote:
>>> >> >
>>> >> >> Correct, those iOS-specific parameters (like allow edit and those
>>> ones)
>>> >> >> existed prior to cordova-js, so yeah, we left them in there as we
>>> didn't
>>> >> >> want to remove without deprecation.
>>> >> >>
>>> >> >> If you can deal with the iOS issue without needing an API
>>>extension:
>>> >> then
>>> >> >> do that. If not, leave it in there, but docs need to updated too.
>>> >> >>
>>> >> >> Extending and changing the public API is a long and difficult
>>>process
>>> >> for
>>> >> >> us and will only get tougher with every platform we add support
>>>to.
>>> >> >>
>>> >> >> On 4/12/12 3:37 PM, "Shazron" <sh...@gmail.com> wrote:
>>> >> >>
>>> >> >> >Then we have to scrap the other three(?) iOS parameters ones that
>>> >> >> >already exist in common if you noticed. Don't know how we merge
>>> >> >> >(unmerge?) this one properly because taking those out will break
>>> >> >> >everyone that is using it, but a deprecation is the way to go as
>>>per
>>> >> >> >http://wiki.apache.org/cordova/DeprecationPolicy . We can remove
>>> this
>>> >> >> >new commit and I'll find a way to get this in somehow.
>>> >> >> >
>>> >> >> >
>>> >> >> >
>>> >> >> >On Thu, Apr 12, 2012 at 3:32 PM, Joe Bowser <bo...@gmail.com>
>>> wrote:
>>> >> >> >> The problem is that this parameter doesn't belong in the common
>>> API.
>>> >> >> >>It'd
>>> >> >> >> be just ignored in Android, but the whole point of cordova-js
>>>is
>>> so
>>> >> that
>>> >> >> >> it's common. It'd look pretty screwed up to add this to the
>>>docs,
>>> >> IMO.
>>> >> >> >>
>>> >> >> >> On Thu, Apr 12, 2012 at 3:26 PM, Shazron <sh...@gmail.com>
>>> wrote:
>>> >> >> >>
>>> >> >> >>> To fix two bugs for Camera.takePicture on iOS
>>> >> >> >>>
>>> >> >> >>> On Thu, Apr 12, 2012 at 3:24 PM, Filip Maj <fi...@adobe.com>
>>> wrote:
>>> >> >> >>> > so what's the point of this new parameter?
>>> >> >> >>> >
>>> >> >> >>> > On 4/12/12 3:16 PM, "Shazron" <sh...@gmail.com> wrote:
>>> >> >> >>> >
>>> >> >> >>> >>I did. Do we want to revert the cordova-js? I can branch
>>>1.6.0
>>> and
>>> >> >> >>> >>cherry-pick your latest commit for 1.6.1
>>> >> >> >>> >>
>>> >> >> >>> >>On Thu, Apr 12, 2012 at 3:04 PM, Filip Maj <fi...@adobe.com>
>>> wrote:
>>> >> >> >>> >>> I saw something in the iOS commit logs for this.
>>> >> >> >>> >>>
>>> >> >> >>> >>> Shaz can you comment?
>>> >> >> >>> >>>
>>> >> >> >>> >>> On 4/12/12 2:59 PM, "Joe Bowser" <bo...@gmail.com>
>>>wrote:
>>> >> >> >>> >>>
>>> >> >> >>> >>>>Can we revert this, since this looks like it's intended
>>>for
>>> both
>>> >> >> >>> Android
>>> >> >> >>> >>>>and iOS, but I don't think it should be in 1.6.1.
>>> >> >> >>> >>>>
>>> >> >> >>> >>>>On Thu, Apr 12, 2012 at 2:52 PM, Filip Maj <fi...@adobe.com>
>>> >> wrote:
>>> >> >> >>> >>>>
>>> >> >> >>> >>>>> I was actually just looking at that myself.
>>> >> >> >>> >>>>>
>>> >> >> >>> >>>>> Looks like it's an iOS-only param.. sigh. We gotta stop
>>> doing
>>> >> >> >>>that,
>>> >> >> >>> >>>>> especially if we don't update documentation.
>>> >> >> >>> >>>>>
>>> >> >> >>> >>>>> On 4/12/12 2:49 PM, "Joe Bowser" <bo...@gmail.com>
>>> wrote:
>>> >> >> >>> >>>>>
>>> >> >> >>> >>>>> >Has anyone tested the cropToSize param for
>>> Camera.getPicture
>>> >> >> >>>yet? I
>>> >> >> >>> >>>>> >didn't
>>> >> >> >>> >>>>> >notice that change until now.
>>> >> >> >>> >>>>> >
>>> >> >> >>> >>>>> >On Thu, Apr 12, 2012 at 2:46 PM, Filip Maj
>>><fil@adobe.com
>>> >
>>> >> >> >>>wrote:
>>> >> >> >>> >>>>> >
>>> >> >> >>> >>>>> >> JS tagged 1.6.1 - the build task in the JS should
>>>work
>>> >> >> >>>properly
>>> >> >> >>> >>>>>now.
>>> >> >> >>> >>>>> >>
>>> >> >> >>> >>>>> >> FYI if anyone has to modify the jake tasks in the
>>>future
>>> >> and
>>> >> >> >>>make
>>> >> >> >>> >>>>>them
>>> >> >> >>> >>>>> >> async, make sure you add the 4th "async" parameter to
>>> the
>>> >> >> >>>task()
>>> >> >> >>> >>>>> >>function
>>> >> >> >>> >>>>> >> and set it to true, and call complete() when the
>>>task is
>>> >> done.
>>> >> >> >>> >>>>> >>
>>> >> >> >>> >>>>> >> See
>>> http://howtonode.org/intro-to-jake/async-jakefile.jsfor
>>> >> >> >>>an
>>> >> >> >>> >>>>> example.
>>> >> >> >>> >>>>> >>
>>> >> >> >>> >>>>> >> On 4/12/12 2:35 PM, "Joe Bowser" <bo...@gmail.com>
>>> >> wrote:
>>> >> >> >>> >>>>> >>
>>> >> >> >>> >>>>> >> >Ready to tag once cordova-js is tagged 1.6.1.
>>> >> >> >>> >>>>> >> >
>>> >> >> >>> >>>>> >> >On Thu, Apr 12, 2012 at 2:33 PM, Anis KADRI <
>>> >> >> >>> anis.kadri@gmail.com>
>>> >> >> >>> >>>>> >>wrote:
>>> >> >> >>> >>>>> >> >
>>> >> >> >>> >>>>> >> >> I will tag my repository to 1.6.1 before end of
>>>day
>>> >> today
>>> >> >> >>>after
>>> >> >> >>> >>>>>some
>>> >> >> >>> >>>>> >> >> thorough testing.
>>> >> >> >>> >>>>> >> >>
>>> >> >> >>> >>>>> >> >> On Thu, Apr 12, 2012 at 2:30 PM, Shazron
>>> >> >> >>><sh...@gmail.com>
>>> >> >> >>> >>>>>wrote:
>>> >> >> >>> >>>>> >> >>
>>> >> >> >>> >>>>> >> >> > I also created a 1.6.1 version tag as well in
>>> jira...
>>> >> >> >>> >>>>> >> >> >
>>> >> >> >>> >>>>> >> >> > On Thu, Apr 12, 2012 at 2:29 PM, Shazron
>>> >> >> >>><sh...@gmail.com>
>>> >> >> >>> >>>>> wrote:
>>> >> >> >>> >>>>> >> >> > > Alright guys since 1.6.0 was released, I'm
>>>going
>>> to
>>> >> >> >>> >>>>>"Release"
>>> >> >> >>> >>>>>the
>>> >> >> >>> >>>>> >> >> > > 1.6.0 version in jira and move outstanding
>>> issues to
>>> >> >> >>>1.7.0
>>> >> >> >>> >>>>> >>version
>>> >> >> >>> >>>>> >> >> > > tag.
>>> >> >> >>> >>>>> >> >> > >
>>> >> >> >>> >>>>> >> >> > >
>>> >> >> >>> >>>>> >> >> > > On Thu, Apr 12, 2012 at 2:26 PM, Filip Maj
>>> >> >> >>><fi...@adobe.com>
>>> >> >> >>> >>>>> wrote:
>>> >> >> >>> >>>>> >> >> > >> The JS needs patching too. Since adding the
>>> commit
>>> >> ID
>>> >> >> >>>into
>>> >> >> >>> >>>>>the
>>> >> >> >>> >>>>> >> >> packaging
>>> >> >> >>> >>>>> >> >> > >> in the jakefile, the default task isn't
>>>running
>>> >> >> >>>properly.
>>> >> >> >>> >>>>> >> >> > >>
>>> >> >> >>> >>>>> >> >> > >> You can manually run "jake build" and "jake
>>> test"
>>> >> but
>>> >> >> >>>not
>>> >> >> >>> >>>>> >>"jake" on
>>> >> >> >>> >>>>> >> >> its
>>> >> >> >>> >>>>> >> >> > >> own - gonna try to figure it out.
>>> >> >> >>> >>>>> >> >> > >>
>>> >> >> >>> >>>>> >> >> > >> On 4/12/12 2:21 PM, "Shazron" <
>>> shazron@gmail.com>
>>> >> >> >>>wrote:
>>> >> >> >>> >>>>> >> >> > >>
>>> >> >> >>> >>>>> >> >> > >>>I'm good with tagging. iOS has a few commits
>>> (one
>>> >> >> >>>commit
>>> >> >> >>> >>>>>in
>>> >> >> >>> >>>>> >> >> > >>>cordova-js) as well. Aim for first thing
>>> tomorrow
>>> >> for
>>> >> >> >>>you
>>> >> >> >>> >>>>>to
>>> >> >> >>> >>>>> >> >> > >>>repackage?
>>> >> >> >>> >>>>> >> >> > >>>
>>> >> >> >>> >>>>> >> >> > >>>On Thu, Apr 12, 2012 at 2:17 PM, Steven Gill
>>> >> >> >>> >>>>> >> >><st...@gmail.com>
>>> >> >> >>> >>>>> >> >> > >>>wrote:
>>> >> >> >>> >>>>> >> >> > >>>> So a bug has been discovered in Cordova
>>> Android
>>> >> that
>>> >> >> >>> >>>>>requires
>>> >> >> >>> >>>>> >>a
>>> >> >> >>> >>>>> >> >>new
>>> >> >> >>> >>>>> >> >> > tag
>>> >> >> >>> >>>>> >> >> > >>>>and
>>> >> >> >>> >>>>> >> >> > >>>> release. You can check out the bug on the
>>> issue
>>> >> >> >>>tracker
>>> >> >> >>> >>>>>at
>>> >> >> >>> >>>>> >> >> > >>>>
>>> >> >> >>> >>>>> >> >> > >>>>
>>> >> >> >>> >>>>> >> >> >
>>> >> >> >>> >>>>> >> >>
>>> >> >> >>> >>>>> >> >>
>>> >> >> >>> >>>>> >>
>>> >> >> >>> >>>>> >>
>>> >> >> >>> >>>>>
>>> >> >> >>> >>>>>
>>> >> >> >>>
>>> >> >>
>>> https://issues.apache.org/jira/browse/CB-490?focusedCommentId=13252809#
>>> >> >> >>> >>>>>co
>>> >> >> >>> >>>>> >> >> > >>>>mment-13252809
>>> >> >> >>> >>>>> >> >> > >>>>
>>> >> >> >>> >>>>> >> >> > >>>> It doesn't make sense to just repackage
>>>1.6.0
>>> >> with
>>> >> >> >>>this
>>> >> >> >>> >>>>>bug
>>> >> >> >>> >>>>> >> >>fixed as
>>> >> >> >>> >>>>> >> >> > we
>>> >> >> >>> >>>>> >> >> > >>>> will have no way to know if people are
>>> >> experiencing
>>> >> >> >>>this
>>> >> >> >>> >>>>>or
>>> >> >> >>> >>>>> >>not.
>>> >> >> >>> >>>>> >> >> > >>>>
>>> >> >> >>> >>>>> >> >> > >>>> Anis mentioned Bada also had some major
>>>issues
>>> >> >> >>>which he
>>> >> >> >>> >>>>>has
>>> >> >> >>> >>>>> >>fixed
>>> >> >> >>> >>>>> >> >> now
>>> >> >> >>> >>>>> >> >> > >>>>and
>>> >> >> >>> >>>>> >> >> > >>>> would like in a 1.6.1 release.
>>> >> >> >>> >>>>> >> >> > >>>>
>>> >> >> >>> >>>>> >> >> > >>>> Thoughts?
>>> >> >> >>> >>>>> >> >> > >>>>
>>> >> >> >>> >>>>> >> >> > >>>> -Steve
>>> >> >> >>> >>>>> >> >> > >>
>>> >> >> >>> >>>>> >> >> >
>>> >> >> >>> >>>>> >> >>
>>> >> >> >>> >>>>> >>
>>> >> >> >>> >>>>> >>
>>> >> >> >>> >>>>>
>>> >> >> >>> >>>>>
>>> >> >> >>> >>>
>>> >> >> >>> >
>>> >> >> >>>
>>> >> >>
>>> >> >>
>>> >>
>>>
>
Re: 1.6.1
Posted by Shazron <sh...@gmail.com>.
Just rebase it Joe :)
On Thu, Apr 12, 2012 at 3:58 PM, Jesse <pu...@gmail.com> wrote:
> Is it too much to drop the new commit that changed the common js API, and
> reapply it after we tag 1.6.1, and figure this one thing out for 1.7?
>
> I also have some cordova-js commits to add to 1.6.1? Although nothing that
> modifies any js outside of what is built for wp7. ( ie, all in my platform
> specific plugins folder )
>
>
>
>
> On Thu, Apr 12, 2012 at 3:51 PM, Shazron <sh...@gmail.com> wrote:
>
>> No - it's about a user's contribution being noted (it exists), I will
>> move it out of the common code post-1.6.1 (I acknowledge my mistake in
>> allowing it in the first place). Can we branch off 1.6.0 then
>> cherry-pick Fil's latest fix for 1.6.1?
>>
>> On Thu, Apr 12, 2012 at 3:47 PM, Joe Bowser <bo...@gmail.com> wrote:
>> > OK, so you're proposing that we leave the thing in the common JS, even
>> > though it's not supposed to be there.
>> >
>> > On Thu, Apr 12, 2012 at 3:45 PM, Shazron <sh...@gmail.com> wrote:
>> >
>> >> Will rebasing lose that commit? Then, no.
>> >>
>> >> On Thu, Apr 12, 2012 at 3:43 PM, Joe Bowser <bo...@gmail.com> wrote:
>> >> > So, can we just rebase the head, push this out and get this rolling?
>> >> >
>> >> > On Thu, Apr 12, 2012 at 3:43 PM, Filip Maj <fi...@adobe.com> wrote:
>> >> >
>> >> >> Correct, those iOS-specific parameters (like allow edit and those
>> ones)
>> >> >> existed prior to cordova-js, so yeah, we left them in there as we
>> didn't
>> >> >> want to remove without deprecation.
>> >> >>
>> >> >> If you can deal with the iOS issue without needing an API extension:
>> >> then
>> >> >> do that. If not, leave it in there, but docs need to updated too.
>> >> >>
>> >> >> Extending and changing the public API is a long and difficult process
>> >> for
>> >> >> us and will only get tougher with every platform we add support to.
>> >> >>
>> >> >> On 4/12/12 3:37 PM, "Shazron" <sh...@gmail.com> wrote:
>> >> >>
>> >> >> >Then we have to scrap the other three(?) iOS parameters ones that
>> >> >> >already exist in common if you noticed. Don't know how we merge
>> >> >> >(unmerge?) this one properly because taking those out will break
>> >> >> >everyone that is using it, but a deprecation is the way to go as per
>> >> >> >http://wiki.apache.org/cordova/DeprecationPolicy . We can remove
>> this
>> >> >> >new commit and I'll find a way to get this in somehow.
>> >> >> >
>> >> >> >
>> >> >> >
>> >> >> >On Thu, Apr 12, 2012 at 3:32 PM, Joe Bowser <bo...@gmail.com>
>> wrote:
>> >> >> >> The problem is that this parameter doesn't belong in the common
>> API.
>> >> >> >>It'd
>> >> >> >> be just ignored in Android, but the whole point of cordova-js is
>> so
>> >> that
>> >> >> >> it's common. It'd look pretty screwed up to add this to the docs,
>> >> IMO.
>> >> >> >>
>> >> >> >> On Thu, Apr 12, 2012 at 3:26 PM, Shazron <sh...@gmail.com>
>> wrote:
>> >> >> >>
>> >> >> >>> To fix two bugs for Camera.takePicture on iOS
>> >> >> >>>
>> >> >> >>> On Thu, Apr 12, 2012 at 3:24 PM, Filip Maj <fi...@adobe.com>
>> wrote:
>> >> >> >>> > so what's the point of this new parameter?
>> >> >> >>> >
>> >> >> >>> > On 4/12/12 3:16 PM, "Shazron" <sh...@gmail.com> wrote:
>> >> >> >>> >
>> >> >> >>> >>I did. Do we want to revert the cordova-js? I can branch 1.6.0
>> and
>> >> >> >>> >>cherry-pick your latest commit for 1.6.1
>> >> >> >>> >>
>> >> >> >>> >>On Thu, Apr 12, 2012 at 3:04 PM, Filip Maj <fi...@adobe.com>
>> wrote:
>> >> >> >>> >>> I saw something in the iOS commit logs for this.
>> >> >> >>> >>>
>> >> >> >>> >>> Shaz can you comment?
>> >> >> >>> >>>
>> >> >> >>> >>> On 4/12/12 2:59 PM, "Joe Bowser" <bo...@gmail.com> wrote:
>> >> >> >>> >>>
>> >> >> >>> >>>>Can we revert this, since this looks like it's intended for
>> both
>> >> >> >>> Android
>> >> >> >>> >>>>and iOS, but I don't think it should be in 1.6.1.
>> >> >> >>> >>>>
>> >> >> >>> >>>>On Thu, Apr 12, 2012 at 2:52 PM, Filip Maj <fi...@adobe.com>
>> >> wrote:
>> >> >> >>> >>>>
>> >> >> >>> >>>>> I was actually just looking at that myself.
>> >> >> >>> >>>>>
>> >> >> >>> >>>>> Looks like it's an iOS-only param.. sigh. We gotta stop
>> doing
>> >> >> >>>that,
>> >> >> >>> >>>>> especially if we don't update documentation.
>> >> >> >>> >>>>>
>> >> >> >>> >>>>> On 4/12/12 2:49 PM, "Joe Bowser" <bo...@gmail.com>
>> wrote:
>> >> >> >>> >>>>>
>> >> >> >>> >>>>> >Has anyone tested the cropToSize param for
>> Camera.getPicture
>> >> >> >>>yet? I
>> >> >> >>> >>>>> >didn't
>> >> >> >>> >>>>> >notice that change until now.
>> >> >> >>> >>>>> >
>> >> >> >>> >>>>> >On Thu, Apr 12, 2012 at 2:46 PM, Filip Maj <fil@adobe.com
>> >
>> >> >> >>>wrote:
>> >> >> >>> >>>>> >
>> >> >> >>> >>>>> >> JS tagged 1.6.1 - the build task in the JS should work
>> >> >> >>>properly
>> >> >> >>> >>>>>now.
>> >> >> >>> >>>>> >>
>> >> >> >>> >>>>> >> FYI if anyone has to modify the jake tasks in the future
>> >> and
>> >> >> >>>make
>> >> >> >>> >>>>>them
>> >> >> >>> >>>>> >> async, make sure you add the 4th "async" parameter to
>> the
>> >> >> >>>task()
>> >> >> >>> >>>>> >>function
>> >> >> >>> >>>>> >> and set it to true, and call complete() when the task is
>> >> done.
>> >> >> >>> >>>>> >>
>> >> >> >>> >>>>> >> See
>> http://howtonode.org/intro-to-jake/async-jakefile.jsfor
>> >> >> >>>an
>> >> >> >>> >>>>> example.
>> >> >> >>> >>>>> >>
>> >> >> >>> >>>>> >> On 4/12/12 2:35 PM, "Joe Bowser" <bo...@gmail.com>
>> >> wrote:
>> >> >> >>> >>>>> >>
>> >> >> >>> >>>>> >> >Ready to tag once cordova-js is tagged 1.6.1.
>> >> >> >>> >>>>> >> >
>> >> >> >>> >>>>> >> >On Thu, Apr 12, 2012 at 2:33 PM, Anis KADRI <
>> >> >> >>> anis.kadri@gmail.com>
>> >> >> >>> >>>>> >>wrote:
>> >> >> >>> >>>>> >> >
>> >> >> >>> >>>>> >> >> I will tag my repository to 1.6.1 before end of day
>> >> today
>> >> >> >>>after
>> >> >> >>> >>>>>some
>> >> >> >>> >>>>> >> >> thorough testing.
>> >> >> >>> >>>>> >> >>
>> >> >> >>> >>>>> >> >> On Thu, Apr 12, 2012 at 2:30 PM, Shazron
>> >> >> >>><sh...@gmail.com>
>> >> >> >>> >>>>>wrote:
>> >> >> >>> >>>>> >> >>
>> >> >> >>> >>>>> >> >> > I also created a 1.6.1 version tag as well in
>> jira...
>> >> >> >>> >>>>> >> >> >
>> >> >> >>> >>>>> >> >> > On Thu, Apr 12, 2012 at 2:29 PM, Shazron
>> >> >> >>><sh...@gmail.com>
>> >> >> >>> >>>>> wrote:
>> >> >> >>> >>>>> >> >> > > Alright guys since 1.6.0 was released, I'm going
>> to
>> >> >> >>> >>>>>"Release"
>> >> >> >>> >>>>>the
>> >> >> >>> >>>>> >> >> > > 1.6.0 version in jira and move outstanding
>> issues to
>> >> >> >>>1.7.0
>> >> >> >>> >>>>> >>version
>> >> >> >>> >>>>> >> >> > > tag.
>> >> >> >>> >>>>> >> >> > >
>> >> >> >>> >>>>> >> >> > >
>> >> >> >>> >>>>> >> >> > > On Thu, Apr 12, 2012 at 2:26 PM, Filip Maj
>> >> >> >>><fi...@adobe.com>
>> >> >> >>> >>>>> wrote:
>> >> >> >>> >>>>> >> >> > >> The JS needs patching too. Since adding the
>> commit
>> >> ID
>> >> >> >>>into
>> >> >> >>> >>>>>the
>> >> >> >>> >>>>> >> >> packaging
>> >> >> >>> >>>>> >> >> > >> in the jakefile, the default task isn't running
>> >> >> >>>properly.
>> >> >> >>> >>>>> >> >> > >>
>> >> >> >>> >>>>> >> >> > >> You can manually run "jake build" and "jake
>> test"
>> >> but
>> >> >> >>>not
>> >> >> >>> >>>>> >>"jake" on
>> >> >> >>> >>>>> >> >> its
>> >> >> >>> >>>>> >> >> > >> own - gonna try to figure it out.
>> >> >> >>> >>>>> >> >> > >>
>> >> >> >>> >>>>> >> >> > >> On 4/12/12 2:21 PM, "Shazron" <
>> shazron@gmail.com>
>> >> >> >>>wrote:
>> >> >> >>> >>>>> >> >> > >>
>> >> >> >>> >>>>> >> >> > >>>I'm good with tagging. iOS has a few commits
>> (one
>> >> >> >>>commit
>> >> >> >>> >>>>>in
>> >> >> >>> >>>>> >> >> > >>>cordova-js) as well. Aim for first thing
>> tomorrow
>> >> for
>> >> >> >>>you
>> >> >> >>> >>>>>to
>> >> >> >>> >>>>> >> >> > >>>repackage?
>> >> >> >>> >>>>> >> >> > >>>
>> >> >> >>> >>>>> >> >> > >>>On Thu, Apr 12, 2012 at 2:17 PM, Steven Gill
>> >> >> >>> >>>>> >> >><st...@gmail.com>
>> >> >> >>> >>>>> >> >> > >>>wrote:
>> >> >> >>> >>>>> >> >> > >>>> So a bug has been discovered in Cordova
>> Android
>> >> that
>> >> >> >>> >>>>>requires
>> >> >> >>> >>>>> >>a
>> >> >> >>> >>>>> >> >>new
>> >> >> >>> >>>>> >> >> > tag
>> >> >> >>> >>>>> >> >> > >>>>and
>> >> >> >>> >>>>> >> >> > >>>> release. You can check out the bug on the
>> issue
>> >> >> >>>tracker
>> >> >> >>> >>>>>at
>> >> >> >>> >>>>> >> >> > >>>>
>> >> >> >>> >>>>> >> >> > >>>>
>> >> >> >>> >>>>> >> >> >
>> >> >> >>> >>>>> >> >>
>> >> >> >>> >>>>> >> >>
>> >> >> >>> >>>>> >>
>> >> >> >>> >>>>> >>
>> >> >> >>> >>>>>
>> >> >> >>> >>>>>
>> >> >> >>>
>> >> >>
>> https://issues.apache.org/jira/browse/CB-490?focusedCommentId=13252809#
>> >> >> >>> >>>>>co
>> >> >> >>> >>>>> >> >> > >>>>mment-13252809
>> >> >> >>> >>>>> >> >> > >>>>
>> >> >> >>> >>>>> >> >> > >>>> It doesn't make sense to just repackage 1.6.0
>> >> with
>> >> >> >>>this
>> >> >> >>> >>>>>bug
>> >> >> >>> >>>>> >> >>fixed as
>> >> >> >>> >>>>> >> >> > we
>> >> >> >>> >>>>> >> >> > >>>> will have no way to know if people are
>> >> experiencing
>> >> >> >>>this
>> >> >> >>> >>>>>or
>> >> >> >>> >>>>> >>not.
>> >> >> >>> >>>>> >> >> > >>>>
>> >> >> >>> >>>>> >> >> > >>>> Anis mentioned Bada also had some major issues
>> >> >> >>>which he
>> >> >> >>> >>>>>has
>> >> >> >>> >>>>> >>fixed
>> >> >> >>> >>>>> >> >> now
>> >> >> >>> >>>>> >> >> > >>>>and
>> >> >> >>> >>>>> >> >> > >>>> would like in a 1.6.1 release.
>> >> >> >>> >>>>> >> >> > >>>>
>> >> >> >>> >>>>> >> >> > >>>> Thoughts?
>> >> >> >>> >>>>> >> >> > >>>>
>> >> >> >>> >>>>> >> >> > >>>> -Steve
>> >> >> >>> >>>>> >> >> > >>
>> >> >> >>> >>>>> >> >> >
>> >> >> >>> >>>>> >> >>
>> >> >> >>> >>>>> >>
>> >> >> >>> >>>>> >>
>> >> >> >>> >>>>>
>> >> >> >>> >>>>>
>> >> >> >>> >>>
>> >> >> >>> >
>> >> >> >>>
>> >> >>
>> >> >>
>> >>
>>
Re: 1.6.1
Posted by Filip Maj <fi...@adobe.com>.
>Is it too much to drop the new commit that changed the common js API, and
>reapply it after we tag 1.6.1, and figure this one thing out for 1.7?
That sounds very good to me but I am under the impression that iOS
requires this commit? Like I said I'm quite confused.
>
>I also have some cordova-js commits to add to 1.6.1? Although nothing that
>modifies any js outside of what is built for wp7. ( ie, all in my platform
>specific plugins folder )
>
O then it sounds like I tagged the JS 1.6.1 too early anyways..
>
>
>
>On Thu, Apr 12, 2012 at 3:51 PM, Shazron <sh...@gmail.com> wrote:
>
>> No - it's about a user's contribution being noted (it exists), I will
>> move it out of the common code post-1.6.1 (I acknowledge my mistake in
>> allowing it in the first place). Can we branch off 1.6.0 then
>> cherry-pick Fil's latest fix for 1.6.1?
>>
>> On Thu, Apr 12, 2012 at 3:47 PM, Joe Bowser <bo...@gmail.com> wrote:
>> > OK, so you're proposing that we leave the thing in the common JS, even
>> > though it's not supposed to be there.
>> >
>> > On Thu, Apr 12, 2012 at 3:45 PM, Shazron <sh...@gmail.com> wrote:
>> >
>> >> Will rebasing lose that commit? Then, no.
>> >>
>> >> On Thu, Apr 12, 2012 at 3:43 PM, Joe Bowser <bo...@gmail.com>
>>wrote:
>> >> > So, can we just rebase the head, push this out and get this
>>rolling?
>> >> >
>> >> > On Thu, Apr 12, 2012 at 3:43 PM, Filip Maj <fi...@adobe.com> wrote:
>> >> >
>> >> >> Correct, those iOS-specific parameters (like allow edit and those
>> ones)
>> >> >> existed prior to cordova-js, so yeah, we left them in there as we
>> didn't
>> >> >> want to remove without deprecation.
>> >> >>
>> >> >> If you can deal with the iOS issue without needing an API
>>extension:
>> >> then
>> >> >> do that. If not, leave it in there, but docs need to updated too.
>> >> >>
>> >> >> Extending and changing the public API is a long and difficult
>>process
>> >> for
>> >> >> us and will only get tougher with every platform we add support
>>to.
>> >> >>
>> >> >> On 4/12/12 3:37 PM, "Shazron" <sh...@gmail.com> wrote:
>> >> >>
>> >> >> >Then we have to scrap the other three(?) iOS parameters ones that
>> >> >> >already exist in common if you noticed. Don't know how we merge
>> >> >> >(unmerge?) this one properly because taking those out will break
>> >> >> >everyone that is using it, but a deprecation is the way to go as
>>per
>> >> >> >http://wiki.apache.org/cordova/DeprecationPolicy . We can remove
>> this
>> >> >> >new commit and I'll find a way to get this in somehow.
>> >> >> >
>> >> >> >
>> >> >> >
>> >> >> >On Thu, Apr 12, 2012 at 3:32 PM, Joe Bowser <bo...@gmail.com>
>> wrote:
>> >> >> >> The problem is that this parameter doesn't belong in the common
>> API.
>> >> >> >>It'd
>> >> >> >> be just ignored in Android, but the whole point of cordova-js
>>is
>> so
>> >> that
>> >> >> >> it's common. It'd look pretty screwed up to add this to the
>>docs,
>> >> IMO.
>> >> >> >>
>> >> >> >> On Thu, Apr 12, 2012 at 3:26 PM, Shazron <sh...@gmail.com>
>> wrote:
>> >> >> >>
>> >> >> >>> To fix two bugs for Camera.takePicture on iOS
>> >> >> >>>
>> >> >> >>> On Thu, Apr 12, 2012 at 3:24 PM, Filip Maj <fi...@adobe.com>
>> wrote:
>> >> >> >>> > so what's the point of this new parameter?
>> >> >> >>> >
>> >> >> >>> > On 4/12/12 3:16 PM, "Shazron" <sh...@gmail.com> wrote:
>> >> >> >>> >
>> >> >> >>> >>I did. Do we want to revert the cordova-js? I can branch
>>1.6.0
>> and
>> >> >> >>> >>cherry-pick your latest commit for 1.6.1
>> >> >> >>> >>
>> >> >> >>> >>On Thu, Apr 12, 2012 at 3:04 PM, Filip Maj <fi...@adobe.com>
>> wrote:
>> >> >> >>> >>> I saw something in the iOS commit logs for this.
>> >> >> >>> >>>
>> >> >> >>> >>> Shaz can you comment?
>> >> >> >>> >>>
>> >> >> >>> >>> On 4/12/12 2:59 PM, "Joe Bowser" <bo...@gmail.com>
>>wrote:
>> >> >> >>> >>>
>> >> >> >>> >>>>Can we revert this, since this looks like it's intended
>>for
>> both
>> >> >> >>> Android
>> >> >> >>> >>>>and iOS, but I don't think it should be in 1.6.1.
>> >> >> >>> >>>>
>> >> >> >>> >>>>On Thu, Apr 12, 2012 at 2:52 PM, Filip Maj <fi...@adobe.com>
>> >> wrote:
>> >> >> >>> >>>>
>> >> >> >>> >>>>> I was actually just looking at that myself.
>> >> >> >>> >>>>>
>> >> >> >>> >>>>> Looks like it's an iOS-only param.. sigh. We gotta stop
>> doing
>> >> >> >>>that,
>> >> >> >>> >>>>> especially if we don't update documentation.
>> >> >> >>> >>>>>
>> >> >> >>> >>>>> On 4/12/12 2:49 PM, "Joe Bowser" <bo...@gmail.com>
>> wrote:
>> >> >> >>> >>>>>
>> >> >> >>> >>>>> >Has anyone tested the cropToSize param for
>> Camera.getPicture
>> >> >> >>>yet? I
>> >> >> >>> >>>>> >didn't
>> >> >> >>> >>>>> >notice that change until now.
>> >> >> >>> >>>>> >
>> >> >> >>> >>>>> >On Thu, Apr 12, 2012 at 2:46 PM, Filip Maj
>><fil@adobe.com
>> >
>> >> >> >>>wrote:
>> >> >> >>> >>>>> >
>> >> >> >>> >>>>> >> JS tagged 1.6.1 - the build task in the JS should
>>work
>> >> >> >>>properly
>> >> >> >>> >>>>>now.
>> >> >> >>> >>>>> >>
>> >> >> >>> >>>>> >> FYI if anyone has to modify the jake tasks in the
>>future
>> >> and
>> >> >> >>>make
>> >> >> >>> >>>>>them
>> >> >> >>> >>>>> >> async, make sure you add the 4th "async" parameter to
>> the
>> >> >> >>>task()
>> >> >> >>> >>>>> >>function
>> >> >> >>> >>>>> >> and set it to true, and call complete() when the
>>task is
>> >> done.
>> >> >> >>> >>>>> >>
>> >> >> >>> >>>>> >> See
>> http://howtonode.org/intro-to-jake/async-jakefile.jsfor
>> >> >> >>>an
>> >> >> >>> >>>>> example.
>> >> >> >>> >>>>> >>
>> >> >> >>> >>>>> >> On 4/12/12 2:35 PM, "Joe Bowser" <bo...@gmail.com>
>> >> wrote:
>> >> >> >>> >>>>> >>
>> >> >> >>> >>>>> >> >Ready to tag once cordova-js is tagged 1.6.1.
>> >> >> >>> >>>>> >> >
>> >> >> >>> >>>>> >> >On Thu, Apr 12, 2012 at 2:33 PM, Anis KADRI <
>> >> >> >>> anis.kadri@gmail.com>
>> >> >> >>> >>>>> >>wrote:
>> >> >> >>> >>>>> >> >
>> >> >> >>> >>>>> >> >> I will tag my repository to 1.6.1 before end of
>>day
>> >> today
>> >> >> >>>after
>> >> >> >>> >>>>>some
>> >> >> >>> >>>>> >> >> thorough testing.
>> >> >> >>> >>>>> >> >>
>> >> >> >>> >>>>> >> >> On Thu, Apr 12, 2012 at 2:30 PM, Shazron
>> >> >> >>><sh...@gmail.com>
>> >> >> >>> >>>>>wrote:
>> >> >> >>> >>>>> >> >>
>> >> >> >>> >>>>> >> >> > I also created a 1.6.1 version tag as well in
>> jira...
>> >> >> >>> >>>>> >> >> >
>> >> >> >>> >>>>> >> >> > On Thu, Apr 12, 2012 at 2:29 PM, Shazron
>> >> >> >>><sh...@gmail.com>
>> >> >> >>> >>>>> wrote:
>> >> >> >>> >>>>> >> >> > > Alright guys since 1.6.0 was released, I'm
>>going
>> to
>> >> >> >>> >>>>>"Release"
>> >> >> >>> >>>>>the
>> >> >> >>> >>>>> >> >> > > 1.6.0 version in jira and move outstanding
>> issues to
>> >> >> >>>1.7.0
>> >> >> >>> >>>>> >>version
>> >> >> >>> >>>>> >> >> > > tag.
>> >> >> >>> >>>>> >> >> > >
>> >> >> >>> >>>>> >> >> > >
>> >> >> >>> >>>>> >> >> > > On Thu, Apr 12, 2012 at 2:26 PM, Filip Maj
>> >> >> >>><fi...@adobe.com>
>> >> >> >>> >>>>> wrote:
>> >> >> >>> >>>>> >> >> > >> The JS needs patching too. Since adding the
>> commit
>> >> ID
>> >> >> >>>into
>> >> >> >>> >>>>>the
>> >> >> >>> >>>>> >> >> packaging
>> >> >> >>> >>>>> >> >> > >> in the jakefile, the default task isn't
>>running
>> >> >> >>>properly.
>> >> >> >>> >>>>> >> >> > >>
>> >> >> >>> >>>>> >> >> > >> You can manually run "jake build" and "jake
>> test"
>> >> but
>> >> >> >>>not
>> >> >> >>> >>>>> >>"jake" on
>> >> >> >>> >>>>> >> >> its
>> >> >> >>> >>>>> >> >> > >> own - gonna try to figure it out.
>> >> >> >>> >>>>> >> >> > >>
>> >> >> >>> >>>>> >> >> > >> On 4/12/12 2:21 PM, "Shazron" <
>> shazron@gmail.com>
>> >> >> >>>wrote:
>> >> >> >>> >>>>> >> >> > >>
>> >> >> >>> >>>>> >> >> > >>>I'm good with tagging. iOS has a few commits
>> (one
>> >> >> >>>commit
>> >> >> >>> >>>>>in
>> >> >> >>> >>>>> >> >> > >>>cordova-js) as well. Aim for first thing
>> tomorrow
>> >> for
>> >> >> >>>you
>> >> >> >>> >>>>>to
>> >> >> >>> >>>>> >> >> > >>>repackage?
>> >> >> >>> >>>>> >> >> > >>>
>> >> >> >>> >>>>> >> >> > >>>On Thu, Apr 12, 2012 at 2:17 PM, Steven Gill
>> >> >> >>> >>>>> >> >><st...@gmail.com>
>> >> >> >>> >>>>> >> >> > >>>wrote:
>> >> >> >>> >>>>> >> >> > >>>> So a bug has been discovered in Cordova
>> Android
>> >> that
>> >> >> >>> >>>>>requires
>> >> >> >>> >>>>> >>a
>> >> >> >>> >>>>> >> >>new
>> >> >> >>> >>>>> >> >> > tag
>> >> >> >>> >>>>> >> >> > >>>>and
>> >> >> >>> >>>>> >> >> > >>>> release. You can check out the bug on the
>> issue
>> >> >> >>>tracker
>> >> >> >>> >>>>>at
>> >> >> >>> >>>>> >> >> > >>>>
>> >> >> >>> >>>>> >> >> > >>>>
>> >> >> >>> >>>>> >> >> >
>> >> >> >>> >>>>> >> >>
>> >> >> >>> >>>>> >> >>
>> >> >> >>> >>>>> >>
>> >> >> >>> >>>>> >>
>> >> >> >>> >>>>>
>> >> >> >>> >>>>>
>> >> >> >>>
>> >> >>
>> https://issues.apache.org/jira/browse/CB-490?focusedCommentId=13252809#
>> >> >> >>> >>>>>co
>> >> >> >>> >>>>> >> >> > >>>>mment-13252809
>> >> >> >>> >>>>> >> >> > >>>>
>> >> >> >>> >>>>> >> >> > >>>> It doesn't make sense to just repackage
>>1.6.0
>> >> with
>> >> >> >>>this
>> >> >> >>> >>>>>bug
>> >> >> >>> >>>>> >> >>fixed as
>> >> >> >>> >>>>> >> >> > we
>> >> >> >>> >>>>> >> >> > >>>> will have no way to know if people are
>> >> experiencing
>> >> >> >>>this
>> >> >> >>> >>>>>or
>> >> >> >>> >>>>> >>not.
>> >> >> >>> >>>>> >> >> > >>>>
>> >> >> >>> >>>>> >> >> > >>>> Anis mentioned Bada also had some major
>>issues
>> >> >> >>>which he
>> >> >> >>> >>>>>has
>> >> >> >>> >>>>> >>fixed
>> >> >> >>> >>>>> >> >> now
>> >> >> >>> >>>>> >> >> > >>>>and
>> >> >> >>> >>>>> >> >> > >>>> would like in a 1.6.1 release.
>> >> >> >>> >>>>> >> >> > >>>>
>> >> >> >>> >>>>> >> >> > >>>> Thoughts?
>> >> >> >>> >>>>> >> >> > >>>>
>> >> >> >>> >>>>> >> >> > >>>> -Steve
>> >> >> >>> >>>>> >> >> > >>
>> >> >> >>> >>>>> >> >> >
>> >> >> >>> >>>>> >> >>
>> >> >> >>> >>>>> >>
>> >> >> >>> >>>>> >>
>> >> >> >>> >>>>>
>> >> >> >>> >>>>>
>> >> >> >>> >>>
>> >> >> >>> >
>> >> >> >>>
>> >> >>
>> >> >>
>> >>
>>
Re: 1.6.1
Posted by Jesse <pu...@gmail.com>.
Is it too much to drop the new commit that changed the common js API, and
reapply it after we tag 1.6.1, and figure this one thing out for 1.7?
I also have some cordova-js commits to add to 1.6.1? Although nothing that
modifies any js outside of what is built for wp7. ( ie, all in my platform
specific plugins folder )
On Thu, Apr 12, 2012 at 3:51 PM, Shazron <sh...@gmail.com> wrote:
> No - it's about a user's contribution being noted (it exists), I will
> move it out of the common code post-1.6.1 (I acknowledge my mistake in
> allowing it in the first place). Can we branch off 1.6.0 then
> cherry-pick Fil's latest fix for 1.6.1?
>
> On Thu, Apr 12, 2012 at 3:47 PM, Joe Bowser <bo...@gmail.com> wrote:
> > OK, so you're proposing that we leave the thing in the common JS, even
> > though it's not supposed to be there.
> >
> > On Thu, Apr 12, 2012 at 3:45 PM, Shazron <sh...@gmail.com> wrote:
> >
> >> Will rebasing lose that commit? Then, no.
> >>
> >> On Thu, Apr 12, 2012 at 3:43 PM, Joe Bowser <bo...@gmail.com> wrote:
> >> > So, can we just rebase the head, push this out and get this rolling?
> >> >
> >> > On Thu, Apr 12, 2012 at 3:43 PM, Filip Maj <fi...@adobe.com> wrote:
> >> >
> >> >> Correct, those iOS-specific parameters (like allow edit and those
> ones)
> >> >> existed prior to cordova-js, so yeah, we left them in there as we
> didn't
> >> >> want to remove without deprecation.
> >> >>
> >> >> If you can deal with the iOS issue without needing an API extension:
> >> then
> >> >> do that. If not, leave it in there, but docs need to updated too.
> >> >>
> >> >> Extending and changing the public API is a long and difficult process
> >> for
> >> >> us and will only get tougher with every platform we add support to.
> >> >>
> >> >> On 4/12/12 3:37 PM, "Shazron" <sh...@gmail.com> wrote:
> >> >>
> >> >> >Then we have to scrap the other three(?) iOS parameters ones that
> >> >> >already exist in common if you noticed. Don't know how we merge
> >> >> >(unmerge?) this one properly because taking those out will break
> >> >> >everyone that is using it, but a deprecation is the way to go as per
> >> >> >http://wiki.apache.org/cordova/DeprecationPolicy . We can remove
> this
> >> >> >new commit and I'll find a way to get this in somehow.
> >> >> >
> >> >> >
> >> >> >
> >> >> >On Thu, Apr 12, 2012 at 3:32 PM, Joe Bowser <bo...@gmail.com>
> wrote:
> >> >> >> The problem is that this parameter doesn't belong in the common
> API.
> >> >> >>It'd
> >> >> >> be just ignored in Android, but the whole point of cordova-js is
> so
> >> that
> >> >> >> it's common. It'd look pretty screwed up to add this to the docs,
> >> IMO.
> >> >> >>
> >> >> >> On Thu, Apr 12, 2012 at 3:26 PM, Shazron <sh...@gmail.com>
> wrote:
> >> >> >>
> >> >> >>> To fix two bugs for Camera.takePicture on iOS
> >> >> >>>
> >> >> >>> On Thu, Apr 12, 2012 at 3:24 PM, Filip Maj <fi...@adobe.com>
> wrote:
> >> >> >>> > so what's the point of this new parameter?
> >> >> >>> >
> >> >> >>> > On 4/12/12 3:16 PM, "Shazron" <sh...@gmail.com> wrote:
> >> >> >>> >
> >> >> >>> >>I did. Do we want to revert the cordova-js? I can branch 1.6.0
> and
> >> >> >>> >>cherry-pick your latest commit for 1.6.1
> >> >> >>> >>
> >> >> >>> >>On Thu, Apr 12, 2012 at 3:04 PM, Filip Maj <fi...@adobe.com>
> wrote:
> >> >> >>> >>> I saw something in the iOS commit logs for this.
> >> >> >>> >>>
> >> >> >>> >>> Shaz can you comment?
> >> >> >>> >>>
> >> >> >>> >>> On 4/12/12 2:59 PM, "Joe Bowser" <bo...@gmail.com> wrote:
> >> >> >>> >>>
> >> >> >>> >>>>Can we revert this, since this looks like it's intended for
> both
> >> >> >>> Android
> >> >> >>> >>>>and iOS, but I don't think it should be in 1.6.1.
> >> >> >>> >>>>
> >> >> >>> >>>>On Thu, Apr 12, 2012 at 2:52 PM, Filip Maj <fi...@adobe.com>
> >> wrote:
> >> >> >>> >>>>
> >> >> >>> >>>>> I was actually just looking at that myself.
> >> >> >>> >>>>>
> >> >> >>> >>>>> Looks like it's an iOS-only param.. sigh. We gotta stop
> doing
> >> >> >>>that,
> >> >> >>> >>>>> especially if we don't update documentation.
> >> >> >>> >>>>>
> >> >> >>> >>>>> On 4/12/12 2:49 PM, "Joe Bowser" <bo...@gmail.com>
> wrote:
> >> >> >>> >>>>>
> >> >> >>> >>>>> >Has anyone tested the cropToSize param for
> Camera.getPicture
> >> >> >>>yet? I
> >> >> >>> >>>>> >didn't
> >> >> >>> >>>>> >notice that change until now.
> >> >> >>> >>>>> >
> >> >> >>> >>>>> >On Thu, Apr 12, 2012 at 2:46 PM, Filip Maj <fil@adobe.com
> >
> >> >> >>>wrote:
> >> >> >>> >>>>> >
> >> >> >>> >>>>> >> JS tagged 1.6.1 - the build task in the JS should work
> >> >> >>>properly
> >> >> >>> >>>>>now.
> >> >> >>> >>>>> >>
> >> >> >>> >>>>> >> FYI if anyone has to modify the jake tasks in the future
> >> and
> >> >> >>>make
> >> >> >>> >>>>>them
> >> >> >>> >>>>> >> async, make sure you add the 4th "async" parameter to
> the
> >> >> >>>task()
> >> >> >>> >>>>> >>function
> >> >> >>> >>>>> >> and set it to true, and call complete() when the task is
> >> done.
> >> >> >>> >>>>> >>
> >> >> >>> >>>>> >> See
> http://howtonode.org/intro-to-jake/async-jakefile.jsfor
> >> >> >>>an
> >> >> >>> >>>>> example.
> >> >> >>> >>>>> >>
> >> >> >>> >>>>> >> On 4/12/12 2:35 PM, "Joe Bowser" <bo...@gmail.com>
> >> wrote:
> >> >> >>> >>>>> >>
> >> >> >>> >>>>> >> >Ready to tag once cordova-js is tagged 1.6.1.
> >> >> >>> >>>>> >> >
> >> >> >>> >>>>> >> >On Thu, Apr 12, 2012 at 2:33 PM, Anis KADRI <
> >> >> >>> anis.kadri@gmail.com>
> >> >> >>> >>>>> >>wrote:
> >> >> >>> >>>>> >> >
> >> >> >>> >>>>> >> >> I will tag my repository to 1.6.1 before end of day
> >> today
> >> >> >>>after
> >> >> >>> >>>>>some
> >> >> >>> >>>>> >> >> thorough testing.
> >> >> >>> >>>>> >> >>
> >> >> >>> >>>>> >> >> On Thu, Apr 12, 2012 at 2:30 PM, Shazron
> >> >> >>><sh...@gmail.com>
> >> >> >>> >>>>>wrote:
> >> >> >>> >>>>> >> >>
> >> >> >>> >>>>> >> >> > I also created a 1.6.1 version tag as well in
> jira...
> >> >> >>> >>>>> >> >> >
> >> >> >>> >>>>> >> >> > On Thu, Apr 12, 2012 at 2:29 PM, Shazron
> >> >> >>><sh...@gmail.com>
> >> >> >>> >>>>> wrote:
> >> >> >>> >>>>> >> >> > > Alright guys since 1.6.0 was released, I'm going
> to
> >> >> >>> >>>>>"Release"
> >> >> >>> >>>>>the
> >> >> >>> >>>>> >> >> > > 1.6.0 version in jira and move outstanding
> issues to
> >> >> >>>1.7.0
> >> >> >>> >>>>> >>version
> >> >> >>> >>>>> >> >> > > tag.
> >> >> >>> >>>>> >> >> > >
> >> >> >>> >>>>> >> >> > >
> >> >> >>> >>>>> >> >> > > On Thu, Apr 12, 2012 at 2:26 PM, Filip Maj
> >> >> >>><fi...@adobe.com>
> >> >> >>> >>>>> wrote:
> >> >> >>> >>>>> >> >> > >> The JS needs patching too. Since adding the
> commit
> >> ID
> >> >> >>>into
> >> >> >>> >>>>>the
> >> >> >>> >>>>> >> >> packaging
> >> >> >>> >>>>> >> >> > >> in the jakefile, the default task isn't running
> >> >> >>>properly.
> >> >> >>> >>>>> >> >> > >>
> >> >> >>> >>>>> >> >> > >> You can manually run "jake build" and "jake
> test"
> >> but
> >> >> >>>not
> >> >> >>> >>>>> >>"jake" on
> >> >> >>> >>>>> >> >> its
> >> >> >>> >>>>> >> >> > >> own - gonna try to figure it out.
> >> >> >>> >>>>> >> >> > >>
> >> >> >>> >>>>> >> >> > >> On 4/12/12 2:21 PM, "Shazron" <
> shazron@gmail.com>
> >> >> >>>wrote:
> >> >> >>> >>>>> >> >> > >>
> >> >> >>> >>>>> >> >> > >>>I'm good with tagging. iOS has a few commits
> (one
> >> >> >>>commit
> >> >> >>> >>>>>in
> >> >> >>> >>>>> >> >> > >>>cordova-js) as well. Aim for first thing
> tomorrow
> >> for
> >> >> >>>you
> >> >> >>> >>>>>to
> >> >> >>> >>>>> >> >> > >>>repackage?
> >> >> >>> >>>>> >> >> > >>>
> >> >> >>> >>>>> >> >> > >>>On Thu, Apr 12, 2012 at 2:17 PM, Steven Gill
> >> >> >>> >>>>> >> >><st...@gmail.com>
> >> >> >>> >>>>> >> >> > >>>wrote:
> >> >> >>> >>>>> >> >> > >>>> So a bug has been discovered in Cordova
> Android
> >> that
> >> >> >>> >>>>>requires
> >> >> >>> >>>>> >>a
> >> >> >>> >>>>> >> >>new
> >> >> >>> >>>>> >> >> > tag
> >> >> >>> >>>>> >> >> > >>>>and
> >> >> >>> >>>>> >> >> > >>>> release. You can check out the bug on the
> issue
> >> >> >>>tracker
> >> >> >>> >>>>>at
> >> >> >>> >>>>> >> >> > >>>>
> >> >> >>> >>>>> >> >> > >>>>
> >> >> >>> >>>>> >> >> >
> >> >> >>> >>>>> >> >>
> >> >> >>> >>>>> >> >>
> >> >> >>> >>>>> >>
> >> >> >>> >>>>> >>
> >> >> >>> >>>>>
> >> >> >>> >>>>>
> >> >> >>>
> >> >>
> https://issues.apache.org/jira/browse/CB-490?focusedCommentId=13252809#
> >> >> >>> >>>>>co
> >> >> >>> >>>>> >> >> > >>>>mment-13252809
> >> >> >>> >>>>> >> >> > >>>>
> >> >> >>> >>>>> >> >> > >>>> It doesn't make sense to just repackage 1.6.0
> >> with
> >> >> >>>this
> >> >> >>> >>>>>bug
> >> >> >>> >>>>> >> >>fixed as
> >> >> >>> >>>>> >> >> > we
> >> >> >>> >>>>> >> >> > >>>> will have no way to know if people are
> >> experiencing
> >> >> >>>this
> >> >> >>> >>>>>or
> >> >> >>> >>>>> >>not.
> >> >> >>> >>>>> >> >> > >>>>
> >> >> >>> >>>>> >> >> > >>>> Anis mentioned Bada also had some major issues
> >> >> >>>which he
> >> >> >>> >>>>>has
> >> >> >>> >>>>> >>fixed
> >> >> >>> >>>>> >> >> now
> >> >> >>> >>>>> >> >> > >>>>and
> >> >> >>> >>>>> >> >> > >>>> would like in a 1.6.1 release.
> >> >> >>> >>>>> >> >> > >>>>
> >> >> >>> >>>>> >> >> > >>>> Thoughts?
> >> >> >>> >>>>> >> >> > >>>>
> >> >> >>> >>>>> >> >> > >>>> -Steve
> >> >> >>> >>>>> >> >> > >>
> >> >> >>> >>>>> >> >> >
> >> >> >>> >>>>> >> >>
> >> >> >>> >>>>> >>
> >> >> >>> >>>>> >>
> >> >> >>> >>>>>
> >> >> >>> >>>>>
> >> >> >>> >>>
> >> >> >>> >
> >> >> >>>
> >> >>
> >> >>
> >>
>
Re: 1.6.1
Posted by Filip Maj <fi...@adobe.com>.
I'm so confused now as to what's going on that I no longer know lol
On 4/12/12 3:51 PM, "Shazron" <sh...@gmail.com> wrote:
>No - it's about a user's contribution being noted (it exists), I will
>move it out of the common code post-1.6.1 (I acknowledge my mistake in
>allowing it in the first place). Can we branch off 1.6.0 then
>cherry-pick Fil's latest fix for 1.6.1?
>
>On Thu, Apr 12, 2012 at 3:47 PM, Joe Bowser <bo...@gmail.com> wrote:
>> OK, so you're proposing that we leave the thing in the common JS, even
>> though it's not supposed to be there.
>>
>> On Thu, Apr 12, 2012 at 3:45 PM, Shazron <sh...@gmail.com> wrote:
>>
>>> Will rebasing lose that commit? Then, no.
>>>
>>> On Thu, Apr 12, 2012 at 3:43 PM, Joe Bowser <bo...@gmail.com> wrote:
>>> > So, can we just rebase the head, push this out and get this rolling?
>>> >
>>> > On Thu, Apr 12, 2012 at 3:43 PM, Filip Maj <fi...@adobe.com> wrote:
>>> >
>>> >> Correct, those iOS-specific parameters (like allow edit and those
>>>ones)
>>> >> existed prior to cordova-js, so yeah, we left them in there as we
>>>didn't
>>> >> want to remove without deprecation.
>>> >>
>>> >> If you can deal with the iOS issue without needing an API extension:
>>> then
>>> >> do that. If not, leave it in there, but docs need to updated too.
>>> >>
>>> >> Extending and changing the public API is a long and difficult
>>>process
>>> for
>>> >> us and will only get tougher with every platform we add support to.
>>> >>
>>> >> On 4/12/12 3:37 PM, "Shazron" <sh...@gmail.com> wrote:
>>> >>
>>> >> >Then we have to scrap the other three(?) iOS parameters ones that
>>> >> >already exist in common if you noticed. Don't know how we merge
>>> >> >(unmerge?) this one properly because taking those out will break
>>> >> >everyone that is using it, but a deprecation is the way to go as
>>>per
>>> >> >http://wiki.apache.org/cordova/DeprecationPolicy . We can remove
>>>this
>>> >> >new commit and I'll find a way to get this in somehow.
>>> >> >
>>> >> >
>>> >> >
>>> >> >On Thu, Apr 12, 2012 at 3:32 PM, Joe Bowser <bo...@gmail.com>
>>>wrote:
>>> >> >> The problem is that this parameter doesn't belong in the common
>>>API.
>>> >> >>It'd
>>> >> >> be just ignored in Android, but the whole point of cordova-js is
>>>so
>>> that
>>> >> >> it's common. It'd look pretty screwed up to add this to the
>>>docs,
>>> IMO.
>>> >> >>
>>> >> >> On Thu, Apr 12, 2012 at 3:26 PM, Shazron <sh...@gmail.com>
>>>wrote:
>>> >> >>
>>> >> >>> To fix two bugs for Camera.takePicture on iOS
>>> >> >>>
>>> >> >>> On Thu, Apr 12, 2012 at 3:24 PM, Filip Maj <fi...@adobe.com>
>>>wrote:
>>> >> >>> > so what's the point of this new parameter?
>>> >> >>> >
>>> >> >>> > On 4/12/12 3:16 PM, "Shazron" <sh...@gmail.com> wrote:
>>> >> >>> >
>>> >> >>> >>I did. Do we want to revert the cordova-js? I can branch
>>>1.6.0 and
>>> >> >>> >>cherry-pick your latest commit for 1.6.1
>>> >> >>> >>
>>> >> >>> >>On Thu, Apr 12, 2012 at 3:04 PM, Filip Maj <fi...@adobe.com>
>>>wrote:
>>> >> >>> >>> I saw something in the iOS commit logs for this.
>>> >> >>> >>>
>>> >> >>> >>> Shaz can you comment?
>>> >> >>> >>>
>>> >> >>> >>> On 4/12/12 2:59 PM, "Joe Bowser" <bo...@gmail.com> wrote:
>>> >> >>> >>>
>>> >> >>> >>>>Can we revert this, since this looks like it's intended for
>>>both
>>> >> >>> Android
>>> >> >>> >>>>and iOS, but I don't think it should be in 1.6.1.
>>> >> >>> >>>>
>>> >> >>> >>>>On Thu, Apr 12, 2012 at 2:52 PM, Filip Maj <fi...@adobe.com>
>>> wrote:
>>> >> >>> >>>>
>>> >> >>> >>>>> I was actually just looking at that myself.
>>> >> >>> >>>>>
>>> >> >>> >>>>> Looks like it's an iOS-only param.. sigh. We gotta stop
>>>doing
>>> >> >>>that,
>>> >> >>> >>>>> especially if we don't update documentation.
>>> >> >>> >>>>>
>>> >> >>> >>>>> On 4/12/12 2:49 PM, "Joe Bowser" <bo...@gmail.com>
>>>wrote:
>>> >> >>> >>>>>
>>> >> >>> >>>>> >Has anyone tested the cropToSize param for
>>>Camera.getPicture
>>> >> >>>yet? I
>>> >> >>> >>>>> >didn't
>>> >> >>> >>>>> >notice that change until now.
>>> >> >>> >>>>> >
>>> >> >>> >>>>> >On Thu, Apr 12, 2012 at 2:46 PM, Filip Maj
>>><fi...@adobe.com>
>>> >> >>>wrote:
>>> >> >>> >>>>> >
>>> >> >>> >>>>> >> JS tagged 1.6.1 - the build task in the JS should work
>>> >> >>>properly
>>> >> >>> >>>>>now.
>>> >> >>> >>>>> >>
>>> >> >>> >>>>> >> FYI if anyone has to modify the jake tasks in the
>>>future
>>> and
>>> >> >>>make
>>> >> >>> >>>>>them
>>> >> >>> >>>>> >> async, make sure you add the 4th "async" parameter to
>>>the
>>> >> >>>task()
>>> >> >>> >>>>> >>function
>>> >> >>> >>>>> >> and set it to true, and call complete() when the task
>>>is
>>> done.
>>> >> >>> >>>>> >>
>>> >> >>> >>>>> >> See
>>>http://howtonode.org/intro-to-jake/async-jakefile.jsfor
>>> >> >>>an
>>> >> >>> >>>>> example.
>>> >> >>> >>>>> >>
>>> >> >>> >>>>> >> On 4/12/12 2:35 PM, "Joe Bowser" <bo...@gmail.com>
>>> wrote:
>>> >> >>> >>>>> >>
>>> >> >>> >>>>> >> >Ready to tag once cordova-js is tagged 1.6.1.
>>> >> >>> >>>>> >> >
>>> >> >>> >>>>> >> >On Thu, Apr 12, 2012 at 2:33 PM, Anis KADRI <
>>> >> >>> anis.kadri@gmail.com>
>>> >> >>> >>>>> >>wrote:
>>> >> >>> >>>>> >> >
>>> >> >>> >>>>> >> >> I will tag my repository to 1.6.1 before end of day
>>> today
>>> >> >>>after
>>> >> >>> >>>>>some
>>> >> >>> >>>>> >> >> thorough testing.
>>> >> >>> >>>>> >> >>
>>> >> >>> >>>>> >> >> On Thu, Apr 12, 2012 at 2:30 PM, Shazron
>>> >> >>><sh...@gmail.com>
>>> >> >>> >>>>>wrote:
>>> >> >>> >>>>> >> >>
>>> >> >>> >>>>> >> >> > I also created a 1.6.1 version tag as well in
>>>jira...
>>> >> >>> >>>>> >> >> >
>>> >> >>> >>>>> >> >> > On Thu, Apr 12, 2012 at 2:29 PM, Shazron
>>> >> >>><sh...@gmail.com>
>>> >> >>> >>>>> wrote:
>>> >> >>> >>>>> >> >> > > Alright guys since 1.6.0 was released, I'm
>>>going to
>>> >> >>> >>>>>"Release"
>>> >> >>> >>>>>the
>>> >> >>> >>>>> >> >> > > 1.6.0 version in jira and move outstanding
>>>issues to
>>> >> >>>1.7.0
>>> >> >>> >>>>> >>version
>>> >> >>> >>>>> >> >> > > tag.
>>> >> >>> >>>>> >> >> > >
>>> >> >>> >>>>> >> >> > >
>>> >> >>> >>>>> >> >> > > On Thu, Apr 12, 2012 at 2:26 PM, Filip Maj
>>> >> >>><fi...@adobe.com>
>>> >> >>> >>>>> wrote:
>>> >> >>> >>>>> >> >> > >> The JS needs patching too. Since adding the
>>>commit
>>> ID
>>> >> >>>into
>>> >> >>> >>>>>the
>>> >> >>> >>>>> >> >> packaging
>>> >> >>> >>>>> >> >> > >> in the jakefile, the default task isn't running
>>> >> >>>properly.
>>> >> >>> >>>>> >> >> > >>
>>> >> >>> >>>>> >> >> > >> You can manually run "jake build" and "jake
>>>test"
>>> but
>>> >> >>>not
>>> >> >>> >>>>> >>"jake" on
>>> >> >>> >>>>> >> >> its
>>> >> >>> >>>>> >> >> > >> own - gonna try to figure it out.
>>> >> >>> >>>>> >> >> > >>
>>> >> >>> >>>>> >> >> > >> On 4/12/12 2:21 PM, "Shazron"
>>><sh...@gmail.com>
>>> >> >>>wrote:
>>> >> >>> >>>>> >> >> > >>
>>> >> >>> >>>>> >> >> > >>>I'm good with tagging. iOS has a few commits
>>>(one
>>> >> >>>commit
>>> >> >>> >>>>>in
>>> >> >>> >>>>> >> >> > >>>cordova-js) as well. Aim for first thing
>>>tomorrow
>>> for
>>> >> >>>you
>>> >> >>> >>>>>to
>>> >> >>> >>>>> >> >> > >>>repackage?
>>> >> >>> >>>>> >> >> > >>>
>>> >> >>> >>>>> >> >> > >>>On Thu, Apr 12, 2012 at 2:17 PM, Steven Gill
>>> >> >>> >>>>> >> >><st...@gmail.com>
>>> >> >>> >>>>> >> >> > >>>wrote:
>>> >> >>> >>>>> >> >> > >>>> So a bug has been discovered in Cordova
>>>Android
>>> that
>>> >> >>> >>>>>requires
>>> >> >>> >>>>> >>a
>>> >> >>> >>>>> >> >>new
>>> >> >>> >>>>> >> >> > tag
>>> >> >>> >>>>> >> >> > >>>>and
>>> >> >>> >>>>> >> >> > >>>> release. You can check out the bug on the
>>>issue
>>> >> >>>tracker
>>> >> >>> >>>>>at
>>> >> >>> >>>>> >> >> > >>>>
>>> >> >>> >>>>> >> >> > >>>>
>>> >> >>> >>>>> >> >> >
>>> >> >>> >>>>> >> >>
>>> >> >>> >>>>> >> >>
>>> >> >>> >>>>> >>
>>> >> >>> >>>>> >>
>>> >> >>> >>>>>
>>> >> >>> >>>>>
>>> >> >>>
>>> >>
>>>https://issues.apache.org/jira/browse/CB-490?focusedCommentId=13252809#
>>> >> >>> >>>>>co
>>> >> >>> >>>>> >> >> > >>>>mment-13252809
>>> >> >>> >>>>> >> >> > >>>>
>>> >> >>> >>>>> >> >> > >>>> It doesn't make sense to just repackage 1.6.0
>>> with
>>> >> >>>this
>>> >> >>> >>>>>bug
>>> >> >>> >>>>> >> >>fixed as
>>> >> >>> >>>>> >> >> > we
>>> >> >>> >>>>> >> >> > >>>> will have no way to know if people are
>>> experiencing
>>> >> >>>this
>>> >> >>> >>>>>or
>>> >> >>> >>>>> >>not.
>>> >> >>> >>>>> >> >> > >>>>
>>> >> >>> >>>>> >> >> > >>>> Anis mentioned Bada also had some major
>>>issues
>>> >> >>>which he
>>> >> >>> >>>>>has
>>> >> >>> >>>>> >>fixed
>>> >> >>> >>>>> >> >> now
>>> >> >>> >>>>> >> >> > >>>>and
>>> >> >>> >>>>> >> >> > >>>> would like in a 1.6.1 release.
>>> >> >>> >>>>> >> >> > >>>>
>>> >> >>> >>>>> >> >> > >>>> Thoughts?
>>> >> >>> >>>>> >> >> > >>>>
>>> >> >>> >>>>> >> >> > >>>> -Steve
>>> >> >>> >>>>> >> >> > >>
>>> >> >>> >>>>> >> >> >
>>> >> >>> >>>>> >> >>
>>> >> >>> >>>>> >>
>>> >> >>> >>>>> >>
>>> >> >>> >>>>>
>>> >> >>> >>>>>
>>> >> >>> >>>
>>> >> >>> >
>>> >> >>>
>>> >>
>>> >>
>>>
Re: 1.6.1
Posted by Shazron <sh...@gmail.com>.
No - it's about a user's contribution being noted (it exists), I will
move it out of the common code post-1.6.1 (I acknowledge my mistake in
allowing it in the first place). Can we branch off 1.6.0 then
cherry-pick Fil's latest fix for 1.6.1?
On Thu, Apr 12, 2012 at 3:47 PM, Joe Bowser <bo...@gmail.com> wrote:
> OK, so you're proposing that we leave the thing in the common JS, even
> though it's not supposed to be there.
>
> On Thu, Apr 12, 2012 at 3:45 PM, Shazron <sh...@gmail.com> wrote:
>
>> Will rebasing lose that commit? Then, no.
>>
>> On Thu, Apr 12, 2012 at 3:43 PM, Joe Bowser <bo...@gmail.com> wrote:
>> > So, can we just rebase the head, push this out and get this rolling?
>> >
>> > On Thu, Apr 12, 2012 at 3:43 PM, Filip Maj <fi...@adobe.com> wrote:
>> >
>> >> Correct, those iOS-specific parameters (like allow edit and those ones)
>> >> existed prior to cordova-js, so yeah, we left them in there as we didn't
>> >> want to remove without deprecation.
>> >>
>> >> If you can deal with the iOS issue without needing an API extension:
>> then
>> >> do that. If not, leave it in there, but docs need to updated too.
>> >>
>> >> Extending and changing the public API is a long and difficult process
>> for
>> >> us and will only get tougher with every platform we add support to.
>> >>
>> >> On 4/12/12 3:37 PM, "Shazron" <sh...@gmail.com> wrote:
>> >>
>> >> >Then we have to scrap the other three(?) iOS parameters ones that
>> >> >already exist in common if you noticed. Don't know how we merge
>> >> >(unmerge?) this one properly because taking those out will break
>> >> >everyone that is using it, but a deprecation is the way to go as per
>> >> >http://wiki.apache.org/cordova/DeprecationPolicy . We can remove this
>> >> >new commit and I'll find a way to get this in somehow.
>> >> >
>> >> >
>> >> >
>> >> >On Thu, Apr 12, 2012 at 3:32 PM, Joe Bowser <bo...@gmail.com> wrote:
>> >> >> The problem is that this parameter doesn't belong in the common API.
>> >> >>It'd
>> >> >> be just ignored in Android, but the whole point of cordova-js is so
>> that
>> >> >> it's common. It'd look pretty screwed up to add this to the docs,
>> IMO.
>> >> >>
>> >> >> On Thu, Apr 12, 2012 at 3:26 PM, Shazron <sh...@gmail.com> wrote:
>> >> >>
>> >> >>> To fix two bugs for Camera.takePicture on iOS
>> >> >>>
>> >> >>> On Thu, Apr 12, 2012 at 3:24 PM, Filip Maj <fi...@adobe.com> wrote:
>> >> >>> > so what's the point of this new parameter?
>> >> >>> >
>> >> >>> > On 4/12/12 3:16 PM, "Shazron" <sh...@gmail.com> wrote:
>> >> >>> >
>> >> >>> >>I did. Do we want to revert the cordova-js? I can branch 1.6.0 and
>> >> >>> >>cherry-pick your latest commit for 1.6.1
>> >> >>> >>
>> >> >>> >>On Thu, Apr 12, 2012 at 3:04 PM, Filip Maj <fi...@adobe.com> wrote:
>> >> >>> >>> I saw something in the iOS commit logs for this.
>> >> >>> >>>
>> >> >>> >>> Shaz can you comment?
>> >> >>> >>>
>> >> >>> >>> On 4/12/12 2:59 PM, "Joe Bowser" <bo...@gmail.com> wrote:
>> >> >>> >>>
>> >> >>> >>>>Can we revert this, since this looks like it's intended for both
>> >> >>> Android
>> >> >>> >>>>and iOS, but I don't think it should be in 1.6.1.
>> >> >>> >>>>
>> >> >>> >>>>On Thu, Apr 12, 2012 at 2:52 PM, Filip Maj <fi...@adobe.com>
>> wrote:
>> >> >>> >>>>
>> >> >>> >>>>> I was actually just looking at that myself.
>> >> >>> >>>>>
>> >> >>> >>>>> Looks like it's an iOS-only param.. sigh. We gotta stop doing
>> >> >>>that,
>> >> >>> >>>>> especially if we don't update documentation.
>> >> >>> >>>>>
>> >> >>> >>>>> On 4/12/12 2:49 PM, "Joe Bowser" <bo...@gmail.com> wrote:
>> >> >>> >>>>>
>> >> >>> >>>>> >Has anyone tested the cropToSize param for Camera.getPicture
>> >> >>>yet? I
>> >> >>> >>>>> >didn't
>> >> >>> >>>>> >notice that change until now.
>> >> >>> >>>>> >
>> >> >>> >>>>> >On Thu, Apr 12, 2012 at 2:46 PM, Filip Maj <fi...@adobe.com>
>> >> >>>wrote:
>> >> >>> >>>>> >
>> >> >>> >>>>> >> JS tagged 1.6.1 - the build task in the JS should work
>> >> >>>properly
>> >> >>> >>>>>now.
>> >> >>> >>>>> >>
>> >> >>> >>>>> >> FYI if anyone has to modify the jake tasks in the future
>> and
>> >> >>>make
>> >> >>> >>>>>them
>> >> >>> >>>>> >> async, make sure you add the 4th "async" parameter to the
>> >> >>>task()
>> >> >>> >>>>> >>function
>> >> >>> >>>>> >> and set it to true, and call complete() when the task is
>> done.
>> >> >>> >>>>> >>
>> >> >>> >>>>> >> See http://howtonode.org/intro-to-jake/async-jakefile.jsfor
>> >> >>>an
>> >> >>> >>>>> example.
>> >> >>> >>>>> >>
>> >> >>> >>>>> >> On 4/12/12 2:35 PM, "Joe Bowser" <bo...@gmail.com>
>> wrote:
>> >> >>> >>>>> >>
>> >> >>> >>>>> >> >Ready to tag once cordova-js is tagged 1.6.1.
>> >> >>> >>>>> >> >
>> >> >>> >>>>> >> >On Thu, Apr 12, 2012 at 2:33 PM, Anis KADRI <
>> >> >>> anis.kadri@gmail.com>
>> >> >>> >>>>> >>wrote:
>> >> >>> >>>>> >> >
>> >> >>> >>>>> >> >> I will tag my repository to 1.6.1 before end of day
>> today
>> >> >>>after
>> >> >>> >>>>>some
>> >> >>> >>>>> >> >> thorough testing.
>> >> >>> >>>>> >> >>
>> >> >>> >>>>> >> >> On Thu, Apr 12, 2012 at 2:30 PM, Shazron
>> >> >>><sh...@gmail.com>
>> >> >>> >>>>>wrote:
>> >> >>> >>>>> >> >>
>> >> >>> >>>>> >> >> > I also created a 1.6.1 version tag as well in jira...
>> >> >>> >>>>> >> >> >
>> >> >>> >>>>> >> >> > On Thu, Apr 12, 2012 at 2:29 PM, Shazron
>> >> >>><sh...@gmail.com>
>> >> >>> >>>>> wrote:
>> >> >>> >>>>> >> >> > > Alright guys since 1.6.0 was released, I'm going to
>> >> >>> >>>>>"Release"
>> >> >>> >>>>>the
>> >> >>> >>>>> >> >> > > 1.6.0 version in jira and move outstanding issues to
>> >> >>>1.7.0
>> >> >>> >>>>> >>version
>> >> >>> >>>>> >> >> > > tag.
>> >> >>> >>>>> >> >> > >
>> >> >>> >>>>> >> >> > >
>> >> >>> >>>>> >> >> > > On Thu, Apr 12, 2012 at 2:26 PM, Filip Maj
>> >> >>><fi...@adobe.com>
>> >> >>> >>>>> wrote:
>> >> >>> >>>>> >> >> > >> The JS needs patching too. Since adding the commit
>> ID
>> >> >>>into
>> >> >>> >>>>>the
>> >> >>> >>>>> >> >> packaging
>> >> >>> >>>>> >> >> > >> in the jakefile, the default task isn't running
>> >> >>>properly.
>> >> >>> >>>>> >> >> > >>
>> >> >>> >>>>> >> >> > >> You can manually run "jake build" and "jake test"
>> but
>> >> >>>not
>> >> >>> >>>>> >>"jake" on
>> >> >>> >>>>> >> >> its
>> >> >>> >>>>> >> >> > >> own - gonna try to figure it out.
>> >> >>> >>>>> >> >> > >>
>> >> >>> >>>>> >> >> > >> On 4/12/12 2:21 PM, "Shazron" <sh...@gmail.com>
>> >> >>>wrote:
>> >> >>> >>>>> >> >> > >>
>> >> >>> >>>>> >> >> > >>>I'm good with tagging. iOS has a few commits (one
>> >> >>>commit
>> >> >>> >>>>>in
>> >> >>> >>>>> >> >> > >>>cordova-js) as well. Aim for first thing tomorrow
>> for
>> >> >>>you
>> >> >>> >>>>>to
>> >> >>> >>>>> >> >> > >>>repackage?
>> >> >>> >>>>> >> >> > >>>
>> >> >>> >>>>> >> >> > >>>On Thu, Apr 12, 2012 at 2:17 PM, Steven Gill
>> >> >>> >>>>> >> >><st...@gmail.com>
>> >> >>> >>>>> >> >> > >>>wrote:
>> >> >>> >>>>> >> >> > >>>> So a bug has been discovered in Cordova Android
>> that
>> >> >>> >>>>>requires
>> >> >>> >>>>> >>a
>> >> >>> >>>>> >> >>new
>> >> >>> >>>>> >> >> > tag
>> >> >>> >>>>> >> >> > >>>>and
>> >> >>> >>>>> >> >> > >>>> release. You can check out the bug on the issue
>> >> >>>tracker
>> >> >>> >>>>>at
>> >> >>> >>>>> >> >> > >>>>
>> >> >>> >>>>> >> >> > >>>>
>> >> >>> >>>>> >> >> >
>> >> >>> >>>>> >> >>
>> >> >>> >>>>> >> >>
>> >> >>> >>>>> >>
>> >> >>> >>>>> >>
>> >> >>> >>>>>
>> >> >>> >>>>>
>> >> >>>
>> >> https://issues.apache.org/jira/browse/CB-490?focusedCommentId=13252809#
>> >> >>> >>>>>co
>> >> >>> >>>>> >> >> > >>>>mment-13252809
>> >> >>> >>>>> >> >> > >>>>
>> >> >>> >>>>> >> >> > >>>> It doesn't make sense to just repackage 1.6.0
>> with
>> >> >>>this
>> >> >>> >>>>>bug
>> >> >>> >>>>> >> >>fixed as
>> >> >>> >>>>> >> >> > we
>> >> >>> >>>>> >> >> > >>>> will have no way to know if people are
>> experiencing
>> >> >>>this
>> >> >>> >>>>>or
>> >> >>> >>>>> >>not.
>> >> >>> >>>>> >> >> > >>>>
>> >> >>> >>>>> >> >> > >>>> Anis mentioned Bada also had some major issues
>> >> >>>which he
>> >> >>> >>>>>has
>> >> >>> >>>>> >>fixed
>> >> >>> >>>>> >> >> now
>> >> >>> >>>>> >> >> > >>>>and
>> >> >>> >>>>> >> >> > >>>> would like in a 1.6.1 release.
>> >> >>> >>>>> >> >> > >>>>
>> >> >>> >>>>> >> >> > >>>> Thoughts?
>> >> >>> >>>>> >> >> > >>>>
>> >> >>> >>>>> >> >> > >>>> -Steve
>> >> >>> >>>>> >> >> > >>
>> >> >>> >>>>> >> >> >
>> >> >>> >>>>> >> >>
>> >> >>> >>>>> >>
>> >> >>> >>>>> >>
>> >> >>> >>>>>
>> >> >>> >>>>>
>> >> >>> >>>
>> >> >>> >
>> >> >>>
>> >>
>> >>
>>
Re: 1.6.1
Posted by Joe Bowser <bo...@gmail.com>.
OK, so you're proposing that we leave the thing in the common JS, even
though it's not supposed to be there.
On Thu, Apr 12, 2012 at 3:45 PM, Shazron <sh...@gmail.com> wrote:
> Will rebasing lose that commit? Then, no.
>
> On Thu, Apr 12, 2012 at 3:43 PM, Joe Bowser <bo...@gmail.com> wrote:
> > So, can we just rebase the head, push this out and get this rolling?
> >
> > On Thu, Apr 12, 2012 at 3:43 PM, Filip Maj <fi...@adobe.com> wrote:
> >
> >> Correct, those iOS-specific parameters (like allow edit and those ones)
> >> existed prior to cordova-js, so yeah, we left them in there as we didn't
> >> want to remove without deprecation.
> >>
> >> If you can deal with the iOS issue without needing an API extension:
> then
> >> do that. If not, leave it in there, but docs need to updated too.
> >>
> >> Extending and changing the public API is a long and difficult process
> for
> >> us and will only get tougher with every platform we add support to.
> >>
> >> On 4/12/12 3:37 PM, "Shazron" <sh...@gmail.com> wrote:
> >>
> >> >Then we have to scrap the other three(?) iOS parameters ones that
> >> >already exist in common if you noticed. Don't know how we merge
> >> >(unmerge?) this one properly because taking those out will break
> >> >everyone that is using it, but a deprecation is the way to go as per
> >> >http://wiki.apache.org/cordova/DeprecationPolicy . We can remove this
> >> >new commit and I'll find a way to get this in somehow.
> >> >
> >> >
> >> >
> >> >On Thu, Apr 12, 2012 at 3:32 PM, Joe Bowser <bo...@gmail.com> wrote:
> >> >> The problem is that this parameter doesn't belong in the common API.
> >> >>It'd
> >> >> be just ignored in Android, but the whole point of cordova-js is so
> that
> >> >> it's common. It'd look pretty screwed up to add this to the docs,
> IMO.
> >> >>
> >> >> On Thu, Apr 12, 2012 at 3:26 PM, Shazron <sh...@gmail.com> wrote:
> >> >>
> >> >>> To fix two bugs for Camera.takePicture on iOS
> >> >>>
> >> >>> On Thu, Apr 12, 2012 at 3:24 PM, Filip Maj <fi...@adobe.com> wrote:
> >> >>> > so what's the point of this new parameter?
> >> >>> >
> >> >>> > On 4/12/12 3:16 PM, "Shazron" <sh...@gmail.com> wrote:
> >> >>> >
> >> >>> >>I did. Do we want to revert the cordova-js? I can branch 1.6.0 and
> >> >>> >>cherry-pick your latest commit for 1.6.1
> >> >>> >>
> >> >>> >>On Thu, Apr 12, 2012 at 3:04 PM, Filip Maj <fi...@adobe.com> wrote:
> >> >>> >>> I saw something in the iOS commit logs for this.
> >> >>> >>>
> >> >>> >>> Shaz can you comment?
> >> >>> >>>
> >> >>> >>> On 4/12/12 2:59 PM, "Joe Bowser" <bo...@gmail.com> wrote:
> >> >>> >>>
> >> >>> >>>>Can we revert this, since this looks like it's intended for both
> >> >>> Android
> >> >>> >>>>and iOS, but I don't think it should be in 1.6.1.
> >> >>> >>>>
> >> >>> >>>>On Thu, Apr 12, 2012 at 2:52 PM, Filip Maj <fi...@adobe.com>
> wrote:
> >> >>> >>>>
> >> >>> >>>>> I was actually just looking at that myself.
> >> >>> >>>>>
> >> >>> >>>>> Looks like it's an iOS-only param.. sigh. We gotta stop doing
> >> >>>that,
> >> >>> >>>>> especially if we don't update documentation.
> >> >>> >>>>>
> >> >>> >>>>> On 4/12/12 2:49 PM, "Joe Bowser" <bo...@gmail.com> wrote:
> >> >>> >>>>>
> >> >>> >>>>> >Has anyone tested the cropToSize param for Camera.getPicture
> >> >>>yet? I
> >> >>> >>>>> >didn't
> >> >>> >>>>> >notice that change until now.
> >> >>> >>>>> >
> >> >>> >>>>> >On Thu, Apr 12, 2012 at 2:46 PM, Filip Maj <fi...@adobe.com>
> >> >>>wrote:
> >> >>> >>>>> >
> >> >>> >>>>> >> JS tagged 1.6.1 - the build task in the JS should work
> >> >>>properly
> >> >>> >>>>>now.
> >> >>> >>>>> >>
> >> >>> >>>>> >> FYI if anyone has to modify the jake tasks in the future
> and
> >> >>>make
> >> >>> >>>>>them
> >> >>> >>>>> >> async, make sure you add the 4th "async" parameter to the
> >> >>>task()
> >> >>> >>>>> >>function
> >> >>> >>>>> >> and set it to true, and call complete() when the task is
> done.
> >> >>> >>>>> >>
> >> >>> >>>>> >> See http://howtonode.org/intro-to-jake/async-jakefile.jsfor
> >> >>>an
> >> >>> >>>>> example.
> >> >>> >>>>> >>
> >> >>> >>>>> >> On 4/12/12 2:35 PM, "Joe Bowser" <bo...@gmail.com>
> wrote:
> >> >>> >>>>> >>
> >> >>> >>>>> >> >Ready to tag once cordova-js is tagged 1.6.1.
> >> >>> >>>>> >> >
> >> >>> >>>>> >> >On Thu, Apr 12, 2012 at 2:33 PM, Anis KADRI <
> >> >>> anis.kadri@gmail.com>
> >> >>> >>>>> >>wrote:
> >> >>> >>>>> >> >
> >> >>> >>>>> >> >> I will tag my repository to 1.6.1 before end of day
> today
> >> >>>after
> >> >>> >>>>>some
> >> >>> >>>>> >> >> thorough testing.
> >> >>> >>>>> >> >>
> >> >>> >>>>> >> >> On Thu, Apr 12, 2012 at 2:30 PM, Shazron
> >> >>><sh...@gmail.com>
> >> >>> >>>>>wrote:
> >> >>> >>>>> >> >>
> >> >>> >>>>> >> >> > I also created a 1.6.1 version tag as well in jira...
> >> >>> >>>>> >> >> >
> >> >>> >>>>> >> >> > On Thu, Apr 12, 2012 at 2:29 PM, Shazron
> >> >>><sh...@gmail.com>
> >> >>> >>>>> wrote:
> >> >>> >>>>> >> >> > > Alright guys since 1.6.0 was released, I'm going to
> >> >>> >>>>>"Release"
> >> >>> >>>>>the
> >> >>> >>>>> >> >> > > 1.6.0 version in jira and move outstanding issues to
> >> >>>1.7.0
> >> >>> >>>>> >>version
> >> >>> >>>>> >> >> > > tag.
> >> >>> >>>>> >> >> > >
> >> >>> >>>>> >> >> > >
> >> >>> >>>>> >> >> > > On Thu, Apr 12, 2012 at 2:26 PM, Filip Maj
> >> >>><fi...@adobe.com>
> >> >>> >>>>> wrote:
> >> >>> >>>>> >> >> > >> The JS needs patching too. Since adding the commit
> ID
> >> >>>into
> >> >>> >>>>>the
> >> >>> >>>>> >> >> packaging
> >> >>> >>>>> >> >> > >> in the jakefile, the default task isn't running
> >> >>>properly.
> >> >>> >>>>> >> >> > >>
> >> >>> >>>>> >> >> > >> You can manually run "jake build" and "jake test"
> but
> >> >>>not
> >> >>> >>>>> >>"jake" on
> >> >>> >>>>> >> >> its
> >> >>> >>>>> >> >> > >> own - gonna try to figure it out.
> >> >>> >>>>> >> >> > >>
> >> >>> >>>>> >> >> > >> On 4/12/12 2:21 PM, "Shazron" <sh...@gmail.com>
> >> >>>wrote:
> >> >>> >>>>> >> >> > >>
> >> >>> >>>>> >> >> > >>>I'm good with tagging. iOS has a few commits (one
> >> >>>commit
> >> >>> >>>>>in
> >> >>> >>>>> >> >> > >>>cordova-js) as well. Aim for first thing tomorrow
> for
> >> >>>you
> >> >>> >>>>>to
> >> >>> >>>>> >> >> > >>>repackage?
> >> >>> >>>>> >> >> > >>>
> >> >>> >>>>> >> >> > >>>On Thu, Apr 12, 2012 at 2:17 PM, Steven Gill
> >> >>> >>>>> >> >><st...@gmail.com>
> >> >>> >>>>> >> >> > >>>wrote:
> >> >>> >>>>> >> >> > >>>> So a bug has been discovered in Cordova Android
> that
> >> >>> >>>>>requires
> >> >>> >>>>> >>a
> >> >>> >>>>> >> >>new
> >> >>> >>>>> >> >> > tag
> >> >>> >>>>> >> >> > >>>>and
> >> >>> >>>>> >> >> > >>>> release. You can check out the bug on the issue
> >> >>>tracker
> >> >>> >>>>>at
> >> >>> >>>>> >> >> > >>>>
> >> >>> >>>>> >> >> > >>>>
> >> >>> >>>>> >> >> >
> >> >>> >>>>> >> >>
> >> >>> >>>>> >> >>
> >> >>> >>>>> >>
> >> >>> >>>>> >>
> >> >>> >>>>>
> >> >>> >>>>>
> >> >>>
> >> https://issues.apache.org/jira/browse/CB-490?focusedCommentId=13252809#
> >> >>> >>>>>co
> >> >>> >>>>> >> >> > >>>>mment-13252809
> >> >>> >>>>> >> >> > >>>>
> >> >>> >>>>> >> >> > >>>> It doesn't make sense to just repackage 1.6.0
> with
> >> >>>this
> >> >>> >>>>>bug
> >> >>> >>>>> >> >>fixed as
> >> >>> >>>>> >> >> > we
> >> >>> >>>>> >> >> > >>>> will have no way to know if people are
> experiencing
> >> >>>this
> >> >>> >>>>>or
> >> >>> >>>>> >>not.
> >> >>> >>>>> >> >> > >>>>
> >> >>> >>>>> >> >> > >>>> Anis mentioned Bada also had some major issues
> >> >>>which he
> >> >>> >>>>>has
> >> >>> >>>>> >>fixed
> >> >>> >>>>> >> >> now
> >> >>> >>>>> >> >> > >>>>and
> >> >>> >>>>> >> >> > >>>> would like in a 1.6.1 release.
> >> >>> >>>>> >> >> > >>>>
> >> >>> >>>>> >> >> > >>>> Thoughts?
> >> >>> >>>>> >> >> > >>>>
> >> >>> >>>>> >> >> > >>>> -Steve
> >> >>> >>>>> >> >> > >>
> >> >>> >>>>> >> >> >
> >> >>> >>>>> >> >>
> >> >>> >>>>> >>
> >> >>> >>>>> >>
> >> >>> >>>>>
> >> >>> >>>>>
> >> >>> >>>
> >> >>> >
> >> >>>
> >>
> >>
>
Re: 1.6.1
Posted by Shazron <sh...@gmail.com>.
Will rebasing lose that commit? Then, no.
On Thu, Apr 12, 2012 at 3:43 PM, Joe Bowser <bo...@gmail.com> wrote:
> So, can we just rebase the head, push this out and get this rolling?
>
> On Thu, Apr 12, 2012 at 3:43 PM, Filip Maj <fi...@adobe.com> wrote:
>
>> Correct, those iOS-specific parameters (like allow edit and those ones)
>> existed prior to cordova-js, so yeah, we left them in there as we didn't
>> want to remove without deprecation.
>>
>> If you can deal with the iOS issue without needing an API extension: then
>> do that. If not, leave it in there, but docs need to updated too.
>>
>> Extending and changing the public API is a long and difficult process for
>> us and will only get tougher with every platform we add support to.
>>
>> On 4/12/12 3:37 PM, "Shazron" <sh...@gmail.com> wrote:
>>
>> >Then we have to scrap the other three(?) iOS parameters ones that
>> >already exist in common if you noticed. Don't know how we merge
>> >(unmerge?) this one properly because taking those out will break
>> >everyone that is using it, but a deprecation is the way to go as per
>> >http://wiki.apache.org/cordova/DeprecationPolicy . We can remove this
>> >new commit and I'll find a way to get this in somehow.
>> >
>> >
>> >
>> >On Thu, Apr 12, 2012 at 3:32 PM, Joe Bowser <bo...@gmail.com> wrote:
>> >> The problem is that this parameter doesn't belong in the common API.
>> >>It'd
>> >> be just ignored in Android, but the whole point of cordova-js is so that
>> >> it's common. It'd look pretty screwed up to add this to the docs, IMO.
>> >>
>> >> On Thu, Apr 12, 2012 at 3:26 PM, Shazron <sh...@gmail.com> wrote:
>> >>
>> >>> To fix two bugs for Camera.takePicture on iOS
>> >>>
>> >>> On Thu, Apr 12, 2012 at 3:24 PM, Filip Maj <fi...@adobe.com> wrote:
>> >>> > so what's the point of this new parameter?
>> >>> >
>> >>> > On 4/12/12 3:16 PM, "Shazron" <sh...@gmail.com> wrote:
>> >>> >
>> >>> >>I did. Do we want to revert the cordova-js? I can branch 1.6.0 and
>> >>> >>cherry-pick your latest commit for 1.6.1
>> >>> >>
>> >>> >>On Thu, Apr 12, 2012 at 3:04 PM, Filip Maj <fi...@adobe.com> wrote:
>> >>> >>> I saw something in the iOS commit logs for this.
>> >>> >>>
>> >>> >>> Shaz can you comment?
>> >>> >>>
>> >>> >>> On 4/12/12 2:59 PM, "Joe Bowser" <bo...@gmail.com> wrote:
>> >>> >>>
>> >>> >>>>Can we revert this, since this looks like it's intended for both
>> >>> Android
>> >>> >>>>and iOS, but I don't think it should be in 1.6.1.
>> >>> >>>>
>> >>> >>>>On Thu, Apr 12, 2012 at 2:52 PM, Filip Maj <fi...@adobe.com> wrote:
>> >>> >>>>
>> >>> >>>>> I was actually just looking at that myself.
>> >>> >>>>>
>> >>> >>>>> Looks like it's an iOS-only param.. sigh. We gotta stop doing
>> >>>that,
>> >>> >>>>> especially if we don't update documentation.
>> >>> >>>>>
>> >>> >>>>> On 4/12/12 2:49 PM, "Joe Bowser" <bo...@gmail.com> wrote:
>> >>> >>>>>
>> >>> >>>>> >Has anyone tested the cropToSize param for Camera.getPicture
>> >>>yet? I
>> >>> >>>>> >didn't
>> >>> >>>>> >notice that change until now.
>> >>> >>>>> >
>> >>> >>>>> >On Thu, Apr 12, 2012 at 2:46 PM, Filip Maj <fi...@adobe.com>
>> >>>wrote:
>> >>> >>>>> >
>> >>> >>>>> >> JS tagged 1.6.1 - the build task in the JS should work
>> >>>properly
>> >>> >>>>>now.
>> >>> >>>>> >>
>> >>> >>>>> >> FYI if anyone has to modify the jake tasks in the future and
>> >>>make
>> >>> >>>>>them
>> >>> >>>>> >> async, make sure you add the 4th "async" parameter to the
>> >>>task()
>> >>> >>>>> >>function
>> >>> >>>>> >> and set it to true, and call complete() when the task is done.
>> >>> >>>>> >>
>> >>> >>>>> >> See http://howtonode.org/intro-to-jake/async-jakefile.js for
>> >>>an
>> >>> >>>>> example.
>> >>> >>>>> >>
>> >>> >>>>> >> On 4/12/12 2:35 PM, "Joe Bowser" <bo...@gmail.com> wrote:
>> >>> >>>>> >>
>> >>> >>>>> >> >Ready to tag once cordova-js is tagged 1.6.1.
>> >>> >>>>> >> >
>> >>> >>>>> >> >On Thu, Apr 12, 2012 at 2:33 PM, Anis KADRI <
>> >>> anis.kadri@gmail.com>
>> >>> >>>>> >>wrote:
>> >>> >>>>> >> >
>> >>> >>>>> >> >> I will tag my repository to 1.6.1 before end of day today
>> >>>after
>> >>> >>>>>some
>> >>> >>>>> >> >> thorough testing.
>> >>> >>>>> >> >>
>> >>> >>>>> >> >> On Thu, Apr 12, 2012 at 2:30 PM, Shazron
>> >>><sh...@gmail.com>
>> >>> >>>>>wrote:
>> >>> >>>>> >> >>
>> >>> >>>>> >> >> > I also created a 1.6.1 version tag as well in jira...
>> >>> >>>>> >> >> >
>> >>> >>>>> >> >> > On Thu, Apr 12, 2012 at 2:29 PM, Shazron
>> >>><sh...@gmail.com>
>> >>> >>>>> wrote:
>> >>> >>>>> >> >> > > Alright guys since 1.6.0 was released, I'm going to
>> >>> >>>>>"Release"
>> >>> >>>>>the
>> >>> >>>>> >> >> > > 1.6.0 version in jira and move outstanding issues to
>> >>>1.7.0
>> >>> >>>>> >>version
>> >>> >>>>> >> >> > > tag.
>> >>> >>>>> >> >> > >
>> >>> >>>>> >> >> > >
>> >>> >>>>> >> >> > > On Thu, Apr 12, 2012 at 2:26 PM, Filip Maj
>> >>><fi...@adobe.com>
>> >>> >>>>> wrote:
>> >>> >>>>> >> >> > >> The JS needs patching too. Since adding the commit ID
>> >>>into
>> >>> >>>>>the
>> >>> >>>>> >> >> packaging
>> >>> >>>>> >> >> > >> in the jakefile, the default task isn't running
>> >>>properly.
>> >>> >>>>> >> >> > >>
>> >>> >>>>> >> >> > >> You can manually run "jake build" and "jake test" but
>> >>>not
>> >>> >>>>> >>"jake" on
>> >>> >>>>> >> >> its
>> >>> >>>>> >> >> > >> own - gonna try to figure it out.
>> >>> >>>>> >> >> > >>
>> >>> >>>>> >> >> > >> On 4/12/12 2:21 PM, "Shazron" <sh...@gmail.com>
>> >>>wrote:
>> >>> >>>>> >> >> > >>
>> >>> >>>>> >> >> > >>>I'm good with tagging. iOS has a few commits (one
>> >>>commit
>> >>> >>>>>in
>> >>> >>>>> >> >> > >>>cordova-js) as well. Aim for first thing tomorrow for
>> >>>you
>> >>> >>>>>to
>> >>> >>>>> >> >> > >>>repackage?
>> >>> >>>>> >> >> > >>>
>> >>> >>>>> >> >> > >>>On Thu, Apr 12, 2012 at 2:17 PM, Steven Gill
>> >>> >>>>> >> >><st...@gmail.com>
>> >>> >>>>> >> >> > >>>wrote:
>> >>> >>>>> >> >> > >>>> So a bug has been discovered in Cordova Android that
>> >>> >>>>>requires
>> >>> >>>>> >>a
>> >>> >>>>> >> >>new
>> >>> >>>>> >> >> > tag
>> >>> >>>>> >> >> > >>>>and
>> >>> >>>>> >> >> > >>>> release. You can check out the bug on the issue
>> >>>tracker
>> >>> >>>>>at
>> >>> >>>>> >> >> > >>>>
>> >>> >>>>> >> >> > >>>>
>> >>> >>>>> >> >> >
>> >>> >>>>> >> >>
>> >>> >>>>> >> >>
>> >>> >>>>> >>
>> >>> >>>>> >>
>> >>> >>>>>
>> >>> >>>>>
>> >>>
>> https://issues.apache.org/jira/browse/CB-490?focusedCommentId=13252809#
>> >>> >>>>>co
>> >>> >>>>> >> >> > >>>>mment-13252809
>> >>> >>>>> >> >> > >>>>
>> >>> >>>>> >> >> > >>>> It doesn't make sense to just repackage 1.6.0 with
>> >>>this
>> >>> >>>>>bug
>> >>> >>>>> >> >>fixed as
>> >>> >>>>> >> >> > we
>> >>> >>>>> >> >> > >>>> will have no way to know if people are experiencing
>> >>>this
>> >>> >>>>>or
>> >>> >>>>> >>not.
>> >>> >>>>> >> >> > >>>>
>> >>> >>>>> >> >> > >>>> Anis mentioned Bada also had some major issues
>> >>>which he
>> >>> >>>>>has
>> >>> >>>>> >>fixed
>> >>> >>>>> >> >> now
>> >>> >>>>> >> >> > >>>>and
>> >>> >>>>> >> >> > >>>> would like in a 1.6.1 release.
>> >>> >>>>> >> >> > >>>>
>> >>> >>>>> >> >> > >>>> Thoughts?
>> >>> >>>>> >> >> > >>>>
>> >>> >>>>> >> >> > >>>> -Steve
>> >>> >>>>> >> >> > >>
>> >>> >>>>> >> >> >
>> >>> >>>>> >> >>
>> >>> >>>>> >>
>> >>> >>>>> >>
>> >>> >>>>>
>> >>> >>>>>
>> >>> >>>
>> >>> >
>> >>>
>>
>>
Re: 1.6.1
Posted by Joe Bowser <bo...@gmail.com>.
So, can we just rebase the head, push this out and get this rolling?
On Thu, Apr 12, 2012 at 3:43 PM, Filip Maj <fi...@adobe.com> wrote:
> Correct, those iOS-specific parameters (like allow edit and those ones)
> existed prior to cordova-js, so yeah, we left them in there as we didn't
> want to remove without deprecation.
>
> If you can deal with the iOS issue without needing an API extension: then
> do that. If not, leave it in there, but docs need to updated too.
>
> Extending and changing the public API is a long and difficult process for
> us and will only get tougher with every platform we add support to.
>
> On 4/12/12 3:37 PM, "Shazron" <sh...@gmail.com> wrote:
>
> >Then we have to scrap the other three(?) iOS parameters ones that
> >already exist in common if you noticed. Don't know how we merge
> >(unmerge?) this one properly because taking those out will break
> >everyone that is using it, but a deprecation is the way to go as per
> >http://wiki.apache.org/cordova/DeprecationPolicy . We can remove this
> >new commit and I'll find a way to get this in somehow.
> >
> >
> >
> >On Thu, Apr 12, 2012 at 3:32 PM, Joe Bowser <bo...@gmail.com> wrote:
> >> The problem is that this parameter doesn't belong in the common API.
> >>It'd
> >> be just ignored in Android, but the whole point of cordova-js is so that
> >> it's common. It'd look pretty screwed up to add this to the docs, IMO.
> >>
> >> On Thu, Apr 12, 2012 at 3:26 PM, Shazron <sh...@gmail.com> wrote:
> >>
> >>> To fix two bugs for Camera.takePicture on iOS
> >>>
> >>> On Thu, Apr 12, 2012 at 3:24 PM, Filip Maj <fi...@adobe.com> wrote:
> >>> > so what's the point of this new parameter?
> >>> >
> >>> > On 4/12/12 3:16 PM, "Shazron" <sh...@gmail.com> wrote:
> >>> >
> >>> >>I did. Do we want to revert the cordova-js? I can branch 1.6.0 and
> >>> >>cherry-pick your latest commit for 1.6.1
> >>> >>
> >>> >>On Thu, Apr 12, 2012 at 3:04 PM, Filip Maj <fi...@adobe.com> wrote:
> >>> >>> I saw something in the iOS commit logs for this.
> >>> >>>
> >>> >>> Shaz can you comment?
> >>> >>>
> >>> >>> On 4/12/12 2:59 PM, "Joe Bowser" <bo...@gmail.com> wrote:
> >>> >>>
> >>> >>>>Can we revert this, since this looks like it's intended for both
> >>> Android
> >>> >>>>and iOS, but I don't think it should be in 1.6.1.
> >>> >>>>
> >>> >>>>On Thu, Apr 12, 2012 at 2:52 PM, Filip Maj <fi...@adobe.com> wrote:
> >>> >>>>
> >>> >>>>> I was actually just looking at that myself.
> >>> >>>>>
> >>> >>>>> Looks like it's an iOS-only param.. sigh. We gotta stop doing
> >>>that,
> >>> >>>>> especially if we don't update documentation.
> >>> >>>>>
> >>> >>>>> On 4/12/12 2:49 PM, "Joe Bowser" <bo...@gmail.com> wrote:
> >>> >>>>>
> >>> >>>>> >Has anyone tested the cropToSize param for Camera.getPicture
> >>>yet? I
> >>> >>>>> >didn't
> >>> >>>>> >notice that change until now.
> >>> >>>>> >
> >>> >>>>> >On Thu, Apr 12, 2012 at 2:46 PM, Filip Maj <fi...@adobe.com>
> >>>wrote:
> >>> >>>>> >
> >>> >>>>> >> JS tagged 1.6.1 - the build task in the JS should work
> >>>properly
> >>> >>>>>now.
> >>> >>>>> >>
> >>> >>>>> >> FYI if anyone has to modify the jake tasks in the future and
> >>>make
> >>> >>>>>them
> >>> >>>>> >> async, make sure you add the 4th "async" parameter to the
> >>>task()
> >>> >>>>> >>function
> >>> >>>>> >> and set it to true, and call complete() when the task is done.
> >>> >>>>> >>
> >>> >>>>> >> See http://howtonode.org/intro-to-jake/async-jakefile.js for
> >>>an
> >>> >>>>> example.
> >>> >>>>> >>
> >>> >>>>> >> On 4/12/12 2:35 PM, "Joe Bowser" <bo...@gmail.com> wrote:
> >>> >>>>> >>
> >>> >>>>> >> >Ready to tag once cordova-js is tagged 1.6.1.
> >>> >>>>> >> >
> >>> >>>>> >> >On Thu, Apr 12, 2012 at 2:33 PM, Anis KADRI <
> >>> anis.kadri@gmail.com>
> >>> >>>>> >>wrote:
> >>> >>>>> >> >
> >>> >>>>> >> >> I will tag my repository to 1.6.1 before end of day today
> >>>after
> >>> >>>>>some
> >>> >>>>> >> >> thorough testing.
> >>> >>>>> >> >>
> >>> >>>>> >> >> On Thu, Apr 12, 2012 at 2:30 PM, Shazron
> >>><sh...@gmail.com>
> >>> >>>>>wrote:
> >>> >>>>> >> >>
> >>> >>>>> >> >> > I also created a 1.6.1 version tag as well in jira...
> >>> >>>>> >> >> >
> >>> >>>>> >> >> > On Thu, Apr 12, 2012 at 2:29 PM, Shazron
> >>><sh...@gmail.com>
> >>> >>>>> wrote:
> >>> >>>>> >> >> > > Alright guys since 1.6.0 was released, I'm going to
> >>> >>>>>"Release"
> >>> >>>>>the
> >>> >>>>> >> >> > > 1.6.0 version in jira and move outstanding issues to
> >>>1.7.0
> >>> >>>>> >>version
> >>> >>>>> >> >> > > tag.
> >>> >>>>> >> >> > >
> >>> >>>>> >> >> > >
> >>> >>>>> >> >> > > On Thu, Apr 12, 2012 at 2:26 PM, Filip Maj
> >>><fi...@adobe.com>
> >>> >>>>> wrote:
> >>> >>>>> >> >> > >> The JS needs patching too. Since adding the commit ID
> >>>into
> >>> >>>>>the
> >>> >>>>> >> >> packaging
> >>> >>>>> >> >> > >> in the jakefile, the default task isn't running
> >>>properly.
> >>> >>>>> >> >> > >>
> >>> >>>>> >> >> > >> You can manually run "jake build" and "jake test" but
> >>>not
> >>> >>>>> >>"jake" on
> >>> >>>>> >> >> its
> >>> >>>>> >> >> > >> own - gonna try to figure it out.
> >>> >>>>> >> >> > >>
> >>> >>>>> >> >> > >> On 4/12/12 2:21 PM, "Shazron" <sh...@gmail.com>
> >>>wrote:
> >>> >>>>> >> >> > >>
> >>> >>>>> >> >> > >>>I'm good with tagging. iOS has a few commits (one
> >>>commit
> >>> >>>>>in
> >>> >>>>> >> >> > >>>cordova-js) as well. Aim for first thing tomorrow for
> >>>you
> >>> >>>>>to
> >>> >>>>> >> >> > >>>repackage?
> >>> >>>>> >> >> > >>>
> >>> >>>>> >> >> > >>>On Thu, Apr 12, 2012 at 2:17 PM, Steven Gill
> >>> >>>>> >> >><st...@gmail.com>
> >>> >>>>> >> >> > >>>wrote:
> >>> >>>>> >> >> > >>>> So a bug has been discovered in Cordova Android that
> >>> >>>>>requires
> >>> >>>>> >>a
> >>> >>>>> >> >>new
> >>> >>>>> >> >> > tag
> >>> >>>>> >> >> > >>>>and
> >>> >>>>> >> >> > >>>> release. You can check out the bug on the issue
> >>>tracker
> >>> >>>>>at
> >>> >>>>> >> >> > >>>>
> >>> >>>>> >> >> > >>>>
> >>> >>>>> >> >> >
> >>> >>>>> >> >>
> >>> >>>>> >> >>
> >>> >>>>> >>
> >>> >>>>> >>
> >>> >>>>>
> >>> >>>>>
> >>>
> https://issues.apache.org/jira/browse/CB-490?focusedCommentId=13252809#
> >>> >>>>>co
> >>> >>>>> >> >> > >>>>mment-13252809
> >>> >>>>> >> >> > >>>>
> >>> >>>>> >> >> > >>>> It doesn't make sense to just repackage 1.6.0 with
> >>>this
> >>> >>>>>bug
> >>> >>>>> >> >>fixed as
> >>> >>>>> >> >> > we
> >>> >>>>> >> >> > >>>> will have no way to know if people are experiencing
> >>>this
> >>> >>>>>or
> >>> >>>>> >>not.
> >>> >>>>> >> >> > >>>>
> >>> >>>>> >> >> > >>>> Anis mentioned Bada also had some major issues
> >>>which he
> >>> >>>>>has
> >>> >>>>> >>fixed
> >>> >>>>> >> >> now
> >>> >>>>> >> >> > >>>>and
> >>> >>>>> >> >> > >>>> would like in a 1.6.1 release.
> >>> >>>>> >> >> > >>>>
> >>> >>>>> >> >> > >>>> Thoughts?
> >>> >>>>> >> >> > >>>>
> >>> >>>>> >> >> > >>>> -Steve
> >>> >>>>> >> >> > >>
> >>> >>>>> >> >> >
> >>> >>>>> >> >>
> >>> >>>>> >>
> >>> >>>>> >>
> >>> >>>>>
> >>> >>>>>
> >>> >>>
> >>> >
> >>>
>
>
Re: 1.6.1
Posted by Shazron <sh...@gmail.com>.
Noted. My intent was to grab a significant user contribution
(community, not just us eh) and tweak it by 1.7.0, did not expect a
1.6.1 today.
On Thu, Apr 12, 2012 at 3:43 PM, Filip Maj <fi...@adobe.com> wrote:
> Correct, those iOS-specific parameters (like allow edit and those ones)
> existed prior to cordova-js, so yeah, we left them in there as we didn't
> want to remove without deprecation.
>
> If you can deal with the iOS issue without needing an API extension: then
> do that. If not, leave it in there, but docs need to updated too.
>
> Extending and changing the public API is a long and difficult process for
> us and will only get tougher with every platform we add support to.
>
> On 4/12/12 3:37 PM, "Shazron" <sh...@gmail.com> wrote:
>
>>Then we have to scrap the other three(?) iOS parameters ones that
>>already exist in common if you noticed. Don't know how we merge
>>(unmerge?) this one properly because taking those out will break
>>everyone that is using it, but a deprecation is the way to go as per
>>http://wiki.apache.org/cordova/DeprecationPolicy . We can remove this
>>new commit and I'll find a way to get this in somehow.
>>
>>
>>
>>On Thu, Apr 12, 2012 at 3:32 PM, Joe Bowser <bo...@gmail.com> wrote:
>>> The problem is that this parameter doesn't belong in the common API.
>>>It'd
>>> be just ignored in Android, but the whole point of cordova-js is so that
>>> it's common. It'd look pretty screwed up to add this to the docs, IMO.
>>>
>>> On Thu, Apr 12, 2012 at 3:26 PM, Shazron <sh...@gmail.com> wrote:
>>>
>>>> To fix two bugs for Camera.takePicture on iOS
>>>>
>>>> On Thu, Apr 12, 2012 at 3:24 PM, Filip Maj <fi...@adobe.com> wrote:
>>>> > so what's the point of this new parameter?
>>>> >
>>>> > On 4/12/12 3:16 PM, "Shazron" <sh...@gmail.com> wrote:
>>>> >
>>>> >>I did. Do we want to revert the cordova-js? I can branch 1.6.0 and
>>>> >>cherry-pick your latest commit for 1.6.1
>>>> >>
>>>> >>On Thu, Apr 12, 2012 at 3:04 PM, Filip Maj <fi...@adobe.com> wrote:
>>>> >>> I saw something in the iOS commit logs for this.
>>>> >>>
>>>> >>> Shaz can you comment?
>>>> >>>
>>>> >>> On 4/12/12 2:59 PM, "Joe Bowser" <bo...@gmail.com> wrote:
>>>> >>>
>>>> >>>>Can we revert this, since this looks like it's intended for both
>>>> Android
>>>> >>>>and iOS, but I don't think it should be in 1.6.1.
>>>> >>>>
>>>> >>>>On Thu, Apr 12, 2012 at 2:52 PM, Filip Maj <fi...@adobe.com> wrote:
>>>> >>>>
>>>> >>>>> I was actually just looking at that myself.
>>>> >>>>>
>>>> >>>>> Looks like it's an iOS-only param.. sigh. We gotta stop doing
>>>>that,
>>>> >>>>> especially if we don't update documentation.
>>>> >>>>>
>>>> >>>>> On 4/12/12 2:49 PM, "Joe Bowser" <bo...@gmail.com> wrote:
>>>> >>>>>
>>>> >>>>> >Has anyone tested the cropToSize param for Camera.getPicture
>>>>yet? I
>>>> >>>>> >didn't
>>>> >>>>> >notice that change until now.
>>>> >>>>> >
>>>> >>>>> >On Thu, Apr 12, 2012 at 2:46 PM, Filip Maj <fi...@adobe.com>
>>>>wrote:
>>>> >>>>> >
>>>> >>>>> >> JS tagged 1.6.1 - the build task in the JS should work
>>>>properly
>>>> >>>>>now.
>>>> >>>>> >>
>>>> >>>>> >> FYI if anyone has to modify the jake tasks in the future and
>>>>make
>>>> >>>>>them
>>>> >>>>> >> async, make sure you add the 4th "async" parameter to the
>>>>task()
>>>> >>>>> >>function
>>>> >>>>> >> and set it to true, and call complete() when the task is done.
>>>> >>>>> >>
>>>> >>>>> >> See http://howtonode.org/intro-to-jake/async-jakefile.js for
>>>>an
>>>> >>>>> example.
>>>> >>>>> >>
>>>> >>>>> >> On 4/12/12 2:35 PM, "Joe Bowser" <bo...@gmail.com> wrote:
>>>> >>>>> >>
>>>> >>>>> >> >Ready to tag once cordova-js is tagged 1.6.1.
>>>> >>>>> >> >
>>>> >>>>> >> >On Thu, Apr 12, 2012 at 2:33 PM, Anis KADRI <
>>>> anis.kadri@gmail.com>
>>>> >>>>> >>wrote:
>>>> >>>>> >> >
>>>> >>>>> >> >> I will tag my repository to 1.6.1 before end of day today
>>>>after
>>>> >>>>>some
>>>> >>>>> >> >> thorough testing.
>>>> >>>>> >> >>
>>>> >>>>> >> >> On Thu, Apr 12, 2012 at 2:30 PM, Shazron
>>>><sh...@gmail.com>
>>>> >>>>>wrote:
>>>> >>>>> >> >>
>>>> >>>>> >> >> > I also created a 1.6.1 version tag as well in jira...
>>>> >>>>> >> >> >
>>>> >>>>> >> >> > On Thu, Apr 12, 2012 at 2:29 PM, Shazron
>>>><sh...@gmail.com>
>>>> >>>>> wrote:
>>>> >>>>> >> >> > > Alright guys since 1.6.0 was released, I'm going to
>>>> >>>>>"Release"
>>>> >>>>>the
>>>> >>>>> >> >> > > 1.6.0 version in jira and move outstanding issues to
>>>>1.7.0
>>>> >>>>> >>version
>>>> >>>>> >> >> > > tag.
>>>> >>>>> >> >> > >
>>>> >>>>> >> >> > >
>>>> >>>>> >> >> > > On Thu, Apr 12, 2012 at 2:26 PM, Filip Maj
>>>><fi...@adobe.com>
>>>> >>>>> wrote:
>>>> >>>>> >> >> > >> The JS needs patching too. Since adding the commit ID
>>>>into
>>>> >>>>>the
>>>> >>>>> >> >> packaging
>>>> >>>>> >> >> > >> in the jakefile, the default task isn't running
>>>>properly.
>>>> >>>>> >> >> > >>
>>>> >>>>> >> >> > >> You can manually run "jake build" and "jake test" but
>>>>not
>>>> >>>>> >>"jake" on
>>>> >>>>> >> >> its
>>>> >>>>> >> >> > >> own - gonna try to figure it out.
>>>> >>>>> >> >> > >>
>>>> >>>>> >> >> > >> On 4/12/12 2:21 PM, "Shazron" <sh...@gmail.com>
>>>>wrote:
>>>> >>>>> >> >> > >>
>>>> >>>>> >> >> > >>>I'm good with tagging. iOS has a few commits (one
>>>>commit
>>>> >>>>>in
>>>> >>>>> >> >> > >>>cordova-js) as well. Aim for first thing tomorrow for
>>>>you
>>>> >>>>>to
>>>> >>>>> >> >> > >>>repackage?
>>>> >>>>> >> >> > >>>
>>>> >>>>> >> >> > >>>On Thu, Apr 12, 2012 at 2:17 PM, Steven Gill
>>>> >>>>> >> >><st...@gmail.com>
>>>> >>>>> >> >> > >>>wrote:
>>>> >>>>> >> >> > >>>> So a bug has been discovered in Cordova Android that
>>>> >>>>>requires
>>>> >>>>> >>a
>>>> >>>>> >> >>new
>>>> >>>>> >> >> > tag
>>>> >>>>> >> >> > >>>>and
>>>> >>>>> >> >> > >>>> release. You can check out the bug on the issue
>>>>tracker
>>>> >>>>>at
>>>> >>>>> >> >> > >>>>
>>>> >>>>> >> >> > >>>>
>>>> >>>>> >> >> >
>>>> >>>>> >> >>
>>>> >>>>> >> >>
>>>> >>>>> >>
>>>> >>>>> >>
>>>> >>>>>
>>>> >>>>>
>>>> https://issues.apache.org/jira/browse/CB-490?focusedCommentId=13252809#
>>>> >>>>>co
>>>> >>>>> >> >> > >>>>mment-13252809
>>>> >>>>> >> >> > >>>>
>>>> >>>>> >> >> > >>>> It doesn't make sense to just repackage 1.6.0 with
>>>>this
>>>> >>>>>bug
>>>> >>>>> >> >>fixed as
>>>> >>>>> >> >> > we
>>>> >>>>> >> >> > >>>> will have no way to know if people are experiencing
>>>>this
>>>> >>>>>or
>>>> >>>>> >>not.
>>>> >>>>> >> >> > >>>>
>>>> >>>>> >> >> > >>>> Anis mentioned Bada also had some major issues
>>>>which he
>>>> >>>>>has
>>>> >>>>> >>fixed
>>>> >>>>> >> >> now
>>>> >>>>> >> >> > >>>>and
>>>> >>>>> >> >> > >>>> would like in a 1.6.1 release.
>>>> >>>>> >> >> > >>>>
>>>> >>>>> >> >> > >>>> Thoughts?
>>>> >>>>> >> >> > >>>>
>>>> >>>>> >> >> > >>>> -Steve
>>>> >>>>> >> >> > >>
>>>> >>>>> >> >> >
>>>> >>>>> >> >>
>>>> >>>>> >>
>>>> >>>>> >>
>>>> >>>>>
>>>> >>>>>
>>>> >>>
>>>> >
>>>>
>
Re: 1.6.1
Posted by Shazron <sh...@gmail.com>.
Re: the three iOS params (Becky)
http://mail-archives.apache.org/mod_mbox/incubator-callback-dev/201204.mbox/%3CCADjNb%2Bk7vAvbytcUrg6mcdtPLOObJ8JNQRoohnxR53YEKDdA6g%40mail.gmail.com%3E
https://issues.apache.org/jira/browse/CB-427
On Thu, Apr 12, 2012 at 3:37 PM, Shazron <sh...@gmail.com> wrote:
> Then we have to scrap the other three(?) iOS parameters ones that
> already exist in common if you noticed. Don't know how we merge
> (unmerge?) this one properly because taking those out will break
> everyone that is using it, but a deprecation is the way to go as per
> http://wiki.apache.org/cordova/DeprecationPolicy . We can remove this
> new commit and I'll find a way to get this in somehow.
>
>
>
> On Thu, Apr 12, 2012 at 3:32 PM, Joe Bowser <bo...@gmail.com> wrote:
>> The problem is that this parameter doesn't belong in the common API. It'd
>> be just ignored in Android, but the whole point of cordova-js is so that
>> it's common. It'd look pretty screwed up to add this to the docs, IMO.
>>
>> On Thu, Apr 12, 2012 at 3:26 PM, Shazron <sh...@gmail.com> wrote:
>>
>>> To fix two bugs for Camera.takePicture on iOS
>>>
>>> On Thu, Apr 12, 2012 at 3:24 PM, Filip Maj <fi...@adobe.com> wrote:
>>> > so what's the point of this new parameter?
>>> >
>>> > On 4/12/12 3:16 PM, "Shazron" <sh...@gmail.com> wrote:
>>> >
>>> >>I did. Do we want to revert the cordova-js? I can branch 1.6.0 and
>>> >>cherry-pick your latest commit for 1.6.1
>>> >>
>>> >>On Thu, Apr 12, 2012 at 3:04 PM, Filip Maj <fi...@adobe.com> wrote:
>>> >>> I saw something in the iOS commit logs for this.
>>> >>>
>>> >>> Shaz can you comment?
>>> >>>
>>> >>> On 4/12/12 2:59 PM, "Joe Bowser" <bo...@gmail.com> wrote:
>>> >>>
>>> >>>>Can we revert this, since this looks like it's intended for both
>>> Android
>>> >>>>and iOS, but I don't think it should be in 1.6.1.
>>> >>>>
>>> >>>>On Thu, Apr 12, 2012 at 2:52 PM, Filip Maj <fi...@adobe.com> wrote:
>>> >>>>
>>> >>>>> I was actually just looking at that myself.
>>> >>>>>
>>> >>>>> Looks like it's an iOS-only param.. sigh. We gotta stop doing that,
>>> >>>>> especially if we don't update documentation.
>>> >>>>>
>>> >>>>> On 4/12/12 2:49 PM, "Joe Bowser" <bo...@gmail.com> wrote:
>>> >>>>>
>>> >>>>> >Has anyone tested the cropToSize param for Camera.getPicture yet? I
>>> >>>>> >didn't
>>> >>>>> >notice that change until now.
>>> >>>>> >
>>> >>>>> >On Thu, Apr 12, 2012 at 2:46 PM, Filip Maj <fi...@adobe.com> wrote:
>>> >>>>> >
>>> >>>>> >> JS tagged 1.6.1 - the build task in the JS should work properly
>>> >>>>>now.
>>> >>>>> >>
>>> >>>>> >> FYI if anyone has to modify the jake tasks in the future and make
>>> >>>>>them
>>> >>>>> >> async, make sure you add the 4th "async" parameter to the task()
>>> >>>>> >>function
>>> >>>>> >> and set it to true, and call complete() when the task is done.
>>> >>>>> >>
>>> >>>>> >> See http://howtonode.org/intro-to-jake/async-jakefile.js for an
>>> >>>>> example.
>>> >>>>> >>
>>> >>>>> >> On 4/12/12 2:35 PM, "Joe Bowser" <bo...@gmail.com> wrote:
>>> >>>>> >>
>>> >>>>> >> >Ready to tag once cordova-js is tagged 1.6.1.
>>> >>>>> >> >
>>> >>>>> >> >On Thu, Apr 12, 2012 at 2:33 PM, Anis KADRI <
>>> anis.kadri@gmail.com>
>>> >>>>> >>wrote:
>>> >>>>> >> >
>>> >>>>> >> >> I will tag my repository to 1.6.1 before end of day today after
>>> >>>>>some
>>> >>>>> >> >> thorough testing.
>>> >>>>> >> >>
>>> >>>>> >> >> On Thu, Apr 12, 2012 at 2:30 PM, Shazron <sh...@gmail.com>
>>> >>>>>wrote:
>>> >>>>> >> >>
>>> >>>>> >> >> > I also created a 1.6.1 version tag as well in jira...
>>> >>>>> >> >> >
>>> >>>>> >> >> > On Thu, Apr 12, 2012 at 2:29 PM, Shazron <sh...@gmail.com>
>>> >>>>> wrote:
>>> >>>>> >> >> > > Alright guys since 1.6.0 was released, I'm going to
>>> >>>>>"Release"
>>> >>>>>the
>>> >>>>> >> >> > > 1.6.0 version in jira and move outstanding issues to 1.7.0
>>> >>>>> >>version
>>> >>>>> >> >> > > tag.
>>> >>>>> >> >> > >
>>> >>>>> >> >> > >
>>> >>>>> >> >> > > On Thu, Apr 12, 2012 at 2:26 PM, Filip Maj <fi...@adobe.com>
>>> >>>>> wrote:
>>> >>>>> >> >> > >> The JS needs patching too. Since adding the commit ID into
>>> >>>>>the
>>> >>>>> >> >> packaging
>>> >>>>> >> >> > >> in the jakefile, the default task isn't running properly.
>>> >>>>> >> >> > >>
>>> >>>>> >> >> > >> You can manually run "jake build" and "jake test" but not
>>> >>>>> >>"jake" on
>>> >>>>> >> >> its
>>> >>>>> >> >> > >> own - gonna try to figure it out.
>>> >>>>> >> >> > >>
>>> >>>>> >> >> > >> On 4/12/12 2:21 PM, "Shazron" <sh...@gmail.com> wrote:
>>> >>>>> >> >> > >>
>>> >>>>> >> >> > >>>I'm good with tagging. iOS has a few commits (one commit
>>> >>>>>in
>>> >>>>> >> >> > >>>cordova-js) as well. Aim for first thing tomorrow for you
>>> >>>>>to
>>> >>>>> >> >> > >>>repackage?
>>> >>>>> >> >> > >>>
>>> >>>>> >> >> > >>>On Thu, Apr 12, 2012 at 2:17 PM, Steven Gill
>>> >>>>> >> >><st...@gmail.com>
>>> >>>>> >> >> > >>>wrote:
>>> >>>>> >> >> > >>>> So a bug has been discovered in Cordova Android that
>>> >>>>>requires
>>> >>>>> >>a
>>> >>>>> >> >>new
>>> >>>>> >> >> > tag
>>> >>>>> >> >> > >>>>and
>>> >>>>> >> >> > >>>> release. You can check out the bug on the issue tracker
>>> >>>>>at
>>> >>>>> >> >> > >>>>
>>> >>>>> >> >> > >>>>
>>> >>>>> >> >> >
>>> >>>>> >> >>
>>> >>>>> >> >>
>>> >>>>> >>
>>> >>>>> >>
>>> >>>>>
>>> >>>>>
>>> https://issues.apache.org/jira/browse/CB-490?focusedCommentId=13252809#
>>> >>>>>co
>>> >>>>> >> >> > >>>>mment-13252809
>>> >>>>> >> >> > >>>>
>>> >>>>> >> >> > >>>> It doesn't make sense to just repackage 1.6.0 with this
>>> >>>>>bug
>>> >>>>> >> >>fixed as
>>> >>>>> >> >> > we
>>> >>>>> >> >> > >>>> will have no way to know if people are experiencing this
>>> >>>>>or
>>> >>>>> >>not.
>>> >>>>> >> >> > >>>>
>>> >>>>> >> >> > >>>> Anis mentioned Bada also had some major issues which he
>>> >>>>>has
>>> >>>>> >>fixed
>>> >>>>> >> >> now
>>> >>>>> >> >> > >>>>and
>>> >>>>> >> >> > >>>> would like in a 1.6.1 release.
>>> >>>>> >> >> > >>>>
>>> >>>>> >> >> > >>>> Thoughts?
>>> >>>>> >> >> > >>>>
>>> >>>>> >> >> > >>>> -Steve
>>> >>>>> >> >> > >>
>>> >>>>> >> >> >
>>> >>>>> >> >>
>>> >>>>> >>
>>> >>>>> >>
>>> >>>>>
>>> >>>>>
>>> >>>
>>> >
>>>
Re: 1.6.1
Posted by Filip Maj <fi...@adobe.com>.
Correct, those iOS-specific parameters (like allow edit and those ones)
existed prior to cordova-js, so yeah, we left them in there as we didn't
want to remove without deprecation.
If you can deal with the iOS issue without needing an API extension: then
do that. If not, leave it in there, but docs need to updated too.
Extending and changing the public API is a long and difficult process for
us and will only get tougher with every platform we add support to.
On 4/12/12 3:37 PM, "Shazron" <sh...@gmail.com> wrote:
>Then we have to scrap the other three(?) iOS parameters ones that
>already exist in common if you noticed. Don't know how we merge
>(unmerge?) this one properly because taking those out will break
>everyone that is using it, but a deprecation is the way to go as per
>http://wiki.apache.org/cordova/DeprecationPolicy . We can remove this
>new commit and I'll find a way to get this in somehow.
>
>
>
>On Thu, Apr 12, 2012 at 3:32 PM, Joe Bowser <bo...@gmail.com> wrote:
>> The problem is that this parameter doesn't belong in the common API.
>>It'd
>> be just ignored in Android, but the whole point of cordova-js is so that
>> it's common. It'd look pretty screwed up to add this to the docs, IMO.
>>
>> On Thu, Apr 12, 2012 at 3:26 PM, Shazron <sh...@gmail.com> wrote:
>>
>>> To fix two bugs for Camera.takePicture on iOS
>>>
>>> On Thu, Apr 12, 2012 at 3:24 PM, Filip Maj <fi...@adobe.com> wrote:
>>> > so what's the point of this new parameter?
>>> >
>>> > On 4/12/12 3:16 PM, "Shazron" <sh...@gmail.com> wrote:
>>> >
>>> >>I did. Do we want to revert the cordova-js? I can branch 1.6.0 and
>>> >>cherry-pick your latest commit for 1.6.1
>>> >>
>>> >>On Thu, Apr 12, 2012 at 3:04 PM, Filip Maj <fi...@adobe.com> wrote:
>>> >>> I saw something in the iOS commit logs for this.
>>> >>>
>>> >>> Shaz can you comment?
>>> >>>
>>> >>> On 4/12/12 2:59 PM, "Joe Bowser" <bo...@gmail.com> wrote:
>>> >>>
>>> >>>>Can we revert this, since this looks like it's intended for both
>>> Android
>>> >>>>and iOS, but I don't think it should be in 1.6.1.
>>> >>>>
>>> >>>>On Thu, Apr 12, 2012 at 2:52 PM, Filip Maj <fi...@adobe.com> wrote:
>>> >>>>
>>> >>>>> I was actually just looking at that myself.
>>> >>>>>
>>> >>>>> Looks like it's an iOS-only param.. sigh. We gotta stop doing
>>>that,
>>> >>>>> especially if we don't update documentation.
>>> >>>>>
>>> >>>>> On 4/12/12 2:49 PM, "Joe Bowser" <bo...@gmail.com> wrote:
>>> >>>>>
>>> >>>>> >Has anyone tested the cropToSize param for Camera.getPicture
>>>yet? I
>>> >>>>> >didn't
>>> >>>>> >notice that change until now.
>>> >>>>> >
>>> >>>>> >On Thu, Apr 12, 2012 at 2:46 PM, Filip Maj <fi...@adobe.com>
>>>wrote:
>>> >>>>> >
>>> >>>>> >> JS tagged 1.6.1 - the build task in the JS should work
>>>properly
>>> >>>>>now.
>>> >>>>> >>
>>> >>>>> >> FYI if anyone has to modify the jake tasks in the future and
>>>make
>>> >>>>>them
>>> >>>>> >> async, make sure you add the 4th "async" parameter to the
>>>task()
>>> >>>>> >>function
>>> >>>>> >> and set it to true, and call complete() when the task is done.
>>> >>>>> >>
>>> >>>>> >> See http://howtonode.org/intro-to-jake/async-jakefile.js for
>>>an
>>> >>>>> example.
>>> >>>>> >>
>>> >>>>> >> On 4/12/12 2:35 PM, "Joe Bowser" <bo...@gmail.com> wrote:
>>> >>>>> >>
>>> >>>>> >> >Ready to tag once cordova-js is tagged 1.6.1.
>>> >>>>> >> >
>>> >>>>> >> >On Thu, Apr 12, 2012 at 2:33 PM, Anis KADRI <
>>> anis.kadri@gmail.com>
>>> >>>>> >>wrote:
>>> >>>>> >> >
>>> >>>>> >> >> I will tag my repository to 1.6.1 before end of day today
>>>after
>>> >>>>>some
>>> >>>>> >> >> thorough testing.
>>> >>>>> >> >>
>>> >>>>> >> >> On Thu, Apr 12, 2012 at 2:30 PM, Shazron
>>><sh...@gmail.com>
>>> >>>>>wrote:
>>> >>>>> >> >>
>>> >>>>> >> >> > I also created a 1.6.1 version tag as well in jira...
>>> >>>>> >> >> >
>>> >>>>> >> >> > On Thu, Apr 12, 2012 at 2:29 PM, Shazron
>>><sh...@gmail.com>
>>> >>>>> wrote:
>>> >>>>> >> >> > > Alright guys since 1.6.0 was released, I'm going to
>>> >>>>>"Release"
>>> >>>>>the
>>> >>>>> >> >> > > 1.6.0 version in jira and move outstanding issues to
>>>1.7.0
>>> >>>>> >>version
>>> >>>>> >> >> > > tag.
>>> >>>>> >> >> > >
>>> >>>>> >> >> > >
>>> >>>>> >> >> > > On Thu, Apr 12, 2012 at 2:26 PM, Filip Maj
>>><fi...@adobe.com>
>>> >>>>> wrote:
>>> >>>>> >> >> > >> The JS needs patching too. Since adding the commit ID
>>>into
>>> >>>>>the
>>> >>>>> >> >> packaging
>>> >>>>> >> >> > >> in the jakefile, the default task isn't running
>>>properly.
>>> >>>>> >> >> > >>
>>> >>>>> >> >> > >> You can manually run "jake build" and "jake test" but
>>>not
>>> >>>>> >>"jake" on
>>> >>>>> >> >> its
>>> >>>>> >> >> > >> own - gonna try to figure it out.
>>> >>>>> >> >> > >>
>>> >>>>> >> >> > >> On 4/12/12 2:21 PM, "Shazron" <sh...@gmail.com>
>>>wrote:
>>> >>>>> >> >> > >>
>>> >>>>> >> >> > >>>I'm good with tagging. iOS has a few commits (one
>>>commit
>>> >>>>>in
>>> >>>>> >> >> > >>>cordova-js) as well. Aim for first thing tomorrow for
>>>you
>>> >>>>>to
>>> >>>>> >> >> > >>>repackage?
>>> >>>>> >> >> > >>>
>>> >>>>> >> >> > >>>On Thu, Apr 12, 2012 at 2:17 PM, Steven Gill
>>> >>>>> >> >><st...@gmail.com>
>>> >>>>> >> >> > >>>wrote:
>>> >>>>> >> >> > >>>> So a bug has been discovered in Cordova Android that
>>> >>>>>requires
>>> >>>>> >>a
>>> >>>>> >> >>new
>>> >>>>> >> >> > tag
>>> >>>>> >> >> > >>>>and
>>> >>>>> >> >> > >>>> release. You can check out the bug on the issue
>>>tracker
>>> >>>>>at
>>> >>>>> >> >> > >>>>
>>> >>>>> >> >> > >>>>
>>> >>>>> >> >> >
>>> >>>>> >> >>
>>> >>>>> >> >>
>>> >>>>> >>
>>> >>>>> >>
>>> >>>>>
>>> >>>>>
>>> https://issues.apache.org/jira/browse/CB-490?focusedCommentId=13252809#
>>> >>>>>co
>>> >>>>> >> >> > >>>>mment-13252809
>>> >>>>> >> >> > >>>>
>>> >>>>> >> >> > >>>> It doesn't make sense to just repackage 1.6.0 with
>>>this
>>> >>>>>bug
>>> >>>>> >> >>fixed as
>>> >>>>> >> >> > we
>>> >>>>> >> >> > >>>> will have no way to know if people are experiencing
>>>this
>>> >>>>>or
>>> >>>>> >>not.
>>> >>>>> >> >> > >>>>
>>> >>>>> >> >> > >>>> Anis mentioned Bada also had some major issues
>>>which he
>>> >>>>>has
>>> >>>>> >>fixed
>>> >>>>> >> >> now
>>> >>>>> >> >> > >>>>and
>>> >>>>> >> >> > >>>> would like in a 1.6.1 release.
>>> >>>>> >> >> > >>>>
>>> >>>>> >> >> > >>>> Thoughts?
>>> >>>>> >> >> > >>>>
>>> >>>>> >> >> > >>>> -Steve
>>> >>>>> >> >> > >>
>>> >>>>> >> >> >
>>> >>>>> >> >>
>>> >>>>> >>
>>> >>>>> >>
>>> >>>>>
>>> >>>>>
>>> >>>
>>> >
>>>
Re: 1.6.1
Posted by Shazron <sh...@gmail.com>.
Then we have to scrap the other three(?) iOS parameters ones that
already exist in common if you noticed. Don't know how we merge
(unmerge?) this one properly because taking those out will break
everyone that is using it, but a deprecation is the way to go as per
http://wiki.apache.org/cordova/DeprecationPolicy . We can remove this
new commit and I'll find a way to get this in somehow.
On Thu, Apr 12, 2012 at 3:32 PM, Joe Bowser <bo...@gmail.com> wrote:
> The problem is that this parameter doesn't belong in the common API. It'd
> be just ignored in Android, but the whole point of cordova-js is so that
> it's common. It'd look pretty screwed up to add this to the docs, IMO.
>
> On Thu, Apr 12, 2012 at 3:26 PM, Shazron <sh...@gmail.com> wrote:
>
>> To fix two bugs for Camera.takePicture on iOS
>>
>> On Thu, Apr 12, 2012 at 3:24 PM, Filip Maj <fi...@adobe.com> wrote:
>> > so what's the point of this new parameter?
>> >
>> > On 4/12/12 3:16 PM, "Shazron" <sh...@gmail.com> wrote:
>> >
>> >>I did. Do we want to revert the cordova-js? I can branch 1.6.0 and
>> >>cherry-pick your latest commit for 1.6.1
>> >>
>> >>On Thu, Apr 12, 2012 at 3:04 PM, Filip Maj <fi...@adobe.com> wrote:
>> >>> I saw something in the iOS commit logs for this.
>> >>>
>> >>> Shaz can you comment?
>> >>>
>> >>> On 4/12/12 2:59 PM, "Joe Bowser" <bo...@gmail.com> wrote:
>> >>>
>> >>>>Can we revert this, since this looks like it's intended for both
>> Android
>> >>>>and iOS, but I don't think it should be in 1.6.1.
>> >>>>
>> >>>>On Thu, Apr 12, 2012 at 2:52 PM, Filip Maj <fi...@adobe.com> wrote:
>> >>>>
>> >>>>> I was actually just looking at that myself.
>> >>>>>
>> >>>>> Looks like it's an iOS-only param.. sigh. We gotta stop doing that,
>> >>>>> especially if we don't update documentation.
>> >>>>>
>> >>>>> On 4/12/12 2:49 PM, "Joe Bowser" <bo...@gmail.com> wrote:
>> >>>>>
>> >>>>> >Has anyone tested the cropToSize param for Camera.getPicture yet? I
>> >>>>> >didn't
>> >>>>> >notice that change until now.
>> >>>>> >
>> >>>>> >On Thu, Apr 12, 2012 at 2:46 PM, Filip Maj <fi...@adobe.com> wrote:
>> >>>>> >
>> >>>>> >> JS tagged 1.6.1 - the build task in the JS should work properly
>> >>>>>now.
>> >>>>> >>
>> >>>>> >> FYI if anyone has to modify the jake tasks in the future and make
>> >>>>>them
>> >>>>> >> async, make sure you add the 4th "async" parameter to the task()
>> >>>>> >>function
>> >>>>> >> and set it to true, and call complete() when the task is done.
>> >>>>> >>
>> >>>>> >> See http://howtonode.org/intro-to-jake/async-jakefile.js for an
>> >>>>> example.
>> >>>>> >>
>> >>>>> >> On 4/12/12 2:35 PM, "Joe Bowser" <bo...@gmail.com> wrote:
>> >>>>> >>
>> >>>>> >> >Ready to tag once cordova-js is tagged 1.6.1.
>> >>>>> >> >
>> >>>>> >> >On Thu, Apr 12, 2012 at 2:33 PM, Anis KADRI <
>> anis.kadri@gmail.com>
>> >>>>> >>wrote:
>> >>>>> >> >
>> >>>>> >> >> I will tag my repository to 1.6.1 before end of day today after
>> >>>>>some
>> >>>>> >> >> thorough testing.
>> >>>>> >> >>
>> >>>>> >> >> On Thu, Apr 12, 2012 at 2:30 PM, Shazron <sh...@gmail.com>
>> >>>>>wrote:
>> >>>>> >> >>
>> >>>>> >> >> > I also created a 1.6.1 version tag as well in jira...
>> >>>>> >> >> >
>> >>>>> >> >> > On Thu, Apr 12, 2012 at 2:29 PM, Shazron <sh...@gmail.com>
>> >>>>> wrote:
>> >>>>> >> >> > > Alright guys since 1.6.0 was released, I'm going to
>> >>>>>"Release"
>> >>>>>the
>> >>>>> >> >> > > 1.6.0 version in jira and move outstanding issues to 1.7.0
>> >>>>> >>version
>> >>>>> >> >> > > tag.
>> >>>>> >> >> > >
>> >>>>> >> >> > >
>> >>>>> >> >> > > On Thu, Apr 12, 2012 at 2:26 PM, Filip Maj <fi...@adobe.com>
>> >>>>> wrote:
>> >>>>> >> >> > >> The JS needs patching too. Since adding the commit ID into
>> >>>>>the
>> >>>>> >> >> packaging
>> >>>>> >> >> > >> in the jakefile, the default task isn't running properly.
>> >>>>> >> >> > >>
>> >>>>> >> >> > >> You can manually run "jake build" and "jake test" but not
>> >>>>> >>"jake" on
>> >>>>> >> >> its
>> >>>>> >> >> > >> own - gonna try to figure it out.
>> >>>>> >> >> > >>
>> >>>>> >> >> > >> On 4/12/12 2:21 PM, "Shazron" <sh...@gmail.com> wrote:
>> >>>>> >> >> > >>
>> >>>>> >> >> > >>>I'm good with tagging. iOS has a few commits (one commit
>> >>>>>in
>> >>>>> >> >> > >>>cordova-js) as well. Aim for first thing tomorrow for you
>> >>>>>to
>> >>>>> >> >> > >>>repackage?
>> >>>>> >> >> > >>>
>> >>>>> >> >> > >>>On Thu, Apr 12, 2012 at 2:17 PM, Steven Gill
>> >>>>> >> >><st...@gmail.com>
>> >>>>> >> >> > >>>wrote:
>> >>>>> >> >> > >>>> So a bug has been discovered in Cordova Android that
>> >>>>>requires
>> >>>>> >>a
>> >>>>> >> >>new
>> >>>>> >> >> > tag
>> >>>>> >> >> > >>>>and
>> >>>>> >> >> > >>>> release. You can check out the bug on the issue tracker
>> >>>>>at
>> >>>>> >> >> > >>>>
>> >>>>> >> >> > >>>>
>> >>>>> >> >> >
>> >>>>> >> >>
>> >>>>> >> >>
>> >>>>> >>
>> >>>>> >>
>> >>>>>
>> >>>>>
>> https://issues.apache.org/jira/browse/CB-490?focusedCommentId=13252809#
>> >>>>>co
>> >>>>> >> >> > >>>>mment-13252809
>> >>>>> >> >> > >>>>
>> >>>>> >> >> > >>>> It doesn't make sense to just repackage 1.6.0 with this
>> >>>>>bug
>> >>>>> >> >>fixed as
>> >>>>> >> >> > we
>> >>>>> >> >> > >>>> will have no way to know if people are experiencing this
>> >>>>>or
>> >>>>> >>not.
>> >>>>> >> >> > >>>>
>> >>>>> >> >> > >>>> Anis mentioned Bada also had some major issues which he
>> >>>>>has
>> >>>>> >>fixed
>> >>>>> >> >> now
>> >>>>> >> >> > >>>>and
>> >>>>> >> >> > >>>> would like in a 1.6.1 release.
>> >>>>> >> >> > >>>>
>> >>>>> >> >> > >>>> Thoughts?
>> >>>>> >> >> > >>>>
>> >>>>> >> >> > >>>> -Steve
>> >>>>> >> >> > >>
>> >>>>> >> >> >
>> >>>>> >> >>
>> >>>>> >>
>> >>>>> >>
>> >>>>>
>> >>>>>
>> >>>
>> >
>>
Re: 1.6.1
Posted by Filip Maj <fi...@adobe.com>.
>The problem is that this parameter doesn't belong in the common API. It'd
>be just ignored in Android, but the whole point of cordova-js is so that
>it's common. It'd look pretty screwed up to add this to the docs, IMO.
Agreed - it'd also be ignored on all the other platforms other than iOS.
I'm just confused as to which bugs this fixes / why we need to change the
cross-platform API to fix a platform-specific bug?
Moving forward if we change the public API to a method we need to always
update the docs (what it's for and which platforms support it, at the very
least). This is at a _minimum_ in my mind. What's preferential to this is
to actually extend the other platforms to support the new API addition.
Re: 1.6.1
Posted by Joe Bowser <bo...@gmail.com>.
The problem is that this parameter doesn't belong in the common API. It'd
be just ignored in Android, but the whole point of cordova-js is so that
it's common. It'd look pretty screwed up to add this to the docs, IMO.
On Thu, Apr 12, 2012 at 3:26 PM, Shazron <sh...@gmail.com> wrote:
> To fix two bugs for Camera.takePicture on iOS
>
> On Thu, Apr 12, 2012 at 3:24 PM, Filip Maj <fi...@adobe.com> wrote:
> > so what's the point of this new parameter?
> >
> > On 4/12/12 3:16 PM, "Shazron" <sh...@gmail.com> wrote:
> >
> >>I did. Do we want to revert the cordova-js? I can branch 1.6.0 and
> >>cherry-pick your latest commit for 1.6.1
> >>
> >>On Thu, Apr 12, 2012 at 3:04 PM, Filip Maj <fi...@adobe.com> wrote:
> >>> I saw something in the iOS commit logs for this.
> >>>
> >>> Shaz can you comment?
> >>>
> >>> On 4/12/12 2:59 PM, "Joe Bowser" <bo...@gmail.com> wrote:
> >>>
> >>>>Can we revert this, since this looks like it's intended for both
> Android
> >>>>and iOS, but I don't think it should be in 1.6.1.
> >>>>
> >>>>On Thu, Apr 12, 2012 at 2:52 PM, Filip Maj <fi...@adobe.com> wrote:
> >>>>
> >>>>> I was actually just looking at that myself.
> >>>>>
> >>>>> Looks like it's an iOS-only param.. sigh. We gotta stop doing that,
> >>>>> especially if we don't update documentation.
> >>>>>
> >>>>> On 4/12/12 2:49 PM, "Joe Bowser" <bo...@gmail.com> wrote:
> >>>>>
> >>>>> >Has anyone tested the cropToSize param for Camera.getPicture yet? I
> >>>>> >didn't
> >>>>> >notice that change until now.
> >>>>> >
> >>>>> >On Thu, Apr 12, 2012 at 2:46 PM, Filip Maj <fi...@adobe.com> wrote:
> >>>>> >
> >>>>> >> JS tagged 1.6.1 - the build task in the JS should work properly
> >>>>>now.
> >>>>> >>
> >>>>> >> FYI if anyone has to modify the jake tasks in the future and make
> >>>>>them
> >>>>> >> async, make sure you add the 4th "async" parameter to the task()
> >>>>> >>function
> >>>>> >> and set it to true, and call complete() when the task is done.
> >>>>> >>
> >>>>> >> See http://howtonode.org/intro-to-jake/async-jakefile.js for an
> >>>>> example.
> >>>>> >>
> >>>>> >> On 4/12/12 2:35 PM, "Joe Bowser" <bo...@gmail.com> wrote:
> >>>>> >>
> >>>>> >> >Ready to tag once cordova-js is tagged 1.6.1.
> >>>>> >> >
> >>>>> >> >On Thu, Apr 12, 2012 at 2:33 PM, Anis KADRI <
> anis.kadri@gmail.com>
> >>>>> >>wrote:
> >>>>> >> >
> >>>>> >> >> I will tag my repository to 1.6.1 before end of day today after
> >>>>>some
> >>>>> >> >> thorough testing.
> >>>>> >> >>
> >>>>> >> >> On Thu, Apr 12, 2012 at 2:30 PM, Shazron <sh...@gmail.com>
> >>>>>wrote:
> >>>>> >> >>
> >>>>> >> >> > I also created a 1.6.1 version tag as well in jira...
> >>>>> >> >> >
> >>>>> >> >> > On Thu, Apr 12, 2012 at 2:29 PM, Shazron <sh...@gmail.com>
> >>>>> wrote:
> >>>>> >> >> > > Alright guys since 1.6.0 was released, I'm going to
> >>>>>"Release"
> >>>>>the
> >>>>> >> >> > > 1.6.0 version in jira and move outstanding issues to 1.7.0
> >>>>> >>version
> >>>>> >> >> > > tag.
> >>>>> >> >> > >
> >>>>> >> >> > >
> >>>>> >> >> > > On Thu, Apr 12, 2012 at 2:26 PM, Filip Maj <fi...@adobe.com>
> >>>>> wrote:
> >>>>> >> >> > >> The JS needs patching too. Since adding the commit ID into
> >>>>>the
> >>>>> >> >> packaging
> >>>>> >> >> > >> in the jakefile, the default task isn't running properly.
> >>>>> >> >> > >>
> >>>>> >> >> > >> You can manually run "jake build" and "jake test" but not
> >>>>> >>"jake" on
> >>>>> >> >> its
> >>>>> >> >> > >> own - gonna try to figure it out.
> >>>>> >> >> > >>
> >>>>> >> >> > >> On 4/12/12 2:21 PM, "Shazron" <sh...@gmail.com> wrote:
> >>>>> >> >> > >>
> >>>>> >> >> > >>>I'm good with tagging. iOS has a few commits (one commit
> >>>>>in
> >>>>> >> >> > >>>cordova-js) as well. Aim for first thing tomorrow for you
> >>>>>to
> >>>>> >> >> > >>>repackage?
> >>>>> >> >> > >>>
> >>>>> >> >> > >>>On Thu, Apr 12, 2012 at 2:17 PM, Steven Gill
> >>>>> >> >><st...@gmail.com>
> >>>>> >> >> > >>>wrote:
> >>>>> >> >> > >>>> So a bug has been discovered in Cordova Android that
> >>>>>requires
> >>>>> >>a
> >>>>> >> >>new
> >>>>> >> >> > tag
> >>>>> >> >> > >>>>and
> >>>>> >> >> > >>>> release. You can check out the bug on the issue tracker
> >>>>>at
> >>>>> >> >> > >>>>
> >>>>> >> >> > >>>>
> >>>>> >> >> >
> >>>>> >> >>
> >>>>> >> >>
> >>>>> >>
> >>>>> >>
> >>>>>
> >>>>>
> https://issues.apache.org/jira/browse/CB-490?focusedCommentId=13252809#
> >>>>>co
> >>>>> >> >> > >>>>mment-13252809
> >>>>> >> >> > >>>>
> >>>>> >> >> > >>>> It doesn't make sense to just repackage 1.6.0 with this
> >>>>>bug
> >>>>> >> >>fixed as
> >>>>> >> >> > we
> >>>>> >> >> > >>>> will have no way to know if people are experiencing this
> >>>>>or
> >>>>> >>not.
> >>>>> >> >> > >>>>
> >>>>> >> >> > >>>> Anis mentioned Bada also had some major issues which he
> >>>>>has
> >>>>> >>fixed
> >>>>> >> >> now
> >>>>> >> >> > >>>>and
> >>>>> >> >> > >>>> would like in a 1.6.1 release.
> >>>>> >> >> > >>>>
> >>>>> >> >> > >>>> Thoughts?
> >>>>> >> >> > >>>>
> >>>>> >> >> > >>>> -Steve
> >>>>> >> >> > >>
> >>>>> >> >> >
> >>>>> >> >>
> >>>>> >>
> >>>>> >>
> >>>>>
> >>>>>
> >>>
> >
>
Re: 1.6.1
Posted by Shazron <sh...@gmail.com>.
To fix two bugs for Camera.takePicture on iOS
On Thu, Apr 12, 2012 at 3:24 PM, Filip Maj <fi...@adobe.com> wrote:
> so what's the point of this new parameter?
>
> On 4/12/12 3:16 PM, "Shazron" <sh...@gmail.com> wrote:
>
>>I did. Do we want to revert the cordova-js? I can branch 1.6.0 and
>>cherry-pick your latest commit for 1.6.1
>>
>>On Thu, Apr 12, 2012 at 3:04 PM, Filip Maj <fi...@adobe.com> wrote:
>>> I saw something in the iOS commit logs for this.
>>>
>>> Shaz can you comment?
>>>
>>> On 4/12/12 2:59 PM, "Joe Bowser" <bo...@gmail.com> wrote:
>>>
>>>>Can we revert this, since this looks like it's intended for both Android
>>>>and iOS, but I don't think it should be in 1.6.1.
>>>>
>>>>On Thu, Apr 12, 2012 at 2:52 PM, Filip Maj <fi...@adobe.com> wrote:
>>>>
>>>>> I was actually just looking at that myself.
>>>>>
>>>>> Looks like it's an iOS-only param.. sigh. We gotta stop doing that,
>>>>> especially if we don't update documentation.
>>>>>
>>>>> On 4/12/12 2:49 PM, "Joe Bowser" <bo...@gmail.com> wrote:
>>>>>
>>>>> >Has anyone tested the cropToSize param for Camera.getPicture yet? I
>>>>> >didn't
>>>>> >notice that change until now.
>>>>> >
>>>>> >On Thu, Apr 12, 2012 at 2:46 PM, Filip Maj <fi...@adobe.com> wrote:
>>>>> >
>>>>> >> JS tagged 1.6.1 - the build task in the JS should work properly
>>>>>now.
>>>>> >>
>>>>> >> FYI if anyone has to modify the jake tasks in the future and make
>>>>>them
>>>>> >> async, make sure you add the 4th "async" parameter to the task()
>>>>> >>function
>>>>> >> and set it to true, and call complete() when the task is done.
>>>>> >>
>>>>> >> See http://howtonode.org/intro-to-jake/async-jakefile.js for an
>>>>> example.
>>>>> >>
>>>>> >> On 4/12/12 2:35 PM, "Joe Bowser" <bo...@gmail.com> wrote:
>>>>> >>
>>>>> >> >Ready to tag once cordova-js is tagged 1.6.1.
>>>>> >> >
>>>>> >> >On Thu, Apr 12, 2012 at 2:33 PM, Anis KADRI <an...@gmail.com>
>>>>> >>wrote:
>>>>> >> >
>>>>> >> >> I will tag my repository to 1.6.1 before end of day today after
>>>>>some
>>>>> >> >> thorough testing.
>>>>> >> >>
>>>>> >> >> On Thu, Apr 12, 2012 at 2:30 PM, Shazron <sh...@gmail.com>
>>>>>wrote:
>>>>> >> >>
>>>>> >> >> > I also created a 1.6.1 version tag as well in jira...
>>>>> >> >> >
>>>>> >> >> > On Thu, Apr 12, 2012 at 2:29 PM, Shazron <sh...@gmail.com>
>>>>> wrote:
>>>>> >> >> > > Alright guys since 1.6.0 was released, I'm going to
>>>>>"Release"
>>>>>the
>>>>> >> >> > > 1.6.0 version in jira and move outstanding issues to 1.7.0
>>>>> >>version
>>>>> >> >> > > tag.
>>>>> >> >> > >
>>>>> >> >> > >
>>>>> >> >> > > On Thu, Apr 12, 2012 at 2:26 PM, Filip Maj <fi...@adobe.com>
>>>>> wrote:
>>>>> >> >> > >> The JS needs patching too. Since adding the commit ID into
>>>>>the
>>>>> >> >> packaging
>>>>> >> >> > >> in the jakefile, the default task isn't running properly.
>>>>> >> >> > >>
>>>>> >> >> > >> You can manually run "jake build" and "jake test" but not
>>>>> >>"jake" on
>>>>> >> >> its
>>>>> >> >> > >> own - gonna try to figure it out.
>>>>> >> >> > >>
>>>>> >> >> > >> On 4/12/12 2:21 PM, "Shazron" <sh...@gmail.com> wrote:
>>>>> >> >> > >>
>>>>> >> >> > >>>I'm good with tagging. iOS has a few commits (one commit
>>>>>in
>>>>> >> >> > >>>cordova-js) as well. Aim for first thing tomorrow for you
>>>>>to
>>>>> >> >> > >>>repackage?
>>>>> >> >> > >>>
>>>>> >> >> > >>>On Thu, Apr 12, 2012 at 2:17 PM, Steven Gill
>>>>> >> >><st...@gmail.com>
>>>>> >> >> > >>>wrote:
>>>>> >> >> > >>>> So a bug has been discovered in Cordova Android that
>>>>>requires
>>>>> >>a
>>>>> >> >>new
>>>>> >> >> > tag
>>>>> >> >> > >>>>and
>>>>> >> >> > >>>> release. You can check out the bug on the issue tracker
>>>>>at
>>>>> >> >> > >>>>
>>>>> >> >> > >>>>
>>>>> >> >> >
>>>>> >> >>
>>>>> >> >>
>>>>> >>
>>>>> >>
>>>>>
>>>>>https://issues.apache.org/jira/browse/CB-490?focusedCommentId=13252809#
>>>>>co
>>>>> >> >> > >>>>mment-13252809
>>>>> >> >> > >>>>
>>>>> >> >> > >>>> It doesn't make sense to just repackage 1.6.0 with this
>>>>>bug
>>>>> >> >>fixed as
>>>>> >> >> > we
>>>>> >> >> > >>>> will have no way to know if people are experiencing this
>>>>>or
>>>>> >>not.
>>>>> >> >> > >>>>
>>>>> >> >> > >>>> Anis mentioned Bada also had some major issues which he
>>>>>has
>>>>> >>fixed
>>>>> >> >> now
>>>>> >> >> > >>>>and
>>>>> >> >> > >>>> would like in a 1.6.1 release.
>>>>> >> >> > >>>>
>>>>> >> >> > >>>> Thoughts?
>>>>> >> >> > >>>>
>>>>> >> >> > >>>> -Steve
>>>>> >> >> > >>
>>>>> >> >> >
>>>>> >> >>
>>>>> >>
>>>>> >>
>>>>>
>>>>>
>>>
>
Re: 1.6.1
Posted by Joe Bowser <bo...@gmail.com>.
git rebase -i HEAD~2
I can push up what I have and then we can go with that!
On Thu, Apr 12, 2012 at 3:16 PM, Shazron <sh...@gmail.com> wrote:
> I did. Do we want to revert the cordova-js? I can branch 1.6.0 and
> cherry-pick your latest commit for 1.6.1
>
> On Thu, Apr 12, 2012 at 3:04 PM, Filip Maj <fi...@adobe.com> wrote:
> > I saw something in the iOS commit logs for this.
> >
> > Shaz can you comment?
> >
> > On 4/12/12 2:59 PM, "Joe Bowser" <bo...@gmail.com> wrote:
> >
> >>Can we revert this, since this looks like it's intended for both Android
> >>and iOS, but I don't think it should be in 1.6.1.
> >>
> >>On Thu, Apr 12, 2012 at 2:52 PM, Filip Maj <fi...@adobe.com> wrote:
> >>
> >>> I was actually just looking at that myself.
> >>>
> >>> Looks like it's an iOS-only param.. sigh. We gotta stop doing that,
> >>> especially if we don't update documentation.
> >>>
> >>> On 4/12/12 2:49 PM, "Joe Bowser" <bo...@gmail.com> wrote:
> >>>
> >>> >Has anyone tested the cropToSize param for Camera.getPicture yet? I
> >>> >didn't
> >>> >notice that change until now.
> >>> >
> >>> >On Thu, Apr 12, 2012 at 2:46 PM, Filip Maj <fi...@adobe.com> wrote:
> >>> >
> >>> >> JS tagged 1.6.1 - the build task in the JS should work properly now.
> >>> >>
> >>> >> FYI if anyone has to modify the jake tasks in the future and make
> >>>them
> >>> >> async, make sure you add the 4th "async" parameter to the task()
> >>> >>function
> >>> >> and set it to true, and call complete() when the task is done.
> >>> >>
> >>> >> See http://howtonode.org/intro-to-jake/async-jakefile.js for an
> >>> example.
> >>> >>
> >>> >> On 4/12/12 2:35 PM, "Joe Bowser" <bo...@gmail.com> wrote:
> >>> >>
> >>> >> >Ready to tag once cordova-js is tagged 1.6.1.
> >>> >> >
> >>> >> >On Thu, Apr 12, 2012 at 2:33 PM, Anis KADRI <an...@gmail.com>
> >>> >>wrote:
> >>> >> >
> >>> >> >> I will tag my repository to 1.6.1 before end of day today after
> >>>some
> >>> >> >> thorough testing.
> >>> >> >>
> >>> >> >> On Thu, Apr 12, 2012 at 2:30 PM, Shazron <sh...@gmail.com>
> >>>wrote:
> >>> >> >>
> >>> >> >> > I also created a 1.6.1 version tag as well in jira...
> >>> >> >> >
> >>> >> >> > On Thu, Apr 12, 2012 at 2:29 PM, Shazron <sh...@gmail.com>
> >>> wrote:
> >>> >> >> > > Alright guys since 1.6.0 was released, I'm going to "Release"
> >>>the
> >>> >> >> > > 1.6.0 version in jira and move outstanding issues to 1.7.0
> >>> >>version
> >>> >> >> > > tag.
> >>> >> >> > >
> >>> >> >> > >
> >>> >> >> > > On Thu, Apr 12, 2012 at 2:26 PM, Filip Maj <fi...@adobe.com>
> >>> wrote:
> >>> >> >> > >> The JS needs patching too. Since adding the commit ID into
> >>>the
> >>> >> >> packaging
> >>> >> >> > >> in the jakefile, the default task isn't running properly.
> >>> >> >> > >>
> >>> >> >> > >> You can manually run "jake build" and "jake test" but not
> >>> >>"jake" on
> >>> >> >> its
> >>> >> >> > >> own - gonna try to figure it out.
> >>> >> >> > >>
> >>> >> >> > >> On 4/12/12 2:21 PM, "Shazron" <sh...@gmail.com> wrote:
> >>> >> >> > >>
> >>> >> >> > >>>I'm good with tagging. iOS has a few commits (one commit in
> >>> >> >> > >>>cordova-js) as well. Aim for first thing tomorrow for you to
> >>> >> >> > >>>repackage?
> >>> >> >> > >>>
> >>> >> >> > >>>On Thu, Apr 12, 2012 at 2:17 PM, Steven Gill
> >>> >> >><st...@gmail.com>
> >>> >> >> > >>>wrote:
> >>> >> >> > >>>> So a bug has been discovered in Cordova Android that
> >>>requires
> >>> >>a
> >>> >> >>new
> >>> >> >> > tag
> >>> >> >> > >>>>and
> >>> >> >> > >>>> release. You can check out the bug on the issue tracker at
> >>> >> >> > >>>>
> >>> >> >> > >>>>
> >>> >> >> >
> >>> >> >>
> >>> >> >>
> >>> >>
> >>> >>
> >>>
> >>>
> https://issues.apache.org/jira/browse/CB-490?focusedCommentId=13252809#co
> >>> >> >> > >>>>mment-13252809
> >>> >> >> > >>>>
> >>> >> >> > >>>> It doesn't make sense to just repackage 1.6.0 with this
> bug
> >>> >> >>fixed as
> >>> >> >> > we
> >>> >> >> > >>>> will have no way to know if people are experiencing this
> or
> >>> >>not.
> >>> >> >> > >>>>
> >>> >> >> > >>>> Anis mentioned Bada also had some major issues which he
> has
> >>> >>fixed
> >>> >> >> now
> >>> >> >> > >>>>and
> >>> >> >> > >>>> would like in a 1.6.1 release.
> >>> >> >> > >>>>
> >>> >> >> > >>>> Thoughts?
> >>> >> >> > >>>>
> >>> >> >> > >>>> -Steve
> >>> >> >> > >>
> >>> >> >> >
> >>> >> >>
> >>> >>
> >>> >>
> >>>
> >>>
> >
>
Re: 1.6.1
Posted by Filip Maj <fi...@adobe.com>.
so what's the point of this new parameter?
On 4/12/12 3:16 PM, "Shazron" <sh...@gmail.com> wrote:
>I did. Do we want to revert the cordova-js? I can branch 1.6.0 and
>cherry-pick your latest commit for 1.6.1
>
>On Thu, Apr 12, 2012 at 3:04 PM, Filip Maj <fi...@adobe.com> wrote:
>> I saw something in the iOS commit logs for this.
>>
>> Shaz can you comment?
>>
>> On 4/12/12 2:59 PM, "Joe Bowser" <bo...@gmail.com> wrote:
>>
>>>Can we revert this, since this looks like it's intended for both Android
>>>and iOS, but I don't think it should be in 1.6.1.
>>>
>>>On Thu, Apr 12, 2012 at 2:52 PM, Filip Maj <fi...@adobe.com> wrote:
>>>
>>>> I was actually just looking at that myself.
>>>>
>>>> Looks like it's an iOS-only param.. sigh. We gotta stop doing that,
>>>> especially if we don't update documentation.
>>>>
>>>> On 4/12/12 2:49 PM, "Joe Bowser" <bo...@gmail.com> wrote:
>>>>
>>>> >Has anyone tested the cropToSize param for Camera.getPicture yet? I
>>>> >didn't
>>>> >notice that change until now.
>>>> >
>>>> >On Thu, Apr 12, 2012 at 2:46 PM, Filip Maj <fi...@adobe.com> wrote:
>>>> >
>>>> >> JS tagged 1.6.1 - the build task in the JS should work properly
>>>>now.
>>>> >>
>>>> >> FYI if anyone has to modify the jake tasks in the future and make
>>>>them
>>>> >> async, make sure you add the 4th "async" parameter to the task()
>>>> >>function
>>>> >> and set it to true, and call complete() when the task is done.
>>>> >>
>>>> >> See http://howtonode.org/intro-to-jake/async-jakefile.js for an
>>>> example.
>>>> >>
>>>> >> On 4/12/12 2:35 PM, "Joe Bowser" <bo...@gmail.com> wrote:
>>>> >>
>>>> >> >Ready to tag once cordova-js is tagged 1.6.1.
>>>> >> >
>>>> >> >On Thu, Apr 12, 2012 at 2:33 PM, Anis KADRI <an...@gmail.com>
>>>> >>wrote:
>>>> >> >
>>>> >> >> I will tag my repository to 1.6.1 before end of day today after
>>>>some
>>>> >> >> thorough testing.
>>>> >> >>
>>>> >> >> On Thu, Apr 12, 2012 at 2:30 PM, Shazron <sh...@gmail.com>
>>>>wrote:
>>>> >> >>
>>>> >> >> > I also created a 1.6.1 version tag as well in jira...
>>>> >> >> >
>>>> >> >> > On Thu, Apr 12, 2012 at 2:29 PM, Shazron <sh...@gmail.com>
>>>> wrote:
>>>> >> >> > > Alright guys since 1.6.0 was released, I'm going to
>>>>"Release"
>>>>the
>>>> >> >> > > 1.6.0 version in jira and move outstanding issues to 1.7.0
>>>> >>version
>>>> >> >> > > tag.
>>>> >> >> > >
>>>> >> >> > >
>>>> >> >> > > On Thu, Apr 12, 2012 at 2:26 PM, Filip Maj <fi...@adobe.com>
>>>> wrote:
>>>> >> >> > >> The JS needs patching too. Since adding the commit ID into
>>>>the
>>>> >> >> packaging
>>>> >> >> > >> in the jakefile, the default task isn't running properly.
>>>> >> >> > >>
>>>> >> >> > >> You can manually run "jake build" and "jake test" but not
>>>> >>"jake" on
>>>> >> >> its
>>>> >> >> > >> own - gonna try to figure it out.
>>>> >> >> > >>
>>>> >> >> > >> On 4/12/12 2:21 PM, "Shazron" <sh...@gmail.com> wrote:
>>>> >> >> > >>
>>>> >> >> > >>>I'm good with tagging. iOS has a few commits (one commit
>>>>in
>>>> >> >> > >>>cordova-js) as well. Aim for first thing tomorrow for you
>>>>to
>>>> >> >> > >>>repackage?
>>>> >> >> > >>>
>>>> >> >> > >>>On Thu, Apr 12, 2012 at 2:17 PM, Steven Gill
>>>> >> >><st...@gmail.com>
>>>> >> >> > >>>wrote:
>>>> >> >> > >>>> So a bug has been discovered in Cordova Android that
>>>>requires
>>>> >>a
>>>> >> >>new
>>>> >> >> > tag
>>>> >> >> > >>>>and
>>>> >> >> > >>>> release. You can check out the bug on the issue tracker
>>>>at
>>>> >> >> > >>>>
>>>> >> >> > >>>>
>>>> >> >> >
>>>> >> >>
>>>> >> >>
>>>> >>
>>>> >>
>>>>
>>>>https://issues.apache.org/jira/browse/CB-490?focusedCommentId=13252809#
>>>>co
>>>> >> >> > >>>>mment-13252809
>>>> >> >> > >>>>
>>>> >> >> > >>>> It doesn't make sense to just repackage 1.6.0 with this
>>>>bug
>>>> >> >>fixed as
>>>> >> >> > we
>>>> >> >> > >>>> will have no way to know if people are experiencing this
>>>>or
>>>> >>not.
>>>> >> >> > >>>>
>>>> >> >> > >>>> Anis mentioned Bada also had some major issues which he
>>>>has
>>>> >>fixed
>>>> >> >> now
>>>> >> >> > >>>>and
>>>> >> >> > >>>> would like in a 1.6.1 release.
>>>> >> >> > >>>>
>>>> >> >> > >>>> Thoughts?
>>>> >> >> > >>>>
>>>> >> >> > >>>> -Steve
>>>> >> >> > >>
>>>> >> >> >
>>>> >> >>
>>>> >>
>>>> >>
>>>>
>>>>
>>
Re: 1.6.1
Posted by Shazron <sh...@gmail.com>.
I did. Do we want to revert the cordova-js? I can branch 1.6.0 and
cherry-pick your latest commit for 1.6.1
On Thu, Apr 12, 2012 at 3:04 PM, Filip Maj <fi...@adobe.com> wrote:
> I saw something in the iOS commit logs for this.
>
> Shaz can you comment?
>
> On 4/12/12 2:59 PM, "Joe Bowser" <bo...@gmail.com> wrote:
>
>>Can we revert this, since this looks like it's intended for both Android
>>and iOS, but I don't think it should be in 1.6.1.
>>
>>On Thu, Apr 12, 2012 at 2:52 PM, Filip Maj <fi...@adobe.com> wrote:
>>
>>> I was actually just looking at that myself.
>>>
>>> Looks like it's an iOS-only param.. sigh. We gotta stop doing that,
>>> especially if we don't update documentation.
>>>
>>> On 4/12/12 2:49 PM, "Joe Bowser" <bo...@gmail.com> wrote:
>>>
>>> >Has anyone tested the cropToSize param for Camera.getPicture yet? I
>>> >didn't
>>> >notice that change until now.
>>> >
>>> >On Thu, Apr 12, 2012 at 2:46 PM, Filip Maj <fi...@adobe.com> wrote:
>>> >
>>> >> JS tagged 1.6.1 - the build task in the JS should work properly now.
>>> >>
>>> >> FYI if anyone has to modify the jake tasks in the future and make
>>>them
>>> >> async, make sure you add the 4th "async" parameter to the task()
>>> >>function
>>> >> and set it to true, and call complete() when the task is done.
>>> >>
>>> >> See http://howtonode.org/intro-to-jake/async-jakefile.js for an
>>> example.
>>> >>
>>> >> On 4/12/12 2:35 PM, "Joe Bowser" <bo...@gmail.com> wrote:
>>> >>
>>> >> >Ready to tag once cordova-js is tagged 1.6.1.
>>> >> >
>>> >> >On Thu, Apr 12, 2012 at 2:33 PM, Anis KADRI <an...@gmail.com>
>>> >>wrote:
>>> >> >
>>> >> >> I will tag my repository to 1.6.1 before end of day today after
>>>some
>>> >> >> thorough testing.
>>> >> >>
>>> >> >> On Thu, Apr 12, 2012 at 2:30 PM, Shazron <sh...@gmail.com>
>>>wrote:
>>> >> >>
>>> >> >> > I also created a 1.6.1 version tag as well in jira...
>>> >> >> >
>>> >> >> > On Thu, Apr 12, 2012 at 2:29 PM, Shazron <sh...@gmail.com>
>>> wrote:
>>> >> >> > > Alright guys since 1.6.0 was released, I'm going to "Release"
>>>the
>>> >> >> > > 1.6.0 version in jira and move outstanding issues to 1.7.0
>>> >>version
>>> >> >> > > tag.
>>> >> >> > >
>>> >> >> > >
>>> >> >> > > On Thu, Apr 12, 2012 at 2:26 PM, Filip Maj <fi...@adobe.com>
>>> wrote:
>>> >> >> > >> The JS needs patching too. Since adding the commit ID into
>>>the
>>> >> >> packaging
>>> >> >> > >> in the jakefile, the default task isn't running properly.
>>> >> >> > >>
>>> >> >> > >> You can manually run "jake build" and "jake test" but not
>>> >>"jake" on
>>> >> >> its
>>> >> >> > >> own - gonna try to figure it out.
>>> >> >> > >>
>>> >> >> > >> On 4/12/12 2:21 PM, "Shazron" <sh...@gmail.com> wrote:
>>> >> >> > >>
>>> >> >> > >>>I'm good with tagging. iOS has a few commits (one commit in
>>> >> >> > >>>cordova-js) as well. Aim for first thing tomorrow for you to
>>> >> >> > >>>repackage?
>>> >> >> > >>>
>>> >> >> > >>>On Thu, Apr 12, 2012 at 2:17 PM, Steven Gill
>>> >> >><st...@gmail.com>
>>> >> >> > >>>wrote:
>>> >> >> > >>>> So a bug has been discovered in Cordova Android that
>>>requires
>>> >>a
>>> >> >>new
>>> >> >> > tag
>>> >> >> > >>>>and
>>> >> >> > >>>> release. You can check out the bug on the issue tracker at
>>> >> >> > >>>>
>>> >> >> > >>>>
>>> >> >> >
>>> >> >>
>>> >> >>
>>> >>
>>> >>
>>>
>>>https://issues.apache.org/jira/browse/CB-490?focusedCommentId=13252809#co
>>> >> >> > >>>>mment-13252809
>>> >> >> > >>>>
>>> >> >> > >>>> It doesn't make sense to just repackage 1.6.0 with this bug
>>> >> >>fixed as
>>> >> >> > we
>>> >> >> > >>>> will have no way to know if people are experiencing this or
>>> >>not.
>>> >> >> > >>>>
>>> >> >> > >>>> Anis mentioned Bada also had some major issues which he has
>>> >>fixed
>>> >> >> now
>>> >> >> > >>>>and
>>> >> >> > >>>> would like in a 1.6.1 release.
>>> >> >> > >>>>
>>> >> >> > >>>> Thoughts?
>>> >> >> > >>>>
>>> >> >> > >>>> -Steve
>>> >> >> > >>
>>> >> >> >
>>> >> >>
>>> >>
>>> >>
>>>
>>>
>
Re: 1.6.1
Posted by Joe Bowser <bo...@gmail.com>.
OK, I must have misread the ticket.
On Thu, Apr 12, 2012 at 3:00 PM, Shazron <sh...@gmail.com> wrote:
> No, it's only iOS.
>
> On Thu, Apr 12, 2012 at 2:59 PM, Joe Bowser <bo...@gmail.com> wrote:
> > Can we revert this, since this looks like it's intended for both Android
> > and iOS, but I don't think it should be in 1.6.1.
> >
> > On Thu, Apr 12, 2012 at 2:52 PM, Filip Maj <fi...@adobe.com> wrote:
> >
> >> I was actually just looking at that myself.
> >>
> >> Looks like it's an iOS-only param.. sigh. We gotta stop doing that,
> >> especially if we don't update documentation.
> >>
> >> On 4/12/12 2:49 PM, "Joe Bowser" <bo...@gmail.com> wrote:
> >>
> >> >Has anyone tested the cropToSize param for Camera.getPicture yet? I
> >> >didn't
> >> >notice that change until now.
> >> >
> >> >On Thu, Apr 12, 2012 at 2:46 PM, Filip Maj <fi...@adobe.com> wrote:
> >> >
> >> >> JS tagged 1.6.1 - the build task in the JS should work properly now.
> >> >>
> >> >> FYI if anyone has to modify the jake tasks in the future and make
> them
> >> >> async, make sure you add the 4th "async" parameter to the task()
> >> >>function
> >> >> and set it to true, and call complete() when the task is done.
> >> >>
> >> >> See http://howtonode.org/intro-to-jake/async-jakefile.js for an
> >> example.
> >> >>
> >> >> On 4/12/12 2:35 PM, "Joe Bowser" <bo...@gmail.com> wrote:
> >> >>
> >> >> >Ready to tag once cordova-js is tagged 1.6.1.
> >> >> >
> >> >> >On Thu, Apr 12, 2012 at 2:33 PM, Anis KADRI <an...@gmail.com>
> >> >>wrote:
> >> >> >
> >> >> >> I will tag my repository to 1.6.1 before end of day today after
> some
> >> >> >> thorough testing.
> >> >> >>
> >> >> >> On Thu, Apr 12, 2012 at 2:30 PM, Shazron <sh...@gmail.com>
> wrote:
> >> >> >>
> >> >> >> > I also created a 1.6.1 version tag as well in jira...
> >> >> >> >
> >> >> >> > On Thu, Apr 12, 2012 at 2:29 PM, Shazron <sh...@gmail.com>
> >> wrote:
> >> >> >> > > Alright guys since 1.6.0 was released, I'm going to "Release"
> the
> >> >> >> > > 1.6.0 version in jira and move outstanding issues to 1.7.0
> >> >>version
> >> >> >> > > tag.
> >> >> >> > >
> >> >> >> > >
> >> >> >> > > On Thu, Apr 12, 2012 at 2:26 PM, Filip Maj <fi...@adobe.com>
> >> wrote:
> >> >> >> > >> The JS needs patching too. Since adding the commit ID into
> the
> >> >> >> packaging
> >> >> >> > >> in the jakefile, the default task isn't running properly.
> >> >> >> > >>
> >> >> >> > >> You can manually run "jake build" and "jake test" but not
> >> >>"jake" on
> >> >> >> its
> >> >> >> > >> own - gonna try to figure it out.
> >> >> >> > >>
> >> >> >> > >> On 4/12/12 2:21 PM, "Shazron" <sh...@gmail.com> wrote:
> >> >> >> > >>
> >> >> >> > >>>I'm good with tagging. iOS has a few commits (one commit in
> >> >> >> > >>>cordova-js) as well. Aim for first thing tomorrow for you to
> >> >> >> > >>>repackage?
> >> >> >> > >>>
> >> >> >> > >>>On Thu, Apr 12, 2012 at 2:17 PM, Steven Gill
> >> >> >><st...@gmail.com>
> >> >> >> > >>>wrote:
> >> >> >> > >>>> So a bug has been discovered in Cordova Android that
> requires
> >> >>a
> >> >> >>new
> >> >> >> > tag
> >> >> >> > >>>>and
> >> >> >> > >>>> release. You can check out the bug on the issue tracker at
> >> >> >> > >>>>
> >> >> >> > >>>>
> >> >> >> >
> >> >> >>
> >> >> >>
> >> >>
> >> >>
> >>
> https://issues.apache.org/jira/browse/CB-490?focusedCommentId=13252809#co
> >> >> >> > >>>>mment-13252809
> >> >> >> > >>>>
> >> >> >> > >>>> It doesn't make sense to just repackage 1.6.0 with this bug
> >> >> >>fixed as
> >> >> >> > we
> >> >> >> > >>>> will have no way to know if people are experiencing this or
> >> >>not.
> >> >> >> > >>>>
> >> >> >> > >>>> Anis mentioned Bada also had some major issues which he has
> >> >>fixed
> >> >> >> now
> >> >> >> > >>>>and
> >> >> >> > >>>> would like in a 1.6.1 release.
> >> >> >> > >>>>
> >> >> >> > >>>> Thoughts?
> >> >> >> > >>>>
> >> >> >> > >>>> -Steve
> >> >> >> > >>
> >> >> >> >
> >> >> >>
> >> >>
> >> >>
> >>
> >>
>
Re: 1.6.1
Posted by Shazron <sh...@gmail.com>.
No, it's only iOS.
On Thu, Apr 12, 2012 at 2:59 PM, Joe Bowser <bo...@gmail.com> wrote:
> Can we revert this, since this looks like it's intended for both Android
> and iOS, but I don't think it should be in 1.6.1.
>
> On Thu, Apr 12, 2012 at 2:52 PM, Filip Maj <fi...@adobe.com> wrote:
>
>> I was actually just looking at that myself.
>>
>> Looks like it's an iOS-only param.. sigh. We gotta stop doing that,
>> especially if we don't update documentation.
>>
>> On 4/12/12 2:49 PM, "Joe Bowser" <bo...@gmail.com> wrote:
>>
>> >Has anyone tested the cropToSize param for Camera.getPicture yet? I
>> >didn't
>> >notice that change until now.
>> >
>> >On Thu, Apr 12, 2012 at 2:46 PM, Filip Maj <fi...@adobe.com> wrote:
>> >
>> >> JS tagged 1.6.1 - the build task in the JS should work properly now.
>> >>
>> >> FYI if anyone has to modify the jake tasks in the future and make them
>> >> async, make sure you add the 4th "async" parameter to the task()
>> >>function
>> >> and set it to true, and call complete() when the task is done.
>> >>
>> >> See http://howtonode.org/intro-to-jake/async-jakefile.js for an
>> example.
>> >>
>> >> On 4/12/12 2:35 PM, "Joe Bowser" <bo...@gmail.com> wrote:
>> >>
>> >> >Ready to tag once cordova-js is tagged 1.6.1.
>> >> >
>> >> >On Thu, Apr 12, 2012 at 2:33 PM, Anis KADRI <an...@gmail.com>
>> >>wrote:
>> >> >
>> >> >> I will tag my repository to 1.6.1 before end of day today after some
>> >> >> thorough testing.
>> >> >>
>> >> >> On Thu, Apr 12, 2012 at 2:30 PM, Shazron <sh...@gmail.com> wrote:
>> >> >>
>> >> >> > I also created a 1.6.1 version tag as well in jira...
>> >> >> >
>> >> >> > On Thu, Apr 12, 2012 at 2:29 PM, Shazron <sh...@gmail.com>
>> wrote:
>> >> >> > > Alright guys since 1.6.0 was released, I'm going to "Release" the
>> >> >> > > 1.6.0 version in jira and move outstanding issues to 1.7.0
>> >>version
>> >> >> > > tag.
>> >> >> > >
>> >> >> > >
>> >> >> > > On Thu, Apr 12, 2012 at 2:26 PM, Filip Maj <fi...@adobe.com>
>> wrote:
>> >> >> > >> The JS needs patching too. Since adding the commit ID into the
>> >> >> packaging
>> >> >> > >> in the jakefile, the default task isn't running properly.
>> >> >> > >>
>> >> >> > >> You can manually run "jake build" and "jake test" but not
>> >>"jake" on
>> >> >> its
>> >> >> > >> own - gonna try to figure it out.
>> >> >> > >>
>> >> >> > >> On 4/12/12 2:21 PM, "Shazron" <sh...@gmail.com> wrote:
>> >> >> > >>
>> >> >> > >>>I'm good with tagging. iOS has a few commits (one commit in
>> >> >> > >>>cordova-js) as well. Aim for first thing tomorrow for you to
>> >> >> > >>>repackage?
>> >> >> > >>>
>> >> >> > >>>On Thu, Apr 12, 2012 at 2:17 PM, Steven Gill
>> >> >><st...@gmail.com>
>> >> >> > >>>wrote:
>> >> >> > >>>> So a bug has been discovered in Cordova Android that requires
>> >>a
>> >> >>new
>> >> >> > tag
>> >> >> > >>>>and
>> >> >> > >>>> release. You can check out the bug on the issue tracker at
>> >> >> > >>>>
>> >> >> > >>>>
>> >> >> >
>> >> >>
>> >> >>
>> >>
>> >>
>> https://issues.apache.org/jira/browse/CB-490?focusedCommentId=13252809#co
>> >> >> > >>>>mment-13252809
>> >> >> > >>>>
>> >> >> > >>>> It doesn't make sense to just repackage 1.6.0 with this bug
>> >> >>fixed as
>> >> >> > we
>> >> >> > >>>> will have no way to know if people are experiencing this or
>> >>not.
>> >> >> > >>>>
>> >> >> > >>>> Anis mentioned Bada also had some major issues which he has
>> >>fixed
>> >> >> now
>> >> >> > >>>>and
>> >> >> > >>>> would like in a 1.6.1 release.
>> >> >> > >>>>
>> >> >> > >>>> Thoughts?
>> >> >> > >>>>
>> >> >> > >>>> -Steve
>> >> >> > >>
>> >> >> >
>> >> >>
>> >>
>> >>
>>
>>
Re: 1.6.1
Posted by Filip Maj <fi...@adobe.com>.
I saw something in the iOS commit logs for this.
Shaz can you comment?
On 4/12/12 2:59 PM, "Joe Bowser" <bo...@gmail.com> wrote:
>Can we revert this, since this looks like it's intended for both Android
>and iOS, but I don't think it should be in 1.6.1.
>
>On Thu, Apr 12, 2012 at 2:52 PM, Filip Maj <fi...@adobe.com> wrote:
>
>> I was actually just looking at that myself.
>>
>> Looks like it's an iOS-only param.. sigh. We gotta stop doing that,
>> especially if we don't update documentation.
>>
>> On 4/12/12 2:49 PM, "Joe Bowser" <bo...@gmail.com> wrote:
>>
>> >Has anyone tested the cropToSize param for Camera.getPicture yet? I
>> >didn't
>> >notice that change until now.
>> >
>> >On Thu, Apr 12, 2012 at 2:46 PM, Filip Maj <fi...@adobe.com> wrote:
>> >
>> >> JS tagged 1.6.1 - the build task in the JS should work properly now.
>> >>
>> >> FYI if anyone has to modify the jake tasks in the future and make
>>them
>> >> async, make sure you add the 4th "async" parameter to the task()
>> >>function
>> >> and set it to true, and call complete() when the task is done.
>> >>
>> >> See http://howtonode.org/intro-to-jake/async-jakefile.js for an
>> example.
>> >>
>> >> On 4/12/12 2:35 PM, "Joe Bowser" <bo...@gmail.com> wrote:
>> >>
>> >> >Ready to tag once cordova-js is tagged 1.6.1.
>> >> >
>> >> >On Thu, Apr 12, 2012 at 2:33 PM, Anis KADRI <an...@gmail.com>
>> >>wrote:
>> >> >
>> >> >> I will tag my repository to 1.6.1 before end of day today after
>>some
>> >> >> thorough testing.
>> >> >>
>> >> >> On Thu, Apr 12, 2012 at 2:30 PM, Shazron <sh...@gmail.com>
>>wrote:
>> >> >>
>> >> >> > I also created a 1.6.1 version tag as well in jira...
>> >> >> >
>> >> >> > On Thu, Apr 12, 2012 at 2:29 PM, Shazron <sh...@gmail.com>
>> wrote:
>> >> >> > > Alright guys since 1.6.0 was released, I'm going to "Release"
>>the
>> >> >> > > 1.6.0 version in jira and move outstanding issues to 1.7.0
>> >>version
>> >> >> > > tag.
>> >> >> > >
>> >> >> > >
>> >> >> > > On Thu, Apr 12, 2012 at 2:26 PM, Filip Maj <fi...@adobe.com>
>> wrote:
>> >> >> > >> The JS needs patching too. Since adding the commit ID into
>>the
>> >> >> packaging
>> >> >> > >> in the jakefile, the default task isn't running properly.
>> >> >> > >>
>> >> >> > >> You can manually run "jake build" and "jake test" but not
>> >>"jake" on
>> >> >> its
>> >> >> > >> own - gonna try to figure it out.
>> >> >> > >>
>> >> >> > >> On 4/12/12 2:21 PM, "Shazron" <sh...@gmail.com> wrote:
>> >> >> > >>
>> >> >> > >>>I'm good with tagging. iOS has a few commits (one commit in
>> >> >> > >>>cordova-js) as well. Aim for first thing tomorrow for you to
>> >> >> > >>>repackage?
>> >> >> > >>>
>> >> >> > >>>On Thu, Apr 12, 2012 at 2:17 PM, Steven Gill
>> >> >><st...@gmail.com>
>> >> >> > >>>wrote:
>> >> >> > >>>> So a bug has been discovered in Cordova Android that
>>requires
>> >>a
>> >> >>new
>> >> >> > tag
>> >> >> > >>>>and
>> >> >> > >>>> release. You can check out the bug on the issue tracker at
>> >> >> > >>>>
>> >> >> > >>>>
>> >> >> >
>> >> >>
>> >> >>
>> >>
>> >>
>>
>>https://issues.apache.org/jira/browse/CB-490?focusedCommentId=13252809#co
>> >> >> > >>>>mment-13252809
>> >> >> > >>>>
>> >> >> > >>>> It doesn't make sense to just repackage 1.6.0 with this bug
>> >> >>fixed as
>> >> >> > we
>> >> >> > >>>> will have no way to know if people are experiencing this or
>> >>not.
>> >> >> > >>>>
>> >> >> > >>>> Anis mentioned Bada also had some major issues which he has
>> >>fixed
>> >> >> now
>> >> >> > >>>>and
>> >> >> > >>>> would like in a 1.6.1 release.
>> >> >> > >>>>
>> >> >> > >>>> Thoughts?
>> >> >> > >>>>
>> >> >> > >>>> -Steve
>> >> >> > >>
>> >> >> >
>> >> >>
>> >>
>> >>
>>
>>
Re: 1.6.1
Posted by Joe Bowser <bo...@gmail.com>.
Can we revert this, since this looks like it's intended for both Android
and iOS, but I don't think it should be in 1.6.1.
On Thu, Apr 12, 2012 at 2:52 PM, Filip Maj <fi...@adobe.com> wrote:
> I was actually just looking at that myself.
>
> Looks like it's an iOS-only param.. sigh. We gotta stop doing that,
> especially if we don't update documentation.
>
> On 4/12/12 2:49 PM, "Joe Bowser" <bo...@gmail.com> wrote:
>
> >Has anyone tested the cropToSize param for Camera.getPicture yet? I
> >didn't
> >notice that change until now.
> >
> >On Thu, Apr 12, 2012 at 2:46 PM, Filip Maj <fi...@adobe.com> wrote:
> >
> >> JS tagged 1.6.1 - the build task in the JS should work properly now.
> >>
> >> FYI if anyone has to modify the jake tasks in the future and make them
> >> async, make sure you add the 4th "async" parameter to the task()
> >>function
> >> and set it to true, and call complete() when the task is done.
> >>
> >> See http://howtonode.org/intro-to-jake/async-jakefile.js for an
> example.
> >>
> >> On 4/12/12 2:35 PM, "Joe Bowser" <bo...@gmail.com> wrote:
> >>
> >> >Ready to tag once cordova-js is tagged 1.6.1.
> >> >
> >> >On Thu, Apr 12, 2012 at 2:33 PM, Anis KADRI <an...@gmail.com>
> >>wrote:
> >> >
> >> >> I will tag my repository to 1.6.1 before end of day today after some
> >> >> thorough testing.
> >> >>
> >> >> On Thu, Apr 12, 2012 at 2:30 PM, Shazron <sh...@gmail.com> wrote:
> >> >>
> >> >> > I also created a 1.6.1 version tag as well in jira...
> >> >> >
> >> >> > On Thu, Apr 12, 2012 at 2:29 PM, Shazron <sh...@gmail.com>
> wrote:
> >> >> > > Alright guys since 1.6.0 was released, I'm going to "Release" the
> >> >> > > 1.6.0 version in jira and move outstanding issues to 1.7.0
> >>version
> >> >> > > tag.
> >> >> > >
> >> >> > >
> >> >> > > On Thu, Apr 12, 2012 at 2:26 PM, Filip Maj <fi...@adobe.com>
> wrote:
> >> >> > >> The JS needs patching too. Since adding the commit ID into the
> >> >> packaging
> >> >> > >> in the jakefile, the default task isn't running properly.
> >> >> > >>
> >> >> > >> You can manually run "jake build" and "jake test" but not
> >>"jake" on
> >> >> its
> >> >> > >> own - gonna try to figure it out.
> >> >> > >>
> >> >> > >> On 4/12/12 2:21 PM, "Shazron" <sh...@gmail.com> wrote:
> >> >> > >>
> >> >> > >>>I'm good with tagging. iOS has a few commits (one commit in
> >> >> > >>>cordova-js) as well. Aim for first thing tomorrow for you to
> >> >> > >>>repackage?
> >> >> > >>>
> >> >> > >>>On Thu, Apr 12, 2012 at 2:17 PM, Steven Gill
> >> >><st...@gmail.com>
> >> >> > >>>wrote:
> >> >> > >>>> So a bug has been discovered in Cordova Android that requires
> >>a
> >> >>new
> >> >> > tag
> >> >> > >>>>and
> >> >> > >>>> release. You can check out the bug on the issue tracker at
> >> >> > >>>>
> >> >> > >>>>
> >> >> >
> >> >>
> >> >>
> >>
> >>
> https://issues.apache.org/jira/browse/CB-490?focusedCommentId=13252809#co
> >> >> > >>>>mment-13252809
> >> >> > >>>>
> >> >> > >>>> It doesn't make sense to just repackage 1.6.0 with this bug
> >> >>fixed as
> >> >> > we
> >> >> > >>>> will have no way to know if people are experiencing this or
> >>not.
> >> >> > >>>>
> >> >> > >>>> Anis mentioned Bada also had some major issues which he has
> >>fixed
> >> >> now
> >> >> > >>>>and
> >> >> > >>>> would like in a 1.6.1 release.
> >> >> > >>>>
> >> >> > >>>> Thoughts?
> >> >> > >>>>
> >> >> > >>>> -Steve
> >> >> > >>
> >> >> >
> >> >>
> >>
> >>
>
>
Re: 1.6.1
Posted by Filip Maj <fi...@adobe.com>.
I was actually just looking at that myself.
Looks like it's an iOS-only param.. sigh. We gotta stop doing that,
especially if we don't update documentation.
On 4/12/12 2:49 PM, "Joe Bowser" <bo...@gmail.com> wrote:
>Has anyone tested the cropToSize param for Camera.getPicture yet? I
>didn't
>notice that change until now.
>
>On Thu, Apr 12, 2012 at 2:46 PM, Filip Maj <fi...@adobe.com> wrote:
>
>> JS tagged 1.6.1 - the build task in the JS should work properly now.
>>
>> FYI if anyone has to modify the jake tasks in the future and make them
>> async, make sure you add the 4th "async" parameter to the task()
>>function
>> and set it to true, and call complete() when the task is done.
>>
>> See http://howtonode.org/intro-to-jake/async-jakefile.js for an example.
>>
>> On 4/12/12 2:35 PM, "Joe Bowser" <bo...@gmail.com> wrote:
>>
>> >Ready to tag once cordova-js is tagged 1.6.1.
>> >
>> >On Thu, Apr 12, 2012 at 2:33 PM, Anis KADRI <an...@gmail.com>
>>wrote:
>> >
>> >> I will tag my repository to 1.6.1 before end of day today after some
>> >> thorough testing.
>> >>
>> >> On Thu, Apr 12, 2012 at 2:30 PM, Shazron <sh...@gmail.com> wrote:
>> >>
>> >> > I also created a 1.6.1 version tag as well in jira...
>> >> >
>> >> > On Thu, Apr 12, 2012 at 2:29 PM, Shazron <sh...@gmail.com> wrote:
>> >> > > Alright guys since 1.6.0 was released, I'm going to "Release" the
>> >> > > 1.6.0 version in jira and move outstanding issues to 1.7.0
>>version
>> >> > > tag.
>> >> > >
>> >> > >
>> >> > > On Thu, Apr 12, 2012 at 2:26 PM, Filip Maj <fi...@adobe.com> wrote:
>> >> > >> The JS needs patching too. Since adding the commit ID into the
>> >> packaging
>> >> > >> in the jakefile, the default task isn't running properly.
>> >> > >>
>> >> > >> You can manually run "jake build" and "jake test" but not
>>"jake" on
>> >> its
>> >> > >> own - gonna try to figure it out.
>> >> > >>
>> >> > >> On 4/12/12 2:21 PM, "Shazron" <sh...@gmail.com> wrote:
>> >> > >>
>> >> > >>>I'm good with tagging. iOS has a few commits (one commit in
>> >> > >>>cordova-js) as well. Aim for first thing tomorrow for you to
>> >> > >>>repackage?
>> >> > >>>
>> >> > >>>On Thu, Apr 12, 2012 at 2:17 PM, Steven Gill
>> >><st...@gmail.com>
>> >> > >>>wrote:
>> >> > >>>> So a bug has been discovered in Cordova Android that requires
>>a
>> >>new
>> >> > tag
>> >> > >>>>and
>> >> > >>>> release. You can check out the bug on the issue tracker at
>> >> > >>>>
>> >> > >>>>
>> >> >
>> >>
>> >>
>>
>>https://issues.apache.org/jira/browse/CB-490?focusedCommentId=13252809#co
>> >> > >>>>mment-13252809
>> >> > >>>>
>> >> > >>>> It doesn't make sense to just repackage 1.6.0 with this bug
>> >>fixed as
>> >> > we
>> >> > >>>> will have no way to know if people are experiencing this or
>>not.
>> >> > >>>>
>> >> > >>>> Anis mentioned Bada also had some major issues which he has
>>fixed
>> >> now
>> >> > >>>>and
>> >> > >>>> would like in a 1.6.1 release.
>> >> > >>>>
>> >> > >>>> Thoughts?
>> >> > >>>>
>> >> > >>>> -Steve
>> >> > >>
>> >> >
>> >>
>>
>>
Re: 1.6.1
Posted by Joe Bowser <bo...@gmail.com>.
Has anyone tested the cropToSize param for Camera.getPicture yet? I didn't
notice that change until now.
On Thu, Apr 12, 2012 at 2:46 PM, Filip Maj <fi...@adobe.com> wrote:
> JS tagged 1.6.1 - the build task in the JS should work properly now.
>
> FYI if anyone has to modify the jake tasks in the future and make them
> async, make sure you add the 4th "async" parameter to the task() function
> and set it to true, and call complete() when the task is done.
>
> See http://howtonode.org/intro-to-jake/async-jakefile.js for an example.
>
> On 4/12/12 2:35 PM, "Joe Bowser" <bo...@gmail.com> wrote:
>
> >Ready to tag once cordova-js is tagged 1.6.1.
> >
> >On Thu, Apr 12, 2012 at 2:33 PM, Anis KADRI <an...@gmail.com> wrote:
> >
> >> I will tag my repository to 1.6.1 before end of day today after some
> >> thorough testing.
> >>
> >> On Thu, Apr 12, 2012 at 2:30 PM, Shazron <sh...@gmail.com> wrote:
> >>
> >> > I also created a 1.6.1 version tag as well in jira...
> >> >
> >> > On Thu, Apr 12, 2012 at 2:29 PM, Shazron <sh...@gmail.com> wrote:
> >> > > Alright guys since 1.6.0 was released, I'm going to "Release" the
> >> > > 1.6.0 version in jira and move outstanding issues to 1.7.0 version
> >> > > tag.
> >> > >
> >> > >
> >> > > On Thu, Apr 12, 2012 at 2:26 PM, Filip Maj <fi...@adobe.com> wrote:
> >> > >> The JS needs patching too. Since adding the commit ID into the
> >> packaging
> >> > >> in the jakefile, the default task isn't running properly.
> >> > >>
> >> > >> You can manually run "jake build" and "jake test" but not "jake" on
> >> its
> >> > >> own - gonna try to figure it out.
> >> > >>
> >> > >> On 4/12/12 2:21 PM, "Shazron" <sh...@gmail.com> wrote:
> >> > >>
> >> > >>>I'm good with tagging. iOS has a few commits (one commit in
> >> > >>>cordova-js) as well. Aim for first thing tomorrow for you to
> >> > >>>repackage?
> >> > >>>
> >> > >>>On Thu, Apr 12, 2012 at 2:17 PM, Steven Gill
> >><st...@gmail.com>
> >> > >>>wrote:
> >> > >>>> So a bug has been discovered in Cordova Android that requires a
> >>new
> >> > tag
> >> > >>>>and
> >> > >>>> release. You can check out the bug on the issue tracker at
> >> > >>>>
> >> > >>>>
> >> >
> >>
> >>
> https://issues.apache.org/jira/browse/CB-490?focusedCommentId=13252809#co
> >> > >>>>mment-13252809
> >> > >>>>
> >> > >>>> It doesn't make sense to just repackage 1.6.0 with this bug
> >>fixed as
> >> > we
> >> > >>>> will have no way to know if people are experiencing this or not.
> >> > >>>>
> >> > >>>> Anis mentioned Bada also had some major issues which he has fixed
> >> now
> >> > >>>>and
> >> > >>>> would like in a 1.6.1 release.
> >> > >>>>
> >> > >>>> Thoughts?
> >> > >>>>
> >> > >>>> -Steve
> >> > >>
> >> >
> >>
>
>
Re: 1.6.1
Posted by Filip Maj <fi...@adobe.com>.
JS tagged 1.6.1 - the build task in the JS should work properly now.
FYI if anyone has to modify the jake tasks in the future and make them
async, make sure you add the 4th "async" parameter to the task() function
and set it to true, and call complete() when the task is done.
See http://howtonode.org/intro-to-jake/async-jakefile.js for an example.
On 4/12/12 2:35 PM, "Joe Bowser" <bo...@gmail.com> wrote:
>Ready to tag once cordova-js is tagged 1.6.1.
>
>On Thu, Apr 12, 2012 at 2:33 PM, Anis KADRI <an...@gmail.com> wrote:
>
>> I will tag my repository to 1.6.1 before end of day today after some
>> thorough testing.
>>
>> On Thu, Apr 12, 2012 at 2:30 PM, Shazron <sh...@gmail.com> wrote:
>>
>> > I also created a 1.6.1 version tag as well in jira...
>> >
>> > On Thu, Apr 12, 2012 at 2:29 PM, Shazron <sh...@gmail.com> wrote:
>> > > Alright guys since 1.6.0 was released, I'm going to "Release" the
>> > > 1.6.0 version in jira and move outstanding issues to 1.7.0 version
>> > > tag.
>> > >
>> > >
>> > > On Thu, Apr 12, 2012 at 2:26 PM, Filip Maj <fi...@adobe.com> wrote:
>> > >> The JS needs patching too. Since adding the commit ID into the
>> packaging
>> > >> in the jakefile, the default task isn't running properly.
>> > >>
>> > >> You can manually run "jake build" and "jake test" but not "jake" on
>> its
>> > >> own - gonna try to figure it out.
>> > >>
>> > >> On 4/12/12 2:21 PM, "Shazron" <sh...@gmail.com> wrote:
>> > >>
>> > >>>I'm good with tagging. iOS has a few commits (one commit in
>> > >>>cordova-js) as well. Aim for first thing tomorrow for you to
>> > >>>repackage?
>> > >>>
>> > >>>On Thu, Apr 12, 2012 at 2:17 PM, Steven Gill
>><st...@gmail.com>
>> > >>>wrote:
>> > >>>> So a bug has been discovered in Cordova Android that requires a
>>new
>> > tag
>> > >>>>and
>> > >>>> release. You can check out the bug on the issue tracker at
>> > >>>>
>> > >>>>
>> >
>>
>>https://issues.apache.org/jira/browse/CB-490?focusedCommentId=13252809#co
>> > >>>>mment-13252809
>> > >>>>
>> > >>>> It doesn't make sense to just repackage 1.6.0 with this bug
>>fixed as
>> > we
>> > >>>> will have no way to know if people are experiencing this or not.
>> > >>>>
>> > >>>> Anis mentioned Bada also had some major issues which he has fixed
>> now
>> > >>>>and
>> > >>>> would like in a 1.6.1 release.
>> > >>>>
>> > >>>> Thoughts?
>> > >>>>
>> > >>>> -Steve
>> > >>
>> >
>>
Re: 1.6.1
Posted by Joe Bowser <bo...@gmail.com>.
Ready to tag once cordova-js is tagged 1.6.1.
On Thu, Apr 12, 2012 at 2:33 PM, Anis KADRI <an...@gmail.com> wrote:
> I will tag my repository to 1.6.1 before end of day today after some
> thorough testing.
>
> On Thu, Apr 12, 2012 at 2:30 PM, Shazron <sh...@gmail.com> wrote:
>
> > I also created a 1.6.1 version tag as well in jira...
> >
> > On Thu, Apr 12, 2012 at 2:29 PM, Shazron <sh...@gmail.com> wrote:
> > > Alright guys since 1.6.0 was released, I'm going to "Release" the
> > > 1.6.0 version in jira and move outstanding issues to 1.7.0 version
> > > tag.
> > >
> > >
> > > On Thu, Apr 12, 2012 at 2:26 PM, Filip Maj <fi...@adobe.com> wrote:
> > >> The JS needs patching too. Since adding the commit ID into the
> packaging
> > >> in the jakefile, the default task isn't running properly.
> > >>
> > >> You can manually run "jake build" and "jake test" but not "jake" on
> its
> > >> own - gonna try to figure it out.
> > >>
> > >> On 4/12/12 2:21 PM, "Shazron" <sh...@gmail.com> wrote:
> > >>
> > >>>I'm good with tagging. iOS has a few commits (one commit in
> > >>>cordova-js) as well. Aim for first thing tomorrow for you to
> > >>>repackage?
> > >>>
> > >>>On Thu, Apr 12, 2012 at 2:17 PM, Steven Gill <st...@gmail.com>
> > >>>wrote:
> > >>>> So a bug has been discovered in Cordova Android that requires a new
> > tag
> > >>>>and
> > >>>> release. You can check out the bug on the issue tracker at
> > >>>>
> > >>>>
> >
> https://issues.apache.org/jira/browse/CB-490?focusedCommentId=13252809#co
> > >>>>mment-13252809
> > >>>>
> > >>>> It doesn't make sense to just repackage 1.6.0 with this bug fixed as
> > we
> > >>>> will have no way to know if people are experiencing this or not.
> > >>>>
> > >>>> Anis mentioned Bada also had some major issues which he has fixed
> now
> > >>>>and
> > >>>> would like in a 1.6.1 release.
> > >>>>
> > >>>> Thoughts?
> > >>>>
> > >>>> -Steve
> > >>
> >
>
Re: 1.6.1
Posted by Anis KADRI <an...@gmail.com>.
I will tag my repository to 1.6.1 before end of day today after some
thorough testing.
On Thu, Apr 12, 2012 at 2:30 PM, Shazron <sh...@gmail.com> wrote:
> I also created a 1.6.1 version tag as well in jira...
>
> On Thu, Apr 12, 2012 at 2:29 PM, Shazron <sh...@gmail.com> wrote:
> > Alright guys since 1.6.0 was released, I'm going to "Release" the
> > 1.6.0 version in jira and move outstanding issues to 1.7.0 version
> > tag.
> >
> >
> > On Thu, Apr 12, 2012 at 2:26 PM, Filip Maj <fi...@adobe.com> wrote:
> >> The JS needs patching too. Since adding the commit ID into the packaging
> >> in the jakefile, the default task isn't running properly.
> >>
> >> You can manually run "jake build" and "jake test" but not "jake" on its
> >> own - gonna try to figure it out.
> >>
> >> On 4/12/12 2:21 PM, "Shazron" <sh...@gmail.com> wrote:
> >>
> >>>I'm good with tagging. iOS has a few commits (one commit in
> >>>cordova-js) as well. Aim for first thing tomorrow for you to
> >>>repackage?
> >>>
> >>>On Thu, Apr 12, 2012 at 2:17 PM, Steven Gill <st...@gmail.com>
> >>>wrote:
> >>>> So a bug has been discovered in Cordova Android that requires a new
> tag
> >>>>and
> >>>> release. You can check out the bug on the issue tracker at
> >>>>
> >>>>
> https://issues.apache.org/jira/browse/CB-490?focusedCommentId=13252809#co
> >>>>mment-13252809
> >>>>
> >>>> It doesn't make sense to just repackage 1.6.0 with this bug fixed as
> we
> >>>> will have no way to know if people are experiencing this or not.
> >>>>
> >>>> Anis mentioned Bada also had some major issues which he has fixed now
> >>>>and
> >>>> would like in a 1.6.1 release.
> >>>>
> >>>> Thoughts?
> >>>>
> >>>> -Steve
> >>
>
Re: 1.6.1
Posted by Shazron <sh...@gmail.com>.
I also created a 1.6.1 version tag as well in jira...
On Thu, Apr 12, 2012 at 2:29 PM, Shazron <sh...@gmail.com> wrote:
> Alright guys since 1.6.0 was released, I'm going to "Release" the
> 1.6.0 version in jira and move outstanding issues to 1.7.0 version
> tag.
>
>
> On Thu, Apr 12, 2012 at 2:26 PM, Filip Maj <fi...@adobe.com> wrote:
>> The JS needs patching too. Since adding the commit ID into the packaging
>> in the jakefile, the default task isn't running properly.
>>
>> You can manually run "jake build" and "jake test" but not "jake" on its
>> own - gonna try to figure it out.
>>
>> On 4/12/12 2:21 PM, "Shazron" <sh...@gmail.com> wrote:
>>
>>>I'm good with tagging. iOS has a few commits (one commit in
>>>cordova-js) as well. Aim for first thing tomorrow for you to
>>>repackage?
>>>
>>>On Thu, Apr 12, 2012 at 2:17 PM, Steven Gill <st...@gmail.com>
>>>wrote:
>>>> So a bug has been discovered in Cordova Android that requires a new tag
>>>>and
>>>> release. You can check out the bug on the issue tracker at
>>>>
>>>>https://issues.apache.org/jira/browse/CB-490?focusedCommentId=13252809#co
>>>>mment-13252809
>>>>
>>>> It doesn't make sense to just repackage 1.6.0 with this bug fixed as we
>>>> will have no way to know if people are experiencing this or not.
>>>>
>>>> Anis mentioned Bada also had some major issues which he has fixed now
>>>>and
>>>> would like in a 1.6.1 release.
>>>>
>>>> Thoughts?
>>>>
>>>> -Steve
>>
Re: 1.6.1
Posted by Shazron <sh...@gmail.com>.
Alright guys since 1.6.0 was released, I'm going to "Release" the
1.6.0 version in jira and move outstanding issues to 1.7.0 version
tag.
On Thu, Apr 12, 2012 at 2:26 PM, Filip Maj <fi...@adobe.com> wrote:
> The JS needs patching too. Since adding the commit ID into the packaging
> in the jakefile, the default task isn't running properly.
>
> You can manually run "jake build" and "jake test" but not "jake" on its
> own - gonna try to figure it out.
>
> On 4/12/12 2:21 PM, "Shazron" <sh...@gmail.com> wrote:
>
>>I'm good with tagging. iOS has a few commits (one commit in
>>cordova-js) as well. Aim for first thing tomorrow for you to
>>repackage?
>>
>>On Thu, Apr 12, 2012 at 2:17 PM, Steven Gill <st...@gmail.com>
>>wrote:
>>> So a bug has been discovered in Cordova Android that requires a new tag
>>>and
>>> release. You can check out the bug on the issue tracker at
>>>
>>>https://issues.apache.org/jira/browse/CB-490?focusedCommentId=13252809#co
>>>mment-13252809
>>>
>>> It doesn't make sense to just repackage 1.6.0 with this bug fixed as we
>>> will have no way to know if people are experiencing this or not.
>>>
>>> Anis mentioned Bada also had some major issues which he has fixed now
>>>and
>>> would like in a 1.6.1 release.
>>>
>>> Thoughts?
>>>
>>> -Steve
>
Re: 1.6.1
Posted by Filip Maj <fi...@adobe.com>.
The JS needs patching too. Since adding the commit ID into the packaging
in the jakefile, the default task isn't running properly.
You can manually run "jake build" and "jake test" but not "jake" on its
own - gonna try to figure it out.
On 4/12/12 2:21 PM, "Shazron" <sh...@gmail.com> wrote:
>I'm good with tagging. iOS has a few commits (one commit in
>cordova-js) as well. Aim for first thing tomorrow for you to
>repackage?
>
>On Thu, Apr 12, 2012 at 2:17 PM, Steven Gill <st...@gmail.com>
>wrote:
>> So a bug has been discovered in Cordova Android that requires a new tag
>>and
>> release. You can check out the bug on the issue tracker at
>>
>>https://issues.apache.org/jira/browse/CB-490?focusedCommentId=13252809#co
>>mment-13252809
>>
>> It doesn't make sense to just repackage 1.6.0 with this bug fixed as we
>> will have no way to know if people are experiencing this or not.
>>
>> Anis mentioned Bada also had some major issues which he has fixed now
>>and
>> would like in a 1.6.1 release.
>>
>> Thoughts?
>>
>> -Steve
Re: 1.6.1
Posted by Shazron <sh...@gmail.com>.
I'm good with tagging. iOS has a few commits (one commit in
cordova-js) as well. Aim for first thing tomorrow for you to
repackage?
On Thu, Apr 12, 2012 at 2:17 PM, Steven Gill <st...@gmail.com> wrote:
> So a bug has been discovered in Cordova Android that requires a new tag and
> release. You can check out the bug on the issue tracker at
> https://issues.apache.org/jira/browse/CB-490?focusedCommentId=13252809#comment-13252809
>
> It doesn't make sense to just repackage 1.6.0 with this bug fixed as we
> will have no way to know if people are experiencing this or not.
>
> Anis mentioned Bada also had some major issues which he has fixed now and
> would like in a 1.6.1 release.
>
> Thoughts?
>
> -Steve