You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by "pdxcodemonkey (GitHub)" <gi...@apache.org> on 2018/09/13 13:40:56 UTC
[GitHub] [geode-native] pdxcodemonkey opened pull request #352:
GEODE-4338: Add C++ Continuous Query Example
[ Full content available at: https://github.com/apache/geode-native/pull/352 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode-native] pivotal-jbarrett commented on pull request
#352: GEODE-4338: Add C++ Continuous Query Example
Posted by "pivotal-jbarrett (GitHub)" <gi...@apache.org>.
Formatting? Why did you move from right to left spacing? I believe all the other sources and most of Geode is right spaced.
[ Full content available at: https://github.com/apache/geode-native/pull/352 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode-native] pivotal-jbarrett commented on pull request
#352: GEODE-4338: Add C++ Continuous Query Example
Posted by "pivotal-jbarrett (GitHub)" <gi...@apache.org>.
Why muddy the example with types we have to cast?
[ Full content available at: https://github.com/apache/geode-native/pull/352 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode-native] pdxcodemonkey commented on pull request #352:
GEODE-4338: Add C++ Continuous Query Example
Posted by "pdxcodemonkey (GitHub)" <gi...@apache.org>.
I ran the clang-format tool in CLion, apparently it didn't do everything "our" way, go figure.
[ Full content available at: https://github.com/apache/geode-native/pull/352 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode-native] pdxcodemonkey commented on pull request #352:
GEODE-4338: Add C++ Continuous Query Example
Posted by "pdxcodemonkey (GitHub)" <gi...@apache.org>.
Fixed
[ Full content available at: https://github.com/apache/geode-native/pull/352 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode-native] pivotal-jbarrett commented on pull request
#352: GEODE-4338: Add C++ Continuous Query Example
Posted by "pivotal-jbarrett (GitHub)" <gi...@apache.org>.
Formatting seems inconsistent
[ Full content available at: https://github.com/apache/geode-native/pull/352 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode-native] pivotal-jbarrett commented on pull request
#352: GEODE-4338: Add C++ Continuous Query Example
Posted by "pivotal-jbarrett (GitHub)" <gi...@apache.org>.
Obvious comments should be omitted.
[ Full content available at: https://github.com/apache/geode-native/pull/352 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode-native] pdxcodemonkey commented on pull request #352:
GEODE-4338: Add C++ Continuous Query Example
Posted by "pdxcodemonkey (GitHub)" <gi...@apache.org>.
Yeah, kinda silly. Fixed types, and fixed in other copies of Order.cpp/Order.hpp in examples.
[ Full content available at: https://github.com/apache/geode-native/pull/352 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode-native] pivotal-jbarrett commented on pull request
#352: GEODE-4338: Add C++ Continuous Query Example
Posted by "pivotal-jbarrett (GitHub)" <gi...@apache.org>.
Auto
[ Full content available at: https://github.com/apache/geode-native/pull/352 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode-native] pdxcodemonkey commented on pull request #352:
GEODE-4338: Add C++ Continuous Query Example
Posted by "pdxcodemonkey (GitHub)" <gi...@apache.org>.
Fixed
[ Full content available at: https://github.com/apache/geode-native/pull/352 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode-native] pdxcodemonkey commented on pull request #352:
GEODE-4338: Add C++ Continuous Query Example
Posted by "pdxcodemonkey (GitHub)" <gi...@apache.org>.
Removed tabs and fixed indentation
[ Full content available at: https://github.com/apache/geode-native/pull/352 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode-native] pivotal-jbarrett commented on pull request
#352: GEODE-4338: Add C++ Continuous Query Example
Posted by "pivotal-jbarrett (GitHub)" <gi...@apache.org>.
If the file has a majority in one direction the formatting rule puts them all to the majority direction. When starting a new file you should prefer right. I suggest updating your formatting rules in CLion to auto format right and then clang format will keep the file in line.
[ Full content available at: https://github.com/apache/geode-native/pull/352 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode-native] pdxcodemonkey closed pull request #352:
GEODE-4338: Add C++ Continuous Query Example
Posted by "pdxcodemonkey (GitHub)" <gi...@apache.org>.
[ pull request closed by pdxcodemonkey ]
[ Full content available at: https://github.com/apache/geode-native/pull/352 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org