You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@aurora.apache.org by Zane Silver <zs...@luminatewireless.com> on 2015/07/22 20:06:20 UTC

Review Request 36697: Added fix for client to connect to correct zookeeper-hosts address/port pairs

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36697/
-----------------------------------------------------------

Review request for Aurora.

Repository: aurora

Description
-------

Added fix for Aurora client to connect to correct zookeeper-hosts address/port pairs.

When more than one zookeeper host was specified in the clusters.json file, only the last host was accessed through the specified zk_port. The client would attempt to connect to all other zookeeper hosts using the default port (2181).

For example, in clusters.json:
[{
"name": "<my_cluster>",
"zk": "host1.domain.com,host2.domain.com,host3.domain.com",
"zk_port": 2626,
"scheduler_zk_path": "/cluster/aurora/scheduler",
"slave_run_directory": "latest"
}
...
]
I found that the client would attempt to access the zk hosts addresses host1.domain.com:2181, host1.domain.com:2181, and host3.domain.com:2626. Thus, the "zk_port" attribute would only update the last host in the host string-list. This change allows the client to properly connect to multiple zookeeper hosts using a port other than the specified port.

Note, that the KazooClient accepts a comma-separated string of hosts.

Diffs
-----

src/main/python/apache/aurora/client/api/scheduler_client.py b8361b82476416d2d7370ab6b170423945d0b4a2

Diff: https://reviews.apache.org/r/36697/diff/

Testing
-------

This is a simple change, but tested to make sure client can still connect to each zookeeper host. Then verified that all hosts are now accessed through the correct port, not just the default (port 2181). Also viewable by Aurora client INFO logs.

Thanks,

Zane Silver

Re: Review Request 36697: Added fix for client to connect to correct zookeeper-hosts address/port pairs

Posted by Zameer Manji <zm...@apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36697/#review92657
-----------------------------------------------------------


This change is now on master. Thanks for your constribution.

- Zameer Manji


On July 22, 2015, 11:29 a.m., Zane Silver wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36697/
> -----------------------------------------------------------
> 
> (Updated July 22, 2015, 11:29 a.m.)
> 
> 
> Review request for Aurora and Zameer Manji.
> 
> 
> Bugs: AURORA-1405
>     https://issues.apache.org/jira/browse/AURORA-1405
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Added fix for Aurora client to connect to correct zookeeper-hosts address/port pairs.
> 
> When more than one zookeeper host was specified in the clusters.json file, only the last host was accessed through the specified zk_port. The client would attempt to connect to all other zookeeper hosts using the default port (2181).
> 
> For example, in clusters.json:
> [{
>   "name": "<my_cluster>",
>   "zk": "host1.domain.com,host2.domain.com,host3.domain.com",
>   "zk_port": 2626,
>   "scheduler_zk_path": "/cluster/aurora/scheduler",
>   "slave_run_directory": "latest"
> }
> ...
> ]
> I found that the client would attempt to access the zk hosts addresses host1.domain.com:2181, host1.domain.com:2181, and host3.domain.com:2626. Thus, the "zk_port" attribute would only update the last host in the host string-list. This change allows the client to properly connect to multiple zookeeper hosts using a port other than the specified port.
> 
> Note, that the KazooClient accepts a comma-separated string of hosts.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/client/api/scheduler_client.py b8361b82476416d2d7370ab6b170423945d0b4a2 
> 
> Diff: https://reviews.apache.org/r/36697/diff/
> 
> 
> Testing
> -------
> 
> This is a simple change, but tested to make sure client can still connect to each zookeeper host. Then verified that all hosts are now accessed through the correct port, not just the default (port 2181). Also viewable by Aurora client INFO logs.
> 
> 
> Thanks,
> 
> Zane Silver
> 
>

Re: Review Request 36697: Added fix for client to connect to correct zookeeper-hosts address/port pairs

Posted by Zameer Manji <zm...@apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36697/#review92654
-----------------------------------------------------------

Ship it!


Ship It!

- Zameer Manji


On July 22, 2015, 11:29 a.m., Zane Silver wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36697/
> -----------------------------------------------------------
> 
> (Updated July 22, 2015, 11:29 a.m.)
> 
> 
> Review request for Aurora and Zameer Manji.
> 
> 
> Bugs: AURORA-1405
>     https://issues.apache.org/jira/browse/AURORA-1405
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Added fix for Aurora client to connect to correct zookeeper-hosts address/port pairs.
> 
> When more than one zookeeper host was specified in the clusters.json file, only the last host was accessed through the specified zk_port. The client would attempt to connect to all other zookeeper hosts using the default port (2181).
> 
> For example, in clusters.json:
> [{
>   "name": "<my_cluster>",
>   "zk": "host1.domain.com,host2.domain.com,host3.domain.com",
>   "zk_port": 2626,
>   "scheduler_zk_path": "/cluster/aurora/scheduler",
>   "slave_run_directory": "latest"
> }
> ...
> ]
> I found that the client would attempt to access the zk hosts addresses host1.domain.com:2181, host1.domain.com:2181, and host3.domain.com:2626. Thus, the "zk_port" attribute would only update the last host in the host string-list. This change allows the client to properly connect to multiple zookeeper hosts using a port other than the specified port.
> 
> Note, that the KazooClient accepts a comma-separated string of hosts.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/client/api/scheduler_client.py b8361b82476416d2d7370ab6b170423945d0b4a2 
> 
> Diff: https://reviews.apache.org/r/36697/diff/
> 
> 
> Testing
> -------
> 
> This is a simple change, but tested to make sure client can still connect to each zookeeper host. Then verified that all hosts are now accessed through the correct port, not just the default (port 2181). Also viewable by Aurora client INFO logs.
> 
> 
> Thanks,
> 
> Zane Silver
> 
>

Re: Review Request 36697: Added fix for client to connect to correct zookeeper-hosts address/port pairs

Posted by Zane Silver <zs...@luminatewireless.com>.

(Updated July 22, 2015, 6:29 p.m.)

Review request for Aurora and Zameer Manji.

Bugs: AURORA-1405
https://issues.apache.org/jira/browse/AURORA-1405

Repository: aurora

Description
-------

Added fix for Aurora client to connect to correct zookeeper-hosts address/port pairs.

Note, that the KazooClient accepts a comma-separated string of hosts.

Diffs
-----

src/main/python/apache/aurora/client/api/scheduler_client.py b8361b82476416d2d7370ab6b170423945d0b4a2

Diff: https://reviews.apache.org/r/36697/diff/

Testing
-------

Thanks,

Zane Silver

Re: Review Request 36697: Added fix for client to connect to correct zookeeper-hosts address/port pairs

Posted by Zane Silver <zs...@luminatewireless.com>.

(Updated July 22, 2015, 6:27 p.m.)

Review request for Aurora and Zameer Manji.

Bugs: https://issues.apache.org/jira/browse/AURORA-1405
https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/AURORA-1405

Repository: aurora

Description
-------

Added fix for Aurora client to connect to correct zookeeper-hosts address/port pairs.

Note, that the KazooClient accepts a comma-separated string of hosts.

Diffs
-----

src/main/python/apache/aurora/client/api/scheduler_client.py b8361b82476416d2d7370ab6b170423945d0b4a2

Diff: https://reviews.apache.org/r/36697/diff/

Testing
-------

Thanks,

Zane Silver

Re: Review Request 36697: Added fix for client to connect to correct zookeeper-hosts address/port pairs

Posted by Aurora ReviewBot <wf...@apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36697/#review92623
-----------------------------------------------------------


Master (b64f7b6) is green with this patch.
  ./build-support/jenkins/build.sh

However, it appears that it might lack test coverage.

I will refresh this build result if you post a review containing "@ReviewBot retry"

- Aurora ReviewBot


On July 22, 2015, 6:06 p.m., Zane Silver wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36697/
> -----------------------------------------------------------
> 
> (Updated July 22, 2015, 6:06 p.m.)
> 
> 
> Review request for Aurora.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Added fix for Aurora client to connect to correct zookeeper-hosts address/port pairs.
> 
> When more than one zookeeper host was specified in the clusters.json file, only the last host was accessed through the specified zk_port. The client would attempt to connect to all other zookeeper hosts using the default port (2181).
> 
> For example, in clusters.json:
> [{
>   "name": "<my_cluster>",
>   "zk": "host1.domain.com,host2.domain.com,host3.domain.com",
>   "zk_port": 2626,
>   "scheduler_zk_path": "/cluster/aurora/scheduler",
>   "slave_run_directory": "latest"
> }
> ...
> ]
> I found that the client would attempt to access the zk hosts addresses host1.domain.com:2181, host1.domain.com:2181, and host3.domain.com:2626. Thus, the "zk_port" attribute would only update the last host in the host string-list. This change allows the client to properly connect to multiple zookeeper hosts using a port other than the specified port.
> 
> Note, that the KazooClient accepts a comma-separated string of hosts.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/client/api/scheduler_client.py b8361b82476416d2d7370ab6b170423945d0b4a2 
> 
> Diff: https://reviews.apache.org/r/36697/diff/
> 
> 
> Testing
> -------
> 
> This is a simple change, but tested to make sure client can still connect to each zookeeper host. Then verified that all hosts are now accessed through the correct port, not just the default (port 2181). Also viewable by Aurora client INFO logs.
> 
> 
> Thanks,
> 
> Zane Silver
> 
>

Re: Review Request 36697: Added fix for client to connect to correct zookeeper-hosts address/port pairs

Posted by Zameer Manji <zm...@apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36697/#review92619
-----------------------------------------------------------


Hi, thanks for your contribution!

Would you mind updating this review by linking to a ticket (bugs field) and adding myself (zmanji) under the People field?

- Zameer Manji


On July 22, 2015, 11:06 a.m., Zane Silver wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36697/
> -----------------------------------------------------------
> 
> (Updated July 22, 2015, 11:06 a.m.)
> 
> 
> Review request for Aurora.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Added fix for Aurora client to connect to correct zookeeper-hosts address/port pairs.
> 
> When more than one zookeeper host was specified in the clusters.json file, only the last host was accessed through the specified zk_port. The client would attempt to connect to all other zookeeper hosts using the default port (2181).
> 
> For example, in clusters.json:
> [{
>   "name": "<my_cluster>",
>   "zk": "host1.domain.com,host2.domain.com,host3.domain.com",
>   "zk_port": 2626,
>   "scheduler_zk_path": "/cluster/aurora/scheduler",
>   "slave_run_directory": "latest"
> }
> ...
> ]
> I found that the client would attempt to access the zk hosts addresses host1.domain.com:2181, host1.domain.com:2181, and host3.domain.com:2626. Thus, the "zk_port" attribute would only update the last host in the host string-list. This change allows the client to properly connect to multiple zookeeper hosts using a port other than the specified port.
> 
> Note, that the KazooClient accepts a comma-separated string of hosts.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/client/api/scheduler_client.py b8361b82476416d2d7370ab6b170423945d0b4a2 
> 
> Diff: https://reviews.apache.org/r/36697/diff/
> 
> 
> Testing
> -------
> 
> This is a simple change, but tested to make sure client can still connect to each zookeeper host. Then verified that all hosts are now accessed through the correct port, not just the default (port 2181). Also viewable by Aurora client INFO logs.
> 
> 
> Thanks,
> 
> Zane Silver
> 
>