You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by mcgilman <gi...@git.apache.org> on 2017/05/11 18:54:12 UTC
[GitHub] nifi pull request #1784: NIFI-3853: Filtering out control characters
GitHub user mcgilman opened a pull request:
https://github.com/apache/nifi/pull/1784
NIFI-3853: Filtering out control characters
NIFI-3853:
- Filtering out certain control characters and unpaired Unicode surrogate codepoints prior to saving the flow.xml.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mcgilman/nifi NIFI-3853
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/1784.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1784
----
commit b5ee18a17bdedc1e5c01b3f05f8e1f0f4106dd86
Author: Matt Gilman <ma...@gmail.com>
Date: 2017-05-11T18:51:50Z
NIFI-3853:
- Filtering out certain control characters and unpaired Unicode surrogate codepoints prior to saving the flow.xml.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request #1784: NIFI-3853: Filtering out control characters
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/nifi/pull/1784
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #1784: NIFI-3853: Filtering out control characters
Posted by alopresto <gi...@git.apache.org>.
Github user alopresto commented on the issue:
https://github.com/apache/nifi/pull/1784
Is there any scenario in which these characters are valid and necessary? I can understand not needing them in labels, component names, etc., but how are they handled if entered into a text field for a processor property that needs them (i.e. byte boundary searching, control characters, etc.)? An alternative to just dropping the illegal characters completely is to Base64 encode them for serialization to (GZIP) XML and then decode on deserialization. This would result in no data loss.
I was able to verify that entering the Unicode escape characters through the UI successfully escaped them, but I was then able to modify the `flow.xml.gz` file on disk and manually insert invalid characters (see screenshots). On startup, the app still throws an exception in the stack trace. This is to be expected, but can we improve the verbosity of the error output?
<img width="1067" alt="screen shot 2017-05-15 at 6 46 10 pm" src="https://cloud.githubusercontent.com/assets/798465/26086380/1a73ce8c-399f-11e7-82bd-a8ef88b1bd77.png">
<img width="1072" alt="screen shot 2017-05-15 at 6 43 46 pm" src="https://cloud.githubusercontent.com/assets/798465/26086378/1a6fa744-399f-11e7-811b-07ad02116f54.png">
<img width="1049" alt="screen shot 2017-05-15 at 6 43 19 pm" src="https://cloud.githubusercontent.com/assets/798465/26086381/1a7584d4-399f-11e7-981d-aca335873b23.png">
<img width="1920" alt="screen shot 2017-05-15 at 6 36 18 pm" src="https://cloud.githubusercontent.com/assets/798465/26086379/1a700298-399f-11e7-8679-bedb37bf9e6e.png">
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #1784: NIFI-3853: Filtering out control characters
Posted by alopresto <gi...@git.apache.org>.
Github user alopresto commented on the issue:
https://github.com/apache/nifi/pull/1784
That said, the proposed changes solve the issue identified in NIFI-3853, so I will merge this and then open a follow-on ticket to discuss further options.
+1, merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---