You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2017/03/03 18:17:43 UTC
[kudu-CR] [security] introduced TokenSigner::HasValidKey() method
Alexey Serbin has uploaded a new change for review.
http://gerrit.cloudera.org:8080/6246
Change subject: [security] introduced TokenSigner::HasValidKey() method
......................................................................
[security] introduced TokenSigner::HasValidKey() method
Introduced the TokenSigner::HasValidKey() method to check whether
TokenSigner has valid key to sign tokens. Added a unit test as well.
Change-Id: I2f85c166c431951d2d676e6936e4bc3b965318c9
---
M src/kudu/security/token-test.cc
M src/kudu/security/token_signer.cc
M src/kudu/security/token_signer.h
3 files changed, 39 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/46/6246/1
--
To view, visit http://gerrit.cloudera.org:8080/6246
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2f85c166c431951d2d676e6936e4bc3b965318c9
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [security] introduced TokenSigner::HasValidKey() method
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change.
Change subject: [security] introduced TokenSigner::HasValidKey() method
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/6246/1/src/kudu/security/token_signer.cc
File src/kudu/security/token_signer.cc:
Line 164: return (tsk_deque_.front()->expire_time() > WallTime_Now());
> Agree: HasValidKey() suggests this method checks for the presence of a vali
SGTM
--
To view, visit http://gerrit.cloudera.org:8080/6246
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2f85c166c431951d2d676e6936e4bc3b965318c9
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] [security] introduced TokenSigner::HasValidKey() method
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change.
Change subject: [security] introduced TokenSigner::HasValidKey() method
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/6246/1/src/kudu/security/token_signer.cc
File src/kudu/security/token_signer.cc:
Line 164: return (tsk_deque_.front()->expire_time() > WallTime_Now());
I'm a little surprised to see this implementation based on the method name. 'HasValidKey' implies to me it will return yes if it has a valid signing key. But this is checking that specifically the first key is valid. Perhaps this should be call 'ShouldRotate' or similar?
--
To view, visit http://gerrit.cloudera.org:8080/6246
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2f85c166c431951d2d676e6936e4bc3b965318c9
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes
[kudu-CR] [security] added TokenSigner::IsCurrentKeyValid() method
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.
Change subject: [security] added TokenSigner::IsCurrentKeyValid() method
......................................................................
Patch Set 3: Verified+1
Flake: org.apache.kudu.client.ITClient.test
--
To view, visit http://gerrit.cloudera.org:8080/6246
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2f85c166c431951d2d676e6936e4bc3b965318c9
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] [security] introduced TokenSigner::HasValidKey() method
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/6246
to look at the new patch set (#2).
Change subject: [security] introduced TokenSigner::HasValidKey() method
......................................................................
[security] introduced TokenSigner::HasValidKey() method
Introduced the TokenSigner::HasValidKey() method to check whether
TokenSigner has valid key to sign tokens. Added a unit test as well.
Change-Id: I2f85c166c431951d2d676e6936e4bc3b965318c9
---
M src/kudu/security/token-test.cc
M src/kudu/security/token_signer.cc
M src/kudu/security/token_signer.h
3 files changed, 39 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/46/6246/2
--
To view, visit http://gerrit.cloudera.org:8080/6246
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2f85c166c431951d2d676e6936e4bc3b965318c9
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] [security] added TokenSigner::IsCurrentKeyValid() method
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change.
Change subject: [security] added TokenSigner::IsCurrentKeyValid() method
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/6246
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2f85c166c431951d2d676e6936e4bc3b965318c9
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] [security] added TokenSigner::IsCurrentKeyValid() method
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/6246
to look at the new patch set (#3).
Change subject: [security] added TokenSigner::IsCurrentKeyValid() method
......................................................................
[security] added TokenSigner::IsCurrentKeyValid() method
Introduced TokenSigner::IsCurrentKeyValid() method to check whether
TokenSigner's current key is valid. Added a unit test as well.
Change-Id: I2f85c166c431951d2d676e6936e4bc3b965318c9
---
M src/kudu/security/token-test.cc
M src/kudu/security/token_signer.cc
M src/kudu/security/token_signer.h
3 files changed, 39 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/46/6246/3
--
To view, visit http://gerrit.cloudera.org:8080/6246
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2f85c166c431951d2d676e6936e4bc3b965318c9
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] [security] added TokenSigner::IsCurrentKeyValid() method
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged.
Change subject: [security] added TokenSigner::IsCurrentKeyValid() method
......................................................................
[security] added TokenSigner::IsCurrentKeyValid() method
Introduced TokenSigner::IsCurrentKeyValid() method to check whether
TokenSigner's current key is valid. Added a unit test as well.
Change-Id: I2f85c166c431951d2d676e6936e4bc3b965318c9
Reviewed-on: http://gerrit.cloudera.org:8080/6246
Tested-by: Alexey Serbin <as...@cloudera.com>
Reviewed-by: Dan Burkert <da...@apache.org>
---
M src/kudu/security/token-test.cc
M src/kudu/security/token_signer.cc
M src/kudu/security/token_signer.h
3 files changed, 39 insertions(+), 1 deletion(-)
Approvals:
Dan Burkert: Looks good to me, approved
Alexey Serbin: Verified
--
To view, visit http://gerrit.cloudera.org:8080/6246
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2f85c166c431951d2d676e6936e4bc3b965318c9
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] [security] introduced TokenSigner::HasValidKey() method
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.
Change subject: [security] introduced TokenSigner::HasValidKey() method
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/6246/1/src/kudu/security/token_signer.cc
File src/kudu/security/token_signer.cc:
Line 164: return (tsk_deque_.front()->expire_time() > WallTime_Now());
> I'm a little surprised to see this implementation based on the method name.
Agree: HasValidKey() suggests this method checks for the presence of a valid key in the key queue.
I think 'IsCurrentKeyValid' would be a better name.
--
To view, visit http://gerrit.cloudera.org:8080/6246
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2f85c166c431951d2d676e6936e4bc3b965318c9
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes