You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tinkerpop.apache.org by GitBox <gi...@apache.org> on 2020/11/06 18:37:51 UTC

[GitHub] [tinkerpop] MartinHaeusler opened a new pull request #1353: Fixed TestSupport file handling to work on windows.

MartinHaeusler opened a new pull request #1353:
URL: https://github.com/apache/tinkerpop/pull/1353


   This makes the TinkerGraph test suite pass on windows (it failed previously due to file handling issues).
   
   This fixes:
   https://issues.apache.org/jira/browse/TINKERPOP-2465?page=com.atlassian.jira.plugin.system.issuetabpanels%3Aall-tabpanel


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [tinkerpop] spmallette closed pull request #1353: TINKERPOP-2465 Fixed TestSupport file handling to work on windows.

Posted by GitBox <gi...@apache.org>.
spmallette closed pull request #1353:
URL: https://github.com/apache/tinkerpop/pull/1353


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [tinkerpop] MartinHaeusler commented on pull request #1353: Fixed TestSupport file handling to work on windows.

Posted by GitBox <gi...@apache.org>.
MartinHaeusler commented on pull request #1353:
URL: https://github.com/apache/tinkerpop/pull/1353#issuecomment-723240681


   I just noticed that my IntelliJ code formatter may have been a little over-zealous with the TestSupport file. I can fix that if it bugs anyone.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [tinkerpop] spmallette commented on pull request #1353: Fixed TestSupport file handling to work on windows.

Posted by GitBox <gi...@apache.org>.
spmallette commented on pull request #1353:
URL: https://github.com/apache/tinkerpop/pull/1353#issuecomment-723264175


   I'm currently testing this change cherry-picked back to `3.4-dev`.  


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [tinkerpop] spmallette commented on pull request #1353: TINKERPOP-2465 Fixed TestSupport file handling to work on windows.

Posted by GitBox <gi...@apache.org>.
spmallette commented on pull request #1353:
URL: https://github.com/apache/tinkerpop/pull/1353#issuecomment-724033915


   I merged this on 9262a62446f2d470cc5f4a7cee20913ed11690f1 - thanks!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org