[GitHub] [couchdb] bessbd commented on a change in pull request #3380: Clean up logs 3.x.v2

[GitBox <gi...@apache.org>]

bessbd commented on a change in pull request #3380:
URL: https://github.com/apache/couchdb/pull/3380#discussion_r581203669



##########
File path: src/chttpd/src/chttpd_node.erl
##########
@@ -71,7 +71,9 @@ handle_node_req(#httpd{method='PUT', path_parts=[_, Node, <<"_config">>, Section
     Value = couch_util:trim(chttpd:json_body(Req)),
     Persist = chttpd:header_value(Req, "X-Couch-Persist") /= "false",
     OldValue = call_node(Node, config, get, [Section, Key, ""]),
-    case call_node(Node, config, set, [Section, Key, ?b2l(Value), Persist]) of
+    IsSensitive = Section == <<"admins">>,
+    Opts = #{persisit => Persist, sensitive => IsSensitive},

Review comment:
       Nit
   ```suggestion
       Opts = #{persist => Persist, sensitive => IsSensitive},
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org