You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benno Evers <be...@mesosphere.com> on 2017/12/05 15:33:20 UTC
Review Request 64342: Correctly updated total resources when agent
capabilities changed.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64342/
-----------------------------------------------------------
Review request for mesos, Alexander Rukletsov and Benjamin Bannier.
Repository: mesos
Description
-------
Due to the short-circuiting behaviour of C++ boolean operations,
an agent that re-registers with changed agent capabilities would
not have its total updated.
Diffs
-----
src/master/allocator/mesos/hierarchical.cpp 715650ee9cb15aed1d1e58badf70fc09e26d13c1
Diff: https://reviews.apache.org/r/64342/diff/1/
Testing
-------
https://jenkins.mesosphere.com/service/jenkins/view/Mesos/job/mesos/job/Mesos_CI-build/2314/
Thanks,
Benno Evers
Re: Review Request 64342: Correctly updated total resources when agent
capabilities changed.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64342/#review192880
-----------------------------------------------------------
Ship it!
Ship It!
- Benjamin Bannier
On Dec. 5, 2017, 4:33 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64342/
> -----------------------------------------------------------
>
> (Updated Dec. 5, 2017, 4:33 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov and Benjamin Bannier.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Due to the short-circuiting behaviour of C++ boolean operations,
> an agent that re-registers with changed agent capabilities would
> not have its total updated.
>
>
> Diffs
> -----
>
> src/master/allocator/mesos/hierarchical.cpp 715650ee9cb15aed1d1e58badf70fc09e26d13c1
>
>
> Diff: https://reviews.apache.org/r/64342/diff/1/
>
>
> Testing
> -------
>
> https://jenkins.mesosphere.com/service/jenkins/view/Mesos/job/mesos/job/Mesos_CI-build/2314/
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 64342: Correctly updated total resources when agent
capabilities changed.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64342/#review192921
-----------------------------------------------------------
Ship it!
Ship It!
- Alexander Rukletsov
On Dec. 5, 2017, 3:33 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64342/
> -----------------------------------------------------------
>
> (Updated Dec. 5, 2017, 3:33 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov and Benjamin Bannier.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Due to the short-circuiting behaviour of C++ boolean operations,
> an agent that re-registers with changed agent capabilities would
> not have its total updated.
>
>
> Diffs
> -----
>
> src/master/allocator/mesos/hierarchical.cpp 715650ee9cb15aed1d1e58badf70fc09e26d13c1
>
>
> Diff: https://reviews.apache.org/r/64342/diff/1/
>
>
> Testing
> -------
>
> https://jenkins.mesosphere.com/service/jenkins/view/Mesos/job/mesos/job/Mesos_CI-build/2314/
>
>
> Thanks,
>
> Benno Evers
>
>