You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@perl.apache.org by "Philip M. Gollucci" <pg...@p6m7g8.com> on 2006/01/10 04:55:48 UTC
Re: svn commit: r367475 - /perl/modperl/trunk/lib/ModPerl/BuildMM.pm
Does this warrant a Changes entry ?
pgollucci@apache.org wrote:
> Author: pgollucci
> Date: Mon Jan 9 19:54:39 2006
> New Revision: 367475
>
> URL: http://svn.apache.org/viewcvs?rev=367475&view=rev
> Log:
> fix this Makefile.PL warning
>
> Writing Makefile for X
> Argument "6.30_01" isn't numeric in numeric ge (>=) at lib/ModPerl/BuildMM.pm line 196.
>
> snatched from Apache2::Status
>
> bleed perl ~26758 includes a dev version of MakeMaker
>
>
> Modified:
> perl/modperl/trunk/lib/ModPerl/BuildMM.pm
>
> Modified: perl/modperl/trunk/lib/ModPerl/BuildMM.pm
> URL: http://svn.apache.org/viewcvs/perl/modperl/trunk/lib/ModPerl/BuildMM.pm?rev=367475&r1=367474&r2=367475&view=diff
> ==============================================================================
> --- perl/modperl/trunk/lib/ModPerl/BuildMM.pm (original)
> +++ perl/modperl/trunk/lib/ModPerl/BuildMM.pm Mon Jan 9 19:54:39 2006
> @@ -193,6 +193,7 @@
> # allow 'make -j'
> require ExtUtils::MakeMaker;
> my $mm_ver = $ExtUtils::MakeMaker::VERSION;
> + $mm_ver =~ s/_.*//; # handle dev versions like 6.30_01
> my $pm_to_blib = ($mm_ver >= 6.22 && $mm_ver <= 6.25)
> ? "pm_to_blib.ts"
> : "pm_to_blib";
>
--
------------------------------------------------------------------------
"Love is not the one you can picture yourself marrying,
but the one you can't picture the rest of your life without."
"It takes a minute to have a crush on someone, an hour to like someone,
and a day to love someone, but it takes a lifetime to forget someone..."
"I wanna hold ya till I die ... I wanna hold ya till the fear in me
subsides."
Philip M. Gollucci (pgollucci@p6m7g8.com) 301.254.5198
Consultant / http://p6m7g8.net/Resume/resume.shtml
Senior Software Engineer - TicketMaster - http://ticketmaster.com
1024D/A79997FA F357 0FDD 2301 6296 690F 6A47 D55A 7172 A799 97F
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org
Re: svn commit: r367475 - /perl/modperl/trunk/lib/ModPerl/BuildMM.pm
Posted by Stas Bekman <st...@stason.org>.
Geoffrey Young wrote:
>
> Philip M. Gollucci wrote:
>
>>Does this warrant a Changes entry ?
>
>
> I wouldn' think so
>
>
>>> my $mm_ver = $ExtUtils::MakeMaker::VERSION;
>>>+ $mm_ver =~ s/_.*//; # handle dev versions like 6.30_01
>>> my $pm_to_blib = ($mm_ver >= 6.22 && $mm_ver <= 6.25)
>
>
> isn't 'no warnings (numeric)' a bit safer than manipulating $VERSION?
If you scope it tightly then it's probably better.
--
_____________________________________________________________
Stas Bekman mailto:stas@stason.org http://stason.org/
MailChannels: Assured Messaging(TM) http://mailchannels.com/
The "Practical mod_perl" book http://modperlbook.org/
http://perl.apache.org/ http://perl.org/ http://logilune.com/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org
Re: svn commit: r367475 - /perl/modperl/trunk/lib/ModPerl/BuildMM.pm
Posted by Geoffrey Young <ge...@modperlcookbook.org>.
>>>> my $mm_ver = $ExtUtils::MakeMaker::VERSION;
>>>> + $mm_ver =~ s/_.*//; # handle dev versions like 6.30_01
>>>> my $pm_to_blib = ($mm_ver >= 6.22 && $mm_ver <= 6.25)
>
> Could be... Apache2::Status also does the regex.... should we swap both ?
if they're both doing it then I guess that makes it ok :)
--Geoff
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org
Re: svn commit: r367475 - /perl/modperl/trunk/lib/ModPerl/BuildMM.pm
Posted by "Philip M. Gollucci" <pg...@p6m7g8.com>.
Geoffrey Young wrote:
>
> Philip M. Gollucci wrote:
>> Does this warrant a Changes entry ?
>
> I wouldn' think so
>
>>> my $mm_ver = $ExtUtils::MakeMaker::VERSION;
>>> + $mm_ver =~ s/_.*//; # handle dev versions like 6.30_01
>>> my $pm_to_blib = ($mm_ver >= 6.22 && $mm_ver <= 6.25)
Could be... Apache2::Status also does the regex.... should we swap both ?
--
------------------------------------------------------------------------
"Love is not the one you can picture yourself marrying,
but the one you can't picture the rest of your life without."
"It takes a minute to have a crush on someone, an hour to like someone,
and a day to love someone, but it takes a lifetime to forget someone..."
"I wanna hold ya till I die ... I wanna hold ya till the fear in me
subsides."
Philip M. Gollucci (pgollucci@p6m7g8.com) 301.254.5198
Consultant / http://p6m7g8.net/Resume/resume.shtml
Senior Software Engineer - TicketMaster - http://ticketmaster.com
1024D/A79997FA F357 0FDD 2301 6296 690F 6A47 D55A 7172 A799 97F
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org
Re: svn commit: r367475 - /perl/modperl/trunk/lib/ModPerl/BuildMM.pm
Posted by Geoffrey Young <ge...@modperlcookbook.org>.
Philip M. Gollucci wrote:
> Does this warrant a Changes entry ?
I wouldn' think so
>> my $mm_ver = $ExtUtils::MakeMaker::VERSION;
>> + $mm_ver =~ s/_.*//; # handle dev versions like 6.30_01
>> my $pm_to_blib = ($mm_ver >= 6.22 && $mm_ver <= 6.25)
isn't 'no warnings (numeric)' a bit safer than manipulating $VERSION?
--Geoff
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org