[GitHub] [lucene-solr] atris edited a comment on issue #754: LUCENE-8875: Introduce Optimized Collector For Large Number Of Hits

[GitBox <gi...@apache.org>]

atris edited a comment on issue #754: LUCENE-8875: Introduce Optimized Collector For Large Number Of Hits
URL: https://github.com/apache/lucene-solr/pull/754#issuecomment-508914746
 
 
   @jpountz @tokee Thanks for your comments.
   
   I am planning to maintain an ArrayList of ScoreDocs and collect numHits, then do a sort on score and return top N as Adrien suggested. This should optimize the performance bottleneck around PQ allocating slots and prepopulating sentinel values.
   
   I am inclined to pursue the idea of not using ScoreDoc and representing score + docID as an array of longs as a separate issue primarily due to the nuances involved with handling shard indices. I do feel that should not be a major blocker anymore given the fact that TopDocs.merge can now tie break on docIDs and ignore shard indices completely during tie breaking.
   
   Thoughts?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org