You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Vinod Kone <vi...@gmail.com> on 2014/01/31 01:55:35 UTC
Review Request 17573: Changed master and slave to get the default hostname
based on the ip.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17573/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman, Brenden Matthews, Niklas Nielsen, and Jiang Yan Xu.
Bugs: MESOS-672
https://issues.apache.org/jira/browse/MESOS-672
Repository: mesos-git
Description
-------
This is part 3.
This changes the semantics of how the default hostname is calculated. When no hostname flag is provided we utilize the libprocess ip to get the hostname (net::getHostname()) instead of os::hostname(). I think this is more appropriate.
Now when the user selects
--ip=127.0.0.1 , default hostname is "localhost" instead of the public hostname of the machine.
--ip=public ip, default hostname is "public hostname"
doesn't specifically set ip, hostname is "public hostname"
Note that --hostname flag overrides the hostname.
Diffs
-----
src/master/master.cpp 77872ece66601043ddeb280cceba5a7676e8a6be
src/slave/slave.cpp a97b1d531d05e63e8ebaa474f526c110f5d573d4
Diff: https://reviews.apache.org/r/17573/diff/
Testing
-------
make check
Thanks,
Vinod Kone
Re: Review Request 17573: Changed master and slave to get the default
hostname based on the ip.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17573/
-----------------------------------------------------------
(Updated Feb. 11, 2014, 7:12 a.m.)
Review request for mesos, Benjamin Hindman, Brenden Matthews, Niklas Nielsen, and Jiang Yan Xu.
Changes
-------
rebased. NNFR.
Bugs: MESOS-672
https://issues.apache.org/jira/browse/MESOS-672
Repository: mesos-git
Description
-------
This is part 3.
This changes the semantics of how the default hostname is calculated. When no hostname flag is provided we utilize the libprocess ip to get the hostname (net::getHostname()) instead of os::hostname(). I think this is more appropriate.
Now when the user selects
--ip=127.0.0.1 , default hostname is "localhost" instead of the public hostname of the machine.
--ip=public ip, default hostname is "public hostname"
doesn't specifically set ip, hostname is "public hostname"
Note that --hostname flag overrides the hostname.
Diffs (updated)
-----
src/master/master.cpp 4d9a9d15b38e021adc04c34b2e86734567bb957e
src/slave/slave.cpp 1c0502e4b88719f18ecb0caface17b8511e9257b
Diff: https://reviews.apache.org/r/17573/diff/
Testing
-------
make check
Thanks,
Vinod Kone
Re: Review Request 17573: Changed master and slave to get the default
hostname based on the ip.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17573/
-----------------------------------------------------------
(Updated Feb. 6, 2014, 9:45 p.m.)
Review request for mesos, Benjamin Hindman, Brenden Matthews, Niklas Nielsen, and Jiang Yan Xu.
Changes
-------
rebase. NNFR.
Bugs: MESOS-672
https://issues.apache.org/jira/browse/MESOS-672
Repository: mesos-git
Description
-------
This is part 3.
This changes the semantics of how the default hostname is calculated. When no hostname flag is provided we utilize the libprocess ip to get the hostname (net::getHostname()) instead of os::hostname(). I think this is more appropriate.
Now when the user selects
--ip=127.0.0.1 , default hostname is "localhost" instead of the public hostname of the machine.
--ip=public ip, default hostname is "public hostname"
doesn't specifically set ip, hostname is "public hostname"
Note that --hostname flag overrides the hostname.
Diffs (updated)
-----
src/master/master.cpp 77872ece66601043ddeb280cceba5a7676e8a6be
src/slave/slave.cpp a97b1d531d05e63e8ebaa474f526c110f5d573d4
Diff: https://reviews.apache.org/r/17573/diff/
Testing
-------
make check
Thanks,
Vinod Kone
Re: Review Request 17573: Changed master and slave to get the default
hostname based on the ip.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17573/#review33373
-----------------------------------------------------------
Ship it!
src/master/master.cpp
<https://reviews.apache.org/r/17573/#comment62832>
Would be nice to move os::hostname into net:: and consolidate the two functions, maybe like:
Try<string> net::hostname(Option<uint32_t> ip = None());
Up to you.
src/master/master.cpp
<https://reviews.apache.org/r/17573/#comment62833>
Would be nice to move os::hostname into net:: and consolidate the two functions, maybe like:
Try<string> net::hostname(Option<uint32_t> ip = None());
Up to you.
- Ben Mahler
On Jan. 31, 2014, 12:55 a.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17573/
> -----------------------------------------------------------
>
> (Updated Jan. 31, 2014, 12:55 a.m.)
>
>
> Review request for mesos, Benjamin Hindman, Brenden Matthews, Niklas Nielsen, and Jiang Yan Xu.
>
>
> Bugs: MESOS-672
> https://issues.apache.org/jira/browse/MESOS-672
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> This is part 3.
>
> This changes the semantics of how the default hostname is calculated. When no hostname flag is provided we utilize the libprocess ip to get the hostname (net::getHostname()) instead of os::hostname(). I think this is more appropriate.
>
> Now when the user selects
> --ip=127.0.0.1 , default hostname is "localhost" instead of the public hostname of the machine.
> --ip=public ip, default hostname is "public hostname"
> doesn't specifically set ip, hostname is "public hostname"
>
> Note that --hostname flag overrides the hostname.
>
>
> Diffs
> -----
>
> src/master/master.cpp 77872ece66601043ddeb280cceba5a7676e8a6be
> src/slave/slave.cpp a97b1d531d05e63e8ebaa474f526c110f5d573d4
>
> Diff: https://reviews.apache.org/r/17573/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>