You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by Rob Hartill <ro...@imdb.com> on 1996/11/17 23:17:04 UTC
cvs commit: apache/src mod_rewrite.h Makefile.tmpl (fwd)
Arrrggh.
No more commits without peer review please.
If you don't like the currently active plan for 1.2b release, lets hear
about it, otherwise please don't commit anything without having it reviewed.
It might be that this was okay'ed at some point, but I can't see any
reference to names of people who've reviewed it.
----- Forwarded message from Brian Behlendorf -----
Date: Sun, 17 Nov 1996 12:53:19 -0800 (PST)
From: Brian Behlendorf <br...@hyperreal.com>
Message-Id: <19...@taz.hyperreal.com>
To: apache-cvs@hyperreal.com
Subject: cvs commit: apache/src mod_rewrite.h Makefile.tmpl
Sender: apache-cvs-owner@hyperreal.com
Reply-To: new-httpd@hyperreal.com
Precedence: bulk
brian 96/11/17 12:53:18
Modified: src mod_rewrite.h Makefile.tmpl
Log:
Fixed regex/regexp descrepancy, which was causing compile failures
with mod_rewrite.
Revision Changes Path
1.9 +1 -1 apache/src/mod_rewrite.h
Index: mod_rewrite.h
===================================================================
RCS file: /export/home/cvs/apache/src/mod_rewrite.h,v
retrieving revision 1.8
retrieving revision 1.9
diff -C3 -r1.8 -r1.9
*** mod_rewrite.h 1996/10/31 17:19:36 1.8
--- mod_rewrite.h 1996/11/17 20:53:15 1.9
***************
*** 108,114 ****
for Apache 1.2 and higher there is a Spencer POSIX library
in the distribution */
#ifndef HAS_APACHE_REGEX_LIB
! #include "regexp/regexp.h"
#endif
--- 108,114 ----
for Apache 1.2 and higher there is a Spencer POSIX library
in the distribution */
#ifndef HAS_APACHE_REGEX_LIB
! #include "regex/regex.h"
#endif
1.33 +1 -1 apache/src/Makefile.tmpl
Index: Makefile.tmpl
===================================================================
RCS file: /export/home/cvs/apache/src/Makefile.tmpl,v
retrieving revision 1.32
retrieving revision 1.33
diff -C3 -r1.32 -r1.33
*** Makefile.tmpl 1996/11/06 10:30:37 1.32
--- Makefile.tmpl 1996/11/17 20:53:16 1.33
***************
*** 123,127 ****
util_script.h
httpd.h: conf.h alloc.h buff.h
! mod_rewrite.h: regexp/regexp.h
util_md5.h: md5.h
--- 123,127 ----
util_script.h
httpd.h: conf.h alloc.h buff.h
! mod_rewrite.h: regex/regex.h
util_md5.h: md5.h
----- End of forwarded message from Brian Behlendorf -----
Re: cvs commit: apache/src mod_rewrite.h Makefile.tmpl (fwd)
Posted by Brian Behlendorf <br...@organic.com>.
This patch wasn't peer reviewed, this is true. However, the solution seemed to
be obvious, and it was a problem that several people had complained about. It
wasn't just an annoyance, it caused compilation to fail. Was my fix incorrect?
I can see how, this on top of Paul's patches, may have seemed like a penny
which broke the camel's back. The satisfy patch submitted seemed rushed too,
but I'm going to go test it right now to see if it works as it should. I just
spent some time implementing an improvement on mod_dir, but I don't expect that
to make the first beta.
Brian
On Sun, 17 Nov 1996, Rob Hartill wrote:
> Arrrggh.
>
> No more commits without peer review please.
>
> If you don't like the currently active plan for 1.2b release, lets hear
> about it, otherwise please don't commit anything without having it reviewed.
>
> It might be that this was okay'ed at some point, but I can't see any
> reference to names of people who've reviewed it.
>
> ----- Forwarded message from Brian Behlendorf -----
>
> Date: Sun, 17 Nov 1996 12:53:19 -0800 (PST)
> From: Brian Behlendorf <br...@hyperreal.com>
> Message-Id: <19...@taz.hyperreal.com>
> To: apache-cvs@hyperreal.com
> Subject: cvs commit: apache/src mod_rewrite.h Makefile.tmpl
> Sender: apache-cvs-owner@hyperreal.com
> Reply-To: new-httpd@hyperreal.com
> Precedence: bulk
>
> brian 96/11/17 12:53:18
>
> Modified: src mod_rewrite.h Makefile.tmpl
> Log:
> Fixed regex/regexp descrepancy, which was causing compile failures
> with mod_rewrite.
>
> Revision Changes Path
> 1.9 +1 -1 apache/src/mod_rewrite.h
>
> Index: mod_rewrite.h
> ===================================================================
> RCS file: /export/home/cvs/apache/src/mod_rewrite.h,v
> retrieving revision 1.8
> retrieving revision 1.9
> diff -C3 -r1.8 -r1.9
> *** mod_rewrite.h 1996/10/31 17:19:36 1.8
> --- mod_rewrite.h 1996/11/17 20:53:15 1.9
> ***************
> *** 108,114 ****
> for Apache 1.2 and higher there is a Spencer POSIX library
> in the distribution */
> #ifndef HAS_APACHE_REGEX_LIB
> ! #include "regexp/regexp.h"
> #endif
>
>
> --- 108,114 ----
> for Apache 1.2 and higher there is a Spencer POSIX library
> in the distribution */
> #ifndef HAS_APACHE_REGEX_LIB
> ! #include "regex/regex.h"
> #endif
>
>
>
>
>
> 1.33 +1 -1 apache/src/Makefile.tmpl
>
> Index: Makefile.tmpl
> ===================================================================
> RCS file: /export/home/cvs/apache/src/Makefile.tmpl,v
> retrieving revision 1.32
> retrieving revision 1.33
> diff -C3 -r1.32 -r1.33
> *** Makefile.tmpl 1996/11/06 10:30:37 1.32
> --- Makefile.tmpl 1996/11/17 20:53:16 1.33
> ***************
> *** 123,127 ****
> util_script.h
>
> httpd.h: conf.h alloc.h buff.h
> ! mod_rewrite.h: regexp/regexp.h
> util_md5.h: md5.h
> --- 123,127 ----
> util_script.h
>
> httpd.h: conf.h alloc.h buff.h
> ! mod_rewrite.h: regex/regex.h
> util_md5.h: md5.h
>
>
>
>
> ----- End of forwarded message from Brian Behlendorf -----
>
>
>
--=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=--
brian@organic.com www.apache.org hyperreal.com http://www.organic.com/JOBS
Re: cvs commit: apache/src mod_rewrite.h Makefile.tmpl (fwd)
Posted by ra...@vex.net.
> Arrrggh.
>
> No more commits without peer review please.
Hey, that was a trivial patch. It was basically a typo fix, plus
a simple check to see if the bundled regex library is being used.
I'll certainly +1 it. I hope we don't need to peer review little
things like this all the time.
-Rasmus