You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by GitBox <gi...@apache.org> on 2021/08/04 19:01:57 UTC
[GitHub] [trafficserver] SolidWallOfCode commented on a change in pull request #8204: transaction data sink: only stream body bytes
SolidWallOfCode commented on a change in pull request #8204:
URL: https://github.com/apache/trafficserver/pull/8204#discussion_r682881890
##########
File path: example/plugins/c-api/txn_data_sink/txn_data_sink.c
##########
@@ -39,12 +39,15 @@
#define PLUGIN_NAME "txn_data_sink"
#define PCP "[" PLUGIN_NAME "] "
+#define MAX_BODY_SIZE 10240
Review comment:
Avoid `#define` - use
```
static constexpr auto MAX_BODY_SIZE = 10240;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org