You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@thrift.apache.org by "Hudson (JIRA)" <ji...@apache.org> on 2014/11/05 05:49:26 UTC

[jira] [Commented] (THRIFT-2612) Java TCompactProtocol.readBinary zero copying

    [ https://issues.apache.org/jira/browse/THRIFT-2612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14197600#comment-14197600 ] 

Hudson commented on THRIFT-2612:
--------------------------------

SUCCESS: Integrated in Thrift #1331 (See [https://builds.apache.org/job/Thrift/1331/])
THRIFT-2612 Java TCompactProtocol.readBinary zero copying (jensg: rev 9a93fe07ffd591222e22a7e35cb42549b3d4fe5e)
* lib/java/src/org/apache/thrift/protocol/TCompactProtocol.java


> Java TCompactProtocol.readBinary zero copying
> ---------------------------------------------
>
>                 Key: THRIFT-2612
>                 URL: https://issues.apache.org/jira/browse/THRIFT-2612
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Java - Library
>    Affects Versions: 0.9.1
>            Reporter: Jon Hoffman
>            Assignee: Jens Geyer
>             Fix For: 0.9.2
>
>         Attachments: THRIFT-2612.1.patch
>
>
> I noticed that TCompactProtocol.readBinary always copies bytes. TBinaryProtocol.readBinary has an optimization to just wrap the ByteBuffer from the TTransport. Is there a reason that same trick wasn't applied in TCompactProtocol? All the tests pass with the attached patch.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)