[GitHub] [spark] cloud-fan commented on a change in pull request #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments

[GitBox <gi...@apache.org>]

cloud-fan commented on a change in pull request #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#discussion_r379444669
 
 

 ##########
 File path: sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4
 ##########
 @@ -1800,8 +1800,23 @@ BRACKETED_EMPTY_COMMENT
     : '/**/' -> channel(HIDDEN)
     ;
 
+// The bracketed comment consists of six main parts, from left to right are:
+// "/*", ~[+], left part, nested bracketed comment, right part, "*/".
+//   Ⅰ. '/*' is used to match the beginning of a bracketed comment.
 
 Review comment:
   it's odd to use roman numerals, can we just use 1, 2, 3?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org