[GitHub] [dubbo] horizonzy commented on a change in pull request #8214: issues 8194 fix

[GitBox <gi...@apache.org>]

horizonzy commented on a change in pull request #8214:
URL: https://github.com/apache/dubbo/pull/8214#discussion_r663382267



##########
File path: dubbo-common/src/main/java/org/apache/dubbo/common/config/PropertiesConfiguration.java
##########
@@ -53,6 +53,9 @@ public PropertiesConfiguration() {
         //override the properties.
         for (OrderedPropertiesProvider orderedPropertiesProvider :
                 orderedPropertiesProviders) {
+            if (orderedPropertiesProvider == null) {

Review comment:
       Maybe this change off the point. I think change the code here will be better.
   
   https://github.com/apache/dubbo/blob/f26ba91b67f642148a10d3b197502e29928b77bf/dubbo-common/src/main/java/org/apache/dubbo/common/extension/ExtensionLoader.java#L425-L428
   
   ->
   ```
       public T getExtension(String name) {
           T extension = getExtension(name, true);
           if (extension == null) {
               throw new IllegalArgumentException("Not find extension: " + name);
           }
           return extension;
       }
   ```
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org