You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/11/07 08:14:01 UTC
[GitHub] [rocketmq] RongtongJin opened a new pull request, #5475: [ISSUE #5471][WIP] Fix AutoSwitchRoleIntegrationTest still experience random failures
RongtongJin opened a new pull request, #5475:
URL: https://github.com/apache/rocketmq/pull/5475
**Make sure set the target branch to `develop`**
## What is the purpose of the change
Close #5471
## Brief changelog
XX
## Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`.
- [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/rocketmq/tree/master/test).
- [x] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test` to make sure integration-test pass.
- [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] lizhanhui commented on pull request #5475: [ISSUE #5471][WIP] Fix AutoSwitchRoleIntegrationTest still experience random failures
Posted by GitBox <gi...@apache.org>.
lizhanhui commented on PR #5475:
URL: https://github.com/apache/rocketmq/pull/5475#issuecomment-1308471744
@RongtongJin Is this pull-request still work-in-progress? Its title contains WIP while it remains inactive for some time
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] RongtongJin commented on pull request #5475: [ISSUE #5471] Fix AutoSwitchRoleIntegrationTest still experience random failures
Posted by GitBox <gi...@apache.org>.
RongtongJin commented on PR #5475:
URL: https://github.com/apache/rocketmq/pull/5475#issuecomment-1321560935
Hi, @lizhanhui I have found some reasons, mainly because the previous test did not clean up the resources. It has been repaired, and the same error has not yet occurred. So I suggest merging this PR and continuing to observe.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] lizhanhui commented on pull request #5475: [ISSUE #5471] Fix AutoSwitchRoleIntegrationTest still experience random failures
Posted by GitBox <gi...@apache.org>.
lizhanhui commented on PR #5475:
URL: https://github.com/apache/rocketmq/pull/5475#issuecomment-1322884740
> Hi, @lizhanhui I have found some reasons, mainly because the previous test did not clean up the resources. It has been fixed, and the same error has not yet occurred. So I suggest merging this PR and continuing to observe.
Good job! Let's merge it and see
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] hzh0425 commented on pull request #5475: [ISSUE #5471][WIP] Fix AutoSwitchRoleIntegrationTest still experience random failures
Posted by GitBox <gi...@apache.org>.
hzh0425 commented on PR #5475:
URL: https://github.com/apache/rocketmq/pull/5475#issuecomment-1312733569
LGTM @RongtongJin
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] RongtongJin commented on pull request #5475: [ISSUE #5471][WIP] Fix AutoSwitchRoleIntegrationTest still experience random failures
Posted by GitBox <gi...@apache.org>.
RongtongJin commented on PR #5475:
URL: https://github.com/apache/rocketmq/pull/5475#issuecomment-1313305482
> @RongtongJin Is this pull-request still work-in-progress? Its title contains WIP while it remains inactive for some time
@lizhanhui Yes, I have been busy recently, but I will continue to fix it until it is stable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] codecov-commenter commented on pull request #5475: [ISSUE #5471][WIP] Fix AutoSwitchRoleIntegrationTest still experience random failures
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #5475:
URL: https://github.com/apache/rocketmq/pull/5475#issuecomment-1308498658
# [Codecov](https://codecov.io/gh/apache/rocketmq/pull/5475?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#5475](https://codecov.io/gh/apache/rocketmq/pull/5475?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1e52421) into [develop](https://codecov.io/gh/apache/rocketmq/commit/9b2375dcf4c06344b8ecbe339ef7bc99e9b4bb93?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9b2375d) will **decrease** coverage by `0.02%`.
> The diff coverage is `22.41%`.
```diff
@@ Coverage Diff @@
## develop #5475 +/- ##
=============================================
- Coverage 43.18% 43.16% -0.03%
- Complexity 8066 8073 +7
=============================================
Files 1025 1025
Lines 72195 72232 +37
Branches 9559 9563 +4
=============================================
- Hits 31180 31179 -1
- Misses 37067 37109 +42
+ Partials 3948 3944 -4
```
| [Impacted Files](https://codecov.io/gh/apache/rocketmq/pull/5475?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...cketmq/broker/offset/ConsumerOrderInfoManager.java](https://codecov.io/gh/apache/rocketmq/pull/5475/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9icm9rZXIvb2Zmc2V0L0NvbnN1bWVyT3JkZXJJbmZvTWFuYWdlci5qYXZh) | `76.15% <0.00%> (-1.10%)` | :arrow_down: |
| [...he/rocketmq/test/client/rmq/RMQNormalConsumer.java](https://codecov.io/gh/apache/rocketmq/pull/5475/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dGVzdC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvdGVzdC9jbGllbnQvcm1xL1JNUU5vcm1hbENvbnN1bWVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [.../apache/rocketmq/test/client/rmq/RMQPopClient.java](https://codecov.io/gh/apache/rocketmq/pull/5475/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dGVzdC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvdGVzdC9jbGllbnQvcm1xL1JNUVBvcENsaWVudC5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...pache/rocketmq/test/client/rmq/RMQPopConsumer.java](https://codecov.io/gh/apache/rocketmq/pull/5475/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dGVzdC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvdGVzdC9jbGllbnQvcm1xL1JNUVBvcENvbnN1bWVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [.../apache/rocketmq/test/factory/ConsumerFactory.java](https://codecov.io/gh/apache/rocketmq/pull/5475/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dGVzdC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvdGVzdC9mYWN0b3J5L0NvbnN1bWVyRmFjdG9yeS5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...rg/apache/rocketmq/test/util/MQAdminTestUtils.java](https://codecov.io/gh/apache/rocketmq/pull/5475/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dGVzdC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvdGVzdC91dGlsL01RQWRtaW5UZXN0VXRpbHMuamF2YQ==) | `0.00% <ø> (ø)` | |
| [...org/apache/rocketmq/tools/command/CommandUtil.java](https://codecov.io/gh/apache/rocketmq/pull/5475/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3Rvb2xzL2NvbW1hbmQvQ29tbWFuZFV0aWwuamF2YQ==) | `31.16% <0.00%> (-3.12%)` | :arrow_down: |
| [...rocketmq/broker/processor/PopMessageProcessor.java](https://codecov.io/gh/apache/rocketmq/pull/5475/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9icm9rZXIvcHJvY2Vzc29yL1BvcE1lc3NhZ2VQcm9jZXNzb3IuamF2YQ==) | `37.90% <52.63%> (+0.59%)` | :arrow_up: |
| [...cketmq/broker/schedule/ScheduleMessageService.java](https://codecov.io/gh/apache/rocketmq/pull/5475/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9icm9rZXIvc2NoZWR1bGUvU2NoZWR1bGVNZXNzYWdlU2VydmljZS5qYXZh) | `58.04% <100.00%> (ø)` | |
| [...etmq/client/latency/LatencyFaultToleranceImpl.java](https://codecov.io/gh/apache/rocketmq/pull/5475/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvbGF0ZW5jeS9MYXRlbmN5RmF1bHRUb2xlcmFuY2VJbXBsLmphdmE=) | `49.35% <100.00%> (ø)` | |
| ... and [17 more](https://codecov.io/gh/apache/rocketmq/pull/5475/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] lizhanhui merged pull request #5475: [ISSUE #5471] Fix AutoSwitchRoleIntegrationTest still experience random failures
Posted by GitBox <gi...@apache.org>.
lizhanhui merged PR #5475:
URL: https://github.com/apache/rocketmq/pull/5475
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org