You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/05/04 19:55:33 UTC
[GitHub] [arrow] jonkeane opened a new pull request #10247: ARROW-12653: [Archery] allow me to add a comment to crossbow requests
jonkeane opened a new pull request #10247:
URL: https://github.com/apache/arrow/pull/10247
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jonkeane commented on pull request #10247: ARROW-12653: [Archery] allow me to add a comment to crossbow requests
Posted by GitBox <gi...@apache.org>.
jonkeane commented on pull request #10247:
URL: https://github.com/apache/arrow/pull/10247#issuecomment-832239230
@github-actions autotune
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jonkeane commented on a change in pull request #10247: ARROW-12653: [Archery] allow me to add a comment to crossbow requests
Posted by GitBox <gi...@apache.org>.
jonkeane commented on a change in pull request #10247:
URL: https://github.com/apache/arrow/pull/10247#discussion_r629478766
##########
File path: dev/archery/archery/tests/test_bot.py
##########
@@ -156,6 +156,7 @@ def handler(command, **kwargs):
@pytest.mark.parametrize(('command', 'reaction'), [
('@ursabot build', '+1'),
+ ('@ursabot build\nwith a comment', '+1'),
Review comment:
Turns out that it is a no-op, just like other examples where the `@` mention is not first.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on a change in pull request #10247: ARROW-12653: [Archery] allow me to add a comment to crossbow requests
Posted by GitBox <gi...@apache.org>.
kszucs commented on a change in pull request #10247:
URL: https://github.com/apache/arrow/pull/10247#discussion_r629496259
##########
File path: dev/archery/archery/tests/test_bot.py
##########
@@ -156,6 +156,7 @@ def handler(command, **kwargs):
@pytest.mark.parametrize(('command', 'reaction'), [
('@ursabot build', '+1'),
+ ('@ursabot build\nwith a comment', '+1'),
Review comment:
@jonkeane thanks for adding a test case!
We should probably add support for `@` mention anywhere in the comment by splitting the lines first.
Could you please create a follow-up jira for this use case (or directly implement it :) in this PR)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on a change in pull request #10247: ARROW-12653: [Archery] allow me to add a comment to crossbow requests
Posted by GitBox <gi...@apache.org>.
kszucs commented on a change in pull request #10247:
URL: https://github.com/apache/arrow/pull/10247#discussion_r626539994
##########
File path: dev/archery/archery/tests/test_bot.py
##########
@@ -156,6 +156,7 @@ def handler(command, **kwargs):
@pytest.mark.parametrize(('command', 'reaction'), [
('@ursabot build', '+1'),
+ ('@ursabot build\nwith a comment', '+1'),
Review comment:
Thanks Jon for working on this!
Could you please add a test case with additional content preceding the mention?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jonkeane commented on a change in pull request #10247: ARROW-12653: [Archery] allow me to add a comment to crossbow requests
Posted by GitBox <gi...@apache.org>.
jonkeane commented on a change in pull request #10247:
URL: https://github.com/apache/arrow/pull/10247#discussion_r626546116
##########
File path: dev/archery/archery/tests/test_bot.py
##########
@@ -156,6 +156,7 @@ def handler(command, **kwargs):
@pytest.mark.parametrize(('command', 'reaction'), [
('@ursabot build', '+1'),
+ ('@ursabot build\nwith a comment', '+1'),
Review comment:
Absolutely, I wasn't 100% certain this was the appropriate place to test this — so if it's not let me know.
Also, I expect that test to fail (and respond a -1), though we could probably add support for it if we wanted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jonkeane commented on a change in pull request #10247: ARROW-12653: [Archery] allow me to add a comment to crossbow requests
Posted by GitBox <gi...@apache.org>.
jonkeane commented on a change in pull request #10247:
URL: https://github.com/apache/arrow/pull/10247#discussion_r629517868
##########
File path: dev/archery/archery/tests/test_bot.py
##########
@@ -156,6 +156,7 @@ def handler(command, **kwargs):
@pytest.mark.parametrize(('command', 'reaction'), [
('@ursabot build', '+1'),
+ ('@ursabot build\nwith a comment', '+1'),
Review comment:
I made ARROW-12720 I started thinking about doing that splitting, but I'm not totally sure it's a good idea to allow the command to be anywhere (or anywhere at the beginning of a newline). The current code requires that the comment [start with the mention](https://github.com/apache/arrow/blob/master/dev/archery/archery/bot.py#L110) which wasn't changed in this PR. At the very least we should discuss/decide what the boundaries ought to be there, which we can do on that ticket before changing that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on a change in pull request #10247: ARROW-12653: [Archery] allow me to add a comment to crossbow requests
Posted by GitBox <gi...@apache.org>.
kszucs commented on a change in pull request #10247:
URL: https://github.com/apache/arrow/pull/10247#discussion_r629523332
##########
File path: dev/archery/archery/tests/test_bot.py
##########
@@ -156,6 +156,7 @@ def handler(command, **kwargs):
@pytest.mark.parametrize(('command', 'reaction'), [
('@ursabot build', '+1'),
+ ('@ursabot build\nwith a comment', '+1'),
Review comment:
SGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jonkeane closed pull request #10247: ARROW-12653: [Archery] allow me to add a comment to crossbow requests
Posted by GitBox <gi...@apache.org>.
jonkeane closed pull request #10247:
URL: https://github.com/apache/arrow/pull/10247
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #10247: ARROW-12653: [Archery] allow me to add a comment to crossbow requests
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #10247:
URL: https://github.com/apache/arrow/pull/10247#issuecomment-832203360
https://issues.apache.org/jira/browse/ARROW-12653
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org