Re: Problems after update SA 2.64 => 3.0.4

[Justin Mason <jm...@jmason.org>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1


Theo Van Dinter writes:
> On Mon, Jun 20, 2005 at 09:09:24PM -0700, Loren Wilton wrote:
> > Theo, I thought the warning on rule name length and description
> > length had either been eliminated to drastically lengthened for
> > non-English rules.	Or was this only in the 3.1 stream?  I know
> > there was work done on this somewhere.
> 
> I don't believe anything was changed about this.  The 3.1 code, for instance,
> still looks for 50 chars:
> 
>   while ( ($k,$v) = each %{$conf->{tests}} ) {
>     if ($conf->{lint_rules}) {
>       if (length($k) > 50 && $k !~ /^__/ && $k !~ /^T_/) {
>         warn "config: warning: rule name '$k' is over 50 chars\n";
>         $conf->{errors}++;
>       }
>     }
>     [...]
>   }

3.1 no longer complains about descriptions over (what was it?) 70 chars --
it does complain about overlong rule names, but descriptions have a much
higher limit now iirc.  So that aspect shouldn't be a problem for
translators in 3.1.

- --j.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.5 (GNU/Linux)
Comment: Exmh CVS

iD8DBQFCuEUgMJF5cimLx9ARAsl6AJsF7/nvftfVY2f1g5SpBCfy+rTS9ACfZmTu
zH79kb9zGARYypaKp/CK7qo=
=PCy6
-----END PGP SIGNATURE-----

Re: Problems after update SA 2.64 => 3.0.4

[Loren Wilton <lw...@earthlink.net>]

> Theo Van Dinter writes:
>>
> > I don't believe anything was changed about this.  The 3.1 code, for
instance,
> > still looks for 50 chars:
> >
> >   while ( ($k,$v) = each %{$conf->{tests}} ) {
> >     if ($conf->{lint_rules}) {
> >       if (length($k) > 50 && $k !~ /^__/ && $k !~ /^T_/) {
> >         warn "config: warning: rule name '$k' is over 50 chars\n";
> >         $conf->{errors}++;
> >       }
> >     }
> >     [...]
> >   }
>
> 3.1 no longer complains about descriptions over (what was it?) 70 chars --
> it does complain about overlong rule names, but descriptions have a much
> higher limit now iirc.  So that aspect shouldn't be a problem for
> translators in 3.1.
>
> - --j.

Hum.  If the code Theo shows actually is from 3.1, then it either needs to
be bypassed for non-english rules, or it is a place that got missed in the
70-character change and needs to be fixed.

Is this something that should have a BZ ticket to make sure it gets checked?

        Loren

Re: Problems after update SA 2.64 => 3.0.4

[Theo Van Dinter <fe...@apache.org>]

On Tue, Jun 21, 2005 at 09:49:36AM -0700, Justin Mason wrote:
> >         warn "config: warning: rule name '$k' is over 50 chars\n";
> 
> 3.1 no longer complains about descriptions over (what was it?) 70 chars --
> it does complain about overlong rule names, but descriptions have a much
> higher limit now iirc.  So that aspect shouldn't be a problem for
> translators in 3.1.

Aha -- I missed that the code line said "rule name".  I kind of saw the
warning and the "50 chars" bit and skipped the part in the middle. <G>
Sorry.

-- 
Randomly Generated Tagline:
Stand on the toilet, get high on pot.