You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by mg...@apache.org on 2013/11/25 14:42:28 UTC

[1/2] git commit: WICKET-5425 WicketTester doesn't preserve the request cookies when #executeListener() is used

Updated Branches:
  refs/heads/master 296d552d7 -> d707e78a0


WICKET-5425 WicketTester doesn't preserve the request cookies when #executeListener() is used

No need to create a new request. Just set the calculated url to the scheduled request.


Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/105a4f2f
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/105a4f2f
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/105a4f2f

Branch: refs/heads/master
Commit: 105a4f2f9de6e643c5196bd15ef194f9290d34a1
Parents: 296d552
Author: Martin Tzvetanov Grigorov <mg...@apache.org>
Authored: Mon Nov 25 14:38:32 2013 +0100
Committer: Martin Tzvetanov Grigorov <mg...@apache.org>
Committed: Mon Nov 25 14:39:58 2013 +0100

----------------------------------------------------------------------
 .../main/java/org/apache/wicket/util/tester/BaseWicketTester.java  | 2 --
 1 file changed, 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/wicket/blob/105a4f2f/wicket-core/src/main/java/org/apache/wicket/util/tester/BaseWicketTester.java
----------------------------------------------------------------------
diff --git a/wicket-core/src/main/java/org/apache/wicket/util/tester/BaseWicketTester.java b/wicket-core/src/main/java/org/apache/wicket/util/tester/BaseWicketTester.java
index 21be99c..5e78cb5 100644
--- a/wicket-core/src/main/java/org/apache/wicket/util/tester/BaseWicketTester.java
+++ b/wicket-core/src/main/java/org/apache/wicket/util/tester/BaseWicketTester.java
@@ -1048,8 +1048,6 @@ public class BaseWicketTester
 			component.getPage(), component), listener);
 
 		Url url = urlFor(handler);
-		MockHttpServletRequest request = new MockHttpServletRequest(application, httpSession,
-			servletContext);
 		request.setUrl(url);
 
 		// Process the request


[2/2] git commit: Fix a typo in comments

Posted by mg...@apache.org.
Fix a typo in comments


Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/d707e78a
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/d707e78a
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/d707e78a

Branch: refs/heads/master
Commit: d707e78a0c6629a1851f4fa1c330a9add8888c4c
Parents: 105a4f2
Author: Martin Tzvetanov Grigorov <mg...@apache.org>
Authored: Mon Nov 25 14:42:06 2013 +0100
Committer: Martin Tzvetanov Grigorov <mg...@apache.org>
Committed: Mon Nov 25 14:42:06 2013 +0100

----------------------------------------------------------------------
 .../main/java/org/apache/wicket/util/tester/BaseWicketTester.java  | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/wicket/blob/d707e78a/wicket-core/src/main/java/org/apache/wicket/util/tester/BaseWicketTester.java
----------------------------------------------------------------------
diff --git a/wicket-core/src/main/java/org/apache/wicket/util/tester/BaseWicketTester.java b/wicket-core/src/main/java/org/apache/wicket/util/tester/BaseWicketTester.java
index 5e78cb5..58eec83 100644
--- a/wicket-core/src/main/java/org/apache/wicket/util/tester/BaseWicketTester.java
+++ b/wicket-core/src/main/java/org/apache/wicket/util/tester/BaseWicketTester.java
@@ -386,7 +386,7 @@ public class BaseWicketTester
 				CookieCollection responseCookies = new CookieCollection();
 
 				// if the last request is a redirect, all cookies from last response should appear
-				// in current reponse
+				// in current response
 				// this call will filter duplicates
 				responseCookies.addAll(lastResponseCookies);
 				for (Cookie cookie : responseCookies.allAsList())