[jira] [Updated] (PIG-2871) Refactor signature for PigReducerEstimator

["Bill Graham (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/PIG-2871?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bill Graham updated PIG-2871:
-----------------------------

    Attachment: PIG-2871.1.patch

Here's a patch with the proposed refactor.
                
> Refactor signature for PigReducerEstimator
> ------------------------------------------
>
>                 Key: PIG-2871
>                 URL: https://issues.apache.org/jira/browse/PIG-2871
>             Project: Pig
>          Issue Type: Bug
>    Affects Versions: 0.11
>            Reporter: Bill Graham
>            Assignee: Bill Graham
>         Attachments: PIG-2871.1.patch
>
>
> The signature to this method should be refactored to provide more context so the implementer has access to the map and reduce plans. Also passing both {{Job}} and {{Configuration}} is redundant, since the latter can be obtained by the former.
> I propose changing this:
> {noformat}
> int estimateNumberOfReducers(Configuration conf, List<POLoad> lds, Job job) throws IOException;
> {noformat}
> To this:
> {noformat}
> int estimateNumberOfReducers(Job job, List<POLoad> lds, MapReduceOper mapReduceOper) throws IOException;
> {noformat}
> This interface is evolving and hasn't yet been released so this is safe.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira