[Impala-ASF-CR] IMPALA-8589: Re-enable flaky test query event hooks.py

["radford nguyen (Code Review)" <ge...@cloudera.org>]

radford nguyen has posted comments on this change. ( http://gerrit.cloudera.org:8080/13713 )

Change subject: IMPALA-8589: Re-enable flaky test_query_event_hooks.py
......................................................................


Patch Set 9:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/13713/9/tests/custom_cluster/test_query_event_hooks.py
File tests/custom_cluster/test_query_event_hooks.py:

http://gerrit.cloudera.org:8080/#/c/13713/9/tests/custom_cluster/test_query_event_hooks.py@49
PS9, Line 49:                                      expected_count=-1)
This test no longer checks for the execution of `onQueryComplete`... it only checks that `onImpalaStartup` is called, which is not a query event hook at all, really.

I think we still need coverage for `onQueryComplete` because it executes on the thread pool executor, which is different than `onImpalaStartup`



-- 
To view, visit http://gerrit.cloudera.org:8080/13713
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia64550e986b5eba59a1d77657943932bb977d470
Gerrit-Change-Number: 13713
Gerrit-PatchSet: 9
Gerrit-Owner: Fredy Wijaya <fr...@apache.org>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fr...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: radford nguyen <ra...@gmail.com>
Gerrit-Comment-Date: Mon, 08 Jul 2019 20:32:17 +0000
Gerrit-HasComments: Yes