You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Venkat Ranganathan <n....@live.com> on 2013/01/23 00:29:39 UTC
Review Request: Fix for SQOOP-840
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9058/
-----------------------------------------------------------
Review request for Sqoop and Jarek Cecho.
Summary (updated)
-----------------
Fix for SQOOP-840
Description (updated)
-------
Fix generics usage so that the classes have right generics declarations - Otherwise, some of the classees show up with errors when using eclipse
This addresses bug SQOOP-840.
https://issues.apache.org/jira/browse/SQOOP-840
Diffs
-----
src/java/com/cloudera/sqoop/mapreduce/ExportOutputFormat.java 48c352b
src/java/org/apache/sqoop/mapreduce/ExportBatchOutputFormat.java 20fc844
src/java/org/apache/sqoop/mapreduce/OracleExportOutputFormat.java 8e9cf1d
src/java/org/apache/sqoop/mapreduce/SQLServerExportOutputFormat.java 1b39519
src/java/org/apache/sqoop/mapreduce/sqlserver/SqlServerExportBatchOutputFormat.java f47d475
Diff: https://reviews.apache.org/r/9058/diff/
Testing (updated)
-------
Ran all existing unit tests - No new functionality added so no new tests
Thanks,
Venkat Ranganathan
Re: Review Request: Fix for SQOOP-840
Posted by Jarek Cecho <ja...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9058/#review15617
-----------------------------------------------------------
Ship it!
Ship It!
- Jarek Cecho
On Jan. 23, 2013, 1:14 a.m., Venkat Ranganathan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9058/
> -----------------------------------------------------------
>
> (Updated Jan. 23, 2013, 1:14 a.m.)
>
>
> Review request for Sqoop and Jarek Cecho.
>
>
> Description
> -------
>
> Fix generics usage so that the classes have right generics declarations - Otherwise, some of the classees show up with errors when using eclipse
>
>
> This addresses bug SQOOP-840.
> https://issues.apache.org/jira/browse/SQOOP-840
>
>
> Diffs
> -----
>
> src/java/com/cloudera/sqoop/mapreduce/ExportOutputFormat.java 48c352b
> src/java/org/apache/sqoop/mapreduce/ExportBatchOutputFormat.java 20fc844
> src/java/org/apache/sqoop/mapreduce/OracleExportOutputFormat.java 8e9cf1d
> src/java/org/apache/sqoop/mapreduce/SQLServerExportOutputFormat.java 1b39519
> src/java/org/apache/sqoop/mapreduce/sqlserver/SqlServerExportBatchOutputFormat.java f47d475
>
> Diff: https://reviews.apache.org/r/9058/diff/
>
>
> Testing
> -------
>
> Ran all existing unit tests - No new functionality added so no new tests
>
>
> Thanks,
>
> Venkat Ranganathan
>
>
Re: Review Request: Fix for SQOOP-840
Posted by Venkat Ranganathan <n....@live.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9058/
-----------------------------------------------------------
(Updated Jan. 23, 2013, 1:14 a.m.)
Review request for Sqoop and Jarek Cecho.
Changes
-------
Fixed line endings
Description
-------
Fix generics usage so that the classes have right generics declarations - Otherwise, some of the classees show up with errors when using eclipse
This addresses bug SQOOP-840.
https://issues.apache.org/jira/browse/SQOOP-840
Diffs (updated)
-----
src/java/com/cloudera/sqoop/mapreduce/ExportOutputFormat.java 48c352b
src/java/org/apache/sqoop/mapreduce/ExportBatchOutputFormat.java 20fc844
src/java/org/apache/sqoop/mapreduce/OracleExportOutputFormat.java 8e9cf1d
src/java/org/apache/sqoop/mapreduce/SQLServerExportOutputFormat.java 1b39519
src/java/org/apache/sqoop/mapreduce/sqlserver/SqlServerExportBatchOutputFormat.java f47d475
Diff: https://reviews.apache.org/r/9058/diff/
Testing
-------
Ran all existing unit tests - No new functionality added so no new tests
Thanks,
Venkat Ranganathan
Re: Review Request: Fix for SQOOP-840
Posted by Venkat Ranganathan <n....@live.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9058/#review15605
-----------------------------------------------------------
- Venkat Ranganathan
On Jan. 22, 2013, 11:29 p.m., Venkat Ranganathan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9058/
> -----------------------------------------------------------
>
> (Updated Jan. 22, 2013, 11:29 p.m.)
>
>
> Review request for Sqoop and Jarek Cecho.
>
>
> Description
> -------
>
> Fix generics usage so that the classes have right generics declarations - Otherwise, some of the classees show up with errors when using eclipse
>
>
> This addresses bug SQOOP-840.
> https://issues.apache.org/jira/browse/SQOOP-840
>
>
> Diffs
> -----
>
> src/java/com/cloudera/sqoop/mapreduce/ExportOutputFormat.java 48c352b
> src/java/org/apache/sqoop/mapreduce/ExportBatchOutputFormat.java 20fc844
> src/java/org/apache/sqoop/mapreduce/OracleExportOutputFormat.java 8e9cf1d
> src/java/org/apache/sqoop/mapreduce/SQLServerExportOutputFormat.java 1b39519
> src/java/org/apache/sqoop/mapreduce/sqlserver/SqlServerExportBatchOutputFormat.java f47d475
>
> Diff: https://reviews.apache.org/r/9058/diff/
>
>
> Testing
> -------
>
> Ran all existing unit tests - No new functionality added so no new tests
>
>
> Thanks,
>
> Venkat Ranganathan
>
>
Re: Review Request: Fix for SQOOP-840
Posted by Jarek Cecho <ja...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9058/#review15603
-----------------------------------------------------------
Hi Venkat,
Thank you very much for fixing this. I've noticed that couple of lines are ending with whitespace character. Would you mind removing those?
Jarcec
src/java/org/apache/sqoop/mapreduce/ExportBatchOutputFormat.java
<https://reviews.apache.org/r/9058/#comment33697>
Nit: Trailing white space characters.
src/java/org/apache/sqoop/mapreduce/OracleExportOutputFormat.java
<https://reviews.apache.org/r/9058/#comment33698>
Nit: Trailing white space characters.
src/java/org/apache/sqoop/mapreduce/SQLServerExportOutputFormat.java
<https://reviews.apache.org/r/9058/#comment33699>
Nit: Trailing white space characters.
src/java/org/apache/sqoop/mapreduce/sqlserver/SqlServerExportBatchOutputFormat.java
<https://reviews.apache.org/r/9058/#comment33700>
Nit: Trailing white space characters.
- Jarek Cecho
On Jan. 22, 2013, 11:29 p.m., Venkat Ranganathan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9058/
> -----------------------------------------------------------
>
> (Updated Jan. 22, 2013, 11:29 p.m.)
>
>
> Review request for Sqoop and Jarek Cecho.
>
>
> Description
> -------
>
> Fix generics usage so that the classes have right generics declarations - Otherwise, some of the classees show up with errors when using eclipse
>
>
> This addresses bug SQOOP-840.
> https://issues.apache.org/jira/browse/SQOOP-840
>
>
> Diffs
> -----
>
> src/java/com/cloudera/sqoop/mapreduce/ExportOutputFormat.java 48c352b
> src/java/org/apache/sqoop/mapreduce/ExportBatchOutputFormat.java 20fc844
> src/java/org/apache/sqoop/mapreduce/OracleExportOutputFormat.java 8e9cf1d
> src/java/org/apache/sqoop/mapreduce/SQLServerExportOutputFormat.java 1b39519
> src/java/org/apache/sqoop/mapreduce/sqlserver/SqlServerExportBatchOutputFormat.java f47d475
>
> Diff: https://reviews.apache.org/r/9058/diff/
>
>
> Testing
> -------
>
> Ran all existing unit tests - No new functionality added so no new tests
>
>
> Thanks,
>
> Venkat Ranganathan
>
>