You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "adoroszlai (via GitHub)" <gi...@apache.org> on 2023/02/28 13:52:48 UTC
[GitHub] [ozone] adoroszlai opened a new pull request, #4327: HDDS-8044. Ensure GrpcOutputStream is closed
adoroszlai opened a new pull request, #4327:
URL: https://github.com/apache/ozone/pull/4327
## What changes were proposed in this pull request?
`GrpcOutputStream` is created for replicating container between datanodes. It is passed into `TarContainerPacker`, which closes it after writing files of the container.
If an exception happens before `TarContainerPacker#pack` is called (e.g. container not found), `GrpcOutputStream` is left open.
This patch ensures the stream is closed even in such cases. This applies to pull replication. Push replication already has such logic:
https://github.com/apache/ozone/blob/25ad1f2a4fc944cff098c22edaea1bd9e08344ba/hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/replication/PushReplicator.java#L79
https://issues.apache.org/jira/browse/HDDS-8044
## How was this patch tested?
Added unit test.
https://github.com/adoroszlai/hadoop-ozone/actions/runs/4292108894
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] kerneltime merged pull request #4327: HDDS-8044. Ensure GrpcOutputStream is closed
Posted by "kerneltime (via GitHub)" <gi...@apache.org>.
kerneltime merged PR #4327:
URL: https://github.com/apache/ozone/pull/4327
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org