[GitHub] [spark] LuciferYang commented on a diff in pull request #42092: [SPARK-44496][SQL][CONNECT] Move Interfaces needed by SCSC to sql/api

["LuciferYang (via GitHub)" <gi...@apache.org>]

LuciferYang commented on code in PR #42092:
URL: https://github.com/apache/spark/pull/42092#discussion_r1324738993


##########
project/MimaExcludes.scala:
##########
@@ -174,6 +174,35 @@ object MimaExcludes {
     ProblemFilters.exclude[MissingClassProblem]("org.apache.spark.sql.types.ObjectType"),
     ProblemFilters.exclude[MissingClassProblem]("org.apache.spark.sql.types.ObjectType$"),
 
+    // SPARK-44496: Move Interfaces needed by SCSC to sql/api.
+    ProblemFilters.exclude[MissingClassProblem]("org.apache.spark.sql.Encoder"),

Review Comment:
   @amaliujia Apologies for the late comment. Why were these `ProblemFilters` placed in `defaultExcludes` instead of `v35excludes`? Will they never be involved in the Mima check again?
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org