[jira] [Commented] (YARN-9400) Remove unnecessary if at EntityGroupFSTimelineStore#parseApplicationId

["Abhishek Modi (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/YARN-9400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16920624#comment-16920624 ] 

Abhishek Modi commented on YARN-9400:
-------------------------------------

Thanks [~Prabhu Joseph]. lgtm. will commit to trunk.

> Remove unnecessary if at EntityGroupFSTimelineStore#parseApplicationId
> ----------------------------------------------------------------------
>
>                 Key: YARN-9400
>                 URL: https://issues.apache.org/jira/browse/YARN-9400
>             Project: Hadoop YARN
>          Issue Type: Improvement
>    Affects Versions: 3.2.0
>            Reporter: Prabhu Joseph
>            Assignee: Prabhu Joseph
>            Priority: Minor
>         Attachments: YARN-9400-001.patch
>
>
> If clause to validate whether appIdStr starts with "application" is not required at EntityGroupFSTimelineStore#parseApplicationId
> {code}
>  // converts the String to an ApplicationId or null if conversion failed
>   private static ApplicationId parseApplicationId(String appIdStr) {
>     ApplicationId appId = null;
>     if (appIdStr.startsWith(ApplicationId.appIdStrPrefix)) {
>       try {
>         appId = ApplicationId.fromString(appIdStr);
>       } catch (IllegalArgumentException e) {
>         appId = null;
>       }
>     }
>     return appId;
>   }
> {code}



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org