[GitHub] KellenSunderland edited a comment on issue #13310: [MXNET-703] Update TensorRT to v5 ONNX IR to v3. Fix inference bugs.

[GitBox <gi...@apache.org>]

KellenSunderland edited a comment on issue #13310: [MXNET-703] Update TensorRT to v5 ONNX IR to v3.  Fix inference bugs.
URL: https://github.com/apache/incubator-mxnet/pull/13310#issuecomment-441385511
 
 
   @marcoabreu Would appreciate it if you could have a quick look at the Jenkins modifications and make sure I'm not breaking anything.  (Review of other stuff also appreciated but not required).  The reason for a Jenkins change is a switch from make to cmake, which builds the libmxnet.so bin in build instead of lib if following the conventions of our other cmake projects.
   
   Edit: Actually another thing to note.  I found that the version of cmake installed by CI has a bug currently with CUDA 10.  I'm sure they'll (cmake devs) publish a fix, but in the mean time I've installed a later version which doesn't have the bug.  If you want I can move this into a separate PR (which this PR would then have a dep on to pass).  
   
   See comments
   # Note: we specify an exact cmake version to work around a cmake 3.10 CUDA 10 issue.
   # Reference: https://github.com/clab/dynet/issues/1457

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services