You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by "BUAAserein (via GitHub)" <gi...@apache.org> on 2023/07/28 08:19:28 UTC
[GitHub] [iotdb] BUAAserein opened a new pull request, #10723: [IOTDB-6061] Fix the instability failure caused by initServer in IoTConsensus UT not binding to the corresponding port
BUAAserein opened a new pull request, #10723:
URL: https://github.com/apache/iotdb/pull/10723
### Description
see [jira](https://issues.apache.org/jira/browse/IOTDB-6061)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] OneSizeFitsQuorum merged pull request #10723: [IOTDB-6061] Fix the instability failure caused by initServer in IoTConsensus UT not binding to the corresponding port
Posted by "OneSizeFitsQuorum (via GitHub)" <gi...@apache.org>.
OneSizeFitsQuorum merged PR #10723:
URL: https://github.com/apache/iotdb/pull/10723
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] OneSizeFitsQuorum commented on a diff in pull request #10723: [IOTDB-6061] Fix the instability failure caused by initServer in IoTConsensus UT not binding to the corresponding port
Posted by "OneSizeFitsQuorum (via GitHub)" <gi...@apache.org>.
OneSizeFitsQuorum commented on code in PR #10723:
URL: https://github.com/apache/iotdb/pull/10723#discussion_r1277284875
##########
iotdb-core/consensus/src/test/java/org/apache/iotdb/consensus/iot/ReplicateTest.java:
##########
@@ -87,12 +98,35 @@ public void tearDown() throws Exception {
}
}
+ public void changeConfiguration(int i) {
+ try (PublicBAOS publicBAOS = new PublicBAOS();
+ DataOutputStream outputStream = new DataOutputStream(publicBAOS)) {
+ outputStream.writeInt(this.peers.size());
+ for (Peer peer : this.peers) {
+ peer.serialize(outputStream);
+ }
+ File storageDir = new File(peersStorage.get(i).getAbsolutePath(), "1_1");
Review Comment:
use `buildPeerDir(storageDir, groupId);`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] BUAAserein commented on a diff in pull request #10723: [IOTDB-6061] Fix the instability failure caused by initServer in IoTConsensus UT not binding to the corresponding port
Posted by "BUAAserein (via GitHub)" <gi...@apache.org>.
BUAAserein commented on code in PR #10723:
URL: https://github.com/apache/iotdb/pull/10723#discussion_r1277300799
##########
iotdb-core/consensus/src/test/java/org/apache/iotdb/consensus/iot/ReplicateTest.java:
##########
@@ -87,12 +98,35 @@ public void tearDown() throws Exception {
}
}
+ public void changeConfiguration(int i) {
+ try (PublicBAOS publicBAOS = new PublicBAOS();
+ DataOutputStream outputStream = new DataOutputStream(publicBAOS)) {
+ outputStream.writeInt(this.peers.size());
+ for (Peer peer : this.peers) {
+ peer.serialize(outputStream);
+ }
+ File storageDir = new File(peersStorage.get(i).getAbsolutePath(), "1_1");
Review Comment:
OK
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org